Re: [PATCH v4 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-07 Thread Stefan Schaeckeler (sschaeck)
> Adding AST2400 and AST2600 edac driver support. > > Signed-off-by: Troy Lee Reviewed-by: Stefan Schaeckeler > --- drivers/edac/Kconfig | 6 +++--- > drivers/edac/aspeed_edac.c | 7 +-- > 2 files changed, 8 insertions(+), 5 deletions(-) > diff --git a/drivers/edac/Kconfig

Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-07 Thread Stefan Schaeckeler (sschaeck)
Hello Troy, > Hi Stefan, > > The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off > from u-boot and check if driver runs correctly. I noticed now most changes are these "exports". As you removed them a later revision, the patch looks now lean and clean. I'll give you my

Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-11-30 Thread Stefan Schaeckeler (sschaeck)
Hello Troy, > Adding AST2400 and AST2600 edac driver support. > > Signed-off-by: Troy Lee > --- > drivers/edac/Kconfig | 6 +- > drivers/edac/aspeed_edac.c | 114 + > 2 files changed, 94 insertions(+), 26 deletions(-) Uh, there are quite some

Re: [PATCH 01/17] ARM: dts: aspeed-g5: Move EDAC node to APB

2019-07-29 Thread Stefan Schaeckeler (sschaeck)
On Thursday, July 25, 2019 at 10:40 PM, Andrew Jeffery wrote: > Previously the register interface was not attached to any internal bus, > which is not correct - it lives on the APB. > > Cc: Stefan M Schaeckeler > Signed-off-by: Andrew Jeffery > --- > arch/arm/boot/dts/aspeed-g5.dtsi | 14

Re: [PATCH 02/17] ARM: dts: aspeed-g5: Use recommended generic node name for SDMC

2019-07-29 Thread Stefan Schaeckeler (sschaeck)
On Thursday, July 25, 2019 at 10:40 PM, Andrew Jeffery wrote: > The EDAC is a sub-function of the SDRAM Memory Controller. Rename the > node to the appropriate generic node name. > > Cc: Stefan M Schaeckeler > Signed-off-by: Andrew Jeffery > --- > arch/arm/boot/dts/aspeed-g5.dtsi | 2 +- > 1

Re: [PATCH -next] EDAC: aspeed: Remove set but not used variable 'np'

2019-05-28 Thread Stefan Schaeckeler (sschaeck)
On Tuesday, May 28, 2019 at 6:27 PM, Andrew Jeffery wrote: > On Sun, 26 May 2019, at 00:12, YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > drivers/edac/aspeed_edac.c: In function aspeed_probe: > > drivers/edac/aspeed_edac.c:284:22: warning: variable np set but not >