[PATCH] staging: bcm2835-camera: Add TODO for removing overlay support

2018-05-10 Thread Stefan Schake
The overlay code is non-functional since it relies on firmware control of the HVS. Signed-off-by: Stefan Schake --- Dave, does this match your understanding? drivers/staging/vc04_services/bcm2835-camera/TODO | 8 1 file changed, 8 insertions(+) diff --git a/drivers/staging

Re: [PATCH] drm/vc4: Add a pad field to align drm_vc4_submit_cl to 64 bits.

2018-04-30 Thread Stefan Schake
On Tue, May 1, 2018 at 1:59 AM, Eric Anholt wrote: > I had originally asked Stefan Schake to drop the pad field from the > syncobj changes that just landed, because I couldn't come up with a > reason to align to 64 bits. > > Talking with Dave Airlie about the new v3d drive

Re: [PATCH] drm/tegra: hub: Use state directly

2018-04-30 Thread Stefan Schake
On Wed, Apr 18, 2018 at 12:40 PM, Stefan Schake wrote: > Using drm_atomic_get_private_obj_state after state has been swapped > will return old state. > > Fixes: 0281c4149021 ("drm/tegra: hub: Use private object for global state") > Signed-off-by: Stefan Schake >

[PATCH v4 1/2] drm/vc4: Add CTM support

2018-04-20 Thread Stefan Schake
scalars that we can't approximate without integer bits. Signed-off-by: Stefan Schake Signed-off-by: Eric Anholt --- Eric, I removed your r-b since there were a bunch more changes. v4: Handle CTM disabling in check Don't use drm_atomic_get_private_obj_state in commit

[PATCH v4 2/2] drm/vc4: Add CTM registers to debugfs

2018-04-20 Thread Stefan Schake
Now that we set the OLED* registers to do CTM, it's helpful to have them in the register dump. Signed-off-by: Stefan Schake --- v4: new in the series. drivers/gpu/drm/vc4/vc4_hvs.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drivers/gpu/dr

[PATCH] drm/tegra: hub: Use state directly

2018-04-18 Thread Stefan Schake
Using drm_atomic_get_private_obj_state after state has been swapped will return old state. Fixes: 0281c4149021 ("drm/tegra: hub: Use private object for global state") Signed-off-by: Stefan Schake --- drivers/gpu/drm/tegra/hub.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

Re: [PATCH] drm/vc4: Add some missing HVS register definitions.

2018-04-11 Thread Stefan Schake
gt; Signed-off-by: Eric Anholt > Cc: Stefan Schake > --- > drivers/gpu/drm/vc4/vc4_regs.h | 96 > ++ > 1 file changed, 96 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_regs.h b/drivers/gpu/drm/vc4/vc4_regs.h > index b9749cb240

[PATCH] drm/vc4: Move IRQ enable to PM path

2017-12-29 Thread Stefan Schake
we know there was a previous disable invocation during suspend. Fixes: 253696ccd613 ("drm/vc4: Account for interrupts in flight") Signed-off-by: Stefan Schake --- I tested replacing the enable/disable dance with just synchronize_irq, but that only made the original kernel OOPS

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Stefan Schake
On Tue, Nov 14, 2017 at 8:44 PM, Eric Anholt wrote: > Stefan Schake writes: > >> On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: >>> Stefan Schake writes: >>> >>>> The overflow mem work callback vc4_overflow_mem_work reenables its >>>&g

Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-14 Thread Stefan Schake
On Tue, Nov 14, 2017 at 1:18 AM, Eric Anholt wrote: > Stefan Schake writes: > >> The overflow mem work callback vc4_overflow_mem_work reenables its >> associated interrupt upon completion. To ensure all interrupts are disabled >> when we return from vc4_irq_uninstall, we

[PATCH 2/2] drm/vc4: Ensure interrupts are disabled

2017-11-09 Thread Stefan Schake
The overflow mem work callback vc4_overflow_mem_work reenables its associated interrupt upon completion. To ensure all interrupts are disabled when we return from vc4_irq_uninstall, we need to disable it again if cancel_work_sync indicated pending work. Signed-off-by: Stefan Schake --- drivers

[PATCH 1/2] drm/vc4: Account for interrupts in flight

2017-11-09 Thread Stefan Schake
vc4_overflow_mem_work. Link: https://github.com/anholt/linux/issues/114 Signed-off-by: Stefan Schake Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.") --- drivers/gpu/drm/vc4/vc4_irq.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_irq.c b/drivers/g

[PATCH 0/2] drm/vc4: Correctly uninstall interrupts

2017-11-09 Thread Stefan Schake
dereference but turned out to be unrelated. Tested with a Raspberry Pi CM 3 that was previously stuck in a boot loop due to the issue. With the patch applied, the NULL dereference was no longer observed through numerous resets. Stefan Schake (2): drm/vc4: Account for interrupts in flight drm/vc4