Re: [PATCH] s390: Fix me in dasd_eer.c

ch one is better. But today I say that the 'Operation not permitted' is more to the point. An FBA device has no (changable) medium, so what could be wrong about its type? Could be confusing. >From your patch description I do not really get why you want to change the return code. Why do you think that

Re: [PATCH] s390: Fix me in dasd_eer.c

no (changable) medium, so what could be wrong about its type? Could be confusing. From your patch description I do not really get why you want to change the return code. Why do you think that EMEDIUMTYPE is better than EPERM? Mit freundlichen Grüßen / Kind regards Stefan Weinhuber -- To unsubscribe

Re: [PATCH 0/9][v2] dasd: implement block timeout

+++- > drivers/s390/block/dasd_erp.c |8 +++ > drivers/s390/block/dasd_fba.c | 10 +++- > drivers/s390/block/dasd_int.h | 10 +++ > drivers/s390/block/dasd_ioctl.c | 59 +++ > 11 files changed, 313 insertions(+), 21 deletions(-) > > -- > 1.7.4

Re: [PATCH 0/9][v2] dasd: implement block timeout

/dasd_int.h | 10 +++ drivers/s390/block/dasd_ioctl.c | 59 +++ 11 files changed, 313 insertions(+), 21 deletions(-) -- 1.7.4.2 This patch set looks fine to me now. Thanks! Acked-by: Stefan Weinhuber w...@de.ibm.com Mit freundlichen Grüßen / Kind regards Stefan

Re: [PATCH 8/9] dasd: Add 'timeout' attribute

+ blk_queue_rq_timeout(q, device->blk_timeout * HZ); > + spin_unlock_irqrestore(>block->request_queue_lock, flags); > + > + dasd_put_device(device); > + return count; > +} > + [..] Mit freundlichen Grüßen / Kind regards Stefan Weinhuber -- Linux for zSeries kernel developm

Re: [PATCH 8/9] dasd: Add 'timeout' attribute

(device); + return count; +} + [..] Mit freundlichen Grüßen / Kind regards Stefan Weinhuber -- Linux for zSeries kernel development IBM Systems Technology Group, Systems Software Development / SW Linux für zSeries Entwicklung IBM Deutschland Schoenaicher Str. 220 71032 Boeblingen Phone: +49

Re: [PATCH 5/5] s390:block:fix up ENOIOCTLCMD error handling

if (rc == -ENOIOCTLCMD) > -rc = -EINVAL; > - } else > - rc = -EINVAL; > } > dasd_put_device(base); > return rc; > -- > 1.7.11.5 > The patch is looking fine to me, thanks. Mit freundlichen Grüßen / Kind regards Stefan Weinhube

Re: [PATCH 5/5] s390:block:fix up ENOIOCTLCMD error handling

); return rc; -- 1.7.11.5 The patch is looking fine to me, thanks. Mit freundlichen Grüßen / Kind regards Stefan Weinhuber -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http