RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

2019-08-07 Thread Steve Twiss
Hi Paul, I will not be able to make these changes to support modularity any more. Although the support.opensou...@diasemi.com e-mail address for Support is still working, I will not be able to review your patches if you were to re-send them again. Regards, Stephen On 07 December 2018 20:30, Pa

RE: [PATCH] mfd: da9063: remove now unused platform_data

2019-07-23 Thread Steve Twiss
igned-off-by: Wolfram Sang > --- > include/Kbuild | 1 - > include/linux/mfd/da9063/pdata.h | 60 > 2 files changed, 61 deletions(-) > delete mode 100644 include/linux/mfd/da9063/pdata.h Acked-by: Steve Twiss Regards, Steve

RE: [PATCH] regulator: da9062: Simplify the code iterating all regulators

2019-07-11 Thread Steve Twiss
On 11 July 2019 12:47, Axel Lin wrote: > To: Steve Twiss; Support Opensource; Liam Girdwood; > linux-kernel@vger.kernel.org > Cc: Axel Lin > Subject: [PATCH] regulator: da9062: Simplify the code iterating all regulators > > It's more straightforward to use for state

RE: [PATCH] mfd: da9063: occupy second I2C address, too

2019-06-21 Thread Steve Twiss
On 21 June 2019 11:10 Wolfram Sang wrote: > Subject: Re: [PATCH] mfd: da9063: occupy second I2C address, too > > > For what it's worth, maybe consider adding a dev_warn attached to the return > > of devm_i2c_new_dummy_device? > > I am in the middle of some API changes. Once those are over, I wan

RE: [PATCH] mfd: da9063: occupy second I2C address, too

2019-06-21 Thread Steve Twiss
Hi Wolfram, On 20 June 2019 10:21, Wolfram Sang wrote: > Subject: Re: [PATCH] mfd: da9063: occupy second I2C address, too > > > Is this a safety clause? What I mean is, shouldn't the hardware design make > > sure there are not two devices located on the same I2C bus with the same > > slave > > a

RE: [PATCH] mfd: da9063: occupy second I2C address, too

2019-06-20 Thread Steve Twiss
On 20 June 2019 13:29, Lee Jones wrote: > Subject: Re: [PATCH] mfd: da9063: occupy second I2C address, too > > Why isn't this reply attached (threaded) to the patch. My apologies. It wasn't my intention to split Wolfram's original e-mail thread. I don't usually reply using the mailto: link from

Re: [PATCH] mfd: da9063: occupy second I2C address, too

2019-06-20 Thread Steve Twiss
(resend because the e-mail client added HTML formatting to my last reply) Hi Wolfram, On Wed, 19 Jun 2019 19:18:06, Wolfram Sang wrote: > Subject: [PATCH] mfd: da9063: occupy second I2C address, too > > Even though we don't use it yet, we should mark the second I2C address > this device is list

[PATCH V4] regulator: da9061/62: Adjust LDO voltage selection minimum value

2019-06-20 Thread Steve Twiss
orrect calculaton for the n_voltages value in the regulator LDO2. These fixes effect all LDO regulators for DA9061 and DA9062. Acked-by: Steve Twiss Tested-by: Steve Twiss Signed-off-by: Felix Riemann Signed-off-by: Steve Twiss --- Patch history v2 - Fix whitespace problems, slight refact

[PATCH V3] regulator: da9061/62: Adjust LDO voltage selection minimum value

2019-06-19 Thread Steve Twiss
orrect calculaton for the n_voltages value in the regulator LDO2. These fixes effect all LDO regulators for DA9061 and DA9062. Acked-by: Steve Twiss Tested-by: Steve Twiss Signed-off-by: Steve Twiss Signed-off-by: Felix Riemann --- Hi Mark, I've added my signed-off tag to the commit

[PATCH V2] regulator: da9061/62: Adjust LDO voltage selection minimum value

2019-06-19 Thread Steve Twiss
orrect calculaton for the n_voltages value in the regulator LDO2. These fixes effect all LDO regulators for DA9061 and DA9062. Acked-by: Steve Twiss Tested-by: Steve Twiss Signed-off-by: Felix Riemann --- Hi Felix, I have taken your previous patch, fixed the whitespace like we discussed and u

RE: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value

2019-06-18 Thread Steve Twiss
Hi Felix, On 18 June 2019 12:08 Felix Riemann wrote: > Subject: AW: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum > value > > Hi Steve, > > A colleague told me that he saw our mail server mix-up whitespaces in text > mails > before, although the copy that got relayed back to

RE: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value

2019-06-13 Thread Steve Twiss
Hi Felix, On 13 June 2019 14:02, Felix Riemann wrote: > Subject: [PATCH] regulator: da9062: Adjust LDO voltage selection minimum value > > According to the datasheet the LDO's voltage selection registers have > a minimum value of 0x2. This offset was not observed by the driver, > causing the LDO

[PATCH] mfd: da9063: Fix OTP control register names to match datasheets for DA9063/63L

2019-04-26 Thread Steve Twiss
of CONT (i.e. control). Cc: Stable Signed-off-by: Steve Twiss --- include/linux/mfd/da9063/registers.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/mfd/da9063/registers.h b/include/linux/mfd/da9063/registers.h index 5d42859..844fc29 100644 --- a

RE: [PATCH 12/22] watchdog: da9063_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
da9063 *da9063; > struct watchdog_device *wdd; > > - if (!pdev->dev.parent) > + if (!dev->parent) > return -EINVAL; None of my previous Acked e-mails in this patch set considered whether the dev->parent was NULL. But this DA9063 driver does. Logically, this is correct to check, but ... any thoughts? Otherwise, Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 11/22] watchdog: da9062_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
https://github.com/groeck/coccinelle-patches > > Cc: Support Opensource > Signed-off-by: Guenter Roeck Acked-by: Steve Twiss Thanks for that, Regards, Steve

RE: [PATCH 10/22] watchdog: da9055_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
he conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > Cc: Support Opensource > Signed-off-by: Guenter Roeck Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 09/22] watchdog: da9052_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-10 Thread Steve Twiss
he conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches > > Cc: Support Opensource > Signed-off-by: Guenter Roeck Acked-by: Steve Twiss Thanks! Regards, Steve

RE: [PATCH 1/2] rtc: da9063: set range

2019-04-02 Thread Steve Twiss
Hi, > > > drivers/rtc/rtc-da9063.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c > > > index 1b792bcea3c7..53e690b0f3a2 100644 > > > --- a/drivers/rtc/rtc-da9063.c > > > +++ b/drivers/rtc/rtc-da9063.c > > > @@ -475,6 +4

RE: [RFC] ARM: dts: imx: Fix the AR803X phy-mode

2019-04-01 Thread Steve Twiss
phy-mode = "rgmii-id"; > phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; > status = "okay"; > }; [...] This patch looks surprisingly similar to this one ;) https://lore.kernel.org/patchwork/patch/1052588/ Link: https://lkml.kernel.org/r/1397

RE: [PATCH 5/6] mfd: da9063: remove leftover platform_data definitions

2019-03-29 Thread Steve Twiss
--- > 1 file changed, 65 deletions(-) > delete mode 100644 include/linux/mfd/da9063/pdata.h > > diff --git a/include/linux/mfd/da9063/pdata.h Thanks! Acked-by: Steve Twiss Tested-by: Steve Twiss Regards, Steve

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-22 Thread Steve Twiss
Here are my thoughts. On 22 March 2019 10:21, Michal Vokáč wrote: > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > On 22. 03. 19 3:24, Fabio Estevam wrote: > > On Thu, Mar 21, 2019 at 11:15 PM Shawn Guo wrote: > > > >>> Unfortunately, just by looking at

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-21 Thread Steve Twiss
Hi Fabio, On 21 March 2019 11:17, Fabio Estevam, > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old

RE: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Steve Twiss
Hi Fabio, On 20 March 2019 12:17, Fabio Estevam wrote: > Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use > rgmii-id > > Hi Steve, > > On Wed, Mar 20, 2019 at 9:06 AM Steve Twiss > wrote: > > > > The PHY used on the Freescale i.MX6

[PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id

2019-03-20 Thread Steve Twiss
delays in this case). This patch fixes the network problems seen on the Freescale i.MX6Q/DL SABRE boards and makes a difference when correctly loading the NFS rootfs on startup. Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazz...@free-electrons.com Tested-by: Steve Tw

RE: [PATCH v2] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
On 18 March 2019 16:41, Dmitry Osipenko wrote: > Subject: Re: [PATCH v2] regulator: core: fix error path for > regulator_set_voltage_unlocked [...] > Reviewed-by: Dmitry Osipenko Thanks Dmitry. Regards, Steve

[PATCH v2] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
that case, -22 is expected as the return value, not 0. Fixes: 9243a195be7a ("regulator: core: Change voltage setting path") Cc: stable Signed-off-by: Steve Twiss --- drivers/regulator/core.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/regulator

RE: [PATCH] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
Hi Dmitry, Thanks, On 18 March 2019 16:03, Dmitry Osipenko wrote: > Subject: Re: [PATCH] regulator: core: fix error path for > regulator_set_voltage_unlocked > > 18.03.2019 18:32, Steve Twiss пишет: > > During several error paths in the function > > regulator_set_volt

[PATCH] regulator: core: fix error path for regulator_set_voltage_unlocked

2019-03-18 Thread Steve Twiss
that case, -22 is expected as the return value, not 0. Fixes: 9243a195be7a ("regulator: core: Change voltage setting path") Signed-off-by: Steve Twiss --- drivers/regulator/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regula

RE: [PATCH 2/2] regulator: da9055: Convert to regulator core's simplified DT parsing code

2019-03-18 Thread Steve Twiss
Hi Mark, For the DA9055, I have spoken with the management here. Dialog Semiconductor are "no longer building the DA9055"; the device doesn't appear on the support portal or website and; I have been told, "you can remove [it] from your list of supported products". But, as always: I realise that t

RE: [PATCH] regulator: da9052: Include linux/of.h to fix build warning for of_match_ptr

2019-03-18 Thread Steve Twiss
nings when !CONFIG_OF. > > Reported-by: kbuild test robot > Signed-off-by: Axel Lin Thanks! Acked-by: Steve Twiss Regards, Steve

[PATCH 06/13] regulator: ltc3589: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 3eb2c7ecb7ea ("regulator: Add LTC3589 support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/ltc3589.c | 10

[PATCH 01/13] regulator: da9055: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: f6130be652d0 ("regulator: DA9055 regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/da9055-regulator.c | 2

[PATCH 03/13] regulator: da9063: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 69ca3e58d178 ("regulator: da9063: Add Dialog DA9063 voltage regulators support.") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers

[PATCH 04/13] regulator: da9211: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 1028a37daa14 ("regulator: da9211: new regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/da9211-regul

[PATCH 02/13] regulator: da9062: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 4068e5182ada ("regulator: da9062: DA9062 regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/da9062-regul

[PATCH 05/13] regulator: lp8755: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: b59320cc5a5e ("regulator: lp8755: new driver for LP8755") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/lp8

[PATCH 08/13] regulator: pv88060: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/pv88060-regul

[PATCH 13/13] regulator: wm831x ldo: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: d1c6b4fe668b ("regulator: Add WM831x LDO support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/wm831x-ldo.c | 2 ++ 1 fi

[PATCH 09/13] regulator: pv88080: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 99cf3af5e2d5 ("regulator: pv88080: new regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/pv88080-regul

[PATCH 07/13] regulator: ltc3676: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: 37b918a034fe ("regulator: Add LTC3676 support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/ltc3676.c | 10

[PATCH 10/13] regulator: pv88090: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: c90456e36d9c ("regulator: pv88090: new regulator driver") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/pv88090-regul

[PATCH 11/13] regulator: wm831x: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: e4ee831f949a ("regulator: Add WM831x DC-DC buck convertor support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/wm831x-

[PATCH 00/13] Fix backtrace warnings from bad notifier chain calls

2019-03-05 Thread Steve Twiss
while, but the API I have used used here to fix it (i.e. regulator_lock()/regulator_unlock()) has only been in the kernel since v4.18. Therefore as this fix stands, the patches do not port back very far in kernel history. Regards, Steve Steve Twiss (13): regulator: da9055: Fix notifier mutex

[PATCH 12/13] regulator: wm831x isink: Fix notifier mutex lock warning

2019-03-05 Thread Steve Twiss
regulator_notifier_call_chain() when that function call is first made. The mutex can be controlled using the regulator_lock/unlock() API. Fixes: d4d6b722e780 ("regulator: Add WM831x ISINK support") Suggested-by: Adam Thomson Signed-off-by: Steve Twiss --- drivers/regulator/wm831x-isink.c | 2

RE: [PATCH 2/2] regulator: da9063: Convert to use regulator_set/get_current_limit_regmap

2019-03-05 Thread Steve Twiss
--- > drivers/regulator/da9063-regulator.c | 107 +++ > 1 file changed, 28 insertions(+), 79 deletions(-) Thanks again, Acked-by: Steve Twiss Regards, Steve ps. This patch applies to next-20190305. But doesn't cleanly apply cleanly to v5.0, I guess because t

RE: [PATCH 1/2] regulator: da9062: Convert to use regulator_set/get_current_limit_regmap

2019-03-05 Thread Steve Twiss
Hi Axel, On 04 March 2019 13:16, Axel Lin wrote: > Subject: [PATCH 1/2] regulator: da9062: Convert to use > regulator_set/get_current_limit_regmap > > Use regulator_set/get_current_limit_regmap helpers to save some code. Thanks again, Acked-by: Steve Twiss Regards, Steve ps.

RE: [PATCH 10/11] regulator: pv88090: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
.limit_mask = PV88090_##regl_name##_ILIM_MASK, \ > .conf = PV88090_REG_##regl_name##_CONF1, \ > .conf2 = PV88090_REG_##regl_name##_CONF2, \ Acked-by: Steve Twiss ; Thanks, Regards, Steve

RE: [PATCH 09/11] regulator: pv88080: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
On 28 February 2019 13:40, Axel Lin wrote: > Subject: [PATCH 09/11] regulator: pv88080: Convert to use > regulator_set/get_current_limit_regmap > > Use regulator_set/get_current_limit_regmap helpers to save some code. [...] Hi Axel, Looks good to me. Thanks again. Acked-by:

RE: [PATCH 08/11] regulator: pv88060: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
On 28 February 2019 13:40, Axel Lin wrote: > Subject: [PATCH 08/11] regulator: pv88060: Convert to use > regulator_set/get_current_limit_regmap > > Use regulator_set/get_current_limit_regmap helpers to save some code. [...] Hi Axel, Looks good to me. Thanks again. Acked-by:

RE: [PATCH 03/11] regulator: da9055: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
CK_LIM,\ > + .csel_mask = (mbits),\ Hi Axel, Thanks. Acked-by: Steve Twiss Regards, Steve

RE: [PATCH 04/11] regulator: da9210: Convert to use regulator_set/get_current_limit_regmap

2019-02-28 Thread Steve Twiss
or_set_current_limit_regmap, > + .get_current_limit = regulator_get_current_limit_regmap, > }; Hi Axel, Thanks, Acked-by: Steve Twiss Regards, Steve

RE: [PATCH] regulator: da9062: Use struct_size() in devm_kzalloc()

2019-02-25 Thread Steve Twiss
ese open-coded and prone to type mistakes, we can > now use the new struct_size() helper: Acked-by: Steve Twiss Thanks, Regards, Steve > > instance = alloc(struct_size(instance, entry, count), GFP_KERNEL) > > Notice that, in this case, variable size is not necessary, hence i

RE: [PATCH] regulator: da9063: Use struct_size() in devm_kzalloc()

2019-02-25 Thread Steve Twiss
ese open-coded and prone to type mistakes, we can > now use the new struct_size() helper: Acked-by: Steve Twiss Thanks, Regards, Steve

RE: [PATCH 1/2] regulator: da9062: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Steve Twiss
nfo = regl->info; > int n, tval; > > - for (n = 0; n < rinfo->n_current_limits; n++) { > + for (n = rinfo->n_current_limits - 1; n >= 0; n--) { > tval = rinfo->current_limits[n]; > if (tval >= min_ua && tval <=

RE: [PATCH 2/2] regulator: da9063: Select maximum current in specific range for set_current_limit

2019-02-19 Thread Steve Twiss
gl->info; > int n, tval; > > - for (n = 0; n < rinfo->n_current_limits; n++) { > + for (n = rinfo->n_current_limits - 1; n >= 0; n--) { > tval = rinfo->current_limits[n]; > if (tval >= min_uA && tval <= max_uA) > return regmap_field_write(regl->ilimit, n); Acked-by: Steve Twiss

RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2019-01-08 Thread Steve Twiss
gmap-irq.c > > @@ -258,7 +258,7 @@ static int regmap_irq_set_type(struct irq_data *data, > unsigned int type) > > const struct regmap_irq_type *t = &irq_data->type; > > > > if ((t->types_supported & type) != type) > > - return

RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2019-01-07 Thread Steve Twiss
Hi Geert, On 04 January 2019 at 15:48, Geert Uytterhoeven wrote: > To: Steve Twiss > Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type > settings > > ()Hi Steve, > > On Wed, Jan 2, 2019 at 4:31 PM Steve Twiss > wrote: > > On 01 January 2

RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

2019-01-02 Thread Steve Twiss
Hi Geert, On 01 January 2019 @17:36, Geert Uytterhoeven wrote: > Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type > settings > On Mon, Dec 31, 2018 at 8:14 PM Mark Brown wrote: > > On Sat, Dec 29, 2018 at 12:13:32PM +0100, Geert Uytterhoeven wrote: > > > > Geert, do you

RE: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

2018-12-11 Thread Steve Twiss
E_ATTR(_name, 0444, _func##_show, NULL, _index) Acked-by: Steve Twiss Regards, Steve > --- > 1 file changed, 39 insertions(+), 66 deletions(-) > > diff --git a/drivers/hwmon/da9052-hwmon.c b/drivers/hwmon/da9052-hwmon.c > index a973eb6a2890..8ec5bf4ce392 100644 > --- a/drivers

RE: [PATCH 22/30] hwmon: (da9055-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

2018-12-11 Thread Steve Twiss
e-patches/hwmon/. > > This patch does not introduce functional changes. It was verified by > compiling the old and new files and comparing text and data sizes. > > Cc: Support Opensource > Signed-off-by: Guenter Roeck > --- Thanks, Same again. Acked-by: Ste

RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

2018-12-05 Thread Steve Twiss
Sorry typo. I meant modular. On 05 December 2018 12:02, Steve Twiss wrote: > Subject: RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers > > Hi Paul, > > On 03 December 2018 04:23, Paul Gortmaker wrote: > > > Subject: [PATCH v2 00/22] mfd: demodul

RE: [PATCH v2 00/22] mfd: demodularization of non-modular drivers

2018-12-05 Thread Steve Twiss
Hi Paul, On 03 December 2018 04:23, Paul Gortmaker wrote: > Subject: [PATCH v2 00/22] mfd: demodularization of non-modular drivers > > [v1 --> v2: add some more commits as requested by Lee (MFD maintainer), > update the 00/NN text; re-do build and link testing on new linux-next. ] > > This gro

RE: [PATCH] Input: add error handling for da9052_reg_write

2018-06-11 Thread Steve Twiss
On 11 June 2018 18:30 wrote Dmitry Torokhov > Subject: Re: [PATCH] Input: add error handling for da9052_reg_write > > Hi Zhouyang, > > On Mon, Jun 11, 2018 at 01:23:39PM +0800, Zhouyang Jia wrote: > > When da9052_reg_write fails, the lack of error-handling code may > > cause unexpected results.

RE: [PATCH v3 07/10] mfd: da9063: Add custom IRQ map for DA9063L

2018-06-05 Thread Steve Twiss
-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Lee Jones > Cc: Mark Brown > Cc: Steve Twiss > Cc: Wolfram Sang > Cc: linux-renesas-...@vger.kernel.org > --- > V3: New patch > --- > drivers/mfd/da9063-irq.c | 55 >

RE: [PATCH v3 03/10] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-06-05 Thread Steve Twiss
>> have to be made using DT or otherwise. > >> > >> Signed-off-by: Marek Vasut > >> Cc: Geert Uytterhoeven > >> Cc: Lee Jones > >> Cc: Mark Brown > >> Cc: Steve Twiss > >> Cc: Wolfram Sang > >> Cc: linux-renesas-...@vge

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-24 Thread Steve Twiss
On 24 May 2018 15:51 Marek Vasut wrote: Hi Marek, > To: Steve Twiss ; linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Wolfram Sang ; > linux-renesas-...@vger.kernel.org > Subject: Re: [PATCH 6/6] mfd: da9063: Add DA9063L sup

RE: [PATCH 3/6] mfd: da9063: Add DA9063L type

2018-05-24 Thread Steve Twiss
On 23 May 2018 12:42 Marek Vasut wrote: > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: [PATCH 3/6] mfd: da9063: Add DA9063L type > &

RE: [PATCH 4/6] mfd: da9063: Disallow RTC on DA9063L

2018-05-24 Thread Steve Twiss
Thanks Marek, On 23 May 2018 12:42 Marek Vasut wrote, > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: [PATCH 4/6] mfd: da9063: Disallow RTC

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-24 Thread Steve Twiss
Hi Marek, On 24 May 2018 @ 12:49 Steve Twiss wrote: > To: Marek Vasut ; linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: RE: [PATCH 6/6] mfd: d

RE: [PATCH 1/6] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063

2018-05-24 Thread Steve Twiss
Hi Marek, On 23 May 2018 12:42 Marek Vasut wrote: > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; Lee Jones ; Mark Brown > ; Steve Twiss ; Wolfram > Sang ; linux-renesas-...@vger.kernel.org > Subject: [PATCH 1/6] mfd: da9063: Ren

RE: [PATCH 6/6] mfd: da9063: Add DA9063L support

2018-05-24 Thread Steve Twiss
Thanks Marek, > On 23 May 2018 12:43 Marek Vasut wrote, > > To: linux-kernel@vger.kernel.org > Cc: Marek Vasut ; Geert Uytterhoeven > ; > Lee Jones ; Mark Brown ; Steve > Twiss ; > Wolfram Sang ; > linux-renesas-...@vger.kernel.org > Subject: [PATCH 6/6] mf

[PATCH V1] mfd: da9062: use core helper regmap_reg_range macros

2018-03-28 Thread Steve Twiss
From: Steve Twiss Replace multi-line entries in the regmap_range arrays with single line macros: regmap_reg_range(). This will leave the static structure array entries for regmap_range unaltered. It will significantly reduce the line count in the DA9062/61 core file. Signed-off-by: Steve Twiss

RE: [PATCH 000/100] rtc: remove cargo culted code

2018-03-02 Thread Steve Twiss
On 02 March 2018 08:57, Alexandre Belloni wrote: > To: Steve Twiss > Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH 000/100] rtc: remove cargo culted code > > On 02/03/2018 at 08:46:48 +0000, Steve Twiss wrote: > > Hi Alexandre, > &g

RE: [PATCH 000/100] rtc: remove cargo culted code

2018-03-02 Thread Steve Twiss
ted from other drivers Hi Alexandre, Acked for: rtc: da9063: stop validating rtc_time in .read_time rtc: da9052: stop validating rtc_time in .read_time rtc: da9055: stop validating rtc_time in .read_time Acked-by: Steve Twiss Agreed -- rtc_valid_tm() call is cargo cult for the above. (By

RE: [PATCH v4] watchdog: add SPDX identifiers for watchdog subsystem

2018-03-01 Thread Steve Twiss
On 28 February 2018 15:02, Marcus Folkesson wrote: > Subject: [PATCH v4] watchdog: add SPDX identifiers for watchdog subsystem > > - Add SPDX identifier > - Remove boiler plate license text > - If MODULE_LICENSE and boiler plate does not match, go for boiler plate > licens

RE: [PATCH] hwmon: da9052 Increase sample rate when using TSI

2017-10-20 Thread Steve Twiss
reg_update(hwmon->da9052, DA9052_ADC_CONT_REG, > + DA9052_ADCCONT_ADCMODE, > + DA9052_ADCCONT_ADCMODE); > + Acked-by: Steve Twiss According to the DA9053 Datasheet, Revision 2.1, 31-Aug-2016, Section 18.3, page

[PATCH V1] MAINTAINERS: Fix Dialog search term for watchdog binding file

2017-09-12 Thread Steve Twiss
From: Steve Twiss Commit 340267640d769d3b3af9 ("MAINTAINERS: da9062/61 updates to the Dialog Semiconductor search terms") contained a typo for the watchdog binding: da92??-wdt.txt should have read da90??-wdt.txt. This new commit will fix the error and allows Dialog Semiconductor to fo

RE: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT register from chip model"

2017-08-21 Thread Steve Twiss
On 21 August 2017 08:50, Lee Jones wrote: Hi Lee, > To: Steve Twiss > Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT > register from chip model" > > On Tue, 15 Aug 2017,

RE: [PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from chip model

2017-08-14 Thread Steve Twiss
On 06 June 2017 08:16, Lee Jones wrote: Hi Lee, > To: Steve Twiss > Cc: LINUX-KERNEL; Support Opensource > Subject: Re: [PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from > chip model > > On Mon, 05 Jun 2017, Steve Twiss wrote: > > > From: Steve Twiss

RE: [PATCH 2/2] hwmon: da9052: add support for TSI channel

2017-06-28 Thread Steve Twiss
Hi Sebastian, On 26 June 2017 15:49 Sebastian Reichel wrote: > Subject: [PATCH 2/2] hwmon: da9052: add support for TSI channel > > TSI channel has a 4 channel mux connected to it and is normally > used for touchscreen support. The hardware may alternatively > use it as general purpose adc. > > S

RE: [PATCH 14/51] rtc: da9063: stop using rtc deprecated functions

2017-06-20 Thread Steve Twiss
Hi Benjamin, On 20 June 2017 10:35, Benjamin Gaignard wrote: > Subject: [PATCH 14/51] rtc: da9063: stop using rtc deprecated functions Probably this subject should be "rtc: da9052" not 63. > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that wi

RE: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Steve Twiss
Hi Pavel, On 20 June 2017 14:26, Pavel Machek wrote: > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote:

RE: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular

2017-06-07 Thread Steve Twiss
Hi Paul, On 06 June 2017 21:23, Paul Gortmaker wrote: > Subject: Re: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular > > > >As always, the option exists for someone with the hardware and the > > > desire > > >to extend the functionality to make any given driver tristate. But >

RE: [RESEND PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator driver

2017-06-07 Thread Steve Twiss
Hi Mark, On 07 June 2017 10:42, Mark Brown wrote: > Subject: Re: [RESEND PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator > driver > > On Wed, Jun 07, 2017 at 09:13:48AM +0100, Steve Twiss wrote: > > From: Steve Twiss > > > > Regulator support for the D

[RESEND PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator driver

2017-06-07 Thread Steve Twiss
From: Steve Twiss Regulator support for the DA9061 is added into the DA9062 regulator driver. The regulators for DA9061 differ from those of DA9062. A new DA9061 enumeration list for the LDOs and Bucks supported by this device is added. Regulator information added: the old regulator

RE: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular

2017-06-06 Thread Steve Twiss
Hi Paul, On 05 June 2017 20:30, Paul Gortmaker wrote: > Subject: Re: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular > > [RE: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular] > On 05/06/2017 (Mon 10:30) Steve Twiss wrote: > > > On 03 June 2017 14:04

[PATCH V1] mfd: da9061: fix to remove BBAT_CONT register from chip model

2017-06-05 Thread Steve Twiss
From: Steve Twiss Remove the register DA9062AA_BBAT_CONT (0x0C5) from the DA9061 chip model regmap access ranges. This applies to both da9061_aa_readable_ranges[] and da9061_aa_writeable_ranges[]. This change is to correct the DA9061 chip model and align it with the latest DA9061 Datasheet

RE: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular

2017-06-05 Thread Steve Twiss
Hi Paul, On 03 June 2017 14:04 Paul Gortmaker wrote: > To: linux-kernel@vger.kernel.org > Cc: Paul Gortmaker; Support Opensource; Lee Jones; Eric Miao; Mike Rapoport > Subject: [PATCH 1/4] mfd: da903x: Make it explicitly non-modular > > The Kconfig currently controlling compilation of this code

RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-24 Thread Steve Twiss
Hi Fabio, On 24 May 2017 14:53 Fabio Estevam wrote, > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD > and RI irqs to be off > On Wed, May 24, 2017 at 9:49 AM, Steve Twiss wrote: > > > I used this tag: jb4.3_1.1.1-ga > > http://git.freesc

RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-24 Thread Steve Twiss
Hi Fabio, On 24 May 2017 12:53 Fabio Estevam wrote: > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD > and RI irqs to be off > On Wed, May 24, 2017 at 7:32 AM, Steve Twiss wrote: > > > The USB to UART connection gets corrupted. > > If this

RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-24 Thread Steve Twiss
Hi Fabio, On 23 May 2017 17:26 Fabio Estevam wrote: > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD > and RI irqs to be off > On Tue, May 23, 2017 at 9:17 AM, Steve Twiss wrote: > > > > Revert the commit e61c38d85b7392e ("serial: i

RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-24 Thread Steve Twiss
Hi Uwe, On 23 May 2017 17:09, Uwe Kleine-König wrote: > On Tue, May 23, 2017 at 03:01:26PM +0000, Steve Twiss wrote: > > On 23 May 2017 15:37, Uwe Kleine-König wrote: > > > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure > > > DCD and RI

RE: [RESEND PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator driver

2017-05-24 Thread Steve Twiss
On 23 May 2017 18:17 Mark Brown > To: Steve Twiss > Subject: Re: [RESEND PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator > driver > > On Tue, May 23, 2017 at 02:40:45PM +0100, Steve Twiss wrote: > > > This patch was Acked by Mark Brown, a long time ago, way bac

RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-23 Thread Steve Twiss
Hi Uwe, On 23 May 2017 15:37, Uwe Kleine-König wrote: > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD > and RI irqs to be off > On Tue, May 23, 2017 at 02:28:11PM +0000, Steve Twiss wrote: > > On 23 May 2017 15:10, Uwe Kleine-König wrote: >

RE: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-23 Thread Steve Twiss
Hi Uwe, Thanks for your quick response. On 23 May 2017 15:10, Uwe Kleine-König wrote: > Subject: Re: [PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD > and RI irqs to be off > On Tue, May 23, 2017 at 01:17:26PM +0100, Steve Twiss wrote: > > > > Revert the c

[RESEND PATCH V7 7/7] MAINTAINERS: da9062/61 updates to the Dialog Semiconductor search terms

2017-05-23 Thread Steve Twiss
From: Steve Twiss Additions to search terms for files supported by Dialog Semiconductor. This update will allow Dialog support to follow files for device tree bindings (onkey, thermal and watchdog) and source code for chip thermal monitoring drivers. Signed-off-by: Steve Twiss --- Hi all, Is

[RESEND PATCH V7 5/7] regulator: da9061: BUCK and LDO regulator driver

2017-05-23 Thread Steve Twiss
From: Steve Twiss Regulator support for the DA9061 is added into the DA9062 regulator driver. The regulators for DA9061 differ from those of DA9062. A new DA9061 enumeration list for the LDOs and Bucks supported by this device is added. Regulator information added: the old regulator

[PATCH V1] serial: imx: revert setup DCEDTE early and ensure DCD and RI irqs to be off

2017-05-23 Thread Steve Twiss
From: Steve Twiss Revert the commit e61c38d85b7392e ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off") The patch submitted to setup DCEDTE early and ensure DCD and RI irqs to be off, causes a serial console display problem the i.MX6Q SABRESD board. The conso

RE: [PATCH V7 4/7] mfd: da9061: MFD core support

2017-04-24 Thread Steve Twiss
On 04 April 2017 09:39, Lee Jones wrote: > Subject: Re: [PATCH V7 4/7] mfd: da9061: MFD core support > > On Mon, 03 Apr 2017, Steve Twiss wrote: > > From: Steve Twiss > > MFD support for DA9061 is provided as part of the DA9062 device driver. > > > > The regist

[RESEND PATCH V7 1/5] Documentation: devicetree: watchdog: da9062/61 watchdog timer binding

2017-04-06 Thread Steve Twiss
From: Steve Twiss Add binding information for DA9062 and DA9061 watchdog. Example bindings for both DA9062 and DA9061 devices are added. For the DA9061 device, a fallback compatible line is added as a valid combination of compatible strings. The original binding for DA9062 (only) used to

  1   2   3   4   5   >