Hi Mauro,
On Thu, Aug 27, 2020 at 10:42 AM Mauro Carvalho Chehab
wrote:
>
> Em Thu, 27 Aug 2020 08:48:30 -0700
> Steve deRosier escreveu:
>
> > On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab
> > wrote:
> > >
> > > This patch causes a regr
On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab
wrote:
>
> This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore:
> with it applied, WiFi stops working, and the Kernel starts printing
> this message every second:
>
>wlcore: PHY firmware version: Rev 8.2.0.0.242
>wlcore:
On Mon, Aug 17, 2020 at 6:43 PM Tang Bin wrote:
>
> Hi Kalle：
>
> 在 2020/8/17 22:26, Kalle Valo 写道:
> >> In the function ath10k_ahb_clock_init(), devm_clk_get() doesn't
> >> return NULL. Thus use IS_ERR() and PTR_ERR() to validate
> >> the returned value instead of IS_ERR_OR_NULL().
> > Why? What'
On Fri, May 22, 2020 at 2:51 PM Luis Chamberlain wrote:
>
> On Fri, May 22, 2020 at 10:46:07PM +0200, Johannes Berg wrote:
> > FWIW, I still completely disagree on that taint. You (Luis) obviously
> > have been running into a bug in that driver, I doubt the firmware
> > actually managed to wedge t
On Mon, May 18, 2020 at 7:00 AM Bean Huo wrote:
>
> From: Bean Huo
>
> On some legacy planar 2D Micron NAND devices when a block erase command
I object the use of the qualifications you're putting in this
sentence. By saying "some legacy" you're implying that there's a
set that does and a se
On Mon, May 18, 2020 at 10:19 AM Luis Chamberlain wrote:
>
> On Mon, May 18, 2020 at 10:15:45AM -0700, Ben Greear wrote:
> >
> >
> > On 05/18/2020 10:09 AM, Luis Chamberlain wrote:
> > > On Mon, May 18, 2020 at 09:58:53AM -0700, Ben Greear wrote:
> > > >
> > > >
> > > > On 05/18/2020 09:51 AM, Lui
+ goto err_init_adapter;
> +
> + if (priv->fwrelease < LBTF_FW_VER_MIN ||
> + priv->fwrelease > LBTF_FW_VER_MAX) {
> + goto err_init_adapter;
> + }
> +
> /* The firmware seems to start with the radio enabled. Turn it
> * off before an actual mac80211 start callback is invoked.
> */
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
riate to initialize it first. While I expect there's no chance
of a race as the
mac80211 start callback hasn't been invoked yet, superficially it
looks like there could be.
> + lbtf_set_radio_control(priv);
> +
> if (ieee80211_register_hw(hw))
> goto err_init_adapter;
>
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
eturns: pointer to struct lbtf_priv.
> */
> -struct lbtf_private *lbtf_add_card(void *card, struct device *dmdev)
> +struct lbtf_private *lbtf_add_card(void *card, struct device *dmdev,
> + const struct lbtf_ops *ops)
> {
> struct ieee80211_hw *hw;
> struct lbtf_private *priv = NULL;
> @@ -622,6 +623,7 @@ struct lbtf_private *lbtf_add_card(void *card, struct
> device *dmdev)
>
> priv->hw = hw;
> priv->card = card;
> + priv->ops = ops;
> priv->tx_skb = NULL;
>
> hw->queues = 1;
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
hw->queues = 1;
> ieee80211_hw_set(hw, HOST_BROADCAST_PS_BUFFERING);
> + ieee80211_hw_set(hw, SIGNAL_DBM);
> hw->extra_tx_headroom = sizeof(struct txpd);
> memcpy(priv->channels, lbtf_channels, sizeof(lbtf_channels));
> memcpy(priv->rates, lbtf_rates, sizeof(lbtf_rates));
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
> @@ -649,6 +648,7 @@ struct lbtf_private *lbtf_add_card(void *card, struct
> device *dmdev)
> if (ieee80211_register_hw(hw))
> goto err_init_adapter;
>
> + dev_info(dmdev, "libertastf: Marvell WLAN 802.11 thinfirm adapter\n");
> goto done;
>
> err_init_adapter:
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
p;cardp->udev->dev, "Pointer for rx_urb %p\n",
> cardp->rx_urb);
> ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
",
> +respcmd, le16_to_cpu(resp->seqnum),
> +le16_to_cpu(resp->size));
>
> if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
> spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.20.1
>
Reviewed-by: Steve deRosier
>
> len -= ie_len;
> data += ie_len;
> - };
> + }
>
> ret = 0;
> out:
For ath6kl
Acked-by: Steve deRosier
break;
> case WMI_11AGN_CAP:
> ht = true;
> + /* fall through */
> case WMI_11AG_CAP:
> band_2gig = true;
> band_5gig = true;
> --
> 2.7.4
Gustavo,
Thanks for the adjustment. It now looks good to me.
Reviewed-by: Steve deRosier
On Tue, Apr 10, 2018 at 7:47 AM, Geert Uytterhoeven
wrote:
> Hi Marek,
>
> On Tue, Apr 10, 2018 at 4:37 PM, Marek Vasut wrote:
>> On 04/10/2018 03:26 PM, Geert Uytterhoeven wrote:
>>> On Mon, Apr 9, 2018 at 11:59 PM, Marek Vasut wrote:
On 04/09/2018 02:25 PM, Geert Uytterhoeven wrote:
>
8.33.18
That's the most basic setup, check the man page for more options.
You will get best results if you can exclude other computers from your
test network and other wireless devices from your airspace.
- Steve
--
Steve deRosier
Cal-Sierra Consulting LLC
https://www.cal-sierra.com/
Hi Pavel,
On Wed, Mar 7, 2018 at 1:43 PM, Pavel Machek wrote:
> On Wed 2018-03-07 09:01:16, Richard Weinberger wrote:
>> Pavel,
>>
>> Am Mittwoch, 7. März 2018, 00:18:05 CET schrieb Pavel Machek:
>> > On Sat 2018-03-03 11:45:54, Richard Weinberger wrote:
>> > > While UBI and UBIFS seem to work at
atic struct usb_device_id ath6kl_usb_ids[] = {
> +static const struct usb_device_id ath6kl_usb_ids[] = {
> {USB_DEVICE(0x0cf3, 0x9375)},
> {USB_DEVICE(0x0cf3, 0x9374)},
> { /* Terminating entry */ },
> --
> 2.7.4
>
Looks good. Also builds and works properly.
Reviewed-by: Steve deRosier
Tested-by: Steve deRosier
- Steve
action = ep->ep_cb.tx_full(ep->target,
> packet);
> if (action == HTC_SEND_FULL_DROP) {
> --
> 2.11.0
>
Looks good to me.
Reviewed-by: Steve deRosier
- Steve
On Fri, Mar 31, 2017 at 10:45 AM, Joe Perches wrote:
> On Fri, 2017-03-31 at 10:34 -0700, Steve deRosier wrote:
>> On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote:
>> > On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote:
>> > > On Thu, Mar 30, 2017
On Fri, Mar 31, 2017 at 10:23 AM, Joe Perches wrote:
> On Fri, 2017-03-31 at 10:19 -0700, Steve deRosier wrote:
>> On Thu, Mar 30, 2017 at 3:57 PM, Joe Perches wrote:
>> > Fix fallout too.
> []
>> My only question is why bother doing a format check on something
>>
tion on the clauses that get
compiled out?"
So, it looks good to me as is, or if you feel like making the change
I'm suggesting, that's fine too. And it builds and runs on my
platforms.
Reviewed-by: Steve deRosier
- Steve
Hi,
On Wed, Aug 10, 2016 at 12:07 AM, Amitkumar Karwar wrote:
> Hi Brian,
>
>> From: Brian Norris [mailto:briannor...@chromium.org]
>> Sent: Wednesday, August 10, 2016 12:14 AM
>> To: Amitkumar Karwar
>> Cc: linux-wirel...@vger.kernel.org; Cathy Luo; Nishant Sarmukadam;
>> linux-kernel@vger.kerne
24 matches
Mail list logo
