Re: [PATCH v3] tuntap: add flow control to support back pressure

2014-04-14 Thread Steven Galgano
On 04/14/2014 09:31 AM, Michael S. Tsirkin wrote: > On Mon, Apr 14, 2014 at 09:21:47AM -0400, Steven Galgano wrote: >> Added optional per queue flow control support using IFF_FLOW_CONTROL. When >> the >> IFF_FLOW_CONTROL TUNSETIFF flag is specified it will set a per queue

[PATCH v3] tuntap: add flow control to support back pressure

2014-04-14 Thread Steven Galgano
IFF_MULTI_QUEUE, IFF_FLOW_CONTROL will apply to the single queue. No changes were made to the default drop frame policy. This change adds support for back pressure use cases. Reported-by: Brian Adamson Tested-by: Joseph Giovatto Signed-off-by: Steven Galgano --- Version 3 patch reformatted commit

Re: [PATCH v2] tuntap: add flow control to support back pressure

2014-04-13 Thread Steven Galgano
On 04/13/2014 09:40 PM, David Miller wrote: > From: Steven Galgano > Date: Sun, 13 Apr 2014 21:30:27 -0400 > >> Added optional per queue flow control support using IFF_FLOW_CONTROL. When >> the IFF_FLOW_CONTROL TUNSETIFF flag is specified it will set a per queue >>

[PATCH v2] tuntap: add flow control to support back pressure

2014-04-13 Thread Steven Galgano
IFF_MULTI_QUEUE, IFF_FLOW_CONTROL will apply to the single queue. No changes were made to the default drop frame policy. This change adds support for back pressure use cases. Reported-by: Brian Adamson Tested-by: Joseph Giovatto Signed-off-by: Steven Galgano --- Previous version of patch did not

Re: [PATCH] tuntap: add flow control to support back pressure

2014-04-13 Thread Steven Galgano
pecify the flow control behavior on a queue by queue basis. This would let the application decide what should happen once a queue is full: discard or netif_tx_stop_queue(). I'm not hopeful this solution will be accepted but it might be helpful to someone else. >> BTW, in my initial notic

Re: [PATCH] tuntap: add flow control to support back pressure

2014-04-10 Thread Steven Galgano
On 04/10/2014 06:29 AM, Michael S. Tsirkin wrote: > On Wed, Apr 09, 2014 at 10:19:40PM -0400, Steven Galgano wrote: >> Add tuntap flow control support for use by back pressure routing protocols. >> Setting the new TUNSETIFF flag IFF_FLOW_CONTROL, will signal resources as >>

[PATCH] tuntap: add flow control to support back pressure

2014-04-09 Thread Steven Galgano
Signed-off-by: Steven Galgano --- diff --git a/drivers/net/tun.c b/drivers/net/tun.c index ee328ba..268130c 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -783,8 +783,19 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev) * number of queues