s
otherwise indicate that it should be read-write.
Fix this by having UDF delete permissions track Linux write permissions.
Also grant UDF change attribute permission to the owner when creating a
new inode.
Reported by: Ty Young
Signed-off-by: Steven J. Magnani
---
Changes since rev 1:
UDF delete permissi
s
otherwise indicate that it should be read-write.
Fix this by granting UDF delete and change attribute permissions
to the owner when creating a new inode.
Reported by: Ty Young
Signed-off-by: Steven J. Magnani
---
--- a/fs/udf/udf_i.h2019-08-14 07:24:05.029508342 -0500
+++ b/fs/udf/udf_i.h2019-08-1
ould limit leakage of all inode blocks
on deletion.
This restricts the patch to preservation of stream data during inode
modification.
Signed-off-by: Steven J. Magnani
--- a/fs/udf/udf_i.h2019-07-26 11:35:28.257563879 -0500
+++ b/fs/udf/udf_i.h2019-08-06 14:35:55.579654263 -0500
@@ -42
ot; stream data
For this case, this partial solution reduces the number of blocks leaked
during file deletion to just one (the EFE containing the stream data).
Signed-off-by: Steven J. Magnani
--- a/fs/udf/udf_i.h2019-07-26 11:35:28.257563879 -0500
+++ b/fs/udf/udf_i.h2019-08-06 14:3
mandated for media with smaller blocks. This nonconformity
currently prevents Linux from recognizing the filesystem as UDF.
Modify the driver to tolerate a misformatted VRS on 4K media.
Signed-off-by: Steven J. Magnani
--- a/fs/udf/super.c2019-07-10 20:55:33.334359446 -0500
+++ b/fs/udf
Extract code that parses a Volume Recognition Sequence descriptor
(component), in preparation for calling it twice against different
locations in a block.
Change from v1:
Fix regression in debug logging of "open disc" condition
Signed-off-by: Steven J. Magnani
--- a/fs/udf/super.c
mandated for media with smaller blocks. This nonconformity
currently prevents Linux from recognizing the filesystem as UDF.
Modify the driver to tolerate a misformatted VRS on 4K media.
Signed-off-by: Steven J. Magnani
--- a/fs/udf/super.c2019-07-10 20:55:33.334359446 -0500
+++ b/fs/udf
Extract code that parses a Volume Recognition Sequence descriptor
(component), in preparation for calling it twice against different
locations in a block.
Signed-off-by: Steven J. Magnani
--- a/fs/udf/super.c2019-07-10 18:57:41.192852154 -0500
+++ b/fs/udf/super.c2019-07-10 20:47
the file's information length was increased.
Change since v1:
Simplified udf_do_extend_file() API, partially by factoring out its
handling of the "extending within the last file block" corner case.
Fixes: 2c948b3f86e5 ("udf: Avoid IO in udf_clear_inode")
Signed-off-b
cks.
Signed-off-by: Steven J. Magnani <st...@digidescorp.com>
---
--- a/drivers/scsi/sd.c 2017-02-24 20:29:44.510036363 -0600
+++ b/drivers/scsi/sd.c 2017-02-27 08:19:37.864786958 -0600
@@ -2066,7 +2066,7 @@ static int read_capacity_16(struct scsi_
int the_result;
int re
cks.
Signed-off-by: Steven J. Magnani
---
--- a/drivers/scsi/sd.c 2017-02-24 20:29:44.510036363 -0600
+++ b/drivers/scsi/sd.c 2017-02-27 08:19:37.864786958 -0600
@@ -2066,7 +2066,7 @@ static int read_capacity_16(struct scsi_
int the_result;
int retries = 3, reset_retr
loc space handling in udf_update_inode")
addressed one such field, but several others are required.
Signed-off-by: Steven J. Magnani
---
diff -uprN a/fs/udf/inode.c b/fs/udf/inode.c
--- a/fs/udf/inode.c2015-07-06 13:42:08.861499890 -0500
+++ b/fs/udf/inode.c2015-07-06 13:42:18.1534
in udf_update_inode)
addressed one such field, but several others are required.
Signed-off-by: Steven J. Magnani st...@digidescorp.com
---
diff -uprN a/fs/udf/inode.c b/fs/udf/inode.c
--- a/fs/udf/inode.c2015-07-06 13:42:08.861499890 -0500
+++ b/fs/udf/inode.c2015-07-06 13:42:18.153499469 -0500
Fix module parameter descriptions mentioning default values that no longer
match the code.
Signed-off-by: Steven J. Magnani
---
diff -uprN linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c
b/drivers/scsi/qla2xxx/qla_os.c
--- linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c2014-02-02
18:42
Fix module parameter descriptions mentioning default values that no longer
match the code.
Signed-off-by: Steven J. Magnani st...@digidescorp.com
---
diff -uprN linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c
b/drivers/scsi/qla2xxx/qla_os.c
--- linux-3.14-rc1/drivers/scsi/qla2xxx/qla_os.c
not require the response to
have the same length as the request, all code related to the faulty test
can be removed. If this is not the case, the test should be moved much earlier
in the function since it does not depend on any resource acquitision.
Signed-off-by: Steven J. Magnani
---
--- linux-3.13
not require the response to
have the same length as the request, all code related to the faulty test
can be removed. If this is not the case, the test should be moved much earlier
in the function since it does not depend on any resource acquitision.
Signed-off-by: Steven J. Magnani st...@digidescorp.com
On Fri, 2013-04-26 at 10:30 -0700, James Bottomley wrote:
On Fri, 2013-04-26 at 11:39 -0500, Steven J. Magnani wrote:
> > Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered
> > set_media_not_present() in a way that prevents the sd driver from
> > remembering th
On Fri, 2013-04-26 at 10:30 -0700, James Bottomley wrote:
On Fri, 2013-04-26 at 11:39 -0500, Steven J. Magnani wrote:
Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered
set_media_not_present() in a way that prevents the sd driver from
remembering that a non-removable device has
esent" whether the device has
declared itself "removable" or not.
Signed-off-by: Steven J. Magnani
---
--- a/drivers/scsi/sd.c 2013-04-12 14:16:12.252531097 -0500
+++ b/drivers/scsi/sd.c 2013-04-12 14:21:55.197216521 -0500
@@ -1298,10 +1298,8 @@ out:
static void set_
declared itself removable or not.
Signed-off-by: Steven J. Magnani st...@digidescorp.com
---
--- a/drivers/scsi/sd.c 2013-04-12 14:16:12.252531097 -0500
+++ b/drivers/scsi/sd.c 2013-04-12 14:21:55.197216521 -0500
@@ -1298,10 +1298,8 @@ out:
static void set_media_not_present(struct scsi_disk *sdkp
hh. Thanks for the tip; I hadn't thought to look there since I found
the ext_csd under debugfs.
------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my
hadn't thought to look there since I found
the ext_csd under debugfs.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include
Oct 28 2011 /etc/posfix.old/master.cf
>
> # ls -ld /etc/postfix.old
> ls: cannot access /etc/postfix.old: No such file or directory
This is not the same directory (posTfix).
------------
Steven J. Magnani &qu
/master.cf
# ls -ld /etc/postfix.old
ls: cannot access /etc/postfix.old: No such file or directory
This is not the same directory (posTfix).
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com
.
> The OS i am using is ubuntu-11.10 amd64.
I can't speak for Ubuntu, but on Fedora installing gtk3-devel eliminated
the message you describe.
------------
Steven J. Magnani "I claim this network for MARS!
www.digide
.
I can't speak for Ubuntu, but on Fedora installing gtk3-devel eliminated
the message you describe.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space
me/drop_caches I guess there is
a hole.
------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include
--
To unsubscribe from this
there is
a hole.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include standard.disclaimer
--
To unsubscribe from this list: send the line
orking their way towards
mainline. I recognize that not everyone can take advantage of
client-side features, but options (2) and (3) make life worse for those
who can.
------------
Steven J. Magnani "I claim this network f
features, but options (2) and (3) make life worse for those
who can.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include
l cry ESTALE
despite the server's best efforts.
------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include standard.disclaimer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
urn (c >= 'A' && c <= 'Z') ? tolower(c) : c;
But now it's less efficient because tolower() does an unnecessary lookup
to see if it's supposed to change the value. _tolower() wouldn't have
that issue, but it's marked "Do not use in your code".
--
() wouldn't have
that issue, but it's marked Do not use in your code.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include
Not everyone can afford a Lexus.
------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
by: Steven J. Magnani
--------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include
--
To unsubscribe from this list: send
).
Reviewed-by: Steven J. Magnani st...@digidescorp.com
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include standard.disclaimer
.
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include standard.disclaimer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
t; long)blkdev_max_block(I_BDEV(bdev->bd_inode)));
> + dump_stack();
> + return NULL;
> + }
>
> for (;;) {
> struct buffer_head * bh;
> _
This fixes the hang, but I'm not sure dump_stack() is a good idea. I get
driver than the
FAT filesystem...
------------
Steven J. Magnani "I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!"
#include
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
...
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com Earthling, return my space modulator!
#include standard.disclaimer
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
get
almost 100 lines of stack dumps and error messages in my kernel log.
Also, I was a little surprised to see that mount completes successfully.
Steven J. Magnani I claim this network for MARS
to mount with 'lookupcache=none'.
It's not an exhaustive test by any means, just a data point for you.
Thanks!
Lightly-tested-by: Steve Magnani
----
Steven J. Magnani "I claim this network for MARS!
www.d
with 'lookupcache=none'.
It's not an exhaustive test by any means, just a data point for you.
Thanks!
Lightly-tested-by: Steve Magnani st...@digidescorp.com
Steven J. Magnani I claim this network for MARS!
www.digidescorp.com
ported via NFS are not saddled with maintenance of an index
they will never use.
Finally, simplify NFS file handle generation and lookups.
An ext2-congruent implementation is adequate for FAT needs.
Signed-off-by: Steven J. Magnani
---
diff -uprN a/fs/fat/dir.c b/fs/fat/dir.c
--- a/fs/fat/dir.c
Move NFS-related code into its own C file.
No functional changes.
Signed-off-by: Steven J. Magnani
---
diff -uprN a/fs/fat/fat.h b/fs/fat/fat.h
--- a/fs/fat/fat.h 2012-07-09 08:33:25.206615179 -0500
+++ b/fs/fat/fat.h 2012-07-10 09:10:14.064615822 -0500
@@ -341,6 +341,20 @@ extern int
Under memory pressure, the system may evict dentries from cache.
When the FAT driver receives a NFS request involving an evicted dentry,
it is unable to reconnect it to the filesystem root.
This causes the request to fail, often with ENOENT.
This is partially due to ineffectiveness of the
Under memory pressure, the system may evict dentries from cache.
When the FAT driver receives a NFS request involving an evicted dentry,
it is unable to reconnect it to the filesystem root.
This causes the request to fail, often with ENOENT.
This is partially due to ineffectiveness of the
Move NFS-related code into its own C file.
No functional changes.
Signed-off-by: Steven J. Magnani st...@digidescorp.com
---
diff -uprN a/fs/fat/fat.h b/fs/fat/fat.h
--- a/fs/fat/fat.h 2012-07-09 08:33:25.206615179 -0500
+++ b/fs/fat/fat.h 2012-07-10 09:10:14.064615822 -0500
@@ -341,6
are not saddled with maintenance of an index
they will never use.
Finally, simplify NFS file handle generation and lookups.
An ext2-congruent implementation is adequate for FAT needs.
Signed-off-by: Steven J. Magnani st...@digidescorp.com
---
diff -uprN a/fs/fat/dir.c b/fs/fat/dir.c
--- a/fs/fat
On Tue, 2012-07-10 at 06:34 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> >> Ah, i_ino. I was talking about i_pos. Well, so, what happens if the
> >> child was renamed to other parent on NFS server machine (not via nfs
> >> client)?
On Tue, 2012-07-10 at 04:10 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> >> > >> > Interesting idea. I think this, and reformulating the FAT NFS file
> >> > >> > handle to include the parent's i_ino, will greatly
On Mon, 2012-07-09 at 12:09 -0500, Steven J. Magnani wrote:
> On Mon, 2012-07-09 at 11:27 -0500, Steven J. Magnani wrote:
> > On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote:
> > > If the inode is not on cache anymore, is there the possibility that
> > > sel
On Mon, 2012-07-09 at 11:27 -0500, Steven J. Magnani wrote:
> On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote:
> > "Steven J. Magnani" writes:
> >
> > > On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote:
> > >> "Steven J.
On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> > On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote:
> >> "Steven J. Magnani" writes:
> >>
> >> >> We need the key, possible
On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> >> We need the key, possible key is - if it is only directory, FAT may be
> >> able to use i_start as additional search key.
> >
> > Interesting idea. I
On Sun, 2012-07-08 at 02:00 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> >> You mean the unhashed inode is created by ->get_parent()? If so, the
> >> root cause sounds like ->get_parent() itself. If not, I'm not
> >> understand
On Sun, 2012-07-08 at 02:00 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
You mean the unhashed inode is created by -get_parent()? If so, the
root cause sounds like -get_parent() itself. If not, I'm not
understanding the meaning of the temporary/unofficial
On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
We need the key, possible key is - if it is only directory, FAT may be
able to use i_start as additional search key.
Interesting idea. I think this, and reformulating the FAT NFS
On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
We need the key, possible key is - if it is only directory, FAT may
On Mon, 2012-07-09 at 11:27 -0500, Steven J. Magnani wrote:
On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
On Mon, 2012-07-09 at 22:43 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
We
On Mon, 2012-07-09 at 12:09 -0500, Steven J. Magnani wrote:
On Mon, 2012-07-09 at 11:27 -0500, Steven J. Magnani wrote:
On Tue, 2012-07-10 at 01:10 +0900, OGAWA Hirofumi wrote:
If the inode is not on cache anymore, is there the possibility that
selects the wrong parent? IIRC, NFS
On Tue, 2012-07-10 at 04:10 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
Interesting idea. I think this, and reformulating the FAT NFS file
handle to include the parent's i_ino, will greatly simplify (and
speed
up) the code.
Does
On Tue, 2012-07-10 at 06:34 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
Ah, i_ino. I was talking about i_pos. Well, so, what happens if the
child was renamed to other parent on NFS server machine (not via nfs
client)? The file handle would be including
On Sat, 2012-07-07 at 15:03 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> > On Sat, 2012-07-07 at 06:07 +0900, OGAWA Hirofumi wrote:
> >> "Steven J. Magnani" writes:
> >>
> >> > On Wed, 2012-07-04 at 20:07 +0900,
On Sat, 2012-07-07 at 15:03 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
On Sat, 2012-07-07 at 06:07 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote:
Please don't
On Sat, 2012-07-07 at 06:07 +0900, OGAWA Hirofumi wrote:
> "Steven J. Magnani" writes:
>
> > On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote:
> >> Please don't add new lock_super() usage if it is not necessary. Almost
> >> all of lock_s
On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote:
> Please don't add new lock_super() usage if it is not necessary. Almost
> all of lock_super() just replaced lock_kernel() usage. It rather should
> be removed in future. Probably, this should use inode->i_mutex instead.
>
> BTW, the
On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote:
Please don't add new lock_super() usage if it is not necessary. Almost
all of lock_super() just replaced lock_kernel() usage. It rather should
be removed in future. Probably, this should use inode-i_mutex instead.
BTW, the above
On Sat, 2012-07-07 at 06:07 +0900, OGAWA Hirofumi wrote:
Steven J. Magnani st...@digidescorp.com writes:
On Wed, 2012-07-04 at 20:07 +0900, OGAWA Hirofumi wrote:
Please don't add new lock_super() usage if it is not necessary. Almost
all of lock_super() just replaced lock_kernel() usage
71 matches
Mail list logo
