Re: [PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

The sizeof(u32) is hardcoded. IMO it's better to use the config value in regmap. Thanks 在 2021/1/21 下午5:21, Marc Kleine-Budde 写道: On Thu, Jan 21, 2021 at 05:10:05PM +0800, Su Yanjun wrote: Please describe why you change this. No functional effect. Not quite: scripts/bloat-o-meter

Re: [PATCH v1] can: mcp251xfd: use regmap_bulk_write for compatibility

在 2021/1/22 下午3:26, Marc Kleine-Budde 写道: On 1/22/21 4:02 AM, Su Yanjun wrote: Recently i use mcp2518fd on 4.x kernel which multiple write is not backported, regmap_raw_write will cause old kernel crash because the tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead for

Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

在 2021/1/22 下午3:22, Marc Kleine-Budde 写道: On 1/22/21 7:22 AM, Su Yanjun wrote: When i debug mcp2518fd, some method to track registers is needed. This easy debug interface will be ok. NACK As the driver uses regmap, everything should be there already. To read use: | cat /sys/kernel/debug

[PATCH 4/4] Add the combined mod e for ATI SB700

From: [EMAIL PROTECTED] Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode. The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver, but now it is not necessary for Linux since the kernel has supported

RE: [PATCH 4/4] Add the combined mode for ATI SB700

[mailto:[EMAIL PROTECTED] Sent: Wednesday, May 16, 2007 3:58 PM To: Henry Su Cc: Bartlomiej Zolnierkiewicz; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; gmail_ati Subject: Re: [PATCH 4/4] Add the combined mode for ATI SB700 Henry Su wrote: > From: [EMAIL PROTECTED] > Besides those modes

[patch] Add the device IDs for A MD/ATI SB700

From: [EMAIL PROTECTED] Adding the device ID for AMD/ATI SB700. Signed-off-by:henry su <[EMAIL PROTECTED]> -- --- linux-2.6.21.1.orig/include/linux/pci_ids.h 2007-05-10 06:30:23.0 +0800 +++ linux-2.6.21.1/include/linux/pci_ids.h 2007-05

RE: [patch] Add the device IDs f or AMD/ATI SB700

necessary now. Thanks Henry -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Friday, May 25, 2007 11:00 AM To: Henry Su Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re: [patch] Add

RE: [patch] Add the device IDs f or AMD/ATI SB700

, PCI_DEVICE_ID_ATI_IXP700_IDE), }, { }, }; -Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Friday, May 25, 2007 3:13 PM To: Henry Su Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: Re

RE: [patch] Add the device IDs f or AMD/ATI SB700

Hi all, Since I am a junior linux developing engineer, I really appreciate that you tell me these informations, Thanks for your help! Brs, Henry -Original Message- From: Bartlomiej Zolnierkiewicz [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 29, 2007 4:17 AM To: Jeff Garzik Cc: Henry Su

[patch] Add the combined mode for ATI SB700

From: [EMAIL PROTECTED] Besides those modes in ATI SB600 SATA controller, ATI SB700 supports one more mode:the combined mode. \ The combined mode is a Legacy IDE mode used for compatibility with some old OS without AHCI driver, \ but now it is not necessary for Linux since the kernel has supported

[patch]add the ATI SB700 SATA controller device id to AHCI pci table

From: [EMAIL PROTECTED] Adding the device ID to AHCI pci table for ATI SB700 SATA controller, the subsequent chipset of SB600. Signed-off-by:henry su<[EMAIL PROTECTED]> diff -Nur linux-2.6.21.orig/drivers/ata/ahci.c linux-2.6.21/drivers/ata/ahci.c --- linux-2.6.2

[patch] Add more device IDs for supporting ATI SB700 SATA contro ller completely

From: [EMAIL PROTECTED] The sata controller device ID will be different according to the onchip sata type setting in system BIOS: Device Device ID SATA in IDE mode 0x4390 SATA in AHCI mode

RE: [PATCH V3] drm_crtc: check if fb_create return NULL

-Original Message- From: Jani Nikula [mailto:jani.nik...@linux.intel.com] Sent: Thursday, January 24, 2013 5:05 PM To: Su, Xuemin Cc: airl...@linux.ie; dri-de...@lists.freedesktop.org; linux-kernel@vger.kernel.org; yanmin_zh...@linux.intel.com; He, Bo Subject: Re: [PATCH V3] drm_crtc

[PATCH] drm/radeon: Calling object_unrefer() when creating fb failure

From: liu chuansheng Date: Thu, 31 Jan 2013 22:13:00 +0800 Subject: [PATCH] drm/radeon: Calling object_unrefer() when creating fb failure When kzalloc() failed in radeon_user_framebuffer_create(), need to call object_unreference() to match the object_reference(). Signed-off-by: liu chuansheng

[PATCH v1 1/1] iommu/amd: fix enabling exclusion range for an exact device

From: Su Friendy set_device_exclusion_range(u16 devid, struct ivmd_header *m) enables exclusion range for ONE device. IOMMU does not translate the access to the exclusion range from the device. The device is specified by input argument 'devid'. But 'devid' is not pass

[PATCH] radeon_display: Use pointer return error codes

From: xueminsu Date: Tue, 22 Jan 2013 22:16:53 +0800 Subject: [PATCH] radeon_display: Use pointer return error codes drm_mode_addfb() expects fb_create return error code instead of NULL. Signed-off-by: xueminsu --- drivers/gpu/drm/radeon/radeon_display.c |2 +- 1 files changed, 1 insertion

[PATCH] drm_crtc: check if fb_create return NULL

From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |6 ++ 1 files changed, 6 insertions(

[PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |7 +++ 1 files changed, 7 insertions

RE: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL

-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Wednesday, January 23, 2013 5:54 PM >To: Su, Xuemin >Cc: airl...@linux.ie; dri-de...@lists.freedesktop.org; >linux-kernel@vger.kernel.org; yanmin_zh...@linux.in

[PATCH V3] drm_crtc: check if fb_create return NULL

From: xueminsu Date: Tue, 22 Jan 2013 22:39:39 +0800 Subject: [PATCH] drm_crtc: check if fb_create return NULL Some buggy driver may still return NULL in fb_create, which leads to kernel panic. Signed-off-by: xueminsu --- drivers/gpu/drm/drm_crtc.c |2 ++ 1 files changed, 2 insertions(+),

Re: [PATCH V3] drm_crtc: check if fb_create return NULL

On Thu, 2013-01-24 at 10:31 +0200, Jani Nikula wrote: > > } > > + /* some buggy driver may return NULL here, which may cause panic */ > > + BUG_ON(!fb); > > I fail to see the benefit of this compared to just letting it oops... > > > or->fb_id = fb->base.id; > > ...right here. > > F

RE: [PATCH v1 1/1] iommu/amd: set iommu for early mapped ioapic/hpet

Hi, Joerg, > -Original Message- > From: j...@8bytes.org [mailto:j...@8bytes.org] > Sent: Wednesday, September 03, 2014 11:06 PM > To: Su, Friendy > Cc: io...@lists.linux-foundation.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1 1/1] iommu/amd: set iomm

[PATCH v2 1/1] iommu/amd: set iommu for early mapped ioapic/hpet

From: Su Friendy Subject: iommu/amd: make early mapped ioapic/hpet override IVHD The early mapped ioapic/hpet specified by kernel boot parameter ivrs_ioapic[ID]/ivrs_hpet[ID] always override the ioapic/hpet with same ID reported by ACPI IVHD table. Current driver still uses devid in IVHD to

[PATCH v1 1/1] iommu/amd: set iommu for early mapped ioapic/hpet

From: Su Friendy The early mapped ioapic/hpet specified by kernel boot parameter ivrs_ioapic[ID]/ivrs_hpet[ID] always override the ioapic/hpet with same ID reported by ACPI IVRS table. Therefore, the early mapped should be always controlled by iommu. Current driver did not set iommu for the

RE: [PATCH v2 1/1] iommu/amd: set iommu for early mapped ioapic/hpet

imported a new argument to add_special_device(). Best Regards Friendy > -Original Message- > From: Joerg Roedel [mailto:j...@8bytes.org] > Sent: Friday, September 05, 2014 9:53 PM > To: Su, Friendy > Cc: io...@lists.linux-foundation.org; linux-kernel@vger.kernel.org > S

[PATCH] udp: Fix typo in udpv4/p.c

Signed-off-by: Su Yanjun --- net/ipv4/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index c21862b..d88821c 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -2170,7 +2170,7 @@ static int __udp4_lib_mcast_deliver(struct net *net

[PATCH] udp: Fix typo in net/ipv4/udp.c

Signed-off-by: Su Yanjun --- net/ipv4/udp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index c21862b..d88821c 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -2170,7 +2170,7 @@ static int __udp4_lib_mcast_deliver(struct net *net

[PATCH] NFS: Fix O_DIRECT read problem when another write is going on

read nothing. When the reader issue another read it will read ok. Signed-off-by: Su Yanjun --- fs/nfs/direct.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index 222d711..7f737a3 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs

Re: [PATCH] NFS: Fix O_DIRECT read problem when another write is going on

在 2019/10/1 2:06, Trond Myklebust 写道: Hi Su, On Mon, 2019-09-30 at 17:11 +0800, Su Yanjun wrote: In xfstests generic/465 tests failed. Because O_DIRECT r/w use async rpc calls, when r/w rpc calls are running concurrently we may read partial data which is wrong. For example as follows

[PATCH] PCI: Don't use Printk in raw_spinlocks

ned-off-by: Xingxing Su --- drivers/pci/access.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 79c4a2e..b3fc164 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -160,9 +160,6 @@ int pci_generic_config_write32(struct pci_b

[PATCH] seqlock: Fix build errors

From: XingxingSu Fix the following build errors: In file included from ./include/linux/time.h:6:0, from ./include/linux/compat.h:10, from arch/mips/kernel/asm-offsets.c:12: ./include/linux/seqlock.h: In function ???write_seqcount_begin_nested???: ./include/linux

[PATCH RESEND] KVM: MIPS/VZ: Fix build error caused by 'kvm_run' cleanup

for target 'arch/mips/kvm/vz.o' failed make[2]: *** [arch/mips/kvm/vz.o] Error 1 scripts/Makefile.build:500: recipe for target 'arch/mips/kvm' failed make[1]: *** [arch/mips/kvm] Error 2 Makefile:1785: recipe for target 'arch/mips' failed make: *** [arch/mips] Error

[PATCH] tools/time: access /sys/kernel/debug/udelay_test before test.

sh@ubuntu:~/workspace/linux-stable/tools/time$ sudo ./udelay_test.sh modprobe: FATAL: Module udelay_test not found in directory /lib/modules/5.4.44 ERROR, can not access /sys/kernel/debug/udelay_test. modprobe: FATAL: Module udelay_test not found. Signed-off-by: Hui Su --- tools/time/udelay_te

[PATCH] docs/cpu-load: format the example code.

format the example code. Signed-off-by: Hui Su --- Documentation/admin-guide/cpu-load.rst | 63 ++ 1 file changed, 33 insertions(+), 30 deletions(-) diff --git a/Documentation/admin-guide/cpu-load.rst b/Documentation/admin-guide/cpu-load.rst index ebdecf864080

[PATCH] blk: use REQ_OP_WRITE instead of hard code

use REQ_OP_WRITE instead of hard code in op_is_write(). Signed-off-by: Hui Su --- include/linux/blk_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 7d7c13238fdb..7b9b02378c24 100644 --- a/include/linux

[PATCH] block/elevator: reduce the critical section

1.reduce the critical section in elevator_get(). 2.reduce the critical section in elevator_get_by_features(). 3.remove the found variable. the elv_list_lock is used to protect the elv_list, and the operations of elevator_type does not need to be protected. Signed-off-by: Hui Su --- block

Re: [PATCH] fs: tree-checker: fix missing brace warning for old compilers

On Sat 03 Oct 2020 at 08:11, Pujin Shi wrote: For older versions of gcc, the array = {0}; will cause warnings: So what's the version number of the gcc? "struct foo = { 0 }" should be correct. May be the compiler issue[1] related? 1: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119

[PATCH] taskstats: use family->version instead of TASKSTATS_GENL_VERSION

use family->version instead of the hrad code(TASKSTATS_GENL_VERSION). Signed-off-by: Hui Su --- kernel/taskstats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/taskstats.c b/kernel/taskstats.c index e2ac0e37c4ae..8364663ca07d 100644 --- a/kernel/taskstats.c ++

[PATCH] async.c: reduce the critical region in lowest_in_progress()

The judgement of first do not need to be in the critical region. So move it out. Signed-off-by: Hui Su --- kernel/async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/async.c b/kernel/async.c index 33258e6e20f8..9d33ffcc84c7 100644 --- a/kernel/async.c +++ b/kernel

[PATCH] acct.c: use #elif instead of #end and #elif

use #elif instead of #end and #elif. Signed-off-by: Hui Su --- kernel/acct.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/kernel/acct.c b/kernel/acct.c index b0c5b3a9f5af..24681372af07 100644 --- a/kernel/acct.c +++ b/kernel/acct.c @@ -381,9 +381,7 @@ static

[PATCH] docs/rcu: update the api of call_rcu()

update the api of call_rcu() Signed-off-by: Hui Su --- Documentation/RCU/whatisRCU.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Documentation/RCU/whatisRCU.rst b/Documentation/RCU/whatisRCU.rst index c7f147b8034f..aa7d5ed20da5 100644 --- a/Documentation/RCU

[PATCH] mm/hugetlb.c: just use put_page_testzero() instead of page_count()

we test the page reference count is zero or not here, it can be a bug here if page refercence count is not zero. So we can just use put_page_testzero() instead of page_count(). Signed-off-by: Hui Su --- mm/hugetlb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm

Re: [PATCH] mm/vmalloc.c: check the addr first

On Mon, Sep 28, 2020 at 11:04:34AM -0700, Ira Weiny wrote: > On Mon, Sep 28, 2020 at 12:33:37AM +0800, Hui Su wrote: > > As the comments said, if @addr is NULL, no operation > > is performed, check the addr first in vfree() and > > vfree_atomic() maybe a better choice. >

Re: [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c

On Thu, Oct 01, 2020 at 09:17:29AM -0700, Joe Perches wrote: > On Thu, 2020-10-01 at 14:27 +0200, David Hildenbrand wrote: > > On 25.09.20 18:06, Hui Su wrote: > > > 1. the cpuset.c has been moved from kernel/cpuset.c to > > > kernel/cgroup/cpuset.c long time ag

Re: [PATCH] sched,fair: use list_for_each_entry() in print_cfs_stats()

On Tue, Sep 29, 2020 at 11:56:42AM +0200, Dietmar Eggemann wrote: > On 25/09/2020 21:10, Hui Su wrote: > > Macro for_each_leaf_cfs_rq_safe() use list_for_each_entry_safe(), > > which can against removal of list entry, but we only > > print the cfs_rq data and won'

[PATCH] sched/rt.c remove unnecessary parameter in pick_next_rt_entity

struct rq is not necessary for pick_next_rt_entity(), we can get next sched_rt_entity just from struct rt_rq. Signed-off-by: Hui Su --- kernel/sched/rt.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index f215eea6a966

Re: [PATCH v4 7/7] fs/xfs: Add dedupe support for fsdax

ock2_io_mmap( else xfs_lock_two_inodes(ip1, XFS_MMAPLOCK_EXCL, ip2, XFS_MMAPLOCK_EXCL); + + if (IS_DAX(inode1) && IS_DAX(inode2)) + ret = xfs_break_two_dax_layouts(inode1, inode2); + ret is ignored here. -- Su

[PATCH] lib/stackdepot.c: fix the compile warning

sed_result [-Wunused-result] 154 | kstrtobool(str, &stack_depot_disable); | ^ Signed-off-by: Hui Su --- lib/stackdepot.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index cc21116512a7

Re: build failure of malta_qemu_32r6_defconfig

day.h:57:2: error: the register 'lo' > cannot be clobbered in 'asm' for the current target >57 | asm volatile( > | ^~~ > > Any idea how to fix this? Please ignore if it has been reported before. > > > -- > Regards > Sudip -- YunQiang Su

Re: [PATCH 2/2] blktrace: limit allowed total trace buffer size

The priority of '<<' is lower than '/', right? :) -- Su + if (buf_size < PAGE_SIZE) + buf_size = PAGE_SIZE; + buf_nr = req_pages << PAGE_SHIFT / buf_size; + if (buf_nr == 0) +

Re: [PATCH] mm,oom_kill: fix the comment of is_dump_unreclaim_slabs()

On Tue, Oct 27, 2020 at 08:11:18AM +0100, Michal Hocko wrote: > On Sat 26-09-20 12:15:26, Hui Su wrote: > > fix the comment of is_dump_unreclaim_slabs(), it just check > > whether nr_unreclaimable slabs amount is greater than user > > memory. > > The original comme

[PATCH v2] mm/oom_kill.c: remove the unmatched comments

is_dump_unreclaim_slabs() just check whether nr_unreclaimable slabs amount is greater than user memory, not match witch comment. So delete the comment, and rename it to should_dump_unreclaim_slabs(). Signed-off-by: Hui Su --- mm/oom_kill.c | 8 ++-- 1 file changed, 2 insertions(+), 6

Re: [PATCH v2] mm/oom_kill.c: remove the unmatched comments

On Tue, Oct 27, 2020 at 03:58:14PM +0100, Michal Hocko wrote: > On Tue 27-10-20 22:45:29, Hui Su wrote: > > is_dump_unreclaim_slabs() just check whether nr_unreclaimable > > slabs amount is greater than user memory, not match witch comment. > > As I've tried to e

[PATCH] sched/group_sched: add task_group_is_root() api

Use task_group_is_root() instead of '!tg->se[0]' and 'tg == &root_task_group' to judge whether a task_group is root_task_group. Signed-off-by: Hui Su --- kernel/sched/autogroup.c | 2 +- kernel/sched/core.c | 11 --- kernel/sched/fair.c |

[PATCH] mm/list_lru: optimize condition of exiting the loop

In list_lru_walk(), nr_to_walk type is 'unsigned long', so nr_to_walk won't be '< 0'. In list_lru_walk_node(), nr_to_walk type is 'unsigned long', so *nr_to_walk won't be '< 0' too. We can use '!nr_to_walk' instead of 'nr_to_

Re: [PATCH] mm/list_lru: optimize condition of exiting the loop

On Tue, Oct 27, 2020 at 07:45:53PM +0100, Vlastimil Babka wrote: > On 10/27/20 6:04 PM, Hui Su wrote: > > In list_lru_walk(), nr_to_walk type is 'unsigned long', > > so nr_to_walk won't be '< 0'. > > > > In list_lru_walk_node(), nr_to_walk ty

[PATCH v3] mm/oom_kill: remove comment and rename is_dump_unreclaim_slabs()

er to should_dump_unreclaim_slabs which should make it clear what it is meant to do and drop the comment as the purpose should be pretty evident now. Signed-off-by: Hui Su Acked-by: Michal Hocko --- mm/oom_kill.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git

[PATCH] selftest/vm: Fix build error

ABLE_WRITE) ^ protection_keys.c:218:45: error: ‘PKEY_DISABLE_WRITE’ undeclared pkey_assert(flags & (PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE)); ^ Signed-off-by: Xingxing Su --- tools/testing/selftests/vm/Makefile | 4 1 file changed, 4 insertions(

[PATCH][next] arm64: fix the mm build error in mm/kfence/core.c

function ‘set_memory_valid’ [-Werror=implicit-function-declaration] 12 | set_memory_valid(addr, 1, !protect); | ^~~~ cc1: some warnings being treated as errors which introduced by commit d54febeba2ff ("kfence: use pt_regs to generate stack trace on faults"). Signed-off-

[PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

Since the commit 60cd4bcd6238 ("memcg: localize memcg_kmem_enabled() check"), we have supplied the api which users don't have to explicitly check memcg_kmem_enabled(). Signed-off-by: Hui Su --- mm/page_alloc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH] mm/page_alloc: simplify kmem cgroup charge/uncharge code

On Mon, Dec 07, 2020 at 09:28:46AM -0800, Shakeel Butt wrote: > On Mon, Dec 7, 2020 at 6:22 AM Hui Su wrote: > > The reason to keep __memcg_kmem_[un]charge_page functions is that they > were called in the very hot path. Can you please check the performance > impact of your ch

[PATCH] fs/proc: make pde_get() return nothing

we don't need pde_get()'s return value, so make pde_get() return nothing Signed-off-by: Hui Su --- fs/proc/internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/proc/internal.h b/fs/proc/internal.h index 917cc85e3466..0abbd93a4a08 100644 --- a/fs/proc/

[linux-next] kernel panic when poweroff (Tree for Dec 11)

t syncing: Attempted to kill init! exitcode=0x0009 ]--- qemu-system-x86_64: terminating on signal 15 from pid 2836242 (pkill) The next tree for Dec 10 does not contain this problem, and the tree for Dec 11 can reproduce this problem stably(always panic when poweroff). Reported-by: Hui Su

[PATCH] MIPS: Enable GCOV

arch/mips/boot/compressed/string.o: in function `_GLOBAL__sub_D_00100_1_memcpy': string.c:(.text.exit+0x0): undefined reference to `__gcov_exit' ... Signed-off-by: Youling Tang Signed-off-by: Xingxing Su --- arch/mips/Kconfig | 1 + arch/mips/boot/compressed/Makefile |

[PATCH] selftests/clone3: Add gun99 to compile in Makefile.

ode Signed-off-by: Xingxing Su --- tools/testing/selftests/clone3/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/clone3/Makefile b/tools/testing/selftests/clone3/Makefile index ef7564c..88354a8 100644 --- a/tools/testing/selftests/clone3/Makef

[PATCH v2] selftests/clone3: Fix build error

; i++) { ^ test_core.c:87:2: note: use option -std=c99 or -std=gnu99 to compile Add -std=gnu99 to the clone3 selftest Makefile to fix this. Signed-off-by: Xingxing Su Acked-by: Christian Brauner --- tools/testing/selftests/clone3/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/to

[PATCH] sctp: Add rcu lock to protect dst entry in sctp_transport_route

will cause dst->refcnt==0 then rcu softirq will reclaim the dst entry,get_dst then use the freed memory. This patch adds rcu lock to protect the dst_entry here. Fixes: 6e91b578bf3f("sctp: re-use sctp_transport_pmtu in sctp_transport_route") Signed-off-by: Su Yanjun Report

[PATCH 0/4] Add Support for MediaTek PMIC MT6359 Regulator

This patchset add support to MT6359 PMIC regulator. MT6359 is primary PMIC for MT6779 platform. wen.su (4): dt-bindings: regulator: Add document for MT6359 regulator mfd: Add for PMIC MT6359 registers definition regulator: mt6359: Add support for MT6359 regulator arm64: dts: mt6359: add P

[PATCH 4/4] arm64: dts: mt6359: add PMIC MT6359 related nodes

From: "wen.su" add PMIC MT6359 related nodes which is for MT6779 platform Signed-off-by: wen.su --- arch/arm64/boot/dts/mediatek/mt6359.dtsi | 312 +++ 1 file changed, 312 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi diff --git a/arch/

[PATCH 1/4] dt-bindings: regulator: Add document for MT6359 regulator

From: "wen.su" add dt-binding document for MediaTek MT6359 PMIC Signed-off-by: wen.su --- .../bindings/regulator/mt6359-regulator.txt| 59 ++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/mt6359-regulator.txt diff

[PATCH 2/4] mfd: Add for PMIC MT6359 registers definition

From: "wen.su" This adds MediaTek PMIC MT6359 registers definition for the following sub modules: - Regulator - RTC - Interrupt Signed-off-by: wen.su --- include/linux/mfd/mt6359/registers.h | 531 +++ 1 file changed, 531 insertions(+) create mode 100644 inclu

[PATCH 3/4] regulator: mt6359: Add support for MT6359 regulator

struct regulator_dev *rdev; + int i; + + for (i = 0; i < MT6359_MAX_REGULATOR; i++) { + config.dev = &pdev->dev; + config.driver_data = &mt6359_regulators[i]; + config.regmap = mt6397->regmap; + + rdev = devm_regulator

About patch NFS: Fix O_DIRECT accounting of number of bytes read/written

Hi trond, Because My mail system cant receive nfs mail list’s mails, I reply your patch here. I have some question for the patch. >No. Basic O_DIRECT does not guarantee atomicity of requests, which is >why we do not have generic locking at the VFS level when reading and >writing. The only guarant

[PATCH net] ipv4: fix ifa_flags reuse problem in using ifconfig tool

weird especially some old scripts or program [2] still use ifconfig. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/ commit/fec80e7473ad16979af75ed299d68103e7aa3fe9 [2] LTP or TAHI Signed-off-by: Su Yanjun --- net/ipv4/devinet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net

Re: [RFC PATCH v5 0/4] add simple copy support

On Fri 19 Feb 2021 at 20:45, SelvaKumar S wrote: This patchset tries to add support for TP4065a ("Simple Copy Command"), v2020.05.04 ("Ratified") The Specification can be found in following link. https://nvmexpress.org/wp-content/uploads/NVM-Express-1.4-Ratified-TPs-1.zip 404 not found

Re: [PATCH v3] binfmt_misc: pass binfmt_misc flags to the interpreter

gt; >> --persistent no --preserve-argv0 no > >># systemctl restart systemd-binfmt.service > >># cat /proc/sys/fs/binfmt_misc/qemu-ppc > >>enabled > >>interpreter //qemu-ppc > >>

[PATCH v1] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

No functional effect. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c index

[PATCH v2] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

No functional effect. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c index

[PATCH v3] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

The sizeof(u32) is hardcoded. It's better to use the config value in regmap. It increases the size of target object, but it's flexible when new mcp chip need other val_bytes. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 ++--- 1 file changed, 6

[PATCH v1] can: mcp251xfd: use regmap_bulk_write for compatibility

Recently i use mcp2518fd on 4.x kernel which multiple write is not backported, regmap_raw_write will cause old kernel crash because the tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead for compatibility. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd

[PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

When i debug mcp2518fd, some method to track registers is needed. This easy debug interface will be ok. For example, read a register at 0xe00: echo 0xe00 > can_get_reg cat can_get_reg write a register at 0xe00: echo 0xe00,0x60 > can_set_reg Signed-off-by: Su Yanjun --- .../net/c

[PATCH v4] can: mcp251xfd: replace sizeof(u32) with val_bytes in regmap

The sizeof(u32) is hardcoded. It's better to use the config value in regmap. It increases the size of target object, but it's flexible when new mcp chip need other val_bytes. Signed-off-by: Su Yanjun --- drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 ++--- 1 file changed, 6

rcutorture: meaning of "End of test: RCU_HOTPLUG"

_holdoff=0 I am wondering that meaning of "RCU_HOTPLUG". Is it expected because cpu hotplug is enabled in the test? Or just represents another type of failure? Thanks, Su

Re: rcutorture: meaning of "End of test: RCU_HOTPLUG"

Thanks for your quick reply! Paul On 1/22/19 12:01 PM, Paul E. McKenney wrote: On Tue, Jan 22, 2019 at 11:40:53AM +0800, Su Yue wrote: Hi, guys While running rcutorture tests with "onoff_interval", some tests failed and results

Re: rcutorture: meaning of "End of test: RCU_HOTPLUG"

On 1/23/19 11:22 AM, Paul E. McKenney wrote: On Tue, Jan 22, 2019 at 04:42:19PM +0800, Su Yue wrote: Thanks for your quick reply! Paul On 1/22/19 12:01 PM, Paul E. McKenney wrote: On Tue, Jan 22, 2019 at 11:40:53AM +0800, Su Yue wrote: Hi, guys While running rcutorture tests with

[PATCH] netfilter: nf_ct_helper: Fix possible panic when nf_conntrack_helper_unregister is used in an unloadable module

From: Su Yanjun Because nf_conntrack_helper_unregister maybe used in an unloadable module, it uses 'synchronize_rcu' which may cause kernel panic. According to the artical: RCU and Unloadable Modules https://lwn.net/Articles/217484/ When we have a heavy rcu callback load, then s

Re: [PATCH] netfilter: nf_ct_helper: Fix possible panic when nf_conntrack_helper_unregister is used in an unloadable module

On 2019/3/1 16:43, Sergei Shtylyov wrote: Hello! On 01.03.2019 8:56, Su Yanjun wrote: From: Su Yanjun Because nf_conntrack_helper_unregister maybe used in an unloadable module, it uses 'synchronize_rcu' which may cause kernel panic. According to the artical:    Article?

[PATCH] net: xfrm: Fix potential oops in xfrm_user_rcv_msg and array out of bounds

When i review xfrm_user.c code, i found some potentical bug in it. In xfrm_user_rcvmsg if type parameter from user space is set to XFRM_MSG_MAX or XFRM_MSG_NEWSADINFO or XFRM_MSG_NEWSPDINFO. It will cause xfrm_user_rcv_msg referring to null entry in xfrm_dispatch array. Signed-off-by: Su

[PATCH] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm

For rcu protected pointers, we'd bettter add '__rcu' for them. No functional change. Signed-off-by: Su Yanjun --- include/net/netns/xfrm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/netns/xfrm.h b/include/net/netns/xfrm.h index 59f45b1..d2a36

[PATCH v2] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm

noderef] *nlsk [...] So introduce a new wrapper function of nlmsg_unicast to handle type conversions. No functional change. Signed-off-by: Su Yanjun --- Changes from v1: - fix spelling mistakes and the sparse tool' warnings include/net/netns/xfrm.h | 2 +-

Re: [PATCH] net: xfrm: Fix potential oops in xfrm_user_rcv_msg and array out of bounds

On 2019/3/5 15:31, Steffen Klassert wrote: On Tue, Mar 05, 2019 at 03:08:49PM +0800, Su Yanjun wrote: On 2019/3/5 14:49, Herbert Xu wrote: On Sun, Mar 03, 2019 at 10:47:39PM -0500, Su Yanjun wrote: When i review xfrm_user.c code, i found some potentical bug in it. In xfrm_user_rcvmsg if

[PATCH v3] net: xfrm: Add '_rcu' tag for rcu protected pointer in netns_xfrm

noderef] *nlsk [...] So introduce a new wrapper function of nlmsg_unicast to handle type conversions. This patch also fixes a direct access of a rcu protected socket. Fixes: be33690d8fcf("[XFRM]: Fix aevent related crash") Signed-off-by: Su Yanjun --- Changes from v2: - add 'F

Re: [PATCH] xfs: correct statx's result_mask value

On 1/8/2019 2:04 AM, Eric Sandeen wrote: On 1/7/19 11:52 AM, Darrick J. Wong wrote: On Mon, Jan 07, 2019 at 04:53:10AM -0500, Su Yanjun wrote: For statx syscall, xfs return the wrong result_mask. Signed-off-by: Su Yanjun --- fs/xfs/xfs_iops.c | 3 +++ 1 file changed, 3 insertions

Re: [PATCH] xfs: correct statx's result_mask value

On 1/8/2019 1:07 PM, Darrick J. Wong wrote: On Tue, Jan 08, 2019 at 12:58:43PM +0800, Su Yanjun wrote: On 1/8/2019 2:04 AM, Eric Sandeen wrote: On 1/7/19 11:52 AM, Darrick J. Wong wrote: On Mon, Jan 07, 2019 at 04:53:10AM -0500, Su Yanjun wrote: For statx syscall, xfs return the wrong

Re: [PATCH] vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel

On 1/4/2019 3:43 PM, Steffen Klassert wrote: On Thu, Jan 03, 2019 at 07:48:41AM -0500, Su Yanjun wrote: Recently we run a network test over ipcomp virtual tunnel.We find that if a ipv4 packet needs fragment, then the peer can't receive it. We deep into the code and find that when packet

[PATCH v2] vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel

ocess in ipcomp virtual tunnel. Signed-off-by: Su Yanjun --- Based on Linus' master branch. Changes from v1: - use a separate handler for ipip packet processing in ipcomp virtual tunnel net/ipv4/ip_vti.c | 50 ++ 1 file changed, 50 insertio

[PATCH] xfs: correct statx's result_mask value

For statx syscall, xfs return the wrong result_mask. Signed-off-by: Su Yanjun --- fs/xfs/xfs_iops.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c index f48ffd7..3811457 100644 --- a/fs/xfs/xfs_iops.c +++ b/fs/xfs/xfs_iops.c @@ -521,6 +521,9

[PATCH] ipv6: fix typo in net/ipv6/reassembly.c

Signed-off-by: Su Yanjun --- net/ipv6/reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index a5bb59e..36a3d8d 100644 --- a/net/ipv6/reassembly.c +++ b/net/ipv6/reassembly.c @@ -210,7 +210,7 @@ static int ip6_frag_queue

[PATCH] vti4: Fix a ipip packet processing bug in 'IPCOMP' virtual tunnel

ocess in ipcomp virtual tunnel. Signed-off-by: Su Yanjun --- net/ipv4/ip_vti.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c index de31b30..63de2f6 100644 --- a/net/ipv4/ip_vti.c +++ b/net/ipv4/ip_vti.c @@ -6

Re: [PATCH v2] btrfs: add a check for sysfs_create_group

re_attr_group); + if (ret) + btrfs_err(fs_info, "failed to create btrfs_feature_attr_group.\n"); NIT: ".\n" is unnecessary. --- Su } static int btrfs_init_debugfs(void)

  1   2   3   >