On Wed, 2019-06-12 at 14:25 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
Thanks Greg.
Reviewed-by: Sudeep
On Tue, 2019-06-11 at 20:43 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
Thanks Greg.
Reviewed-by: Sudeep
location during the
open(..) callback succeeds or fails. The close(..) callback cleans up
the data structures from the mmap(..) or open(..) callbacks if any.
Thanks,
Sudeep Dutt
added way back in commit
> 2a2d1382fe9dcc ("virtio: Add improved queue allocation API") in order to
> address mic's usecase, according to the commit message.
>
Thank you for fixing this up Vincent.
Reviewed-by: Sudeep Dutt
> Signed-off-by: Vincent Whitchurch
> ---
>
patch introduces a new data structure, i.e.,
> scif_cb_arg, to store the arguments required by the call back function. A
> variable 'cb_arg' is allocated in _scif_prog_signal() to pass the
> arguments. 'cb_arg' will be freed after dma_pool_free() in
> scif_prog_signal_cb().
>
Thanks for incorpo
tx->callback_param = status;
> + tx->callback_param = cb_arg;
> }
cb_arg should be freed if there is a dma_submit_error(..) below in the
dma_fail path.
Wenwen, can you please fix these up and resend the patch?
Thanks,
Sudeep Dutt
tx->callback_param = status;
> + tx->callback_param = cb_arg;
> }
cb_arg should be freed if there is a dma_submit_error(..) below in the
dma_fail path.
Wenwen, can you please fix these up and resend the patch?
Thanks,
Sudeep Dutt
.
>
> Does this mean we can kill the kernel scif code as well?
The MIC COSM drivers are using the kernel SCIF code. These drivers have
been upstream since 2015 and we are not sure who is using them. Our
preference will be to keep these drivers in the kernel for now.
Thanks,
Sudeep Dutt
.
>
> Does this mean we can kill the kernel scif code as well?
The MIC COSM drivers are using the kernel SCIF code. These drivers have
been upstream since 2015 and we are not sure who is using them. Our
preference will be to keep these drivers in the kernel for now.
Thanks,
Sudeep Dutt
43c9a7 ("misc: mic: SCIF open close bind and listen APIs")
> Signed-off-by: Dan Carpenter
> ---
> I have not tested this patch. Please review carefully.
Thanks for the patch Dan.
Reviewed-by: Sudeep Dutt
>
> diff --git a/drivers/misc/mic/scif/scif_api.c
> b/drivers
43c9a7 ("misc: mic: SCIF open close bind and listen APIs")
> Signed-off-by: Dan Carpenter
> ---
> I have not tested this patch. Please review carefully.
Thanks for the patch Dan.
Reviewed-by: Sudeep Dutt
>
> diff --git a/drivers/misc/mic/scif/scif_api.c
> b/drivers
tps://lkml.org/lkml/2016/4/5/7
Greg, can you please please apply the patch?
Thanks,
Sudeep Dutt
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > master
> > head: c3b46c73264b03000d1e18b22f5caf63332547c9
> > commit: 8810d
tps://lkml.org/lkml/2016/4/5/7
Greg, can you please please apply the patch?
Thanks,
Sudeep Dutt
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > master
> > head: c3b46c73264b03000d1e18b22f5caf63332547c9
> > commit: 8810d
On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote:
> > Fixes randconfig build error reported at
> > https://lkml.org/lkml/2016/4/3/135 by ensuring that
> > the VOP driver selects VIRTIO.
> >
&g
On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote:
> > Fixes randconfig build error reported at
> > https://lkml.org/lkml/2016/4/3/135 by ensuring that
> > the VOP driver selects VIRTIO.
> >
&g
Fixes randconfig build error reported at
https://lkml.org/lkml/2016/4/3/135 by ensuring that
the VOP driver selects VIRTIO.
Reported-by: Fengguang Wu <fengguang...@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.co
Fixes randconfig build error reported at
https://lkml.org/lkml/2016/4/3/135 by ensuring that
the VOP driver selects VIRTIO.
Reported-by: Fengguang Wu
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
This patch deletes the virtio functionality from the MIC X100 card
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic
This patch deletes the virtio functionality from the MIC X100 host
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic
This patch moves the virtio specific debugfs hooks previously in
mic_debugfs.c in the MIC host driver into the VOP driver. The
Kconfig/Makefile is also updated to allow building the VOP driver.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/Kconfig | 20
from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/vop/vop_vringh.c | 1164 +++
c/mic/card/mic_virtio.c. Apart from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Sudeep Dutt
Signed-off-by: Ashutosh Dixit
---
drivers/misc/mic/vop/vop_ma
-by: Sudeep Dutt
---
drivers/misc/mic/Kconfig | 17
drivers/misc/mic/bus/Makefile | 1 +
drivers/misc/mic/bus/vop_bus.h | 140
drivers/misc/mic/bus/vop_bus.c | 203 +
4 files changed, 361 insertions(+)
create mode
This patch adds VOP driver data structures used in subsequent
patches. These data structures are refactored from similar data
structures used in the virtio parts of previous MIC host and card
drivers.
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/vop/vop_main.h
7) Enables VOP debugfs and driver build
8) Implements the MIC host and card driver changes to enable VOP
Ashutosh Dixit (1):
misc: mic: Enable VOP card side functionality
Sudeep Dutt (7):
misc: mic: Remove MIC X100 host virtio functionality
misc: mic: Remove MIC X100 card virtio functionality
Signed-off-by: Sudeep Dutt
---
Documentation/mic/mic_overview.txt | 54
drivers/misc/mic/Kconfig | 7 ++-
drivers/misc/mic/card/mic_device.h | 3 +
drivers/misc/mic/host/mic_device.h | 3 +
Documentation/mic/mpssd/mpssd.c| 2 +-
drivers/misc/mic/card
On Sun, 2016-02-07 at 22:57 -0800, Greg Kroah-Hartman wrote:
> On Mon, Feb 01, 2016 at 08:23:40PM -0800, Sudeep Dutt wrote:
> > The Virtio Over PCIe (VOP) bus abstracts the low level hardware
> > details like interrupts and mapping remote memory so that the same VOP
> > dr
On Sun, 2016-02-07 at 22:57 -0800, Greg Kroah-Hartman wrote:
> On Mon, Feb 01, 2016 at 08:23:40PM -0800, Sudeep Dutt wrote:
> > The Virtio Over PCIe (VOP) bus abstracts the low level hardware
> > details like interrupts and mapping remote memory so that the same VOP
> > dr
This patch deletes the virtio functionality from the MIC X100 host
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudee
from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
drivers/misc/mic/v
tio Devices.") in
drivers/misc/mic/card/mic_virtio.c. Apart from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
Signed-off-by: Ashut
This patch moves the virtio specific debugfs hooks previously in
mic_debugfs.c in the MIC host driver into the VOP driver. The
Kconfig/Makefile is also updated to allow building the VOP driver.
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <
<ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
Documentation/mic/mic_overview.txt | 54
drivers/misc/mic/Kconfig | 7 ++-
drivers/misc/mic/card/mic_device.h | 3 +
drivers/misc/mic/host/mic_device.h | 3 +
Documentati
.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
drivers/misc/mic/Kconfig | 17
drivers/misc/mic/bus/Makefile | 1 +
drivers/misc/mic/bus/vop_bus.h | 140
drivers/misc/mic/bus/vop_bus.c | 203
This patch adds VOP driver data structures used in subsequent
patches. These data structures are refactored from similar data
structures used in the virtio parts of previous MIC host and card
drivers.
Signed-off-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <
7) Enables VOP debugfs and driver build
8) Implements the MIC host and card driver changes to enable VOP
Ashutosh Dixit (1):
misc: mic: Enable VOP card side functionality
Sudeep Dutt (7):
misc: mic: Remove MIC X100 host virtio functionality
misc: mic: Remove MIC X100 card virtio functionality
This patch deletes the virtio functionality from the MIC X100 card
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudee
ality
7) Enables VOP debugfs and driver build
8) Implements the MIC host and card driver changes to enable VOP
Ashutosh Dixit (1):
misc: mic: Enable VOP card side functionality
Sudeep Dutt (7):
misc: mic: Remove MIC X100 host virtio functionality
misc: mic: Remove MIC X100 card virtio funct
This patch deletes the virtio functionality from the MIC X100 host
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic
-by: Sudeep Dutt
---
drivers/misc/mic/Kconfig | 17
drivers/misc/mic/bus/Makefile | 1 +
drivers/misc/mic/bus/vop_bus.h | 142
drivers/misc/mic/bus/vop_bus.c | 204 +
4 files changed, 364 insertions(+)
create mode
This patch deletes the virtio functionality from the MIC X100 card
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic
Signed-off-by: Sudeep Dutt
---
Documentation/mic/mic_overview.txt | 54 +---
drivers/misc/mic/Kconfig | 7 ++-
drivers/misc/mic/card/mic_device.h | 3 +
drivers/misc/mic/host/mic_device.h | 3 +
Documentation/mic/mpssd/mpssd.c| 2 +-
drivers/misc/mic/card
c/mic/card/mic_virtio.c. Apart from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Sudeep Dutt
Signed-off-by: Ashutosh Dixit
---
drivers/misc/mic/vop/vop_ma
from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/vop/vop_vringh.c | 1164 +++
This patch moves the virtio specific debugfs hooks previously in
mic_debugfs.c in the MIC host driver into the VOP driver. The
Kconfig/Makefile is also updated to allow building the VOP driver.
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/Kconfig | 20
This patch adds VOP driver data structures used in subsequent
patches. These data structures are refactored from similar data
structures used in the virtio parts of previous MIC host and card
drivers.
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/vop/vop_main.h
This patch moves the virtio specific debugfs hooks previously in
mic_debugfs.c in the MIC host driver into the VOP driver. The
Kconfig/Makefile is also updated to allow building the VOP driver.
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <
This patch adds VOP driver data structures used in subsequent
patches. These data structures are refactored from similar data
structures used in the virtio parts of previous MIC host and card
drivers.
Signed-off-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <
This patch deletes the virtio functionality from the MIC X100 host
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudee
.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
drivers/misc/mic/Kconfig | 17
drivers/misc/mic/bus/Makefile | 1 +
drivers/misc/mic/bus/vop_bus.h | 142
drivers/misc/mic/bus/vop_bus.c | 204
This patch deletes the virtio functionality from the MIC X100 card
driver. A subsequent patch will re-enable this functionality by
consolidating the hardware independent logic in a new Virtio over PCIe
(VOP) driver.
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudee
<ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
Documentation/mic/mic_overview.txt | 54 +---
drivers/misc/mic/Kconfig | 7 ++-
drivers/misc/mic/card/mic_device.h | 3 +
drivers/misc/mic/host/mic_device.h | 3 +
Documentati
tio Devices.") in
drivers/misc/mic/card/mic_virtio.c. Apart from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
Signed-off-by: Ashut
from being moved into a
separate driver the functionality is essentially unchanged. See the
above mentioned commit for a description of this functionality.
Signed-off-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
drivers/misc/mic/v
ality
7) Enables VOP debugfs and driver build
8) Implements the MIC host and card driver changes to enable VOP
Ashutosh Dixit (1):
misc: mic: Enable VOP card side functionality
Sudeep Dutt (7):
misc: mic: Remove MIC X100 host virtio functionality
misc: mic: Remove MIC X100 card virtio funct
On Fri, 2015-12-11 at 20:09 -0600, Eric Biggers wrote:
> The error code passed to ERR_PTR() always should be negated. Also, the
> return value of scif_add_mmu_notifier() was never checked.
>
Thanks for the patch Eric.
Reviewed-by: Sudeep Dutt
> Signed-off-by: Eric Biggers
>
command_line() fails.
>
Thanks for this patch series Sudip. All 4 patches look good.
Reviewed-by: Sudeep Dutt
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/misc/mic/host/mic_x100.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/driv
command_line() fails.
>
Thanks for this patch series Sudip. All 4 patches look good.
Reviewed-by: Sudeep Dutt <sudeep.d...@intel.com>
> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
> ---
> drivers/misc/mic/host/mic_x100.c | 13 +++--
> 1 file changed, 7
On Fri, 2015-12-11 at 20:09 -0600, Eric Biggers wrote:
> The error code passed to ERR_PTR() always should be negated. Also, the
> return value of scif_add_mmu_notifier() was never checked.
>
Thanks for the patch Eric.
Reviewed-by: Sudeep Dutt <sudeep.d...@intel.com>
> S
On Wed, 2015-11-18 at 21:10 +0900, Sergey Senozhatsky wrote:
> Cosmetic.
>
> Do not define list_entry_next() and use list_next_entry()
> from list.h.
>
Hi Sergey,
A similar patch was posted @ https://lkml.org/lkml/2015/11/16/328
Regards,
Sudeep Dutt
> Signed-off-by:
On Wed, 2015-11-18 at 21:10 +0900, Sergey Senozhatsky wrote:
> Cosmetic.
>
> Do not define list_entry_next() and use list_next_entry()
> from list.h.
>
Hi Sergey,
A similar patch was posted @ https://lkml.org/lkml/2015/11/16/328
Regards,
Sudeep Dutt
> Signed-off-by:
On Mon, 2015-11-16 at 21:46 +0800, Geliang Tang wrote:
> list_next_entry has been defined in list.h, so I replace list_entry_next
> with it.
>
Thanks for the cleanup.
Reviewed-by: Sudeep Dutt
> Signed-off-by: Geliang Tang
> ---
> drivers/misc/mic/sc
On Mon, 2015-11-16 at 21:46 +0800, Geliang Tang wrote:
> list_next_entry has been defined in list.h, so I replace list_entry_next
> with it.
>
Thanks for the cleanup.
Reviewed-by: Sudeep Dutt <sudeep.d...@intel.com>
> Signed-off-by: Geliang Tang <geliangt...@163.com>
&
gister(scif_epd_t epd, void *addr, size_t
> len, off_t offset,
> if ((map_flags & SCIF_MAP_FIXED) &&
> ((ALIGN(offset, PAGE_SIZE) != offset) ||
> (offset < 0) ||
> - (offset + (off_t)len < offset)))
> + (len < LONG_MAX
Add entry for MIC drivers to the MAINTAINERS file
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
MAINTAINERS | 16
1 file changed, 16 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fe5bbfe..994a7ae 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Add entry for MIC drivers to the MAINTAINERS file
Signed-off-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
MAINTAINERS | 15 +++
1 file changed, 15 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fe5bbfe..840993b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5575,6
On Tue, 2015-10-13 at 22:46 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 09:34:21AM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-13 at 14:38 +0530, Sudip Mukherjee wrote:
>
> > > + struct scif_hw_dev *sdev = scifdev->sdev;
> > > +
> > > + dm
we will have a leak.
> Lets deinitialize and release the resources connected to p2p_ij.
>
Reviewed-by: Sudeep Dutt
Thanks again for the fix.
> Signed-off-by: Sudip Mukherjee
> ---
>
> v3: added unmapping the aperture
> v2: missed making the function as static
>
> d
se resubmit this patch with the change above?
Also you should mention [PATCH char-misc-next] in the next revision.
Thanks for the fix!
Sudeep Dutt
> + scif_p2p_freesg(p2p->ppi_sg[SCIF_PPI_MMIO]);
> + scif_p2p_freesg(p2p->ppi_sg[SCIF_PPI_APER]);
> + kfree(p2p);
> +}
On Tue, 2015-10-13 at 15:52 +0300, Dan Carpenter wrote:
> The caller expects that we take this lock again before returning
> otherwise it you get double unlocks and races.
>
Reviewed-by: Sudeep Dutt
Thanks for the fix!
> Fixes: ba612aa8b487 ('misc: mic: SCIF memory
@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t
> len, off_t offset,
> if ((map_flags & SCIF_MAP_FIXED) &&
> ((ALIGN(offset, PAGE_SIZE) != offset) ||
> (offset < 0) ||
> - (offset + (off_t)len < offset)
On Tue, 2015-10-13 at 15:52 +0300, Dan Carpenter wrote:
> The caller expects that we take this lock again before returning
> otherwise it you get double unlocks and races.
>
Reviewed-by: Sudeep Dutt <sudeep.d...@intel.com>
Thanks for the fix!
> Fixes: ba612aa8b487 ('misc
IDIRECTIONAL);
Can you please resubmit this patch with the change above?
Also you should mention [PATCH char-misc-next] in the next revision.
Thanks for the fix!
Sudeep Dutt
> + scif_p2p_freesg(p2p->ppi_sg[SCIF_PPI_MMIO]);
> + scif_p2p_freesg(p2p->ppi_sg[SCIF_PPI_APER]);
>
we will have a leak.
> Lets deinitialize and release the resources connected to p2p_ij.
>
Reviewed-by: Sudeep Dutt <sudeep.d...@intel.com>
Thanks again for the fix.
> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
> ---
>
> v3: added unmapping the aperture
On Tue, 2015-10-13 at 22:46 +0530, Sudip Mukherjee wrote:
> On Tue, Oct 13, 2015 at 09:34:21AM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-13 at 14:38 +0530, Sudip Mukherjee wrote:
>
> > > + struct scif_hw_dev *sdev = scifdev->sdev;
> > > +
> > > + dm
Add entry for MIC drivers to the MAINTAINERS file
Signed-off-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
MAINTAINERS | 16
1 file changed, 16 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fe5b
Add entry for MIC drivers to the MAINTAINERS file
Signed-off-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
MAINTAINERS | 15 +++
1 file changed, 15 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fe5b
On Fri, 2015-10-09 at 09:41 +0300, Dan Carpenter wrote:
> We should be returning -ENOMEM here instead of success.
>
Reviewed-by: Sudeep Dutt
Thanks for the fix!
> Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
> Signed-off-by: Dan Carpenter
>
ght_sleep();
> @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t
> len, off_t offset,
> if ((map_flags & SCIF_MAP_FIXED) &&
> ((ALIGN(offset, PAGE_SIZE) != offset) ||
> (offset < 0) ||
> - (offset +
return -EINVAL;
>
> might_sleep();
> @@ -1613,7 +1613,7 @@ off_t scif_register(scif_epd_t epd, void *addr, size_t
> len, off_t offset,
> if ((map_flags & SCIF_MAP_FIXED) &&
> ((ALIGN(offset, PAGE_SIZE) != offset) ||
> (offset < 0
On Fri, 2015-10-09 at 09:41 +0300, Dan Carpenter wrote:
> We should be returning -ENOMEM here instead of success.
>
Reviewed-by: Sudeep Dutt <sudeep.d...@intel.com>
Thanks for the fix!
> Fixes: ba612aa8b487 ('misc: mic: SCIF memory registration and unregistration')
>
On Tue, 2015-10-06 at 09:33 +0100, gre...@linuxfoundation.org wrote:
> On Tue, Oct 06, 2015 at 01:05:27AM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-06 at 08:56 +0100, gre...@linuxfoundation.org wrote:
> > > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote:
> >
On Tue, 2015-10-06 at 08:56 +0100, gre...@linuxfoundation.org wrote:
> On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-06 at 06:20 +0100, gre...@linuxfoundation.org wrote:
> > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gre...@linuxfoundatio
On Tue, 2015-10-06 at 08:56 +0100, gre...@linuxfoundation.org wrote:
> On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-06 at 06:20 +0100, gre...@linuxfoundation.org wrote:
> > > On Tue, Oct 06, 2015 at 06:12:40AM +0100, gre...@linuxfoundatio
On Tue, 2015-10-06 at 09:33 +0100, gre...@linuxfoundation.org wrote:
> On Tue, Oct 06, 2015 at 01:05:27AM -0700, Sudeep Dutt wrote:
> > On Tue, 2015-10-06 at 08:56 +0100, gre...@linuxfoundation.org wrote:
> > > On Mon, Oct 05, 2015 at 10:23:38PM -0700, Sudeep Dutt wrote:
> >
On Tue, 2015-10-06 at 06:20 +0100, gre...@linuxfoundation.org wrote:
> On Tue, Oct 06, 2015 at 06:12:40AM +0100, gre...@linuxfoundation.org wrote:
> > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote:
> > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote:
&g
On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote:
> On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote:
> > From: Sudeep Dutt
> >
> > iova is a library which can be built without IOMMU_SUPPORT
> >
> > Signed-off-by: Sudeep Dutt
>
> The firs
he correct long term solution is to move the iova
library from drivers/iommu into lib/iova which will be done in
a future patch.
Cc: David Woodhouse
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/iommu/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -
he correct long term solution is to move the iova
library from drivers/iommu into lib/iova which will be done in
a future patch.
Cc: David Woodhouse <david.woodho...@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.di...@intel.com>
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
--
On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote:
> On Tue, 2015-09-29 at 18:09 -0700, Ashutosh Dixit wrote:
> > From: Sudeep Dutt <sudeep.d...@intel.com>
> >
> > iova is a library which can be built without IOMMU_SUPPORT
> >
> > Signed-off
On Tue, 2015-10-06 at 06:20 +0100, gre...@linuxfoundation.org wrote:
> On Tue, Oct 06, 2015 at 06:12:40AM +0100, gre...@linuxfoundation.org wrote:
> > On Mon, Oct 05, 2015 at 10:38:43AM -0700, Sudeep Dutt wrote:
> > > On Mon, 2015-10-05 at 03:50 -0700, Woodhouse, David wrote:
&g
SCIF depends on IOVA which requires IOMMU_SUPPORT to be enabled.
The long term fix is to move IOVA from drivers/iommu to lib/
but this current patch should fix the reported issue.
Reported-by: Fengguang Wu
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/Kconfig | 2
;
Signed-off-by: Sudeep Dutt <sudeep.d...@intel.com>
---
drivers/misc/mic/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig
index 60376fb..40677df 100644
--- a/drivers/misc/mic/Kconfig
+++ b/drivers/misc/mic/Kcon
On Fri, 2015-08-21 at 13:59 +0530, Vinod Koul wrote:
> On Thu, Aug 20, 2015 at 10:30:50AM -0700, Sudeep Dutt wrote:
> > On Thu, 2015-08-20 at 10:50 +0530, Vinod Koul wrote:
> > > On Mon, Jul 27, 2015 at 04:58:17PM -0700, As
On Fri, 2015-08-21 at 13:59 +0530, Vinod Koul wrote:
On Thu, Aug 20, 2015 at 10:30:50AM -0700, Sudeep Dutt wrote:
On Thu, 2015-08-20 at 10:50 +0530, Vinod Koul wrote:
On Mon, Jul 27, 2015 at 04:58:17PM -0700, Ashutosh Dixit wrote
he status descriptor.
The DMA engine API does not allow drivers to pass a 8 byte value. We are
allowed to pass a source physical address but we cannot determine the
source value within the DMA driver using that information specifically
with the IOMMU enabled. We have added this workaround so that we ca
that we can
program this special status update descriptor without making any changes
to the DMA engine API.
Thanks for the review!
Sudeep Dutt
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
t; >
> > > > Cc: Joerg Roedel
> > > > Reviewed-by: Anil S Keshavamurthy > > > >
> > > > Reviewed-by: Sudeep Dutt
> > > > Signed-off-by: Harish Chegondi
> > >
> > > Where is this going to be used outside of the IOMMU
Reviewed-by: Sudeep Dutt sudeep.d...@intel.com
Signed-off-by: Harish Chegondi harish.chego...@intel.com
Where is this going to be used outside of the IOMMU world?
We are using the IOVA generator in the SCIF driver posted @
http://thread.gmane.org/gmane.linux.kernel/2005895
Delete unnecessary prints resulting in an "spdev could be null"
warning from a static checker in scif_peer_remove(..).
Reported-by: Dan Carpenter
Reviewed-by: Ashutosh Dixit
Signed-off-by: Sudeep Dutt
---
drivers/misc/mic/scif/scif_main.c | 4
1 file changed, 4 deletions(-)
1 - 100 of 457 matches
Mail list logo
