RE: MHI code review

2019-06-12 Thread Sujeev Dias
Our team also monitoring following thread https://lkml.kernel.org/lkml/20190531035348.7194-1-el...@linaro.org/ Since this also has implication on MHI as well. Thanks Sujeev -Original Message- From: Sujeev Dias Sent: Wednesday, June 12, 2019 10:55 AM To: 'Daniele Palmas'

RE: MHI code review

2019-06-12 Thread Sujeev Dias
Hi Daniels Sorry for delay response. Yes, we will be pushing new set of series very soon that will have support for 55 as well. The series that's pushed should already work for SDX20, 24 and 55. There are some new features related to 55 that's not yet in series. Thanks Sujeev -Original

[PATCH v2 2/7] mhi_bus: core: add power management support

2018-07-09 Thread Sujeev Dias
Add support for MHI power management operations such as power on, off, suspend, and resume. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- drivers/bus/mhi/core/Makefile |2 +- drivers/bus/mhi/core/mhi_boot.c | 533

[PATCH v2 3/7] mhi_bus: core: add support for data transfer

2018-07-09 Thread Sujeev Dias
Add support for transferring data between external modem and MHI host using MHI protocol. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- drivers/bus/mhi/core/mhi_init.c | 76 +++- drivers/bus/mhi/core/mhi_internal.h | 8 - drivers/bus/mhi

[PATCH v2 1/7] mhi_bus: core: initial checkin for modem host interface bus driver

2018-07-09 Thread Sujeev Dias
-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- Documentation/00-INDEX| 2 + Documentation/devicetree/bindings/bus/mhi.txt | 258 Documentation/mhi.txt | 235 +++ drivers/bus/Kconfig

MHI code review

2018-07-09 Thread Sujeev Dias
Hi Greg Kroah-Hartman\Arnd Bergmann and community Thank you for all the feedback, I believe I have addressed all the comments from previous patches. Also, I am excluding mhi network driver in this series. I still have some modifications to do. Please review the new patch series and share your f

[PATCH v2 6/7] mhi_bus: controller: MHI support for QCOM modems

2018-07-09 Thread Sujeev Dias
QCOM PCIe based modems uses MHI as the communication protocol. MHI control driver is the bus master for such modems. As the bus master driver, it oversees power management operations such as suspend, resume, powering on and off the device. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong

[PATCH v2 7/7] mhi_bus: dev: uci: add user space interface driver

2018-07-09 Thread Sujeev Dias
This module allows user space clients to transfer data between external modem and host using standard file operations. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- arch/arm64/configs/defconfig | 1 + drivers/bus/Kconfig | 1

[PATCH v2 5/7] mhi_bus: core: add support to get external modem time

2018-07-09 Thread Sujeev Dias
For accurate synchronizations between external modem and host processor, mhi host will capture modem time relative to host time. Client may use time measurements for adjusting any drift between host and modem. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha

[PATCH v2 4/7] mhi_bus: core: add support for handling ioctl cmds

2018-07-09 Thread Sujeev Dias
User space clients use RS232 control signaling mechanism to communicate call status between host and modem. Adding support to handle ioctl commands from user space. Signed-off-by: Sujeev Dias Reviewed-by: Tony Truong Signed-off-by: Siddartha Mohanadoss --- drivers/bus/mhi/core/Makefile

Re: [PATCH v1 1/4] mhi_bus: core: Add support for MHI host interface

2018-05-03 Thread Sujeev Dias
Hi Pavel On 05/03/2018 12:21 PM, Pavel Machek wrote: Hi! MHI Host Interface is a communication protocol to be used by the host to control and communcate with modem over a high speed peripheral bus. This module will allow host to communicate with external devices that support MHI protocol. I

Re: [PATCH v1 1/4] mhi_bus: core: Add support for MHI host interface

2018-04-28 Thread Sujeev Dias
On 04/27/2018 05:18 AM, Arnd Bergmann wrote: On Fri, Apr 27, 2018 at 4:23 AM, Sujeev Dias wrote: diff --git a/Documentation/devicetree/bindings/bus/mhi.txt b/Documentation/devicetree/bindings/bus/mhi.txt new file mode 100644 index 000..ea1b620 --- /dev/null +++ b/Documentation

Re: [PATCH v1 2/4] mhi_bus: controller: MHI support for QCOM modems

2018-04-28 Thread Sujeev Dias
On 04/27/2018 04:32 AM, Arnd Bergmann wrote: On Fri, Apr 27, 2018 at 4:23 AM, Sujeev Dias wrote: QCOM PCIe based modems uses MHI as the communication protocol. MHI control driver is the bus master for such modems. As the bus master driver, it oversees power management operations such as

Re: [PATCH v1 3/4] mhi_bus: dev: netdev: add network interface driver

2018-04-28 Thread Sujeev Dias
On 04/27/2018 04:19 AM, Arnd Bergmann wrote: On Fri, Apr 27, 2018 at 4:23 AM, Sujeev Dias wrote: MHI based net device driver is used for transferring IP traffic between host and modem. Driver allows clients to transfer data using standard network interface. Signed-off-by: Sujeev Dias

Re: [PATCH v1 1/4] mhi_bus: core: Add support for MHI host interface

2018-04-28 Thread Sujeev Dias
Thanks for quick feedback On 04/27/2018 12:22 AM, Greg Kroah-Hartman wrote: On Thu, Apr 26, 2018 at 07:23:28PM -0700, Sujeev Dias wrote: MHI Host Interface is a communication protocol to be used by the host to control and communcate with modem over a high speed peripheral bus. This module

MHI initial design review

2018-04-26 Thread Sujeev Dias
Hi Greg Kroah-Hartman\All This is the initial submit of Modem Host Interface (MHI) stack for upstream consideration. MHI is a communication protocol to communicate with external Qualcomm modems and Wi-Fi chipsets over high speed peripheral buses. Even though MHI doesn’t dictate underlying physical

[PATCH v1 2/4] mhi_bus: controller: MHI support for QCOM modems

2018-04-26 Thread Sujeev Dias
QCOM PCIe based modems uses MHI as the communication protocol. MHI control driver is the bus master for such modems. As the bus master driver, it oversees power management operations such as suspend, resume, powering on and off the device. Signed-off-by: Sujeev Dias --- Documentation/devicetree

[PATCH v1 3/4] mhi_bus: dev: netdev: add network interface driver

2018-04-26 Thread Sujeev Dias
MHI based net device driver is used for transferring IP traffic between host and modem. Driver allows clients to transfer data using standard network interface. Signed-off-by: Sujeev Dias --- Documentation/devicetree/bindings/bus/mhi.txt | 36 ++ drivers/bus/Kconfig

[PATCH v1 4/4] mhi_bus: dev: uci: add user space interface driver

2018-04-26 Thread Sujeev Dias
This module allows user space clients to transfer data between external modem and host using standard file operations. Signed-off-by: Sujeev Dias --- drivers/bus/mhi/devices/Kconfig | 9 + drivers/bus/mhi/devices/Makefile | 1 + drivers/bus/mhi/devices/mhi_uci.c | 662