From: Cody P Schafer d...@codyps.com
CC: Haren Myneni hb...@us.ibm.com
CC: Cody P Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
.../testing/sysfs-bus-event_source-devices-hv_24x7 | 22
From: Cody P Schafer d...@codyps.com
CC: Haren Myneni hb...@us.ibm.com
CC: Cody P Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/util/pmu.c | 4 ++--
tools/perf/util/pmu.h | 6 +++---
2
-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
arch/powerpc/perf/hv-common.c | 10 +-
arch/powerpc/perf/hv-gpci-requests.h | 79 +++
arch/powerpc/perf/hv-gpci.c| 8 ++
arch/powerpc/perf/hv
...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
arch/powerpc/perf/hv-gpci-requests.h | 179 +++
1 file changed, 179 insertions(+)
diff --git a/arch/powerpc/perf/hv-gpci-requests.h
b/arch/powerpc/perf/hv-gpci-requests.h
index 0dfc4d9
From: Cody P Schafer d...@codyps.com
What this patchset does:
- the first patch (override sysfs in tools/perf via SYSFS_PATH) was sent out
previously, but needed a resend anyhow. Having it is useful for testing the
later changes to tools/perf.
- the second patch is a bugfix to the
: Cody P Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/util/parse-events.h | 1 +
tools/perf/util/pmu.c | 55 ++
2 files changed, 46 insertions
=?/
[Kernel PMU event]
CC: Haren Myneni hb...@us.ibm.com
CC: Cody P Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/util/pmu.c | 26 +-
1 file changed, 25 insertions(+), 1
). This isn't possible because
bindings between our cpus and physical cpus may not be fixed, and we
probably won't have a cpu on each physical cpu.
CC: Haren Myneni hb...@us.ibm.com
CC: Cody P Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka
...@us.ibm.com
CC: Cody P Schafer d...@codyps.com
Reported-by: Ian Munsie imun...@au1.ibm.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
arch/powerpc/perf/hv-24x7.c | 52 -
1 file changed
for arbitrary event file contents.
CC: Haren Myneni hb...@us.ibm.com
CC: Cody P Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
.../testing/sysfs-bus-event_source-devices-events | 573
Schafer d...@codyps.com
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
include/linux/perf_event.h | 3 +++
kernel/events/core.c | 8
2 files changed, 11 insertions(+)
diff --git a/include/linux/perf_event.h b
[PATCH] powerpc/perf: Explicitly include util/debug.h
Looks like util/debug.h was indirectly included before and
is no longer included now. pr_debug is left undefined and
the build of perf tool fails on Powerpc.
Explicitly include util/debug.h.
Signed-off-by: Sukadev Bhattiprolu
---
tools
[PATCH] powerpc/perf: Explicitly include util/debug.h
Looks like util/debug.h was indirectly included before and
is no longer included now. pr_debug is left undefined and
the build of perf tool fails on Powerpc.
Explicitly include util/debug.h.
Signed-off-by: Sukadev Bhattiprolu suka
(), on Powerpc, we can skip the --events-file option
and run:
perf stat -e PM_CYC sleep 1
Signed-off-by: Sukadev Bhattiprolu
---
Note: This patch is based on Andi Kleen's recent patchset
https://lkml.org/lkml/2014/7/30/693
Changelog[v2]:
[Michael Ellerman]: Use PVR instead
(), on Powerpc, we can skip the --events-file option
and run:
perf stat -e PM_CYC sleep 1
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Note: This patch is based on Andi Kleen's recent patchset
https://lkml.org/lkml/2014/7/30/693
Changelog[v2]:
[Michael
Dietmar Eggemann [dietmar.eggem...@arm.com] wrote:
| > ltcbrazos2-lp07 login: [ 181.915974] [ cut here ]
| > [ 181.915991] WARNING: at ../kernel/sched/core.c:5881
|
| This warning indicates the problem. One of the struct sched_domains does
| not have it's groups member
Dietmar Eggemann [dietmar.eggem...@arm.com] wrote:
| ltcbrazos2-lp07 login: [ 181.915974] [ cut here ]
| [ 181.915991] WARNING: at ../kernel/sched/core.c:5881
|
| This warning indicates the problem. One of the struct sched_domains does
| not have it's groups member
I am getting this crash on a Powerpc system using 3.16.0-rc7 kernel plus
some patches related to perf (24x7 counters) that Cody Schafer posted here:
https://lkml.org/lkml/2014/5/27/768
I don't get the crash on an unpatched kernel though.
I have been staring at the perf event patches,
I am getting this crash on a Powerpc system using 3.16.0-rc7 kernel plus
some patches related to perf (24x7 counters) that Cody Schafer posted here:
https://lkml.org/lkml/2014/5/27/768
I don't get the crash on an unpatched kernel though.
I have been staring at the perf event patches,
Commit-ID: c94b93cbca59435dfc0f2a838fea55bd632145d3
Gitweb: http://git.kernel.org/tip/c94b93cbca59435dfc0f2a838fea55bd632145d3
Author: Sukadev Bhattiprolu
AuthorDate: Thu, 24 Jul 2014 00:47:18 -0700
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 24 Jul 2014 11:00:39 -0300
perf
Commit-ID: c94b93cbca59435dfc0f2a838fea55bd632145d3
Gitweb: http://git.kernel.org/tip/c94b93cbca59435dfc0f2a838fea55bd632145d3
Author: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
AuthorDate: Thu, 24 Jul 2014 00:47:18 -0700
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate
perf tool would refer to the
PMU events defined in ~/.cache/pmu-events/power8.json.
Signed-off-by: Sukadev Bhattiprolu
---
tools/perf/arch/powerpc/util/header.c | 69 +
tools/perf/perf.c | 11 ++
tools/perf/perf.h |2
[RFC PATCH 1/2] powerpc/perf: include util/util.h and remove stringify macros
The stringify macros are defined in tools/perf/util/util.h and
don't need to be redfined specfiically for powerpc.
Signed-off-by: Sukadev Bhattiprolu
---
tools/perf/arch/powerpc/util/header.c |4 +---
1 file
These two patches implement get_cpu_str() for powerpc.
get_cpu_str() will allow users to cache their perf event JSON files
and skip having to specify the --events-file with each perf invocation.
These patches are based on the commit
commit 4a5e890
Author: Andi Kleen
These two patches implement get_cpu_str() for powerpc.
get_cpu_str() will allow users to cache their perf event JSON files
and skip having to specify the --events-file with each perf invocation.
These patches are based on the commit
commit 4a5e890
Author: Andi Kleen
[RFC PATCH 1/2] powerpc/perf: include util/util.h and remove stringify macros
The stringify macros are defined in tools/perf/util/util.h and
don't need to be redfined specfiically for powerpc.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/arch/powerpc/util
refer to the
PMU events defined in ~/.cache/pmu-events/power8.json.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/arch/powerpc/util/header.c | 69 +
tools/perf/perf.c | 11 ++
tools/perf/perf.h
Andi Kleen [a...@firstfloor.org] wrote:
| +static const char *json_default_name(void)
| +{
| + char *cache;
| + char *idstr = get_cpu_str();
| + char *res = NULL;
| + char *home = NULL;
| + char *emap;
| +
| + emap = getenv("EVENTMAP");
| + if (emap) {
| +
Andi Kleen [a...@firstfloor.org] wrote:
| Works for me with your input file:
|
| % perf list --events-file t.json
| ...
| pm_cyc [Cycles completed]
| pm_inst_cmpl [Instructions completed]
Ah, lower case.
|
|
Andi Kleen [a...@firstfloor.org] wrote:
| Should be ready for merge now. Please consider.
Overall I think it is a cool feature. I was able to run some simple
tests on Power8 (by explicitly specifying the JSON file). Have a couple
of questions below.
|
| [v2: Review feedback addressed and some
Andi Kleen [a...@firstfloor.org] wrote:
| Should be ready for merge now. Please consider.
Overall I think it is a cool feature. I was able to run some simple
tests on Power8 (by explicitly specifying the JSON file). Have a couple
of questions below.
|
| [v2: Review feedback addressed and some
Andi Kleen [a...@firstfloor.org] wrote:
| Works for me with your input file:
|
| % perf list --events-file t.json
| ...
| pm_cyc [Cycles completed]
| pm_inst_cmpl [Instructions completed]
Ah, lower case.
|
|
Andi Kleen [a...@firstfloor.org] wrote:
| +static const char *json_default_name(void)
| +{
| + char *cache;
| + char *idstr = get_cpu_str();
| + char *res = NULL;
| + char *home = NULL;
| + char *emap;
| +
| + emap = getenv(EVENTMAP);
| + if (emap) {
| + if
Commit-ID: a60335ba32981db5bc057b35782644e9e2436407
Gitweb: http://git.kernel.org/tip/a60335ba32981db5bc057b35782644e9e2436407
Author: Sukadev Bhattiprolu
AuthorDate: Wed, 25 Jun 2014 08:49:03 -0700
Committer: Jiri Olsa
CommitDate: Fri, 27 Jun 2014 11:14:51 +0200
perf tools powerpc
Commit-ID: a60335ba32981db5bc057b35782644e9e2436407
Gitweb: http://git.kernel.org/tip/a60335ba32981db5bc057b35782644e9e2436407
Author: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
AuthorDate: Wed, 25 Jun 2014 08:49:03 -0700
Committer: Jiri Olsa jo...@kernel.org
CommitDate: Fri, 27 Jun
() to be
consistent with behavior.
[Jiri Olsa] Add '__maybe_unused' tags for unused parameters.
Changelog[v2]:
Add missing dwfl_end()
Fix merge conflicts due to some unwind code
Reported-by: Maynard Johnson
Tested-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
---
tools
-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/arch/powerpc/Makefile |1 +
tools/perf/arch/powerpc/util/skip-callchain-idx.c | 266 +
tools/perf/config/Makefile|4 +
tools/perf/util/callchain.h
Blanchard.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson
Tested-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v5]
[Jiri Olsa] Avoid the new external symbol PERF_CONTEXT_IGNORE;
Revert back to previous
Blanchard.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson mayn...@us.ibm.com
Tested-by: Maynard Johnson mayn...@us.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v5]
[Jiri Olsa] Avoid the new external
the CFA
even without the .eh_frame section.
Fix suggested by Anton Blanchard.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson
Tested-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v4]
Move Powerpc
interfaces:
arch_skip_callchain_idx()
next_callchain_ip()
Reported-by: Maynard Johnson
Tested-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v4]
Move Powerpc-specific code to separate patch
[Jiri Olsa] Minimize performance impact to other
interfaces:
arch_skip_callchain_idx()
next_callchain_ip()
Reported-by: Maynard Johnson mayn...@us.ibm.com
Tested-by: Maynard Johnson mayn...@us.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v4]
Move Powerpc-specific code to separate patch
the CFA
even without the .eh_frame section.
Fix suggested by Anton Blanchard.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson mayn...@us.ibm.com
Tested-by: Maynard Johnson mayn...@us.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka
Jiri Olsa [jo...@redhat.com] wrote:
| On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote:
|
| SNIP
|
| > |
| > |
| > | could you please change this, so it's nop for arch != powerpc
| > | via #ifdef I guess.. or some other smart way ;-)
| >
| > I was trying t
Jiri Olsa [jo...@redhat.com] wrote:
| On Tue, Jun 03, 2014 at 12:47:10AM -0700, Sukadev Bhattiprolu wrote:
|
| SNIP
|
| |
| |
| | could you please change this, so it's nop for arch != powerpc
| | via #ifdef I guess.. or some other smart way ;-)
|
| I was trying to avoid the #ifdef
Jiri Olsa [jo...@redhat.com] wrote:
| On Fri, May 30, 2014 at 05:59:25PM +0200, Jiri Olsa wrote:
| > On Fri, May 30, 2014 at 08:50:19AM -0700, Sukadev Bhattiprolu wrote:
| > > Jiri Olsa [jo...@redhat.com] wrote:
| > > | On Fri, May 16, 2014 at 02:03:33PM -0700, Sukadev Bh
Jiri Olsa [jo...@redhat.com] wrote:
| On Fri, May 30, 2014 at 05:59:25PM +0200, Jiri Olsa wrote:
| On Fri, May 30, 2014 at 08:50:19AM -0700, Sukadev Bhattiprolu wrote:
| Jiri Olsa [jo...@redhat.com] wrote:
| | On Fri, May 16, 2014 at 02:03:33PM -0700, Sukadev Bhattiprolu wrote:
| | Hi
.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson
Tested-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v3]
[Jiri Olsa] Rename function to arch_skip_callchain_idx() to be
consistent with behavior
Jiri Olsa [jo...@redhat.com] wrote:
|
| yep, that sounds more clear to me.. something like below?
|
| calling callchain_dup from within arch_adjust_callchain in case
| you want to change it and returning != 0 in this case, so
| we could free the new callchain
Agree.
|
| but it might be to
Jiri Olsa [jo...@redhat.com] wrote:
|
| yep, that sounds more clear to me.. something like below?
|
| calling callchain_dup from within arch_adjust_callchain in case
| you want to change it and returning != 0 in this case, so
| we could free the new callchain
Agree.
|
| but it might be to
.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson mayn...@us.ibm.com
Tested-by: Maynard Johnson mayn...@us.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v3]
[Jiri Olsa] Rename function
.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson
Tested-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
Acked-by: Maynard Johnson
---
Changelog[v2]:
- Add missing dwfl_end()
- Fix merge conflicts due to some unwind code
.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson mayn...@us.ibm.com
Tested-by: Maynard Johnson mayn...@us.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Acked-by: Maynard Johnson mayn...@us.ibm.com
---
Changelog[v2
Maynard Johnson [mpj...@us.ibm.com] wrote:
| > [PATCH 1/1] powerpc/perf: Adjust callchain based on DWARF debug info
|
| Acked-by: Maynard Johnson
|
| Reviewed and tested. Thanks, Suka.
Thanks Maynard. This updated patch also fixes whitespace damage.
From: Sukadev Bhattiprolu
Date: Fri
even without the .eh_frame section.
Fix suggested by Anton Blanchard.
Thanks to valuable input on DWARF debug information from Ulrich Weigand.
Reported-by: Maynard Johnson mayn...@us.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Tested-by: Maynard Johnson mayna
.eh_frame and .debug_info
sections are available. We should be able to determin the CFA
even without the .eh_frame section.
Thanks to Ulrich Weigand for help with DWARF debug information.
Fix suggested by Anton Blanchard.
Reported-by: Maynard Johnson
Signed-off-by: Sukadev Bhattiprolu
-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/arch/powerpc/Makefile| 1 +
tools/perf/arch/powerpc/util/adjust-callchain.c | 278
tools/perf/config/Makefile | 5 +
tools/perf/util/callchain.h | 12
>From 9ad9432dab2bf4d1c8e6ff9201e88d5ae9f3994a Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu
Date: Wed, 19 Mar 2014 20:24:22 -0500
Subject: [PATCH 1/1] perf: Add 'merge-recursive' callchain option
Powerpc saves the link register (LR) with each sample to help resolve
callchains for progr
From 9ad9432dab2bf4d1c8e6ff9201e88d5ae9f3994a Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Wed, 19 Mar 2014 20:24:22 -0500
Subject: [PATCH 1/1] perf: Add 'merge-recursive' callchain option
Powerpc saves the link register (LR) with each sample to help
When checking whether a bit representing a register is set in
sample_regs, a 64-bit mask, use 64-bit value (1LL).
Signed-off-by: Sukadev Bhattiprolu
---
tools/perf/util/unwind.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/unwind.c b/tools/perf/util
bdnz1b
li 0,1 /* sys_exit */
sc
work:
mflr30
bl work2
mtlr30
blr
work2:
blr
Sukadev Bhattiprolu (3):
power: perf: Enable saving the u
with libunwind and libunwind-devel libdwarf packages
installed.
TODO:
- Not sure if we need to list all the Power registers or restrict
to only those that libunwind needs.
- Check about perf_reg_abi()
- Build for 32-bit
Signed-off-by: Sukadev Bhattiprolu
file).
But we save the user-stack only when user explicitly requests it:
perf record --call-graph=dwarf,8192
Signed-off-by: Sukadev Bhattiprolu
---
arch/powerpc/Kconfig |2 +
arch/powerpc/include/uapi/asm/perf_regs.h | 70 +++
arch/powerpc/perf
with libunwind and libunwind-devel libdwarf packages
installed.
TODO:
- Not sure if we need to list all the Power registers or restrict
to only those that libunwind needs.
- Check about perf_reg_abi()
- Build for 32-bit
Signed-off-by: Sukadev Bhattiprolu suka
file).
But we save the user-stack only when user explicitly requests it:
perf record --call-graph=dwarf,8192 application
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
arch/powerpc/Kconfig |2 +
arch/powerpc/include/uapi/asm/perf_regs.h | 70
When checking whether a bit representing a register is set in
sample_regs, a 64-bit mask, use 64-bit value (1LL).
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/util/unwind.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util
*/
sc
work:
mflr30
bl work2
mtlr30
blr
work2:
blr
Sukadev Bhattiprolu (3):
power: perf: Enable saving the user stack in a sample.
power: perf tool: Add libunwind
Ingo Molnar [mi...@kernel.org] wrote:
|
| * Peter Zijlstra wrote:
|
| > On Tue, Nov 05, 2013 at 02:31:52PM -0300, Arnaldo Carvalho de Melo wrote:
| > > PeterZ,
| > >
| > > Can I have your Acked-by for this one? I guess now the goal is
| > > achieved, no?
Being able to profile children with
Ingo Molnar [mi...@kernel.org] wrote:
|
| * Peter Zijlstra pet...@infradead.org wrote:
|
| On Tue, Nov 05, 2013 at 02:31:52PM -0300, Arnaldo Carvalho de Melo wrote:
| PeterZ,
|
| Can I have your Acked-by for this one? I guess now the goal is
| achieved, no?
Being able to profile
A gently tested RFC patch...
---
>From 38554891fc41082b767f24ce3293658f7329a691 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu
Date: Fri, 8 Nov 2013 17:14:06 -0800
Subject: [PATCH] Fix inhert with perf record --pid
If a target process is identified by its pid:
perf record --
A gently tested RFC patch...
---
From 38554891fc41082b767f24ce3293658f7329a691 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
Date: Fri, 8 Nov 2013 17:14:06 -0800
Subject: [PATCH] Fix inhert with perf record --pid
If a target process is identified by its pid
ael Ellerman and comments from Tom Musta.
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v6]
- [David Laight, Anshuman Khandual] Add a comment in function
header to help better understand which instructions are selected
by the instr_is_load_store_2
on optimized code from Michael Ellerman and comments from Tom Musta.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v6]
- [David Laight, Anshuman Khandual] Add a comment in function
header to help better understand which instructions are selected
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote:
| On 10/16/2013 01:55 PM, David Laight wrote:
| >> Implement instr_is_load_store_2_06() to detect whether a given instruction
| >> is one of the fixed-point or floating-point load/store instructions in the
| >> POWER Instruction Set
David Laight [david.lai...@aculab.com] wrote:
|
| I can't help feeling the code could do with some comments about
| which actual instructions are selected where.
At a high level, only the load and store instructions are selected.
I added a reference to the Appendix F (Opcode maps) in the
David Laight [david.lai...@aculab.com] wrote:
|
| I can't help feeling the code could do with some comments about
| which actual instructions are selected where.
At a high level, only the load and store instructions are selected.
I added a reference to the Appendix F (Opcode maps) in the
Anshuman Khandual [khand...@linux.vnet.ibm.com] wrote:
| On 10/16/2013 01:55 PM, David Laight wrote:
| Implement instr_is_load_store_2_06() to detect whether a given instruction
| is one of the fixed-point or floating-point load/store instructions in the
| POWER Instruction Set Architecture
The logic used in branch_opcode() to extract the opcode for an instruction
applies to non branch instructions also. So rename to instr_opcode().
Signed-off-by: Sukadev Bhattiprolu
---
arch/powerpc/lib/code-patching.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Khandual.
Sukadev Bhattiprolu (10):
powerpc: Rename branch_opcode() to instr_opcode()
powerpc/Power7: detect load/store instructions
tools/perf: silence compiler warnings
tools/perf: Remove local byteorder.h.
powerpc/perf: Remove PME_ prefix for power7 events
powerpc/perf: Export Power8
The uninitialized variables cause warnings which are treated as errors
during build (without WERROR=0).
Signed-off-by: Sukadev Bhattiprolu
---
tools/perf/util/srcline.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util
-off-by: Sukadev Bhattiprolu
---
tools/perf/Makefile |1 -
tools/perf/util/include/asm/byteorder.h |2 --
tools/perf/util/include/linux/types.h | 20
3 files changed, 20 insertions(+), 3 deletions(-)
delete mode 100644 tools/perf/util/include
Signed-off-by: Sukadev Bhattiprolu
---
arch/powerpc/include/asm/perf_event_server.h |2 +-
arch/powerpc/perf/power7-pmu.c | 18 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/include/asm/perf_event_server.h
b/arch/powerpc
Export generic perf events for Power8 in sysfs.
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v6]:
[Michael Ellerman] Drop PME_ prefix in macros
arch/powerpc/perf/power8-events-list.h | 20 +++
arch/powerpc/perf/power8-pmu.c | 44
perf_mem_data_src is an union that is initialized via the ->val field
and accessed via the bitmap fields. For this to work on big endian
platforms, we also need a big-endian represenation of perf_mem_data_src.
Cc: Stephane Eranian
Cc: Michael Ellerman
Signed-off-by: Sukadev Bhattipr
hael Ellerman
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v4]:
Drop support for 'perf mem' for Power (use perf-record and perf-report
directly)
Changelog[v3]:
[Michael Ellerman] If newer levels that we defined in [v2] are not
needed for Power8, ignore the n
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy
of applications.
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v6]:
- [Michael Ellerman]: Drop redundant PME_ prefix from event name.
arch/powerpc/perf/power8-events-list.h |1 +
1 file changed, 1 insertion
on Power for now.
Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling.
Cc: Stephane Eranian
Cc: Michael Ellerman
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v2]:
Drop support for 'perf mem' for Power (use perf-record and perf-report
directly)
on a Power7 system. (Power8 systems set some
bits in the SIER to identify load/store operations and hence don't need a
similar functionality).
Based on optimized code from Michael Ellerman and comments from Tom Musta.
Signed-off-by: Sukadev Bhattiprolu
---
Changelog[v6]
- [Michael Ellerman
on a Power7 system. (Power8 systems set some
bits in the SIER to identify load/store operations and hence don't need a
similar functionality).
Based on optimized code from Michael Ellerman and comments from Tom Musta.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v6
for now.
Thanks to input from Stephane Eranian, Michael Ellerman and Michael Neuling.
Cc: Stephane Eranian eran...@google.com
Cc: Michael Ellerman mich...@ellerman.id.au
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v2]:
Drop support for 'perf mem' for Power (use
The perf event PM_MRK_GRP_CMPL is useful in analyzing memory hierarchy
of applications.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v6]:
- [Michael Ellerman]: Drop redundant PME_ prefix from event name.
arch/powerpc/perf/power8-events-list.h |1 +
1
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog [v6]
- [Michael Ellerman] Use __BIG_ENDIAN_BITFIELD to simplify the
endian check.
Changelog [v5]:
- perf_event.h includes byteorder.h which pulls in the local
byteorder.h when building
...@google.com
Cc: Michael Ellerman mich...@ellerman.id.au
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v4]:
Drop support for 'perf mem' for Power (use perf-record and perf-report
directly)
Changelog[v3]:
[Michael Ellerman] If newer levels that we defined
Export generic perf events for Power8 in sysfs.
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
Changelog[v6]:
[Michael Ellerman] Drop PME_ prefix in macros
arch/powerpc/perf/power8-events-list.h | 20 +++
arch/powerpc/perf/power8-pmu.c | 44
eller...@au1.ibm.com
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
arch/powerpc/include/asm/perf_event_server.h |2 +-
arch/powerpc/perf/power7-pmu.c | 18 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/powerpc/include
-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/Makefile |1 -
tools/perf/util/include/asm/byteorder.h |2 --
tools/perf/util/include/linux/types.h | 20
3 files changed, 20 insertions(+), 3 deletions(-)
delete mode 100644
The logic used in branch_opcode() to extract the opcode for an instruction
applies to non branch instructions also. So rename to instr_opcode().
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
arch/powerpc/lib/code-patching.c |6 +++---
1 file changed, 3 insertions(+), 3
Khandual.
Sukadev Bhattiprolu (10):
powerpc: Rename branch_opcode() to instr_opcode()
powerpc/Power7: detect load/store instructions
tools/perf: silence compiler warnings
tools/perf: Remove local byteorder.h.
powerpc/perf: Remove PME_ prefix for power7 events
powerpc/perf: Export Power8
The uninitialized variables cause warnings which are treated as errors
during build (without WERROR=0).
Signed-off-by: Sukadev Bhattiprolu suka...@linux.vnet.ibm.com
---
tools/perf/util/srcline.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/srcline.c
Michael Ellerman [mich...@ellerman.id.au] wrote:
| bool is_load_store(int ext_opcode)
| {
| upper = ext_opcode >> 5;
| lower = ext_opcode & 0x1f;
|
| /* Short circuit as many misses as we can */
| if (lower < 3 || lower > 23)
| return false;
I see some
1401 - 1500 of 1764 matches
Mail list logo
