Re: [PATCH] dma-buf: add ref counting for module as exporter

2015-05-07 Thread Sumit Semwal
On 7 May 2015 at 13:40, Greg KH wrote: > On Thu, May 07, 2015 at 01:00:52PM +0530, Sumit Semwal wrote: >> Add reference counting on a kernel module that exports dma-buf and >> implements its operations. This prevents the module from being unloaded >> while DMABUF file

[PATCH] dma-buf: add ref counting for module as exporter

2015-05-07 Thread Sumit Semwal
[tomasz: Original author] Signed-off-by: Tomasz Stanislawski Acked-by: Daniel Vetter [sumits: updated & rebased as per review comments] Signed-off-by: Sumit Semwal [1]: https://lkml.org/lkml/2012/8/8/163 --- drivers/dma-buf/dma-buf.c | 9 - drivers/

Re: [RFCv3 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-05-05 Thread Sumit Semwal
Hi Russell, everyone, First up, sincere apologies for being awol for sometime; had some personal / medical things to take care of, and then I thought I'd wait for the merge window to get over before beginning to discuss this again. On 11 February 2015 at 21:53, Russell King - ARM Linux wrote: >

[GIT PULL]: dma-buf updates for 4.1-rc1

2015-04-24 Thread Sumit Semwal
rection of copy-paste stupidity while doing the cleanup -------- Sumit Semwal (2): dma-buf: cleanup dma_buf_export() to make it easily extensible staging: android: ion: fix wrong init of dma_buf_export_info Documentation/dma-

[GIT PULL]: dma-buf fixes for 4.0

2015-03-03 Thread Sumit Semwal
Hi Linus, May I please request you to pull a couple of fixes in dma-buf for 4.0-rc3? The following changes since commit b942c653ae265abbd31032f3b4f5f857e5c7c723: Merge tag 'trace-sh-3.19' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace (2015-01-22 06:26:07 +1200) are ava

[PATCH] staging: android: ion: fix wrong init of dma_buf_export_info

2015-02-24 Thread Sumit Semwal
113 exp_info.flags = O_RDWR; 1114 exp_info.priv = buffer; ^^ And here also. 1115 This patch corrects this stupidity. Reported-by: Dan Carpenter Signed-off-by: Sumit Semwal --- drivers/staging/android/ion/ion.c | 10 +- 1 file

Re: [GIT PULL]: few dma-buf updates for 3.20-rc1

2015-02-22 Thread Sumit Semwal
Hi Linus, On 22 February 2015 at 01:42, Linus Torvalds wrote: > On Fri, Feb 20, 2015 at 8:27 AM, Sumit Semwal wrote: >> >> Could you please pull a few dma-buf changes for 3.20-rc1? Nothing >> fancy, minor cleanups. > > No. > > I pulled, and immediately unpulled

[GIT PULL]: few dma-buf updates for 3.20-rc1

2015-02-20 Thread Sumit Semwal
ion: wait only with non-zero timeout specified (v3) dma-buf/fence: don't wait when specified timeout is zero Michel Dänzer (1): reservation: Remove shadowing local variable 'ret' Sumit Semwal (1): dma-buf: cleanup dma_buf_export() to make it easily extensible Docu

Re: [RFCv3 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-02-01 Thread Sumit Semwal
Hi Russell, On 30 January 2015 at 00:56, Russell King - ARM Linux wrote: > On Thu, Jan 29, 2015 at 01:52:09PM -0500, Rob Clark wrote: >> Quite possibly for some of these edge some of cases, some of the >> dma-buf exporters are going to need to get more clever (ie. hand off >> different scatterlis

Re: [RFCv3 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-01-29 Thread Sumit Semwal
On 29 January 2015 at 21:17, Russell King - ARM Linux wrote: > On Thu, Jan 29, 2015 at 09:00:11PM +0530, Sumit Semwal wrote: >> So, short answer is, it is left to the exporter to decide. The dma-buf >> framework should not even attempt to decide or enforce any of the >>

Re: [RFCv3 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-01-29 Thread Sumit Semwal
Hi Russell! On 29 January 2015 at 20:09, Russell King - ARM Linux wrote: > On Tue, Jan 27, 2015 at 01:55:54PM +0530, Sumit Semwal wrote: >> +/* >> + * recalc_constraints - recalculates constraints for all attached devices; >> + * useful for detach() r

Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
On 28 January 2015 at 16:50, Daniel Thompson wrote: > On 28/01/15 06:00, Sumit Semwal wrote: >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a)\ >> +

[PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
() with dma_buf_export(), and change all callers accordingly. Signed-off-by: Sumit Semwal --- v3: Daniel Thompson caught the C99 warning issue w/ using {0}; using {.exp_name = xxx} instead. v2: add macro to zero out local struct, and fill KBUILD_MODNAME by default drivers/dma-buf/dma-buf.c

Re: [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
Hi Mauro, On 28 January 2015 at 18:53, Mauro Carvalho Chehab wrote: > Em Wed, 28 Jan 2015 18:24:03 +0530 > Sumit Semwal escreveu: > >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT

[PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-27 Thread Sumit Semwal
() with dma_buf_export(), and change all callers accordingly. Signed-off-by: Sumit Semwal --- v2: add macro to zero out local struct, and fill KBUILD_MODNAME by default drivers/dma-buf/dma-buf.c | 47 +- drivers/gpu/drm/armada/armada_gem.c

[RFCv3 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-01-27 Thread Sumit Semwal
l the time, - dma_buf_recalc_constraints - which recalculates the constraints for all currently attached devices for the 'paranoid' ones amongst us. The idea of this patch is largely taken from Rob Clark's RFC at https://lkml.org/lkml/2012/7/19/285, and the comments received on it. Cc: Rob Clark Si

[RFCv3 1/2] device: add dma_params->max_segment_count

2015-01-27 Thread Sumit Semwal
[sumits: Minor updates wrt comments] Signed-off-by: Sumit Semwal --- v3: include Robin Murphy's fix[1] for handling '0' as a value for max_segment_count v2: minor updates wrt comments on the first version [1]: http://article.gmane.org/gmane.linux.kernel.iommu/8175/

Re: [RFCv2 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-01-26 Thread Sumit Semwal
Hi Russell! On 21 January 2015 at 23:01, Russell King - ARM Linux wrote: > On Wed, Jan 21, 2015 at 09:46:47AM +0530, Sumit Semwal wrote: >> +static int calc_constraints(struct device *dev, >> + struct dma_buf_constraints *calc_cons) >&g

[RFC] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-22 Thread Sumit Semwal
() with dma_buf_export(), and change all callers accordingly. Signed-off-by: Sumit Semwal --- drivers/dma-buf/dma-buf.c | 47 +- drivers/gpu/drm/armada/armada_gem.c| 12 +-- drivers/gpu/drm/drm_prime.c| 14

Re: [RFCv2 1/2] device: add dma_params->max_segment_count

2015-01-21 Thread Sumit Semwal
Hi Robin! On 22 January 2015 at 00:26, Robin Murphy wrote: > Hi Sumit, > > > On 21/01/15 04:16, Sumit Semwal wrote: >> >> From: Rob Clark >> >> For devices which have constraints about maximum number of segments in >> an sglist. For example, a de

Re: [PATCH RESEND] dma-mapping: tidy up dma_parms default handling

2015-01-21 Thread Sumit Semwal
ly more meaningful >> macros and removing the superfluous "else" statements. >> >> Signed-off-by: Robin Murphy > > > Acked-by: Marek Szyprowski Please feel free to add my Reviewed-by: Sumit Semwal > >> --- >> >> Hi, various maintainers fro

[RFCv2 2/2] dma-buf: add helpers for sharing attacher constraints with dma-parms

2015-01-20 Thread Sumit Semwal
the comments received on it. Cc: Rob Clark Signed-off-by: Sumit Semwal --- drivers/dma-buf/dma-buf.c | 132 +- include/linux/dma-buf.h | 22 2 files changed, 153 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-buf.c b/driver

[RFCv2 0/2] dma-parms, constraints and helpers for dma-buf

2015-01-20 Thread Sumit Semwal
the RFC for this one, to get feedback on whether this mechanism seems ok to everyone. [1] https://lkml.org/lkml/2014/10/10/340 [2] https://lkml.org/lkml/2012/7/19/285 Rob Clark (1): device: add dma_params->max_segment_count Sumit Semwal (1): dma-buf: add helpers for sharing attache

[RFCv2 1/2] device: add dma_params->max_segment_count

2015-01-20 Thread Sumit Semwal
[sumits: Minor updates wrt comments on the first version] Signed-off-by: Sumit Semwal --- include/linux/device.h | 1 + include/linux/dma-mapping.h | 19 +++ 2 files changed, 20 insertions(+) diff --git a/include/linux/device.h b/include/linux/device.h index fb50673..a32f

Re: [RFC 1/4] dma-buf: Add constraints sharing information

2014-12-10 Thread Sumit Semwal
Hi Daniel, Thanks a bunch for your review comments! A few comments, post our discussion at LPC; On 12 October 2014 at 00:25, Daniel Vetter wrote: > On Sat, Oct 11, 2014 at 01:37:55AM +0530, Sumit Semwal wrote: >> At present, struct device lacks a mechanism of exposing memory

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Sumit Semwal
On 24 November 2014 at 21:24, Felipe Balbi wrote: > On Mon, Nov 24, 2014 at 09:19:09PM +0530, Sumit Semwal wrote: >> Hi Felipe, >> >> On 24 November 2014 at 20:08, Felipe Balbi wrote: >> > Hi, >> > >> > On Fri, Nov 21, 2014 at 09:13:00PM +0530, Ki

Re: [PATCH v1 2/3] usb: phy: Handle per-PHY event for connect and disconnect events

2014-11-24 Thread Sumit Semwal
gt; >> >> Cc: Felipe Balbi >> >> Cc: Greg Kroah-Hartman >> >> Cc: linux-kernel@vger.kernel.org >> >> Cc: linux-...@vger.kernel.org >> >> Cc: Android Kernel Team >> >> Cc: John Stultz >> >> Cc: Sumit Semwal &

Re: [Linaro-mm-sig] [RFC 2/4] cenalloc: Constraint-Enabled Allocation helpers for dma-buf

2014-10-14 Thread Sumit Semwal
Hi Laura, On 13 October 2014 14:05, Laura Abbott wrote: > On 10/10/2014 1:07 PM, Sumit Semwal wrote: >> >> Devices sharing buffers using dma-buf could benefit from sharing their >> constraints via struct device, and dma-buf framework would manage the >> common c

Re: [RFC 2/4] cenalloc: Constraint-Enabled Allocation helpers for dma-buf

2014-10-14 Thread Sumit Semwal
Hi Greg, Daniel! On 12 October 2014 00:10, Daniel Vetter wrote: > On Fri, Oct 10, 2014 at 04:09:00PM -0700, Greg Kroah-Hartman wrote: >> On Sat, Oct 11, 2014 at 01:37:56AM +0530, Sumit Semwal wrote: >> > Devices sharing buffers using dma-buf could benefit from sharing their &g

Re: [Linaro-mm-sig] [RFC 0/4] dma-buf Constraints-Enabled Allocation helpers

2014-10-14 Thread Sumit Semwal
Hi Laura, On 13 October 2014 13:42, Laura Abbott wrote: > On 10/10/2014 1:07 PM, Sumit Semwal wrote: >> >> Hi, >> >> Why: >> >> While sharing buffers using dma-buf, currently there's no mechanism to >> let >> devices share thei

[RFC 1/4] dma-buf: Add constraints sharing information

2014-10-10 Thread Sumit Semwal
asis, while defining some common masks. Signed-off-by: Sumit Semwal Cc: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Cc: linux-me...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org --- drivers/dma-buf/dma-buf.c

[RFC 3/4] cenalloc: Build files for constraint-enabled allocation helpers

2014-10-10 Thread Sumit Semwal
Add the build files for cenalloc, the constraints-enabled allocation helper framework for dma-buf. Signed-off-by: Sumit Semwal Cc: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Cc: linux-me...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org

[RFC 2/4] cenalloc: Constraint-Enabled Allocation helpers for dma-buf

2014-10-10 Thread Sumit Semwal
c_buffer_free to free the buffer if refcount reaches zero; ** IMPORTANT** This mechanism of delayed allocation based on constraint-enablement will work *ONLY IF* the first map_attachment() call is made AFTER all attach() calls are done. Signed-off-by: Sumit Semwal Cc: linux-kernel@vger.kernel.org C

[RFC 4/4] cenalloc: a sample allocator for contiguous page allocation

2014-10-10 Thread Sumit Semwal
From: Benjamin Gaignard Signed-off-by: Benjamin Gaignard Signed-off-by: Sumit Semwal Cc: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman Cc: linux-me...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-mm-...@lists.linaro.org --- drivers/cenalloc/Makefile

[RFC 0/4] dma-buf Constraints-Enabled Allocation helpers

2014-10-10 Thread Sumit Semwal
egards, ~Sumit. [1]: 'C'onstraints 'EN'abled 'ALLOC'ation helpers = cenalloc: it might not be a very appealing name, so suggestions are very welcome! Benjamin Gaignard (1): cenalloc: a sample allocator for contiguous page allocation Sumit Semwal (3): dma-buf: Add constraint

[GIT PULL]: few dma-buf updates for 3.17-rc3

2014-08-28 Thread Sumit Semwal
Hi Linus, The major changes for 3.17 already went via Greg-KH's tree this time as well; this is a small pull request for dma-buf - all documentation related. Could you please pull? The following changes since commit f1bd473f95e02bc382d4dae94d7f82e2a455e05d: Merge branch 'sec-v3.17-rc2' of gi

Re: [PATCH 1/6] MAINTAINERS: Update DMA BUFFER SHARING patterns

2014-07-29 Thread Sumit Semwal
Hi Joe! On 30 July 2014 09:08, Joe Perches wrote: > One pattern per F: line please... Thanks for catching this; Acked-by: Sumit Semwal > > Signed-off-by: Joe Perches > CC: Sumit Semwal > --- > MAINTAINERS | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > &g

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-08 Thread Sumit Semwal
day. >> >> btw should we add you as a (co)maintainer for driver/core/dma-buf since >> you seem to want to keep a closer tab on what the insane gfx folks are up >> to in there? > > Sure, why not, what's one more maintainership... > > Oh, does that mean you want

Re: [PATCH v2 0/9] Updated fence patch series

2014-07-07 Thread Sumit Semwal
Hi Greg, On 2 July 2014 11:07, Greg KH wrote: > On Tue, Jul 01, 2014 at 12:57:02PM +0200, Maarten Lankhorst wrote: >> So after some more hacking I've moved dma-buf to its own subdirectory, >> drivers/dma-buf and applied the fence patches to its new place. I believe >> that the >> first patch sho

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Sumit Semwal
On 19 June 2014 10:24, Greg KH wrote: > On Thu, Jun 19, 2014 at 09:57:35AM +0530, Sumit Semwal wrote: >> Hi Greg, >> >> >> >> >> Who is going to sign up to maintain this code? (hint, it's not me...) >> > >> > that would be

Re: [REPOST PATCH 1/8] fence: dma-buf cross-device synchronization (v17)

2014-06-18 Thread Sumit Semwal
>> Explicitly include linux/atomic.h. >>> v16: >>> Add trace events. >>> Import changes required by android syncpoints. >>> v17: >>> Use wake_up_state instead of try_to_wake_up. (Colin Cross) >>> Fix up commit description for

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Sumit Semwal
; On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: >> >> > Hi Greg, >> >> > >> >> > >> >> > On 30 May 2014 21:38, Greg Kroah-Hartman >> >> > wrote: >> >> > > On Fri, May 30, 2014 at 10:15:05AM +02

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-05 Thread Sumit Semwal
Hi Greg, On 5 June 2014 17:21, Rob Clark wrote: > On Wed, Jun 4, 2014 at 1:49 PM, Greg Kroah-Hartman > wrote: >> On Wed, Jun 04, 2014 at 03:28:33PM +0200, Thierry Reding wrote: >>> On Wed, Jun 04, 2014 at 04:57:07PM +0530, Sumit Semwal wrote: >>> > Hi Greg, &g

Re: [PATCH] fence: Use smp_mb__before_atomic()

2014-06-04 Thread Sumit Semwal
Hi Greg, On 30 May 2014 21:38, Greg Kroah-Hartman wrote: > On Fri, May 30, 2014 at 10:15:05AM +0200, Thierry Reding wrote: >> On Wed, May 28, 2014 at 01:51:45PM -0700, Greg Kroah-Hartman wrote: >> > On Wed, May 28, 2014 at 04:26:32PM +0200, Thierry Reding wrote: >> > > From: Thierry Reding >> >

Re: [PATCH linux-next] DRM: Armada: update dma_buf_export use

2014-05-27 Thread Sumit Semwal
for the prod Stephen! All, I'll merge it in today's for-next for me. > -- > Cheers, > Stephen Rothwell s...@canb.auug.org.au -- Thanks and regards, Sumit Semwal Graphics Engineer - Graphics working group Linaro.org │ Open source software for ARM SoCs -- T

Re: [PATCH] Documentation/dma-buf-sharing.txt: update API descriptions

2014-05-20 Thread Sumit Semwal
struct sg_table *, >> +enum dma_data_direction); >> >> unmap_dma_buf signifies the end-of-DMA for the attachment provided. Like >> map_dma_buf, this API also must be implemented by the exporter. >> -- >> 1.7.9.5

Re: linux-next: build failure after merge of the dma-buf tree

2014-05-20 Thread Sumit Semwal
*tegra_gem_prime_export(struct drm_device > *drm, >int flags) > { > return dma_buf_export(gem, &tegra_gem_prime_dmabuf_ops, gem->size, > - flags); > + flags, NULL); > } > struct drm_g

Re: linux-next: manual merge of the dma-buf tree with the drm-intel tree

2014-05-20 Thread Sumit Semwal
On 20 May 2014 12:25, Stephen Rothwell wrote: > Hi Sumit, > > Today's linux-next merge of the dma-buf tree got a conflict in > drivers/gpu/drm/i915/i915_gem_dmabuf.c between commit 5cc9ed4b9a7a > ("drm/i915: Introduce mapping of user pages into video memory (userptr) > ioctl") from the drm-intel t

Re: linux-next: manual merge of the dma-buf tree with the staging tree

2014-05-20 Thread Sumit Semwal
On 20 May 2014 12:36, Greg KH wrote: > On Tue, May 20, 2014 at 05:00:31PM +1000, Stephen Rothwell wrote: >> Hi Sumit, >> >> Today's linux-next merge of the dma-buf tree got a conflict in >> drivers/staging/android/sync.c between commit 10f62861b4a2 ("staging: >> android: fix missing a blank line a

[GIT PULL]: dma-buf updates for 3.14

2014-02-17 Thread Sumit Semwal
for you to fetch changes up to c0b00a525c127d0055c1df6283300e17f601a1a1: dma-buf: update debugfs output (2014-02-13 10:08:52 +0530) Small dma-buf pull request for 3.14 -------- Sumit Sem

Re: [GIT PULL]: dma-buf updates for 3.12

2013-09-11 Thread Sumit Semwal
Hi Linus. Sincere apologies for the html post; this request is now in plain-text. (it has been convenient using the gmail interface, but I promise this is the last time you'll see a non-plain-text email from me. Apologies again! Best regards, ~Sumit. On 11 September 2013 17:07, Sumit S

[GIT PULL]: dma-buf updates for 3.10

2013-05-01 Thread Sumit Semwal
6:22 +0530) 3.10 dma-buf updates Added debugfs support to dma-buf. -------- Sumit Semwal (2): dma-buf: replace dma_buf_export() with dma_buf_export_named() dma-buf: Add debugfs support Documentation/dma-buf-sharing

[GIT PULL]: dma-buf updates for 3.9

2013-02-27 Thread Sumit Semwal
Hi Linus, Here's the 3.9 pull request for dma-buf framework updates: could you please pull? Thanks and best regards, ~Sumit. The following changes since commit d895cb1af15c04c522a25c79cc429076987c089b: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2013-0

[GIT PULL]: dma-buf updates for 3.8

2012-12-19 Thread Sumit Semwal
Hi Linus, A fairly small dma-buf pull request for 3.8 - only 2 patches. Could you please pull? Thanks! ~Sumit. The following changes since commit f01af9f85855e38fbd601e033a8eac204cc4cc1c: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc (2012-12-19 20:31:02 -0800) are availabl

Re: [PATCH] dma-buf: add reference counting for exporter module

2012-08-08 Thread Sumit Semwal
t;> >>if (WARN_ON(!priv || !ops >> >> +|| !ops->owner >> >> Thank you for spotting this. >> I didn'y know that try_get_module returned true is module was NULL. >> >> BTW. Is it worth to add ".owner = THIS_MODULE,&

Re: [PATCH 1/3] dma-fence: dma-buf synchronization (v7)

2012-08-07 Thread Sumit Semwal
maturely while > keeping everything stable. As such, aborting requests should only be done > in exceptional circumstances, in this case hardware died and things are > already locked up anyhow.. > > ~Maarten > -- Thanks and best regards, Sumit Semwal -- To unsubscribe from this

Re: [RFC PATCH 1/3] dma-fence: dma-buf synchronization (v5)

2012-08-05 Thread Sumit Semwal
Hi Maarten, On 27 July 2012 19:09, Maarten Lankhorst wrote: > A dma-fence can be attached to a buffer which is being filled or consumed > by hw, to allow userspace to pass the buffer without waiting to another > device. For example, userspace can call page_flip ioctl to display the > next frame o

<    1   2   3