RE: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once

2014-06-27 Thread Suresh Thiagarajan
at this fields is only set and appears > to be never used, > maybe it could be completely removed. You are correct. The whole forensic_info structure itself is not used or referred anywhere. I will remove it and send a patch. Regards, Suresh Thiagarajan > > Regards, > Maurizio Lombard

RE: spinlock_irqsave() && flags (Was: pm80xx: Spinlock fix)

2014-01-02 Thread Suresh Thiagarajan
On Fri, Dec 27, 2013 at 9:48 PM, Oleg Nesterov wrote: > On 12/24, Suresh Thiagarajan wrote: >> >> Below is a small pseudo code on protecting/serializing the flag for global >> access. >> struct temp >> { >> ... >> spinlock_t lock; >

RE: spinlock_irqsave() && flags (Was: pm80xx: Spinlock fix)

2013-12-24 Thread Suresh Thiagarajan
On Tue, Dec 24, 2013 at 1:59 PM, Ingo Molnar wrote: > > * Oleg Nesterov wrote: > >> On 12/23, Ingo Molnar wrote: >> > >> > * Oleg Nesterov wrote: >> > >> > > Initially I thought that this is obviously wrong, irqsave/irqrestore >> > > assume that "flags" is owned by the caller, not by the lock.