[tip:x86/urgent] x86/purgatory: Avoid creating stray ..d files, remove -MD from KBUILD_CFLAGS

2018-03-25 Thread tip-bot for Sven Wegener
Commit-ID: e847f6aaf68f6156a5e9b26afe1a7316b9ab697e Gitweb: https://git.kernel.org/tip/e847f6aaf68f6156a5e9b26afe1a7316b9ab697e Author: Sven Wegener <sven.wege...@stealer.net> AuthorDate: Sat, 24 Mar 2018 22:21:13 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate:

[tip:x86/urgent] x86/purgatory: Avoid creating stray ..d files, remove -MD from KBUILD_CFLAGS

2018-03-25 Thread tip-bot for Sven Wegener
Commit-ID: e847f6aaf68f6156a5e9b26afe1a7316b9ab697e Gitweb: https://git.kernel.org/tip/e847f6aaf68f6156a5e9b26afe1a7316b9ab697e Author: Sven Wegener AuthorDate: Sat, 24 Mar 2018 22:21:13 +0100 Committer: Ingo Molnar CommitDate: Sun, 25 Mar 2018 11:04:02 +0200 x86/purgatory: Avoid

[PATCH] x86/purgatory: Remove -MD from KBUILD_CFLAGS

2018-03-24 Thread Sven Wegener
The kernel build system already takes care of generating the dependency files. Having the additional -MD in KBUILD_CFLAGS leads to stray ..d files in the build directory when we call the cc-option macro. Signed-off-by: Sven Wegener <sven.wege...@stealer.net> --- arch/x86/purgatory/Makefi

[PATCH] x86/purgatory: Remove -MD from KBUILD_CFLAGS

2018-03-24 Thread Sven Wegener
The kernel build system already takes care of generating the dependency files. Having the additional -MD in KBUILD_CFLAGS leads to stray ..d files in the build directory when we call the cc-option macro. Signed-off-by: Sven Wegener --- arch/x86/purgatory/Makefile | 2 +- 1 file changed, 1

[tip:x86/urgent] x86_32, entry: Store badsys error code in %eax

2014-07-22 Thread tip-bot for Sven Wegener
Commit-ID: 8142b215501f8b291a108a202b3a053a265b03dd Gitweb: http://git.kernel.org/tip/8142b215501f8b291a108a202b3a053a265b03dd Author: Sven Wegener AuthorDate: Tue, 22 Jul 2014 10:26:06 +0200 Committer: H. Peter Anvin CommitDate: Tue, 22 Jul 2014 02:34:05 -0700 x86_32, entry: Store

[PATCH] x86_32, entry: store badsys error code in %eax

2014-07-22 Thread Sven Wegener
t used, the syscall return value is the passed-in syscall number from the untouched %eax register. Use %eax as the return value register in syscall_badsys and sysenter_badsys, like a real syscall handler does, and have the caller push the value onto the stack for ptrace access. Signed-off-by: Sven Wegen

Re: [PATCH] x86_32, entry: store badsys error code in %eax

2014-07-22 Thread Sven Wegener
On Mon, 21 Jul 2014, Andy Lutomirski wrote: > On Sun, Jul 20, 2014 at 2:33 PM, Sven Wegener > wrote: > > Commit 554086d ("x86_32, entry: Do syscall exit work on badsys > > (CVE-2014-4508)") introduced a subtle regression in the x86_32 syscall > > entry code, re

Re: [PATCH] x86_32, entry: store badsys error code in %eax

2014-07-22 Thread Sven Wegener
On Mon, 21 Jul 2014, Andy Lutomirski wrote: On Sun, Jul 20, 2014 at 2:33 PM, Sven Wegener sven.wege...@stealer.net wrote: Commit 554086d (x86_32, entry: Do syscall exit work on badsys (CVE-2014-4508)) introduced a subtle regression in the x86_32 syscall entry code, resulting in syscall

[PATCH] x86_32, entry: store badsys error code in %eax

2014-07-22 Thread Sven Wegener
-in syscall number from the untouched %eax register. Use %eax as the return value register in syscall_badsys and sysenter_badsys, like a real syscall handler does, and have the caller push the value onto the stack for ptrace access. Signed-off-by: Sven Wegener sven.wege...@stealer.net Reviewed

[tip:x86/urgent] x86_32, entry: Store badsys error code in %eax

2014-07-22 Thread tip-bot for Sven Wegener
Commit-ID: 8142b215501f8b291a108a202b3a053a265b03dd Gitweb: http://git.kernel.org/tip/8142b215501f8b291a108a202b3a053a265b03dd Author: Sven Wegener sven.wege...@stealer.net AuthorDate: Tue, 22 Jul 2014 10:26:06 +0200 Committer: H. Peter Anvin h...@zytor.com CommitDate: Tue, 22 Jul 2014

[PATCH] x86_32, entry: fix sysenter_badsys END symbol

2014-07-20 Thread Sven Wegener
Signed-off-by: Sven Wegener Cc: Andy Lutomirski --- arch/x86/kernel/entry_32.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S index 793f6c9..0958f2b 100644 --- a/arch/x86/kernel/entry_32.S +++ b/arch/x86/kernel

[PATCH] x86_32, entry: use syscall_badsys from syscall_trace_entry

2014-07-20 Thread Sven Wegener
Bring syscall_trace_entry in line with the other syscall_* error handling code and use syscall_badsys for setting -ENOSYS. Signed-off-by: Sven Wegener --- arch/x86/kernel/entry_32.S | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86

[PATCH] x86_32, entry: store badsys error code in %eax

2014-07-20 Thread Sven Wegener
is not used, the syscall return value is the passed-in syscall number from the %eax register. Use %eax as the return value register in syscall_badsys and sysenter_badsys, like a real syscall handler does, and have the caller push the value onto the stack for ptrace access. Signed-off-by: Sv

[PATCH] x86_32, entry: store badsys error code in %eax

2014-07-20 Thread Sven Wegener
is the passed-in syscall number from the %eax register. Use %eax as the return value register in syscall_badsys and sysenter_badsys, like a real syscall handler does, and have the caller push the value onto the stack for ptrace access. Signed-off-by: Sven Wegener sven.wege...@stealer.net --- arch

[PATCH] x86_32, entry: use syscall_badsys from syscall_trace_entry

2014-07-20 Thread Sven Wegener
Bring syscall_trace_entry in line with the other syscall_* error handling code and use syscall_badsys for setting -ENOSYS. Signed-off-by: Sven Wegener sven.wege...@stealer.net --- arch/x86/kernel/entry_32.S | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel

[PATCH] x86_32, entry: fix sysenter_badsys END symbol

2014-07-20 Thread Sven Wegener
Signed-off-by: Sven Wegener sven.wege...@stealer.net Cc: Andy Lutomirski l...@amacapital.net --- arch/x86/kernel/entry_32.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S index 793f6c9..0958f2b 100644 --- a/arch/x86

[PATCH] NFSv4: Check for buffer length in __nfs4_get_acl_uncached

2012-12-12 Thread Sven Wegener
ied is too short, we still copy the complete ACL, resulting in kernel and user space memory corruption. Signed-off-by: Sven Wegener Cc: sta...@kernel.org --- fs/nfs/nfs4proc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Resending, because it did not get any response. diff --git a

[PATCH] NFSv4: Check for buffer length in __nfs4_get_acl_uncached

2012-12-12 Thread Sven Wegener
still copy the complete ACL, resulting in kernel and user space memory corruption. Signed-off-by: Sven Wegener sven.wege...@stealer.net Cc: sta...@kernel.org --- fs/nfs/nfs4proc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Resending, because it did not get any response. diff --git

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-10 Thread Sven Wegener
On Sat, 9 Feb 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: struct ip_vs_sync_thread_data { - struct completion *startup; + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-10 Thread Sven Wegener
On Sat, 9 Feb 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: struct ip_vs_sync_thread_data { - struct completion *startup; + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run

[RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Sven Wegener
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an

[RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Sven Wegener
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an

Re: [PATCH] leds: Add support for power LED on WRAP systems

2008-02-07 Thread Sven Wegener
On Thu, 7 Feb 2008, Richard Purdie wrote: On Tue, 2008-02-05 at 21:51 +0100, Sven Wegener wrote: WRAP systems have an additional LED. The power LED is normally lit after boot and doesn't serve any other purpose besides showing that the system is powered on. Nevertheless, its state

Re: [PATCH] leds: Add support for power LED on WRAP systems

2008-02-07 Thread Sven Wegener
On Thu, 7 Feb 2008, Richard Purdie wrote: On Tue, 2008-02-05 at 21:51 +0100, Sven Wegener wrote: WRAP systems have an additional LED. The power LED is normally lit after boot and doesn't serve any other purpose besides showing that the system is powered on. Nevertheless, its state

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
controllable by a sysctl variable so that users can tune it. We enforce a lower limit of 0 and an upper limit of 2000 ms on the interval. A too large interval can make the synchronization buffer consume too much memory and will also delay the exit of the kernel threads. Signed-off-by: Sven Wegener

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
On Wed, 6 Feb 2008, David Rientjes wrote: On Wed, 6 Feb 2008, Sven Wegener wrote: diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c index 948378d..9b57ad3 100644 --- a/net/ipv4/ipvs/ip_vs_sync.c +++ b/net/ipv4/ipvs/ip_vs_sync.c @@ -143,6 +143,8 @@ char

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
controllable by a sysctl variable so that users can tune it. Signed-off-by: Sven Wegener <[EMAIL PROTECTED]> --- Documentation/networking/ipvs-sysctl.txt |9 + net/ipv4/ipvs/ip_vs_ctl.c|9 - net/ipv4/ipvs/ip_vs_sync.c |6 -- 3

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
controllable by a sysctl variable so that users can tune it. Signed-off-by: Sven Wegener [EMAIL PROTECTED] --- Documentation/networking/ipvs-sysctl.txt |9 + net/ipv4/ipvs/ip_vs_ctl.c|9 - net/ipv4/ipvs/ip_vs_sync.c |6 -- 3 files changed

Re: [PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
On Wed, 6 Feb 2008, David Rientjes wrote: On Wed, 6 Feb 2008, Sven Wegener wrote: diff --git a/net/ipv4/ipvs/ip_vs_sync.c b/net/ipv4/ipvs/ip_vs_sync.c index 948378d..9b57ad3 100644 --- a/net/ipv4/ipvs/ip_vs_sync.c +++ b/net/ipv4/ipvs/ip_vs_sync.c @@ -143,6 +143,8 @@ char

[PATCH] ipvs: Make the synchronization interval controllable

2008-02-06 Thread Sven Wegener
controllable by a sysctl variable so that users can tune it. We enforce a lower limit of 0 and an upper limit of 2000 ms on the interval. A too large interval can make the synchronization buffer consume too much memory and will also delay the exit of the kernel threads. Signed-off-by: Sven Wegener

[PATCH] ipvs: Make wrr "no available servers" error message rate-limited

2008-02-05 Thread Sven Wegener
No available servers is more an error message than something informational. It should also be rate-limited, else we're going to flood our logs on a busy director, if all real servers are out of order with a weight of zero. Signed-off-by: Sven Wegener <[EMAIL PROTECTED]> --- Actually, do w

[PATCH] leds: Add support for power LED on WRAP systems

2008-02-05 Thread Sven Wegener
ed-off-by: Sven Wegener <[EMAIL PROTECTED]> --- drivers/leds/leds-wrap.c | 41 +++-- 1 files changed, 35 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-wrap.c b/drivers/leds/leds-wrap.c index 27fb2d8..0ccb483 100644 --- a/drivers/leds/leds-

[PATCH] leds: Add support for power LED on WRAP systems

2008-02-05 Thread Sven Wegener
WRAP systems have an additional LED. The power LED is normally lit after boot and doesn't serve any other purpose besides showing that the system is powered on. Nevertheless, its state is controllable and we can attach a trigger to it. Cc: Kristian Kielhofner [EMAIL PROTECTED] Signed-off-by: Sven

[PATCH] ipvs: Make wrr no available servers error message rate-limited

2008-02-05 Thread Sven Wegener
No available servers is more an error message than something informational. It should also be rate-limited, else we're going to flood our logs on a busy director, if all real servers are out of order with a weight of zero. Signed-off-by: Sven Wegener [EMAIL PROTECTED] --- Actually, do we need