Re: [PATCH] staging:bcm2048 : Add parentheses around variable x

On Fri, Feb 3, 2017 at 3:42 PM, Dan Carpenter wrote: > On Sat, Dec 03, 2016 at 03:14:26PM +0530, Tabrez khan wrote: >> Add parentheses around variable x for the readability purpose. >> > > It's not really about readability... > > regards, > dan carpenter >

[PATCH] staging:lustre:remove braces from single-line body

Remove unnecessary braces from single line if statement. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/obdecho/echo_client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho

[PATCH] staging:lustre:fixed space coding style in o2iblnd_cb.c

Space required before assignment operator, to make close to kernel coding style. This error is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging:lustre:fixed space coding style in o2iblnd_cb.c

Space required before assignment operator, to make close to kernel coding style. This error is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] staging : lustre : Remove braces from single line body.

Remove unnecessary braces from single line if statement. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c

[PATCH] staging : lustre : Remove braces from single-line body.

Remove unnecessary braces from single-line if statement. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/ptlrpc/import.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c

[PATCH] staging : lustre : Remove braces from single-line body.

Remove unnecessary braces {} from single line if statement. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/ptlrpc/import.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc

[PATCH] staging : lustre : Remove braces from single-line body.

Remove unnecessary braces {} for single while statement. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass

Re: [PATCH] staging : osc : Remove braces from single-line body

On Thu, Dec 15, 2016 at 7:08 AM, Greg KH wrote: > On Thu, Dec 15, 2016 at 07:03:52AM +0530, Tabrez khan wrote: >> Remove unnecessary braces {} for single if statement block. >> This warning is found using checkpatch.pl. >> >> Signed-off-by: Tabrez khan >> ---

[PATCH] staging : osc : Remove braces from single-line body

Remove unnecessary braces {} for single if statement block. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc

[PATCH] staging : i4l : Remove blank lines

Remove unnecessary blank lines. This warning was found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/i4l/act2000/module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c index fc14de4..b2ebaf0

[PATCH] staging : osc : coding style fix

Remove unnecessary braces {} for single if statement block. This warning is found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/lustre/lustre/osc/osc_cache.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/osc

[PATCH] staging : i4l : Remove blank lines

From: Tabrez khan Remove blank lines. Signed-off-by: Tabrez khan --- drivers/staging/i4l/act2000/module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c index fc14de4..b2ebaf0 100644 --- a/drivers/staging/i4l

[PATCH] staging: i4l :fixed coding style

Remove braces {} for single if statement block. Signed-off-by: Tabrez khan --- drivers/staging/i4l/act2000/module.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c index 99c9c0a..fc14de4 100644

[PATCH] staging:bcm2048 : Add parentheses around variable x

Add parentheses around variable x for the readability purpose. This warning was found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048/radio