() knlGS:
CS: 0010 DS: ES: CR0: 80050033
CR2: 0130 CR3: 000103414000 CR4: 007506f0
PKRU: 5554
Call Trace:
? __die+0x20/0x70
? page_fault_oops+0x15a/0x460
? trace_event_raw_event_x86_exceptions+0x5f/0xa0
? exc_page_fault+0x6e/0x180
? asm_exc_page_fault+0x22/0x30
? __pfx_strlen+0x10/0x10
trace_event_raw_event_qdisc_reset+0x4d/0x180
? synchronize_rcu_expedited+0x215/0x240
? __pfx_autoremove_wake_function+0x10/0x10
qdisc_reset+0x130/0x150
netif_set_real_num_tx_queues+0xe3/0x1e0
veth_init_queues+0x44/0x70 [veth 24a9dd1cd1b1b279e1b467ad46d47a753799b428]
veth_newlink+0x22b/0x440 [veth 24a9dd1cd1b1b279e1b467ad46d47a753799b428]
__rtnl_newlink+0x718/0x990
rtnl_newlink+0x44/0x70
rtnetlink_rcv_msg+0x159/0x410
? kmalloc_reserve+0x90/0xf0
? trace_event_raw_event_kmem_cache_alloc+0x87/0xe0
? __pfx_rtnetlink_rcv_msg+0x10/0x10
netlink_rcv_skb+0x54/0x100
netlink_unicast+0x243/0x370
netlink_sendmsg+0x1bb/0x3e0
sys_sendmsg+0x2bb/0x320
? copy_msghdr_from_user+0x6d/0xa0
___sys_sendmsg+0x88/0xd0
Thanks a lot!
Taehee Yoo
be used.
But the patch would cause conflict with 34a9c361dd48
("hsr: remove hsr interface if all slaves are removed").
That commit is not merged into "net" branch yet.
So, I will send fix patch after the merge.
Test commands:
#SHELL1
ip link add dummy0 type dummy
ip link add dummy1
rq_offline.part.89+0x140/0x140
[ ... ]
Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 2 ++
net/bpfilter/bpfilter_kern.c | 28 +++-
net/ipv4/bpfilter/sockopt.c | 22 +
quot;net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo
---
v4 : check stop flag in the load_umh() to avoid a double-create UMH
include/linux/bpfilter.h | 2 ++
net/bpfilter/bpfilter_kern.c | 37 +++-
net/bpfilter/bpfilter_umh_blob.S
Now, UMH process is killed, do_exit() calls the umh_info->cleanup callback
to release members of the umh_info.
This patch makes bpfilter_umh's cleanup routine to use the
umh_info->cleanup callback.
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 11 ---
n
uld release both members of the
umh_info and the private data.
Suggested-by: David S. Miller
Signed-off-by: Taehee Yoo
---
v4 : declare the exit_umh() as static inline
include/linux/sched.h | 9 +
include/linux/umh.h | 2 ++
kernel/exit.c | 1 +
kernel/umh.c |
is fixed by the third and fourth patch.
v4 :
- declare the exit_umh() as static inline
- check stop flag in the load_umh() to avoid a double-create UMH
v3 :
- Avoid unnecessary list lookup for non-UMH processes
- Add a new PF_UMH flag
v2 : add the first and second patch
v1 : Initial patch
T
On Tue, 8 Jan 2019 at 00:25, David Miller wrote:
>
> From: Taehee Yoo
> Date: Mon, 7 Jan 2019 21:10:14 +0900
>
> > @@ -679,6 +688,29 @@ static int proc_cap_handler(struct ctl_table *table,
> > int write,
> > return 0;
> > }
> >
rq_offline.part.89+0x140/0x140
[ ... ]
Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 2 ++
net/bpfilter/bpfilter_kern.c | 20 ++--
net/ipv4/bpfilter/sockopt.c | 21 ---
Now, UMH process is killed, do_exit() calls the umh_info->cleanup callback
to release members of the umh_info.
This patch makes bpfilter_umh's cleanup routine to use the
umh_info->cleanup callback.
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 11 ---
n
quot;net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 2 ++
net/bpfilter/bpfilter_kern.c | 35 +++-
net/bpfilter/bpfilter_umh_blob.S | 2 +-
net/ipv4/bpfilter/sockopt.c | 11 +-
4 files chan
uld release both members of the
umh_info and the private data.
Suggested-by: David S. Miller
Signed-off-by: Taehee Yoo
---
v3 :
- Avoid unnecessary list lookup for non-UMH processes
- Add a new PF_UMH flag
include/linux/sched.h | 1 +
include/linux/umh.h | 4
kernel/exit.c |
s is fixed by the third patch.
The TEST2 makes a panic because of a race condition in the bpfilter_umh
module.
This is fixed by the fourth patch.
v3 :
- Avoid unnecessary list lookup for non-UMH processes
- Add a new PF_UMH flag
v2 : add the first and second patch
v1 : Initial patch
Taehee Yo
On Mon, 7 Jan 2019 at 01:55, David Miller wrote:
>
> From: Taehee Yoo
> Date: Sun, 6 Jan 2019 14:34:52 +0900
>
> > How about adding a new PF_UMH flag for task_struct->flags to identify
> > UMH process?
> > By using this flag, the exit_umh() can avoid unnecessar
On Sun, 6 Jan 2019 at 07:10, David Miller wrote:
>
> From: Taehee Yoo
> Date: Mon, 31 Dec 2018 01:31:43 +0900
>
> > +void exit_umh(struct task_struct *tsk)
> > +{
> > + struct umh_info *info;
> > + pid_t pid = tsk->pid;
&g
On Sat, 5 Jan 2019 at 05:54, David Miller wrote:
>
> From: Taehee Yoo
> Date: Mon, 31 Dec 2018 01:30:45 +0900
>
> > This patches fix two bugs in the bpfilter_umh which are related in
> > iptables command.
> ...
>
> I am still thinking about these patches, sor
Now, UMH process is killed, do_exit() calls the umh_info->cleanup callback
to release members of the umh_info.
This patch makes bpfilter_umh's cleanup routine to use the
umh_info->cleanup callback.
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 11 ---
n
rq_offline.part.89+0x140/0x140
[ ... ]
Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 2 ++
net/bpfilter/bpfilter_kern.c | 20 ++--
net/ipv4/bpfilter/sockopt.c | 21 -
3 f
quot;net: add skeleton of bpfilter kernel module")
Signed-off-by: Taehee Yoo
---
include/linux/bpfilter.h | 2 ++
net/bpfilter/bpfilter_kern.c | 35 +++-
net/bpfilter/bpfilter_umh_blob.S | 2 +-
net/ipv4/bpfilter/sockopt.c | 11 +-
4 files chan
-by: David S. Miller
Signed-off-by: Taehee Yoo
---
include/linux/umh.h | 4
kernel/exit.c | 1 +
kernel/umh.c| 27 +++
3 files changed, 32 insertions(+)
diff --git a/include/linux/umh.h b/include/linux/umh.h
index 235f51b62c71..c645f0a19103 100644
--
because of a race condition in the bpfilter_umh
module.
This is fixed by the fourth patch.
Taehee Yoo (4):
umh: add exit routine for UMH process
net: bpfilter: use cleanup callback to release umh_info
net: bpfilter: restart bpfilter_umh when error occurred
net: bpfilter: disallow to remove bpfi
21 matches
Mail list logo
