On 02/17/2017 10:29 PM, Arnaldo Carvalho de Melo wrote:
Em Fri, Feb 17, 2017 at 11:33:29AM +0900, Taeung Song escreveu:
Hi, Arnaldo :)
Regarding perf annotate:
1) Problem : wrong line numbers on perf-annotate (both stdio and TUI)
2) Problem : wrong sum of overhead(percent) matching source
On 02/17/2017 10:29 PM, Arnaldo Carvalho de Melo wrote:
Em Fri, Feb 17, 2017 at 11:33:29AM +0900, Taeung Song escreveu:
Hi, Arnaldo :)
Regarding perf annotate:
1) Problem : wrong line numbers on perf-annotate (both stdio and TUI)
2) Problem : wrong sum of overhead(percent) matching source
readable :) )
I'll send the patchset for them, maybe it'll a bit take time.
But I won't be long..
Thanks,
Taeung
On 02/15/2017 11:24 PM, Taeung Song wrote:
On 02/15/2017 10:24 PM, Arnaldo Carvalho de Melo wrote:
Em Wed, Feb 15, 2017 at 09:34:51PM +0900, Taeung Song escreveu:
> Hi all :)
>
>
readable :) )
I'll send the patchset for them, maybe it'll a bit take time.
But I won't be long..
Thanks,
Taeung
On 02/15/2017 11:24 PM, Taeung Song wrote:
On 02/15/2017 10:24 PM, Arnaldo Carvalho de Melo wrote:
Em Wed, Feb 15, 2017 at 09:34:51PM +0900, Taeung Song escreveu:
> Hi all :)
>
>
On 02/15/2017 10:24 PM, Arnaldo Carvalho de Melo wrote:
Em Wed, Feb 15, 2017 at 09:34:51PM +0900, Taeung Song escreveu:
> Hi all :)
>
> I found some problems about showing line numbers of perf-annotate.
> and I have a suggestion about perf-annotate.
>
> Sure, I h
On 02/15/2017 10:24 PM, Arnaldo Carvalho de Melo wrote:
Em Wed, Feb 15, 2017 at 09:34:51PM +0900, Taeung Song escreveu:
> Hi all :)
>
> I found some problems about showing line numbers of perf-annotate.
> and I have a suggestion about perf-annotate.
>
> Sure, I h
Hi all :)
I found some problems about showing line numbers of perf-annotate.
and I have a suggestion about perf-annotate.
Sure, I have a plan to send the patchset about that.
But I'd like to know other opinions about that before sending the
patchset. :)
If the user do perf-annotate,
#
Hi all :)
I found some problems about showing line numbers of perf-annotate.
and I have a suggestion about perf-annotate.
Sure, I have a plan to send the patchset about that.
But I'd like to know other opinions about that before sending the
patchset. :)
If the user do perf-annotate,
#
Commit-ID: 5aa365f29867eb739cde0713f00c7d80f36e0739
Gitweb: http://git.kernel.org/tip/5aa365f29867eb739cde0713f00c7d80f36e0739
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Wed, 1 Feb 2017 21:34:05 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit
Commit-ID: 75fc5ae5cc53fff71041ecadeb3354a2b4c9fe42
Gitweb: http://git.kernel.org/tip/75fc5ae5cc53fff71041ecadeb3354a2b4c9fe42
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Wed, 1 Feb 2017 21:34:04 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit
Commit-ID: 5aa365f29867eb739cde0713f00c7d80f36e0739
Gitweb: http://git.kernel.org/tip/5aa365f29867eb739cde0713f00c7d80f36e0739
Author: Taeung Song
AuthorDate: Wed, 1 Feb 2017 21:34:05 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 8 Feb 2017 09:41:11 -0300
perf tools: Add
Commit-ID: 75fc5ae5cc53fff71041ecadeb3354a2b4c9fe42
Gitweb: http://git.kernel.org/tip/75fc5ae5cc53fff71041ecadeb3354a2b4c9fe42
Author: Taeung Song
AuthorDate: Wed, 1 Feb 2017 21:34:04 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 8 Feb 2017 09:41:10 -0300
perf tools: Only
Commit-ID: 506fde11a35f39e1b44478339c41e94dfd278aa2
Gitweb: http://git.kernel.org/tip/506fde11a35f39e1b44478339c41e94dfd278aa2
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Wed, 1 Feb 2017 21:34:06 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Commit
Commit-ID: 506fde11a35f39e1b44478339c41e94dfd278aa2
Gitweb: http://git.kernel.org/tip/506fde11a35f39e1b44478339c41e94dfd278aa2
Author: Taeung Song
AuthorDate: Wed, 1 Feb 2017 21:34:06 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 8 Feb 2017 09:41:11 -0300
perf tools: Use
is to set the default value of -o/--order
option.
Cc: Taeung Song <treeze.tae...@gmail.com>
Signed-off-by: Namhyung Kim <namhy...@kernel.org>
---
tools/perf/Documentation/perf-config.txt | 7 +++
tools/perf/Documentation/perf-diff.txt | 6 +-
tools/perf/builtin-diff.c
is to set the default value of -o/--order
option.
Cc: Taeung Song
Signed-off-by: Namhyung Kim
---
tools/perf/Documentation/perf-config.txt | 7 +++
tools/perf/Documentation/perf-diff.txt | 6 +-
tools/perf/builtin-diff.c| 14 ++
3 files changed, 26 insertions
Commit-ID: b05d1093987a78695766b71a2d723aa65b5c25c5
Gitweb: http://git.kernel.org/tip/b05d1093987a78695766b71a2d723aa65b5c25c5
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Tue, 31 Jan 2017 20:38:29 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: b05d1093987a78695766b71a2d723aa65b5c25c5
Gitweb: http://git.kernel.org/tip/b05d1093987a78695766b71a2d723aa65b5c25c5
Author: Taeung Song
AuthorDate: Tue, 31 Jan 2017 20:38:29 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 31 Jan 2017 16:20:09 -0300
perf ftrace
Commit-ID: 43d41deb71fe1850264e5dd8109211683954ea14
Gitweb: http://git.kernel.org/tip/43d41deb71fe1850264e5dd8109211683954ea14
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Tue, 31 Jan 2017 20:38:28 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 43d41deb71fe1850264e5dd8109211683954ea14
Gitweb: http://git.kernel.org/tip/43d41deb71fe1850264e5dd8109211683954ea14
Author: Taeung Song
AuthorDate: Tue, 31 Jan 2017 20:38:28 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 31 Jan 2017 16:20:08 -0300
perf tools
Commit-ID: bf062bd20e6c4988a9c593824ea6bb58730b6289
Gitweb: http://git.kernel.org/tip/bf062bd20e6c4988a9c593824ea6bb58730b6289
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Thu, 26 Jan 2017 18:35:37 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: bf062bd20e6c4988a9c593824ea6bb58730b6289
Gitweb: http://git.kernel.org/tip/bf062bd20e6c4988a9c593824ea6bb58730b6289
Author: Taeung Song
AuthorDate: Thu, 26 Jan 2017 18:35:37 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 26 Jan 2017 15:53:27 -0300
perf ftrace
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 0c3b81a..316f054 100644
--- a/tools/perf/util/parse-ev
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 5d90fe7..0c3b81a 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/per
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/u
Signed-off-by: Taeung Song
---
tools/perf/util/parse-events.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 5d90fe7..0c3b81a 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -211,6
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
---
tools/perf/util/parse-events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3c876b8..5d90fe7 100644
--- a/tools/perf/util/parse-events.c
Signed-off-by: Taeung Song
---
tools/perf/util/parse-events.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 0c3b81a..316f054 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 316f054..ac47c12 100644
--- a/tools/perf/util
Signed-off-by: Taeung Song
---
tools/perf/util/parse-events.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 316f054..ac47c12 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util
- Add only one macro instead of two macros (Jiri)
Taeung Song (4):
perf tools: Only increase index if perf_evsel__new_idx() succeeds
perf tools: Fill in a lacking part no checking NULL after zalloc() in
parse-events.c
perf tools: Use zfree() instead of free() and assigning NULL to the
- Add only one macro instead of two macros (Jiri)
Taeung Song (4):
perf tools: Only increase index if perf_evsel__new_idx() succeeds
perf tools: Fill in a lacking part no checking NULL after zalloc() in
parse-events.c
perf tools: Use zfree() instead of free() and assigning NULL to the
On 01/31/2017 10:25 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu:
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
The title of this p
On 01/31/2017 10:25 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu:
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
The title of this patch is misleading, ambiguous. It leads one to have
doubt if we were not incrementing
Sorry I'm late..
I got it!
I'll send v3 with changed patches !!
Thanks,
Taeung
On 01/31/2017 10:23 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 08:38:30PM +0900, Taeung Song escreveu:
Currently there are several parts not checking NULL
after allocating with zalloc() or asigning
Sorry I'm late..
I got it!
I'll send v3 with changed patches !!
Thanks,
Taeung
On 01/31/2017 10:23 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 08:38:30PM +0900, Taeung Song escreveu:
Currently there are several parts not checking NULL
after allocating with zalloc() or asigning
On 01/31/2017 10:15 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 09:46:28AM -0300, Arnaldo Carvalho de Melo escreveu:
Also you are silently ignoring any unknown variable in this section, so
if someone has this:
cat ~/.perfconfig
[ftrace]
trace = function
I.e.
On 01/31/2017 10:15 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 09:46:28AM -0300, Arnaldo Carvalho de Melo escreveu:
Also you are silently ignoring any unknown variable in this section, so
if someone has this:
cat ~/.perfconfig
[ftrace]
trace = function
I.e.
Hi, Arnaldo :)
On 01/31/2017 09:21 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 08:38:28PM +0900, Taeung Song escreveu:
Such as for_each_subsystem and for_each_event in util/parse-events.c,
add new macros 'for_each_event' for easy iteration over the tracepoints
in order
Hi, Arnaldo :)
On 01/31/2017 09:21 PM, Arnaldo Carvalho de Melo wrote:
Em Tue, Jan 31, 2017 at 08:38:28PM +0900, Taeung Song escreveu:
Such as for_each_subsystem and for_each_event in util/parse-events.c,
add new macros 'for_each_event' for easy iteration over the tracepoints
in order
iri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/trace-event-info.c | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a/tools/perf/util/trace-e
m>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3c876b8..87a3e5a 100644
--- a/too
Such as for_each_subsystem and for_each_event in util/parse-events.c,
add new macros 'for_each_event' for easy iteration over the tracepoints
in order to be more compact and readable.
Cc: Steven Rostedt
Cc: Frederic Weisbecker
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
Currently there are several parts not checking NULL
after allocating with zalloc() or asigning NULL value
to a pointer variable after doing free().
So I fill in code checking NULL and
use zfree() instead of free().
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/u
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
---
tools/perf/util/parse-events.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 87a3e5a..ac47c12 100644
--- a/tools/perf/util/parse-events.c
hyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-ftrace.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 41d..00e228f 100644
---
Hi, :)
Lately I sent several patches.
But they need to be modified so I send v2 packing them.
v2:
- Check the return of perf_config() and
warn the user with config error message (Arnaldo)
- Change commit messages (Jiri)
- Add only one macro instead of two macros (Jiri)
Taeung Song (4
switch <-__schedule
<...>-14450 [002] 10089.284232: finish_wait <-pipe_wait
<...>-14450 [002] 10089.284232: mutex_lock <-pipe_wait
<...>-14450 [002] 10089.284232: _cond_resched <-mutex_lock
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by:
Hi, :)
Lately I sent several patches.
But they need to be modified so I send v2 packing them.
v2:
- Check the return of perf_config() and
warn the user with config error message (Arnaldo)
- Change commit messages (Jiri)
- Add only one macro instead of two macros (Jiri)
Taeung Song (4
On 01/30/2017 09:38 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:
SNIP
looks almost the same as for_each_event_system macro,
what's the difference other than 'ftrace' check?
Little thing.
In parse-events.c for_each_event macro contains
tp_event_has_id
On 01/30/2017 09:38 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:
SNIP
looks almost the same as for_each_event_system macro,
what's the difference other than 'ftrace' check?
Little thing.
In parse-events.c for_each_event macro contains
tp_event_has_id
On 01/30/2017 06:01 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 02:23:38PM +0900, Taeung Song wrote:
Currently there are several parts not checking NULL
after allocating with zalloc() or asigning NULL value
to a pointer variable after doing free().
So I fill in code checking NULL and
use
On 01/30/2017 06:01 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 02:23:38PM +0900, Taeung Song wrote:
Currently there are several parts not checking NULL
after allocating with zalloc() or asigning NULL value
to a pointer variable after doing free().
So I fill in code checking NULL and
use
Hi, jirka :)
Thank you!
Taeung
On 01/30/2017 05:55 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 02:23:39PM +0900, Taeung Song wrote:
If 'evsel' is NULL, in perf_evsel__is_bpf_output()
NULL pointer error can happen so check it.
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Namhyung Kim
Hi, jirka :)
Thank you!
Taeung
On 01/30/2017 05:55 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 02:23:39PM +0900, Taeung Song wrote:
If 'evsel' is NULL, in perf_evsel__is_bpf_output()
NULL pointer error can happen so check it.
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
On 01/30/2017 06:08 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 05:35:28PM +0900, Taeung Song wrote:
SNIP
+#define for_each_event_system(dir, dent, tps) \
+ while ((dent = readdir(dir))) \
+ if (dent->d_type == DT_
On 01/30/2017 06:08 PM, Jiri Olsa wrote:
On Mon, Jan 30, 2017 at 05:35:28PM +0900, Taeung Song wrote:
SNIP
+#define for_each_event_system(dir, dent, tps) \
+ while ((dent = readdir(dir))) \
+ if (dent->d_type == DT_
<fweis...@gmail.com>
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/trace-event-info.c | 45 --
1 file changed, 19 insertions(+), 26 deletions(-)
Signed-off-by: Taeung Song
---
tools/perf/util/trace-event-info.c | 45 --
1 file changed, 19 insertions(+), 26 deletions(-)
diff --git a/tools/perf/util/trace-event-info.c
b/tools/perf/util/trace-event-info.c
index ceb0e27..27beaff 100644
--- a/tools/perf/util
If 'evsel' is NULL, in perf_evsel__is_bpf_output()
NULL pointer error can happen so check it.
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/evsel.c | 6 --
1 file changed,
If 'evsel' is NULL, in perf_evsel__is_bpf_output()
NULL pointer error can happen so check it.
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
---
tools/perf/util/evsel.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf
m>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/parse-events.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 3c876b8..87a3e5a 100644
--- a/too
Currently there are several parts not checking NULL
after allocating with zalloc() or asigning NULL value
to a pointer variable after doing free().
So I fill in code checking NULL and
use zfree() instead of free().
Cc: Namhyung Kim
Cc: Jiri Olsa
Signed-off-by: Taeung Song
---
tools/perf/util
On 01/27/2017 03:58 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jan 26, 2017 at 06:35:38PM +0900, Taeung Song escreveu:
Currently perf ftrace command will select 'function_graph' or 'function'.
So add ftrace.tracer config option to select tracer
# cat ~/.perfconfig
[ftrace
On 01/27/2017 03:58 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jan 26, 2017 at 06:35:38PM +0900, Taeung Song escreveu:
Currently perf ftrace command will select 'function_graph' or 'function'.
So add ftrace.tracer config option to select tracer
# cat ~/.perfconfig
[ftrace
: generic_pipe_buf_confirm <-pipe_read
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-ftrace.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/
: generic_pipe_buf_confirm <-pipe_read
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
---
tools/perf/builtin-ftrace.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 41d..00e228f 1
Hi, Arnaldo :)
On 01/27/2017 03:58 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jan 26, 2017 at 06:35:38PM +0900, Taeung Song escreveu:
Currently perf ftrace command will select 'function_graph' or 'function'.
So add ftrace.tracer config option to select tracer
# cat ~/.perfconfig
Hi, Arnaldo :)
On 01/27/2017 03:58 AM, Arnaldo Carvalho de Melo wrote:
Em Thu, Jan 26, 2017 at 06:35:38PM +0900, Taeung Song escreveu:
Currently perf ftrace command will select 'function_graph' or 'function'.
So add ftrace.tracer config option to select tracer
# cat ~/.perfconfig
ernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-ftrace.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index d05658d..414
im
Signed-off-by: Taeung Song
---
tools/perf/builtin-ftrace.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index d05658d..41d 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -20
: generic_pipe_buf_confirm <-pipe_read
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Namhyung Kim <namhy...@kernel.org>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-ftrace.c | 20
1 file changed, 20 insertions(+)
diff --git a/tools/pe
g>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/builtin-ftrace.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 8df5416..0754dee 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/
If a value for tracing file is NULL,
segment fault error can occur using strlen().
Of course, currently the function don't be given NULL value.
But write_tracing_file() can be generally used.
So add the if statement.
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
---
tools/perf
: generic_pipe_buf_confirm <-pipe_read
Cc: Jiri Olsa
Cc: Namhyung Kim
Signed-off-by: Taeung Song
---
tools/perf/builtin-ftrace.c | 20
1 file changed, 20 insertions(+)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 41d..8df5416 100644
Hi, Arnaldo :)
On 11/30/2016 01:05 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Nov 28, 2016 at 05:51:12PM +0900, Taeung Song escreveu:
When initializing default perf config values,
we currently use values of actual type(int, bool, char *, etc.).
For example,
If there isn't a user config value
Hi, Arnaldo :)
On 11/30/2016 01:05 AM, Arnaldo Carvalho de Melo wrote:
Em Mon, Nov 28, 2016 at 05:51:12PM +0900, Taeung Song escreveu:
When initializing default perf config values,
we currently use values of actual type(int, bool, char *, etc.).
For example,
If there isn't a user config value
Good morning!! Arnaldo :)
On 11/15/2016 12:50 AM, Arnaldo Carvalho de Melo wrote:
Em Fri, Nov 04, 2016 at 03:44:17PM +0900, Taeung Song escreveu:
Add a functionality getting specific config key-value pairs.
For the syntax examples,
perf config [] [section.name ...]
e.g. To query config
Good morning!! Arnaldo :)
On 11/15/2016 12:50 AM, Arnaldo Carvalho de Melo wrote:
Em Fri, Nov 04, 2016 at 03:44:17PM +0900, Taeung Song escreveu:
Add a functionality getting specific config key-value pairs.
For the syntax examples,
perf config [] [section.name ...]
e.g. To query config
: Jiri Olsa <jo...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/ui/browsers/annotate.c | 16
tools/perf/util/config.h | 3 +++
2 files changed, 15 insertions(+), 4 deletions(-)
di
: Jiri Olsa <jo...@redhat.com>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/config.h | 20
1 file changed, 20 insertions(+)
diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
index
r.c
because of setting default values of actual variables for 'colors' config.
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/config
Signed-off-by: Taeung Song
---
tools/perf/ui/browsers/annotate.c | 16
tools/perf/util/config.h | 3 +++
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c
b/tools/perf/ui/browsers/annotate.c
index ec7a30f..183f9c7 100644
Signed-off-by: Taeung Song
---
tools/perf/util/config.h | 20
1 file changed, 20 insertions(+)
diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
index 434d71c..7498669 100644
--- a/tools/perf/util/config.h
+++ b/tools/perf/util/config.h
@@ -96,4 +96,24 @@ struct
r.c
because of setting default values of actual variables for 'colors' config.
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Wang Nan
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 15 +++
tools/perf/util/config.h | 17 +
2 files changed, 32 insertions(+)
diff --gi
c: Jiri Olsa <jo...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/ui/browser.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/tools/perf/ui/browser.c b/tools/perf/u
gt;
Cc: Jiri Olsa <jo...@kernel.org>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/ui/browser.c | 53 +++--
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/tools/perf/u
of setting default values of actual variables for 'annotate' config.
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Jiri Olsa <jo...@redhat.com>
Cc: Wang Nan <wangn...@huawei.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/config.c | 11 +++
Signed-off-by: Taeung Song
---
tools/perf/ui/browser.c | 25 ++---
1 file changed, 18 insertions(+), 7 deletions(-)
diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index 1c80f00..5caa7e4 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -509,
Signed-off-by: Taeung Song
---
tools/perf/ui/browser.c | 53 +++--
1 file changed, 25 insertions(+), 28 deletions(-)
diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index 3eb3edb..1c80f00 100644
--- a/tools/perf/ui/browser.c
+++ b/tools
of setting default values of actual variables for 'annotate' config.
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Wang Nan
Signed-off-by: Taeung Song
---
tools/perf/util/config.c | 11 +++
tools/perf/util/config.h | 11 +++
2 files changed, 22 insertions(+)
diff --git a/tools/perf/util
+ ltrim instead of strchr and while (isspace(*++bg)); (Arnaldo)
Taeung Song (7):
perf config: Introduce default_config_section and default_config_item
for default config key-value pairs
perf config: Add macros assigning key-value pairs to
default_config_item
perf config: Add default
+ ltrim instead of strchr and while (isspace(*++bg)); (Arnaldo)
Taeung Song (7):
perf config: Introduce default_config_section and default_config_item
for default config key-value pairs
perf config: Add macros assigning key-value pairs to
default_config_item
perf config: Add default
eter Zijlstra <pet...@infradead.org>
Cc: Ingo Molnar <mi...@redhat.com>
Cc: Masami Hiramatsu <mhira...@kernel.org>
Cc: David Ahern <dsah...@gmail.com>
Signed-off-by: Taeung Song <treeze.tae...@gmail.com>
---
tools/perf/util/config.h | 29 +
1 file changed
/config.c)
with default config arrays and it could be easy and simple to modify
existing default config values or add default values for new config item.
Cc: Namhyung Kim
Cc: Jiri Olsa
Cc: Wang Nan
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Masami Hiramatsu
Cc: David Ahern
Signed-off-by: Taeung
Commit-ID: c6fc018a7a64c2c3ea56529fd8d0ca0f43408b0f
Gitweb: http://git.kernel.org/tip/c6fc018a7a64c2c3ea56529fd8d0ca0f43408b0f
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Fri, 4 Nov 2016 15:44:20 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 36662794bb520be828df8e2f3404264f5e7a7973
Gitweb: http://git.kernel.org/tip/36662794bb520be828df8e2f3404264f5e7a7973
Author: Taeung Song <treeze.tae...@gmail.com>
AuthorDate: Fri, 4 Nov 2016 15:44:19 +0900
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: c6fc018a7a64c2c3ea56529fd8d0ca0f43408b0f
Gitweb: http://git.kernel.org/tip/c6fc018a7a64c2c3ea56529fd8d0ca0f43408b0f
Author: Taeung Song
AuthorDate: Fri, 4 Nov 2016 15:44:20 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 14 Nov 2016 13:08:11 -0300
perf config
Commit-ID: 36662794bb520be828df8e2f3404264f5e7a7973
Gitweb: http://git.kernel.org/tip/36662794bb520be828df8e2f3404264f5e7a7973
Author: Taeung Song
AuthorDate: Fri, 4 Nov 2016 15:44:19 +0900
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 14 Nov 2016 12:57:40 -0300
perf config
501 - 600 of 1768 matches
Mail list logo
