Hi,
This is just a gentle reminder, If any other information is needed.
Tarun Sahu writes:
> memory_group_register_static takes maximum number of pages as the argument
> while dev_dax_kmem_probe passes total_len (in bytes) as the argument.
>
> IIUC, I don't see any crash/
Hi Vishal,
"Verma, Vishal L" writes:
> On Wed, 2023-06-21 at 11:36 +0530, Tarun Sahu wrote:
>> Hi Alison,
>>
>> Alison Schofield writes:
>>
>> > On Tue, Jun 20, 2023 at 07:33:32PM +0530, Tarun Sahu wrote:
>> > >
return zone;
}
return >node_zones[ZONE_NORMAL];
}
Incorrect zone will be returned here, which in later time might cause bigger
problem.
Fixes: eedf634aac3b ("dax/kmem: use a single static memory group for a single
probed unit")
Signed-off-by: Tarun Sahu
Review
n zone;
}
return >node_zones[ZONE_NORMAL];
}
Incorrect zone will be returned here, which in later time might cause bigger
problem.
Fixes: eedf634aac3b ("dax/kmem: use a single static memory group for a single
probed unit")
Signed-off-by: Tarun Sahu
Reviewed-by: Vishal Verma
---
Hi Alison,
Alison Schofield writes:
> On Tue, Jun 20, 2023 at 07:33:32PM +0530, Tarun Sahu wrote:
>> memory_group_register_static takes maximum number of pages as the argument
>> while dev_dax_kmem_probe passes total_len (in bytes) as the argument.
>
> This sounds like
memory_group_register_static takes maximum number of pages as the argument
while dev_dax_kmem_probe passes total_len (in bytes) as the argument.
Signed-off-by: Tarun Sahu
---
drivers/dax/kmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dax/kmem.c b/drivers/dax
Hi Vishal,
Vishal Verma writes:
> With DAX memory regions originating from CXL memory expanders or
> NVDIMMs, the kmem driver may be hot-adding huge amounts of system memory
> on a system without enough 'regular' main memory to support the memmap
> for it. To avoid this, ensure that all kmem
Hi,
Look all good to me.
Reviewed-by: Tarun Sahu
On Nov 23 2022, Xiu Jianfeng wrote:
> After changes in commit 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique
> name for bus provider"), @priv->bus_desc.provider_name is no longer a
> const string, but a dynamic strin
Hi,
Thanks for resolving it.
All looks good. Except a thing, there is no check for return status of
ksrdup too. that can also be part of this patch.
On Nov 23 2022, Xiu Jianfeng wrote:
> After changes in commit 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique
> name for bus provider"),
9 matches
Mail list logo
