[PATCH 0/8] platform/chrome: cros_ec: Fixes and improvements

2017-08-10 Thread Thierry Escande
Hi, This series contains various fixes and improvements for the ChromeOS Embedded Controller drivers. These concern PM suspend/resume fixes, sysfs interface, and module initialization. Regards, Thierry Daniel Hung-yu Wu (1): platform/chrome: cros_ec: register shutdown function for debugfs

[PATCH 4/8] platform/chrome: cros_ec: register shutdown function for debugfs

2017-08-10 Thread Thierry Escande
Wu Signed-off-by: Thierry Escande --- drivers/platform/chrome/cros_ec_dev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c index 2571f5e..225d8e9 100644 --- a/drivers/platform/chrome/cros_ec_dev.c +++ b

[PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-10 Thread Thierry Escande
check before the device is added so the features map obtained from the EC is ready on time. Signed-off-by: Gwendal Grignou <gwen...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/platform/chrome/cros_ec_dev.c | 32 ++--- drive

[PATCH 7/8] platform/chrome: cros_ec: Add sysfs entry to set keyboard wake lid angle

2017-08-10 Thread Thierry Escande
so the features map obtained from the EC is ready on time. Signed-off-by: Gwendal Grignou Signed-off-by: Thierry Escande --- drivers/platform/chrome/cros_ec_dev.c | 32 ++--- drivers/platform/chrome/cros_ec_sysfs.c | 80 + include/linux/mfd/cros_ec.h

[PATCH 6/8] mfd: cros_ec_i2c: add ACPI module device table

2017-08-10 Thread Thierry Escande
From: Wei-Ning Huang <wnhu...@google.com> Add ACPI module device table for matching cros-ec devices to load the cros_ec_i2c driver automatically. Signed-off-by: Wei-Ning Huang <wnhu...@google.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/mfd/

[PATCH 6/8] mfd: cros_ec_i2c: add ACPI module device table

2017-08-10 Thread Thierry Escande
From: Wei-Ning Huang Add ACPI module device table for matching cros-ec devices to load the cros_ec_i2c driver automatically. Signed-off-by: Wei-Ning Huang Signed-off-by: Thierry Escande --- drivers/mfd/cros_ec_i2c.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers

[PATCH 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

2017-08-10 Thread Thierry Escande
status() instead of cros_ec_cmd_xfer() so an error message is printed in the syslog. Signed-off-by: Gwendal Grignou <gwen...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/platform/chrome/cros_ec_sysfs.c | 25 - 1 file cha

[PATCH 8/8] platform/chrome: cros_ec: sysfs: Modify error handling

2017-08-10 Thread Thierry Escande
of cros_ec_cmd_xfer() so an error message is printed in the syslog. Signed-off-by: Gwendal Grignou Signed-off-by: Thierry Escande --- drivers/platform/chrome/cros_ec_sysfs.c | 25 - 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_sysfs.c b

[PATCH 1/8] iio: cros_ec: Relax sampling frequency before suspending

2017-08-10 Thread Thierry Escande
ake up, this patch adds prepare and complete callbacks to set 1s sampling period just before suspend. This ensures the sensor hub will not be a source of interrupt during the suspend process. Signed-off-by: Gwendal Grignou <gwen...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca..

[PATCH 1/8] iio: cros_ec: Relax sampling frequency before suspending

2017-08-10 Thread Thierry Escande
and complete callbacks to set 1s sampling period just before suspend. This ensures the sensor hub will not be a source of interrupt during the suspend process. Signed-off-by: Gwendal Grignou Signed-off-by: Thierry Escande --- .../iio/common/cros_ec_sensors/cros_ec_sensors.c | 1 + .../common

[PATCH 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late

2017-08-10 Thread Thierry Escande
needs to be resumed earlier due to some status polling from the EC firmware (e.g. battery status). This patch moves the PM ops to late stage to make it work normally. Signed-off-by: Joseph Lo <jose...@nvidia.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers

[PATCH 2/8] mfd: cros_ec_i2c: move the system sleep pm ops to late

2017-08-10 Thread Thierry Escande
due to some status polling from the EC firmware (e.g. battery status). This patch moves the PM ops to late stage to make it work normally. Signed-off-by: Joseph Lo Signed-off-by: Thierry Escande --- drivers/mfd/cros_ec_i2c.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v3] go2001 hardware codec support

2017-07-25 Thread Thierry Escande
to earlier failing format tests. test VIDIOC_EXPBUF: OK (Not Supported) Test input 0: Total: 43, Succeeded: 40, Failed: 3, Warnings: 0 Thierry Escande (1): [media] v4l2: Add support for go2001 PCI codec driver drivers/media/pci/Kconfig|2 + drivers/media/pci

[PATCH v3] go2001 hardware codec support

2017-07-25 Thread Thierry Escande
to earlier failing format tests. test VIDIOC_EXPBUF: OK (Not Supported) Test input 0: Total: 43, Succeeded: 40, Failed: 3, Warnings: 0 Thierry Escande (1): [media] v4l2: Add support for go2001 PCI codec driver drivers/media/pci/Kconfig|2 + drivers/media/pci

[PATCH v3] [media] v4l2: Add support for go2001 PCI codec driver

2017-07-25 Thread Thierry Escande
tio <v...@chromium.org> henryhsu <henry...@chromium.org> Wu-Cheng Li <wuchen...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/pci/Kconfig|2 + drivers/media/pci/Makefile |1 + drivers/media/pci

[PATCH v3] [media] v4l2: Add support for go2001 PCI codec driver

2017-07-25 Thread Thierry Escande
Signed-off-by: Thierry Escande --- drivers/media/pci/Kconfig|2 + drivers/media/pci/Makefile |1 + drivers/media/pci/go2001/Kconfig | 11 + drivers/media/pci/go2001/Makefile|2 + drivers/media/pci/go2001/go2001.h| 331 drivers

[PATCH v4 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

2017-06-30 Thread Thierry Escande
This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> Ack

[PATCH v4 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

2017-06-30 Thread Thierry Escande
This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz Acked-by: Jacek Anaszewski --- drivers/media/platform/s5p-jpeg/jpeg-core.c

[PATCH v4 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-30 Thread Thierry Escande
lanar APIs (Not needed). - Add comment regarding call to jpeg_bound_align_image() after qbuf. - Remove unrelated code from resolution change event support patch. Thierry Escande (3): [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr() [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg

[PATCH v4 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-30 Thread Thierry Escande
lanar APIs (Not needed). - Add comment regarding call to jpeg_bound_align_image() after qbuf. - Remove unrelated code from resolution change event support patch. Thierry Escande (3): [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr() [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg

[PATCH v4 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-30 Thread Thierry Escande
ey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> Acked-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 9 - 1 fi

[PATCH v4 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-30 Thread Thierry Escande
If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed s5p_jpeg_q_data structure is not modified so there is no need to use a temporary structure and the field-by-field copy can be avoided. Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietras

[PATCH v4 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-30 Thread Thierry Escande
From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when ERR_INT_EN is set to 1. Fix this case and report BUF_STATE_ERROR to videobuf2. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry

[PATCH v4 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-30 Thread Thierry Escande
If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed s5p_jpeg_q_data structure is not modified so there is no need to use a temporary structure and the field-by-field copy can be avoided. Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz Acked-by: Jacek Anaszewski

[PATCH v4 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-30 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: And

[PATCH v4 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

2017-06-30 Thread Thierry Escande
This patch moves the subsampling value decoding read from the jpeg header into its own function. This new function is called s5p_jpeg_subsampling_decode() and returns true if it successfully decodes the subsampling value, false otherwise. Signed-off-by: Thierry Escande <thierry.e

[PATCH v4 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-30 Thread Thierry Escande
From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz Acked-by: Jacek Anaszewski --- drivers/media/platform/s5p-jpeg/jpeg-core.c

[PATCH v4 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

2017-06-30 Thread Thierry Escande
This patch moves the subsampling value decoding read from the jpeg header into its own function. This new function is called s5p_jpeg_subsampling_decode() and returns true if it successfully decodes the subsampling value, false otherwise. Signed-off-by: Thierry Escande Acked-by: Andrzej

[PATCH v4 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-30 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pie

[PATCH v4 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-30 Thread Thierry Escande
From: Tony K Nadackal Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz Acked-by: Jacek Anaszewski --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 -- 1

[PATCH v4 7/8] [media] s5p-jpeg: Add support for resolution change event

2017-06-30 Thread Thierry Escande
s used in the Chromium browser project by the V4L2 JPEG Decode Accelerator (V4L2JDA) to allocate output buffer. Signed-off-by: Henry-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung

[PATCH v4 7/8] [media] s5p-jpeg: Add support for resolution change event

2017-06-30 Thread Thierry Escande
project by the V4L2 JPEG Decode Accelerator (V4L2JDA) to allocate output buffer. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry Escande Acked-by: Andrzej Pietrasiewicz Acked-by: Jacek Anaszewski --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 106 +--- drivers

[PATCH v4 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-30 Thread Thierry Escande
msung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> Acked-by: Andrzej Pietrasiewicz <andrze...@samsung.com> Acked-by: Jacek Anaszewski <jacek.anaszew...@gmail.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 19 +++ 1 file changed, 19 inser

[PATCH v4 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-30 Thread Thierry Escande
header. If the width/height values of jpeg are not aligned, the decoder output will be corrupted. So in this patch we call jpeg_bound_align_image() to align the width/height values of Capture buffer in s5p_jpeg_buf_queue(). Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande Acked

[PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-27 Thread Thierry Escande
If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed s5p_jpeg_q_data structure is not modify so there is no need to use a temporary structure and the field-by-field copy can be avoided. Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platfo

[PATCH v3 4/8] [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue

2017-06-27 Thread Thierry Escande
If s5p_jpeg_parse_hdr() fails to parse the JPEG header, the passed s5p_jpeg_q_data structure is not modify so there is no need to use a temporary structure and the field-by-field copy can be avoided. Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 23

[PATCH v3 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-27 Thread Thierry Escande
ange event support patch. Thierry Escande (3): [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr() [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue [media] s5p-jpeg: Split s5p_jpeg_parse_hdr() Tony K Nadackal (3): [media] s5p-jpeg: Call jpeg_bound_align_image

[PATCH v3 0/8] [media] s5p-jpeg: Various fixes and improvements

2017-06-27 Thread Thierry Escande
ange event support patch. Thierry Escande (3): [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr() [media] s5p-jpeg: Don't use temporary structure in s5p_jpeg_buf_queue [media] s5p-jpeg: Split s5p_jpeg_parse_hdr() Tony K Nadackal (3): [media] s5p-jpeg: Call jpeg_bound_align_image

[PATCH v3 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-27 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jp

[PATCH v3 2/8] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-27 Thread Thierry Escande
From: Tony K Nadackal Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v3 7/8] [media] s5p-jpeg: Add support for resolution change event

2017-06-27 Thread Thierry Escande
s used in the Chromium browser project by the V4L2 JPEG Decode Accelerator (V4L2JDA) to allocate output buffer. Signed-off-by: Henry-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg

[PATCH v3 7/8] [media] s5p-jpeg: Add support for resolution change event

2017-06-27 Thread Thierry Escande
project by the V4L2 JPEG Decode Accelerator (V4L2JDA) to allocate output buffer. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 106 +--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 7 ++ 2 files changed

[PATCH v3 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

2017-06-27 Thread Thierry Escande
This patch moves the subsampling value decoding read from the jpeg header into its own function. This new function is called s5p_jpeg_subsampling_decode() and returns true if it successfully decodes the subsampling value, false otherwise. Signed-off-by: Thierry Escande <thierry.e

[PATCH v3 5/8] [media] s5p-jpeg: Split s5p_jpeg_parse_hdr()

2017-06-27 Thread Thierry Escande
This patch moves the subsampling value decoding read from the jpeg header into its own function. This new function is called s5p_jpeg_subsampling_decode() and returns true if it successfully decodes the subsampling value, false otherwise. Signed-off-by: Thierry Escande --- drivers/media

[PATCH v3 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-27 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media

[PATCH v3 6/8] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-27 Thread Thierry Escande
From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 15 +++ 1 file changed, 15 insertions(+) diff

[PATCH v3 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-27 Thread Thierry Escande
ey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/plat

[PATCH v3 8/8] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-27 Thread Thierry Escande
From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when ERR_INT_EN is set to 1. Fix this case and report BUF_STATE_ERROR to videobuf2. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry

[PATCH v3 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-27 Thread Thierry Escande
msung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 52dc7

[PATCH v3 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

2017-06-27 Thread Thierry Escande
This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.

[PATCH v3 3/8] [media] s5p-jpeg: Handle parsing error in s5p_jpeg_parse_hdr()

2017-06-27 Thread Thierry Escande
This patch modifies the s5p_jpeg_parse_hdr() function so it only modifies the passed s5p_jpeg_q_data structure if the jpeg header parsing is successful. Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 38 - 1 file changed, 21

[PATCH v3 1/8] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-27 Thread Thierry Escande
header. If the width/height values of jpeg are not aligned, the decoder output will be corrupted. So in this patch we call jpeg_bound_align_image() to align the width/height values of Capture buffer in s5p_jpeg_buf_queue(). Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers

Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP events support over ACPI

2017-06-23 Thread Thierry Escande
Hi Benson, On 22/06/2017 21:35, Benson Leung wrote: + adev = ACPI_COMPANION(dev); + if (adev) { + status = acpi_install_notify_handler(adev->handle, +ACPI_ALL_NOTIFY, Is there a reason you're using

Re: [PATCH RESEND 09/13] platform/chrome: cros_ec_lpc: Add MKBP events support over ACPI

2017-06-23 Thread Thierry Escande
Hi Benson, On 22/06/2017 21:35, Benson Leung wrote: + adev = ACPI_COMPANION(dev); + if (adev) { + status = acpi_install_notify_handler(adev->handle, +ACPI_ALL_NOTIFY, Is there a reason you're using

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-20 Thread Thierry Escande
Hi Andrzej, On 20/06/2017 12:51, Andrzej Pietrasiewicz wrote: Hi Thierry, W dniu 19.06.2017 o 15:50, Thierry Escande pisze: Hi Andrzej, On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote: Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-20 Thread Thierry Escande
Hi Andrzej, On 20/06/2017 12:51, Andrzej Pietrasiewicz wrote: Hi Thierry, W dniu 19.06.2017 o 15:50, Thierry Escande pisze: Hi Andrzej, On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote: Hi Thierry, Thank you for the patch. Can you give a use case for resolution change event

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-19 Thread Thierry Escande
see inline. W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: henryhsu <henry...@chromium.org> @@ -1611,8 +1612,6 @@ static int s5p_jpeg_s_fmt(struct s5p_jpeg_ctx *ct, struct v4l2_format *f) FMT_TYPE_OUTPUT : FMT_TYPE_CAPTURE; q_data->fmt = s5p_jpeg_find_forma

Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-19 Thread Thierry Escande
see inline. W dniu 12.06.2017 o 19:13, Thierry Escande pisze: From: henryhsu @@ -1611,8 +1612,6 @@ static int s5p_jpeg_s_fmt(struct s5p_jpeg_ctx *ct, struct v4l2_format *f) FMT_TYPE_OUTPUT : FMT_TYPE_CAPTURE; q_data->fmt = s5p_jpeg_find_format(ct, pix->pixelformat,

[PATCH v2 2/6] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-12 Thread Thierry Escande
msung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 52dc7

[PATCH v2 2/6] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-12 Thread Thierry Escande
header. If the width/height values of jpeg are not aligned, the decoder output will be corrupted. So in this patch we call jpeg_bound_align_image() to align the width/height values of Capture buffer in s5p_jpeg_buf_queue(). Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers

[PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-12 Thread Thierry Escande
ey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/plat

[PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-12 Thread Thierry Escande
From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when ERR_INT_EN is set to 1. Fix this case and report BUF_STATE_ERROR to videobuf2. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry

[PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-12 Thread Thierry Escande
From: Abhilash Kesavan <a.kesa...@samsung.com> This patch resets the encoding and decoding register bits before doing a soft reset. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platfor

[PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-12 Thread Thierry Escande
From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-12 Thread Thierry Escande
Henry-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 125 +++- drivers/media/platform/s5p-jpeg/jpeg-core.h | 7 ++ 2 files changed, 91 insertions(+), 41 deleti

[PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event

2017-06-12 Thread Thierry Escande
-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 125 +++- drivers/media/platform/s5p-jpeg/jpeg-core.h | 7 ++ 2 files changed, 91 insertions(+), 41 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p

[PATCH v2 3/6] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-12 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jp

[PATCH v2 3/6] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-12 Thread Thierry Escande
From: Tony K Nadackal Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH v2 4/6] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-12 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media

[PATCH v2 0/6] [media] s5p-jpeg: Various fixes and improvements

2017-06-12 Thread Thierry Escande
Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. All these patches come from the Chromium v3.8 kernel tree. In this v2: - Remove IOMMU support patch (mapping now created automatically for single JPEG CODEC device). - Remove "Change sclk_jpeg to 166MHz"

[PATCH v2 4/6] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-12 Thread Thierry Escande
From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 0/6] [media] s5p-jpeg: Various fixes and improvements

2017-06-12 Thread Thierry Escande
Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. All these patches come from the Chromium v3.8 kernel tree. In this v2: - Remove IOMMU support patch (mapping now created automatically for single JPEG CODEC device). - Remove "Change sclk_jpeg to 166MHz"

Re: [PATCH 6/9] [media] s5p-jpeg: Add support for resolution change event

2017-06-07 Thread Thierry Escande
Hi Jacek, On 02/06/2017 23:53, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: henryhsu <henry...@chromium.org> This patch adds support for resolution change event to notify clients so they can prepare correct output buffer. When resolution

Re: [PATCH 6/9] [media] s5p-jpeg: Add support for resolution change event

2017-06-07 Thread Thierry Escande
Hi Jacek, On 02/06/2017 23:53, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: henryhsu This patch adds support for resolution change event to notify clients so they can prepare correct output buffer. When resolution change happened, G_FMT

Re: [PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-07 Thread Thierry Escande
Hi Jacek, On 02/06/2017 21:50, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: Abhilash Kesavan <a.kesa...@samsung.com> This patch resets the encoding and decoding register bits before doing a soft reset. Signed-off-by: Tony K Nadackal

Re: [PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-07 Thread Thierry Escande
Hi Jacek, On 02/06/2017 21:50, Jacek Anaszewski wrote: Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande

[PATCH 0/9] [media] s5p-jpeg: Various fixes and improvements

2017-06-02 Thread Thierry Escande
Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. All these patches come from the Chromium v3.8 kernel tree. Regards, Thierry Abhilash Kesavan (1): [media] s5p-jpeg: Reset the Codec before doing a soft reset Ricky Liang (1): [media] s5p-jpeg: Add

[PATCH 0/9] [media] s5p-jpeg: Various fixes and improvements

2017-06-02 Thread Thierry Escande
Hi, This series contains various fixes and improvements for the Samsung s5p-jpeg driver. All these patches come from the Chromium v3.8 kernel tree. Regards, Thierry Abhilash Kesavan (1): [media] s5p-jpeg: Reset the Codec before doing a soft reset Ricky Liang (1): [media] s5p-jpeg: Add

[PATCH 4/9] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-02 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media

[PATCH 4/9] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format

2017-06-02 Thread Thierry Escande
From: Tony K Nadackal This patch adds support for decoding 4:1:1 chroma subsampling in the jpeg header parsing function. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 6/9] [media] s5p-jpeg: Add support for resolution change event

2017-06-02 Thread Thierry Escande
Henry-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 121 drivers/media/platform/s5p-jpeg/jpeg-core.h | 7 ++ 2 files changed, 95 insertions(+), 33 deleti

[PATCH 6/9] [media] s5p-jpeg: Add support for resolution change event

2017-06-02 Thread Thierry Escande
-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 121 drivers/media/platform/s5p-jpeg/jpeg-core.h | 7 ++ 2 files changed, 95 insertions(+), 33 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p

[PATCH 5/9] [media] s5p-jpeg: Add IOMMU support

2017-06-02 Thread Thierry Escande
<tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 77 + 1 file changed, 77 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5

[PATCH 5/9] [media] s5p-jpeg: Add IOMMU support

2017-06-02 Thread Thierry Escande
From: Tony K Nadackal This patch adds support for IOMMU s5p-jpeg driver if the Exynos IOMMU and ARM DMA IOMMU configurations are supported. The address space is created with size limited to 256M and base address set to 0x2000. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande

[PATCH 7/9] [media] s5p-jpeg: Change sclk_jpeg to 166MHz for Exynos5250

2017-06-02 Thread Thierry Escande
From: henryhsu <henry...@chromium.org> The default clock parent of jpeg on Exynos5250 is fin_pll, which is 24MHz. We have to change the clock parent to CPLL, which is 333MHz, and set sclk_jpeg to 166MHz. Signed-off-by: Heng-Ruey Hsu <henry...@chromium.org> Signed-off-by: Thi

[PATCH 7/9] [media] s5p-jpeg: Change sclk_jpeg to 166MHz for Exynos5250

2017-06-02 Thread Thierry Escande
From: henryhsu The default clock parent of jpeg on Exynos5250 is fin_pll, which is 24MHz. We have to change the clock parent to CPLL, which is 333MHz, and set sclk_jpeg to 166MHz. Signed-off-by: Heng-Ruey Hsu Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 47

[PATCH 8/9] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-02 Thread Thierry Escande
ey Hsu <henry...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/plat

[PATCH 8/9] [media] s5p-jpeg: Add stream error handling for Exynos5420

2017-06-02 Thread Thierry Escande
From: henryhsu On Exynos5420, the STREAM_STAT bit raised on the JPGINTST register means there is a syntax error or an unrecoverable error on compressed file when ERR_INT_EN is set to 1. Fix this case and report BUF_STATE_ERROR to videobuf2. Signed-off-by: Henry-Ruey Hsu Signed-off-by: Thierry

[PATCH 3/9] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-02 Thread Thierry Escande
From: Tony K Nadackal <tony...@samsung.com> Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jp

[PATCH 3/9] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling

2017-06-02 Thread Thierry Escande
From: Tony K Nadackal Corrects the WARN_ON statement for subsampling based on the JPEG Hardware version. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 2/9] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-02 Thread Thierry Escande
msung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media/platform/s5p-jpeg/jpeg-core.c index 52dc794..6fb1ab4 10

[PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-02 Thread Thierry Escande
From: Abhilash Kesavan <a.kesa...@samsung.com> This patch resets the encoding and decoding register bits before doing a soft reset. Signed-off-by: Tony K Nadackal <tony...@samsung.com> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platfor

[PATCH 9/9] [media] s5p-jpeg: Add support for multi-planar APIs

2017-06-02 Thread Thierry Escande
Signed-off-by: Ricky Liang <jcli...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 152 +--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 + 2 files changed, 139 insertion

[PATCH 2/9] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf

2017-06-02 Thread Thierry Escande
header. If the width/height values of jpeg are not aligned, the decoder output will be corrupted. So in this patch we call jpeg_bound_align_image() to align the width/height values of Capture buffer in s5p_jpeg_buf_queue(). Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers

[PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-02 Thread Thierry Escande
From: Abhilash Kesavan This patch resets the encoding and decoding register bits before doing a soft reset. Signed-off-by: Tony K Nadackal Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-hw-exynos4.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers

[PATCH 9/9] [media] s5p-jpeg: Add support for multi-planar APIs

2017-06-02 Thread Thierry Escande
Signed-off-by: Thierry Escande --- drivers/media/platform/s5p-jpeg/jpeg-core.c | 152 +--- drivers/media/platform/s5p-jpeg/jpeg-core.h | 2 + 2 files changed, 139 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.c b/drivers/media

[PATCH v2] [media] v4l2: Add support for go2001 PCI codec driver

2017-05-25 Thread Thierry Escande
in Linux v4.4. This driver is originally developed by: Pawel Osciak <posc...@chromium.org> Ville-Mikko Rautio <v...@chromium.org> henryhsu <henry...@chromium.org> Wu-Cheng Li <wuchen...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com> --- Cha

[PATCH v2] [media] v4l2: Add support for go2001 PCI codec driver

2017-05-25 Thread Thierry Escande
in Linux v4.4. This driver is originally developed by: Pawel Osciak Ville-Mikko Rautio henryhsu Wu-Cheng Li Signed-off-by: Thierry Escande --- Changes in v2: - Removed unneeded call to dma_cache_sync() on coherent dma buffer. drivers/media/pci/Kconfig|2 + drivers/media

[PATCH v4] sd: Ignore sync cache failures when not supported

2017-05-11 Thread Thierry Escande
t much we can do for these drives, so we shouldn't fail to suspend for this error case. The drive may stay powered if that's the setup for the port it's plugged into. Signed-off-by: Derek Basehore <dbaseh...@chromium.org> Signed-off-by: Thierry Escande <thierry.esca...@collabora.com&g

[PATCH v4] sd: Ignore sync cache failures when not supported

2017-05-11 Thread Thierry Escande
for these drives, so we shouldn't fail to suspend for this error case. The drive may stay powered if that's the setup for the port it's plugged into. Signed-off-by: Derek Basehore Signed-off-by: Thierry Escande --- v4 changes: - Check sense header validity before checking the sense_key field - Get rid

<    1   2   3   4   5   6   7   8   >