Same symbol with EXPORT_SYMBOL and EXPORT_SYMBOL_GPL

2021-01-09 Thread Thomas Meyer
Hi, I have a question regarding EXPORT_SYMBOL vs. EXPORT_SYMBOL_GPL: I did stumble upon different export declarations between different architectures, e.g.: $ grep -r -e "EXPORT_SYMBOL[^(]*(" * | tr ":()" " " | sort -s -k 3 -k 2 | grep __virt_addr_valid arch/mips/mm/mmap.c EXPORT_SYMBOL_GPL

[PATCH 1/2] lib/bsearch.c: introduce bsearch_idx

2019-10-19 Thread Thomas Meyer
many existing bsearch implementations don't want to have the pointer to the found element, but the index position, or if the searched element doesn't exist, the index position the search element would be placed in the array. Signed-off-by: Thomas Meyer --- include/linux/bsea

[PATCH 2/2] xfs: replace homemade binary search

2019-10-19 Thread Thomas Meyer
use newly introduced bsearch_idx instead. Signed-off-by: Thomas Meyer --- fs/xfs/libxfs/xfs_dir2_block.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/fs/xfs/libxfs/xfs_dir2_block.c b/fs/xfs/libxfs/xfs_dir2_block.c index 9595ced393dce

Re: [PATCH] kernel/groups.c: use bsearch library function

2019-10-09 Thread Thomas Meyer
Rasmus Villemoes writes: > On 07/10/2019 21.26, Thomas Meyer wrote: >> commit b7b2562f7252 ("kernel/groups.c: use sort library function") >> introduced the sort library function. >> also use the bsearch library function instead of open-coding the binary >>

[PATCH] kernel/groups.c: use bsearch library function

2019-10-07 Thread Thomas Meyer
commit b7b2562f7252 ("kernel/groups.c: use sort library function") introduced the sort library function. also use the bsearch library function instead of open-coding the binary search. Signed-off-by: Thomas Meyer --- kernel/groups.c | 17 - 1 file changed, 4 inserti

[PATCH] counter: ftm-quaddec: needs HAS_IOMEM

2019-06-01 Thread Thomas Meyer
the driver fails for UML with: drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap' Fix it by depending on HAS_IOMEM --- drivers/counter/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig index 138ecd8a8fbd..6298344b53

[PATCH] scsi: pmcraid: Use *_pool_zalloc rather than *_pool_alloc

2019-05-29 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -4668,18 +4668,14 @@ static int pmcraid_allocate_control_bloc

Cocci spatch "pool_zalloc-simple" - v5.2-rc1

2019-05-29 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Run against version v5.2-rc1 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

[PATCH] scsi: lpfc: Use *_pool_zalloc rather than *_pool_alloc

2019-05-29 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -4114,14 +4114,13 @@ lpfc_new_io_buf(struct

Cocci spatch "vma_pages" - v5.2-rc1

2019-05-29 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Run against version v5.2-rc1 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

[PATCH] vfio-pci/nvlink2: Use vma_pages function instead of explicit computation

2019-05-29 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c --- a/drivers/vfio/pci/vfio_pci_nvlink2.c +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c @@ -161,7 +161,7

Cocci spatch "of_table" - v5.2-rc1

2019-05-27 Thread Thomas Meyer
Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Run against version v5.2-rc1 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

[no subject]

2019-05-26 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c --- a/drivers/vfio/pci/vfio_pci_nvlink2.c +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c @@ -161,7 +161,7 @@

[no subject]

2019-05-26 Thread Thomas Meyer
>From tho...@m3y3r.de Sun May 26 00:14:21 2019 Subject: Cocci spatch "vma_pages" - v5.2-rc1 To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1558822461331-726613767-0-diffspli

[no subject]

2019-05-26 Thread Thomas Meyer
>From tho...@m3y3r.de Sun May 26 13:49:24 2019 Subject: Cocci spatch "of_table" - v5.2-rc1 To: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patch: Cocci X-Mailer: DiffSplit Message-ID: <1558871364605-1026448693-0-diffspli

[no subject]

2019-05-26 Thread Thomas Meyer
y3r.de> X-Serial-No: 1 Make sure (of/i2c/platform)_device_id tables are NULL terminated. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c --- a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c +++ b/driv

uio drivers?

2019-01-10 Thread Thomas Meyer
Hi, I wanted to have a look at some existing userspace i/o drivers, but wasn't able to find any. do such drivers exist? Can anybody point me to some uio drivers with open source code? with kind regards thomas

[PATCH] platform/x86: intel_ips: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c --- a/drivers/platform/x86/intel_ips.c +++ b/drivers/platform/x86/intel_ips.c @@ -1300,8 +1300,7 @@ static const struct

[PATCH] PM / AVS: SmartReflex: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -1010,8 +1010,7 @@ static int omap_sr_remove

[PATCH] scsi: megaraid_sas: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c --- a/drivers/scsi/megaraid/megaraid_mbox.c +++ b/drivers/scsi/megaraid/megaraid_mbox.c @@ -1243,8 +1243,7

[PATCH] [SCSI] zfcp: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c --- a/drivers/s390/scsi/zfcp_aux.c +++ b/drivers/s390/scsi/zfcp_aux.c @@ -248,20 +248,13 @@ static int zfcp_allocate_low_mem_buffers

[PATCH] drm/amdgpu: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c @@ -816,6

Cocci spatch "ifnullfree" - v4.20-rc4

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Found by coccinelle spatch "free/ifnullfree.cocci" Run against version v4.20-rc4 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

[PATCH] scsi: qla2xxx: NULL check before some freeing functions is not needed.

2018-12-02 Thread Thomas Meyer
NULL check before some freeing functions is not needed. Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4191,12 +4191,10 @@ fail_free_nvram: kfree(ha

sky2: no irq handler on v4.17.6

2018-07-22 Thread Thomas Meyer
Hi, I currently use my old i386 laptop with kernel v4.14.55 where my sky2 ethernet driver works correctly. I tried to upgrade to v4.17.6 but the sky2 driver fails with "No irq handler for vector". any ideas? dmesg: [0.00] Linux version 4.17.6+ (thomas@computer) (gcc version 8.1.1 2018

Re: [PATCH] auxdisplay: img-ascii-lcd: Only build on archs that have IOMEM

2017-11-27 Thread Thomas Meyer
On Thu, Aug 10, 2017 at 11:24:04AM -0700, Randy Dunlap wrote: > On 08/10/2017 01:53 AM, Thomas Meyer wrote: > > This avoids the MODPOST error: > > ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko] > > undefined! > > > > Signed

of: unittest fails on UML

2017-10-13 Thread Thomas Meyer
Hi, drivers/of/unittest.c fails on UML with a kernel crash. The crash is due to of_find_device_by_node() returning NULL: 841│ /* Test that a missing irq domain returns -EPROBE_DEFER */ 842│ np = of_find_node_by_path("/testcase-data/testcase-device1"); 843├>pdev = of_find_d

of/unittest fails on UML

2017-10-13 Thread Thomas Meyer
Hi, drivers/of/unittest.c fails on UML with a kernel crash. The crash is due to of_find_device_by_node() returning NULL: 841│ /* Test that a missing irq domain returns -EPROBE_DEFER */ 842│ np = of_find_node_by_path("/testcase-data/testcase-device1"); 843├>pdev = of_find_d

[PATCH] um: Fix kcov crash before kernel is started.

2017-10-13 Thread Thomas Meyer
UMLs current_thread_info() unconditionally assumes that the top of the stack contains the thread_info structure. Prevent kcov from using invalid curent_thread_info() data by disable instrumentation of early startup code. Signed-off-by: Thomas Meyer --- arch/um/kernel/skas/Makefile | 2 ++ lib

Re: [tho...@m3y3r.de: Re: [PATCH] um: Fix kcov crash before kernel is started.]

2017-10-09 Thread Thomas Meyer
On Mon, Oct 09, 2017 at 08:10:45PM +0200, Dmitry Vyukov wrote: > On Mon, Oct 9, 2017 at 6:47 PM, Thomas Meyer wrote: > > - Forwarded message from Thomas Meyer - > > > > Hi, > > > > are you able to shed light on this topic? > > Any help is greatly

Re: [PATCH] um: Fix kcov crash before kernel is started.

2017-10-08 Thread Thomas Meyer
On Sun, Oct 08, 2017 at 12:44:12PM +0200, Richard Weinberger wrote: > Am Sonntag, 8. Oktober 2017, 12:31:58 CEST schrieb Thomas Meyer: > > UMLs current_thread_info() unconditionally assumes that the top of the stack > > contains the thread_info structure. But on UML the __sanitiz

[PATCH] um: Fix kcov crash before kernel is started.

2017-10-08 Thread Thomas Meyer
the system_state. Signed-off-by: Thomas Meyer --- kernel/kcov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kernel/kcov.c b/kernel/kcov.c index 3f693a0f6f3e..d601c0e956f6 100644 --- a/kernel/kcov.c +++ b/kernel/kcov.c @@ -56,6 +56,12 @@ void notrace __sanitizer_cov_trace_pc(void

Re: Build regressions/improvements in v4.14-rc3

2017-10-07 Thread Thomas Meyer
On Sun, Oct 08, 2017 at 09:50:53AM +1100, Michael Ellerman wrote: > Thomas Meyer writes: > > > On Thu, Oct 05, 2017 at 01:43:31PM +1100, Michael Ellerman wrote: > >> Thomas Meyer writes: > >> > On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrot

[PATCH] apparmor: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/security/apparmor/lsm.c b/security/apparmor/lsm.c --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c @@ -761,7 +761,7 @@ module_param_call(

[PATCH] ceph: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/ceph/caps.c b/fs/ceph/caps.c --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c @@ -1711,7 +1711,7 @@ void ceph_check_caps(struct ceph_inode_i /* if w

[PATCH] btrfs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -6958,7 +6958,7 @@ static int __btrfs_free_extent(s

[PATCH] exofs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/exofs/super.c b/fs/exofs/super.c --- a/fs/exofs/super.c +++ b/fs/exofs/super.c @@ -116,7 +116,7 @@ static int parse_options(char *op

[PATCH] nfsd: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c --- a/fs/nfsd/nfs4proc.c +++ b/fs/nfsd/nfs4proc.c @@ -230,7 +230,7 @@ do_open_lookup(struct svc_rqst *rqstp, s

[PATCH] proc: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/proc/generic.c b/fs/proc/generic.c --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -325,7 +325,7 @@ static int proc_register(struct proc_dir write

[PATCH] NFS: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c --- a/fs/nfs/callback_proc.c +++ b/fs/nfs/callback_proc.c @@ -439,7 +439,7 @@ static bool referring_call_exists(s

[PATCH] pstore: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/pstore/ftrace.c b/fs/pstore/ftrace.c --- a/fs/pstore/ftrace.c +++ b/fs/pstore/ftrace.c @@ -148,7 +148,7 @@ void pstore_unregister_ftrace(void) mutex

[PATCH] configfs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/configfs/file.c b/fs/configfs/file.c --- a/fs/configfs/file.c +++ b/fs/configfs/file.c @@ -166,7 +166,7 @@ configfs_read_bin_file(struct file

[PATCH] f2fs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/f2fs/data.c b/fs/f2fs/data.c --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -419,7 +419,7 @@ next: bio_page = fio->encrypted_page ? fio->encrypted

Cocci spatch "boolinit" - v4.14-rc1

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Found by coccinelle spatch "misc/boolinit.cocci" Run against version v4.14-rc1 P.S. If you find this email unwanted, set up a procmail rule junking on the header: X-Patch: Cocci

[PATCH] ima: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c --- a/security/integrity/ima/ima_fs.c +++ b/security/integrity/ima/ima_fs.c @@ -32,7 +32,7 @@

[PATCH] bfq: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/block/bfq-iosched.c b/block/bfq-iosched.c --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4986,7 +4986,7 @@ static ssize_t bfq_low_latency_stor

[PATCH] xfs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c --- a/fs/xfs/libxfs/xfs_bmap.c +++ b/fs/xfs/libxfs/xfs_bmap.c @@ -1490,14 +1490,14 @@ xfs_bmap_isaeof(

[PATCH] ext4: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/ext4/extents.c b/fs/ext4/extents.c --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -5242,7 +5242,7 @@ ext4_ext_shift_path_extents(struct ext4_ {

[PATCH] selinux: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c --- a/security/selinux/ss/mls.c +++ b/security/selinux/ss/mls.c @@ -550,7 +550,7 @@ int mls_compute_sid(s

[PATCH] cifs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c --- a/fs/cifs/cifsacl.c +++ b/fs/cifs/cifsacl.c @@ -370,7 +370,7 @@ sid_to_id(struct cifs_sb_info *cifs_sb,

[PATCH] afs: Fix bool initialization/comparison

2017-10-07 Thread Thomas Meyer
Bool initializations should use true and false. Bool tests don't need comparisons. Signed-off-by: Thomas Meyer --- diff -u -p a/fs/afs/cache.c b/fs/afs/cache.c --- a/fs/afs/cache.c +++ b/fs/afs/cache.c @@ -195,7 +195,7 @@ enum fscache_checkaux afs_vlocation_cach * VL record fro

Re: Build regressions/improvements in v4.14-rc3

2017-10-05 Thread Thomas Meyer
On Thu, Oct 05, 2017 at 01:43:31PM +1100, Michael Ellerman wrote: > Thomas Meyer writes: > > On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrote: > ... > >> > >> I've switched it to using one of the toolchains from Free Electrons, > >> whi

kselftest on UML results - 4.14.0-rc3-00019-g78d8732cf2d8

2017-10-03 Thread Thomas Meyer
Hi, here are the results from running the kselftests under UML, created with the script available here: https://github.com/thomasmey/uml/blob/master/uml-fedora-kselftest.sh 1.) code coverage http://m3y3r.de/kselftest/4.14.0-rc3-00019-g78d8732cf2d8/coverage/index.html 2.) cyclomatic complexity h

Re: Build regressions/improvements in v4.14-rc3

2017-10-03 Thread Thomas Meyer
On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrote: > Geert Uytterhoeven writes: > > > Hi Thomas, > > > > On Mon, Oct 2, 2017 at 4:11 PM, Thomas Meyer wrote: > >> On Mon, Oct 02, 2017 at 11:49:33AM +0200, Geert Uytterhoeven wrote: > >>

Re: Build regressions/improvements in v4.14-rc3

2017-10-02 Thread Thomas Meyer
On Mon, Oct 02, 2017 at 11:49:33AM +0200, Geert Uytterhoeven wrote: > Below is the list of build error/warning regressions/improvements in > v4.14-rc3[1] compared to v4.13[2]. Hi, a question regarding the um-defconfig build: http://kisskb.ellerman.id.au/kisskb/target/2974/ The error thrown looks

[PATCH] gcov: GCOV_KERNEL and GCOV are mutually exclusive

2017-09-26 Thread Thomas Meyer
Fix it by forcing the user to choose one of the two GCOV options. Signed-off-by: Thomas Meyer --- kernel/gcov/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig index 1276aabaab55..6c0dd2a6d4fd 100644 --- a/kernel/gcov/Kconfig +++ b/kernel/gcov

radeon_get_bios: BUG: unable to handle kernel paging request

2017-09-24 Thread Thomas Meyer
Hi, while trying to resurrect my old Macbook as an 32 bit kernel testing device, I think someone broke the radeon driver on this first generation pure EFI boot Macbook. My guess would be that the introduction of the vga_switcheroo code did break the radeon_get_bios functionality. I will try agai

[PATCH 3/4] VFS: normal filesystems (and lustre): Cocci spatch "alloc_cast"

2017-09-20 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c --- a/f

[PATCH 1/4] drm/amd/powerplay: Cocci spatch "alloc_cast"

2017-09-20 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_proce

[PATCH 0/4] Cocci spatch "alloc_cast" - v4.14-rc1

2017-09-20 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Run against version v4.14-rc1 Let me know when you as a maintainer are not interested in these kind of patch

[PATCH 2/4] fs: Cocci spatch "alloc_cast"

2017-09-20 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c --- a/fs

[PATCH 4/4] ALSA: emu10k1: Cocci spatch "alloc_cast"

2017-09-20 Thread Thomas Meyer
Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc." Found by coccinelle spatch "api/alloc/alloc_cast.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k

[PATCH 3/3] net: stmmac: Cocci spatch "of_table"

2017-09-20 Thread Thomas Meyer
Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c --- a/d

[PATCH 0/3] Cocci spatch "of_table" - v4.14-rc1

2017-09-20 Thread Thomas Meyer
Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Run against version v4.14-rc1 Let me know when you as a maintainer are not interested in these kind of patches. I can exclude you by path; e.g. all findings in "drivers/scsi" will

[PATCH 2/3] i2c: Cocci spatch "of_table"

2017-09-20 Thread Thomas Meyer
Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c --- a/drivers/i2c/busses/i2c-sprd.c +++ b/drivers/i2c/busses/

[PATCH 1/3] ARM: mediatek: Cocci spatch "of_table"

2017-09-20 Thread Thomas Meyer
Make sure (of/i2c/platform)_device_id tables are NULL terminated. Found by coccinelle spatch "misc/of_table.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c --- a/arch/arm/mach-mediatek/platsmp.c +++ b/arch/arm/mac

[PATCH 2/6] e100: Cocci spatch "pool_zalloc-simple"

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c --- a/drivers/net/ethernet/intel/e1

[PATCH 4/6] mvsas: Cocci spatch "pool_zalloc-simple"

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c --- a/drivers/scsi/mvsas/mv_sas.c +++ b/drivers/

[PATCH 6/6] scsi: Cocci spatch "pool_zalloc-simple"

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++

[PATCH 5/6] scsi: qla2xxx: Cocci spatch "pool_zalloc-simple"

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c --- a/drivers/scsi/qla2xxx/qla_bsg.c +++

[PATCH 0/6] Cocci spatch "pool_zalloc-simple" - v4.14-rc1

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Run against version v4.14-rc1 Let me know when you as a maintainer are not interested in these kind of patches. I can exclude you by path; e.g. all findings in "

[PATCH 1/6] mailbox: bcm-flexrm-mailbox: Cocci spatch "pool_zalloc-simple"

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c --- a/drivers/mailbox/

[PATCH 3/6] scsi: lpfc: Cocci spatch "pool_zalloc-simple"

2017-09-20 Thread Thomas Meyer
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c --- a/drivers/scsi/lpfc/lpfc_nvme.c +++ b/dr

[PATCH 0/1] Cocci spatch "simple_open" - v4.14-rc1

2017-09-20 Thread Thomas Meyer
This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. Found by coccinelle spatch "api/simple_open.cocci" Run against version v4.14-rc1 Let me know when you as a maintainer are not interested in these kind of patches

[PATCH 1/1] [SCSI] fnic: Cocci spatch "simple_open"

2017-09-20 Thread Thomas Meyer
This removes an open coded simple_open() function and replaces file operations references to the function with simple_open() instead. Found by coccinelle spatch "api/simple_open.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/scsi/fnic/fnic_debugfs.c b/drivers

[PATCH 2/7] arm64: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma

[PATCH 0/7] Cocci spatch "vma_pages" - v4.14-rc1

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Run against version v4.14-rc1 Let me know when you as a maintainer are not interested in these kind of patches. I can exclude you by path; e.g. all findings in "drivers/scsi" w

[PATCH 3/7] metag: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/metag/kernel/dma.c b/arch/metag/kernel/dma.c --- a/arch/metag/kernel/dma.c +++ b/arch/metag/kernel/dma.c @@ -34

[PATCH 1/7] ARM: dma-mapping: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c

[PATCH 4/7] microblaze: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c --- a/arch/microblaze/kernel/dma.c +++ b/arch/microblaze/ke

[PATCH 5/7] MIPS: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/mips/mm/dma-default.c b/arch/mips/mm/dma-default.c --- a/arch/mips/mm/dma-default.c +++ b/arch/mips/mm/dma-default.c

[PATCH 7/7] drm/rockchip: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c --- a/drivers/gpu/dr

[PATCH 6/7] KVM: PPC: Cocci spatch "vma_pages"

2017-09-20 Thread Thomas Meyer
Use vma_pages function on vma object instead of explicit computation. Found by coccinelle spatch "api/vma_pages.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c --- a/arch/powerpc/kvm/e500_mmu_host.c +++ b/arch/p

Re: (*ABS*+0xbb29b267): multiple definition of `__crc___gcov_merge_add'

2017-09-18 Thread Thomas Meyer
True, as CONFIG_GCOV and CONFIG_GCOV_KERNEL should be mutually exclusive CONFIG options. With kind regards Thomas > Am 17.09.2017 um 20:52 schrieb kbuild test robot : > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 0666f560b71b899cd11a7caf39fd4

Re: [PATCH V2] tipc: Use bsearch library function

2017-09-17 Thread Thomas Meyer
> Am 16.09.2017 um 15:20 schrieb Jon Maloy . >> >> What part of "very time critical" have you verified and benchmarked as >> inconsequential? >> >> Please post your results. > > I agree with Joe here. This change does not simplify anything, it does not > reduce the amount of code, plus that it

[PATCH] vt: Use bsearch library function in is_double_width

2017-09-16 Thread Thomas Meyer
Use bsearch library function instead of duplicated functionality. Signed-off-by: Thomas Meyer --- drivers/tty/vt/vt.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c index 2ebaba16f785..ca55004a639e

[PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Thomas Meyer
Use common library function rather than explicitly coding some variant of it yourself. Signed-off-by: Thomas Meyer --- net/tipc/name_table.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) V2: Coding style diff --git a/net/tipc/name_table.c b/net/tipc

kselftest on UML results - 4.13.0-11224-gcb1606851304

2017-09-12 Thread Thomas Meyer
Hi, Overall coverage rate: lines..: 34.6% (90861 of 262609 lines) functions..: 40.4% (9978 of 24683 functions) Coverage is available here: http://m3y3r.de/kselftest/4.13.0-11224-gcb1606851304/coverage/index.html My script also outputs those results files: 1.) Cyclomatic complexity http:

[PATCH] ARC: reset: Only build on archs that have IOMEM

2017-09-11 Thread Thomas Meyer
This avoids the error: drivers/reset/reset-hsdk-v1.o: In function `hsdkv1_reset_probe': /home/thomas/git/linux/drivers/reset/reset-hsdk-v1.c:101: undefined reference to `devm_ioremap_resource' collect2: error: ld returned 1 exit status Signed-off-by: Thomas Meyer --- drivers/reset/K

[PATCH] tipc: Use bsearch library function

2017-09-11 Thread Thomas Meyer
Use common library function rather than explicitly coding some variant of it yourself. Signed-off-by: Thomas Meyer --- net/tipc/name_table.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c index

[PATCH] media: rc: Use bsearch library function

2017-09-08 Thread Thomas Meyer
Replace self coded binary search, by existing library version. Signed-off-by: Thomas Meyer --- drivers/media/rc/rc-main.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index

[PATCH 3/3] selftests/net: msg_zerocopy enable build with older kernel headers

2017-09-08 Thread Thomas Meyer
Explicitly define SO_EE_ORIGIN_ZEROCOPY. This makes the test program build with older kernel headers, e.g. from Debian 9. Signed-off-by: Thomas Meyer --- tools/testing/selftests/net/msg_zerocopy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net

[PATCH 2/3] selftests/intel_pstate: No need to compile test progs in the run script

2017-09-08 Thread Thomas Meyer
: line 35: gcc: command not found Problem compiling aperf.c. Signed-off-by: Thomas Meyer --- tools/testing/selftests/intel_pstate/run.sh | 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh index

[PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support

2017-09-08 Thread Thomas Meyer
The multiple_kprobes test case fails to check for KPROBE_EVENT support. Add the check to prevent a false test result. Signed-off-by: Thomas Meyer --- tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests

[PATCH] selftests/bpf: Make bpf_util work on uniprocessor systems

2017-09-08 Thread Thomas Meyer
The current implementation fails to work on uniprocessor systems. Fix the parser to also handle the uniprocessor case. Signed-off-by: Thomas Meyer --- tools/testing/selftests/bpf/bpf_util.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tools/testing

Re: [PATCH] selftests: breakpoints: re-order TEST_GEN_PROGS targets

2017-09-08 Thread Thomas Meyer
On Fri, Sep 08, 2017 at 11:41:21AM +0300, Fathi Boudra wrote: > Shuah, should I resend? Hi, I also did send some patches to his kernel.org address after lazy searching for "Shuah" in my inbox. But maybe his other email address is the correct one. with kind regards thomas

[PATCH 2/2] selftests/memfd: Add null check for freepgs.

2017-09-07 Thread Thomas Meyer
User mode linux kernel has no huge pages. So this variable will be null. Guard all tests in the shell script with a null check. Signed-off-by: Thomas Meyer --- tools/testing/selftests/memfd/run_tests.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests

[PATCH 1/2] selftests/memfd: Actually make the test executable.

2017-09-07 Thread Thomas Meyer
The current shell script misses the execute flag. Signed-off-by: Thomas Meyer --- tools/testing/selftests/memfd/run_tests.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/memfd/run_tests.sh diff --git a/tools/testing/selftests/me

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-06 Thread Thomas Meyer
On Tue, Sep 05, 2017 at 02:22:05PM -0700, David Miller wrote: > From: Joe Perches > Date: Tue, 05 Sep 2017 13:01:18 -0700 > > > On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote: > >> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: > >> >

Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro

2017-09-05 Thread Thomas Meyer
On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote: > From: Thomas Meyer > Date: Sun, 03 Sep 2017 14:19:31 +0200 > > > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it > > yourself. > > Found with: find -type f -name "*.c"

  1   2   3   4   >