Hi,
I have a question regarding EXPORT_SYMBOL vs. EXPORT_SYMBOL_GPL:
I did stumble upon different export declarations between different
architectures, e.g.:
$ grep -r -e "EXPORT_SYMBOL[^(]*(" * | tr ":()" " " | sort -s -k 3 -k 2 |
grep __virt_addr_valid
arch/mips/mm/mmap.c EXPORT_SYMBOL_GPL
many existing bsearch implementations don't want to have the pointer to the
found element, but the index position, or if the searched element doesn't
exist, the index position the search element would be placed in the array.
Signed-off-by: Thomas Meyer
---
include/linux/bsea
use newly introduced bsearch_idx instead.
Signed-off-by: Thomas Meyer
---
fs/xfs/libxfs/xfs_dir2_block.c | 30 ++
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_dir2_block.c b/fs/xfs/libxfs/xfs_dir2_block.c
index 9595ced393dce
Rasmus Villemoes writes:
> On 07/10/2019 21.26, Thomas Meyer wrote:
>> commit b7b2562f7252 ("kernel/groups.c: use sort library function")
>> introduced the sort library function.
>> also use the bsearch library function instead of open-coding the binary
>>
commit b7b2562f7252 ("kernel/groups.c: use sort library function")
introduced the sort library function.
also use the bsearch library function instead of open-coding the binary
search.
Signed-off-by: Thomas Meyer
---
kernel/groups.c | 17 -
1 file changed, 4 inserti
the driver fails for UML with:
drivers/counter/ftm-quaddec.c:301: undefined reference to `devm_ioremap'
Fix it by depending on HAS_IOMEM
---
drivers/counter/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index 138ecd8a8fbd..6298344b53
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4668,18 +4668,14 @@ static int pmcraid_allocate_control_bloc
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Run against version v5.2-rc1
P.S. If you find this email unwanted, set up a procmail rule junking on
the header:
X-Patch: Cocci
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -4114,14 +4114,13 @@ lpfc_new_io_buf(struct
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Run against version v5.2-rc1
P.S. If you find this email unwanted, set up a procmail rule junking on
the header:
X-Patch: Cocci
Use vma_pages function on vma object instead of explicit computation.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c
b/drivers/vfio/pci/vfio_pci_nvlink2.c
--- a/drivers/vfio/pci/vfio_pci_nvlink2.c
+++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
@@ -161,7 +161,7
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"
Run against version v5.2-rc1
P.S. If you find this email unwanted, set up a procmail rule junking on
the header:
X-Patch: Cocci
Use vma_pages function on vma object instead of explicit computation.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/vfio/pci/vfio_pci_nvlink2.c
b/drivers/vfio/pci/vfio_pci_nvlink2.c
--- a/drivers/vfio/pci/vfio_pci_nvlink2.c
+++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
@@ -161,7 +161,7 @@
>From tho...@m3y3r.de Sun May 26 00:14:21 2019
Subject: Cocci spatch "vma_pages" - v5.2-rc1
To: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patch: Cocci
X-Mailer: DiffSplit
Message-ID: <1558822461331-726613767-0-diffspli
>From tho...@m3y3r.de Sun May 26 13:49:24 2019
Subject: Cocci spatch "of_table" - v5.2-rc1
To: linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patch: Cocci
X-Mailer: DiffSplit
Message-ID: <1558871364605-1026448693-0-diffspli
y3r.de>
X-Serial-No: 1
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
b/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
--- a/drivers/gpu/drm/omapdrm/dss/omapdss-boot-init.c
+++ b/driv
Hi,
I wanted to have a look at some existing userspace i/o drivers, but
wasn't able to find any. do such drivers exist?
Can anybody point me to some uio drivers with open source code?
with kind regards
thomas
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
--- a/drivers/platform/x86/intel_ips.c
+++ b/drivers/platform/x86/intel_ips.c
@@ -1300,8 +1300,7 @@ static const struct
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -1010,8 +1010,7 @@ static int omap_sr_remove
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/megaraid/megaraid_mbox.c
b/drivers/scsi/megaraid/megaraid_mbox.c
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -1243,8 +1243,7
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/s390/scsi/zfcp_aux.c b/drivers/s390/scsi/zfcp_aux.c
--- a/drivers/s390/scsi/zfcp_aux.c
+++ b/drivers/s390/scsi/zfcp_aux.c
@@ -248,20 +248,13 @@ static int zfcp_allocate_low_mem_buffers
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
@@ -816,6
NULL check before some freeing functions is not needed.
Found by coccinelle spatch "free/ifnullfree.cocci"
Run against version v4.20-rc4
P.S. If you find this email unwanted, set up a procmail rule junking on
the header:
X-Patch: Cocci
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4191,12 +4191,10 @@ fail_free_nvram:
kfree(ha
Hi,
I currently use my old i386 laptop with kernel v4.14.55 where my sky2
ethernet driver works correctly.
I tried to upgrade to v4.17.6 but the sky2 driver fails with "No irq
handler for vector".
any ideas?
dmesg:
[0.00] Linux version 4.17.6+ (thomas@computer) (gcc version 8.1.1
2018
On Thu, Aug 10, 2017 at 11:24:04AM -0700, Randy Dunlap wrote:
> On 08/10/2017 01:53 AM, Thomas Meyer wrote:
> > This avoids the MODPOST error:
> > ERROR: "devm_ioremap_resource" [drivers/auxdisplay/img-ascii-lcd.ko]
> > undefined!
> >
> > Signed
Hi,
drivers/of/unittest.c fails on UML with a kernel crash.
The crash is due to of_find_device_by_node() returning NULL:
841│ /* Test that a missing irq domain returns -EPROBE_DEFER */
842│ np = of_find_node_by_path("/testcase-data/testcase-device1");
843├>pdev = of_find_d
Hi,
drivers/of/unittest.c fails on UML with a kernel crash.
The crash is due to of_find_device_by_node() returning NULL:
841│ /* Test that a missing irq domain returns -EPROBE_DEFER */
842│ np = of_find_node_by_path("/testcase-data/testcase-device1");
843├>pdev = of_find_d
UMLs current_thread_info() unconditionally assumes that the top of the stack
contains the thread_info structure.
Prevent kcov from using invalid curent_thread_info() data by disable
instrumentation of early startup code.
Signed-off-by: Thomas Meyer
---
arch/um/kernel/skas/Makefile | 2 ++
lib
On Mon, Oct 09, 2017 at 08:10:45PM +0200, Dmitry Vyukov wrote:
> On Mon, Oct 9, 2017 at 6:47 PM, Thomas Meyer wrote:
> > - Forwarded message from Thomas Meyer -
> >
> > Hi,
> >
> > are you able to shed light on this topic?
> > Any help is greatly
On Sun, Oct 08, 2017 at 12:44:12PM +0200, Richard Weinberger wrote:
> Am Sonntag, 8. Oktober 2017, 12:31:58 CEST schrieb Thomas Meyer:
> > UMLs current_thread_info() unconditionally assumes that the top of the stack
> > contains the thread_info structure. But on UML the __sanitiz
the system_state.
Signed-off-by: Thomas Meyer
---
kernel/kcov.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 3f693a0f6f3e..d601c0e956f6 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -56,6 +56,12 @@ void notrace __sanitizer_cov_trace_pc(void
On Sun, Oct 08, 2017 at 09:50:53AM +1100, Michael Ellerman wrote:
> Thomas Meyer writes:
>
> > On Thu, Oct 05, 2017 at 01:43:31PM +1100, Michael Ellerman wrote:
> >> Thomas Meyer writes:
> >> > On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrot
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/security/apparmor/lsm.c b/security/apparmor/lsm.c
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -761,7 +761,7 @@ module_param_call(
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/ceph/caps.c b/fs/ceph/caps.c
--- a/fs/ceph/caps.c
+++ b/fs/ceph/caps.c
@@ -1711,7 +1711,7 @@ void ceph_check_caps(struct ceph_inode_i
/* if w
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -6958,7 +6958,7 @@ static int __btrfs_free_extent(s
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/exofs/super.c b/fs/exofs/super.c
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -116,7 +116,7 @@ static int parse_options(char *op
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -230,7 +230,7 @@ do_open_lookup(struct svc_rqst *rqstp, s
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/proc/generic.c b/fs/proc/generic.c
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -325,7 +325,7 @@ static int proc_register(struct proc_dir
write
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
--- a/fs/nfs/callback_proc.c
+++ b/fs/nfs/callback_proc.c
@@ -439,7 +439,7 @@ static bool referring_call_exists(s
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/pstore/ftrace.c b/fs/pstore/ftrace.c
--- a/fs/pstore/ftrace.c
+++ b/fs/pstore/ftrace.c
@@ -148,7 +148,7 @@ void pstore_unregister_ftrace(void)
mutex
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/configfs/file.c b/fs/configfs/file.c
--- a/fs/configfs/file.c
+++ b/fs/configfs/file.c
@@ -166,7 +166,7 @@ configfs_read_bin_file(struct file
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/f2fs/data.c b/fs/f2fs/data.c
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -419,7 +419,7 @@ next:
bio_page = fio->encrypted_page ? fio->encrypted
Bool initializations should use true and false. Bool tests don't need
comparisons.
Found by coccinelle spatch "misc/boolinit.cocci"
Run against version v4.14-rc1
P.S. If you find this email unwanted, set up a procmail rule junking on
the header:
X-Patch: Cocci
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_fs.c
--- a/security/integrity/ima/ima_fs.c
+++ b/security/integrity/ima/ima_fs.c
@@ -32,7 +32,7 @@
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/block/bfq-iosched.c b/block/bfq-iosched.c
--- a/block/bfq-iosched.c
+++ b/block/bfq-iosched.c
@@ -4986,7 +4986,7 @@ static ssize_t bfq_low_latency_stor
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -1490,14 +1490,14 @@ xfs_bmap_isaeof(
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/ext4/extents.c b/fs/ext4/extents.c
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5242,7 +5242,7 @@ ext4_ext_shift_path_extents(struct ext4_
{
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
--- a/security/selinux/ss/mls.c
+++ b/security/selinux/ss/mls.c
@@ -550,7 +550,7 @@ int mls_compute_sid(s
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c
--- a/fs/cifs/cifsacl.c
+++ b/fs/cifs/cifsacl.c
@@ -370,7 +370,7 @@ sid_to_id(struct cifs_sb_info *cifs_sb,
Bool initializations should use true and false. Bool tests don't need
comparisons.
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/afs/cache.c b/fs/afs/cache.c
--- a/fs/afs/cache.c
+++ b/fs/afs/cache.c
@@ -195,7 +195,7 @@ enum fscache_checkaux afs_vlocation_cach
* VL record fro
On Thu, Oct 05, 2017 at 01:43:31PM +1100, Michael Ellerman wrote:
> Thomas Meyer writes:
> > On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrote:
> ...
> >>
> >> I've switched it to using one of the toolchains from Free Electrons,
> >> whi
Hi,
here are the results from running the kselftests under UML, created with the
script
available here:
https://github.com/thomasmey/uml/blob/master/uml-fedora-kselftest.sh
1.) code coverage
http://m3y3r.de/kselftest/4.14.0-rc3-00019-g78d8732cf2d8/coverage/index.html
2.) cyclomatic complexity
h
On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrote:
> Geert Uytterhoeven writes:
>
> > Hi Thomas,
> >
> > On Mon, Oct 2, 2017 at 4:11 PM, Thomas Meyer wrote:
> >> On Mon, Oct 02, 2017 at 11:49:33AM +0200, Geert Uytterhoeven wrote:
> >>
On Mon, Oct 02, 2017 at 11:49:33AM +0200, Geert Uytterhoeven wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.14-rc3[1] compared to v4.13[2].
Hi,
a question regarding the um-defconfig build:
http://kisskb.ellerman.id.au/kisskb/target/2974/
The error thrown looks
Fix it by forcing the user to choose one of the two GCOV options.
Signed-off-by: Thomas Meyer
---
kernel/gcov/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig
index 1276aabaab55..6c0dd2a6d4fd 100644
--- a/kernel/gcov/Kconfig
+++ b/kernel/gcov
Hi,
while trying to resurrect my old Macbook as an 32 bit kernel testing device,
I think someone broke the radeon driver on this first generation pure EFI boot
Macbook.
My guess would be that the introduction of the vga_switcheroo code did break the
radeon_get_bios functionality.
I will try agai
Remove casting the values returned by memory allocation functions like
kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c
--- a/f
Remove casting the values returned by memory allocation functions like
kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_proce
Remove casting the values returned by memory allocation functions like
kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of
patch
Remove casting the values returned by memory allocation functions like
kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
--- a/fs
Remove casting the values returned by memory allocation functions like
kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc."
Found by coccinelle spatch "api/alloc/alloc_cast.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
--- a/d
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of
patches.
I can exclude you by path; e.g. all findings in "drivers/scsi" will
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
--- a/drivers/i2c/busses/i2c-sprd.c
+++ b/drivers/i2c/busses/
Make sure (of/i2c/platform)_device_id tables are NULL terminated.
Found by coccinelle spatch "misc/of_table.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/arm/mach-mediatek/platsmp.c b/arch/arm/mach-mediatek/platsmp.c
--- a/arch/arm/mach-mediatek/platsmp.c
+++ b/arch/arm/mac
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/net/ethernet/intel/e100.c
b/drivers/net/ethernet/intel/e100.c
--- a/drivers/net/ethernet/intel/e1
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c
--- a/drivers/scsi/qla4xxx/ql4_mbx.c
+++
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of
patches.
I can exclude you by path; e.g. all findings in "
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/mailbox/bcm-flexrm-mailbox.c
b/drivers/mailbox/bcm-flexrm-mailbox.c
--- a/drivers/mailbox/
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/dr
This removes an open coded simple_open() function and replaces file operations
references to the function with simple_open() instead.
Found by coccinelle spatch "api/simple_open.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of
patches
This removes an open coded simple_open() function and replaces file operations
references to the function with simple_open() instead.
Found by coccinelle spatch "api/simple_open.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/fnic/fnic_debugfs.c b/drivers
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c
--- a/arch/arm64/mm/dma-mapping.c
+++ b/arch/arm64/mm/dma
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Run against version v4.14-rc1
Let me know when you as a maintainer are not interested in these kind of
patches.
I can exclude you by path; e.g. all findings in "drivers/scsi" w
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/metag/kernel/dma.c b/arch/metag/kernel/dma.c
--- a/arch/metag/kernel/dma.c
+++ b/arch/metag/kernel/dma.c
@@ -34
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c
--- a/arch/microblaze/kernel/dma.c
+++ b/arch/microblaze/ke
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/mips/mm/dma-default.c b/arch/mips/mm/dma-default.c
--- a/arch/mips/mm/dma-default.c
+++ b/arch/mips/mm/dma-default.c
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
--- a/drivers/gpu/dr
Use vma_pages function on vma object instead of explicit computation.
Found by coccinelle spatch "api/vma_pages.cocci"
Signed-off-by: Thomas Meyer
---
diff -u -p a/arch/powerpc/kvm/e500_mmu_host.c b/arch/powerpc/kvm/e500_mmu_host.c
--- a/arch/powerpc/kvm/e500_mmu_host.c
+++ b/arch/p
True, as CONFIG_GCOV and CONFIG_GCOV_KERNEL should be mutually exclusive CONFIG
options.
With kind regards
Thomas
> Am 17.09.2017 um 20:52 schrieb kbuild test robot :
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 0666f560b71b899cd11a7caf39fd4
> Am 16.09.2017 um 15:20 schrieb Jon Maloy .
>>
>> What part of "very time critical" have you verified and benchmarked as
>> inconsequential?
>>
>> Please post your results.
>
> I agree with Joe here. This change does not simplify anything, it does not
> reduce the amount of code, plus that it
Use bsearch library function instead of duplicated functionality.
Signed-off-by: Thomas Meyer
---
drivers/tty/vt/vt.c | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index 2ebaba16f785..ca55004a639e
Use common library function rather than explicitly coding
some variant of it yourself.
Signed-off-by: Thomas Meyer
---
net/tipc/name_table.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
V2: Coding style
diff --git a/net/tipc/name_table.c b/net/tipc
Hi,
Overall coverage rate:
lines..: 34.6% (90861 of 262609 lines)
functions..: 40.4% (9978 of 24683 functions)
Coverage is available here:
http://m3y3r.de/kselftest/4.13.0-11224-gcb1606851304/coverage/index.html
My script also outputs those results files:
1.) Cyclomatic complexity
http:
This avoids the error:
drivers/reset/reset-hsdk-v1.o: In function `hsdkv1_reset_probe':
/home/thomas/git/linux/drivers/reset/reset-hsdk-v1.c:101: undefined
reference to `devm_ioremap_resource'
collect2: error: ld returned 1 exit status
Signed-off-by: Thomas Meyer
---
drivers/reset/K
Use common library function rather than explicitly coding
some variant of it yourself.
Signed-off-by: Thomas Meyer
---
net/tipc/name_table.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
index
Replace self coded binary search, by existing library version.
Signed-off-by: Thomas Meyer
---
drivers/media/rc/rc-main.c | 34 --
1 file changed, 20 insertions(+), 14 deletions(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c
index
Explicitly define SO_EE_ORIGIN_ZEROCOPY.
This makes the test program build with older kernel headers,
e.g. from Debian 9.
Signed-off-by: Thomas Meyer
---
tools/testing/selftests/net/msg_zerocopy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net
: line 35: gcc: command not found
Problem compiling aperf.c.
Signed-off-by: Thomas Meyer
---
tools/testing/selftests/intel_pstate/run.sh | 6 --
1 file changed, 6 deletions(-)
diff --git a/tools/testing/selftests/intel_pstate/run.sh
b/tools/testing/selftests/intel_pstate/run.sh
index
The multiple_kprobes test case fails to check for KPROBE_EVENT support.
Add the check to prevent a false test result.
Signed-off-by: Thomas Meyer
---
tools/testing/selftests/ftrace/test.d/kprobe/multiple_kprobes.tc | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests
The current implementation fails to work on uniprocessor systems.
Fix the parser to also handle the uniprocessor case.
Signed-off-by: Thomas Meyer
---
tools/testing/selftests/bpf/bpf_util.h | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/tools/testing
On Fri, Sep 08, 2017 at 11:41:21AM +0300, Fathi Boudra wrote:
> Shuah, should I resend?
Hi,
I also did send some patches to his kernel.org address after lazy searching
for "Shuah" in my inbox. But maybe his other email address is the correct one.
with kind regards
thomas
User mode linux kernel has no huge pages. So this variable will be null.
Guard all tests in the shell script with a null check.
Signed-off-by: Thomas Meyer
---
tools/testing/selftests/memfd/run_tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests
The current shell script misses the execute flag.
Signed-off-by: Thomas Meyer
---
tools/testing/selftests/memfd/run_tests.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/memfd/run_tests.sh
diff --git a/tools/testing/selftests/me
On Tue, Sep 05, 2017 at 02:22:05PM -0700, David Miller wrote:
> From: Joe Perches
> Date: Tue, 05 Sep 2017 13:01:18 -0700
>
> > On Tue, 2017-09-05 at 21:45 +0200, Thomas Meyer wrote:
> >> On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote:
> >> >
On Tue, Sep 05, 2017 at 11:50:44AM -0700, David Miller wrote:
> From: Thomas Meyer
> Date: Sun, 03 Sep 2017 14:19:31 +0200
>
> > Use ARRAY_SIZE macro, rather than explicitly coding some variant of it
> > yourself.
> > Found with: find -type f -name "*.c"
1 - 100 of 358 matches
Mail list logo