Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

> It looks like your patch runs into dead locks problems: > > I have a cron job reading my sensors. If I read the sensors on another > thread (e.g. via cat), the 2nd thread can produce a dead lock: > > * thread 1 has bus & sl lock > * thread 1 drops bus lock, keeps sl locks and sleeps > * thread 2

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

> Oops, sorry, it got lost in the shuffle, here's the first patch again > (the others were for debugging and increase that time and so wouldn't > go upstream anyway). I assumed so. It looks like your patch runs into dead locks problems: I have a cron job reading my sensors. If I read the

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

> Here's a different strategy, add a w1_therm family_data specific mutex > so w1_therm_remove_slave won't return while another thread is in > w1_slave_show. Thoughts? > > I included three patches, the first is the proposed fix, the second > makes it more reproducible (and since my testing doesn't

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

It looks like your patch runs into dead locks problems: I have a cron job reading my sensors. If I read the sensors on another thread (e.g. via cat), the 2nd thread can produce a dead lock: * thread 1 has bus sl lock * thread 1 drops bus lock, keeps sl locks and sleeps * thread 2 get bus

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Here's a different strategy, add a w1_therm family_data specific mutex so w1_therm_remove_slave won't return while another thread is in w1_slave_show. Thoughts? I included three patches, the first is the proposed fix, the second makes it more reproducible (and since my testing doesn't have

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Oops, sorry, it got lost in the shuffle, here's the first patch again (the others were for debugging and increase that time and so wouldn't go upstream anyway). I assumed so. It looks like your patch runs into dead locks problems: I have a cron job reading my sensors. If I read the sensors

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi David, thanks for your feedback on my first patch, I wasn't aware of checkpatch.pl. Initially, I had just if-ed the usage of family-data, which did not look that nice. I was referring to this proof-of-concept workaround in my initial bug report. The patch I've submitted is different from my

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

Hi David, thanks for your feedback on my first patch, I wasn't aware of checkpatch.pl. Initially, I had just if-ed the usage of family-data, which did not look that nice. I was referring to this proof-of-concept workaround in my initial bug report. The patch I've submitted is different from my

Re: Fwd: w1/slaves/w1_therm: null-ptr access of sl->family_data

t will be useful > to you as well, though the bigger problem might be why they are > vanishing in the first place. > > On Mon, Feb 23, 2015 at 06:09:16PM +0100, Thorsten Bschorr wrote: >> Hi, >> >> I have observed a null-pointer access in w1/slaves/w1_therm on my Raspberry &

Re: Fwd: w1/slaves/w1_therm: null-ptr access of sl-family_data

, though the bigger problem might be why they are vanishing in the first place. On Mon, Feb 23, 2015 at 06:09:16PM +0100, Thorsten Bschorr wrote: Hi, I have observed a null-pointer access in w1/slaves/w1_therm on my Raspberry Pi running 3.18.5 with several DS18S20 temperature sensors. I have

Fwd: w1/slaves/w1_therm: null-ptr access of sl->family_data

eems that the sensor does not respond in time to the (periodic) search. Please email me if you need further information. Best regards, Thorsten Bschorr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Fwd: w1/slaves/w1_therm: null-ptr access of sl-family_data

not respond in time to the (periodic) search. Please email me if you need further information. Best regards, Thorsten Bschorr -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org