Re: [PATCH 2/3] arm64: dts: mt8173: Separating mtk-vcodec-enc device node

2021-01-26 Thread Tiffany Lin
Wang > Acked-by: Tiffany Lin > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 60 > 1 file changed, 31 insertions(+), 29 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > b/arch/arm64/boot/dts/mediatek/mt8173.dtsi &g

Re: [PATCH 1/3] dt-bindings: media: mtk-vcodec: Separating mtk vcodec encoder node

2021-01-26 Thread Tiffany Lin
quot;. > > Signed-off-by: Hsin-Yi Wang > Signed-off-by: Maoguang Meng > Signed-off-by: Irui Wang > Acked-by: Tiffany Lin > --- > .../bindings/media/mediatek-vcodec.txt| 58 ++- > 1 file changed, 31 insertions(+), 27 deletions(-) > > dif

Re: [PATCH 3/3] media: mtk-vcodec: Separating mtk encoder driver

2021-01-26 Thread Tiffany Lin
rs: > User Call "VIDIOC_QUERYCAP": > H264 Encoder return driver name "mtk-vcodec-enc"; > VP8 Encoder return driver name "mtk-venc-vp8. > > Signed-off-by: Hsin-Yi Wang > Signed-off-by: Maoguang Meng > Signed-off-by: Irui Wang > Acked-by: Tiffany Li

Re: [PATCH v4 17/17] media: mtk-vcodec: venc: fix invalid time per frame in S_PARM

2020-08-24 Thread Tiffany Lin
On Fri, 2020-08-21 at 19:36 +0900, Alexandre Courbot wrote: > v4l2-compliance expects the driver to adjust the time per frame if it is > invalid (numerator or denominator set to 0). Adjust it to the default > value in these cases. > Acked-by: Tiffany Lin > Signed-off-by: Al

Re: [PATCH v4 16/17] media: mtk-vcodec: venc: set default time per frame

2020-08-24 Thread Tiffany Lin
On Fri, 2020-08-21 at 19:36 +0900, Alexandre Courbot wrote: > The time per frame was left initialized to 0/0, which make the driver > fail v4l2-compliance, and also leaves it potentially exposed to doing a > division by zero. > Acked-by: Tiffany Lin > Signed-off-by: Al

Re: [PATCH v4 15/17] media: mtk-vcodec: venc: support ENUM_FRAMESIZES on OUTPUT formats

2020-08-24 Thread Tiffany Lin
On Fri, 2020-08-21 at 19:36 +0900, Alexandre Courbot wrote: > v4l2-compliance requires ENUM_FRAMESIZES to support OUTPUT formats. > Reuse mtk_venc_find_format() to make sure both queues are considered > when serving an ENUM_FRAMESIZES. > Acked-by: Tiffany Lin > Signed-off-by: Al

Re: [PATCH v4 14/17] media: mtk-vcodec: venc: use platform data for ENUM_FRAMESIZES

2020-08-24 Thread Tiffany Lin
gt; Fix this by referring to the platform data to find out whether a given > format is supported. Since the supported sizes are all the same > regardless of the format, we can then return a copy of a static value if > the format is supported. > Acked-by: Tiffany Lin > Si

Re: [PATCH v2 12/18] media: mtk-vcodec: venc: set OUTPUT buffers field to V4L2_FIELD_NONE

2020-06-30 Thread Tiffany Lin
On Fri, 2020-06-26 at 17:04 +0900, Alexandre Courbot wrote: > A default value of 0 means V4L2_FIELD_ANY, which is not correct. > Reported by v4l2-compliance. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/mtk-vcodec/mt

Re: [PATCH v2 11/18] media: mtk-vcodec: venc support MIN_OUTPUT_BUFFERS control

2020-06-30 Thread Tiffany Lin
On Fri, 2020-06-26 at 17:04 +0900, Alexandre Courbot wrote: > This control is required by v4l2-compliance for encoders. A value of 1 > should be suitable for all scenarios. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/mtk-vcode

Re: [PATCH v2 10/18] Revert "media: mtk-vcodec: Remove extra area allocation in an input buffer on encoding"

2020-06-30 Thread Tiffany Lin
nce's G_FMT and S_FMT tests regress. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/mtk-v

Re: [PATCH v2 01/18] media: mtk-vcodec: abstract firmware interface

2020-06-30 Thread Tiffany Lin
s under a layer that will > allow us to handle both firmware types transparently. > Acked-by: Tiffany Lin > Signed-off-by: Yunfei Dong > [acourbot: refactor, cleanup and split] > Co-developed-by: Alexandre Courbot > Signed-off-by: Alexandre Courbot > [pihsun: fix error pat

Re: [PATCH v2 06/18] media: mtk-vcodec: venc: specify supported formats per-chip

2020-06-30 Thread Tiffany Lin
r each queue. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 8 ++ > .../platform/mtk-vcodec/mtk_vcodec_enc.c | 122 +++--- > .../platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 40 ++ >

Re: [PATCH 02/10] media: mtk-vcodec: add SCP firmware ops

2020-06-24 Thread Tiffany Lin
On Tue, 2020-06-16 at 22:17 +0900, Alexandre Courbot wrote: > On Mon, Jun 8, 2020 at 7:47 PM Tiffany Lin wrote: > > > > On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > > > From: Yunfei Dong > > > > > > Add support for communicating with the

Re: [PATCH 07/10] media: mtk-vcodec: venc: remove redundant code

2020-06-22 Thread Tiffany Lin
On Mon, 2020-06-22 at 22:10 +0900, Alexandre Courbot wrote: > On Fri, Jun 19, 2020 at 3:59 PM Tiffany Lin wrote: > > > > On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > > > vidioc_try_fmt() does clamp height and width when called on the OUTPUT > > >

Re: [PATCH 06/10] media: mtk-vcodec: venc: specify supported formats per-chip

2020-06-22 Thread Tiffany Lin
On Mon, 2020-06-22 at 21:44 +0900, Alexandre Courbot wrote: > On Fri, Jun 19, 2020 at 4:26 PM Tiffany Lin wrote: > > > > On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > > > Different chips have different supported bitrate ranges. Move the list > >

Re: [PATCH 06/10] media: mtk-vcodec: venc: specify supported formats per-chip

2020-06-19 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > Different chips have different supported bitrate ranges. Move the list > of supported formats to the platform data, and split the output and > capture formats into two lists to make it easier to find the default > format for each queue.

Re: [PATCH 09/10] media: dt-bindings: mtk-vcodec: specify SCP node

2020-06-19 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > The mediatek codecs can use either the VPU or the SCP as their interface > to firmware. Reflect this in the DT bindings. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > Documentation/devicet

Re: [PATCH 08/10] media: mtk-vcodec: add support for MT8183 encoder

2020-06-19 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > From: Yunfei Dong > > Now that all the supporting blocks are present, enable encoder for > MT8183. > Acked-by: Tiffany Lin > Signed-off-by: Yunfei Dong > [acourbot: refactor, cleanup and split] > Co

Re: [PATCH 07/10] media: mtk-vcodec: venc: remove redundant code

2020-06-19 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > vidioc_try_fmt() does clamp height and width when called on the OUTPUT > queue, so clamping them prior to calling this function is redundant. Set > the queue's parameters after calling vidioc_try_fmt() so we can use the > values it compu

Re: [PATCH v4 01/17] media: dt-binding: mtk-vcodec: Separating mtk-vcodec encode node.

2020-06-16 Thread Tiffany Lin
On Wed, 2020-06-10 at 15:38 +0800, Tiffany Lin wrote: > On Wed, 2020-06-10 at 15:46 +0900, Alexandre Courbot wrote: > > On Wed, Jun 10, 2020 at 6:21 AM Rob Herring wrote: > > > > > > On Sat, May 30, 2020 at 04:10:02PM +0800, Yong Wu wrote: > > > > From

Re: [PATCH 05/10] media: mtk-vcodec: venc: specify bitrate range per-chip

2020-06-16 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > Different chips have different supported bitrate ranges. Move the min > and max supported bitrates to the platform data. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > drivers/media/p

Re: [PATCH 04/10] media: mtk-vcodec: venc: handle firmware version field

2020-06-16 Thread Tiffany Lin
on't support. > > For MT8173, this ABI version field is reserved and thus undefined ; thus > ignore it on this chip. There should only be one firmware version available > for it anyway. > Acked-by: Tiffany Lin > Signed-off-by: Alexandre Courbot > --- > .../platf

Re: [PATCH v4 01/17] media: dt-binding: mtk-vcodec: Separating mtk-vcodec encode node.

2020-06-10 Thread Tiffany Lin
On Wed, 2020-06-10 at 15:46 +0900, Alexandre Courbot wrote: > On Wed, Jun 10, 2020 at 6:21 AM Rob Herring wrote: > > > > On Sat, May 30, 2020 at 04:10:02PM +0800, Yong Wu wrote: > > > From: Maoguang Meng > > > > > > Update binding document since the avc and vp8 hardware encoder in > > > mt8173 ar

Re: [PATCH 03/10] media: mtk-vcodec: venc: support SCP firmware

2020-06-10 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > From: Yunfei Dong > > Support the new extended firmware used by MT8183's encoder. > Acked-by: Tiffany Lin > Signed-off-by: Yunfei Dong > [acourbot: refactor, cleanup and split] > Co-developed-by: Alexa

Re: [PATCH v4 09/17] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2020-06-09 Thread Tiffany Lin
_sync, > > the smi-larb's pm_runtime_get_sync also be called automatically. > > Acked-by: Tiffany Lin > > CC: Tiffany Lin > > Signed-off-by: Yong Wu > > Reviewed-by: Evan Green > > --- > > .../media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 19

Re: [PATCH v4 08/17] media: mtk-vcodec: separate mtk-vcodec-enc node.

2020-06-09 Thread Tiffany Lin
> > https://lkml.org/lkml/2019/9/3/316 > > > > User Call "VIDIOC_QUERYCAP": > > H264 Encoder return driver name "mtk-vcodec-enc"; > > VP8 Encoder return driver name "mtk-venc-vp8. > > Acked-by: Tiffany Lin > > Signed-off-by: Maogu

Re: [PATCH 02/10] media: mtk-vcodec: add SCP firmware ops

2020-06-08 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > From: Yunfei Dong > > Add support for communicating with the SCP firmware, which will be used > by MT8183. > > Signed-off-by: Yunfei Dong > [acourbot: refactor, cleanup and split] > Co-developed-by: Alexandre Courbot > Signed-off-by

Re: [PATCH 01/10] media: mtk-vcodec: abstract firmware interface

2020-06-08 Thread Tiffany Lin
On Mon, 2020-06-08 at 18:16 +0800, Tiffany Lin wrote: > On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > > From: Yunfei Dong > > > > MT8183's codec firwmare is run by a different remote processor from > > MT8173. While the firmware interface i

Re: [PATCH 01/10] media: mtk-vcodec: abstract firmware interface

2020-06-08 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > From: Yunfei Dong > > MT8183's codec firwmare is run by a different remote processor from > MT8173. While the firmware interface is basically the same, the way to > invoke it differs. Abstract all firmware calls under a layer that will

Re: [PATCH 01/10] media: mtk-vcodec: abstract firmware interface

2020-06-08 Thread Tiffany Lin
On Wed, 2020-05-20 at 17:27 +0900, Alexandre Courbot wrote: > From: Yunfei Dong > > MT8183's codec firwmare is run by a different remote processor from > MT8173. While the firmware interface is basically the same, the way to > invoke it differs. Abstract all firmware calls under a layer that will

Re: [PATCH v2] [media] mtk-vcodec: Show mtk driver error without DEBUG definition

2017-06-19 Thread Tiffany Lin
On Tue, 2017-05-30 at 18:53 +0900, Hirokazu Honda wrote: > A driver error message is shown without DEBUG definition > to find an error and debug easily. > > Signed-off-by: Hirokazu Honda Acked-by: Tiffany Lin > --- > drivers/media/platform/mtk-vcodec/mtk_

Re: [PATCH] media: mtk-vcodec: remove informative log

2017-04-21 Thread Tiffany Lin
On Wed, 2017-04-19 at 07:56 -0300, Mauro Carvalho Chehab wrote: > Em Wed, 5 Apr 2017 19:09:59 +0800 > Tiffany Lin escreveu: > > > On Wed, 2017-04-05 at 18:54 +0800, Minghsiu Tsai wrote: > > > Driver is stable. Remove DEBUG definition from driver. > > > > >

Re: [PATCH] media: mtk-vcodec: remove informative log

2017-04-05 Thread Tiffany Lin
On Wed, 2017-04-05 at 18:54 +0800, Minghsiu Tsai wrote: > Driver is stable. Remove DEBUG definition from driver. > > There are debug message in /var/log/messages if DEBUG is defined, > such as: > [MTK_V4L2] level=0 fops_vcodec_open(),170: decoder capability 0 > [MTK_V4L2] level=0 fops_vcodec_open(

Re: [PATCH v3 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-07 Thread Tiffany Lin
On Wed, 2017-03-08 at 11:40 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > Acked-by: Tiffany Lin > Signed-off-by: Wu-Cheng Li &

Re: [PATCH v2 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-07 Thread Tiffany Lin
On Tue, 2017-03-07 at 22:42 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > > Signed-off-by: Wu-Cheng Li > --- > drivers/media/platform/mtk-vcodec/mtk_v

Re: [PATCH 1/1] mtk-vcodec: check the vp9 decoder buffer index from VPU.

2017-03-07 Thread Tiffany Lin
On Tue, 2017-03-07 at 14:03 +0800, Wu-Cheng Li wrote: > From: Wu-Cheng Li > > VPU firmware has a bug and may return invalid buffer index for > some vp9 videos. Check the buffer indexes before accessing the > buffer. > > Signed-off-by: Wu-Cheng Li > --- > drivers/media/platform/mtk-vcodec/mtk_v

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

2016-10-24 Thread Tiffany Lin
Hi Mauro, On Mon, 2016-10-24 at 07:05 -0200, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 11:22:08 +0800 > Tiffany Lin escreveu: > > > Hi Mauro, > > > > On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > > > Em Fri, 2 Sep 2016 20:19:

Re: FW: [PATCH] mtk-vcodec: fix some smatch warnings

2016-10-23 Thread Tiffany Lin
dev; >^~~ > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Tiffany Lin > --- > drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 2 -- > drivers/media/platform/mtk-vcodec/vdec_drv_if.c | 1 + > 2 files changed, 1 insertion(+), 2 deletions

Re: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

2016-10-23 Thread Tiffany Lin
Hi Mauro, On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote: > Em Fri, 2 Sep 2016 20:19:54 +0800 > Tiffany Lin escreveu: > > > Add v4l2 layer decoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin > > > +int vdec_if_init(struct mtk_

Re: [PATCH v2 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

2016-09-18 Thread Tiffany Lin
Hi Hans, On Wed, 2016-09-14 at 13:51 +0200, Hans Verkuil wrote: > Hi Tiffany, > > On 09/09/2016 05:48 PM, Tiffany Lin wrote: > > Add V4L2_PIX_FMT_MT21C documentation > > > > Signed-off-by: Tiffany Lin > > --- > > Documentation/media/uapi/v4l/pixfmt-res

Re: [PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

2016-09-13 Thread Tiffany Lin
Hi Hans, On Thu, 2016-09-08 at 11:27 +0200, Hans Verkuil wrote: > On 09/08/16 11:11, Tiffany Lin wrote: > > Hi Hans, > > > > On Thu, 2016-09-08 at 09:21 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> On 09/07/2016 08:56 AM, Tiffany Lin wrote:

[PATCH v2 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

2016-09-09 Thread Tiffany Lin
Add V4L2_PIX_FMT_MT21C documentation Signed-off-by: Tiffany Lin --- Documentation/media/uapi/v4l/pixfmt-reserved.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst index

[PATCH v2 3/4] vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder

2016-09-09 Thread Tiffany Lin
Add V4L2_PIX_FMT_MT21C support Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c

[PATCH v2 4/4] arm64: dts: mediatek: Add Video Decoder for MT8173

2016-09-09 Thread Tiffany Lin
Add video decoder node for MT8173 Signed-off-by: Tiffany Lin --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 10f638f

[PATCH v2 1/4] v4l: add Mediatek compressed video block format

2016-09-09 Thread Tiffany Lin
Add V4L2_PIX_FMT_MT21C format used on MT8173 driver. It is compressed format and need MT8173 MDP driver to transfer to other standard format. Signed-off-by: Tiffany Lin --- drivers/media/v4l2-core/v4l2-ioctl.c |1 + include/uapi/linux/videodev2.h |1 + 2 files changed, 2

[PATCH v2 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

2016-09-09 Thread Tiffany Lin
2M/NV21M/YUV420M/YVU420M -> Encoder -> H264/VP8 When playback, the pipeline will be: H264/VP8/VP9 -> Decoder driver -> MT21C -> MDP Driver -> DRM [1]https://patchwork.kernel.org/patch/9305329/ --- v2: add more information for MT21C in docs-rst --- Tiffany Lin (4): v4l: add Mediate

Re: [PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

2016-09-08 Thread Tiffany Lin
Hi Hans, On Thu, 2016-09-08 at 09:21 +0200, Hans Verkuil wrote: > Hi Tiffany, > > On 09/07/2016 08:56 AM, Tiffany Lin wrote: > > This patch series add Mediatek compressed block format V4L2_PIX_FMT_MT21C, > > the > > decoder driver will decoded bitstream t

Re: [PATCH 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

2016-09-07 Thread Tiffany Lin
Hi Hans, On Wed, 2016-09-07 at 11:23 +0200, Hans Verkuil wrote: > On 09/07/16 08:56, Tiffany Lin wrote: > > Add V4L2_PIX_FMT_MT21C documentation > > > > Signed-off-by: Tiffany Lin > > --- > > Documentation/media/uapi/v4l/pixfmt-reserved.rst |6 ++

Re: [PATCH] [media] VPU: mediatek: fix null pointer dereference on pdev

2016-09-07 Thread Tiffany Lin
On Wed, 2016-09-07 at 18:10 +0100, Colin King wrote: > From: Colin Ian King > > pdev is being null checked, however, prior to that it is being > dereferenced by platform_get_drvdata. Move the assignments of > vpu and run to after the pdev null check to avoid a potential > null pointer dereferenc

[PATCH v3] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

2016-09-07 Thread Tiffany Lin
Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin Signed-off-by: Andrew-CT Chen --- v3: Move MEDIATEK MEDIA DRIVER after MEDIATEK ETHERNET DRIVER to follow alphabet sequence v2: Rename MT8173 MEDIA DRIVER to MEDIATEK MEDIA DRIVER

[PATCH 4/4] arm64: dts: mediatek: Add Video Decoder for MT8173

2016-09-06 Thread Tiffany Lin
Add video decoder node for MT8173 Signed-off-by: Tiffany Lin --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index 10f638f

[PATCH 2/4] docs-rst: Add compressed video formats used on MT8173 codec driver

2016-09-06 Thread Tiffany Lin
Add V4L2_PIX_FMT_MT21C documentation Signed-off-by: Tiffany Lin --- Documentation/media/uapi/v4l/pixfmt-reserved.rst |6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst index 0dd2f7f

[PATCH 1/4] v4l: add Mediatek compressed video block format

2016-09-06 Thread Tiffany Lin
Add V4L2_PIX_FMT_MT21C format used on MT8173 driver. It is compressed format and need MT8173 MDP driver to transfer to other standard format. Signed-off-by: Tiffany Lin --- drivers/media/v4l2-core/v4l2-ioctl.c |1 + include/uapi/linux/videodev2.h |1 + 2 files changed, 2

[PATCH 0/4] Add V4L2_PIX_FMT_MT21C format for MT8173 codec driver

2016-09-06 Thread Tiffany Lin
2M/NV21M/YUV420M/YVU420M -> Encoder -> H264/VP8 When playback, the pipeline will be: H264/VP8/VP9 -> Decoder driver -> MT21C -> MDP Driver -> DRM [1]https://patchwork.kernel.org/patch/9305329/ Tiffany Lin (4): v4l: add Mediatek compressed video block format docs-rst: Add compressed

[PATCH 3/4] vcodec: mediatek: Add V4L2_PIX_FMT_MT21C support for v4l2 decoder

2016-09-06 Thread Tiffany Lin
Add V4L2_PIX_FMT_MT21C support Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c

[PATCH v2] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

2016-09-06 Thread Tiffany Lin
Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin Signed-off-by: Andrew-CT Chen --- v2: Rename MT8173 MEDIA DRIVER to MEDIATEK MEDIA DRIVER --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS

[PATCH] vcodec: mediatek: Fix decoder compiler/sparse warnings

2016-09-06 Thread Tiffany Lin
This patch fix decoder compiler/sparse warnings Signed-off-by: Tiffany Lin --- .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c |7 --- .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c |1 + .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c |4 ++-- drivers/media/platform

Re: [PATCH] vcodec: mediatek: fix odd_ptr_err.cocci warnings

2016-09-06 Thread Tiffany Lin
On Tue, 2016-09-06 at 22:51 +0800, Julia Lawall wrote: > PTR_ERR should access the value just tested by IS_ERR > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Tiffany Lin > Signed-off-by: Julia Lawall > Signed-off-by: Fengguang Wu Re

[PATCH] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

2016-09-05 Thread Tiffany Lin
Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin Signed-off-by: Andrew-CT Chen --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0a16a82..ed830c7 100644 --- a

[PATCH] vcodec: mediatek: Add V4L2_CAP_TIMEPERFRAME capability setting

2016-09-05 Thread Tiffany Lin
This patch setting V4L2_CAP_TIMEPERFRAME capability in vidioc_venc_s/g_parm functions Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Tiffany Lin
Hi Hans, On Mon, 2016-09-05 at 13:26 +0200, Hans Verkuil wrote: > On 09/05/2016 12:52 PM, Tiffany Lin wrote: > > Hi Hans, > > > > On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > >> On 09/05/2016 11:53 AM, Hans Verkuil wrote: > >>> On 09/05/2

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Tiffany Lin
Hi Hans, On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > On 09/05/2016 11:53 AM, Hans Verkuil wrote: > > On 09/05/2016 11:50 AM, Tiffany Lin wrote: > >> Hi Hans, > >> > >> On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > >&g

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Tiffany Lin
Hi Hans, On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > On 09/02/2016 02:19 PM, Tiffany Lin wrote: > > == > > Introduction > > == > > > > The purpose of this series is to add the driver for video codec hw embedded

[PATCH v5 8/9] Add documentation for V4L2_PIX_FMT_VP9.

2016-09-02 Thread Tiffany Lin
Add documentation for V4L2_PIX_FMT_VP9. Signed-off-by: Tiffany Lin Signed-off-by: Wu-Cheng Li --- Documentation/media/uapi/v4l/pixfmt-013.rst |8 1 file changed, 8 insertions(+) diff --git a/Documentation/media/uapi/v4l/pixfmt-013.rst b/Documentation/media/uapi/v4l/pixfmt-013

[PATCH v5 2/9] dt-bindings: Add a binding for Mediatek Video Decoder

2016-09-02 Thread Tiffany Lin
Add a DT binding documentation of Video Decoder for the MT8173 SoC from Mediatek. Signed-off-by: Tiffany Lin Acked-by: Rob Herring --- .../devicetree/bindings/media/mediatek-vcodec.txt | 57 ++-- 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/Documentation

[PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

2016-09-02 Thread Tiffany Lin
Add v4l2 layer decoder driver for MT8173 Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/Makefile | 12 +- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 1433 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h | 88 ++ .../media/platform

[PATCH v5 6/9] videodev2.h: add V4L2_PIX_FMT_VP9 format.

2016-09-02 Thread Tiffany Lin
From: Wu-Cheng Li This adds VP9 video coding format, a successor to VP8. Signed-off-by: Wu-Cheng Li Signed-off-by: Tiffany Lin --- include/uapi/linux/videodev2.h |1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index

[PATCH v5 7/9] v4l2-ioctl: add VP9 format description.

2016-09-02 Thread Tiffany Lin
From: Wu-Cheng Li VP9 is a video coding format and a successor to VP8. Signed-off-by: Wu-Cheng Li Signed-off-by: Tiffany Lin --- drivers/media/v4l2-core/v4l2-ioctl.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-02 Thread Tiffany Lin
c hw clock setting 2. Refine vp9 codec driver 3. Refine v4l2 codec driver Change in v2: 1. Add documentation for V4L2_PIX_FMT_MT21 2. Remove DRM_FORMAT_MT21 2. Refine code according to review comments Andrew-CT Chen (1): VPU: mediatek: Add decode support Tiffany Lin (10): dt-bindings: Add a b

[PATCH v5 5/9] vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver

2016-09-02 Thread Tiffany Lin
Add vp8 decoder driver for MT8173 Signed-off-by: PC Chen Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/Makefile |1 + .../media/platform/mtk-vcodec/vdec/vdec_vp8_if.c | 633 drivers/media/platform/mtk-vcodec/vdec_drv_if.c|3 + 3

[PATCH v5 1/9] VPU: mediatek: Add decode support

2016-09-02 Thread Tiffany Lin
From: Andrew-CT Chen VPU driver add decode support Signed-off-by: Andrew-CT Chen Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vpu/mtk_vpu.c | 12 drivers/media/platform/mtk-vpu/mtk_vpu.h | 27 +++ 2 files changed, 39 insertions(+) diff

[PATCH v5 9/9] vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver

2016-09-02 Thread Tiffany Lin
Add vp9 decoder driver for MT8173 Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/Makefile |1 + drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 10 + .../media/platform/mtk-vcodec/vdec/vdec_vp9_if.c | 967 drivers/media/platform/mtk

[PATCH v5 4/9] vcodec: mediatek: Add Mediatek H264 Video Decoder Drive

2016-09-02 Thread Tiffany Lin
Add h264 decoder driver for MT8173 Signed-off-by: PC Chen Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/Makefile |3 +- .../media/platform/mtk-vcodec/vdec/vdec_h264_if.c | 506 drivers/media/platform/mtk-vcodec/vdec_drv_if.c|3 + 3

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

2016-08-15 Thread Tiffany Lin
Hi Hans, On Mon, 2016-08-15 at 11:07 +0200, Hans Verkuil wrote: > On 08/15/2016 11:03 AM, Tiffany Lin wrote: > > Hi Hans, > > > > I upstream v4 on 8/10, I don't know why this version is not shown in > > https://patchwork.kernel.org. > > But

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

2016-08-15 Thread Tiffany Lin
hose > needs to be updated as well due to the move to sphinx. > > Thanks! > > Hans > > On 05/30/2016 02:29 PM, Tiffany Lin wrote: > > == > > Introduction > > == > > > > The purpose of this series is to add the driver fo

Re: [PATCH] vcodec: mediatek: bug fix and code refine for mt8173 v4l2 Encoder

2016-08-14 Thread Tiffany Lin
Hi Hans, On Sun, 2016-08-14 at 13:40 +0200, Hans Verkuil wrote: > On 08/12/2016 04:35 PM, Tiffany Lin wrote: > > This patch include fixs: > > 1. Remove unused include in mtk_vcodec_drv.h > > 2. Fix visible_height larger than coded_height issue in s_fmt_out > &g

[PATCH for v4.8] vcodec:mediatek: Refine VP8 encoder driver

2016-08-14 Thread Tiffany Lin
This patch remove field and function that unused anymore Signed-off-by: Tiffany Lin --- .../media/platform/mtk-vcodec/venc/venc_vp8_if.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/venc/venc_vp8_if.c b/drivers/media

[PATCH for v4.8] vcodec:mediatek: Refine H264 encoder driver

2016-08-14 Thread Tiffany Lin
This patch : 1. remove field and function that unused anymore 2. add support V4L2_MPEG_VIDEO_H264_LEVEL_4_2 Signed-off-by: Tiffany Lin --- .../media/platform/mtk-vcodec/venc/venc_h264_if.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media

[PATCH for v4.8] vcodec:mediatek: change H264 profile default to profile high

2016-08-14 Thread Tiffany Lin
This patch change default H264 profile from V4L2_MPEG_VIDEO_H264_PROFILE_MAIN to V4L2_MPEG_VIDEO_H264_PROFILE_HIGH Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/mtk

[PATCH for v4.8] vcodec:mediatek: Add timestamp and timecode copy for V4L2 Encoder

2016-08-14 Thread Tiffany Lin
This patch add copying timestamp and timecode from src buffer to dst buffer Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 23 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec

[PATCH for v4.8] vcodec:mediatek: Fix visible_height larger than coded_height issue in s_fmt_out

2016-08-14 Thread Tiffany Lin
) So remove extend visible_height or coded_height, user space should just use sizeimage to get real buffer size needed Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/media/platform/mtk

[PATCH for v4.8] vcodec:mediatek: Fix fops_vcodec_release flow for V4L2 Encoder

2016-08-14 Thread Tiffany Lin
This patch fix that mtk_vcodec_venc_release should be called after v4l2_m2m_ctx_release Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |7 ++- .../media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c |6 +- 2 files changed, 11 insertions(+), 2

[PATCH for v4.8] vcodec:mediatek:code refine for v4l2 Encoder driver

2016-08-14 Thread Tiffany Lin
This patch remove unused header and define from haeder files Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h |1 - .../media/platform/mtk-vcodec/mtk_vcodec_intr.h|1 - 2 files changed, 2 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec

[PATCH v6] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-08-14 Thread Tiffany Lin
This patch add g/s_selection for MT8173 V4L2 Encoder. Only output queue support g/s_selection to configure crop. The top/left of active rectangle should always be (0,0) Signed-off-by: Tiffany Lin --- v6: - remove unused err variable from s_selection v5: - remove visible_height change to a

[PATCH] vcodec: mediatek: bug fix and code refine for mt8173 v4l2 Encoder

2016-08-12 Thread Tiffany Lin
MTK_INST_WORK_THREAD_ABORT_DONE 6. Add support V4L2_MPEG_VIDEO_H264_LEVEL_4_2 4. Refine venc_h264_if.c and venc_vp8_if.c Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h |1 - drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 42

[PATCH v5] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-08-12 Thread Tiffany Lin
This patch add g/s_selection for MT8173 V4L2 Encoder. Only output queue support g/s_selection to configure crop. The top/left of active rectangle should always be (0,0). Signed-off-by: Tiffany Lin --- v5: - remove visible_height change to a separate patch v4: - do not return -ERANGE and just

Re: [PATCH v4 9/9] arm64: dts: mediatek: Add Video Decoder for MT8173

2016-08-12 Thread Tiffany Lin
Hi Matthias, On Thu, 2016-08-11 at 17:44 +0200, Matthias Brugger wrote: > > On 10/08/16 16:48, Tiffany Lin wrote: > > Add video decoder node for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 44 > >

Re: [PATCH v3] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-08-04 Thread Tiffany Lin
Hi Hans, On Thu, 2016-08-04 at 15:00 +0200, Hans Verkuil wrote: > > On 08/04/2016 12:08 PM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 v4l2 encoder > > > > Signed-off-by: Tiffany Lin > > --- > > v3: > > - add v4l2_s_select

[PATCH v3] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-08-04 Thread Tiffany Lin
This patch add g/s_selection support for MT8173 v4l2 encoder Signed-off-by: Tiffany Lin --- v3: - add v4l2_s_selection to check constraint flags - remove visible_height modification in s_fmt_out --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 81 +--- 1 file changed

Re: [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

2016-08-01 Thread Tiffany Lin
Hi Hans, On Mon, 2016-08-01 at 12:39 +0200, Hans Verkuil wrote: > Hi Tiffany, > > On 08/01/2016 11:38 AM, Tiffany Lin wrote: > > Hi Hans, > > > > >>> +static int vidioc_vdec_g_selection(struct file *file, void *priv, > >>> + s

Re: [PATCH v3 5/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver

2016-08-01 Thread Tiffany Lin
Hi Hans, On Fri, 2016-07-08 at 13:06 +0200, Hans Verkuil wrote: > On 05/30/2016 02:29 PM, Tiffany Lin wrote: > > Add v4l2 layer decoder driver for MT8173 > > > > Signed-off-by: Tiffany Lin > > --- > > drivers/media/platform/mtk-vcodec/Makefile | 10 +

[PATCH v2] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-29 Thread Tiffany Lin
Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 83 ++-- 1 file changed, 78 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c index 3ed3f2d

Re: [PATCH v3 0/9] Add MT8173 Video Decoder Driver

2016-07-21 Thread tiffany lin
Hi Hans, On Fri, 2016-07-08 at 13:44 +0200, Hans Verkuil wrote: > On 07/07/2016 12:16 PM, tiffany lin wrote: > > Hi Hans, > > > > > > On Wed, 2016-07-06 at 15:19 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> I plan to review th

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-19 Thread tiffany lin
Hi Hans, On Mon, 2016-07-18 at 14:44 +0200, Hans Verkuil wrote: > On 07/18/2016 02:28 PM, tiffany lin wrote: > > Understood now. > > > > Now I am trying to figure out how to make this function right. > > Our encoder only support crop range from (0, 0) to (width, height

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-18 Thread tiffany lin
On Fri, 2016-07-15 at 19:50 +0200, Hans Verkuil wrote: > On 07/14/2016 08:27 AM, tiffany lin wrote: > > Hi Hans, > > > > > > On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > >> Hi Tiffany, > >> > >> My apologies for the delay, but he

Re: [PATCH] [media] mtk-vcodec: fix type mismatches

2016-07-14 Thread tiffany lin
On Mon, 2016-07-11 at 23:37 +0200, Arnd Bergmann wrote: > The newly added mtk-vcodec driver produces a number of warnings in an ARM > allmodconfig build, mainly since it assumes that dma_addr_t is 32-bit wide: > > mtk-vcodec/venc/venc_vp8_if.c: In function 'vp8_enc_alloc_work_buf': > mtk-vcodec/ve

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

2016-07-14 Thread tiffany lin
Hi Nicolas, On Wed, 2016-07-13 at 09:55 -0400, Nicolas Dufresne wrote: > Le mercredi 13 juillet 2016 à 10:00 +0800, tiffany lin a écrit : > > Hi Nicolas, > > > > On Tue, 2016-07-12 at 15:14 -0400, Nicolas Dufresne wrote: > > > Le mardi 12 juillet 2016 à 15:08 -

Re: [PATCH] vcodec: mediatek: Add g/s_selection support for V4L2 Encoder

2016-07-13 Thread tiffany lin
Hi Hans, On Mon, 2016-07-11 at 06:32 +0200, Hans Verkuil wrote: > Hi Tiffany, > > My apologies for the delay, but here is my review at last: > > On 05/30/2016 09:52 AM, Tiffany Lin wrote: > > This patch add g/s_selection support for MT8173 > > >

Re: [PATCH] [media] mtk-vcodec: fix type mismatches

2016-07-13 Thread tiffany lin
Hi Arnd, On Wed, 2016-07-13 at 15:08 +0200, Arnd Bergmann wrote: > On Wednesday, July 13, 2016 5:56:26 PM CEST tiffany lin wrote: > > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c > > > b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c >

Re: [PATCH] [media] mtk-vcodec: fix type mismatches

2016-07-13 Thread tiffany lin
Hi Arnd, On Mon, 2016-07-11 at 23:37 +0200, Arnd Bergmann wrote: > The newly added mtk-vcodec driver produces a number of warnings in an ARM > allmodconfig build, mainly since it assumes that dma_addr_t is 32-bit wide: > > mtk-vcodec/venc/venc_vp8_if.c: In function 'vp8_enc_alloc_work_buf': > mtk

  1   2   3   >