[PATCH linux-next V2] tty: Disable default console blanking interval

2017-03-22 Thread Tim Gardner
). Furthermore, CRT burn in concerns should no longer govern the default case. Affected users could always set consoleblank on the kernel command line. Signed-off-by: Tim Gardner Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Adam Borowski Cc: Scot Doyle --- I'm not particularly knowledgable

[PATCH linux-next] tty: Disable default console blanking interval

2017-03-22 Thread Tim Gardner
BugLink: http://bugs.launchpad.net/bugs/869017 Signed-off-by: Tim Gardner Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Adam Borowski Cc: Scot Doyle --- I'm not particularly knowledgable about console issues. Is a blaknking interval relevant in a post CRT world ? The argument in th

[PATCH v4.4-rc8 3/4] x86/microcode/intel: load_microcode: Squelch frame size warning

2016-01-07 Thread tim . gardner
From: Tim Gardner arch/x86/kernel/cpu/microcode/intel.c: In function 'load_microcode.isra.2.constprop': arch/x86/kernel/cpu/microcode/intel.c:130:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] gcc version 5.3.1 20160101 (Ubuntu 5.3.1-5ub

[PATCH v4.4-rc8 4/4] x86/microcode/intel: get_matching_model_microcode: Squelch frame size warning

2016-01-07 Thread tim . gardner
From: Tim Gardner arch/x86/kernel/cpu/microcode/intel.c: In function 'get_matching_model_microcode.isra.3.constprop': arch/x86/kernel/cpu/microcode/intel.c:348:1: warning: the frame size of 1080 bytes is larger than 1024 bytes [-Wframe-larger-than=] gcc version 5.3.1 20160101 (Ub

[PATCH v4.4-rc8 1/4] x86/microcode/intel: save_mc_for_early: Squelch frame size warning

2016-01-07 Thread tim . gardner
From: Tim Gardner arch/x86/kernel/cpu/microcode/intel.c: In function 'save_mc_for_early': arch/x86/kernel/cpu/microcode/intel.c:516:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] gcc version 5.3.1 20160101 (Ubuntu 5.3.1-5ubuntu1) Cc: Boris

[PATCH v4.4-rc8 2/4] x86/microcode/intel: save_microcode_in_initrd_intel: Squelch frame size warning

2016-01-07 Thread tim . gardner
From: Tim Gardner arch/x86/kernel/cpu/microcode/intel.c: In function 'save_microcode_in_initrd_intel': arch/x86/kernel/cpu/microcode/intel.c:705:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] gcc version 5.3.1 20160101 (Ubuntu 5.3.1-5ub

Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-11-01 Thread Tim Gardner
On 10/30/2015 02:59 PM, Johannes Thumshirn wrote: > Hi Tim, > tim.gard...@canonical.com writes: > >> From: Tim Gardner >> >> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': >> drivers/scsi/be2iscsi/be_main.c:3187:18: warning:

[PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

2015-10-30 Thread tim . gardner
From: Tim Gardner drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous': drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] WARN_ON(!length > 0); gcc version 5.2.1

Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

2015-09-09 Thread Tim Gardner
On 09/08/2015 08:13 PM, Michael Ellerman wrote: On Tue, 2015-09-08 at 17:19 -0600, Tim Gardner wrote: On 09/08/2015 04:47 PM, Paul Mackerras wrote: On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gard...@canonical.com wrote: From: Tim Gardner commit 72cd7b44bc99 ("powerpc: Uncomment and

Re: [PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

2015-09-08 Thread Tim Gardner
On 09/08/2015 04:47 PM, Paul Mackerras wrote: > On Tue, Sep 08, 2015 at 12:13:11PM -0600, tim.gard...@canonical.com wrote: >> From: Tim Gardner >> >> commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx() >> routine available") neglected to d

[PATCH] powerpc: define empty enable_kernel_vsx() when CONFIG_VSX=n

2015-09-08 Thread tim . gardner
From: Tim Gardner commit 72cd7b44bc99 ("powerpc: Uncomment and make enable_kernel_vsx() routine available") neglected to define an empty inline replacement for enable_kernel_vsx() when CONFIG_VSX=n. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Leonida

[PATCH 4.2-rc5] workqueue: Make flush_workqueue() available again to non GPL modules

2015-08-04 Thread tim . gardner
From: Tim Gardner Commit 37b1ef31a568fc02e53587620226e5f3c66454c8 ("workqueue: move flush_scheduled_work() to workqueue.h") moved the exported non GPL flush_scheduled_work() from a function to an inline wrapper. Unfortunately, it directly calls flush_workqueue() which is a GPL function

Re: [4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure

2015-07-23 Thread Tim Gardner
On 07/23/2015 04:18 AM, Michael Ellerman wrote: On Mon, 2015-20-07 at 19:01:42 UTC, Tim Gardner wrote: From: Tim Gardner drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class module_init(anslcd_init); ^ drivers/macintosh/ans-lcd.c:201:1: error: type

[PATCH 4.2-rc3] macintosh/ans-lcd.c: Missing include causes compile failure

2015-07-20 Thread tim . gardner
From: Tim Gardner drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class module_init(anslcd_init); ^ drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] gcc version

[PATCH 3.17-rc5] kconfig: Suppress warning: ‘jump’ may be used uninitialized

2014-09-16 Thread tim . gardner
From: Tim Gardner In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c: In function ‘get_symbol_str’: scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] jump->offset = strlen(r

[PATCH 3.17-rc5 ] scripts/sortextable: Suppress warning: ‘relocs_size’ may be used uninitialized

2014-09-16 Thread tim . gardner
From: Tim Gardner In file included from scripts/sortextable.c:194:0: scripts/sortextable.c: In function ‘main’: scripts/sortextable.h:176:3: warning: ‘relocs_size’ may be used uninitialized in this function [-Wmaybe-uninitialized] memset(relocs, 0, relocs_size); ^ scripts/sortextable.h

Re: [3.13.y.z extended stable] Linux 3.13.11.7 stable review

2014-09-16 Thread Tim Gardner
On 09/15/2014 07:26 PM, Greg KH wrote: > On Mon, Sep 15, 2014 at 07:18:35PM -0600, Tim Gardner wrote: >> On 09/15/2014 06:03 PM, Greg KH wrote: >>> On Mon, Sep 15, 2014 at 03:06:50PM -0700, Kamal Mostafa wrote: >>>> This is the start of the review cycle for the Linux

Re: [3.13.y.z extended stable] Linux 3.13.11.7 stable review

2014-09-15 Thread Tim Gardner
ts of people ? I'm only aware of one complaint voiced by Peter Anvin at the kernel summit (http://lwn.net/Articles/608917/). rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

Re: [PATCH] cpufreq: ppc-corenet-cpu-freq: do_div use quotient

2014-06-06 Thread Tim Gardner
locks */ > + u64temp = 12ULL * NSEC_PER_SEC; > + do_div(u64temp, fsl_get_sys_freq()); > + policy->cpuinfo.transition_latency = u64temp + 1; > > of_node_put(np); > > Whoops, what was I thinking ? You should also add "Cc: sta...@vger.kernel.org # 3.15+" since this pa

Re: Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Tim Gardner
On 05/02/2014 12:30 PM, Tim Gardner wrote: > On 05/02/2014 11:21 AM, Alex Deucher wrote: >> On Fri, May 2, 2014 at 12:40 PM, Tim Gardner >> wrote: >>> I've bisected a resume regression on a Lenovo x120e to >>> 177cf92de4aa97ec1435987e91696ed8b5023130 (d

Re: Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Tim Gardner
On 05/02/2014 11:21 AM, Alex Deucher wrote: > On Fri, May 2, 2014 at 12:40 PM, Tim Gardner > wrote: >> I've bisected a resume regression on a Lenovo x120e to >> 177cf92de4aa97ec1435987e91696ed8b5023130 (drm/crtc-helpers: fix dpms on >> logic). Everything works fin

Lenovo x120e resume regression in 3.15-rc1 bisected to 'drm/crtc-helpers: fix dpms on logic'

2014-05-02 Thread Tim Gardner
also causing this laptop to resume to a black screen wherein the platform appears to be locked up (no console, no network). See attached bisect log and lspci. The BIOS version is 1.15. rtg -- Tim Gardner tim.gard...@canonical.com # bad: [c9eaa447e77efe77b7fa4c953bd62de8297fd6c5] Linux 3.15-rc1 #

[PATCH 3.15-rc3] cpufreq: ppc-corenet-cpufreq: Fix __udivdi3 modpost error

2014-04-28 Thread Tim Gardner
sion. gcc version 4.8.2 Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: Zhuoyu Zhang Signed-off-by: Tim Gardner --- drivers/cpufreq/ppc-corenet-cpufreq.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c b/drivers/cpufreq/p

[PATCH net-next] xprtrdma: rpcrdma_register_default_external: Silence frame size warning

2014-04-18 Thread Tim Gardner
" Cc: "David S. Miller" Signed-off-by: Tim Gardner --- net/sunrpc/xprtrdma/verbs.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c index 93726560..8130349 100644 --- a/net/sunrpc/xprtrdma/ver

Re: [PATCH net-next] xprtrdma: rpcrdma_register_default_external: Silence frame size warning

2014-04-18 Thread Tim Gardner
On 04/18/2014 01:52 PM, Trond Myklebust wrote: On Fri, Apr 18, 2014 at 3:50 PM, Tim Gardner mailto:tim.gard...@canonical.com>> wrote: net/sunrpc/xprtrdma/verbs.c: In function 'rpcrdma_register_default_external': net/sunrpc/xprtrdma/verbs.c:1774:1: warning: the fr

[PATCH v2 linux-next] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

2014-04-16 Thread Tim Gardner
c: Takashi Iwai Cc: Mark Brown Cc: Lars-Peter Clausen Cc: JongHo Kim Signed-off-by: Tim Gardner --- v2: Changed string preface from "OVER RUN" to "XRUN". As Takashi pointed out, 'Use a term "XRUN", as it's not always an overrun.' sound/core/pcm_l

[PATCH] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

2014-04-10 Thread Tim Gardner
c: Takashi Iwai Cc: Mark Brown Cc: Lars-Peter Clausen Cc: JongHo Kim Signed-off-by: Tim Gardner --- sound/core/pcm_lib.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index ce83def..2a0563d 100644 --- a/sound/core/pcm_lib.c +

[PATCH linux-next] ALSA: usb-audio: Suppress repetitive debug messages from retire_playback_urb()

2014-04-09 Thread Tim Gardner
ed to printk_ratelimit + if (printk_ratelimit() && Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Eldad Zack Cc: Daniel Mack Cc: Clemens Ladisch Signed-off-by: Tim Gardner --- sound/usb/pcm.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/usb/pcm.c b/sound/us

linux-next: ahci_platform broken build

2014-03-16 Thread Tim Gardner
dule_drivers/ata] Error 2 The compile problem is then fixed in 96a01ba52c60fdd74dd6e8cf06645d06515b1396 (ahci-platform: Add enable_ / disable_resources helper functions) which is not really kosher. It seems like you ought to fix this before the 3.15 merge window opens. rtg -- Tim

[PATCH 2/4 linux-next V3] cifs: rename set_path_size and set_file_size

2013-12-09 Thread Tim Gardner
These 2 method names are a bit confusing. Rename them so that one can tell at a glance how they are to be used. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V3 - no change V2 - this is a new patch in the V2 series. fs/cifs/cifsglob.h |4 ++-- fs

[PATCH 3/4 linux-next V3] cifs: Introduce cifs_legacy_set_file_size()

2013-12-09 Thread Tim Gardner
Consolidates some duplicate code. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V3 - no change V2 - this is a new patch in the V2 series. fs/cifs/inode.c | 54 +- 1 file changed, 33 insertions(+), 21

[PATCH 1/4 linux-next V3] cifs: Replace CIFSSMBSetEOF() with smb_set_file_size()

2013-12-09 Thread Tim Gardner
French Cc: Jeff Layton Signed-off-by: Dean Gehnert Signed-off-by: Tim Gardner --- V3 - same as V2 V2 - There really is no substantive change from V1. Rather, this patch is now the first in a series that acheives the review comments set out by Jeff Layton for the V1 patch

[PATCH 4/4 linux-next V3] cifs: Combine set_file_size by handle and path into one function

2013-12-09 Thread Tim Gardner
throughout. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V3 - dropped 'cifs: fix incorrect reference count check' which impacted this patch. Also moved cifsFileInfo_put(open_file) according to V2 review comments from Jeff Layton. V2 - this is a

Re: [PATCH 4/5 linux-next V2] cifs: fix incorrect reference count check

2013-12-09 Thread Tim Gardner
On 12/09/2013 04:03 AM, Jeff Layton wrote: > On Sun, 8 Dec 2013 14:08:43 -0700 > Tim Gardner wrote: > >> The reference count on tlink can only be decremented if >> cifs_sb_tlink(cifs_sb) was used to acquire it. That only >> happens if open_file==NULL. >> >&g

[PATCH 5/5 linux-next V2 (resend)] cifs: Combine set_file_size by handle and path into one function

2013-12-08 Thread Tim Gardner
smb_set_file_size() more or less intact. SMBv2 and higher are more regular and orthogonal, so the v2 handler smb2_set_file_size() no longer contains the legacy hacks. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V2 - this is a new patch in the V2 series

[PATCH 3/5 linux-next V2] cifs: Introduce cifs_legacy_set_file_size()

2013-12-08 Thread Tim Gardner
Consolidates some duplicate code. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V2 - this is a new patch in the V2 series. fs/cifs/inode.c | 54 +- 1 file changed, 33 insertions(+), 21 deletions

[PATCH 5/5 linux-next V2] cifs: Combine set_file_size by handle and path into one function

2013-12-08 Thread Tim Gardner
smb_set_file_size() more or less intact. SMBv2 and higher are more regular and orthogonal, so the v2 handler smb2_set_file_size() no longer contains the legacy hacks. Signed-off-by: Tim Gardner --- V2 - this is a new patch in the V2 series. I know this is kind of a giant patch, but th

[PATCH 4/5 linux-next V2] cifs: fix incorrect reference count check

2013-12-08 Thread Tim Gardner
The reference count on tlink can only be decremented if cifs_sb_tlink(cifs_sb) was used to acquire it. That only happens if open_file==NULL. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V2 - this is a new patch in the V2 series. fs/cifs/inode.c |2

[PATCH 1/5 linux-next V2] cifs: Replace CIFSSMBSetEOF() with smb_set_file_size()

2013-12-08 Thread Tim Gardner
French Cc: Jeff Layton Signed-off-by: Dean Gehnert Signed-off-by: Tim Gardner --- V2 - There really is no substantive change from V1. Rather, this patch is now the first in a series that acheives the review comments set out by Jeff Layton for the V1 patch

[PATCH 2/5 linux-next V2] cifs: rename set_path_size and set_file_size

2013-12-08 Thread Tim Gardner
These 2 method names are a bit confusing. Rename them so that one can tell at a glance how they are to be used. Cc: Steve French Cc: Jeff Layton Cc: Dean Gehnert Signed-off-by: Tim Gardner --- V2 - this is a new patch in the V2 series. fs/cifs/cifsglob.h |4 ++-- fs/cifs/inode.c

[PATCH linux-next] cifs: Replace CIFSSMBSetEOF() with smb_set_file_size()

2013-11-26 Thread Tim Gardner
nc_mid_result: cmd=4 mid=22 state=4 Cc: Jeff Layton Cc: Steve French Signed-off-by: Dean Gehnert Signed-off-by: Tim Gardner --- We encountered this problem whilst backporting the CIFS driver to a kernel and VFS old enough to still call inode_operations.setattr() when truncating a file. We're n

Re: [PATCH linux-next] SELinux: security_load_policy: Silence frame-larger-than warning

2013-11-19 Thread Tim Gardner
On 11/19/2013 02:38 PM, Paul Moore wrote: > On Thursday, November 14, 2013 03:04:51 PM Tim Gardner wrote: >> Dynamically allocate a couple of the larger stack variables in order to >> reduce the stack footprint below 1024. gcc-4.8 >> >> security/selinux

Re: [PATCH 3.13-rc1] xen-blkfront: Silence pfn maybe-uninitialized warning

2013-11-14 Thread Tim Gardner
On 11/14/2013 02:24 PM, Konrad Rzeszutek Wilk wrote: > Tim Gardner wrote: >> pfn cannot actually be used unless (!info->feature_persistent), nor >> is pfn accessed in get_grant() unless (!info->feature_persistent), >> but silence this warning anyway. gcc-4.8 >>

[PATCH linux-next] SELinux: security_load_policy: Silence frame-larger-than warning

2013-11-14 Thread Tim Gardner
ewpolicydb, sizeof policydb); Cc: Stephen Smalley Cc: James Morris Cc: Eric Paris Signed-off-by: Tim Gardner --- security/selinux/ss/services.c | 54 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/security/selinux/ss/services.c b/security/sel

[PATCH 3.13-rc1] xen-blkfront: Silence pfn maybe-uninitialized warning

2013-11-14 Thread Tim Gardner
k Cc: Boris Ostrovsky Cc: David Vrabel Signed-off-by: Tim Gardner --- drivers/block/xen-blkfront.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 432db1b..5f926de 100644 --- a/drivers/block/xen-blkfront.c +++

Re: [PATCH linux-next] cifs: Use data structures to compute NTLMv2 response offsets

2013-11-12 Thread Tim Gardner
ount parameters used were '-o noserverino,nounix,user=test,pass=test'. For example, sudo mount -t cifs //10.0.0.182/test /tmp/mnt -o noserverino,nounix,user=test,pass=test,sec=ntlmssp The patched kernel produced identical results. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubsc

[PATCH linux-next] cifs: Use data structures to compute NTLMv2 response offsets

2013-11-07 Thread Tim Gardner
A bit of cleanup plus some gratuitous variable renaming. I think using structures instead of numeric offsets makes this code much more understandable. Also added a comment about current time range expected by the server. Cc: Jeff Layton Cc: Steve French Signed-off-by: Tim Gardner --- The

Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-11-01 Thread Tim Gardner
alled) > > e.g. > > make C=1 M=fs/cifs modules CF=-D__CHECK_ENDIAN__ > Didn't know about __CHECK_ENDIAN__, but will do so in the future. Your changes look fine. rtg -- Tim Gardner t...@tpi.com www.tpi.com OR 503-601-0234 x102 MT 406-443-5357 -- To unsubscribe from this lis

[PATCH 3.12-rc7] KVM: Fix modprobe failure for kvm_intel/kvm_amd

2013-10-29 Thread Tim Gardner
NFIG_KVM=m CONFIG_KVM_INTEL=m CONFIG_KVM_AMD=m # CONFIG_KVM_MMU_AUDIT is not set CONFIG_KVM_DEVICE_ASSIGNMENT=y Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Gleb Natapov Cc: Raghavendra K T Cc: Marcelo Tosatti Signed-off-by: Tim Gardner --- There is likel

[PATCH linux-next] cifs: Cleanup and clarify CalcNTLMv2_response()

2013-10-18 Thread Tim Gardner
Use of a structure aids in the understanding of this seemingly simple bit of code. The addition of a couple of comments also helps. Cc: Jeff Layton Cc: Steve French Signed-off-by: Tim Gardner --- I'd just like to be sure that the destructive copy is really what was intended. I can't

Re: [PATCH 2/2 linux-next] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-16 Thread Tim Gardner
On 10/16/2013 09:25 AM, Shirish Pargaonkar wrote: > On Wed, Oct 16, 2013 at 10:09 AM, Tim Gardner wrote: >> The multiplex identifier (MID) in the SMB header is only >> ever used by the client, in conjunction with PID, to match responses >> from the server. As such, the endian

[PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-16 Thread Tim Gardner
that use the full 64 bit multiplex identifier. Introduce the helpers get_mid() and compare_mid() to make the endian translation clear. Cc: Jeff Layton Cc: Steve French Signed-off-by: Tim Gardner --- V2 - get an endian appropriate copy of 'mid' for debug output in checkSMB(). Ac

Re: [PATCH 2/2 linux-next] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-16 Thread Tim Gardner
On 10/16/2013 08:40 AM, Jeff Layton wrote: > On Wed, 16 Oct 2013 09:09:50 -0600 > Tim Gardner wrote: > >> The multiplex identifier (MID) in the SMB header is only >> ever used by the client, in conjunction with PID, to match responses >> from the server. As such, the

[PATCH 2/2 linux-next] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-16 Thread Tim Gardner
that use the full 64 bit multiplex identifier. Introduce the helpers get_mid() and compare_mid() to make the endian translation clear. Cc: Steve French Signed-off-by: Tim Gardner --- I'm looking at some of this code in excrutiating detail because I'm having trouble with a backport of

[PATCH 1/2 linux-next] cifs: Remove redundant multiplex identifier check from check_smb_hdr()

2013-10-16 Thread Tim Gardner
The only call site for check_smb_header() assigns 'mid' from the SMB packet, which is then checked again in check_smb_header(). This seems like redundant redundancy. Cc: Steve French Signed-off-by: Tim Gardner --- fs/cifs/misc.c | 12 ++-- 1 file changed, 2 inserti

[PATCH 3.12-rc4] cifs: ntstatus_to_dos_map[] is not terminated

2013-10-13 Thread Tim Gardner
Signed-off-by: Tim Gardner --- fs/cifs/netmisc.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c index af847e1..651a527 100644 --- a/fs/cifs/netmisc.c +++ b/fs/cifs/netmisc.c @@ -780,7 +780,9 @@ static const struct { ERRDOS

Re: [PATCH] TTY: hvc_dcc: probe for a JTAG connection before registering

2013-09-23 Thread Tim Gardner
f > anything is attached and handling characters. There is no way to probe > this, so send a newline and check that it is handled. > > Cc: Paolo Pisati > Cc: Tim Gardner > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Signed-off-by: Rob Herring > --- > drivers/tty/hvc/h

Re: [PATCH 3.12-rc1] USB: input: cm109.c: Convert high volume dev_err() to dev_err_ratelimited()

2013-09-23 Thread Tim Gardner
On 09/19/2013 02:52 PM, Dmitry Torokhov wrote: > Hi Tim, > > On Tue, Sep 10, 2013 at 10:23:13AM -0600, Tim Gardner wrote: >> BugLink: http://bugs.launchpad.net/bugs/1222850 >> >> This input device can get into a state that produces a high >> volume of device s

[PATCH 3.12-rc1] USB: input: cm109.c: Convert high volume dev_err() to dev_err_ratelimited()

2013-09-10 Thread Tim Gardner
BugLink: http://bugs.launchpad.net/bugs/1222850 This input device can get into a state that produces a high volume of device status errors. Attempt to throttle these error messages such that the kernel log is not flooded. Cc: Dmitry Torokhov Signed-off-by: Tim Gardner --- drivers/input/misc

[PATCH net-next v2] net: neighbour: Remove CONFIG_ARPD

2013-08-29 Thread Tim Gardner
alico Signed-off-by: Tim Gardner --- Eric's suggestion to simply remove the config option makes sense to me. If acceptable then I'll submit a patch series that also removes CONFIG_ARPD from the various arch defconfigs. net/core/neighbour.c |2 -- net/ipv4/Kconfig | 16 --

Re: [PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Tim Gardner
On 08/28/2013 12:51 PM, Joe Perches wrote: > On Wed, 2013-08-28 at 12:24 -0600, Tim Gardner wrote: >> Drop a couple of ifdef/endif pairs by moving the ifdef >> surrounding neigh_app_ns() to the interior of neigh_app_ns(). > [] >> This is an admittedly trivial change. I stu

[PATCH net-next 1/1] net: neighbour: Simplify ifdefs around neigh_app_ns()

2013-08-28 Thread Tim Gardner
rches Signed-off-by: Tim Gardner --- This is an admittedly trivial change. I stumbled on it while trying to figure out why Ubuntu doesn't have CONFIG_ARPD enabled. net/core/neighbour.c |4 ++-- net/ipv4/arp.c |2 -- net/ipv6/ndisc.c |2 -- 3 files changed, 2 insertions

[PATCH 3.11-rc5 1/2] ALSA: pcm: Add snd_printd_ratelimit()

2013-08-16 Thread Tim Gardner
Signed-off-by: Tim Gardner --- checkpatch is moaning about the use of printk_ratelimit(), but printk_ratelimited() seems like overkill for a debug feature. WARNING: Prefer printk_ratelimited or pr__ratelimited to printk_ratelimit #38: FILE: include/sound/core.h:382: +#define snd_printd_ratelimit

[PATCH 3.11-rc5 2/2] ALSA: pcm: Use snd_printd_ratelimit()

2013-08-16 Thread Tim Gardner
Clausen Cc: Yacine Belkadi Signed-off-by: Tim Gardner --- sound/core/pcm_lib.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 82bb029..6e03b46 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -184,7

[PATCH 3.11-rc3+] radeon: si_dpm: Fix 32 bit __divdi3 modpost failure

2013-08-01 Thread Tim Gardner
ERROR: "__divdi3" [drivers/gpu/drm/radeon/radeon.ko] undefined! make[3]: *** [__modpost] Error 1 gcc version 4.8.1 Cc: David Airlie Cc: Alex Deucher Signed-off-by: Tim Gardner --- drivers/gpu/drm/radeon/si_dpm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: 3.11.0-rc1: Mellanox mlx5 fails to compile on 32-bit kernels

2013-07-17 Thread Tim Gardner
On 07/17/2013 12:50 PM, Ben Greear wrote: > Seems there is a 64-bit division in there somewhere. > > Thanks, > Ben > http://www.gossamer-threads.com/lists/linux/kernel/1746720 -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: send the line "unsu

Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-15 Thread Tim Gardner
On 07/15/2013 09:52 AM, Randy Dunlap wrote: > On 07/15/13 07:56, Tim Gardner wrote: >> Cc: Eli Cohen Signed-off-by: Tim Gardner >> > > I reported this last week and Eli wrote: > > "I have this fixed in my tree and we run the driver on i386. I will > check on

[PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-15 Thread Tim Gardner
Cc: Eli Cohen Signed-off-by: Tim Gardner --- drivers/net/ethernet/mellanox/mlx5/core/debugfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c index 4273c06..9c7194b

Re: od_set_powersave_bias: NULL pointer dereference

2013-06-25 Thread Tim Gardner
On 06/25/2013 10:19 AM, Jacob Shin wrote: > On Tue, Jun 25, 2013 at 12:26:14PM +0530, Viresh Kumar wrote: >> On 24 June 2013 22:29, Tim Gardner wrote: >>> This is from Ubuntu Saucy based on 3.10-rc7: >>> >>> [ 12.911676] BUG: unable to handl

Re: [PATCH linux-next v2] DM RAID: validate_raid_redundancy: Silence uninitialized variable warning

2013-06-13 Thread Tim Gardner
On 06/13/2013 09:30 AM, Tommi Rantala wrote: > 2013/2/21 Tim Gardner : >> drivers/md/dm-raid.c:453:53: warning: 'rebuilds_per_group' may be used >> uninitialized in this function [-Wuninitialized] >> drivers/md/dm-raid.c:383:11: note: 'rebuilds_per_group&#x

Re: [PATCH linux-next v2] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-12 Thread Tim Gardner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 03/12/2013 12:47 PM, Mark Brown wrote: > On Mon, Mar 11, 2013 at 01:18:23PM -0600, Tim Gardner wrote: >> ADAU1373_BCLKDIV_SOURCE is defined as BIT(5) which uses UL >> constants. On amd64 the result of the ones complement oper

Re: [PATCH linux-next v3] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Tim Gardner
o that are used and tested are all-phys and FRMR (the default). Dunno if I'll get time for that. I had a one day window where I could hack out some simple patches. Now I'm back to the usual grindstone. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: s

[PATCH linux-next v3] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Tim Gardner
c: Haggai Eran Cc: Or Gerlitz Cc: Shani Michaeli Cc: linux-...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Tim Gardner --- v1 - Use kmalloc() to dynamically allocate and free the array of 'struct ib_phys_buf' objects v2 - Move the array of 'struct ib_phys_buf&#x

[PATCH linux-next v2] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-11 Thread Tim Gardner
IV_SR_MASK | ADAU1373_BCLKDIV_BCLK_MASK. Cc: Lars-Peter Clausen Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: device-drivers-de...@blackfin.uclinux.org Cc: alsa-de...@alsa-project.org Signed-off-by: Tim Gardner --- v1 - simple cast solution v2 - Implement a full set of field masks as su

Re: [PATCH linux-next v2] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Tim Gardner
mit xprt->ops->send_request(task) xprt_rdma_send_request rpcrdma_marshal_req rpcrdma_create_chunks rpcrdma_register_external rpcrdma_register_default_external It appears that the context for kmalloc() should be fine unless there is a spinlock held around call_transmit() (which seems

[PATCH linux-next v2] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Tim Gardner
gcc version 4.6.3 Cc: Trond Myklebust Cc: "J. Bruce Fields" Cc: "David S. Miller" Cc: Tom Tucker Cc: Haggai Eran Cc: Or Gerlitz Cc: Shani Michaeli Cc: linux-...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Tim Gardner --- v1 - Use kmalloc() to dynamically

Re: [PATCH] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-11 Thread Tim Gardner
On 03/11/2013 04:01 AM, Lars-Peter Clausen wrote: > On 03/10/2013 06:34 PM, Tim Gardner wrote: >> ADAU1373_BCLKDIV_SOURCE is defined as BIT(5) which uses UL constants. On >> amd64 the result of the ones complement operator is then truncated to >> unsigned int accordin

Re: [PATCH linux-next] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-10 Thread Tim Gardner
to network speeds. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH linux-next] mfd: max8925: max8925_backlight_probe: Silence 'statement with no effect' warning

2013-03-10 Thread Tim Gardner
Florian Tobias Schandinat Cc: linux-fb...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/video/backlight/max8925_bl.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/max8925_bl.c b/drivers/video/backlight/max8925_bl.c index 5ca11b0..199f

[PATCH linux-next] intelfb: intelfbhw_mode_to_hw: Silence m1/m2 'may be used uninitialized' warnings

2013-03-10 Thread Tim Gardner
uninitialized in this function [-Wuninitialized] gcc version 4.6.3 Cc: Maik Broemme Cc: Florian Tobias Schandinat Cc: linux-fb...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/video/intelfb/intelfbhw.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/intelf

[PATCH] ASoC: adau1373: adau1373_hw_params: Silence overflow warning

2013-03-10 Thread Tim Gardner
drivers-de...@blackfin.uclinux.org Cc: alsa-de...@alsa-project.org Signed-off-by: Tim Gardner --- sound/soc/codecs/adau1373.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/adau1373.c b/sound/soc/codecs/adau1373.c index 068b3ae..56ed788 100644 --- a/sound/soc/codecs/

[PATCH linux-next] ASoC: wm_hubs: Silence reg_r and reg_l 'may be used uninitialized' warnings

2013-03-10 Thread Tim Gardner
on 4.6.3 Cc: Mark Brown Cc: Liam Girdwood Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: patc...@opensource.wolfsonmicro.com Cc: alsa-de...@alsa-project.org Signed-off-by: Tim Gardner --- sound/soc/codecs/wm_hubs.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/so

[PATCH linux-next] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-10 Thread Tim Gardner
Cc: "David S. Miller" Cc: Tom Tucker Cc: Haggai Eran Cc: Or Gerlitz Cc: Shani Michaeli Cc: linux-...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Tim Gardner --- net/sunrpc/xprtrdma/verbs.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/

[PATCH linux-next] ipvs: ip_vs_fill_iph_skb: Silence warning that 'iph.thoff_reasm' may be used uninitialized

2013-03-10 Thread Tim Gardner
Julian Anastasov Cc: "David S. Miller" Cc: Alexey Kuznetsov Cc: James Morris Cc: Hideaki YOSHIFUJI Cc: Patrick McHardy Cc: net...@vger.kernel.org Cc: lvs-de...@vger.kernel.org Signed-off-by: Tim Gardner --- include/net/ip_vs.h |6 -- 1 file changed, 4 insertions(+), 2 deleti

crypto: omap-sham, omap-aes and dma_request_slave_channel_compat()

2013-02-26 Thread Tim Gardner
dense ? Reverting those 2 commits at least allows the compile complete. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

[PATCH 3.9-rc1] clk: vt8500: Fix variable name '*prate' compile error

2013-02-26 Thread Tim Gardner
-off-by: Tim Gardner --- drivers/clk/clk-vt8500.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-vt8500.c b/drivers/clk/clk-vt8500.c index b5538bb..09c6331 100644 --- a/drivers/clk/clk-vt8500.c +++ b/drivers/clk/clk-vt8500.c @@ -157,7 +157,7 @@ static int

Re: sched: CPU #1's llc-sibling CPU #0 is not on the same node!

2013-02-25 Thread Tim Gardner
On 02/25/2013 08:02 AM, Tim Gardner wrote: > Is this an expected warning ? I'll boot a vanilla kernel just to be sure. > > rebased against ab7826595e9ec51a51f622c5fc91e2f59440481a in Linus' repo: > Same with a vanilla kernel, so it doesn't appear that any Ubunt

[PATCH linux-next v2] DM RAID: validate_raid_redundancy: Silence uninitialized variable warning

2013-02-21 Thread Tim Gardner
0 anyways to silence GCC warnings. Cc: Alasdair Kergon Cc: dm-de...@redhat.com Cc: Neil Brown Cc: linux-r...@vger.kernel.org Signed-off-by: Tim Gardner --- v2 - Added GCC comment. Update commit log with a more definite explanation. As Neil has pointed out, https://lwn.net/Articl

[PATCH linux-next] DM RAID: validate_raid_redundancy: Silence uninitialized variable warning

2013-02-20 Thread Tim Gardner
at rebuilds_per_group could be used before set, but set it to 0 anyways just to shutup GCC. Cc: Alasdair Kergon Cc: dm-de...@redhat.com Cc: Neil Brown Cc: linux-r...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/md/dm-raid.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH linux/linux-next] aic94xx: asd_read_flash: Fix uninitialized variable warning

2013-02-20 Thread Tim Gardner
If asd_find_flash_de() fails, then 'offs' could be used without having been initialized. Set 'offs' to zero which seems like the most reasonable value. Cc: "James E.J. Bottomley" Cc: linux-s...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/scsi/aic94xx/

[PATCH linux/linux-next] mpt2sas: _scsih_sas_broadcast_primitive_event: Quiet unused variable warning

2013-02-20 Thread Tim Gardner
dd __maybe_unused to the definition of event_data. Cc: Nagalakshmi Nandigama Cc: Sreekanth Reddy Cc: supp...@lsi.com Cc: "James E.J. Bottomley" Cc: dl-mptfusionli...@lsi.com Cc: linux-s...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/scsi/mpt2sas/mpt2sas_scsih.c |3 ++-

[PATCH linux/linux-next] [SCSI] mvsas: Fix compile warnings by using correct enums

2013-02-20 Thread Tim Gardner
Use enum symbols of the same value, but from the correct enum type definition. Cc: "James E.J. Bottomley" Cc: Dan Williams Cc: Greg Kroah-Hartman Cc: Jack Wang Cc: linux-s...@vger.kernel.org Signed-off-by: Tim Gardner --- drivers/scsi/mvsas/mv_sas.c |4 ++-- 1 file changed, 2

[PATCH linux-next v2] firewire: fw_device_init: 'minor' may be used uninitialized

2013-02-18 Thread Tim Gardner
er Cc: linux1394-de...@lists.sourceforge.net Signed-off-by: Tim Gardner --- If this patch is correct, then it also ought to go to stable if it misses 3.8 final. v2 - Better commit subject drivers/firewire/core-device.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/fire

[PATCH linux-next] firewire: fw_device_init: ‘minor’ may be used uninitialized

2013-02-18 Thread Tim Gardner
er Cc: linux1394-de...@lists.sourceforge.net Signed-off-by: Tim Gardner --- If this patch is correct, then it also ought to go to stable if it misses 3.8 final. drivers/firewire/core-device.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/core-device.c b/d

[PATCH linux-next] cpqarray: do_ida_request() - reduce stack frame size

2013-02-18 Thread Tim Gardner
kernel log. drivers/block/cpqarray.c: In function ‘do_ida_request’: drivers/block/cpqarray.c:969:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Chirag Kantharia Cc: iss_storage...@hp.com Signed-off-by: Tim Gardner --- drivers/block/cpqarray.c |7

[PATCH linux-next] rt2x00: rt2x00pci_regbusy_read() - only print register access failure once

2013-02-18 Thread Tim Gardner
inux-wirel...@vger.kernel.org Cc: us...@rt2x00.serialmonkey.com Cc: net...@vger.kernel.org Cc: sta...@vger.kernel.org Signed-off-by: Tim Gardner --- This patch applies as far back as 3.0.65 (and maybe older but that is as far back as I checked). drivers/net/wireless/rt2x00/rt2x00pci.c |4 ++

[PATCH linux-next v2] ocfs2: remove kfree() redundant null checks

2013-02-13 Thread Tim Gardner
calling kfree() etc Cc: Mark Fasheh Cc: Joel Becker Cc: Andrew Morton Cc: Akinobu Mita Cc: Al Viro Cc: "David S. Miller" Cc: Tejun Heo Cc: Jiri Kosina Cc: ocfs2-de...@oss.oracle.com Signed-off-by: Tim Gardner --- v2 - Decided to fix all the kfree() smatch warnings in one p

Re: [PATCH 1/2 linux-next] ocfs2: remove kfree() redundant null checks

2013-02-13 Thread Tim Gardner
On 02/13/2013 12:44 PM, Tim Gardner wrote: > fs/ocfs2/alloc.c:6138 ocfs2_begin_truncate_log_recovery() info: > redundant null check on *tl_copy calling kfree() Ignore this series. I'll resend. rtg -- Tim Gardner tim.gard...@canonical.com -- To unsubscribe from this list: se

[PATCH 2/2 linux-next] ocfs2: ocfs2_begin_truncate_log_recovery(): consolidate status error logging

2013-02-13 Thread Tim Gardner
Cc: Mark Fasheh Cc: Joel Becker Cc: ocfs2-de...@oss.oracle.com Signed-off-by: Tim Gardner --- fs/ocfs2/alloc.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 42c0e49..1689ca1 100644 --- a/fs/ocfs2/alloc.c +++ b/fs

[PATCH 1/2 linux-next] ocfs2: remove kfree() redundant null checks

2013-02-13 Thread Tim Gardner
...@oss.oracle.com Signed-off-by: Tim Gardner --- fs/ocfs2/alloc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 31b9463..42c0e49 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c @@ -6134,11 +6134,8 @@ bail: iput

  1   2   >