I just fixed them up and pulled them in myself. ;-)
I also added the following on top of them (and testing this, live while
testing ftrace patches and other builds).
Thanks Steve!
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 30a4c053f98b..837fa75cbb47 100755
--
On 04/06/2018 11:24 AM, Steven Rostedt wrote:
On Mon, 26 Mar 2018 13:08:01 -0700
Tim Tianyang Chen wrote:
Users can define optional variables to get email notifications.
Ktest can send emails when the script:
* was started
* failed with fatal errors and called dodie()
* completed all
This patch set will let users define a mailer, an email address and when to
receive
notifications during automated testings. Users need to setup the specified
mailer
prior to using this feature.
Tim Tianyang Chen (4):
ktest: add email support
ktest: add SigInt handling
ktest: use dodie
User can cancel tests and specify handler's behavior using option
'EMAIL_WHEN_CANCELED'.
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
tools/testing/ktest/ktest.pl | 10 ++
1 file changed, 10 insertions(+)
diff --git a/tools/testing/ktest/ktest.pl
, mail, sendmail
mailer specific routines are _sendmail_send(), _mailx_send()
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
tools/testing/ktest/ktest.pl | 61 +---
1 file changed, 58 insertions(+), 3 deletions(-)
diff --git a/tools/testing
A block of email options is added under the optional config section.
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
tools/testing/ktest/sample.conf | 22 ++
1 file changed, 22 insertions(+)
diff --git a/tools/testing/ktest/sample.conf b/tools/testing/ktest
he version of the script.
* in Sig-Int handeler because it's not a fatal error to cancel the script.
* errors happen during parsing config
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
tools/testing/ktest/ktest.pl | 54 ++--
1 f
Hi Steve, did you get a chance to take a look? cc'ing myself and a
personal email. When I sent the patchset I forgot to include.
Tianyang
On 2018-03-26 04:08 PM, Tim Tianyang Chen wrote:
This patch set will let users define a mailer, an email address and when to
receive
notifications d
he version of the script.
* in Sig-Int handeler because it's not a fatal error to cancel the script.
* errors happen during parsing config
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
Changes since v2:
revert a change for opening and appending the config f
User can cancel tests and specify handler's behavior using option
'EMAIL_WHEN_CANCELED'.
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
ktest.pl | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ktest.pl b/ktest.pl
index 9469783bc6c1..8be12ee27d
A block of email options is added under the optional config section.
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
Changes since v2:
Added comments and defaults for each option
---
sample.conf | 22 ++
1 file changed, 22 insertions(+)
diff --git
, mail, sendmail
mailer specific routines are _sendmail_send(), _mailx_send()
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
changes since v2:
coding style fix for option maps and if statements
moved sig int handeling to another patch
changes since v1:
added
This patch set will let users define a mailer, an email address and when to
receive
notifications during automated testings. Users need to setup the specified
mailer
prior to using this feature.
Tim Tianyang Chen (4):
Ktest: add email support
Ktest: add SigInt handling
Ktest: use dodie
Thanks for the review Steve! One quick comment inline:
On 03/21/2018 08:16 AM, Steven Rostedt wrote:
On Fri, 15 Dec 2017 15:20:10 -0800
Tim Tianyang Chen wrote:
Users should get emails when the script dies because of a critical failure.
Critical
failures are defined as any errors that could
Hi Steve, did your mailer find all the patches? I made sure they all
reply to the same mail ID this time.
Thanks,
Tim
On 12/15/2017 03:20 PM, Tim Tianyang Chen wrote:
This patch set will let users define a mailer, an email address and when to
receive
notifications during automated testings
he version of the script.
* in Sig-Int handeler because it's not a fatal error to cancel the script.
* errors happen during parsing config
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
changes since v1:
removed changes when errors happen during config parsing
---
.
Supported mailers: mailx, mail, sendmail
mailer specific routines are _sendmail_send(), _mailx_send()
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
changes since v1:
added options for when to sendemails in the option_map
---
ktest.pl | 73
A block of email options is added under the optional config section.
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
sample.conf | 10 ++
1 file changed, 10 insertions(+)
diff --git a/sample.conf b/sample.conf
index 6c58cd8bbbae..0571acf2179b 100644
--- a/sample.conf
This patch set will let users define a mailer, an email address and when to
receive
notifications during automated testings. Users need to setup the specified
mailer
prior to using this feature.
Tim Tianyang Chen (3):
Ktest: add email support
Ktest: use dodie for critical falures
Ktest
On 12/14/2017 04:03 PM, Steven Rostedt wrote:
On Tue, 21 Nov 2017 10:53:35 -0800
Tim Tianyang Chen wrote:
Users should get emails when the script dies because of a critical failure.
Critical
failures are defined as any errors that could terminate the script, via die().
In order to add
Thanks for the review Steven!
First comment is that the numbered patches need to be a reply to the
cover patch (that is patches 1/2 and 2/2 need to be replies of 0/2).
Otherwise, my mailer loses them, because I always have my email sorted
by threads, and a reply to 0/2 will move it away from the
On 12/01/2017 03:55 PM, Steven Rostedt wrote:
On Tue, 21 Nov 2017 10:53:27 -0800
Tim Tianyang Chen wrote:
This patch series will let users define mailer and email address for receiving
notifications during automated testings. Users need to setup the specified
mailer
prior to using this
Tianyang Chen (2):
Ktest: Add email support
Ktest: Use dodie for critial failures
ktest.pl | 129 ++-
1 file changed, 86 insertions(+), 43 deletions(-)
--
1.8.3.1
to get the version of the script.
* in Sig-Int handeler because it's not a fatal error to cancel the script.
* the die() in dodie() itself actually kills the script.
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
ktest.pl | 88 +---
ided in config prior to using this script.
Supported mailers: mailx, mail, sendmail
mailer specific routines are _sendmail_send(), _mailx_send()
Suggested-by: Dhaval Giani
Signed-off-by: Tim Tianyang Chen
---
ktest.pl | 41 +
1 file changed, 41 inserti
25 matches
Mail list logo