RE: [PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Tim.Bird
> -Original Message- > From: Alexei Starovoitov > > On Tue, Apr 13, 2021 at 9:32 AM wrote: > > > > > -Original Message- > > > From: Alexei Starovoitov > > > > > > On Tue, Apr 13, 2021 at 9:19 AM wrote: > > > > > > > > > -Original Message- > > > > > From: Alexei

RE: [PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Tim.Bird
> -Original Message- > From: Alexei Starovoitov > > On Tue, Apr 13, 2021 at 9:19 AM wrote: > > > > > -Original Message- > > > From: Alexei Starovoitov > > > > > > On Tue, Apr 13, 2021 at 9:10 AM wrote: > > > > > > > > > > > > > > > > > -Original Message- > > > > >

RE: [PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Tim.Bird
> -Original Message- > From: Alexei Starovoitov > > On Tue, Apr 13, 2021 at 2:52 AM Yang Li wrote: > > > > Fix the following coccicheck warnings: > > ./tools/testing/selftests/bpf/progs/profiler.inc.h:189:7-11: WARNING > > comparing pointer to 0, suggest !E > >

RE: [PATCH] selftests/bpf: use !E instead of comparing with NULL

2021-04-13 Thread Tim.Bird
> -Original Message- > From: Alexei Starovoitov > > On Tue, Apr 13, 2021 at 9:10 AM wrote: > > > > > > > > > -Original Message- > > > From: Alexei Starovoitov > > > > > > On Tue, Apr 13, 2021 at 2:52 AM Yang Li > > > wrote: > > > > > > > > Fix the following coccicheck

RE: [PATCH] selftests: Fix O= and KBUILD_OUTPUT handling for relative paths

2019-10-15 Thread Tim.Bird
> -Original Message- > From: Shuah Khan on Monday, October 14, 2019 3:45 PM > > Fix O= and KBUILD_OUTPUT handling for relative paths. > > export KBUILD_OUTPUT=../kselftest_size > make TARGETS=size kselftest-all > > or > > make O=../kselftest_size TARGETS=size kselftest-all > > In

RE: [BUGFIX PATCH] selftests: Use real temporary working directory for archiving

2019-10-08 Thread Tim.Bird
> -Original Message- > From: Masami Hiramatsu on Thursday, October 03, 2019 7:13 PM > > Use real temporary working directory for generating kselftest > archive. > > tools/testing/selftests/kselftest directory has been used for > the temporary working directory for making a tar archive

bug in KBUILD_OUTPUT handling - for relative paths in kselftest

2019-09-25 Thread Tim.Bird
I found a bug in kselftest KBUILD_OUTPUT handling. The following works: $ cd /home/tbird/work/linux $ export KBUILD_OUTPUT=/home/tbird/work/kbuild $ yes '' | make localmodconfig $ make TARGETS=size kselftest But this doesn't work: $ cd /home/tbird/work/linux $ export KBUILD_OUTPUT=../kbuild $

RE: [GIT PULL] Kselftest update for Linux 5.4-rc1

2019-09-23 Thread Tim.Bird
> -Original Message- > From: Ingo Molnar on Sunday, September 22, 2019 1:26 AM > > * Linus Torvalds wrote: > > > On Fri, Sep 20, 2019 at 9:35 AM Brendan Higgins > > wrote: > > > > > > Sorry about that. I am surprised that none of the other reviewers > > > brought this up. > > > > I

RE: [PATCH] selftests/kselftest/runner.sh: Add 45 second timeout per test

2019-09-19 Thread Tim.Bird
> -Original Message- > From tim.b...@sony.com > > > -Original Message- > > From: Kees Cook > > > > Commit a745f7af3cbd ("selftests/harness: Add 30 second timeout per > > test") solves the problem of kselftest_harness.h-using binary tests > > possibly hanging forever. However,

RE: [PATCH] selftests/kselftest/runner.sh: Add 45 second timeout per test

2019-09-19 Thread Tim.Bird
> -Original Message- > From: shuah > > On 9/19/19 12:55 PM, Alexandre Belloni wrote: > > On 19/09/2019 11:06:44-0700, Kees Cook wrote: > >> Commit a745f7af3cbd ("selftests/harness: Add 30 second timeout per > >> test") solves the problem of kselftest_harness.h-using binary tests > >>

RE: [PATCH] selftests/kselftest/runner.sh: Add 45 second timeout per test

2019-09-19 Thread Tim.Bird
> -Original Message- > From: Kees Cook > > Commit a745f7af3cbd ("selftests/harness: Add 30 second timeout per > test") solves the problem of kselftest_harness.h-using binary tests > possibly hanging forever. However, scripts and other binaries can still > hang forever. This adds a

RE: [PATCH] kunit: add PRINTK dependency

2019-09-06 Thread Tim.Bird
Minor spelling nit.. > -Original Message- > From: Arnd Bergmann > > The vprintk_emit() function is not available when CONFIG_PRINTK > is disabled: > > kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [- > Werror,-Wimplicit-function-declaration] > > I suppose

RE: [PATCH v2] kunit: fix failure to build without printk

2019-08-30 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Fri, Aug 30, 2019 at 11:22:43PM +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: Brendan Higgins > > > > > > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote: > > > > > > > > On Fri, 2019-08-30 at 21:58

RE: [PATCH v2] kunit: fix failure to build without printk

2019-08-30 Thread Tim.Bird
> -Original Message- > From: Joe Perches > > On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote: > > > From: Joe Perches > [] > > IMHO %pV should be avoided if possible. Just because people are > > doing it doesn't mean it should be used when it is not necessary. > > Well,

RE: [PATCH v2] kunit: fix failure to build without printk

2019-08-30 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Fri, Aug 30, 2019 at 3:46 PM Joe Perches wrote: > > > > On Fri, 2019-08-30 at 21:58 +, tim.b...@sony.com wrote: > > > > From: Joe Perches > > [] > > > IMHO %pV should be avoided if possible. Just because people are > > > doing it

RE: [PATCH v2] kunit: fix failure to build without printk

2019-08-30 Thread Tim.Bird
> -Original Message- > From: Joe Perches > > On Fri, 2019-08-30 at 11:38 -0700, Brendan Higgins wrote: > > On Thu, Aug 29, 2019 at 09:44:58PM -0700, Joe Perches wrote: > > > On Thu, 2019-08-29 at 11:01 -0600, shuah wrote: > > > > On 8/28/19 3:49 AM, Sergey Senozhatsky wrote: > > > > >

RE: [PATCH v1] kunit: fix failure to build without printk

2019-08-27 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Tue, Aug 27, 2019 at 3:00 PM shuah wrote: > > > > On 8/27/19 3:36 PM, Brendan Higgins wrote: > > > On Tue, Aug 27, 2019 at 2:09 PM Brendan Higgins > > > wrote: > > >> > > >> On Tue, Aug 27, 2019 at 2:03 PM Brendan Higgins > > >>

RE: [PATCH] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue

2019-08-14 Thread Tim.Bird
> -Original Message- > From: Anders Roxell > > When running tcp_fastopen_backup_key.sh the following issue was seen in > a busybox environment. > ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected > > Shellcheck showed the following issue. > $ shellcheck

RE: Linux Testing Microconference at LPC

2019-05-22 Thread Tim.Bird
> -Original Message- > From: Dmitry Vyukov > On Fri, Apr 26, 2019 at 11:03 PM Tim Bird wrote: > > > > I'm in the process now of planning Automated Testing Summit 2019, > > which is tentatively planned for Lyon, France on October 31. This is > > This is _November_ 1, right? No.

RE: Linux Testing Microconference at LPC

2019-05-15 Thread Tim.Bird
> -Original Message- > From: Sasha Levin > > On Fri, Apr 26, 2019 at 02:02:53PM -0700, Tim Bird wrote: ... > > > >With regards to the Testing microconference at Plumbers, I would like > >to do a presentation on the current status of test standards and test > >framework

RE: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Tim.Bird
> -Original Message- > From: Al Viro > > On Sat, Oct 27, 2018 at 06:52:44AM +, visionsofal...@redchan.it wrote: > > Al: the FSF was so insistent on the adoption of the GPL version 3 > > because the GPL version 2 is not operative against the grantor. > > Anonymous wankstain: sod off

RE: [Ksummit-discuss] The linux devs can rescind their license grant.

2018-10-27 Thread Tim.Bird
> -Original Message- > From: Al Viro > > On Sat, Oct 27, 2018 at 06:52:44AM +, visionsofal...@redchan.it wrote: > > Al: the FSF was so insistent on the adoption of the GPL version 3 > > because the GPL version 2 is not operative against the grantor. > > Anonymous wankstain: sod off

RE: [Ksummit-discuss] [PATCH 6/7] Code of Conduct: Change the contact email address

2018-10-20 Thread Tim.Bird
> -Original Message- > From: Alan Cox > > > +to the circumstances. The Code of Conduct Committee is obligated to > > +maintain confidentiality with regard to the reporter of an incident. > > +Further details of specific enforcement policies may be posted > > +separately. > >

RE: [Ksummit-discuss] [PATCH 6/7] Code of Conduct: Change the contact email address

2018-10-20 Thread Tim.Bird
> -Original Message- > From: Alan Cox > > > +to the circumstances. The Code of Conduct Committee is obligated to > > +maintain confidentiality with regard to the reporter of an incident. > > +Further details of specific enforcement policies may be posted > > +separately. > >

RE: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-18 Thread Tim.Bird
> -Original Message- > From: Frank Rowand > > On 10/18/18 07:56, James Bottomley wrote: > > On Wed, 2018-10-17 at 12:53 -0700, Frank Rowand wrote: > >> On 10/17/18 12:08, James Bottomley wrote: > > [...] > Trying to understand how you are understanding my comment vs what > I

RE: [Ksummit-discuss] [PATCH v3 1/3] code-of-conduct: Fix the ambiguity about collecting email addresses

2018-10-18 Thread Tim.Bird
> -Original Message- > From: Frank Rowand > > On 10/18/18 07:56, James Bottomley wrote: > > On Wed, 2018-10-17 at 12:53 -0700, Frank Rowand wrote: > >> On 10/17/18 12:08, James Bottomley wrote: > > [...] > Trying to understand how you are understanding my comment vs what > I

RE: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Wed, Oct 17, 2018 at 10:52 AM wrote: > > > > > > It might be of interest to the automated testing mailing list too ? (Tim?) > > > > I think this is interesting to groups doing automated testing of the kernel > > (including myself)

RE: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > On Wed, Oct 17, 2018 at 10:52 AM wrote: > > > > > > It might be of interest to the automated testing mailing list too ? (Tim?) > > > > I think this is interesting to groups doing automated testing of the kernel > > (including myself)

RE: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Kieran Bingham > > Hi Brendan, > > I very excitedly jumped on these patches to try them out, as this is > essentially something I was trying to do a few weeks back. > > On 17/10/18 00:50, Brendan Higgins wrote: > > Makes minimum number of changes outside

RE: [RFC v1 06/31] arch: um: enabled running kunit from User Mode Linux

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Kieran Bingham > > Hi Brendan, > > I very excitedly jumped on these patches to try them out, as this is > essentially something I was trying to do a few weeks back. > > On 17/10/18 00:50, Brendan Higgins wrote: > > Makes minimum number of changes outside

RE: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. I'm interested in this, and think the kernel might benefit from this, but I have lots of questions. > Unlike Autotest and kselftest,

RE: [RFC v1 00/31] kunit: Introducing KUnit, the Linux kernel unit testing framework

2018-10-17 Thread Tim.Bird
> -Original Message- > From: Brendan Higgins > > This patch set proposes KUnit, a lightweight unit testing and mocking > framework for the Linux kernel. I'm interested in this, and think the kernel might benefit from this, but I have lots of questions. > Unlike Autotest and kselftest,

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Tim.Bird
> -Original Message- > From: James Bottomley > > On Mon, 2018-10-08 at 17:58 +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: James Bottomley > > > > > > On Mon, 2018-10-08 at 13:51 +, tim.b...@sony.com wrote: > > > > > -Original Message- > > > >

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Tim.Bird
> -Original Message- > From: James Bottomley > > On Mon, 2018-10-08 at 17:58 +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: James Bottomley > > > > > > On Mon, 2018-10-08 at 13:51 +, tim.b...@sony.com wrote: > > > > > -Original Message- > > > >

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Tim.Bird
> -Original Message- > From: James Bottomley > > On Mon, 2018-10-08 at 13:51 +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: James Bottomley > > > On Sat, 2018-10-06 at 21:43 +, tim.b...@sony.com wrote: > > > > > -Original Message- > > > > > From:

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Tim.Bird
> -Original Message- > From: James Bottomley > > On Mon, 2018-10-08 at 13:51 +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: James Bottomley > > > On Sat, 2018-10-06 at 21:43 +, tim.b...@sony.com wrote: > > > > > -Original Message- > > > > > From:

RE: [Ksummit-discuss] [PATCH] code-of-conduct: Remove explicit list of discrimination factors

2018-10-08 Thread Tim.Bird
> -Original Message- > From: Laurent Pinchart > > Hi Tim, > > On Monday, 8 October 2018 17:12:05 EEST tim.b...@sony.com wrote: > > > -Original Message- > > > From: Josh Triplett > > > On Sun, Oct 07, 2018 at 08:18:26PM +0300, Laurent Pinchart wrote: > > >> On Sunday, 7 October

RE: [Ksummit-discuss] [PATCH] code-of-conduct: Remove explicit list of discrimination factors

2018-10-08 Thread Tim.Bird
> -Original Message- > From: Laurent Pinchart > > Hi Tim, > > On Monday, 8 October 2018 17:12:05 EEST tim.b...@sony.com wrote: > > > -Original Message- > > > From: Josh Triplett > > > On Sun, Oct 07, 2018 at 08:18:26PM +0300, Laurent Pinchart wrote: > > >> On Sunday, 7 October

RE: [Ksummit-discuss] [PATCH] code-of-conduct: Remove explicit list of discrimination factors

2018-10-08 Thread Tim.Bird
> -Original Message- > From: Josh Triplett > > On Sun, Oct 07, 2018 at 08:18:26PM +0300, Laurent Pinchart wrote: > > Hi Josh, > > > > On Sunday, 7 October 2018 14:35:14 EEST Josh Triplett wrote: > > > On Sun, Oct 07, 2018 at 10:51:02AM +0200, Geert Uytterhoeven wrote: > > > > Providing an

RE: [Ksummit-discuss] [PATCH] code-of-conduct: Remove explicit list of discrimination factors

2018-10-08 Thread Tim.Bird
> -Original Message- > From: Josh Triplett > > On Sun, Oct 07, 2018 at 08:18:26PM +0300, Laurent Pinchart wrote: > > Hi Josh, > > > > On Sunday, 7 October 2018 14:35:14 EEST Josh Triplett wrote: > > > On Sun, Oct 07, 2018 at 10:51:02AM +0200, Geert Uytterhoeven wrote: > > > > Providing an

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Tim.Bird
> -Original Message- > From: James Bottomley > On Sat, 2018-10-06 at 21:43 +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: James Bottomley > > > > > > Significant concern has been expressed about the responsibilities > > > outlined in the enforcement clause

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-08 Thread Tim.Bird
> -Original Message- > From: James Bottomley > On Sat, 2018-10-06 at 21:43 +, tim.b...@sony.com wrote: > > > -Original Message- > > > From: James Bottomley > > > > > > Significant concern has been expressed about the responsibilities > > > outlined in the enforcement clause

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-06 Thread Tim.Bird
> -Original Message- > From: James Bottomley > > Significant concern has been expressed about the responsibilities outlined in > the enforcement clause of the new code of conduct. Since there is concern > that this becomes binding on the release of the 4.19 kernel, strip the >

RE: [Ksummit-discuss] [PATCH 2/2] code-of-conduct: Strip the enforcement paragraph pending community discussion

2018-10-06 Thread Tim.Bird
> -Original Message- > From: James Bottomley > > Significant concern has been expressed about the responsibilities outlined in > the enforcement clause of the new code of conduct. Since there is concern > that this becomes binding on the release of the 4.19 kernel, strip the >