[PATCH 02/18 v2] MAINTAINERS: Add maintainer for drivers/staging/gasket

From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,7

[PATCH 02/18 v2] MAINTAINERS: Add maintainer for drivers/staging/gasket

From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,7

[PATCH 05/18] staging: gasket: sysfs mapping creation fixups

From: Todd Poynor Return EBUSY for attempt to create a mapping already in use. Remove stale pointers on error allocating attr array. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

From: Todd Poynor Return -ETIMEDOUT on timeouts. Don't need 64-bit sized retry count. Use msleep(). Return immediately when condition hit. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 8 drivers

[PATCH 05/18] staging: gasket: sysfs mapping creation fixups

From: Todd Poynor Return EBUSY for attempt to create a mapping already in use. Remove stale pointers on error allocating attr array. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

From: Todd Poynor Return -ETIMEDOUT on timeouts. Don't need 64-bit sized retry count. Use msleep(). Return immediately when condition hit. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 8 drivers

[PATCH 14/18] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 10/18] staging: gasket: gasket_open use container_of()

From: Todd Poynor Use container_of(), drop unnecessary NULL check. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket

[PATCH 14/18] staging: gasket: fix class create bug handling

From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 10/18] staging: gasket: gasket_open use container_of()

From: Todd Poynor Use container_of(), drop unnecessary NULL check. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket

[PATCH 03/18] staging: gasket: typo and whitespace cleanups

From: Todd Poynor Trivial typo and whitespace fixes. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- drivers/staging/gasket/gasket_core.h | 2 +- drivers/staging/gasket/gasket_page_table.c | 2 +- 3 files changed, 3 insertions

[PATCH 00/18] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Various (18): staging: gasket: remove X86 Kconfig restriction MAINTAINERS: Add maintainer for drivers/staging/gasket staging: gasket: typo and whitespace cleanups staging

[PATCH 01/18] staging: gasket: remove X86 Kconfig restriction

From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig

[PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

From: Todd Poynor g_mutex held across pci_unregister_driver() call, also held in gasket_pci_remove(), which deadlocks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5

[PATCH 04/18] staging: gasket: device registration error and unregister fixups

From: Todd Poynor Remove device registration on class creation fail. Hold mutex around device removal updates for proper ordering of updates. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 +++- 1 file changed, 7 insertions(+), 1

[PATCH 00/18] staging: gasket: sundry fixes and fixups

From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Various (18): staging: gasket: remove X86 Kconfig restriction MAINTAINERS: Add maintainer for drivers/staging/gasket staging: gasket: typo and whitespace cleanups staging

[PATCH 01/18] staging: gasket: remove X86 Kconfig restriction

From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig

[PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

From: Todd Poynor g_mutex held across pci_unregister_driver() call, also held in gasket_pci_remove(), which deadlocks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5

[PATCH 04/18] staging: gasket: device registration error and unregister fixups

From: Todd Poynor Remove device registration on class creation fail. Hold mutex around device removal updates for proper ordering of updates. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 +++- 1 file changed, 7 insertions(+), 1

[PATCH 03/18] staging: gasket: typo and whitespace cleanups

From: Todd Poynor Trivial typo and whitespace fixes. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- drivers/staging/gasket/gasket_core.h | 2 +- drivers/staging/gasket/gasket_page_table.c | 2 +- 3 files changed, 3 insertions

[PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,6

[PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,6

[PATCH 13/18] staging: gasket: gasket_enable_dev fixups

From: Todd Poynor Remove unnecessary variable. Bail out if no physical device. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging

[PATCH 18/18] staging: gasket: various cleanups

From: Todd Poynor Cleanups to error codes, code style, error conditions, etc. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 ++- drivers/staging/gasket/apex_driver.c | 50 - drivers

[PATCH 11/18] staging: gasket: always allow root open for write

From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +++-- drivers/staging/gasket

[PATCH 07/18] staging: gasket: convert gasket_mmap_has_permissions to bool return

From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 09/18] staging: gasket: bail out of reset sequence on device callback error

From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 15/18] staging: gasket: remove unnecessary code in coherent allocator

From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH 12/18] staging: gasket: annotate ioctl arg with __user

From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 12 ++--- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h | 4 +- drivers/staging

[PATCH 13/18] staging: gasket: gasket_enable_dev fixups

From: Todd Poynor Remove unnecessary variable. Bail out if no physical device. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging

[PATCH 18/18] staging: gasket: various cleanups

From: Todd Poynor Cleanups to error codes, code style, error conditions, etc. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 ++- drivers/staging/gasket/apex_driver.c | 50 - drivers

[PATCH 11/18] staging: gasket: always allow root open for write

From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +++-- drivers/staging/gasket

[PATCH 07/18] staging: gasket: convert gasket_mmap_has_permissions to bool return

From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 09/18] staging: gasket: bail out of reset sequence on device callback error

From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 15/18] staging: gasket: remove unnecessary code in coherent allocator

From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH 12/18] staging: gasket: annotate ioctl arg with __user

From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 12 ++--- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h | 4 +- drivers/staging

[PATCH 16/18] staging: gasket: gasket core error handling fixups

From: Todd Poynor Minor fixups to error codes and error handling in gasket core. No device reset callback registered is not an error condition. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 17/18] staging: gasket: don't release coherent mappings

From: Todd Poynor coherent address mappings aren't backed by a struct page, don't need to be released, and don't count as an active page in the page table bookkeeping. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1

[PATCH 16/18] staging: gasket: gasket core error handling fixups

From: Todd Poynor Minor fixups to error codes and error handling in gasket core. No device reset callback registered is not an error condition. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 17/18] staging: gasket: don't release coherent mappings

From: Todd Poynor coherent address mappings aren't backed by a struct page, don't need to be released, and don't count as an active page in the page table bookkeeping. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1

[PATCH] drivers/staging/gasket: Use refcount_read()

From: Todd Poynor Use the refcount_read accessor function, avoid reaching into refcount and atomic struct fields. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_sysfs.c b

[PATCH] drivers/staging/gasket: Use refcount_read()

From: Todd Poynor Use the refcount_read accessor function, avoid reaching into refcount and atomic struct fields. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_sysfs.c b

[PATCH v2] drivers: base: initcall_debug logs for driver probe times

From: Todd Poynor Add initcall_debug logs for each driver device probe call, for example: probe of a380.ramoops returned 1 after 3007 usecs This replaces the previous code added to report times for deferred probes. It also reports OF platform bus device creates that were formerly

[PATCH v2] drivers: base: initcall_debug logs for driver probe times

From: Todd Poynor Add initcall_debug logs for each driver device probe call, for example: probe of a380.ramoops returned 1 after 3007 usecs This replaces the previous code added to report times for deferred probes. It also reports OF platform bus device creates that were formerly

[PATCH] drivers: base: initcall_debug logs for driver probe times

From: Todd Poynor Add initcall_debug logs for each driver device probe call, for example: probe of a380.ramoops returned after 3007 usecs This replaces the previous code added to report times for deferred probes. It also reports OF platform bus device creates that were formerly lumped

[PATCH] drivers: base: initcall_debug logs for driver probe times

From: Todd Poynor Add initcall_debug logs for each driver device probe call, for example: probe of a380.ramoops returned after 3007 usecs This replaces the previous code added to report times for deferred probes. It also reports OF platform bus device creates that were formerly lumped

[PATCH] of/platform: add initcall_debug logs for device creates

From: Todd Poynor Add initcall_debug logs for the amount of time taken by each OF platform bus device create call. For example: of platform device create /reserved-memory/ramoops@a380 took 3255 usecs initcall_debug already reports the total of all such device creates as a single

[PATCH] of/platform: add initcall_debug logs for device creates

From: Todd Poynor Add initcall_debug logs for the amount of time taken by each OF platform bus device create call. For example: of platform device create /reserved-memory/ramoops@a380 took 3255 usecs initcall_debug already reports the total of all such device creates as a single

[PATCH] staging: android: ion: remove duplicate buffer field initializes

fields from the function parameters, prior to the heap allocate() call, for consistency. Signed-off-by: Todd Poynor <toddpoy...@google.com> --- drivers/staging/android/ion/ion.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/d

[PATCH] staging: android: ion: remove duplicate buffer field initializes

fields from the function parameters, prior to the heap allocate() call, for consistency. Signed-off-by: Todd Poynor --- drivers/staging/android/ion/ion.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c

[PATCH] sg: protect against races between mmap() and SG_SET_RESERVED_SIZE

operation with the mapping. Signed-off-by: Todd Poynor <toddpoy...@google.com> --- drivers/scsi/sg.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 3a44b4bc872b..a20718e9f1f4 100644 --- a/drivers/scsi/sg.c +++ b/d

[PATCH] sg: protect against races between mmap() and SG_SET_RESERVED_SIZE

operation with the mapping. Signed-off-by: Todd Poynor --- drivers/scsi/sg.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 3a44b4bc872b..a20718e9f1f4 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -1233,6 +1233,7

[PATCH] sg: recheck MMAP_IO request length with lock held

M should be returned in this case, instead of switching over to an indirect buffer as for non-MMAP_IO requests. Signed-off-by: Todd Poynor <toddpoy...@google.com> --- drivers/scsi/sg.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/sc

[PATCH] sg: recheck MMAP_IO request length with lock held

M should be returned in this case, instead of switching over to an indirect buffer as for non-MMAP_IO requests. Signed-off-by: Todd Poynor --- drivers/scsi/sg.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index d7ff71e0c85c.

Re: [PATCH] initcall_debug: add deferred probe times

On Tue, Jul 25, 2017 at 4:40 PM, Greg Kroah-Hartman <gre...@linuxfoundation.org> wrote: > On Tue, Jul 25, 2017 at 04:31:59PM -0700, Todd Poynor wrote: >> initcall_debug attributes all deferred device probe retries for the >> late_initcall level to function deferred_prob

Re: [PATCH] initcall_debug: add deferred probe times

On Tue, Jul 25, 2017 at 4:40 PM, Greg Kroah-Hartman wrote: > On Tue, Jul 25, 2017 at 04:31:59PM -0700, Todd Poynor wrote: >> initcall_debug attributes all deferred device probe retries for the >> late_initcall level to function deferred_probe_initcall. Add logs of >> the in

[PATCH] initcall_debug: add deferred probe times

initcall processing are not shown. Example log messages added: [0.505119] deferred probe my-sound-device @ 6 [0.517656] deferred probe my-sound-device returned after 1227 usecs Signed-off-by: Todd Poynor <toddpoy...@google.com> --- drivers/base/dd.c | 28 +

[PATCH] initcall_debug: add deferred probe times

initcall processing are not shown. Example log messages added: [0.505119] deferred probe my-sound-device @ 6 [0.517656] deferred probe my-sound-device returned after 1227 usecs Signed-off-by: Todd Poynor --- drivers/base/dd.c | 28 +++- 1 file changed, 27

[PATCH v2] cgroup: move cgroup_subsys_state parent field for cache locality

From: Todd Poynor <toddpoy...@google.com> Various structures embed a struct cgroup_subsys_state, typically at the top of the containing structure. It is common for code that accesses the structures to perform operations that iterate over the chain of parent css pointers, also accessin

[PATCH v2] cgroup: move cgroup_subsys_state parent field for cache locality

From: Todd Poynor Various structures embed a struct cgroup_subsys_state, typically at the top of the containing structure. It is common for code that accesses the structures to perform operations that iterate over the chain of parent css pointers, also accessing data in each containing

[PATCH] cgroup: move cgroup_subsys_state partner field for cache locality

From: Todd Poynor <toddpoy...@gmail.com> Various structures embed a struct cgroup_subsys_state, typically at the top of the containing structure. It is common for code that accesses the structures to perform operations that iterate over the chain of parent css pointers, also accessin

[PATCH] cgroup: move cgroup_subsys_state partner field for cache locality

From: Todd Poynor Various structures embed a struct cgroup_subsys_state, typically at the top of the containing structure. It is common for code that accesses the structures to perform operations that iterate over the chain of parent css pointers, also accessing data in each containing

Re: [PATCH 1/3] usb: phy: introduce usb_phy_set_event interface

On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy wrote: > From: Todd Poynor > > usb: phy: introduce usb_phy_set_event interface Hi Kiran, this is new stuff that is all your own work and you deserve the credit. Thanks for working to get this feature in shape for mainlin

Re: [PATCH 1/3] usb: phy: introduce usb_phy_set_event interface

On Wed, Nov 19, 2014 at 2:43 AM, Kiran Kumar Raparthy kiran.ku...@linaro.org wrote: From: Todd Poynor toddpoy...@google.com usb: phy: introduce usb_phy_set_event interface Hi Kiran, this is new stuff that is all your own work and you deserve the credit. Thanks for working to get this feature

Re: [PATCH v2] PM: Print wall time at suspend entry and exit

On Sat, Sep 20, 2014 at 5:04 PM, Rafael J. Wysocki wrote: > On Friday, September 19, 2014 04:57:12 AM Amit Pundir wrote: >> From: Todd Poynor >> >> Existing timestamps in a dmesg only log suspend activities >> (e.g. filesystem syncs, freezing/unfreezing tasks etc) whil

Re: [PATCH v2] PM: Print wall time at suspend entry and exit

On Sat, Sep 20, 2014 at 5:04 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Friday, September 19, 2014 04:57:12 AM Amit Pundir wrote: From: Todd Poynor toddpoy...@google.com Existing timestamps in a dmesg only log suspend activities (e.g. filesystem syncs, freezing/unfreezing tasks etc

Re: [RFC PATCH] pm: prevent suspend until power supply events are processed

On Wed, Sep 3, 2014 at 9:53 PM, Viresh Kumar wrote: > On 4 September 2014 10:21, Viresh Kumar wrote: >> + /* dependent power supplies (e.g. battery) may have changed >> +* state as a result of this event, so poll again and hold >> +* the wakeup_source until

Re: [RFC PATCH] pm: prevent suspend until power supply events are processed

On Thu, Sep 4, 2014 at 9:37 AM, Tc, Jenny wrote: > If the intention is to prevent suspend while processing the power supply > uevents, > Isn't it a good option to use EPOLLWAKEUP? In Android, it's already used by > healthd to achieve the same. It's a good idea for the userspace handler of the

Re: [RFC PATCH] pm: prevent suspend until power supply events are processed

On Thu, Sep 4, 2014 at 9:37 AM, Tc, Jenny jenny...@intel.com wrote: If the intention is to prevent suspend while processing the power supply uevents, Isn't it a good option to use EPOLLWAKEUP? In Android, it's already used by healthd to achieve the same. It's a good idea for the userspace

Re: [RFC PATCH] pm: prevent suspend until power supply events are processed

On Wed, Sep 3, 2014 at 9:53 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 4 September 2014 10:21, Viresh Kumar viresh.ku...@linaro.org wrote: + /* dependent power supplies (e.g. battery) may have changed +* state as a result of this event, so poll again and hold +

Re: [RFC v2 2/2] usb: phy: Temporarily hold wakeupsource on charger connect and disconnect events

On Tue, Sep 2, 2014 at 7:54 AM, Felipe Balbi wrote: > Hi, > > On Tue, Sep 02, 2014 at 05:19:18PM +0530, Kiran Kumar Raparthy wrote: ... >> diff --git a/drivers/usb/phy/otg-wakeupsource.c >> b/drivers/usb/phy/otg-wakeupsource.c >> index fca2010..70fa05e 100644 >> ---

Re: [RFC v2 2/2] usb: phy: Temporarily hold wakeupsource on charger connect and disconnect events

On Tue, Sep 2, 2014 at 7:54 AM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Sep 02, 2014 at 05:19:18PM +0530, Kiran Kumar Raparthy wrote: ... diff --git a/drivers/usb/phy/otg-wakeupsource.c b/drivers/usb/phy/otg-wakeupsource.c index fca2010..70fa05e 100644 ---

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

On Fri, Aug 29, 2014 at 1:50 PM, Felipe Balbi wrote: > Hi, > > On Wed, Aug 27, 2014 at 02:58:30PM -0700, Todd Poynor wrote: >> On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: >> ... >> > you never explain why this is needed and you have also added some >&g

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

On Fri, Aug 29, 2014 at 1:50 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Wed, Aug 27, 2014 at 02:58:30PM -0700, Todd Poynor wrote: On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi ba...@ti.com wrote: ... you never explain why this is needed and you have also added some information to commit

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi wrote: ... > you never explain why this is needed and you have also added some > information to commit log which shouldn't be here. Android uses this to prevent suspend from interfering with USB peripheral traffic, notably adb. The wakeup source is

Re: [RFC 1/2] USB: OTG: Hold wakeupsource when VBUS present

On Fri, Aug 22, 2014 at 10:12 AM, Felipe Balbi ba...@ti.com wrote: ... you never explain why this is needed and you have also added some information to commit log which shouldn't be here. Android uses this to prevent suspend from interfering with USB peripheral traffic, notably adb. The wakeup

Re: [RFC][PATCH 1/2] PM: Print pending wakeup IRQ preventing suspend to dmesg

On Fri, Aug 1, 2014 at 9:30 AM, Amit Pundir wrote: > From: Todd Poynor > > Currently when a pending wakeup irq stops suspend, it can be difficult > to determine why suspend was prevented and which IRQ was actually > responsible. > > In order to help debug these situatio

Re: [RFC][PATCH 2/2] PM: Suspend: Print wall time at suspend entry and exit

> Existing printk timestamps in a dmesg only log suspend activities > (e.g. filesystem syncs, freezing/unfreezing tasks etc) while the > system has already started to enter/exit the suspend state. Sometimes > it is handy to have suspend entry/exit overhead information while > debugging suspend

Re: [RFC][PATCH 2/2] PM: Suspend: Print wall time at suspend entry and exit

Existing printk timestamps in a dmesg only log suspend activities (e.g. filesystem syncs, freezing/unfreezing tasks etc) while the system has already started to enter/exit the suspend state. Sometimes it is handy to have suspend entry/exit overhead information while debugging suspend issues.

Re: [RFC][PATCH 1/2] PM: Print pending wakeup IRQ preventing suspend to dmesg

On Fri, Aug 1, 2014 at 9:30 AM, Amit Pundir amit.pun...@linaro.org wrote: From: Todd Poynor toddpoy...@google.com Currently when a pending wakeup irq stops suspend, it can be difficult to determine why suspend was prevented and which IRQ was actually responsible. In order to help debug

[PATCH 0/2] timerfd support for wakeup alarm timers

Enable wakeup alarm timers via file descriptors. Hook up alarmtimer to timerfd via clocks CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM, and add needed functions to alarmtimer. fs/timerfd.c | 131 + include/linux/alarmtimer.h |4 +

[PATCH 2/2] timerfd: add alarm timers

Add support for clocks CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM, thereby enabling wakeup alarm timers via file descriptors. Signed-off-by: Todd Poynor --- fs/timerfd.c | 131 --- 1 file changed, 108 insertions(+), 23 deletions

[PATCH 1/2] alarmtimer: add functions for timerfd support

. Signed-off-by: Todd Poynor --- include/linux/alarmtimer.h | 4 kernel/time/alarmtimer.c | 39 ++- 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/include/linux/alarmtimer.h b/include/linux/alarmtimer.h index 9069694..a899402 100644

[PATCH 1/2] alarmtimer: add functions for timerfd support

. Signed-off-by: Todd Poynor toddpoy...@google.com --- include/linux/alarmtimer.h | 4 kernel/time/alarmtimer.c | 39 ++- 2 files changed, 42 insertions(+), 1 deletion(-) diff --git a/include/linux/alarmtimer.h b/include/linux/alarmtimer.h index 9069694

[PATCH 2/2] timerfd: add alarm timers

Add support for clocks CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM, thereby enabling wakeup alarm timers via file descriptors. Signed-off-by: Todd Poynor toddpoy...@google.com --- fs/timerfd.c | 131 --- 1 file changed, 108 insertions

[PATCH 0/2] timerfd support for wakeup alarm timers

Enable wakeup alarm timers via file descriptors. Hook up alarmtimer to timerfd via clocks CLOCK_REALTIME_ALARM and CLOCK_BOOTTIME_ALARM, and add needed functions to alarmtimer. fs/timerfd.c | 131 + include/linux/alarmtimer.h |4 +

[PATCH] alarmtimer: implement minimum alarm interval for allowing suspend

for 1 second while the alarm is allowed to be serviced or other hopefully transient conditions preventing the alarm clear up. Signed-off-by: Todd Poynor --- kernel/time/alarmtimer.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel/time/alarmtimer.c b

[PATCH] alarmtimer: implement minimum alarm interval for allowing suspend

for 1 second while the alarm is allowed to be serviced or other hopefully transient conditions preventing the alarm clear up. Signed-off-by: Todd Poynor toddpoy...@google.com --- kernel/time/alarmtimer.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/kernel

Re: [PATCH] PM / Sleep: Print name of wakeup source that aborts suspend

On Wed, Jul 18, 2012 at 09:47:34PM +0200, Rafael J. Wysocki wrote: > On Wednesday, July 18, 2012, Todd Poynor wrote: ... > > +{ > > + struct wakeup_source *ws; > > + int active = 0; > > + struct wakeup_source *last_activity_ws = NULL;

Re: [PATCH] PM / Sleep: Print name of wakeup source that aborts suspend

On Wed, Jul 18, 2012 at 09:47:34PM +0200, Rafael J. Wysocki wrote: On Wednesday, July 18, 2012, Todd Poynor wrote: ... +{ + struct wakeup_source *ws; + int active = 0; + struct wakeup_source *last_activity_ws = NULL; + + rcu_read_lock(); + list_for_each_entry_rcu(ws

[PATCH] PM / Sleep: Print name of wakeup source that aborts suspend

Print active wakeup sources, or the most recently active wakeup source, when a PM transition is aborted due to wakeup source events. Signed-off-by: Todd Poynor --- drivers/base/power/wakeup.c | 29 + 1 files changed, 29 insertions(+), 0 deletions(-) A driver

[PATCH] PM / Sleep: Print name of wakeup source that aborts suspend

Print active wakeup sources, or the most recently active wakeup source, when a PM transition is aborted due to wakeup source events. Signed-off-by: Todd Poynor toddpoy...@google.com --- drivers/base/power/wakeup.c | 29 + 1 files changed, 29 insertions(+), 0

Re: [linux-pm] PowerOP Take 2 1/3: ARM OMAP1 platform support

David Brownell wrote: Interesting. I start to like this shape better; it moves more of the logic to operating point code, where it can make the sysfs interface talk in terms of meaningful abstractions, not cryptic numeric offsets. But it was odd to see the first patch be platform-specific

Re: [linux-pm] PowerOP Take 2 1/3: ARM OMAP1 platform support

David Brownell wrote: Interesting. I start to like this shape better; it moves more of the logic to operating point code, where it can make the sysfs interface talk in terms of meaningful abstractions, not cryptic numeric offsets. But it was odd to see the first patch be platform-specific

Re: PowerOP Take 2 0/3 Intro

Jordan Crouse wrote: Todd - do you have a ChangeLog from Take 1? :) Right, here's what's changed in this version... The generic structure of an operating point as an array of integers is dropped. A struct powerop_point is now an entirely backend-defined struct of arbitrary fields. There

Re: PowerOP Take 2 0/3 Intro

Jordan Crouse wrote: Todd - do you have a ChangeLog from Take 1? :) Right, here's what's changed in this version... The generic structure of an operating point as an array of integers is dropped. A struct powerop_point is now an entirely backend-defined struct of arbitrary fields. There

PowerOP Take 2 2/3: sysfs UI core

x-2.6.13-rc4/drivers/powerop/powerop_sysfs.c === --- /dev/null +++ linux-2.6.13-rc4/drivers/powerop/powerop_sysfs.c @@ -0,0 +1,398 @@ +/* + * PowerOP sysfs UI + * + * Author: Todd Poynor <[EMAIL PROTECTED]> + * + * 2005 (c) M

PowerOP Take 2 3/3: OMAP1 sysfs UI

A PowerOP sysfs UI backend for OMAP1 platforms, adding sysfs attributes and show/store functions that correspond to the platform power parameters. An example usage on an OMAP1510 Innovator which does not have voltage scaling and ignoring the DSP: # echo -n 168-168-84 > /sys/powerop/new # DPLL

PowerOP Take 2 0/3 Intro

PowerOP is a system power parameter management API submitted for discussion. PowerOP writes and reads power "operating points", comprised of arbitrary values, called power parameters, that correspond to registers, clocks, dividers, voltage regulators, etc. that may be modified to set a basic

PowerOP Take 2 1/3: ARM OMAP1 platform support

=== --- /dev/null +++ linux-2.6.13-rc4/arch/arm/mach-omap1/powerop.c @@ -0,0 +1,157 @@ +/* + * PowerOP support for OMAP1 + * + * Based on DPM OMAP code by Matthew Locke, Dmitry Chigirev, Vladimir + * Barinov, and Todd Poynor. + * + * 2005 (c) MontaVista Software, Inc. This file

<    2   3   4   5   6   7   8   >