Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls

2018-03-09 Thread Tom Bogendoerfer
On Wed, Mar 07, 2018 at 05:56:41PM +1100, Finn Thain wrote: > In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev > in dma api calls as if it was a pointer to a struct device. But > it actually points to a struct platform_device. Fix this. > > Cc: Thomas Bogendoerfer

Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls

2018-03-09 Thread Tom Bogendoerfer
On Wed, Mar 07, 2018 at 05:56:41PM +1100, Finn Thain wrote: > In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev > in dma api calls as if it was a pointer to a struct device. But > it actually points to a struct platform_device. Fix this. > > Cc: Thomas Bogendoerfer >

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: > I don't know the intricacies of the Mustang hardware but external > aborts have been a symptom of missing clocks on other hardware. you are right, it's a missing clock. For SGMII ports the driver doesn't really use the clock source

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: > I don't know the intricacies of the Mustang hardware but external > aborts have been a symptom of missing clocks on other hardware. you are right, it's a missing clock. For SGMII ports the driver doesn't really use the clock source

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: > This change causes boot failures for me on my APM Mustang system running > Fedora rawhide: > > [ 16.669089] Synchronous External Abort: synchronous external abort > (0x960 > [ 16.669099] Internal error: : 9610 [#1] SMP

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: > This change causes boot failures for me on my APM Mustang system running > Fedora rawhide: > > [ 16.669089] Synchronous External Abort: synchronous external abort > (0x960 > [ 16.669099] Internal error: : 9610 [#1] SMP

Re: [net-next] net: phy: marvell: Show complete link partner advertising

2017-06-13 Thread Tom Bogendoerfer
On Mon, Jun 12, 2017 at 09:05:04AM -0700, Florian Fainelli wrote: > On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > > From: Thomas Bogendoerfer > > > > Give back all modes advertised by the link partner. This change brings > > the marvell phy driver in line with all

Re: [net-next] net: phy: marvell: Show complete link partner advertising

2017-06-13 Thread Tom Bogendoerfer
On Mon, Jun 12, 2017 at 09:05:04AM -0700, Florian Fainelli wrote: > On 06/12/2017 05:54 AM, Thomas Bogendoerfer wrote: > > From: Thomas Bogendoerfer > > > > Give back all modes advertised by the link partner. This change brings > > the marvell phy driver in line with all other phy drivers. > >

Re: [PATCH] Fix returns of some CLK API calls, if !CONFIG_HAVE_CLOCK

2017-04-25 Thread Tom Bogendoerfer
On Tue, Apr 25, 2017 at 05:31:37PM +0100, Russell King - ARM Linux wrote: > On Tue, Apr 25, 2017 at 02:30:07PM +0200, Thomas Bogendoerfer wrote: > > If CONFIG_HAVE_CLOCK is not set, return values of clk_get(), > > devm_clk_get(), devm_get_clk_from_child(), clk_get_parent() > > and clk_get_sys()

Re: [PATCH] Fix returns of some CLK API calls, if !CONFIG_HAVE_CLOCK

2017-04-25 Thread Tom Bogendoerfer
On Tue, Apr 25, 2017 at 05:31:37PM +0100, Russell King - ARM Linux wrote: > On Tue, Apr 25, 2017 at 02:30:07PM +0200, Thomas Bogendoerfer wrote: > > If CONFIG_HAVE_CLOCK is not set, return values of clk_get(), > > devm_clk_get(), devm_get_clk_from_child(), clk_get_parent() > > and clk_get_sys()

Re: [PATCH] m68k/sun3: Fix virtual addresses of clock and interrupt register

2015-09-25 Thread Tom Bogendoerfer
On Fri, Sep 25, 2015 at 09:21:34AM +0200, Geert Uytterhoeven wrote: > On Mon, Sep 14, 2015 at 11:40 AM, Alexander Kuleshov > wrote: > > The MMU base is 32 bits size - 0xfe00, seems that we missed > > one zero in the definition of the clock and interrupt register > > addresses. > > Thanks for

Re: [PATCH] m68k/sun3: Fix virtual addresses of clock and interrupt register

2015-09-25 Thread Tom Bogendoerfer
On Fri, Sep 25, 2015 at 09:21:34AM +0200, Geert Uytterhoeven wrote: > On Mon, Sep 14, 2015 at 11:40 AM, Alexander Kuleshov > wrote: > > The MMU base is 32 bits size - 0xfe00, seems that we missed > > one zero in the definition of the clock and interrupt register > >