-Z
>
> With all of this in mind, lets drop the recursion limit. It has no
> additional security value, anymore. On the contrary, it randomly
> confuses message brokers that try to forward file-descriptors, since
> any sendmsg(2) call can fail spuriously with ETOOMANYREFS if a client
> ma
e x86 simple-framebuffer setup code to use the correct size in the
> non-VBE case.
>
> While at it, avoid variable abbreviations and rename 'len' to 'length',
> and use the correct types matching the screen_info definition.
>
> Signed-off-by: David Herrmann
Rev
ILITY_64BIT_BASE is set, the
> screen_info->ext_lfb_base field will contain the upper 32bit of the
> actual lfb_base. Make sure the address is not 0 (i.e., unset), as well as
> does not overflow the physical address type.
>
> Signed-off-by: David Herrmann
Reviewed-by: To
On Fri, Oct 28, 2016 at 3:58 PM, Peter Zijlstra wrote:
> On Fri, Oct 28, 2016 at 03:47:58PM +0200, Tom Gundersen wrote:
>> On Fri, Oct 28, 2016 at 3:33 PM, Peter Zijlstra wrote:
>> > On Fri, Oct 28, 2016 at 01:33:25PM +0200, Tom Gundersen wrote:
>
>> > And this, pr
On Fri, Oct 28, 2016 at 3:33 PM, Peter Zijlstra wrote:
> On Fri, Oct 28, 2016 at 01:33:25PM +0200, Tom Gundersen wrote:
>> On Thu, Oct 27, 2016 at 6:43 PM, Peter Zijlstra wrote:
>> > On Wed, Oct 26, 2016 at 09:18:02PM +0200, David Herrmann wrote:
>> >
>> >&
On Fri, Oct 28, 2016 at 3:11 PM, Richard Weinberger
wrote:
> On Wed, Oct 26, 2016 at 9:17 PM, David Herrmann wrote:
>> Hi
>>
>> This proposal introduces bus1.ko, a kernel messaging bus. This is not a
>> request
>> for inclusion, yet. It is rather an initial draft and a Request For Comments.
>>
>
On Fri, Oct 28, 2016 at 3:05 PM, Richard Weinberger
wrote:
> On Wed, Oct 26, 2016 at 9:18 PM, David Herrmann wrote:
>> + /* initialize constant fields */
>> + peer->id = atomic64_inc_return(&peer_ids);
>> + peer->flags = 0;
>> + peer->cred = get_cred(current_cred());
>> +
On Fri, Oct 28, 2016 at 2:06 PM, Richard Weinberger
wrote:
> David, Tom,
>
> On Wed, Oct 26, 2016 at 9:18 PM, David Herrmann wrote:
>> +struct bus1_peer *bus1_peer_new(void)
>> +{
>> + static atomic64_t peer_ids = ATOMIC64_INIT(0);
>> + const struct cred *cred = current_cred();
>> +
On Thu, Oct 27, 2016 at 6:43 PM, Peter Zijlstra wrote:
> On Wed, Oct 26, 2016 at 09:18:02PM +0200, David Herrmann wrote:
>
>> A bus1 message queue is a FIFO, i.e., messages are linearly ordered by
>> the time they were sent. Moreover, atomic delivery of messages to
>> multiple queues are supported
On Thu, Oct 27, 2016 at 6:37 PM, Linus Torvalds
wrote:
> On Thu, Oct 27, 2016 at 8:25 AM, Tom Gundersen wrote:
>>
>> Could you elaborate on why you think syscalls would be more
>> appropriate than ioctls?
>
> ioctl's tend to be a horrid mess both for things like c
On Thu, Oct 27, 2016 at 11:11 AM, Arnd Bergmann wrote:
> On Thursday, October 27, 2016 1:54:05 AM CEST Tom Gundersen wrote:
>> On Thu, Oct 27, 2016 at 1:19 AM, Andy Lutomirski wrote:
>> > This may have been covered elsewhere, but could this use syscalls instead?
>>
>
On Thu, Oct 27, 2016 at 1:19 AM, Andy Lutomirski wrote:
> This may have been covered elsewhere, but could this use syscalls instead?
Yes, syscalls would work essentially the same. For now, we are using a
cdev as it makes it a lot more convenient to develop and test as an
out-of-tree module, but t
On Tue, Jul 7, 2015 at 1:23 AM, Luis R. Rodriguez wrote:
> On Sat, Jul 04, 2015 at 07:09:19AM -0700, Dan Williams wrote:
>> On Fri, Jul 3, 2015 at 11:30 AM, Luis R. Rodriguez wrote:
>> > On Sat, Jun 27, 2015 at 04:45:25PM -0700, Dan Williams wrote:
>> >> On Mon, Mar 30, 2015 at 4:20 PM, Dmitry To
On Fri, Jun 26, 2015 at 9:33 PM, Andy Lutomirski wrote:
> What's a good distro on which to poke at a full running system?
Fedora Rawhide is probably currently your best bet.
> Fedora Rawhide seems to still build systemd with --disable-kdbus,
> although I suppose that means that I could boot it w
This policy used to be unconditionally applied by udev, but there
is no reason to make userspace be involved in this and in the future
udev will not be doing it by default.
See: <https://github.com/systemd/systemd/pull/353>.
Signed-off-by: Tom Gundersen
Cc: Jiri Kosina
Cc: Greg Kroah-H
On 04/15/2015 10:22 PM, Andy Lutomirski wrote:
> On Wed, Apr 15, 2015 at 9:44 AM, Havoc Pennington wrote:
>> That is, with dbus if I send a broadcast message, then send a unicast
>> request to another client, then drop the connection causing the bus to
>> broadcast that I've dropped; then the othe
On Wed, Apr 15, 2015 at 2:09 PM, Jiri Kosina wrote:
> On Wed, 15 Apr 2015, Greg Kroah-Hartman wrote:
>
>> 'systemctl reboot' calls a bunch of other things to determine if you
>> have local access to the machine, or permissions to reboot the machine
>> (i.e. CAP_SYS_BOOT), and other things that pol
On Tue, Mar 31, 2015 at 3:58 PM, Andy Lutomirski wrote:
> On Mon, Mar 30, 2015 at 9:56 AM, David Herrmann wrote:
>> Hi
>>
>> On Wed, Mar 25, 2015 at 7:12 PM, Andy Lutomirski wrote:
>>> On Wed, Mar 25, 2015 at 10:29 AM, David Herrmann
>>> wrote:
>> [...]
> I could be wrong about the lack of
renamed,
so userspace needs to be able to reliably tell the difference.
Similar functionality was introduced for the rtnetlink core in commit 5517750.
Signed-off-by: Tom Gundersen
Cc: Kalle Valo
Cc: Brett Rudley
Cc: Arend van Spriel
Cc: Franky (Zhenhui) Lin
Cc: Hante Meuleman
Cc: Johannes
Hi Michael,
On Mon, Jan 26, 2015 at 3:42 PM, Michael Kerrisk (man-pages)
wrote:
> 2. Is the API to be invoked directly by applications or is intended to
>be used only behind specific libraries? You seem to be saying that
>the latter is the case (here, I'm referring to your comment above
>
Hi Martin,
On Sat, Nov 1, 2014 at 6:51 PM, Martin Mares wrote:
> The support for hwdb has finally landed in mainline pciutils.
>
> I have modified your patch to bring it closer to the rest of device
> naming logic. Namely:
Great! Thanks for merging this, and for working on it.
> Aside of the RE
On 10/30/2014 12:55 AM, Andy Lutomirski wrote:> It's worth noting that:
>
> - Proper credential passing could be added to UNIX sockets, and we
> may want to do that anyway. Also, the current kdbus semantics seem to
> be "spew lots of credentials and other miscellaneous
> potentially-sensitive and
On Thu, Oct 30, 2014 at 9:20 AM, Arnd Bergmann wrote:
> I think in general, using enum is great, but for ioctl command numbers,
> we probably want to have defines so the user space implementation can
> use #ifdef to see if the kernel version that it is being built for
> knows a particular command.
Hi Eric,
On Thu, Oct 30, 2014 at 5:20 AM, Eric W. Biederman
wrote:
> The userspace API breaks userspace in an unfixable way.
>
> Nacked-by: "Eric W. Biederman"
>
> Problem the first.
> - Using global names for containers makes it impossible to create
> unprivileged containers.
I don't follow.
On Fri, Oct 10, 2014 at 11:54 PM, Anatol Pomozov
wrote:
> 1) Why not to make the timeout configurable through config file? There
> is already udev.conf you can put config option there. Thus people with
> modprobe issues can easily "fix" the problem. And then decrease
> default timeout back to 30 s
On Thu, Oct 2, 2014 at 10:06 PM, Luis R. Rodriguez wrote:
> On Thu, Oct 02, 2014 at 08:12:37AM +0200, Tom Gundersen wrote:
>> Making kmod a special case is of course possible. However, as long as
>> there is no fundamental reason why kmod should get this special
>> treatment,
On Tue, Sep 30, 2014 at 5:24 PM, Luis R. Rodriguez wrote:
>> > commit e64fae5573e566ce4fd9b23c68ac8f3096603314
>> > Author: Kay Sievers
>> > Date: Wed Jan 18 05:06:18 2012 +0100
>> >
>> > udevd: kill hanging event processes after 30 seconds
>> >
>> > Some broken kernel drivers load firm
On Tue, Sep 30, 2014 at 4:27 AM, Luis R. Rodriguez wrote:
> On Sun, Sep 28, 2014 at 07:07:24PM +0200, Tom Gundersen wrote:
>> On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez
>> wrote:
>> > From: "Luis R. Rodriguez"
>> > Systemd has a general t
Hi Luis,
Thanks for the patches and the detailed analysis.
Feel free to add
Acked-by: Tom Gundersen
Minor comments on the commit message below.
On Fri, Sep 26, 2014 at 11:57 PM, Luis R. Rodriguez
wrote:
> From: "Luis R. Rodriguez"
>
> Some init systems may wish to ex
On Fri, Sep 12, 2014 at 12:26 AM, Luis R. Rodriguez
wrote:
> On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen wrote:
>> How about simply introducing a new flag to finit_module() to indicate
>> that the caller does not care about asynchronicity. We could then pass
>> this fr
On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez
wrote:
>>> More than two years
>>> have gone by on growing design and assumptions on top of that original
>>> commit. I'm not sure if *systemd folks* yet believe its was a design
>>> regression?
>>
>> I don't think so. udev should not allow its w
On Tue, Sep 9, 2014 at 10:45 PM, Luis R. Rodriguez
wrote:
> On Tue, Sep 9, 2014 at 12:35 PM, James Bottomley
> wrote:
>> On Tue, 2014-09-09 at 12:16 -0700, Luis R. Rodriguez wrote:
>>> On Mon, Sep 8, 2014 at 10:38 PM, James Bottomley
>>> wrote:
>>> > If we want to sort out some sync/async mechan
On Tue, Sep 9, 2014 at 3:26 AM, Luis R. Rodriguez
wrote:
> On Mon, Sep 8, 2014 at 6:22 PM, Tejun Heo wrote:
>> On Tue, Sep 09, 2014 at 10:10:59AM +0900, Tejun Heo wrote:
>>> I'm not too convinced this is such a difficult problem to figure out.
>>> We already have most of logic in place and the on
On Tue, Aug 26, 2014 at 7:14 PM, Luis R. Rodriguez wrote:
> On Tue, Aug 26, 2014 at 07:09:46PM +0200, Luis R. Rodriguez wrote:
>> When Christian tried removing the udev firmware loader
>> it was detected that the Dell rbu driver still required
>> use of FW_LOADER_USER_HELPER [0]. This driver neede
On Tue, Aug 12, 2014 at 10:29 AM, Dexuan Cui wrote:
>> From: Tom Gundersen
>> > Unluckily this logic doesn't work because the user-space daemons
>> > like ifplugd, usually don't renew the DHCP immediately as long as they
>> > receive a link-down message
On Mon, Aug 11, 2014 at 5:23 AM, Dexuan Cui wrote:
>> -Original Message-
>> From: Greg KH [mailto:gre...@linuxfoundation.org]
>> > > >
>> > > > IMO the most feasible and need-the-least-change solution may be:
>> > > > the hyperv network VSC driver passes the event
>> > > > RNDIS_STATUS_NET
Hi Johannes,
On Mon, Jul 21, 2014 at 11:40 AM, Johannes Berg
wrote:
> On Thu, 2014-07-10 at 10:17 +0200, Tom Gundersen wrote:
>> Pass the value down and set it at the same place the name itself is set.
>
> Is this going to be applied as part of one bigger series?
This patch i
On Mon, Jul 21, 2014 at 12:21 PM, Yue Zhang (OSTC DEV)
wrote:
>> From: Tom Gundersen [mailto:t...@jklm.no]
>> Sent: Monday, July 21, 2014 5:42 PM
>>
>> On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote:
>> > From: Yue Zhang
>> >
>> > This patch
On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote:
> From: Yue Zhang
>
> This patch addresses the comment from Olaf Hering and Greg KH
> for a previous commit 3a494e710367 ("hyperv: Add handler for
> RNDIS_STATUS_NETWORK_CHANGE event")
>
> In previous solution, the driver calls "network restart"
On Fri, Jul 18, 2014 at 1:20 AM, David Miller wrote:
> From: Tom Gundersen
> Date: Thu, 17 Jul 2014 10:06:05 +0200
>
>> @@ -2787,10 +2788,13 @@ static int gsm_create_network(struct gsm_dlci *dlci,
>> struct gsm_netconfig *nc)
>> pr_debug("create network
On Fri, Jul 18, 2014 at 1:19 AM, David Miller wrote:
> From: Tom Gundersen
> Date: Thu, 17 Jul 2014 10:06:04 +0200
>
>> @@ -192,8 +193,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct
>> genl_info *info)
>> if (devname[nla_len(info->attrs[
On Thu, Jul 17, 2014 at 11:04 AM, Johannes Berg
wrote:
> On Thu, 2014-07-17 at 10:06 +0200, Tom Gundersen wrote:
>> Pass the value down and set it at the same place the name itself is set.
>
> Huh? What's this? Can you explain why?
Sure, sorry the context got lost.
We want
Signed-off-by: Tom Gundersen
Acked-by: Alexander Aring
Cc: Dmitry Eremin-Solenikov
Cc: linux-zigbee-de...@lists.sourceforge.net
---
include/net/wpan-phy.h | 4 +++-
net/ieee802154/nl-phy.c| 5 -
net/mac802154/ieee802154_dev.c | 7 ---
3 files changed, 11 insertions
When the user provides a name, set NET_NAME_USER, otherwise an enumerated
name is used, so set NET_NAME_ENUM.
Signed-off-by: Tom Gundersen
---
drivers/net/tun.c | 9 ++---
drivers/tty/n_gsm.c | 10 +++---
net/atm/br2684.c | 5 +++--
net/bluetooth/bnep/core.c
Signed-off-by: Tom Gundersen
Cc: Jay Vosburgh
Cc: Veaceslav Falico
Cc: Andy Gospodarek
---
drivers/net/bonding/bond_main.c | 7 ---
drivers/net/bonding/bond_sysfs.c | 2 +-
drivers/net/bonding/bonding.h| 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net
label
it NET_NAME_USER.
Signed-off-by: Tom Gundersen
Cc: Paul Mackerras
Cc: linux-...@vger.kernel.org
---
drivers/net/ppp/ppp_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index c38ee90..6526057 100644
--- a/drivers/net
Signed-off-by: Tom Gundersen
Cc: Karsten Keil
---
drivers/isdn/i4l/isdn_common.c | 4 ++--
drivers/isdn/i4l/isdn_net.c| 10 +-
drivers/isdn/i4l/isdn_net.h| 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l
When deriving the name from the real device, inherit the assign type, otherwise
set PREDICTABLE as the name will be uniquely determined by the VLANID.
Signed-off-by: Tom Gundersen
Cc: Patrick McHardy
---
net/8021q/vlan.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a
Pass the value down and set it at the same place the name itself is set.
Signed-off-by: Tom Gundersen
Cc: Johannes Berg
Cc: John Linville
---
drivers/net/wireless/ath/ath6kl/cfg80211.c| 6 --
drivers/net/wireless/ath/ath6kl/cfg80211.h| 1 +
drivers/net/wireless
Signed-off-by: Tom Gundersen
Cc: Pravin Shelar
Cc: d...@openvswitch.org
---
v9: set NET_NAME_USER directly in internal_dev_create as requested by Pravin
Shelar
net/openvswitch/vport-internal_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/vport
a problem) the correct name assign type
Patch 4:do the same for devices created via ioctls
Patch 5-9: cover a few individual drivers
More individual drivers will be converted in a follow-up series.
Tom Gundersen (9):
net: set name assign type for names assigned using a static st
This covers the trivial case:
alloc_netdev(_, "bar", NET_NAME_PREDICTABLE, _);
Signed-off-by: Tom Gundersen
---
drivers/media/dvb-core/dvb_net.c | 2 +-
drivers/misc/sgi-xp/xpnet.c | 2 +-
drivers/net/caif/caif_virtio.c | 2 +-
drivers/net/eql.c| 4 ++--
d
On Thu, Jul 17, 2014 at 9:26 AM, Veaceslav Falico wrote:
> On Thu, Jul 17, 2014 at 09:17:07AM +0200, Tom Gundersen wrote:
>>
>> On Thu, Jul 17, 2014 at 8:56 AM, David Miller wrote:
>>>
>>> Tom, even if the patches are sort of independent, they logically
>&
On Thu, Jul 17, 2014 at 8:56 AM, David Miller wrote:
> Tom, even if the patches are sort of independent, they logically
> belong together.
>
> So please number them, and provide an appropriate "[PATCH 0/N] ..."
> cover letter.
>
> Please resubmit these patches with that done properly, thank you.
On Thu, Jul 17, 2014 at 1:00 AM, Pravin Shelar wrote:
> On Wed, Jul 16, 2014 at 3:43 PM, Tom Gundersen wrote:
>> Signed-off-by: Tom Gundersen
>> Cc: Pravin Shelar
>> Cc: d...@openvswitch.org
>> ---
>>
>> This patch goes on top of net-next.
>>
Signed-off-by: Tom Gundersen
Acked-by: Alexander Aring
Cc: Dmitry Eremin-Solenikov
Cc: linux-zigbee-de...@lists.sourceforge.net
---
This patch goes on top of net-next.
include/net/wpan-phy.h | 4 +++-
net/ieee802154/nl-phy.c| 5 -
net/mac802154/ieee802154_dev.c | 7
label
it NET_NAME_USER.
Signed-off-by: Tom Gundersen
Cc: Paul Mackerras
Cc: linux-...@vger.kernel.org
---
This patch goes on top of net-next.
drivers/net/ppp/ppp_generic.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index
Pass the value down and set it at the same place the name itself is set.
Signed-off-by: Tom Gundersen
Cc: Johannes Berg
Cc: John Linville
---
This patch goes on top of net-next.
drivers/net/wireless/ath/ath6kl/cfg80211.c| 6 --
drivers/net/wireless/ath/ath6kl/cfg80211.h
Signed-off-by: Tom Gundersen
Cc: Pravin Shelar
Cc: d...@openvswitch.org
---
This patch goes on top of net-next.
net/openvswitch/datapath.c | 1 +
net/openvswitch/vport-internal_dev.c | 2 +-
net/openvswitch/vport.h | 2 ++
3 files changed, 4 insertions(+), 1 deletion
When deriving the name from the real device, inherit the assign type, otherwise
set PREDICTABLE as the name will be uniquely determined by the VLANID.
Signed-off-by: Tom Gundersen
Cc: Patrick McHardy
---
This patch goes on top of net-next.
net/8021q/vlan.c | 7 ++-
1 file changed, 6
Signed-off-by: Tom Gundersen
Cc: Karsten Keil
---
This patch goes on top of net-next.
drivers/isdn/i4l/isdn_common.c | 4 ++--
drivers/isdn/i4l/isdn_net.c| 10 +-
drivers/isdn/i4l/isdn_net.h| 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/isdn
This covers the trivial case:
alloc_netdev(_, "bar", NET_NAME_PREDICTABLE, _);
Signed-off-by: Tom Gundersen
---
This patch goes on top of net-next.
drivers/media/dvb-core/dvb_net.c | 2 +-
drivers/misc/sgi-xp/xpnet.c | 2 +-
drivers/net/caif/caif_virtio.c | 2 +-
drivers
l resubmit this patch once the earlier patches introducing the
infrastructure have been applied.
Cheers,
Tom
[0]: <https://lkml.org/lkml/2014/7/10/94>.
> On Thu, Jul 10, 2014 at 10:17:34AM +0200, Tom Gundersen wrote:
>> The name is given by the firmware, so we assume it is predic
This passes down NET_NAME_USER (or NET_NAME_ENUM) to alloc_netdev(),
for any device created over rtnetlink.
v9: restore reverse-christmas-tree order of local variables
Signed-off-by: Tom Gundersen
---
drivers/net/veth.c | 11 ---
include/net/rtnetlink.h | 1 +
net/core
minor documentation fixes
v9: move comment to the right commit
Signed-off-by: Tom Gundersen
Reviewed-by: David Herrmann
Reviewed-by: Kay Sievers
---
Documentation/ABI/testing/sysfs-class-net | 11 +++
include/linux/netdevice.h | 2 ++
include/uapi/linux/netdev
Based on a patch from David Herrmann.
This is the only place devices can be renamed.
v9: restore revers-christmas-tree order of local variables
Signed-off-by: Tom Gundersen
Reviewed-by: David Herrmann
---
net/core/dev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/net/core
This passes down NET_NAME_USER (or NET_NAME_ENUM) to alloc_netdev(),
for any device created over rtnetlink.
Signed-off-by: Tom Gundersen
---
drivers/net/veth.c | 11 ---
include/net/rtnetlink.h | 1 +
net/core/rtnetlink.c| 12
3 files changed, 17 insertions(+), 7
assign type as an argument.
- introduce an internal assign type NET_NAME_UNKNOWN, which makes
it simpler to split up the patches, but may eventually be dropped.
- introduce a new assign type NET_NAME_PREDICTABLE to indicate to
userspace that the kernel-assigned names are well-behaved.
Tom
ff-by: Tom Gundersen
Reviewed-by: David Herrmann
Reviewed-by: Kay Sievers
v8: minor documentation fixes
---
Documentation/ABI/testing/sysfs-class-net | 11 +++
include/linux/netdevice.h | 2 ++
include/uapi/linux/netdevice.h| 6 ++
net/core/
Based on a patch from David Herrmann.
This is the only place devices can be renamed.
Signed-off-by: Tom Gundersen
Reviewed-by: David Herrmann
---
net/core/dev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 392c784..5d7b2a6 100644
--- a/net
On Thu, Jul 10, 2014 at 10:08 PM, Arend van Spriel wrote:
> On 10-07-14 10:17, Tom Gundersen wrote:
>> The name is given by the firmware, so we assume it is predictable.
>
> How about the scenario where one would have multiple broadcom wifi
> devices in the system. Both driv
On Thu, Jul 10, 2014 at 9:58 PM, Arend van Spriel wrote:
> On 10-07-14 10:17, Tom Gundersen wrote:
>> Based on a patch by David Herrmann.
>>
>> The name_assign_type attribute gives hints where the interface name of a
>> given net-device comes from. These v
On Thu, Jul 10, 2014 at 5:53 PM, Nicolas Dichtel
wrote:
> Le 10/07/2014 10:17, Tom Gundersen a écrit :
>
>> Based on a patch by David Herrmann.
>>
>> The name_assign_type attribute gives hints where the interface name of a
>> given net-device comes from. Thes
On Thu, Jul 10, 2014 at 11:19 AM, Tom Gundersen wrote:
> Thanks for the quick answer.
>
> On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote:
>> It is not reasonable to expect people to review such a large number of
>> patches at one time.
>>
>> Split your
On Thu, Jul 10, 2014 at 1:29 PM, Bjørn Mork wrote:
> Tom Gundersen writes:
>> On Thu, Jul 10, 2014 at 11:16 AM, Bjørn Mork wrote:
>>> Tom Gundersen writes:
>>>
>>>> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
>>>> index 5dc638c..f405
On Thu, Jul 10, 2014 at 1:44 PM, Bjørn Mork wrote:
> Tom Gundersen writes:
>
>> The result of
>>
>> modprobe dummy numdummies=2
>>
>> is to create dummy0 and dummy1, always with the same names.
>>
>> The result of
>>
>> ip link add t
On Thu, Jul 10, 2014 at 11:01 AM, Ian Campbell wrote:
> On Thu, 2014-07-10 at 10:17 +0200, Tom Gundersen wrote:
>> The name contains then xen handle, which is not guaranteed to be
>> stable between restarts, so label this NET_NAME_ENUM.
>
> FWIW the N'th interface fo
On Thu, Jul 10, 2014 at 12:26 PM, David Herrmann wrote:
> Hi
>
>>> The same goes for NET_NAME_USER and NET_NAME_RENAMED. These are the same
>>> from a kernel point of view.
>>
>> You mean to collapse the two, and just label renamed interfaces
>> NET_NAME_USER instead?
>
> I have no real objections
On Thu, Jul 10, 2014 at 11:16 AM, Bjørn Mork wrote:
> Tom Gundersen writes:
>
>> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
>> index 5dc638c..f405e05 100644
>> --- a/net/ethernet/eth.c
>> +++ b/net/ethernet/eth.c
>> @@ -390,7 +390,8 @@ EXPORT_SYMBOL
On Thu, Jul 10, 2014 at 11:31 AM, Bjørn Mork wrote:
> Tom Gundersen writes:
>
>> A fixed number of indistinguishable dummy devices are allocated at module
>> init time,
>> the names are therefore PREDICTABLE rather than ENUM.
>
> OK? So if I go do
>
> mo
Thanks for the quick answer.
On Thu, Jul 10, 2014 at 10:43 AM, David Miller wrote:
> It is not reasonable to expect people to review such a large number of
> patches at one time.
>
> Split your series up into logical, and more reasonably sized chunks.
>
> I'd say 14 or 15 at a time is the limit.
Based on a patch from David Herrmann.
This is the only place devices can be renamed.
Signed-off-by: Tom Gundersen
Reviewed-by: David Herrmann
---
net/core/dev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 30eedf6..7765ec5 100644
--- a/net
This covers the trivial case:
alloc_netdev(_, "foo%d", NET_NAME_ENUM, _);
Signed-off-by: Tom Gundersen
---
drivers/firewire/net.c| 2 +-
drivers/hsi/clients/ssi_protocol.c| 3 ++-
drivers/net/caif/caif_spi.c | 4 ++--
drivers/net
This covers the trivial case:
alloc_netdev(_, "bar", NET_NAME_PREDICTABLE, _);
Signed-off-by: Tom Gundersen
---
drivers/media/dvb-core/dvb_net.c | 2 +-
drivers/misc/sgi-xp/xpnet.c | 2 +-
drivers/net/caif/caif_virtio.c | 2 +-
drivers/net/eql.c| 4 ++--
d
Signed-off-by: Tom Gundersen
Cc: Dmitry Eremin-Solenikov
Cc: linux-zigbee-de...@lists.sourceforge.net
---
include/net/wpan-phy.h | 4 +++-
net/ieee802154/nl-phy.c| 5 -
net/mac802154/ieee802154_dev.c | 7 ---
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git
A fixed number of indistinguishable dummy devices are allocated at module init
time,
the names are therefore PREDICTABLE rather than ENUM.
Signed-off-by: Tom Gundersen
Cc: dingtianhong
Cc: Tan Xiaojun
Cc: WANG Cong
---
drivers/net/dummy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Pass the value down and set it at the same place the name itself is set.
Signed-off-by: Tom Gundersen
Cc: Johannes Berg
Cc: John Linville
---
drivers/net/wireless/ath/ath6kl/cfg80211.c| 6 --
drivers/net/wireless/ath/ath6kl/cfg80211.h| 1 +
drivers/net/wireless
A given number of indistinguishable interfaces are allocated at init time, so
consider their names predictable.
Signed-off-by: Tom Gundersen
Cc: linux-h...@vger.kernel.org
---
net/rose/af_rose.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rose/af_rose.c b/net/rose
A given number of indistinguishable interfaces are allocated at init time, so
consider their names predictable.
Signed-off-by: Tom Gundersen
Cc: Ralf Baechle
Cc: linux-h...@vger.kernel.org
---
net/netrom/af_netrom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netrom
Signed-off-by: Tom Gundersen
---
drivers/net/veth.c | 11 ---
include/net/rtnetlink.h | 1 +
net/core/rtnetlink.c| 12
3 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index b4a10bc..5058700 100644
--- a
The name is uniquely determined by the name of the TTY.
Signed-off-by: Tom Gundersen
Cc: Dmitry Tarnyagin
---
drivers/net/caif/caif_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/caif/caif_serial.c b/drivers/net/caif/caif_serial.c
index 27bbc56
We have one device per routing table, so the naming is predictable.
Signed-off-by: Tom Gundersen
Cc: Alexey Kuznetsov
Cc: James Morris
Cc: Hideaki YOSHIFUJI
Cc: Patrick McHardy
---
net/ipv4/ipmr.c | 2 +-
net/ipv6/ip6mr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
alloc_netdev is first called without a name, before the name and name assign
type is open-coded later.
Signed-off-by: Tom Gundersen
Cc: John Linville
Cc: linux-wirel...@vger.kernel.org
---
drivers/net/wireless/airo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless
Devices are named according to the scheme lteXpdnY, where Y is the
nic type, and X is the normal enumeration, so the scheme is NET_NAME_ENUM.
Signed-off-by: Tom Gundersen
Cc: Greg Kroah-Hartman
Cc: Won Kang
Cc: Rashika Kheria
Cc: de...@driverdev.osuosl.org
---
drivers/staging/gdm724x
The name contains then xen handle, which is not guaranteed to be
stable between restarts, so label this NET_NAME_ENUM.
Signed-off-by: Tom Gundersen
Cc: Ian Campbell
Cc: Wei Liu
Cc: xen-de...@lists.xenproject.org
---
drivers/net/xen-netback/interface.c | 4 ++--
1 file changed, 2 insertions
Signed-off-by: Tom Gundersen
Cc: Marek Lindner
Cc: Simon Wunderlich
Cc: Antonio Quartulli
Cc: b.a.t.m@lists.open-mesh.org
---
net/batman-adv/hard-interface.c | 5 +++--
net/batman-adv/hard-interface.h | 3 ++-
net/batman-adv/soft-interface.c | 9 ++---
net/batman-adv/soft-interface.h
Let the drivers pass in the name assign type. They all get the name as a module
parameter.
Signed-off-by: Tom Gundersen
Cc: Dan Carpenter
Cc: Paul Gortmaker
---
drivers/net/arcnet/arc-rimi.c | 2 +-
drivers/net/arcnet/arcnet.c | 8 ++--
drivers/net/arcnet/com20020-isa.c | 2
The hamradio devices are created the same way with the same names on module
init time so should therefore be PREDICTABLE rather than ENUM.
Signed-off-by: Tom Gundersen
Cc: Thomas Sailer
Cc: Joerg Reuter
Cc: Jean-Paul Roubelat
Cc: Wenliang Fan
Cc: linux-h...@vger.kernel.org
---
drivers/net
Signed-off-by: Tom Gundersen
Cc: Samuel Ortiz
Cc: Dragos Foianu
---
include/net/irda/irlan_eth.h | 2 +-
net/irda/irlan/irlan_common.c | 2 +-
net/irda/irlan/irlan_eth.c| 7 ---
3 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/include/net/irda/irlan_eth.h b/include/net
Signed-off-by: Tom Gundersen
Cc: Karsten Keil
---
drivers/isdn/i4l/isdn_common.c | 4 ++--
drivers/isdn/i4l/isdn_net.c| 10 +-
drivers/isdn/i4l/isdn_net.h| 4 ++--
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/isdn/i4l/isdn_common.c b/drivers/isdn/i4l
1 - 100 of 197 matches
Mail list logo
