[char-misc-next] mei: me: add Alder Lake P device id.

2021-04-13 Thread Tomas Winkler
Add Alder Lake P device ID. Cc: Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index 14be76d4c2e6..cb34925e10f1 100644

[PATCH v3] mtd: intel-spi: add is_protected and is_bios_locked knobs

2021-04-11 Thread Tomas Winkler
as the manufacturing will need the both files in order to validate that the device is properly sealed. Cc: Joe Perches Cc: Mika Westerberg Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler Reviewed-by: Mika Westerberg --- V2: Add a newline to the string format in sysfs_emit() (Joe Perches ) V3

[PATCH v6] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

2021-04-11 Thread Tomas Winkler
PCHs. Cc: Hans de Goede Cc: David E Box Reviewed-by: Andy Shevchenko Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend v4: 1. Fix return statement (Andy) 2. Specify manufacturing

[PATCH v5] platform/x86: intel_pmc_core: export platform global reset bits via etr3 sysfs file

2021-04-11 Thread Tomas Winkler
PCHs. Cc: Hans de Goede Cc: David E Box Reviewed-by: Andy Shevchenko Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend v4: 1. Fix return statement (Andy) 2. Specify manufacturing

[PATCH v4] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler --- 2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend v4: 1. Fix return statement (Andy) 2. Specify manufacturing process (Enrico) .../ABI/testing/sysfs-platform-intel-pmc | 11

[PATCH v3] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) V3: 1. Resend .../ABI/testing/sysfs-platform-intel-pmc | 11 +++ MAINTAINERS | 1 + drivers/platform/x86/intel_pmc_core.c | 97

[PATCH v2] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-02 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- V2: 1. Add locking for reading the ET3 register (Andy) 2. Fix few style issues (Andy) .../ABI/testing/sysfs-platform-intel-pmc | 11 +++ MAINTAINERS | 1 + drivers/platform/x86/intel_pmc_core.c | 95

[PATCH] platform/x86: intel_pmc_core: export platform global_reset via sysfs.

2021-04-01 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- .../ABI/testing/sysfs-platform-intel-pmc | 11 +++ MAINTAINERS | 1 + drivers/platform/x86/intel_pmc_core.c | 95 +++ drivers/platform/x86/intel_pmc_core.h | 6 ++ 4 files changed, 113

[PATCH v2] mtd: intel-spi: add is_protected and is_bios_locked knobs

2021-03-31 Thread Tomas Winkler
as the manufacturing will need the both files in order to validate that the device is properly sealed. Cc: Joe Perches Cc: Mika Westerberg Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler Reviewed-by: Mika Westerberg --- V2: Add a newline to the string format in sysfs_emit() (Joe Perches

[PATCH] mtd: intel-spi: add is_protected and is_bios_locked knobs

2021-03-30 Thread Tomas Winkler
as the manufacturing will need the both files in order to validate that the device is properly sealed. Cc: Mika Westerberg Signed-off-by: Tamar Mashiah Signed-off-by: Tomas Winkler Reviewed-by: Mika Westerberg --- .../ABI/testing/sysfs-devices-intel-spi | 16 MAINTAINERS

[char-misc-next] mei: allow map and unmap of client dma buffer only for disconnected client

2021-03-18 Thread Tomas Winkler
Allow map and unmap of the client dma buffer only when the client is not connected. The functions return -EPROTO if the client is already connected. This is to fix the race when traffic may start or stop when buffer is not available. Cc: #v5.11+ Signed-off-by: Tomas Winkler --- drivers/misc

[PATCH] mtd: mtdcore: constify name param in mtd_bdi_init

2021-02-25 Thread Tomas Winkler
The bdi name is not modified by the function, it should be const. Signed-off-by: Tomas Winkler --- drivers/mtd/mtdcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index db5167eacaa4..80fb69453ebe 100644 --- a/drivers/mtd

[char-misc-next 2/2] mei: use sysfs_emit() in tx_queue_limit_show sysfs

2021-02-08 Thread Tomas Winkler
Using of snprintf is discouraged in sysfs use the new sysfs_emit() API. Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 9f6682033ed7..28937b6e7e0c 100644

[char-misc-next 1/2] mei: bus: block send with vtag on non-conformat FW

2021-02-08 Thread Tomas Winkler
From: Alexander Usyskin Block data send with vtag if either transport layer or FW client are not supporting vtags. Cc: # v5.10+ Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc

[char-misc-next 6/6] mei: bus: add client dma interface

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Expose the client dma mapping via mei client bus interface. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 46 ++ drivers/misc/mei/hw.h | 5 + include/linux/mei_cl_bus.h | 3

[char-misc-next 3/6] mei: add support for client dma capability

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Client DMA capability indicates whether the firmware supports setting up a direct DMA channel between the host and me client. The DMA capabilities are supported from firmware HBM version 2.2 and newer. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler

[char-misc-next 5/6] mei: implement client dma setup.

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Implement HBM message protocol to setup and tear down DMA buffer on behalf of an client. On top there DMA buffer allocation and its life time management. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c| 286

[char-misc-next 4/6] mei: hbm: add client dma hbm messages

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Define structures for client DMA HBM protocol. The protocol requires passing dma buffer address and the buffer id. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 53 +++ 1 file changed

[char-misc-next 2/6] mei: allow clients on bus to communicate in remove callback

2021-02-06 Thread Tomas Winkler
From: Alexander Usyskin Introduce new intermediate state to allow the clients on the bus to communicate with the firmware from the remove handler. This is to enable to perform a clean shutdown. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6

[char-misc-next 1/6] mei: use sprintf in tx_queue_limit_show sysfs

2021-02-06 Thread Tomas Winkler
Using of snprintf is discouraged in sysfs. For simple u8 it is safe to use sprintf. Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 9f6682033ed7..24a05f45b639

[PATCH] mtd: use refcount to prevent corruption

2021-01-27 Thread Tomas Winkler
When underlying device is removed mtd core will crash in case user space is still holding an open handle to a mtd device node. A proper refcounting is needed so device is release only when a partition has no active users. The current simple counter is not sufficient. Signed-off-by: Tomas Winkler

[watchdog v2] watchdog: mei_wdt: request stop on unregister

2021-01-24 Thread Tomas Winkler
-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: Update the commit message with better explanation drivers/watchdog/mei_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c index 5391bf3e6b11..c5967d8b4256 100644 --- a/drivers

[watchdog] watchdog: mei_wdt: request stop on unregister

2021-01-07 Thread Tomas Winkler
From: Alexander Usyskin Send the stop command to the firmware on watchdog unregister to eleminate false event on suspend. Cc: Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/watchdog/mei_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/watchdog

[char-misc-next 2/2] mei: bus: enable pavp device.

2020-11-16 Thread Tomas Winkler
Enable protected audio video path client on mei client bus. Cc: Sean Z Huang Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 6cc3145bb716..d8e760b11ae3 100644

[char-misc-next 1/2] mei: bus: add vtag support

2020-11-16 Thread Tomas Winkler
Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 13 +++-- drivers/misc/mei/bus.c | 101 +-- drivers/misc/mei/client.c| 6 ++- drivers/misc/mei/mei_dev.h | 4 +- include/linux/mei_cl_bus.h | 6 +++ 5 files changed, 104

[char-misc-next 3/3] mei: bus: deinitialize callback functions on init failure

2020-10-29 Thread Tomas Winkler
-by: Tomas Winkler --- drivers/misc/mei/bus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c index 1a54bf3ed0c3..76aa0e93748a 100644 --- a/drivers/misc/mei/bus.c +++ b/drivers/misc/mei/bus.c @@ -370,8 +370,11 @@ int

[char-misc-next 0/3] mei: bus: null derefence in rx

2020-10-29 Thread Tomas Winkler
Fix race in receive callback for drivers on me client bus, that results in null dereferencing and improve the error handling. The first patch 'mei: protect mei_cl_mtu from null dereference' itself is sufficient to prevent the failure and is intended for stable. Alexander Usyskin (3): mei:

[char-misc-next 2/3] mei: bus: do not start a read for disconnected clients

2020-10-29 Thread Tomas Winkler
From: Alexander Usyskin Avoid queuing reads and registering rx callbacks in case the client is not connected, to prevent null dereferencing and memory leaks. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 8 ++-- 1 file changed, 6 insertions

[char-misc-next 1/3] mei: protect mei_cl_mtu from null dereference

2020-10-29 Thread Tomas Winkler
ned-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/client.h b/drivers/misc/mei/client.h index 64143d4ec758..9e08a9843bba 100644 --- a/drivers/misc/mei/client.h +++ b/driv

[char-misc-next 08/13] mei: handle tx queue flushing for vtag connections

2020-08-18 Thread Tomas Winkler
. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 3904fce18261..d5c3f7d54634 100644 --- a/drivers

[char-misc-next 04/13] mei: add support for mei extended header.

2020-08-18 Thread Tomas Winkler
only supported extension is the vtag. From the HW perspective the extended headers is already part of the payload. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/misc/mei/client.c| 189 --- drivers/misc/mei/hbm.c | 14

[char-misc-next 06/13] mei: add a spin lock to protect rd_completed queue

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin In order to support vtags we need to access read completed queue out of driver big lock. Add a spin lock to protect rd_completed queue. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 6 ++--- drivers/misc/mei/client.c

[char-misc-next 10/13] mei: bus: unconditionally enable clients with vtag support

2020-08-18 Thread Tomas Winkler
-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 07ba16d46690..4e30fa98fe7d 100644 --- a/drivers/misc/mei/bus-fixup.c +++ b/drivers/misc/mei

[char-misc-next 12/13] mei: docs: add vtag ioctl documentation

2020-08-18 Thread Tomas Winkler
Add structured documenation for the new vtag ioctl Signed-off-by: Tomas Winkler --- Documentation/driver-api/mei/mei.rst | 37 1 file changed, 37 insertions(+) diff --git a/Documentation/driver-api/mei/mei.rst b/Documentation/driver-api/mei/mei.rst index

[char-misc-next 09/13] mei: bus: use zero vtag for bus clients.

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin The zero vtag is required for the read flow to work also for devices on the mei client bus. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 72 +- 1 file changed, 71 insertions(+), 1

[char-misc-next 13/13] mei: virtio: virtualization frontend driver

2020-08-18 Thread Tomas Winkler
for each mei vritio device. The backend service is available in ACRN device-model at github. For more information, please refer to https://projectacrn.org The ACRN virtio sub device id for MEI is is 0x8602. Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Signed-off-by: Wang Yu Signed

[char-misc-next 11/13] mei: add connect with vtag ioctl

2020-08-18 Thread Tomas Winkler
parameter is the properties of the FW client Clients that do not support tagged connection will respond with -EOPNOTSUPP Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/main.c | 210 --- include/uapi/linux/mei.h | 49

[char-misc-next 05/13] mei: bump hbm version to 2.2

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Bump HBM version to 2.2 to indicate vtag support. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h index

[char-misc-next 03/13] mei: add vtag support bit in client properties

2020-08-18 Thread Tomas Winkler
@@ Contact: Tomas Winkler Description: Stores mei client fixed address, if any Format: %d +What: /sys/bus/mei/devices/.../vtag +Date: Nov 2020 +KernelVersion: 5.9 +Contact: Tomas Winkler +Description: Stores mei client vtag support status

[char-misc-next 02/13] mei: restrict vtag support to hbm version 2.2

2020-08-18 Thread Tomas Winkler
the series bisectable. Everything will be enabled when driver HBM version is set to 2.2. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 1 + drivers/misc/mei/hbm.c | 15 +++ drivers/misc/mei/hw.h | 9 + drivers/misc

[char-misc-next 07/13] mei: add a vtag map for each client

2020-08-18 Thread Tomas Winkler
From: Alexander Usyskin Vtag map is a list of tuples of vtag and file pointer (struct mei_cl_vtag) associated with a particular me host client. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 168 - drivers

[char-misc-next 01/13] mei: hbm: add capabilities message

2020-08-18 Thread Tomas Winkler
the requested capability is supported. Bump copyright year in affected files. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 1 + drivers/misc/mei/hbm.c | 72 ++ drivers/misc/mei/hbm.h | 2 ++ drivers/misc

[char-misc-next 00/13] mei: add support for virtual tags

2020-08-18 Thread Tomas Winkler
ioctl Tomas Winkler (3): mei: add support for mei extended header. mei: docs: add vtag ioctl documentation mei: virtio: virtualization frontend driver Documentation/ABI/testing/sysfs-bus-mei | 7 + Documentation/driver-api/mei/mei.rst| 37 + drivers/misc/mei/Kconfig

[char-misc V5] mei: hdcp: fix mei_hdcp_verify_mprime() input parameter

2020-08-18 Thread Tomas Winkler
ber of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: 0a1af1b5c18d (misc/mei/hdcp: Verify M_prime) Cc: # v5.1+: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Signed-off-by: Tomas Winkler Revie

[char-misc-next V4] mei: hdcp: fix mei_hdcp_verify_mprime() input parameter

2020-07-30 Thread Tomas Winkler
ber of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: commit 0a1af1b5c18d ("misc/mei/hdcp: Verify M_prime") Cc: "Gustavo A. R. Silva" Cc: Ramalingam C Cc: v5.1+ Signed-off-by: Tomas Winkler --- V4: 1.

[char-misc-next] mei: hdcp: fix mei_hdcp_verify_mprime() input parameter

2020-07-30 Thread Tomas Winkler
ber of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: commit 0a1af1b5c18d ("misc/mei/hdcp: Verify M_prime") Cc: "Gustavo A. R. Silva" Cc: Ramalingam C Cc: v5.1+ Signed-off-by: Tomas Winkler --- V4: 1.

[char-misc-next V3] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-30 Thread Tomas Winkler
ber of streams is always one. Fixes: c56967d674e3 (mei: hdcp: Replace one-element array with flexible-array member) Fixes: 0a1af1b5c18d ("misc/mei/hdcp: Verify M_prime") Cc: "Gustavo A. R. Silva" Cc: Ramalingam C Cc: v5.1+ Signed-off-by: Tomas Winkler --- V3: 1. Fix commit

[char-misc-next V2] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-30 Thread Tomas Winkler
: Replace one-element array with flexible-array member) Cc: Ramalingam C Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- V2: Check for allocation failure. drivers/misc/mei/hdcp/mei_hdcp.c | 40 +++- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git

[char-misc-next] mei: hdcp: fix mei_hdcp_verify_mprime() input paramter

2020-07-29 Thread Tomas Winkler
. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/hdcp/mei_hdcp.c | 38 ++-- 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index d1d3e025ca0e..0e8f12e38494 100644 --- a/drivers

[char-misc-next] MAINTAINERS: Fix maintainer entry for mei driver

2020-07-29 Thread Tomas Winkler
mei driver has sub modules, those are not listed via scripts/get_maintainer.pl when using asterisk: drivers/misc/mei/* The correct notation is: drivers/misc/mei/ Cc: Joe Perches Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1

[char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Tomas Winkler
. This reverts commit c56967d674e361ebe716e66992e3c5332b25ac1f. Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/hdcp/mei_hdcp.c | 2 +- drivers/misc/mei/hdcp/mei_hdcp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b

[char-misc-next V3] mei: add device kind to sysfs

2020-07-28 Thread Tomas Winkler
names. Currently we are adding 'itouch' string for Intel IPTS 1.0, 2.0 devices. This is done via new sysfs attribute 'kind'. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: 1. Send the correct patch. V3: 1. Remove redundant lock from kind_show(). (Greg) 2. Don't initialize

[char-misc-next V2] mei: add device kind to sysfs

2020-07-28 Thread Tomas Winkler
names. Currently we are adding 'itouch' string for Intel IPTS 1.0, 2.0 devices. This is done via new sysfs attribute 'kind'. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: Correct version of the patch. Documentation/ABI/testing/sysfs-class-mei | 13 +++ drivers

[char-misc-next] mei: add device type

2020-07-28 Thread Tomas Winkler
are adding 'itouch' string for Intel IPTS devices. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 12 drivers/misc/mei/hw-me.h | 5 + drivers/misc/mei/hw-txe.c | 1 + drivers/misc/mei/main.c| 27

[char-misc-next 6/6] mei: hw: don't use one element arrays

2020-07-23 Thread Tomas Winkler
. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/hw.h b/drivers/misc/mei/hw.h index b1a8d5ec88b3..26fa92cb7f7a 100644 --- a/drivers/misc/mei/hw.h +++ b/drivers/misc/mei/hw.h @@ -1,6 +1,6

[char-misc-next 5/6] mei: hw: use sizeof of variable instead of struct type

2020-07-23 Thread Tomas Winkler
Use sizeof(*dev) + sizeof(*hw) instead of sizeof(struct mei_device) + sizeof(struct mei_me_hw) There is a possibility of bug when variable type has changed but corresponding struct passed to the sizeof has not. Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c

[char-misc-next 2/6] mei: ioctl: use sizeof of variable instead of struct type

2020-07-23 Thread Tomas Winkler
Use sizeof(connect_data))) instead of sizeof(struct mei_connect_client_data) when copying data between user space and kernel. There is a possibility of bug when variable type has changed but corresponding struct passed to the sizeof has not. Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler

[char-misc-next 4/6] mei: client: use sizeof of variable instead of struct type

2020-07-23 Thread Tomas Winkler
There is a possibility of bug when variable type has changed but corresponding struct passed to the sizeof has not. Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/client.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei

[char-misc-next 3/6] mei: bus: use sizeof of variable instead of struct type

2020-07-23 Thread Tomas Winkler
There is a possibility of bug when variable type has changed but corresponding struct passed to the sizeof has not. Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 23 +++ drivers/misc/mei/bus.c | 2 +- 2 files changed, 12

[char-misc-next 0/6] mei: remove one-element arrays

2020-07-23 Thread Tomas Winkler
1. Remove one-element arrays from hw.h 2. Adjust to preferred method of getting size of structure from memory allocation and movement. sizeof(*var) instead of sizeof(struct some_struct) Tomas Winkler (6): mei: hbm: use sizeof of variable instead of struct type mei: ioctl: use sizeof

[char-misc-next 1/6] mei: hbm: use sizeof of variable instead of struct type

2020-07-23 Thread Tomas Winkler
There is a possibility of bug when variable type has changed but corresponding struct passed to the sizeof has not. Cc: Gustavo A. R. Silva Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 74 ++ 1 file changed, 32 insertions(+), 42 deletions

[char-misc-next] mei: bus: don't clean driver pointer

2020-06-28 Thread Tomas Winkler
userspace requests' Nevertheless the fix is correct also for the upstream. Link: https://patchwork.ozlabs.org/project/ubuntu-kernel/patch/20180912085046.3401-2-...@canonical.com/ Cc: Cc: Andy Whitcroft Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c |

[char-misc-next 1/7] mei: me: disable mei interface on Mehlow server platforms

2020-06-19 Thread Tomas Winkler
. Cc: Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/hw-me.c | 60 +++ drivers/misc/mei/hw-me.h | 13 +--- drivers/misc/mei/pci-me.c | 16 +- 4 files changed, 73 insertions(+), 18 deletions

[char-misc-next 3/7] mei: me: make mei_me_fw_sku_sps_4() less cryptic

2020-06-19 Thread Tomas Winkler
Last add mei_me_fw_sku_sps_4() kdoc and add descriptive defines for register name and values. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/hw-me.c | 18 -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers

[char-misc-next 5/7] mei: me: add MEI device for SPT with ITPS capability

2020-06-19 Thread Tomas Winkler
Add device ID for Intel Sunrise Point PCH (Skylake) which has Intel Precise Touch & Stylus IPTS (iTouch). Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs

[char-misc-next 7/7] mei: me: add tiger lake point device ids for H platforms.

2020-06-19 Thread Tomas Winkler
From: Alexander Usyskin Add Tiger Lake device ids H for HECI1. TGH_H is also used in Tatlow SPS platform we need to disable the mei interface there. Cc: Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/hw-me.c | 10

[char-misc-next 2/7] mei: me: constify the device parameter to the probe quirk

2020-06-19 Thread Tomas Winkler
The quirk_probe there is no writing to pci device hence we can constify the passed pci_dev pointer. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 6 +++--- drivers/misc/mei/hw-me.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/hw-me.c b

[char-misc-next 4/7] mei: me: add kdoc for mei_me_fw_type_nm()

2020-06-19 Thread Tomas Winkler
Add kdoc for mei_me_fw_type_nm() function. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index 6aa522c0d910..e476995e4c56 100644 --- a/drivers/misc

[char-misc-next 6/7] mei: me: add MEI device for KBP with ITPS capability

2020-06-19 Thread Tomas Winkler
Add device ID for Intel Kaby Point PCH (Kabylake) which has Intel Precise Touch & Stylus IPTS (iTouch). Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs

[PATCH 2/2] mfd: mfd_cell: constify platform_data

2020-05-16 Thread Tomas Winkler
platform_data is duplicated into platform_device platform_data via platform_device_add_data() and is not modified. Signed-off-by: Tomas Winkler --- include/linux/mfd/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h

[PATCH 0/2] mfd: constify pointers

2020-05-16 Thread Tomas Winkler
Constify properties and platform_data in mfd cells Tomas Winkler (2): mfd: constify properties in mfd_cell mfd: mfd_cell: constify platform_data include/linux/mfd/core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.21.3

[PATCH 1/2] mfd: constify properties in mfd_cell

2020-05-16 Thread Tomas Winkler
Constify 'struct property_entry *properties' in mfd_cell It is always passed around as a pointer const struct. Signed-off-by: Tomas Winkler --- include/linux/mfd/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h index

[char-misc-next] mei: release me_cl object reference

2020-05-12 Thread Tomas Winkler
From: Alexander Usyskin Allow me_cl object to be freed by releasing the reference that was acquired by one of the search functions: __mei_me_cl_by_uuid_id() or __mei_me_cl_by_uuid() Cc: Reported-by: 亿一 Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei

[char-misc] mei: me: disable mei interface on LBG servers.

2020-04-28 Thread Tomas Winkler
Disable the MEI driver on LBG SPS (server) platforms, some corner flows such as recovery mode does not work, and the driver doesn't have working use cases. Cc: Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 8 drivers/misc/mei/hw-me.h | 4 drivers/misc/mei/pci-me.c

[char-misc-next] samples: mei: use hostprogs kbuild constructs

2019-10-10 Thread Tomas Winkler
Use hostprogs kbuild constructs to compile mei sample program mei-amt-version Add CONFIG_SAMPLE_INTEL_MEI option to enable/disable the feature. Signed-off-by: Tomas Winkler --- samples/Kconfig | 7 +++ samples/Makefile | 1 + samples/mei/Makefile | 12 ++-- 3 files

[char-misc-next 2/2] mei: me: fix me_intr_clear function name in KDoc

2019-10-07 Thread Tomas Winkler
From: Alexander Usyskin Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/mei/hw-me.c b/drivers/misc/mei/hw-me.c index c4f6991d3028..5ef30c7c92b3 100644 --- a/drivers/misc

[char-misc-next 1/2] mei: fix modalias documentation

2019-10-07 Thread Tomas Winkler
From: Alexander Usyskin mei client bus added the client protocol version to the device alias, but ABI documentation was not updated. Fixes: b26864cad1c9 (mei: bus: add client protocol version to the device alias) Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- Documentation

[char-misc-next] mei: buf: drop 'running hook' debug messages.

2019-10-04 Thread Tomas Winkler
Drop 'running hook' debug messages, as this info can be already retrieved via ftrace. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index 0a2b99e1af45

[char-misc for v4.5-rc2 2/2 V2] mei: avoid FW version request on Ibex Peak and earlier

2019-10-04 Thread Tomas Winkler
: [ 15.964298] mei mei::55213584-9a29-4916-badf-0fb7ed682aeb:01: Could not read FW version [ 15.964301] mei mei::55213584-9a29-4916-badf-0fb7ed682aeb:01: version command failed -5 Cc: +v4.18 Cc: Paul Menzel Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: Drop offending debug

[char-misc for 4.5-rc2 1/2] mei: me: add comet point (lake) LP device ids

2019-10-01 Thread Tomas Winkler
Add Comet Point devices IDs for Comet Lake U platforms. Cc: Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 3 +++ drivers/misc/mei/pci-me.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index

[char-misc for v4.5-rc2 2/2] mei: avoid FW version request on Ibex Peak and earlier

2019-10-01 Thread Tomas Winkler
: [ 15.964298] mei mei::55213584-9a29-4916-badf-0fb7ed682aeb:01: Could not read FW version [ 15.964301] mei mei::55213584-9a29-4916-badf-0fb7ed682aeb:01: version command failed -5 Cc: +v4.18 Cc: Paul Menzel Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus

[char-misc-next] mei: me: add Tiger Lake point LP device ID

2019-08-19 Thread Tomas Winkler
Add Tiger Lake Point device ID for TGP LP. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/pci-me.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index 6c0173772162..77f7dff7098d

[PATCH V2] scsi: ufs: revamp string descriptor reading

2019-07-30 Thread Tomas Winkler
Define new a type: uc_string_id for easier string handling and less casting. Reduce number or string copies in price of a dynamic allocation. Signed-off-by: Tomas Winkler Tested-by: Avri Altman --- V2: a. Use u8 instead of char as result string is utf8 b. In ufshcd_read_desc_param() keep

[PATCH RESEND] scsi: ufs: revamp string descriptor reading

2019-07-21 Thread Tomas Winkler
Define new a type: uc_string_id for easier string handling and less casting. Reduce number or string copies in price of a dynamic allocation. Signed-off-by: Tomas Winkler Tested-by: Avri Altman --- Resend: It was reviewed by not merged. drivers/scsi/ufs/ufs-sysfs.c | 20 ++--- drivers/scsi

[char-misc] mei: me: add mule creek canyon (EHL) device ids

2019-07-12 Thread Tomas Winkler
From: Alexander Usyskin Add Mule Creek Canyon (PCH) MEI device ids for Elkhart Lake (EHL) Platform. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 3 +++ drivers/misc/mei/pci-me.c | 3 +++ 2 files changed, 6 insertions(+) diff --git

[char-misc-next] mei: Convert to use DEFINE_SHOW_ATTRIBUTE macro

2019-05-20 Thread Tomas Winkler
From: Vitaly Lubart Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Vitaly Lubart Signed-off-by: Tomas Winkler --- drivers/misc/mei/debugfs.c | 184 +++-- 1 file changed, 52 insertions(+), 132 deletions(-) diff --git a/drivers/misc/mei

[char-misc-next 1/2] mei: hdcp: use own Kconfig file

2019-04-22 Thread Tomas Winkler
The mei/hdcp module have its own Makefile so naturally it should have associated Kconfig in the same directory. Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 10 +- drivers/misc/mei/hdcp/Kconfig | 13 + 2 files changed, 14 insertions(+), 9 deletions

[char-misc-next 2/2] mei: expose device state in sysfs

2019-04-22 Thread Tomas Winkler
From: Alexander Usyskin Expose mei device state to user-space through sysfs. This gives indication to applications that driver is in transition, usefully mostly to detect link reset state. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- Documentation/ABI/testing/sysfs-class

[char-misc-next] mei: hdcp: use own Kconfig file

2019-04-04 Thread Tomas Winkler
The mei/hdcp module have its own Makefile so naturally it should have associated Kconfig in the same directory. Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 10 +- drivers/misc/mei/hdcp/Kconfig | 13 + 2 files changed, 14 insertions(+), 9 deletions

[char-misc 5/5] mei: adjust the copyright notice in the files.

2019-03-11 Thread Tomas Winkler
Use unified version of the copyright notice in the files Update copyright years according the year the files were touched, except this patch and SPDX conversions. Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 1 + drivers/misc/mei/Makefile | 2 +- drivers/misc/mei/bus

[char-misc 3/5] nfc/mei: convert to SPDX license tags

2019-03-11 Thread Tomas Winkler
Replace boiler plate licenses texts with the SPDX license identifiers in the mei nfc files header. Signed-off-by: Tomas Winkler --- drivers/nfc/mei_phy.c | 18 +++--- drivers/nfc/microread/mei.c | 17 +++-- drivers/nfc/pn544/mei.c | 15 ++- 3 files

[char-misc 4/5] mei/hdcp: Fix SPDX identifiers

2019-03-11 Thread Tomas Winkler
1. Remove redundant parentheses around single license 2. Fix the license to GPL-2.0 and not GPL-2.0+ in mei_hdcp.h Cc: Ramalingam C Signed-off-by: Tomas Winkler --- drivers/misc/mei/hdcp/mei_hdcp.c | 2 +- drivers/misc/mei/hdcp/mei_hdcp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions

[char-misc 1/5] mei: add missing SPDX tag to mei Kconfig

2019-03-11 Thread Tomas Winkler
Add SPDX tag with GPLv2 license to mei Kconfig. Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig index 74e2c667dce0..998fb4ae9791 100644 --- a/drivers/misc/mei/Kconfig +++ b/drivers

[char-misc 2/5] mei: convert to SPDX license tags

2019-03-11 Thread Tomas Winkler
Replace boiler plate licenses texts with the SPDX license identifiers in the mei files header. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus-fixup.c | 12 +-- drivers/misc/mei/bus.c | 11 +- drivers/misc/mei/client.c | 12 +-- drivers/misc/mei/client.h

[char-misc 0/5] mei: spdx and copyright adjustments

2019-03-11 Thread Tomas Winkler
for copyright notice in the all files and update the copyright notice according file modification date. Tomas Winkler (5): mei: add missing SPDX tag to mei Kconfig mei: convert to SPDX license tags nfc/mei: convert to SPDX license tags mei/hdcp: Fix SPDX identifiers mei: adjust

[char-misc] mei: convert to SPDX license tags

2019-03-10 Thread Tomas Winkler
Signed-off-by: Tomas Winkler --- drivers/misc/mei/Kconfig | 1 + drivers/misc/mei/Makefile| 2 +- drivers/misc/mei/bus-fixup.c | 13 +- drivers/misc/mei/bus.c | 14 ++- drivers/misc/mei/client.c| 13 +- drivers/misc/mei/client.h| 13

[char-misc-next] mei: bus: move hw module get/put to probe/release

2019-02-25 Thread Tomas Winkler
. Moving reference counting to probe and release of mei bus client driver solves this issue in simplest way, as each client provides only a single connection to a client bus driver. Cc: Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 21

[char-misc] mei: hbm: clean the feature flags on link reset

2019-02-20 Thread Tomas Winkler
From: Alexander Usyskin The list of supported functions can be altered upon link reset, clean the flags to allow correct selections of supported features. Cc: v4.19+ Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei/hbm.c | 7 +++ 1 file changed, 7

[char-misc-next] mei: bus: export to_mei_cl_device for mei client devices drivers

2019-02-09 Thread Tomas Winkler
Export to_mei_cl_device macro, as it is needed also in the mei client drivers. Signed-off-by: Tomas Winkler --- drivers/misc/mei/bus.c | 1 - include/linux/mei_cl_bus.h | 2 ++ 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/misc/mei/bus.c b/drivers/misc/mei/bus.c

[char-misc for v5.0] mei: free read cb on ctrl_wr list flush

2019-01-29 Thread Tomas Winkler
From: Alexander Usyskin There is a little window during disconnection flow when read cb is moved between lists and may be not freed. Remove moving read cbs explicitly during flash fixes this memory leak. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/misc/mei

  1   2   3   4   5   6   7   8   9   10   >