Re: [PATCH] 3c59x: read current link status from phy

2005-09-09 Thread Tommy Christensen
John W. Linville wrote: Any chance you could re-diff this to apply on top of the patch posted earlier today by Neil Horman? Sure, but his patch didn't apply to -git8. If Neil would please resend, then I can diff against that. -Tommy - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
Andrew Morton wrote: Should we also decrease the polling interval? Perhaps only when the cable is unplugged? Sounds like a plan. 60 seconds certainly strikes me as being very slow. OTOH, I'm not aware of the reasoning behind this choice in the first place. It might make sense for some odd setu

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
Bogdan Costescu wrote: I now understood what the problem was, so I'll put it in words for posterity: the Link Status bit of the MII Status register needs to be read twice to first clear the error state (link bit=0) after which the bit reports the actual value of the link. From the manual: Yes

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
On Thu, 2005-09-08 at 15:35, Bogdan Costescu wrote: > On Thu, 8 Sep 2005, Tommy Christensen wrote: > > > The idea is to avoid an extra delay of 60 seconds before detecting > > link-up. > > But you are adding the read to a function that is called repeatedly to > fix

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
On Thu, 2005-09-08 at 13:58, Bogdan Costescu wrote: > Can the original poster give an explanation ? I've enjoyed a rather > well functioning 3c59x driver for the past ~6 years without such > double reading. Plus: > - this operation is I/O expensive > - it is performed inside a region protected by

Re: 2.6.11-rc5 and 2.6.12: cannot transmit anything - more info

2005-08-04 Thread Tommy Christensen
Denis Vlasenko wrote: Hi, As reported earlier, sometimes my home box don't want to send anything. # ip r 1.1.5.5 dev tun0 proto kernel scope link src 1.1.5.6 1.1.4.0/24 dev if proto kernel scope link src 1.1.4.6 default via 1.1.5.5 dev tun0 # ping 1.1.4.1 -i 0.01 2005-08-02_19:12:18.19

Re: [PATCH] audit: fixes in audit_log_drain()

2005-01-16 Thread Tommy Christensen
Tommy Christensen wrote: o Don't send shared skb's to netlink_unicast Never mind. Herbert Xu made a better fix for this in netlink. -Tommy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

[PATCH] audit: fixes in audit_log_drain()

2005-01-15 Thread Tommy Christensen
Would this be for you, James? o Fix skb leak o Don't send shared skb's to netlink_unicast Signed-off-by: Tommy S. Christensen <[EMAIL PROTECTED]> -Tommy --- linux-2.6.11-rc1-bk3/kernel/audit.c 2005-01-12 14:54:15.0 +0100 +++ linux-2.6.11-work/kernel/audit.c2005-01-15 23:51:25.399453674