RE: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

2020-09-13 Thread Tony Chuang
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: ef2e9a563b0cd7965e2a1263125dcbb1c86aa6cc > commit: ba0fbe236fb8a7b992e82d6eafb03a600f5eba43 rtw88: extract: make > 8822c an individual kernel module > date: 4 months ago > config: i386-randconfig-r034

RE: drivers/net/wireless/realtek/rtw88/rtw8821c.c:71:8: warning: type qualifiers ignored on function return type

2020-08-27 Thread Tony Chuang
Hi Andy > + linux-wireless > > kernel test robot writes: > > > Hi Tzu-En, > > > > First bad commit (maybe != root cause): > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > > head: 15bc20c6af4ceee97a1f90b43c0e386643c071b4 > > commit: f745eb9ca5bf823b

RE: drivers/net/wireless/realtek/rtw88/pci.c:1477:5: warning: no previous prototype for 'rtw_pci_probe'

2020-08-27 Thread Tony Chuang
> + linux-wireless > > kernel test robot writes: > > > Hi Zong-Zhe, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > > head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7 > > commit: 72f256c2b948622cc45ff8bc0

RE: [PATCH] rtw88: 8821c: Add RFE 2 support

2020-08-05 Thread Tony Chuang
> 8821CE with RFE 2 isn't supported: > [ 12.404834] rtw_8821ce :02:00.0: rfe 2 isn't supported > [ 12.404937] rtw_8821ce :02:00.0: failed to setup chip efuse info > [ 12.404939] rtw_8821ce :02:00.0: failed to setup chip information > NACK The RFE type 2 should be working with s

RE: [PATCH net v1] net: rtw88: fix an issue about leak system resources

2020-05-04 Thread Tony Chuang
> Subject: [PATCH net v1] net: rtw88: fix an issue about leak system resources > > the related system resources were not released when pci_iomap() return > error in the rtw_pci_io_mapping() function. add pci_release_regions() to > fix it. > > Fixes: e3037485c68ec1a ("rtw88: new Realtek 802.11ac d

RE: [PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-09-03 Thread Tony Chuang
> From: Jian-Hong Pan [mailto:jian-h...@endlessm.com] > > > > > Tony Chuang writes: > > > > >> From: Jian-Hong Pan > > >> Subject: [PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft > IRQ > > >> > > >> Ther

RE: [PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-27 Thread Tony Chuang
> From: Jian-Hong Pan > Subject: [PATCH v4] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ > > There is a mass of jobs between spin lock and unlock in the hardware > IRQ which will occupy much time originally. To make system work more > efficiently, this patch moves the jobs to the soft IR

RE: [PATCH v3] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-21 Thread Tony Chuang
Hi, > From: Jian-Hong Pan [mailto:jian-h...@endlessm.com] > > There is a mass of jobs between spin lock and unlock in the hardware > IRQ which will occupy much time originally. To make system work more > efficiently, this patch moves the jobs to the soft IRQ (bottom half) to > reduce the time in

RE: [PATCH v2] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-16 Thread Tony Chuang
> From: Jian-Hong Pan > > There is a mass of jobs between spin lock and unlock in the hardware > IRQ which will occupy much time originally. To make system work more > efficiently, this patch moves the jobs to the soft IRQ (bottom half) to > reduce the time in hardware IRQ. > > Signed-off-by: Jia

RE: [PATCH] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-16 Thread Tony Chuang
Hi, A few more questions below > > From: Jian-Hong Pan [mailto:jian-h...@endlessm.com] > > > > There is a mass of jobs between spin lock and unlock in the hardware > > IRQ which will occupy much time originally. To make system work more > > efficiently, this patch moves the jobs to the soft IRQ (

RE: [PATCH] rtw88: pci: Move a mass of jobs in hw IRQ to soft IRQ

2019-08-16 Thread Tony Chuang
> From: Jian-Hong Pan [mailto:jian-h...@endlessm.com] > > There is a mass of jobs between spin lock and unlock in the hardware > IRQ which will occupy much time originally. To make system work more > efficiently, this patch moves the jobs to the soft IRQ (bottom half) to > reduce the time in hardw

RE: Realtek r8822be wireless card fails to work with new rtw88 kernel module

2019-08-06 Thread Tony Chuang
> + yhchuang > > On Tue, Aug 6, 2019 at 7:32 AM 고준 wrote: > > > > Hello, > > > > I recently reported a bug to Ubuntu regarding a regression in wireless > > driver support for the Realtek r8822be wireless chipset. The issue > > link on launchpad is: > > > > https://bugs.launchpad.net/bugs/1838133

RE: [PATCH] rtw88: pci: Use general byte arrays as the elements of RX ring

2019-07-29 Thread Tony Chuang
The problem is that larger allocates are more likely to fail > > (especially if the system has been running for some time). > > So you almost certainly want to be able to fall back to smaller > > allocates even though they use more memory. > > > > I also wonder if you act

RE: [PATCH v2 1/2] rtw88: pci: Rearrange the memory usage for skb in RX ISR

2019-07-10 Thread Tony Chuang
> Subject: [PATCH v2 1/2] rtw88: pci: Rearrange the memory usage for skb in > RX ISR > > Testing with RTL8822BE hardware, when available memory is low, we > frequently see a kernel panic and system freeze. > > First, rtw_pci_rx_isr encounters a memory allocation failure (trimmed): > > rx routine

RE: [PATCH 09/12] rtw88: Fix misuse of GENMASK macro

2019-07-09 Thread Tony Chuang
> Subject: [PATCH 09/12] rtw88: Fix misuse of GENMASK macro > > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless

RE: [PATCH] rtw88/pci: Rearrange the memory usage for skb in RX ISR

2019-07-08 Thread Tony Chuang
> > > @@ -803,25 +812,14 @@ static void rtw_pci_rx_isr(struct rtw_dev > *rtwdev, > > > struct rtw_pci *rtwpci, > > > skb_put(skb, pkt_stat.pkt_len); > > > skb_reserve(skb, pkt_offset); > > > > > > - /* alloc a smaller skb to mac80211 *

RE: [PATCH] rtw88/pci: Rearrange the memory usage for skb in RX ISR

2019-07-08 Thread Tony Chuang
> Subject: [PATCH] rtw88/pci: Rearrange the memory usage for skb in RX ISR nit, "rtw88: pci:" would be better. > > > When skb allocation fails and the "rx routine starvation" is hit, the > function returns immediately without updating the RX ring. At this > point, the RX ring may continue refer

RE: [PATCH] rtw88: Remove set but not used variable 'ip_sel' and 'orig'

2019-05-29 Thread Tony Chuang
> -Original Message- > From: YueHaibing [mailto:yuehaib...@huawei.com] > Sent: Wednesday, May 29, 2019 10:58 PM > To: Tony Chuang; kv...@codeaurora.org; da...@davemloft.net > Cc: linux-kernel@vger.kernel.org; net...@vger.kernel.org; > linux-wirel...@vger.kernel.org; Yu

RE: [LKP] [mac80211] c752cac9db: hwsim.ap_vlan_iface_cleanup_multibss_per_sta_vif.fail

2019-03-06 Thread Tony Chuang
> -Original Message- > From: kernel test robot [mailto:rong.a.c...@intel.com] > Sent: Thursday, March 07, 2019 3:05 PM > To: Tony Chuang > Cc: Johannes Berg; Larry Finger; LKML; Linus Torvalds; l...@01.org > Subject: [LKP] [ma

RE: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-03 Thread Tony Chuang
> -Original Message- > From: Arend Van Spriel [mailto:arend.vanspr...@broadcom.com] > > > Larry, > > > > Sorry about all these extra replies.  Shortly after I sent my last > > message my access point started recognizing the connection as 802.11ac > > with PHY Rate / Modulation Rate of 86

RE: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-02-27 Thread Tony Chuang
> This message is in regard to a bug I have open on bugs.launchpad.net, 1813372, > linked below.  This issue, originally identified in an Ubuntu kernel, has been > duplicated in the most current mainline kernel, 5.0-rc8, and is in regard to > problems attaining a wireless connection at 802.11ac spe