M ops:
drm/omap: force runtime PM suspend on system suspend
Regards,
Tony
Tony Lindgren (3):
soc: ti: pm33xx: Simplify RTC usage to prepare to drop platform data
ARM: OMAP2+: Drop legacy platform data for am3 and am4 rtc
ARM: OMAP2+: Drop legacy platform data for dra7 rtcss
arch/arm/boo
If we have "ti,no-idle" specified for a module we must not disable
the the module on suspend to keep things backwards compatible.
Fixes: 386cb76681ca ("bus: ti-sysc: Handle missed no-idle property in addition
to no-idle-on-init")
Reported-by: Grygorii Strashko
Signed-o
* Tony Lindgren [200702 19:03]:
> * Suman Anna [200702 18:01]:
> > Hi Tony,
> >
> > On 7/2/20 12:49 PM, Tony Lindgren wrote:
> > > With CONFIG_DEBUG_ATOMIC_SLEEP enabled we can see the following with
> > > wakeirqs and serial console idled:
> >
* Suman Anna [200702 18:01]:
> Hi Tony,
>
> On 7/2/20 12:49 PM, Tony Lindgren wrote:
> > With CONFIG_DEBUG_ATOMIC_SLEEP enabled we can see the following with
> > wakeirqs and serial console idled:
>
> Which devices are these? I have one patch from Tero fixing sim
: d46f9fbec719 ("bus: ti-sysc: Use optional clocks on for enable and wait
for softreset bit")
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus
)
(sysc_enable_module) from [] (sysc_probe+0xe9c/0x1380)
(sysc_probe) from [] (platform_drv_probe+0x48/0x98)
Fixes: e8639e1c986a ("bus: ti-sysc: Handle module unlock quirk needed for some
RTC")
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 4 ++--
1 file changed, 2 insertions(+), 2
ogether so that git biesct will not result
> in a boot failure
Thanks for updating it. Best that Linus queues both patches via
the pinctrl tree when no more comments:
Acked-by: Tony Lindgren
.h.
Looks good to me and should not conflict with anything so feel
free to queue along with your other patches:
Acked-by: Tony Lindgren
> Cc: Ulf Hansson
> Cc: linux-...@vger.kernel.org
> Cc: Tony Lindgren
> Cc: linux-o...@vger.kernel.org
> Signed-off-by: Lee Jones
* Sergey Senozhatsky [200702 05:13]:
> On (20/06/30 11:02), Tony Lindgren wrote:
> > This conditional disable for irq_shared does not look nice to me
> > from the other device point of view :)
> >
> > Would it be possible to just set up te dummy interrupt handler
>
locks from the binding and prm driver as there's no need
for them as pointed out by Tero
- Add checking for domain transition bit in pwrstst register as
pointed out by Tero
- Add omap_prm_domain_show_state() for CONFIG_DEBUG
Tony Lindgren (6):
dt-bindings: omap: Update PRM binding for
The PRM (Power and Reset Module) has a register to enable and disable
the related power domain, so let's update the binding for that.
Cc: devicet...@vger.kernel.org
Cc: Rob Herring
Signed-off-by: Tony Lindgren
---
Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
1 file ch
Let's configure only sgx power domain for am3 and am4 to start with.
Signed-off-by: Tony Lindgren
---
drivers/soc/ti/omap_prm.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c
--- a/driver
Let's add omap4 and 5 l4_abe interconnect instance for the power
domain.
Signed-off-by: Tony Lindgren
---
drivers/soc/ti/omap_prm.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c
--- a/drivers/soc/ti/omap_
We can power off the SGX power domain when not in use when we configure
it for genpd. And with that change, we can now also drop the old unused
legacy platform data.
Signed-off-by: Tony Lindgren
---
arch/arm/boot/dts/am33xx.dtsi | 2 +
arch/arm/boot/dts/am4372.dtsi
We can power off l4_abe domain when not in use when we configure it for
genpd. And with that change, we can now also drop the old unused legacy
platform data.
Note that we also need to now use "simple-pm-bus" instead of "simple-bus"
for PM runtime to get enabled for the bus.
ators, and interconnect instances.
Further support can be added later on as needed for runtime configuration
based on domain-idle-states.
Signed-off-by: Tony Lindgren
---
arch/arm/mach-omap2/Kconfig | 1 +
drivers/soc/ti/omap_prm.c | 228 +++-
2 files changed
* kernel test robot [200629 19:24]:
> >> drivers/soc/ti/omap_prm.c:98:21: warning: attribute declaration must
> >> precede definition [-Wignored-attributes]
>static const struct __maybe_unused omap_prm_domain_map omap_prm_noinact = {
Thanks no more need for __maybe_unused with these patches
* Drew Fustini [200630 21:43]:
> On Tue, Jun 30, 2020 at 02:34:23PM -0700, Tony Lindgren wrote:
> > * Drew Fustini [200630 21:32]:
> > > On Tue, Jun 30, 2020 at 11:20:37AM -0700, Tony Lindgren wrote:
> > ...
> > > > > > Needing to change the dts
* Rong Chen [200630 00:31]:
>
>
> On 6/30/20 2:12 AM, Tony Lindgren wrote:
> > * kernel test robot [200617 17:28]:
> > > Hi Adam,
> > >
> > > Thank you for the patch! Yet something to improve:
> > >
> > > [auto build test ERROR on
* Drew Fustini [200630 21:32]:
> On Tue, Jun 30, 2020 at 11:20:37AM -0700, Tony Lindgren wrote:
...
> > > > Needing to change the dts does not sound good to me.. But maybe you mean
> > > > this is needed until the gpio-omap and pinctrl-single patches are
> > >
* Drew Fustini [200630 02:02]:
> On Mon, Jun 29, 2020 at 10:03:58AM -0700, Tony Lindgren wrote:
> > Hi,
> >
> > * Drew Fustini [200628 08:26]:
> > > v2 changes:
> > > - change default mux from output to input. Input is safer as it does
> > >
gt; > >> This event code represents the state of a removable cover of a
> > > > >> device.
> > > > >> Value 0 means that the cover is open or removed, value 1 means that
> > > > >> the
> > > > >&
* Sergey Senozhatsky [200630 13:06]:
> On (20/06/30 14:22), Petr Mladek wrote:
...
> > > > > @@ -2284,8 +2289,6 @@ int serial8250_do_startup(struct uart_port
> > > > > *port)
> > > > >* allow register changes to become visible.
> > > > >*/
> > > > >
* Suman Anna [200611 08:30]:
> Hi Tony, Jason, Caleb,
>
> The IPU and DSP remote processors are finally booting as of latest master
> on almost all the TI DRA7xx/AM57xx boards except for AM5729 BeagleBone AI
> board. We have most of the common dts pieces available due to the usage
> of common dra
* Drew Fustini [200618 11:30]:
> The BeagleBoard.org PocketBeagle has P1 and P2 headers [0] which expose
> many of the TI AM3358 SoC balls to stacking expansion boards called
> "capes", or to other external connections like jumper wires connected
> to a breadboard.
Thanks applying into omap-for-v
ed [-Wunused-but-set-variable]
> 196 | int error, ignore;
Acked-by: Tony Lindgren
ot;, and moreover "widgets / routing" doesn't need it.
> > This patch removes unsupported "simple-graph-card" prefix from
> > motorola-mapphone-common.dtsi and vendor-prefixes.yaml.
> >
> > Signed-off-by: Kuninori Morimoto
> > ---
>
> Reviewed-by: Sebastian Reichel
Probably best to merge this along with the other asoc patches:
Acked-by: Tony Lindgren
4 bits would have
> run out).
So I guess with 14 bits vs 15 bits we have these date ranges:
1970 + (0x3fff / 365) = 2014
1970 + (0x7fff / 365) = 2059
Meaning we can't do the whole year for 2059 and it's only 2058
compatible like you say above :)
Acked-by: Tony Lindgren
Hi,
* Drew Fustini [200628 08:26]:
> v2 changes:
> - change default mux from output to input. Input is safer as it does
> not drive the line. If the user wants output, they will need to edit
> this device tree.
So can you please clarify this a bit, are you saying that gpio output can't
be
* Drew Fustini [200610 04:03]:
> Add gpio-ranges properties to the gpio controller nodes.
>
> These gpio-ranges were created based on "Table 9-10. CONTROL_MODULE
> REGISTERS" in the "AM335x Technical Reference Manual" [0] and "Table
> 4-2. Pin Attributes" in the "AM335x Sitara Processor datashee
* Tony Lindgren [200529 17:22]:
> * Drew Fustini [200528 13:17]:
> > FYI - Linus W. provided an Acked-by in related thread [0].
> >
> > Anyone else have any review comments?
>
> Looks good to me thanks. But as the merge window is about
> to open, let's do
* Drew Fustini [200629 12:29]:
> Hi Tony - do you think this series is useful as-is?
>
> Or do you want to see some usage of the seperate conf and mux values
> first?
Hmm to me it seems you should squash patches 2 and 3 together as
otherwise git bisect will fail to boot probably at patch 2.
Reg
* Krzysztof Kozlowski [200626 01:07]:
> Fix dtschema validator warnings like:
> l2-cache-controller@48242000: $nodename:0: 'l2-cache-controller@48242000'
> does not match '^(cache-controller|cpu)(@[0-9a-f,]+)*$'
Applying into omap-for-v5.9/dt thanks.
Tony
* kernel test robot [200617 17:28]:
> Hi Adam,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on omap/for-next]
> [cannot apply to balbi-usb/testing/next]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW
* Krzysztof Kozlowski [200626 01:07]:
> Fix dtschema validator warnings like:
> l2-cache-controller@48242000: $nodename:0:
> 'l2-cache-controller@48242000' does not match
> '^(cache-controller|cpu)(@[0-9a-f,]+)*$'
Applying into omap-for-v5.9/dt thanks.
Tony
* Pavel Machek [200615 07:06]:
> Hi!
>
> Droid 4 has same problem as N900: it is often neccessary to manually
> tweak current draw from USB, for example when using thin charging cable.
>
> N900 creates unique attribute by hand, but I believe
> POWER_SUPPLY_PROP_INPUT_CURRENT_LIMIT looks suitable
Let's configure only sgx power domain for am3 and am4 to start with.
Signed-off-by: Tony Lindgren
---
drivers/soc/ti/omap_prm.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c
--- a/driver
* Drew Fustini [200622 16:47]:
> On Mon, Jun 22, 2020 at 09:11:32AM -0700, Tony Lindgren wrote:
> > * Drew Fustini [200618 05:52]:
> > > Currently, pinctrl-single only allows #pinctrl-cells = 1.
> > >
> > > This series will allow pinctrl-single to also suppor
Let's add omap4 and 5 l4_abe interconnect instance for the power
domain.
Signed-off-by: Tony Lindgren
---
drivers/soc/ti/omap_prm.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/soc/ti/omap_prm.c b/drivers/soc/ti/omap_prm.c
--- a/drivers/soc/ti/omap_
ators, and interconnect instances.
Further support can be added later on as needed for runtime configuration
based on domain-idle-states.
Signed-off-by: Tony Lindgren
---
arch/arm/mach-omap2/Kconfig | 1 +
drivers/soc/ti/omap_prm.c | 228 +++-
2 files changed
The PRM (Power and Reset Module) has a register to enable and disable
the related power domain, so let's update the binding for that.
Cc: devicet...@vger.kernel.org
Cc: Rob Herring
Signed-off-by: Tony Lindgren
---
Documentation/devicetree/bindings/arm/omap/prm-inst.txt | 2 ++
1 file ch
We can power off the SGX power domain when not in use when we configure
it for genpd. And with that change, we can now also drop the old unused
legacy platform data.
Signed-off-by: Tony Lindgren
---
arch/arm/boot/dts/am33xx.dtsi | 2 +
arch/arm/boot/dts/am4372.dtsi
g for domain transition bit in pwrstst register as
pointed out by Tero
- Add omap_prm_domain_show_state() for CONFIG_DEBUG
Tony Lindgren (6):
dt-bindings: omap: Update PRM binding for genpd
soc: ti: omap-prm: Add basic power domain support
soc: ti: omap-prm: Configure sgx power domain for am3 an
We can power off l4_abe domain when not in use when we configure it for
genpd. And with that change, we can now also drop the old unused legacy
platform data.
Note that we also need to now use "simple-pm-bus" instead of "simple-bus"
for PM runtime to get enabled for the bus.
* Drew Fustini [200618 05:52]:
> Currently, pinctrl-single only allows #pinctrl-cells = 1.
>
> This series will allow pinctrl-single to also support #pinctrl-cells = 2
>
> If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then
> pcs_parse_one_pinctrl_entry() does an OR operation on to
* Drew Fustini [200617 17:10]:
> Tony - does this look ok for 5.9?
Yes looks OK to me.
Just wondering, are the line with "NA" not used internally either?
If the "NA" lines are used internally, we should probably use
"Reserved" or "Internal" or something like that to avoid later
on having to patc
* Drew Fustini [200617 16:28]:
> These gpio-ranges are correct for all the platforms that included
> am33xx-l4.dtsi.
>
> I think it makes sense to add gpio-ranges properties as they describe
> the relationship between a gpio line and pin control register that
> exists in the hardware.
>
> Are th
* Drew Fustini [200615 08:58]:
> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
> RGMII mode") the networking is broken on the BeagleBone AI which has
> the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from
> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
>
> No
* Drew Fustini [200609 14:46]:
> AM3358 pin mcasp0_aclkr (ZCZ ball B13) [0] is routed to P1.31 header [1]
> Mode 4 of this pin is mmc0_sdwp (SD Write Protect). A signal connected
> to P1.31 may accidentally trigger mmc0 write protection. To avoid this
> situation, do not put mcasp0_aclkr in mode
function to deal with it cleanly.
> >
> > Fixes: b75ca5217743 ("ARM: OMAP: replace setup_irq() by request_irq()")
> > Signed-off-by: Arnd Bergmann
>
> Sorry for the mistake and thanks for the fix,
>
> Acked-by: afzal mohammed
Hmm so is this one still pending?
Best that Arnd applies it directly:
Acked-by: Tony Lindgren
* Tomi Valkeinen [200616 13:02]:
> On 11/06/2020 17:00, Grygorii Strashko wrote:
> > I think, suspend might be fixed if all devices, which are now child of
> > ti-sysc, will do
> > pm_runtime_force_xxx() calls at noirq suspend stage by adding:
> >
> > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtim
* Adam Ford [200613 11:11]:
> Through trial and error, I think I have the right IRQ for OMAP3630 for
> the 2nd instance.
OK great.
> > > I assume the second engine uses different interrupts. I don't suppose
> > > anyone know what it should be?
> >
> > Sorry no idea, usually the secure accelerat
* Grygorii Strashko [200611 13:59]:
> I think, suspend might be fixed if all devices, which are now child of
> ti-sysc, will do
> pm_runtime_force_xxx() calls at noirq suspend stage by adding:
>
> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
>
* Tomi Valkeinen [200610 11:48]:
> On 09/06/2020 20:10, Tony Lindgren wrote:
>
> > > On beagle-x15 I see these errors after modprobe:
> > >
> > > DSS: OMAP DSS rev 6.1
> > > omapdss_dss 5800.dss: bound 58001000.dispc (ops dispc_component_ops
>
* Stephen Rothwell [200609 22:40]:
> Hi all,
>
> Commits
>
> e711da8e6306 ("ARM: dts: am437x-epos-evm: remove lcd timings")
> 02d1ba4bdba0 ("ARM: dts: am437x-gp-evm: remove lcd timings")
> dc7677dbb854 ("ARM: dts: am437x-sk-evm: remove lcd timings")
>
> are missing a Signed-off-by from th
num_maps = 2.
...
> Fixes: 9dddb4df90d1 ("pinctrl: single: support generic pinconf")
It would be good to get an ack/tested-by from Haojian for this.
The patch looks right to me:
Acked-by: Tony Lindgren
* Tony Lindgren [200609 17:11]:
> I'm also seeing the rmmod omapdrm issue on am437x-sk-evm:
Oops sorry this is a user error. I've forgotten I need
to unbind the fb vtcon first :) thanks for hinting that
Tomi!
I can rmmod omapdrm just fine after doing:
# echo 0 > /sys/class/
* Tony Lindgren [200609 16:53]:
> * Tomi Valkeinen [200609 15:27]:
> > On 09/06/2020 18:19, Tony Lindgren wrote:
> > > Currently I'm only able to rmmod -f omapdrm, not sure if these issues
> > > might
> > > be related.
> >
> > Hmm, I always
* Tomi Valkeinen [200609 15:27]:
> On 09/06/2020 18:19, Tony Lindgren wrote:
> > Currently I'm only able to rmmod -f omapdrm, not sure if these issues might
> > be related.
>
> Hmm, I always use modules, and can unload omapdrm and drm fine. But there's
> a seque
* Tomi Valkeinen [200609 07:05]:
> On 03/06/2020 17:06, Tony Lindgren wrote:
> > * Tomi Valkeinen [200603 12:34]:
> > > Hi Tony,
> > >
> > > On 31/05/2020 22:39, Tony Lindgren wrote:
> > > > When booting without legacy platform data, we no lo
* Suman Anna [200605 15:14]:
> Hi Tony,
>
> The following 2 patches are couple of minor fixes that clean up
> couple of commits from the "ARM: dts: dra7/am57xx: remoteproc
> support" series [1]. Please pick these for the 5.8-rc fixes.
>
> The issues look to be result of incorrect rebase-conflict
* Navid Emamdoost [200605 03:28]:
> Calling pm_runtime_get_sync increments the counter even in case of
> failure, causing incorrect ref count. Call pm_runtime_put if
> pm_runtime_get_sync fails.
Looks like we have a similar patch already in Linux next,
care to check?
Regards,
Tony
Otherwise we can get "OCP softreset timed out" warnings occasionally
at least for i2c2 on omap4 now that we check the OCP softreset completed
bit on enable.
Reported-by: Merlijn Wajer
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 2 +-
1 file changed, 1 insertion(+),
* Tomi Valkeinen [200603 12:34]:
> Hi Tony,
>
> On 31/05/2020 22:39, Tony Lindgren wrote:
> > When booting without legacy platform data, we no longer have omap_device
> > calling PM runtime suspend for us on suspend. This causes the driver
> > context not be save
* Tony Lindgren [200602 13:38]:
> * Andy Shevchenko [200602 08:33]:
> Now that we can detach and reattach the kernel serial console,
> there should not be any need for pm_runtime_irq_safe() anymore :)
Below is a hastily tested RFC patch to remove pm_runtime_irq_safe()
for 8250_omap.c t
* Grygorii Strashko [200602 13:44]:
>
>
> On 02/06/2020 16:14, Drew Fustini wrote:
> > Add gpio-ranges properties to the gpio controller nodes.
> >
> > These gpio-ranges were created based on "Table 9-10. CONTROL_MODULE
> > REGISTERS" in the "AM335x Technical Reference Manual" [0] and "Table
>
* Andy Shevchenko [200602 08:33]:
> On Tue, Jun 2, 2020 at 11:09 AM Johan Hovold wrote:
> > On Mon, Jun 01, 2020 at 05:18:13PM -0700, Tony Lindgren wrote:
>
> ...
>
> > There's shouldn't be anything fundamental preventing you from adding the
> > missing
ff-by: Tony Lindgren
---
drivers/tty/serial/8250/8250_port.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_port.c
b/drivers/tty/serial/8250/8250_port.c
--- a/drivers/tty/serial/8250/8250_port.c
+++ b/drivers/tty/serial/8250/8250_port.c
@@ -20
* Drew Fustini [200531 20:42]:
> This patch causes pcs_parse_pinconf() to return an error when no
> pinctrl_map is added. The current behavior is to return 0 when
> !PCS_HAS_PINCONF or !nconfs. Thus pcs_parse_one_pinctrl_entry()
> incorrectly assumes that a map was added and sets num_maps = 2.
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 52762fbd1c4778ac9b173624ca0faacd22ef4724
Gitweb:
https://git.kernel.org/tip/52762fbd1c4778ac9b173624ca0faacd22ef4724
Author:Tony Lindgren
AuthorDate:Thu, 07 May 2020 10:23:18 -07:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: d15483bb49bae0f9cbb67c54becec252545752d3
Gitweb:
https://git.kernel.org/tip/d15483bb49bae0f9cbb67c54becec252545752d3
Author:Tony Lindgren
AuthorDate:Thu, 07 May 2020 10:23:17 -07:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: aba1ad05da088944a62eb87fb0cd8391152e8985
Gitweb:
https://git.kernel.org/tip/aba1ad05da088944a62eb87fb0cd8391152e8985
Author:Tony Lindgren
AuthorDate:Thu, 07 May 2020 10:23:18 -07:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 46b30515f97ece3da661b251e4a0ad9ac7a338d3
Gitweb:
https://git.kernel.org/tip/46b30515f97ece3da661b251e4a0ad9ac7a338d3
Author:Tony Lindgren
AuthorDate:Thu, 07 May 2020 10:23:17 -07:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: c177e2975430cec296aa52a0d413e447417d6cf9
Gitweb:
https://git.kernel.org/tip/c177e2975430cec296aa52a0d413e447417d6cf9
Author:Tony Lindgren
AuthorDate:Tue, 19 May 2020 08:51:57 -07:00
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 6d15120b282e49811a47f2f6d6b749d178be7e99
Gitweb:
https://git.kernel.org/tip/6d15120b282e49811a47f2f6d6b749d178be7e99
Author:Tony Lindgren
AuthorDate:Tue, 19 May 2020 08:51:57 -07:00
call the existing PM runtime suspend functions on suspend.
Fixes: cef766300353 ("drm/omap: Prepare DSS for probing without legacy platform
data")
Reported-by: Faiz Abbas
Cc: dri-de...@lists.freedesktop.org
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
ivity for enable and
disable")
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/driv
t quirks for dynamically
allocated modules")
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
arch/arm/mach-omap2/omap_hwmod.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -1553,7 +1553,7 @@ static
that still seems to be pending.
Anyways, no luck getting the LCD enabled on am437x-sk-evm with v5.6
or v5.7-rc kernels.
Regards,
Tony
Tony Lindgren (5):
drm/omap: Fix suspend resume regression after platform data removal
bus: ti-sysc: Use optional clocks on for enable and wait for softres
k")
Reported-by: Faiz Abbas
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 81 ---
1 file changed, 61 insertions(+), 20 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/d
o initialize
> the clocks and the timer. Just remove it here and make it the default.
>
> Removing the guard around the set_cntfreq() definition, I noticed that
> this is not properly namespaced, so fix that as well.
Looks good to me, thanks for fixing it:
Acked-by: Tony Lindgren
* Tony Lindgren [200527 16:06]:
> * Tony Lindgren [200519 09:05]:
> > * Tomi Valkeinen [200519 15:55]:
> > > (Dropping DT from cc)
> > >
> > > On 19/05/2020 18:48, Tony Lindgren wrote:
> > >
> > > > > > Suspend/resume on am
* Arnd Bergmann [200529 21:41]:
> On Fri, May 29, 2020 at 11:14 PM Tony Lindgren wrote:
> > * Arnd Bergmann [200529 21:09]:
> > >
> > > #ifdef CONFIG_SOC_HAS_REALTIME_COUNTER
> > > extern void omap5_realtime_timer_init(void);
> > > #else
> >
* Arnd Bergmann [200529 21:09]:
> On Fri, May 29, 2020 at 10:44 PM Tony Lindgren wrote:
> >
> > * Arnd Bergmann [200529 20:18]:
> > > There is one more regression introduced by the last build fix:
> >
> > Argh.. I did run make randconfig for l
* Arnd Bergmann [200529 20:18]:
> There is one more regression introduced by the last build fix:
Argh.. I did run make randconfig for like 10 builds
after the last fix.
> arch/arm/mach-omap2/timer.c:170:6: error: attribute declaration must precede
> definition [-Werror,-Wignored-attributes]
> v
he need for any cleanup as the driver infrastructure will
> take care of that.
>
> Let us remove device_create_file and start using the custom attribute
> group in soc_device_attribute.
Acked-by: Tony Lindgren
* Sudeep Holla [200523 17:10]:
> Move device attributes to DEVICE_ATTR_RO() as that would make things
> a lot more "obvious" what is happening over the existing __ATTR usage.
Acked-by: Tony Lindgren
* Drew Fustini [200528 13:17]:
> FYI - Linus W. provided an Acked-by in related thread [0].
>
> Anyone else have any review comments?
Looks good to me thanks. But as the merge window is about
to open, let's do fixes only at this point and leave this
for v5.9.
Regards,
Tony
>
> [0]
> https:
Hi,
* Johan Hovold [200528 13:07]:
> On Tue, May 12, 2020 at 02:47:12PM -0700, Tony Lindgren wrote:
> > +/*
> > + * Motorola MDM GNSS device communicates over a dedicated TS 27.010 channel
> > + * using custom data packets. The packets look like AT commands embedded
> &
* Arnd Bergmann [200528 20:35]:
> On Thu, May 28, 2020 at 6:18 PM wrote:
> > On 5/28/20 8:57 AM, Tony Lindgren wrote:
> > > * Tony Lindgren [200528 13:51]:
> > >> * Tony Lindgren [200528 13:47]:
> > >>> * Arnd Bergmann [200528 09:20]:
> > >
* Tony Lindgren [200528 13:51]:
> * Tony Lindgren [200528 13:47]:
> > * Arnd Bergmann [200528 09:20]:
> > > The OMAP4 timer code had a special hack for using the broadcast timer
> > > without SMP. Since the dmtimer is now gone, this also needs to be dropped
> >
* Tony Lindgren [200528 13:47]:
> * Arnd Bergmann [200528 09:20]:
> > The OMAP4 timer code had a special hack for using the broadcast timer
> > without SMP. Since the dmtimer is now gone, this also needs to be dropped
> > to avoid a link failure for non-SMP AM43xx configurat
* Arnd Bergmann [200528 09:20]:
> The OMAP4 timer code had a special hack for using the broadcast timer
> without SMP. Since the dmtimer is now gone, this also needs to be dropped
> to avoid a link failure for non-SMP AM43xx configurations:
>
> kernel/time/tick-broadcast.o: in function `tick_devi
* H. Nikolaus Schaller [200523 17:34]:
> If irq flags are not cleared for certain operations we
> print an error message.
>
> Since this should never occur in normal operation, this
> patch is an optional safety-net and debugging tool.
Acked-by: Tony Lindgren
s overwritten
> by a second interrupt, independent of whether the
> previous interrupt was already processed or not.
>
> This patch improves interrupt handling to avoid such
> races and loss of interrupt flags.
Good to hear you got it figured out :) Looks OK to me:
Acked-by: Tony Lindgren
* Tony Lindgren [200519 09:05]:
> * Tomi Valkeinen [200519 15:55]:
> > (Dropping DT from cc)
> >
> > On 19/05/2020 18:48, Tony Lindgren wrote:
> >
> > > > > Suspend/resume on am43xx-gpevm is broken right now in mainline and
> > > > >
sable, and we don't want to have the
module potentially stay active while we're trying to disable the clock.
Fixes: d59b60564cbf ("bus: ti-sysc: Add generic enable/disable functions")
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 6 ++
1 file changed, 6 inser
* H. Nikolaus Schaller [200523 17:34]:
> The code accidentially overwrites the variable ret and not val,
> which is returned. So it will return the initial value 0 instead
> of -1.
Oops, sorry about causing this. And thanks for catching it:
Acked-by: Tony Lindgren
* H. Nikolaus Schaller [200523 17:34]:
> Otherwise it will corrupt the console log during debugging.
Acked-by: Tony Lindgren
301 - 400 of 2858 matches
Mail list logo
