[PATCH RESEND net-next] tracing: remove holes in events

2021-03-12 Thread Tony Lu
es) -> 0 5. rpc_xdr_alignment 2 holes (8 bytes) -> 0 Link: https://www.spinics.net/lists/netdev/msg726308.html Link: https://www.spinics.net/lists/netdev/msg726451.html Cc: David Miller Cc: Eric Dumazet Cc: Steven Rostedt Cc: Ingo Molnar Suggested-by: Steven Rostedt Signed-off-by: Ton

Re: [PATCH] tracing: remove holes in events

2021-03-11 Thread Tony Lu
On Thu, Mar 11, 2021 at 08:56:19AM -0500, Steven Rostedt wrote: > On Thu, 11 Mar 2021 17:44:15 +0800 > Tony Lu wrote: > > > --- > > include/trace/events/net.h| 42 +-- > > include/trace/events/qdisc.h | 4 ++-- > > i

[PATCH] tracing: remove holes in events

2021-03-11 Thread Tony Lu
les (8 bytes) -> 0 5. rpc_xdr_alignment 2 holes (8 bytes) -> 0 Link: https://www.spinics.net/lists/netdev/msg726308.html Link: https://www.spinics.net/lists/netdev/msg726451.html Suggested-by: Steven Rostedt Signed-off-by: Tony Lu --- include/trace/ev

Re: [PATCH] net: add net namespace inode for all net_dev events

2021-03-10 Thread Tony Lu
On Wed, Mar 10, 2021 at 11:31:12AM -0500, Steven Rostedt wrote: > On Wed, 10 Mar 2021 17:03:40 +0800 > Tony Lu wrote: > > > I use pahole to read vmlinux.o directly with defconfig and > > CONFIG_DEBUG_INFO enabled, the result shows 22 structs prefixed with > > trace_ev

Re: [PATCH] net: add net namespace inode for all net_dev events

2021-03-10 Thread Tony Lu
On Wed, Mar 10, 2021 at 09:22:34AM +, Lorenz Bauer wrote: > On Tue, 9 Mar 2021 at 20:12, Eric Dumazet wrote: > > > > On 3/9/21 5:43 AM, Tony Lu wrote: > > > There are lots of net namespaces on the host runs containers like k8s. > > > It is very common to s

Re: [PATCH] net: add net namespace inode for all net_dev events

2021-03-10 Thread Tony Lu
On Tue, Mar 09, 2021 at 09:12:45PM +0100, Eric Dumazet wrote: > > > On 3/9/21 5:43 AM, Tony Lu wrote: > > There are lots of net namespaces on the host runs containers like k8s. > > It is very common to see the same interface names among different net > > namespac

Re: [PATCH] net: add net namespace inode for all net_dev events

2021-03-10 Thread Tony Lu
On Tue, Mar 09, 2021 at 12:40:11PM -0500, Steven Rostedt wrote: > On Tue, 9 Mar 2021 12:43:50 +0800 > Tony Lu wrote: > > > There are lots of net namespaces on the host runs containers like k8s. > > It is very common to see the same interface names among different net &g

[PATCH] net: add net namespace inode for all net_dev events

2021-03-08 Thread Tony Lu
distinguish between different net devices. Output: -0 [006] ..s. 133.306989: net_dev_xmit: net_inum=4026531992 dev=eth0 skbaddr=11a87c68 len=54 rc=0 Signed-off-by: Tony Lu --- include/trace/events/net.h | 35 +-- 1 file changed, 25 insertions

[PATCH net-next 1/3] udp: introduce a new tracepoint for udp_send_skb

2019-05-29 Thread Tony Lu
integrate into perf or ebpf. Signed-off-by: Tony Lu --- include/trace/events/udp.h | 81 ++ net/ipv4/udp.c | 1 + net/ipv6/udp.c | 2 + 3 files changed, 84 insertions(+) diff --git a/include/trace/events/udp.h b/include/trace/events/udp.h

[PATCH net-next 0/3] introduce two new tracepoints for udp

2019-05-29 Thread Tony Lu
This series introduces two new tracepoints trace_udp_send and trace_udp_queue_rcv, and removes redundant new line from tcp_event_sk_skb. Tony Lu (3): udp: introduce a new tracepoint for udp_send_skb udp: introduce a new tracepoint for udp_queue_rcv_skb tcp: remove redundant new line from

[PATCH net-next 2/3] udp: introduce a new tracepoint for udp_queue_rcv_skb

2019-05-29 Thread Tony Lu
This introduces a new tracepoint trace_udp_queue_rcv, it will trace UDP packets that are going to be queued on the socket receive queue. Signed-off-by: Tony Lu --- include/trace/events/udp.h | 7 +++ net/ipv4/udp.c | 1 + net/ipv6/udp.c | 1 + 3 files changed, 9

[PATCH net-next 3/3] tcp: remove redundant new line from tcp_event_sk_skb

2019-05-29 Thread Tony Lu
This removes '\n' from trace event class tcp_event_sk_skb to avoid redundant new blank line and make output compact. Signed-off-by: Tony Lu --- include/trace/events/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/tcp.h b/include/trace/ev

RE: [PATCH v2] flush_icache_range: Export symbol to fix build errors

2014-08-20 Thread Tony Lu
>-Original Message- >Fix building errors occuring due to a missing export of flush_icache_range() >in > >kisskb.ellerman.id.au/kisskb/buildresult/11677809/ > >ERROR: "flush_icache_range" [drivers/misc/lkdtm.ko] undefined! > >Signed-off-by: Pranith Kumar >Reported-by: Geert Uytterhoeven >C

RE: [BUG] perf: can not resolve symbols for forked threads

2014-06-23 Thread Tony Lu
Thanks for your reply. >-Original Message- >From: Peter Zijlstra [mailto:pet...@infradead.org] >Sent: Monday, June 23, 2014 5:13 PM >To: Tony Lu >Cc: Paul Mackerras; Ingo Molnar; Arnaldo Carvalho de Melo; >linux-kernel@vger.kernel.org; Chris Metcalf >Subject: Re

[BUG] perf: can not resolve symbols for forked threads

2014-06-19 Thread Tony Lu
Hi I got the below output that shows perf can not resolve symbols for forked threads. I did a system-wide collection from all CPUs after the application hello run. -bash-4.1$ ./perf --version perf version 3.16.rc1.ge99cfa2 -bash-4.1$ ./hello & ./perf record -a sleep 5 -bash-4.1$ ./perf report #

RE: [PATCH 1/4] tile: Add support for handling PMC hardware

2014-03-06 Thread Tony Lu
>-Original Message- >From: Peter Zijlstra [mailto:pet...@infradead.org] >Sent: Thursday, March 06, 2014 5:11 PM >To: Tony Lu >Cc: Paul Mackerras; Ingo Molnar; Arnaldo Carvalho de Melo; Chris Metcalf; >linux-kernel@vger.kernel.org >Subject: Re: [PATCH 1/4] tile: Add sup

RE: [PATCH 3/4] tile/perf: Support perf_events on tilegx and tilepro

2014-03-06 Thread Tony Lu
>-Original Message- >From: Peter Zijlstra [mailto:pet...@infradead.org] >Sent: Thursday, March 06, 2014 5:07 PM >To: Tony Lu >Cc: Paul Mackerras; Ingo Molnar; Arnaldo Carvalho de Melo; Chris Metcalf; >linux-kernel@vger.kernel.org >Subject: Re: [PATCH 3/4] tile/perf: S

[PATCH 4/4] perf tools: Allow building for tile

2014-03-05 Thread Tony Lu
Tested by building perf: - Cross-compiled for tile on x86_64 - Built natively on tile Signed-off-by: Zhigang Lu Signed-off-by: Chris Metcalf --- tools/perf/config/Makefile.arch | 3 ++- tools/perf/perf.h | 8 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/

[PATCH 3/4] tile/perf: Support perf_events on tilegx and tilepro

2014-03-05 Thread Tony Lu
Add perf support for tile architecture. Signed-off-by: Zhigang Lu Signed-off-by: Chris Metcalf --- arch/tile/Kconfig |2 + arch/tile/include/asm/perf_event.h | 22 + arch/tile/kernel/Makefile |1 + arch/tile/kernel/irq.c | 18 + arch/tile/kernel

[PATCH 2/4] tile: Enable NMIs on return from handle_nmi() without errors

2014-03-05 Thread Tony Lu
NMI interrupts mask ALL interrupts before calling the handler, so we need to unmask NMIs according to the value handle_nmi() returns. If it returns zero, the NMIs should be re-enabled; if it returns a non-zero error, the NMIs should be disabled. Signed-off-by: Zhigang Lu Signed-off-by: Chris Metc

[PATCH 1/4] tile: Add support for handling PMC hardware

2014-03-05 Thread Tony Lu
The PMC module is used by perf_events, oprofile and watchdogs. Signed-off-by: Zhigang Lu Signed-off-by: Chris Metcalf --- arch/tile/Kconfig| 4 ++ arch/tile/include/asm/pmc.h | 64 +++ arch/tile/kernel/Makefile| 1 + arch/tile/kernel/intvec_32.S | 13 +

[PATCH 0/4] tile: Add perf_events support for tile

2014-03-05 Thread Tony Lu
From: Zhigang Lu This patchset adds perf support for tile architecture. The code is based on x86 perf event code, and it has been tested on tile for 2 years. Zhigang Lu (4): tile: Add support for handling PMC hardware tile: Enable NMIs on return from handle_nmi() without errors tile/perf:

RE: [PATCH] perf tools: Fix the logic of thread__fork

2014-02-10 Thread Tony Lu
Thanks, I see. I was using the mainline tree, but it was just updated to 3.13-rc8. >-Original Message- >From: Arnaldo Carvalho de Melo [mailto:arnaldo.m...@gmail.com] On Behalf Of >Arnaldo Carvalho de Melo >Sent: Monday, February 10, 2014 8:39 PM >To: Tony Lu >Cc: Pe

[PATCH] perf tools: Fix the logic of thread__fork

2014-02-09 Thread Tony Lu
Revert the logic of checking the return value of thread__set_comm(). If thread__set_comm() returns zero without errors, we should not return immediately, instead we should finish the rest of the clone work. Otherwise, perf report would fail to resolve symbols sampled in forked threads. Signed-off

[PATCH] ftrace: default to tilegx if ARCH=tile is specified

2013-12-05 Thread Tony Lu
This matches the existing behavior in arch/tile/Makefile for defconfig. Reported-by: fengguang...@intel.com Signed-off-by: Tony Lu Signed-off-by: Chris Metcalf --- Chris Metcalf will push this change via the tile tree. scripts/recordmcount.pl | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH v2] tile: support kprobes on tilegx

2013-08-13 Thread Tony Lu
This change includes support for Kprobes, Jprobes and Return Probes. Signed-off-by: Tony Lu Signed-off-by: Chris Metcalf --- v2: implement Masami Hiramatsu's suggestion to add an insn_has_control() check to disallow placing probes on instructions that modify control flow. We can improve th

[PATCH v2] tile: support ASLR fully

2013-08-13 Thread Tony Lu
With this change, tile Linux now supports address-space layout randomization for shared objects, stack, heap and vdso. Signed-off-by: Tony Lu Signed-off-by: Chris Metcalf --- v2: implement Jiri Kosina's suggestion to copy the math in mmap_rnd() for x86. arch/tile/include/asm/elf.h

[PATCH] tile: support ASLR fully

2013-08-09 Thread Tony Lu
With this change, tile Linux now supports address-space layout randomization for shared objects, stack, heap and vdso. Signed-off-by: Tony Lu Signed-off-by: Chris Metcalf --- arch/tile/include/asm/elf.h | 4 arch/tile/mm/mmap.c | 20 ++-- 2 files changed, 22

[PATCH] tile: support ftrace on tilegx

2013-08-09 Thread Tony Lu
This commit adds support for static ftrace, graph function support, and dynamic tracer support. Signed-off-by: Tony Lu Signed-off-by: Chris Metcalf --- I assume it makes sense for this to be pushed via the tile tree; it's currently queued in tile-next. arch/tile/Kconfig

[PATCH] tile: support kprobes on tilegx

2013-08-09 Thread Tony Lu
This change includes support for Kprobes, Jprobes and Return Probes. Signed-off-by: Tony Lu Signed-off-by: Chris Metcalf --- I assume it makes sense for this to be pushed via the tile tree; it's currently queued in tile-next. arch/tile/Kconfig| 2 + arch

RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-03-04 Thread Tony Lu
t;-Original Message- >From: Mark Tinguely [mailto:tingu...@sgi.com] >Sent: Saturday, March 02, 2013 4:24 AM >To: Tony Lu >Cc: Alex Elder; linux-kernel@vger.kernel.org; Chris Metcalf; x...@oss.sgi.com; >Ben Myers; Dave Chinner; linux-fsde...@vger.kernel.org >Subjec

RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-02-23 Thread Tony Lu
>> For example, if xlog_bread_noalign() wants to read blocks from #1 >> to # 9, in which case the passed parameter blk_no is 1, and nbblks >> is 8, sectBBsize is 8, after the round down and round up >> operations, we get blk_no as 0, and nbblks as still 8. We >> definitely lose the last block of th

RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-02-23 Thread Tony Lu
>-Original Message- >From: Ben Myers [mailto:b...@sgi.com] > >Hi Tony, > >On Fri, Feb 22, 2013 at 08:12:52AM +, Tony Lu wrote: >> I encountered the following panic when using xfs partitions as rootfs, which >> is due to the truncated log data read by x

RE: [PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-02-22 Thread Tony Lu
>From: Dave Chinner [mailto:da...@fromorbit.com] >On Fri, Feb 22, 2013 at 08:12:52AM +, Tony Lu wrote: >> I encountered the following panic when using xfs partitions as rootfs, which >> is due to the truncated log data read by xlog_bread_noalign(). We should >> extend

[PATCH] xfs: Fix possible truncation of log data in xlog_bread_noalign()

2013-02-22 Thread Tony Lu
I encountered the following panic when using xfs partitions as rootfs, which is due to the truncated log data read by xlog_bread_noalign(). We should extend the buffer by one extra log sector to ensure there's enough space to accommodate requested log data, which we indeed did in xlog_get_bp(), but

Fix perf DSOs' map address if .text is not the first secion of vmlinux

2012-11-08 Thread Tony Lu
>From 1bacfabf8369764126758bbbea1d3963ac778cce Mon Sep 17 00:00:00 2001 From: Lu Zhigang Date: Thu, 8 Nov 2012 04:31:05 -0500 Subject: [PATCH 1/1] perf symbol: Don't assume .text section is the first section of vmlinux The start address derived from /proc/kallsyms in is the start address of kern