[PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-14 Thread Tony Prisk
with dev_err in vt8500_add_chips since the device is available. There is also no .remove callback defined. To allow removing the registered chips, I have moved *vtchip to be a static global. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- Hi Grant, Let me know what you think of these changes. v2

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-14 Thread Tony Prisk
On Mon, 2013-01-14 at 12:07 -0800, Olof Johansson wrote: On Mon, Jan 14, 2013 at 06:47:35PM +1300, Tony Prisk wrote: On Mon, 2013-01-14 at 18:13 +1300, Tony Prisk wrote: On Mon, 2013-01-14 at 18:09 +1300, Tony Prisk wrote: This patch moves arch-vt8500/timer.c into drivers/clocksource

Re: [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-14 Thread Tony Prisk
On Mon, 2013-01-14 at 09:34 -0700, Stephen Warren wrote: On 01/13/2013 10:09 PM, Tony Prisk wrote: This patch moves arch-vt8500/timer.c into drivers/clocksource and updates the necessary Kconfig/Makefile options. diff --git a/include/linux/vt8500_timer.h b/include/linux/vt8500_timer.h

[PATCH 2/4] serial: vt8500: ioremap'd resource is never freed

2013-01-14 Thread Tony Prisk
Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EBUSY rather than -EADDRNOTAVAIL. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/tty/serial

[PATCH 1/4] serial: vt8500: Fix range-checking on vt8500_uart_ports

2013-01-14 Thread Tony Prisk
Fix two instances where the index to vt8500_uart_ports is tested against VT8500_MAX_PORTS. Correct usage should be = VT8500_MAX_PORTS. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/tty/serial/vt8500_serial.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[GIT PULL v2] Fixes/cleanup for vt8500 serial driver

2013-01-14 Thread Tony Prisk
:36:50 +1300) Series of fixes/cleanups for vt8500 serial/UART driver Tony Prisk (4): serial: vt8500: Fix range-checking on vt8500_uart_ports serial: vt8500

[PATCH 4/4] serial: tty: Cleanup code using devm_ function

2013-01-14 Thread Tony Prisk
Convert the last memory allocation (vt8500_port) to use devm_kzalloc and remove the fail path cleanup code from vt8500_serial_probe. Reorder iomem mapping above clk_enable to simplify fail code. The clock is only enabled if all other resources are available. Signed-off-by: Tony Prisk li

[PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference

2013-01-14 Thread Tony Prisk
, enables the clock in probe. This change removes the fallback when a clock was not specified as it doesn't apply any longer (and would only work if the UART clock was already enabled). DTSI files are updated for VT8500, WM8505 and WM8650. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch

Re: [PATCH 2/4] serial: vt8500: ioremap'd resource is never freed

2013-01-14 Thread Tony Prisk
On Tue, 2013-01-15 at 17:58 +1300, Tony Prisk wrote: Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EBUSY rather than -EADDRNOTAVAIL. Grr.. I

Re: [PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-14 Thread Tony Prisk
On Tue, 2013-01-15 at 07:37 +1300, Tony Prisk wrote: This driver is missing a .remove callback, and the fail path on probe is incomplete. If an error occurs in vt8500_add_chips, gpio_base is not unmapped. The driver is also ignoring the return value from this function so if a chip fails

[PATCH] timer: vt8500: Convert vt8500 to use CLKSRC_OF

2013-01-14 Thread Tony Prisk
This patch converts arch-vt8500 to make use of CLKSRC_OF. Doing so removes the need for include/linux/vt8500_timer.h as vt8500_timer_init no longer needs to be visible outside vt8500_timer.c Signed-off-by: Tony Prisk li...@prisktech.co.nz --- Hi Olof, Here is the fix as requested by Stephen

rtc: vt8500: Fix year field in vt8500_rtc_set_time

2013-01-14 Thread Tony Prisk
Alessandro, This patch was sent out at the same time as two other RTC fixes for vt8500 but this one seems to have stopped somewhere along the way while the other two have been accepted. The patch is showing in the RTC patch system along with the other two:

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
> Oh grr.. forget this completely. It doesn't take into account the > patches I already sent for WM8850. > > I guess it needs to be based on timer/cleanup + vt8500/wm8x50. > > Need a little advise on how to handle this one please :) > > Regards > Tony P Turns out the original patch applies

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
On Mon, 2013-01-14 at 18:13 +1300, Tony Prisk wrote: > On Mon, 2013-01-14 at 18:09 +1300, Tony Prisk wrote: > > This patch moves arch-vt8500/timer.c into drivers/clocksource and > > updates the necessary Kconfig/Makefile options. > > > > Signed-off-by: Tony Prisk

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
On Mon, 2013-01-14 at 18:09 +1300, Tony Prisk wrote: > This patch moves arch-vt8500/timer.c into drivers/clocksource and > updates the necessary Kconfig/Makefile options. > > Signed-off-by: Tony Prisk > --- > arch/arm/mach-vt8500/Kconfig |1 + > arch/arm

[GIT PULL] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
Tony Prisk (1): timer: vt8500: Move timer code to drivers/clocksource arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h |1 - arch/arm/mach-vt8500/vt8500.c

[PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
This patch moves arch-vt8500/timer.c into drivers/clocksource and updates the necessary Kconfig/Makefile options. Signed-off-by: Tony Prisk --- arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h |1 - arch/arm/mach

[GIT PULL] Fixes/cleanup for vt8500 serial driver

2013-01-13 Thread Tony Prisk
. Tony Prisk (4): serial: vt8500: Fix range-checking on vt8500_uart_ports serial: vt8500: ioremap'd resource is never freed serial: vt8500: UART uses gated clock rather than 24Mhz reference serial: tty: Cleanup code using devm_ function

[PATCH 1/4] serial: vt8500: Fix range-checking on vt8500_uart_ports

2013-01-13 Thread Tony Prisk
Fix two instances where the index to vt8500_uart_ports is tested against > VT8500_MAX_PORTS. Correct usage should be >= VT8500_MAX_PORTS. Signed-off-by: Tony Prisk --- drivers/tty/serial/vt8500_serial.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 2/4] serial: vt8500: ioremap'd resource is never freed

2013-01-13 Thread Tony Prisk
Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EBUSY rather than -ENOMEM. Signed-off-by: Tony Prisk --- drivers/tty/serial/vt8500_serial.c |4

[PATCH 4/4] serial: tty: Cleanup code using devm_ function

2013-01-13 Thread Tony Prisk
Convert the last memory allocation (vt8500_port) to use devm_kzalloc and remove the fail path cleanup code from vt8500_serial_probe. Reorder iomem mapping above clk_enable to simplify fail code. The clock is only enabled if all other resources are available. Signed-off-by: Tony Prisk

[PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference

2013-01-13 Thread Tony Prisk
, enables the clock in probe. This change removes the fallback when a clock was not specified as it doesn't apply any longer (and would only work if the UART clock was already enabled). DTSI files are updated for VT8500, WM8505 and WM8650. Signed-off-by: Tony Prisk --- arch/arm/boot/dts/vt8500

[PATCH 3/4] serial: vt8500: UART uses gated clock rather than 24Mhz reference

2013-01-13 Thread Tony Prisk
, enables the clock in probe. This change removes the fallback when a clock was not specified as it doesn't apply any longer (and would only work if the UART clock was already enabled). DTSI files are updated for VT8500, WM8505 and WM8650. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch

[PATCH 4/4] serial: tty: Cleanup code using devm_ function

2013-01-13 Thread Tony Prisk
Convert the last memory allocation (vt8500_port) to use devm_kzalloc and remove the fail path cleanup code from vt8500_serial_probe. Reorder iomem mapping above clk_enable to simplify fail code. The clock is only enabled if all other resources are available. Signed-off-by: Tony Prisk li

[PATCH 2/4] serial: vt8500: ioremap'd resource is never freed

2013-01-13 Thread Tony Prisk
Memory mapped via ioremap call is never released. Rather than add an iounmap call, change allocation function to devm_request_and_ioremap. Also, change the error on failure for this call to -EBUSY rather than -ENOMEM. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/tty/serial

[GIT PULL] Fixes/cleanup for vt8500 serial driver

2013-01-13 Thread Tony Prisk
. Tony Prisk (4): serial: vt8500: Fix range-checking on vt8500_uart_ports serial: vt8500: ioremap'd resource is never freed serial: vt8500: UART uses gated clock rather than 24Mhz reference serial: tty: Cleanup code using devm_ function

[PATCH 1/4] serial: vt8500: Fix range-checking on vt8500_uart_ports

2013-01-13 Thread Tony Prisk
Fix two instances where the index to vt8500_uart_ports is tested against VT8500_MAX_PORTS. Correct usage should be = VT8500_MAX_PORTS. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/tty/serial/vt8500_serial.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
This patch moves arch-vt8500/timer.c into drivers/clocksource and updates the necessary Kconfig/Makefile options. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h

[GIT PULL] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
Tony Prisk (1): timer: vt8500: Move timer code to drivers/clocksource arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h |1 - arch/arm/mach-vt8500/vt8500.c

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
On Mon, 2013-01-14 at 18:09 +1300, Tony Prisk wrote: This patch moves arch-vt8500/timer.c into drivers/clocksource and updates the necessary Kconfig/Makefile options. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach-vt8500

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
On Mon, 2013-01-14 at 18:13 +1300, Tony Prisk wrote: On Mon, 2013-01-14 at 18:09 +1300, Tony Prisk wrote: This patch moves arch-vt8500/timer.c into drivers/clocksource and updates the necessary Kconfig/Makefile options. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch/arm

Re: [Bulk] [PATCH] timer: vt8500: Move timer code to drivers/clocksource

2013-01-13 Thread Tony Prisk
Oh grr.. forget this completely. It doesn't take into account the patches I already sent for WM8850. I guess it needs to be based on timer/cleanup + vt8500/wm8x50. Need a little advise on how to handle this one please :) Regards Tony P Turns out the original patch applies cleanly on

[PATCH] mmc: vt8500: Remove erroneous __exitp in wmt_mci_driver

2013-01-12 Thread Tony Prisk
With the __devinit/__devexit attributes having been removed, this __exitp attribute causes an unused function warning and should be removed as well. Signed-off-by: Tony Prisk --- drivers/mmc/host/wmt-sdmmc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host

[PATCH] mmc: vt8500: Remove erroneous __exitp in wmt_mci_driver

2013-01-12 Thread Tony Prisk
With the __devinit/__devexit attributes having been removed, this __exitp attribute causes an unused function warning and should be removed as well. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/mmc/host/wmt-sdmmc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[GIT PULL] clk: vt8500: Clock fixes for 3.8

2013-01-11 Thread Tony Prisk
to a3c2b58889440dcc6de92d04f09e8fcaf6bf7e2e: clk: vt8500: Fix division-by-0 when requested rate=0 (2012-12-27 13:07:23 +1300) clk: vt8500: Clock fixes for v3.8 Small series of fixes for clocks on vt8500. Signed-off-by: Tony Prisk

Re: [PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
/git/linuxwmt.git tags/vt8500-multiplatform-3.9 Tony Prisk (1): arm: vt8500: Add support for Wondermedia WM8750/WM8850 Documentation/devicetree/bindings/arm/vt8500.txt |8 arch/arm/mach-vt8500/Kconfig

Re: [PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
to ce3f386fdf10d79eaf6ebd63bb7adbd95f08f9f0: arm: vt8500: Remove remaining mach includes (2013-01-12 15:47:39 +1300) arm: vt8500: Convert arch-vt8500 to multiplatform only. Tony Prisk (3

Re: [PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
> I suggest that you split off the last three (and rebase them to be > independent), and apply them to a multiplatform branch for vt8500. Then the > last one is a soc branch that goes on top of the multiplatform branch (i.e. > you > build it on top of multiplatform). That way we can pull in the

[PATCH 3/4] arm: vt8500: Convert debug-macro.S to be multiplatform friendly

2013-01-11 Thread Tony Prisk
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to arm/include/debug/vt8500.S to provide multiplatform support. Minor style changes in code for readability. Signed-off-by: Tony Prisk --- arch/arm/Kconfig.debug |8 + arch/arm/include/debug

[PATCH 4/4] arm: vt8500: Remove remaining mach includes

2013-01-11 Thread Tony Prisk
Remove the last two mach-vt8500/include/mach headers as they are no longer required with multiplatform-only configuration. Signed-off-by: Tony Prisk --- arch/arm/mach-vt8500/include/mach/timex.h | 26 - arch/arm/mach-vt8500/include/mach/uncompress.h | 37

[PATCH 2/4] arm: vt8500: Remove single platform Kconfig options

2013-01-11 Thread Tony Prisk
This patch completes the move of arch-vt8500 to multiplatform only. The remaining single-image Kconfig options are removed from arch/arm/Kconfig and the options in arch/arm/mach-vt8500/Kconfig are updated. Signed-off-by: Tony Prisk --- arch/arm/Kconfig | 21

[PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
up changes for multiplatform configuration. Single platform Kconfig options are removed, along with the remaining mach/includes. The debug-macro.s is moved to arm/include/debug/ to allow DEBUG_LL on multi-platform. Signed-off-by: Tony Prisk

[PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7). Common features across all SoCs are split into ARCH_VT8500 and unique features are specified by each SoC option. Signed-off-by: Tony Prisk --- Documentation/devicetree/bindings/arm/vt8500.txt |8 ++ arch/arm/Kconfig

[PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7). Common features across all SoCs are split into ARCH_VT8500 and unique features are specified by each SoC option. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- Documentation/devicetree/bindings/arm/vt8500.txt |8

[PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
up changes for multiplatform configuration. Single platform Kconfig options are removed, along with the remaining mach/includes. The debug-macro.s is moved to arm/include/debug/ to allow DEBUG_LL on multi-platform. Signed-off-by: Tony Prisk li...@prisktech.co.nz

[PATCH 2/4] arm: vt8500: Remove single platform Kconfig options

2013-01-11 Thread Tony Prisk
This patch completes the move of arch-vt8500 to multiplatform only. The remaining single-image Kconfig options are removed from arch/arm/Kconfig and the options in arch/arm/mach-vt8500/Kconfig are updated. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch/arm/Kconfig | 21

[PATCH 4/4] arm: vt8500: Remove remaining mach includes

2013-01-11 Thread Tony Prisk
Remove the last two mach-vt8500/include/mach headers as they are no longer required with multiplatform-only configuration. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch/arm/mach-vt8500/include/mach/timex.h | 26 - arch/arm/mach-vt8500/include/mach/uncompress.h

[PATCH 3/4] arm: vt8500: Convert debug-macro.S to be multiplatform friendly

2013-01-11 Thread Tony Prisk
This patch moves debug-macro.S from arm/mach-vt8500/include/mach to arm/include/debug/vt8500.S to provide multiplatform support. Minor style changes in code for readability. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- arch/arm/Kconfig.debug |8 + arch

Re: [PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
I suggest that you split off the last three (and rebase them to be independent), and apply them to a multiplatform branch for vt8500. Then the last one is a soc branch that goes on top of the multiplatform branch (i.e. you build it on top of multiplatform). That way we can pull in the

Re: [PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
to ce3f386fdf10d79eaf6ebd63bb7adbd95f08f9f0: arm: vt8500: Remove remaining mach includes (2013-01-12 15:47:39 +1300) arm: vt8500: Convert arch-vt8500 to multiplatform only. Tony Prisk (3

Re: [PATCH 0/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-11 Thread Tony Prisk
/git/linuxwmt.git tags/vt8500-multiplatform-3.9 Tony Prisk (1): arm: vt8500: Add support for Wondermedia WM8750/WM8850 Documentation/devicetree/bindings/arm/vt8500.txt |8 arch/arm/mach-vt8500/Kconfig

[GIT PULL] clk: vt8500: Clock fixes for 3.8

2013-01-11 Thread Tony Prisk
to a3c2b58889440dcc6de92d04f09e8fcaf6bf7e2e: clk: vt8500: Fix division-by-0 when requested rate=0 (2012-12-27 13:07:23 +1300) clk: vt8500: Clock fixes for v3.8 Small series of fixes for clocks on vt8500. Signed-off-by: Tony Prisk li...@prisktech.co.nz

[PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-10 Thread Tony Prisk
with dev_err in vt8500_add_chips since the device is available. There is also no .remove callback defined. To allow removing the registered chips, I have moved *vtchip to be a static global. Signed-off-by: Tony Prisk --- v2: Remove global variable and use platform_set_drvdata instead. drivers/gpio

Re: [PATCH] gpio: vt8500: memory cleanup missing

2013-01-10 Thread Tony Prisk
On Thu, 2013-01-10 at 13:02 +0100, Linus Walleij wrote: > On Thu, Jan 10, 2013 at 11:57 AM, Russell King - ARM Linux > wrote: > > On Thu, Jan 03, 2013 at 10:47:20AM +1300, Tony Prisk wrote: > > >> +static int vt8500_gpio_remove(struct platform_device *pdev)

Re: [PATCH] gpio: vt8500: Export dedicated GPIO before multifunction pins.

2013-01-10 Thread Tony Prisk
On Thu, 2013-01-10 at 11:49 +0100, Linus Walleij wrote: > On Sun, Dec 30, 2012 at 9:29 PM, Tony Prisk wrote: > > > The vendor does not provide numbering for gpio pins. Vendor source > > exports dedicated gpio pins first, followed by multifunction pins. > > As this

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-10 Thread Tony Prisk
On Thu, 2013-01-10 at 10:21 +, Arnd Bergmann wrote: > On Thursday 10 January 2013, Tony Prisk wrote: > > On Wed, 2013-01-09 at 21:27 +, Arnd Bergmann wrote: > > > > > > > Should patches in pull-requests have Ack'd lines already? > > > > This is

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-10 Thread Tony Prisk
On Thu, 2013-01-10 at 10:21 +, Arnd Bergmann wrote: On Thursday 10 January 2013, Tony Prisk wrote: On Wed, 2013-01-09 at 21:27 +, Arnd Bergmann wrote: Should patches in pull-requests have Ack'd lines already? This is what I thought - and the reason I haven't sent a pull

Re: [PATCH] gpio: vt8500: Export dedicated GPIO before multifunction pins.

2013-01-10 Thread Tony Prisk
On Thu, 2013-01-10 at 11:49 +0100, Linus Walleij wrote: On Sun, Dec 30, 2012 at 9:29 PM, Tony Prisk li...@prisktech.co.nz wrote: The vendor does not provide numbering for gpio pins. Vendor source exports dedicated gpio pins first, followed by multifunction pins. As this is what end users

Re: [PATCH] gpio: vt8500: memory cleanup missing

2013-01-10 Thread Tony Prisk
On Thu, 2013-01-10 at 13:02 +0100, Linus Walleij wrote: On Thu, Jan 10, 2013 at 11:57 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 03, 2013 at 10:47:20AM +1300, Tony Prisk wrote: +static int vt8500_gpio_remove(struct platform_device *pdev) +{ + int i

[PATCH v2] gpio: vt8500: memory cleanup missing

2013-01-10 Thread Tony Prisk
with dev_err in vt8500_add_chips since the device is available. There is also no .remove callback defined. To allow removing the registered chips, I have moved *vtchip to be a static global. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- v2: Remove global variable and use platform_set_drvdata

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-09 Thread Tony Prisk
On Wed, 2013-01-09 at 21:27 +, Arnd Bergmann wrote: > On Wednesday 09 January 2013, Tony Prisk wrote: > > I'm quite happy to send a pull request if that's what you prefer. > > > > Generally people have just taken the patches straight from email, so > > everytime I'v

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-09 Thread Tony Prisk
On Tue, 2013-01-08 at 22:30 -0800, Olof Johansson wrote: > On Tue, Jan 8, 2013 at 10:13 PM, Tony Prisk wrote: > > On Fri, 2012-12-28 at 12:20 +1300, Tony Prisk wrote: > >> This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7). > >> > >> Commo

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-09 Thread Tony Prisk
On Tue, 2013-01-08 at 22:30 -0800, Olof Johansson wrote: On Tue, Jan 8, 2013 at 10:13 PM, Tony Prisk li...@prisktech.co.nz wrote: On Fri, 2012-12-28 at 12:20 +1300, Tony Prisk wrote: This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7). Common features across all SoCs

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-09 Thread Tony Prisk
On Wed, 2013-01-09 at 21:27 +, Arnd Bergmann wrote: On Wednesday 09 January 2013, Tony Prisk wrote: I'm quite happy to send a pull request if that's what you prefer. Generally people have just taken the patches straight from email, so everytime I've done a pull-request I get a reply

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-08 Thread Tony Prisk
On Fri, 2012-12-28 at 12:20 +1300, Tony Prisk wrote: > This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7). > > Common features across all SoCs are split into ARCH_VT8500 and > unique features are specified by each SoC option. > > Signed-off-by: Tony Pris

Re: [PATCH 1/4] arm: vt8500: Add support for Wondermedia WM8750/WM8850

2013-01-08 Thread Tony Prisk
On Fri, 2012-12-28 at 12:20 +1300, Tony Prisk wrote: This patch adds support for the WM8750 (ARMv6) and WM8850 (ARMv7). Common features across all SoCs are split into ARCH_VT8500 and unique features are specified by each SoC option. Signed-off-by: Tony Prisk li...@prisktech.co.nz Hi Arnd

Re: [PATCH 2/2] irqchip: vt8500: Move irq code to drivers/irqchip

2013-01-02 Thread Tony Prisk
On Wed, 2013-01-02 at 22:38 -0600, Rob Herring wrote: > > CC: Thomas Gleixner > > arch/arm/mach-vt8500/Makefile |2 +- > > arch/arm/mach-vt8500/common.h |7 +- > > arch/arm/mach-vt8500/irq.c| 253 > > - > > drivers/irqchip/Makefile |

[PATCH 2/2] irqchip: vt8500: Move irq code to drivers/irqchip

2013-01-02 Thread Tony Prisk
Move mach-vt8500/irq.c to drivers/irqchip/irq-vt8500.c and make necessary Makefile changes. No code changes required. Signed-off-by: Tony Prisk --- CC: Thomas Gleixner arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h |7 +- arch/arm/mach-vt8500/irq.c| 253

[PATCH 0/2] Move some mach-vt8500 functions to new directories

2013-01-02 Thread Tony Prisk
and clocksource so maybe he wants to take both. CC: John Stultz CC: Thomas Gleixner Tony Prisk (2): timer: vt8500: Move system timer to clocksource irqchip: vt8500: Move irq code to drivers/irqchip arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach-vt8500/Makefile |2 +- arch

[PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-02 Thread Tony Prisk
Move mach-vt8500/timer.c to drivers/clocksource/vt8500_timer.c and make necessary changes to Kconfig and Makefile. vt8500_timer is moved from vt8500.c to clocksource/vt8500_timer.c and added to common.h for reference from the board descriptor. Signed-off-by: Tony Prisk --- CC: John Stultz CC

[PATCH] gpio: vt8500: memory cleanup missing

2013-01-02 Thread Tony Prisk
with dev_err in vt8500_add_chips since the device is available. There is also no .remove callback defined. To allow removing the registered chips, I have moved *vtchip to be a static global. Signed-off-by: Tony Prisk --- drivers/gpio/gpio-vt8500.c | 53

[PATCH 2/4] video: vt8500: Make wmt_ge_rops optional

2013-01-02 Thread Tony Prisk
At the moment, accelerated raster ops are always enabled on VT8500 and WM8xxx series SoCs. This patch makes them optional. Signed-off-by: Tony Prisk --- drivers/video/Kconfig | 23 +-- drivers/video/vt8500lcdfb.c | 15 +++ drivers/video/wm8505fb.c

[PATCH 3/4] video: vt8500: Remove unused platform_data/video-vt8500lcdfb.h

2013-01-02 Thread Tony Prisk
With the conversion to devicetree only for arch-vt8500, this header is no longer required. This patch removes the #include from the two framebuffer drivers that used it, and the header file. Signed-off-by: Tony Prisk --- drivers/video/vt8500lcdfb.c |2 -- drivers/video

[PATCH 4/4] video: vt8500: Update descriptions in video/Kconfig

2013-01-02 Thread Tony Prisk
This patch updates the descriptions for the VIA VT8500 and Wondermedia WM8xxx-series framebuffer drivers to correctly reflect which hardware they support. Signed-off-by: Tony Prisk --- drivers/video/Kconfig |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 1/4] drivers/video/wm8505fb.c: use devm_ functions

2013-01-02 Thread Tony Prisk
block of error-handling code that needs to call fb_dealloc_cmap, and so this is moved up to the place where it is needed, eliminating the need for all gotos and labels in the function. This was suggested by Tony Prisk. The initializations of fbi and ret at the beginning of the function

[PATCHv2 1/2] pwm: vt8500: Register write busy test performed incorrectly

2013-01-02 Thread Tony Prisk
. Change pwm_busy_wait() to use readl rather than readb. Improve readability of code with defines for registers and bitfields. Signed-off-by: Tony Prisk --- v2: Change parenthesis around defines Replace pr_warn with dev_warn in pwm_busy_wait() drivers/pwm/pwm-vt8500.c | 64

[PATCHv2 2/2] pwm: vt8500: Add polarity support

2013-01-02 Thread Tony Prisk
Add support to set polarity on PWM devices, allowing for inverted duty cycles. Also update the binding document to #pwm-cells = <3> to allow passing the flags from devicetree. Signed-off-by: Tony Prisk --- v2: Change binding document to detail flags usage. Add missing .of_xlate functi

[PATCHv2 2/2] pwm: vt8500: Add polarity support

2013-01-02 Thread Tony Prisk
Add support to set polarity on PWM devices, allowing for inverted duty cycles. Also update the binding document to #pwm-cells = 3 to allow passing the flags from devicetree. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- v2: Change binding document to detail flags usage. Add missing

[PATCHv2 1/2] pwm: vt8500: Register write busy test performed incorrectly

2013-01-02 Thread Tony Prisk
. Change pwm_busy_wait() to use readl rather than readb. Improve readability of code with defines for registers and bitfields. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- v2: Change parenthesis around defines Replace pr_warn with dev_warn in pwm_busy_wait() drivers/pwm/pwm-vt8500.c | 64

[PATCH 4/4] video: vt8500: Update descriptions in video/Kconfig

2013-01-02 Thread Tony Prisk
This patch updates the descriptions for the VIA VT8500 and Wondermedia WM8xxx-series framebuffer drivers to correctly reflect which hardware they support. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/video/Kconfig |9 + 1 file changed, 5 insertions(+), 4 deletions

[PATCH 1/4] drivers/video/wm8505fb.c: use devm_ functions

2013-01-02 Thread Tony Prisk
. This way there is only one block of error-handling code that needs to call fb_dealloc_cmap, and so this is moved up to the place where it is needed, eliminating the need for all gotos and labels in the function. This was suggested by Tony Prisk. The initializations of fbi and ret at the beginning

[PATCH 3/4] video: vt8500: Remove unused platform_data/video-vt8500lcdfb.h

2013-01-02 Thread Tony Prisk
With the conversion to devicetree only for arch-vt8500, this header is no longer required. This patch removes the #include from the two framebuffer drivers that used it, and the header file. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/video/vt8500lcdfb.c

[PATCH 2/4] video: vt8500: Make wmt_ge_rops optional

2013-01-02 Thread Tony Prisk
At the moment, accelerated raster ops are always enabled on VT8500 and WM8xxx series SoCs. This patch makes them optional. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/video/Kconfig | 23 +-- drivers/video/vt8500lcdfb.c | 15 +++ drivers

[PATCH] gpio: vt8500: memory cleanup missing

2013-01-02 Thread Tony Prisk
with dev_err in vt8500_add_chips since the device is available. There is also no .remove callback defined. To allow removing the registered chips, I have moved *vtchip to be a static global. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/gpio/gpio-vt8500.c | 53

[PATCH 0/2] Move some mach-vt8500 functions to new directories

2013-01-02 Thread Tony Prisk
and clocksource so maybe he wants to take both. CC: John Stultz johns...@us.ibm.com CC: Thomas Gleixner t...@linutronix.de Tony Prisk (2): timer: vt8500: Move system timer to clocksource irqchip: vt8500: Move irq code to drivers/irqchip arch/arm/mach-vt8500/Kconfig |1 + arch/arm/mach

[PATCH 1/2] timer: vt8500: Move system timer to clocksource

2013-01-02 Thread Tony Prisk
Move mach-vt8500/timer.c to drivers/clocksource/vt8500_timer.c and make necessary changes to Kconfig and Makefile. vt8500_timer is moved from vt8500.c to clocksource/vt8500_timer.c and added to common.h for reference from the board descriptor. Signed-off-by: Tony Prisk li...@prisktech.co.nz

[PATCH 2/2] irqchip: vt8500: Move irq code to drivers/irqchip

2013-01-02 Thread Tony Prisk
Move mach-vt8500/irq.c to drivers/irqchip/irq-vt8500.c and make necessary Makefile changes. No code changes required. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- CC: Thomas Gleixner t...@linutronix.de arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h |7 +- arch

Re: [PATCH 2/2] irqchip: vt8500: Move irq code to drivers/irqchip

2013-01-02 Thread Tony Prisk
On Wed, 2013-01-02 at 22:38 -0600, Rob Herring wrote: CC: Thomas Gleixner t...@linutronix.de arch/arm/mach-vt8500/Makefile |2 +- arch/arm/mach-vt8500/common.h |7 +- arch/arm/mach-vt8500/irq.c| 253 - drivers/irqchip/Makefile

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-01 Thread Tony Prisk
t pointer - it should never do so. Thread can be viewed here: https://lkml.org/lkml/2012/12/20/105 Regards Tony Prisk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

[PATCH] mmc: vt8500: Remove __devexit attribute on .remove

2013-01-01 Thread Tony Prisk
With the changes to HOTPLUG merged for 3.8, this attribute is no longer required and results in a warning at compile time. Signed-off-by: Tony Prisk --- drivers/mmc/host/wmt-sdmmc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers

[PATCH] mmc: vt8500: Remove __devexit attribute on .remove

2013-01-01 Thread Tony Prisk
With the changes to HOTPLUG merged for 3.8, this attribute is no longer required and results in a warning at compile time. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- drivers/mmc/host/wmt-sdmmc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL

2013-01-01 Thread Tony Prisk
can be viewed here: https://lkml.org/lkml/2012/12/20/105 Regards Tony Prisk -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

[PATCH v3] input: vt8500: Add power button keypad driver

2012-12-31 Thread Tony Prisk
This patch adds support for the Power Button keypad found on Wondermedia netbooks/tablets. A keymap property is exposed to allowing defining the key event to be generated when the power button is pressed. Signed-off-by: Tony Prisk --- CC: linux-kernel@vger.kernel.org CC: linux-arm-ker

Re: [PATCH v2] input: vt8500: Add power button keypad driver

2012-12-31 Thread Tony Prisk
On Mon, 2012-12-31 at 12:37 -0800, Dmitry Torokhov wrote: > Hi Tony, > > On Mon, Dec 31, 2012 at 03:04:59PM +1300, Tony Prisk wrote: > > This patch adds support for the Power Button keypad found on > > Wondermedia netbooks/tablets. > > > > Signed-off-by: Tony

Re: [PATCH v2] input: vt8500: Add power button keypad driver

2012-12-31 Thread Tony Prisk
On Mon, 2012-12-31 at 12:37 -0800, Dmitry Torokhov wrote: Hi Tony, On Mon, Dec 31, 2012 at 03:04:59PM +1300, Tony Prisk wrote: This patch adds support for the Power Button keypad found on Wondermedia netbooks/tablets. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- v2

[PATCH v3] input: vt8500: Add power button keypad driver

2012-12-31 Thread Tony Prisk
This patch adds support for the Power Button keypad found on Wondermedia netbooks/tablets. A keymap property is exposed to allowing defining the key event to be generated when the power button is pressed. Signed-off-by: Tony Prisk li...@prisktech.co.nz --- CC: linux-kernel@vger.kernel.org CC

[PATCH v2] input: vt8500: Add power button keypad driver

2012-12-30 Thread Tony Prisk
This patch adds support for the Power Button keypad found on Wondermedia netbooks/tablets. Signed-off-by: Tony Prisk --- v2: Remove devicetree binding for keycode Add dependency on OF in Kconfig Move static variables in a struct Remove redundant inline modifier from kpad_power_timeout() Remove

Re: [PATCH] input: vt8500: Add power button keypad driver

2012-12-30 Thread Tony Prisk
> > +Example: > > + powerkey: pwrkey@0 { > > + compatible = "wm,power-keypad"; > > + interrupts = <22>; > > + keymap = <116>; /* KEY_POWER */ > > Do we really need this in DT? I'd say just having it manageable from > userspace is enough. Just seemed easier this

[RFC PATCH] input: i8042: Add support for devicetree to i8042 serio driver

2012-12-30 Thread Tony Prisk
This patch adds basic devicetree support for the i8042 controller driver. Simple properties to specify the register offsets. Optional properties to specify the linux device descriptions. Signed-off-by: Tony Prisk --- .../devicetree/bindings/input/intel-8042.txt | 29 + drivers

[RFC PATCH] Add support for devicetree to i8042 serio driver

2012-12-30 Thread Tony Prisk
platform at compile-time. If compiling for a multiplatform kernel, all platforms must use the DT version or only one platform can have i8042 support. The DT version assumes memory-mapped i8042 registers. It can not handle IO-mapped modules (eg. x86) Tony Prisk (1): input: i8042: Add support

<    1   2   3   4   5   6   7   8   >