On December 22, 2020 3:27:33 AM GMT+08:00, h...@zytor.com wrote:
>On December 20, 2020 6:46:25 PM PST, tonywwang...@zhaoxin.com wrote:
>>On December 16, 2020 1:56:45 AM GMT+08:00, Eric Biggers
>> wrote:
>>>On Tue, Dec 15, 2020 at 10:15:29AM +0800, Tony W Wang-oc wrote:
On 15/12/2020 04:4
On December 16, 2020 1:56:45 AM GMT+08:00, Eric Biggers
wrote:
>On Tue, Dec 15, 2020 at 10:15:29AM +0800, Tony W Wang-oc wrote:
>>
>> On 15/12/2020 04:41, Eric Biggers wrote:
>> > On Mon, Dec 14, 2020 at 10:28:19AM +0800, Tony W Wang-oc wrote:
>> >> On 12/12/2020 01:43, Eric Biggers wrote:
>> >>
>
>> +// SPDX-License-Identifier: GPL-2.0
>
>That clearly disagrees with your boilerplate text which says 'v2.0 or
>later'. Assumed that you want or later, then the SPDX id needs to say so.
>
>// SPDX-License-Identifier: GPL-2.0-or-later
Ok, I will adjust this text a
nd-email' to send the patches out directly.
>
>.. and before you do that, run them all through checkpatch.pl and apply
>common sense when fixing the warnings from it:
Ok, I will run my patches through checkpatch.pl and modify them properly
before resend.
Thanks
TonyWWang-oc
fix your email client, or just use 'git
>send-email' to send the patches out directly.
Sorry for that! I was made a mistake to send the patch with HTML format.
I will set up my email client correctly.
Thanks
TonyWWang-oc
and resend it corrected.
>
>Also, gpl "boilerplate" text like this does not need to be in the file
>if you just include the spdx line.
Ok, I will sort this out with our lawyers, then adjust this text correctly
before resend it.
Thanks
TonyWWang-oc
6 matches
Mail list logo