Re: [PATCH v4 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

Hello! Pinging for review now that we are out of the quiet period. Thanks, Ujwal

[PATCH v4 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

: Ujwal Kundur --- Changes since v3: - more formatting fixes Changes since v2: - redo patch on mm-new branch Changes since v1: - indentation fixes - squash into single patch to assist bisections tools/testing/selftests/mm/uffd-common.c | 268 - tools/testing/selftests/mm/uffd

Re: [PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

> Sorry I don't have an opinion on which of these is the best (I can try > to find some time to form an opionion on this later!), but: > > Fixing the flakiness sounds great, but I would suggest decoupling that > from the refactoring. If it's practical, focus on removing the globals > first, while l

Re: [PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

> Sounds like that's your issue - for the kernel, tab is supposed to be > as wide as 8 spaces, not 4. That fixed it, thanks! I've gone through the diff and made sure there are no longer any inconsistent indents. > I'm afraid I'm too ignorant of this code to be able to suggest something > good her

Re: [PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

Thanks for the review and testing! >> -static void retry_copy_page(int ufd, struct uffdio_copy *uffdio_copy, >> - unsigned long offset) >> +static void retry_copy_page(uffd_global_test_opts_t *gopts, struct >> uffdio_copy *uffdio_copy, >> +

[PATCH v3 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

Refactor macros and non-composite global variable definitions into a struct that is defined at the start of a test and is passed around instead of relying on global vars. Signed-off-by: Ujwal Kundur --- Changes since v2: - redo patch on mm-new branch Changes since v1: - indentation fixes

[PATCH v2 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct

This patch refactors macros and non-composite global variable definitions into a struct that is defined at the start of a test and is passed around instead of relying on global vars. Signed-off-by: Ujwal Kundur --- Changes since v1: - indentation fixes - squash into single patch to assist

Re: [PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct

Thanks for the review and testing! I'll push a V2 with the indentation fixes soon. > this deletes the global vars before it deletes > the references to them. That's gonna be a real pain for bisections, > please can you restructure the series to prevent intervening build > failures? > (i.e. if I a

[PATCH 4/4] selftests/mm/uffd: Swap global variables with global test opts

We use the refactored uffd_global_test_opts instead of global variables for uffd-wp-mremap tests. Signed-off-by: Ujwal Kundur --- tools/testing/selftests/mm/uffd-wp-mremap.c | 23 + 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/mm

[PATCH 3/4] selftests/mm/uffd: Swap global variables with global test opts

We use the refactored uffd_global_test_opts instead of global variables for uffd-unit-tests. Signed-off-by: Ujwal Kundur --- tools/testing/selftests/mm/uffd-unit-tests.c | 523 ++- 1 file changed, 269 insertions(+), 254 deletions(-) diff --git a/tools/testing/selftests/mm/uffd

[PATCH 2/4] selftests/mm/uffd: Swap global vars with global test options

We use the refactored uffd_global_test_opts struct instead of global variables for uffd-stress tests. Signed-off-by: Ujwal Kundur --- tools/testing/selftests/mm/uffd-stress.c | 226 --- 1 file changed, 122 insertions(+), 104 deletions(-) diff --git a/tools/testing/selftests

[PATCH 1/4] selftests/mm/uffd: Refactor non-composite global vars into struct

This patch deals with the common uffd routines, refactoring macros and non-composite global variable definitions into a struct that is defined at the start of a test and is passed around instead of relying on global vars. Signed-off-by: Ujwal Kundur --- tools/testing/selftests/mm/uffd-common.c

[PATCH 0/4] selftests/mm/uffd: refactor global variables

frame, and we can more easily reason about the variable mutations Patch 1 needs to be applied first and can be followed by any of the other patches. I've ensured that the tests are passing locally (or atleast have the same output as the code on master). Ujwal Kundur (4): selftests/mm

[PATCH] selftests/mm: Fix spelling

Fix misspellings flagged by codespell. Signed-off-by: Ujwal Kundur --- tools/testing/selftests/mm/uffd-common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/mm/uffd-common.c b/tools/testing/selftests/mm/uffd-common.c index 717539eddf98