Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson
---
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson
---
dr
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson
---
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson
---
dr
This patchset first removes all blank help texts from Kconfig files for all
arches, and then makes Kconfig print a warning for blank help texts.
All patches can be applied independently, but to avoid warning spam, the blank
help texts ought to be removed before the warning is added.
Ulf
On Wed, Jan 31, 2018 at 9:06 AM, Dan Carpenter wrote:
> On Tue, Jan 30, 2018 at 08:05:27PM +0100, Ulf Magnusson wrote:
>> In preparation for adding a warning ("kconfig: Warn if help text is
>> blank"): https://lkml.org/lkml/2018/1/30/516
>>
>
> Please don&
On Tue, Jan 30, 2018 at 7:34 PM, Paul Bolle wrote:
> On Tue, 2018-01-30 at 19:18 +0100, Ulf Magnusson wrote:
>> Print a warning if a 'help' token is given but the help text is blank.
>> Personal pet peeve.
>>
>> Example warnings:
>>
>>
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index b66c264d4194..6088408ef
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index ab98569994f0..57cd591e7
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/arm/mach-vt8500/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-vt8500/Kconfig b/arch/arm/mach-vt8500/Kco
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/nios2/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
index 60fae03dac79..3d4ec88f1
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/mips/bcm63xx/boards/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm6
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/mmc/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 67
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/staging/rtl8192u/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/stagin
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
net/sched/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index c03d86a7775e..f24a6ae68
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/video/fbdev/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kco
cover letter to linux-kbuild.
Ulf Magnusson (10):
net/sched: kconfig: Remove empty help texts
video: fbdev: kconfig: Remove empty help text
mmc: kconfig: Remove empty help text
Staging: rtl8192u: kconfig: Remove empty help text
Staging: rtl8192e: kconfig: Remove empty help text
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/arm/mach-vt8500/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-vt8500/Kconfig b/arch/arm/mach-vt8500/Kco
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
lib/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index b66c264d4194..6088408ef
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index ab98569994f0..57cd591e7
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/nios2/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig
index 60fae03dac79..3d4ec88f1
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
arch/mips/bcm63xx/boards/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm6
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/staging/rtl8192e/rtl8192e/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/Kconfig
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/mmc/host/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 67
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/staging/rtl8192u/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/Kconfig b/drivers/stagin
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
drivers/video/fbdev/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kco
In preparation for adding a warning ("kconfig: Warn if help text is
blank"): https://lkml.org/lkml/2018/1/30/516
Signed-off-by: Ulf Magnusson
---
net/sched/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/sched/Kconfig b/net/sched/Kconfig
index c03d86a7775e..f24a6ae68
NT_FRAME_POINTERS' defined with
blank help text
A separate patchset will be sent to fix all current instances of blank
help texts for all arches. I added the same warning to Kconfiglib.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf.y | 6 ++
1 file changed, 6 insert
On Thu, Jan 18, 2018 at 5:47 PM, Masahiro Yamada
wrote:
> 2018-01-14 23:12 GMT+09:00 Ulf Magnusson :
>> It's easy to miss that choices are special-cased to pass on their mode
>> as the parent dependency.
>>
>> No functional changes. Only comments added.
&g
e.
> oldnoconfig: olddefconfig
> + @echo " WARNING: \"oldnoconfig\" target will be removed after Linux
> 4.19"
> + @echo "Please use \"olddefconfig\" instead."
>
> savedefconfig: $(obj)/conf
> $< $(sil
It is not obvious that the last two cases refer to menus and ifs,
respectively, in the conditional that sets 'parentdep'.
Automatic submenu creation is done later, so the parent can't be a
symbol here.
No functional changes. Only comments added.
Signed-off-by: Ulf Magnusso
On Sun, Jan 14, 2018 at 10:00 PM, Sam Ravnborg wrote:
> Hi Ulf.
>
> On Sun, Jan 14, 2018 at 12:33:43PM +0100, Ulf Magnusson wrote:
>> These together should make the automatic submenu logic a lot clearer.
>>
>> Ulf Magnusson (2):
>> kconfig: Document 'if&#
functional changes. Only comments added.
Signed-off-by: Ulf Magnusson
---
Changelog
v2:
I forgot to mention that this code also undoes automatic submenus created below
promptless symbols.
scripts/kconfig/menu.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/
It's easy to miss that choices are special-cased to pass on their mode
as the parent dependency.
No functional changes. Only comments added.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/scripts/kconfig/menu.c b/sc
An 'if', 'menu', or 'choice' that depends on a preceding symbol will
also generate a submenu.
No functional changes. Only comments updated.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
functional changes. Only comments added.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 24
1 file changed, 24 insertions(+)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 372eb5d9fef3..1f7bcceacde3 100644
--- a/scripts/kconfig/menu.c
+++ b/
functional changes. Only comments added.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 24
1 file changed, 24 insertions(+)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 372eb5d9fef3..1f7bcceacde3 100644
--- a/scripts/kconfig/menu.c
+++ b/
These together should make the automatic submenu logic a lot clearer.
Ulf Magnusson (2):
kconfig: Document 'if' flattening logic
kconfig: Improve auto. menu documentation accuracy
scripts/kconfig/menu.c | 33 +
1 file changed, 29 insertions(+), 4
Not obvious, especially if you don't already know how choices are
implemented.
No functional changes. Only comments added.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
On Fri, Jan 12, 2018 at 8:38 PM, Sam Ravnborg wrote:
> Hi Ulf, Masahiro
>
>> >
>> > BTW, I do not know the historical reason
>> > why zconf instead of kconf in the first place...
>>
>> I have no idea either. kconfig.{l,y} and kconfig_*() would be a lot
>> less confusing.
>
> zconf was the name ori
On Fri, Jan 12, 2018 at 1:26 PM, Ulf Magnusson wrote:
> On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada
> wrote:
>> check_conf() traverses the menu tree, but it is completely no-op for
>> olddefconfig because the following if-else block does nothing.
>>
>> i
case oldaskconfig:
> rootEntry = &rootmenu;
> conf(&rootmenu);
> - input_mode = silentoldconfig;
> + input_mode = oldconfig;
> /* fall through */
> case oldconfig:
> case listnewconfig:
> --
> 2.7.4
>
Looks good to me.
Maybe a comment along the following lines would be nice for
check_conf() as well:
/*
* Recursively process modifiable symbols (and choices) in 'menu' that don't
* have a user value
*/
check_conf() could be renamed to something like
process_new_modifiable_syms() as well.
The check_conf() call in conf() could have this above it as well:
/*
* Except in oldaskconfig mode, we're only interested in new modifiable symbols
*/
Acked-by: Ulf Magnusson
Cheers,
Ulf
,7 +669,7 @@ int main(int ac, char **av)
> do {
> conf_cnt = 0;
> check_conf(&rootmenu);
> - } while (conf_cnt && input_mode != listnewconfig);
> + } while (conf_cnt);
>
rootEntry != menu) {
> check_conf(menu);
> return;
> --
> 2.7.4
>
LGTM
Acked-by: Ulf Magnusson
Cheers,
Ulf
On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada
wrote:
> (all)defconfig does not need to call conf_set_all_new_symbols() because
> conf_write() calculates all symbols based on their default unless they
> have been user-defined.
>
> conf_set_all_new_symbols(def_default) is no-op except for "choice
sym->flags &= ~SYMBOL_WRITE;
> --
> 2.7.4
>
Not tested, but looks fine.
As a note if anyone else takes a look, choices get propagated to the
property conditions of the contained symbols, which indirectly causes
the choice to be calculated when the visibility of a contained symbol
is calculated.
Acked-by: Ulf Magnusson
Cheers,
Ulf
t; -(input_mode != listnewconfig &&
> - input_mode != olddefconfig));
> + } while (conf_cnt && input_mode != listnewconfig);
> + break;
> + case olddefconfig:
> + default:
> break;
> }
>
> --
> 2.7.4
>
Acked-by: Ulf Magnusson
Cheers,
Ulf
On Tue, Dec 12, 2017 at 3:58 PM, Masahiro Yamada
wrote:
> 2017-10-05 12:06 GMT+09:00 Ulf Magnusson :
>> Looks like a change to a comment in zconf.y was never committed, because
>> the updated version only appears it zconf.tab.c_shipped. Update the
>> comment in zconf.y to ma
_${baseprereq}),$(YACC_PREFIX_${baseprereq}),yy)
> -
> quiet_cmd_bison = YACC$@
> - cmd_bison = $(YACC) -o$@ -t -l -p $(YACC_PREFIX) $<
> + cmd_bison = $(YACC) -o$@ -t -l $<
>
> ifdef REGENERATE_PARSERS
> .PRECIOUS: $(src)/%.tab.c_shipped
> --
> 2.7.4
>
Acked-by: Ulf Magnusson
Cheers,
Ulf
zconfnerrs++;
> + yynerrs++;
> return false;
> }
> return true;
> @@ -601,7 +601,7 @@ static void zconf_error(const char *err, ...)
> {
> va_list ap;
>
> - zconfnerrs++;
> + yynerrs++;
> fprintf(stderr, "%s:%d: ", zconf_curname(), zconf_lineno());
> va_start(ap, err);
> vfprintf(stderr, err, ap);
> @@ -609,7 +609,7 @@ static void zconf_error(const char *err, ...)
> fprintf(stderr, "\n");
> }
>
> -static void zconferror(const char *err)
> +static void yyerror(const char *err)
> {
> fprintf(stderr, "%s:%d: %s\n", zconf_curname(), zconf_lineno() + 1,
> err);
> }
> --
> 2.7.4
>
Looks good to me. Less cryptic.
Acked-by: Ulf Magnusson
Cheers,
Ulf
On Wed, Jan 10, 2018 at 5:12 PM, Masahiro Yamada
wrote:
> 2017-10-09 2:11 GMT+09:00 Ulf Magnusson :
>> This is just for completeness to get rid of the last memory leak
>> currently generated during parsing for ARCH=x86. The symbol
>> DVB_NETUP_UNIDVB in drivers/media/pci
g: 'DVB_NETUP_UNIDVB' defined with
more than one help text -- only the last one will be used
Also free() any extra help strings.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf.y | 5 +
1 file changed, 5 insertions(+)
diff --git a/scripts/kconfig/zconf.y b/scripts/kcon
On Wed, Dec 13, 2017 at 5:32 PM, Ulf Magnusson wrote:
> On Sat, Dec 9, 2017 at 5:27 PM, Masahiro Yamada
> wrote:
>> 2017-10-05 11:36 GMT+09:00 Ulf Magnusson :
>>> menu_end_entry() is empty and completely unused as far as I can tell:
>>>
>>>
On Sat, Dec 9, 2017 at 5:27 PM, Masahiro Yamada
wrote:
> 2017-10-05 11:36 GMT+09:00 Ulf Magnusson :
>> menu_end_entry() is empty and completely unused as far as I can tell:
>>
>> $ git log -G menu_end_entry --oneline
>> a02f057 [PATCH] kconfig: improve e
Hello,
A new, much-improved version 2 of Kconfiglib
(https://github.com/ulfalizer/Kconfiglib) is out.
I got tired of some old interface and design mistakes while working on adding
implicit menu support, and decided to redo things the right way.
For a summary of changes, see kconfiglib-2-changes.
On Sun, Oct 8, 2017 at 7:11 PM, Ulf Magnusson wrote:
> After the parsing memory leak fixes.
>
> Signed-off-by: Ulf Magnusson
> ---
> scripts/kconfig/zconf.tab.c_shipped | 562
> +++-
> 1 file changed, 294 insertions(+), 268 deletions(-)
>
, and I suspect it doesn't get used much.
Tested by running the Kconfiglib test suite, which indirectly verifies
that the .config files generated by the C implementation for each
defconfig file in the kernel stays the same.
Signed-off-by: Ulf Magnusson
---
Changes in v2:
- Don
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/expr.c | 106 +
1 file changed, 106 insertions(+)
diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c
index cbf4996..5965ecd 100644
--- a/scripts/kconfig/expr.c
+++ b/scripts/kconfig/expr.c
It's tricky to figure out what it does (and how) without staring at the
code for a long time. Document it to make it more transparent.
No functional changes. Only comments added.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 38 ++
1 file ch
Summary after the fix:
LEAK SUMMARY:
definitely lost: 1,608 bytes in 67 blocks
...
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/expr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/kconfig/expr.c b/scripts/kconfig/expr.c
index cbf4996..ed2
pression node and not the choice
symbol itself.
Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 1,608 bytes in 67 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 0 bytes
x27; (ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 344,376 bytes in 14,349 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 44,448 bytes in 1,852 blocks
...
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 1
H=x86 KERNELVERSION=4.14.0-rc2 valgrind
--leak-check=full scripts/kconfig/mconf Kconfig
Cheers,
Ulf
Ulf Magnusson (3):
kconfig: Fix automatic menu creation mem leak
kconfig: Fix expr_free() E_NOT leak
kconfig: Fix choice symbol expression leak
scripts/kconfig/expr.c | 2 +-
scripts/kconfig/menu.
' statement or not, and managing it becomes simple.
Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 344,568 bytes in 14,352 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely l
y after the fix:
LEAK SUMMARY:
definitely lost: 344,616 bytes in 14,355 blocks
...
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/symbol.c | 5 +
scripts/kconfig/zconf.y | 1 +
2 files changed, 6 insertions(+)
diff --git a/scripts/kconfig/symbol.c b/scripts/
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 387,504 bytes in 15,545 blocks
...
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf.y | 36 +++-
1 file changed, 19 insertions(+), 17 deletions(-)
diff --gi
look at
KERNELVERSION, so just set it to avoid a warning):
$ ARCH=x86 SRCARCH=x86 KERNELVERSION=4.14.0-rc2 valgrind
--leak-check=full scripts/kconfig/mconf Kconfig
Cheers,
Ulf
Ulf Magnusson (6):
kconfig: Don't leak symbol names during parsing
kconfig: Don't leak 's
x27; (ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 344,616 bytes in 14,355 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 344,568 bytes in 14,352 blocks
...
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf
(ARCH=x86) before the fix:
LEAK SUMMARY:
definitely lost: 344,440 bytes in 14,350 blocks
...
Summary after the fix:
LEAK SUMMARY:
definitely lost: 344,376 bytes in 14,349 blocks
...
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf.y
After the parsing memory leak fixes.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf.tab.c_shipped | 562 +++-
1 file changed, 294 insertions(+), 268 deletions(-)
diff --git a/scripts/kconfig/zconf.tab.c_shipped
b/scripts/kconfig/zconf.tab.c_shipped
efault ""'.
- The Kconfiglib test suite was run to indirectly verify that
alldefconfig, allyesconfig, allnoconfig, and all defconfigs in
the kernel still generate the same final .config.
- Valgrind was used to check for memory errors and (new) memory
.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 52 ++
1 file changed, 52 insertions(+)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 8354dfa..94f192de 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
More directly describes the only thing it does.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index e935793..8354dfa 100644
--- a/scripts/kconfig
), Kconfiglib, and
Valgrind.
Cheers,
Ulf
Ulf Magnusson (3):
kconfig: Rename menu_check_dep() to rewrite_m()
kconfig: Clarify expression rewriting
kconfig: Clean up modules handling and fix crash
scripts/kconfig/menu.c | 74 --
1 file changed, 6
On Wed, Oct 4, 2017 at 7:48 AM, Ulf Magnusson wrote:
> Visibility and choices in particular might be a bit tricky to figure
> out.
>
> Also fix existing comment to point out that P_MENU is also used for
> menus.
>
> Signed-off-by: Ulf Magnusson
> ---
>
On Wed, Oct 4, 2017 at 5:37 AM, Ulf Magnusson wrote:
> Understanding what it represents helps a lot when reading the code, and
> it's not obvious, so document it.
>
> The ROOT_MENU flag is only set and tested by the gconf and qconf front
> ends, so leave it undocumented her
On Wed, Oct 4, 2017 at 2:10 AM, Ulf Magnusson wrote:
> On Wed, Oct 4, 2017 at 1:25 AM, Ulf Magnusson wrote:
>> This will catch mistakes like in the following real-world example, where
>> a "CONFIG_" prefix snuck in, making an undefined symbol the defa
Looks like a change to a comment in zconf.y was never committed, because
the updated version only appears it zconf.tab.c_shipped. Update the
comment in zconf.y to match.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/zconf.y | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
, and I suspect it doesn't get used much.
Tested by running the Kconfiglib test suite, which indirectly verifies
that the .config files generated by the C implementation for each
defconfig file in the kernel stays the same.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/lkc.h
Visibility and choices in particular might be a bit tricky to figure
out.
Also fix existing comment to point out that P_MENU is also used for
menus.
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/expr.h | 45 -
1 file changed, 44 insertions(+), 1
Understanding what it represents helps a lot when reading the code, and
it's not obvious, so document it.
The ROOT_MENU flag is only set and tested by the gconf and qconf front
ends, so leave it undocumented here. The obvious guess for what it means
is correct.
Signed-off-by: Ulf Magn
On Wed, Oct 4, 2017 at 1:25 AM, Ulf Magnusson wrote:
> This will catch mistakes like in the following real-world example, where
> a "CONFIG_" prefix snuck in, making an undefined symbol the default:
>
> choice
> prompt &qu
he visible symbol as the default
instead, which is CC_OPTIMIZE_FOR_PERFORMANCE, as intended.
A patch that makes Kconfig print a warning in this case has been
submitted separately:
http://www.spinics.net/lists/linux-kbuild/msg15566.html
Signed-off-by: Ulf Magnusson
---
init/Kconfig | 2 +-
1 file
ered while playing around with Kconfiglib
(https://github.com/ulfalizer/Kconfiglib).
Signed-off-by: Ulf Magnusson
---
scripts/kconfig/menu.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index e935793..ce88de8 100644
--- a/scripts/kconfi
| 1 +
> scripts/kconfig/zconf.hash.c_shipped | 58 ---
> scripts/kconfig/zconf.l | 20 ++-
> scripts/kconfig/zconf.lex.c_shipped | 325
> +--
> 4 files changed, 204 insertions(+), 200 deletions(-)
>
> --
> 1.9.1
>
For
On Tue, Jul 14, 2015 at 6:27 AM, Ulf Magnusson wrote:
> On Mon, Jul 13, 2015 at 2:46 AM, Ulf Magnusson
> wrote:
>> On Sun, Jul 12, 2015 at 04:36:53PM -0700, Jim Davis wrote:
>>> On Sun, Jul 12, 2015 at 2:59 PM, Ulf Magnusson
>>> wrote:
>>> > gzip w
On Mon, Jul 13, 2015 at 2:46 AM, Ulf Magnusson wrote:
> On Sun, Jul 12, 2015 at 04:36:53PM -0700, Jim Davis wrote:
>> On Sun, Jul 12, 2015 at 2:59 PM, Ulf Magnusson
>> wrote:
>> > gzip would run as 'gzip -f' when no uncompressed man pages were found,
>> &
On Mon, Jul 13, 2015 at 05:39:25PM -0700, Greg KH wrote:
> On Sun, Jul 12, 2015 at 08:08:46PM +0200, Ulf Magnusson wrote:
> > Hello,
> >
> > Tested with next-20150709.
> >
> > Documentation/kdbus/Makefile lacks an 'installmandocs' target, causing
>
On Sun, Jul 12, 2015 at 04:36:53PM -0700, Jim Davis wrote:
> On Sun, Jul 12, 2015 at 2:59 PM, Ulf Magnusson
> wrote:
> > gzip would run as 'gzip -f' when no uncompressed man pages were found,
> > making it compress the (empty) stdin to stdout.
>
> >
`find $(obj)/man -name '*.9'`; \
if [ -n "$$man_pages" ]; then \
echo "$$man_pages" | xargs gzip -f; \
fi
Signed-off-by: Ulf Magnusson
---
Documentation/DocBook/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation
Hello,
Tested with next-20150709.
Documentation/kdbus/Makefile lacks an 'installmandocs' target, causing
problems for
%docs: scripts_basic FORCE
$(Q)$(MAKE) $(build)=scripts build_docproc
$(Q)$(MAKE) $(build)=Documentation/DocBook $@
$(Q)$(MAKE) $(build)=Documentation/kdb
One more nitpick (should be the last one):
On Fri, Jul 10, 2015 at 10:25:32AM +0200, Andreas Ruprecht wrote:
> In Kconfig, definitions of options take the following form:
> " ...". COMMANDs and PARAMs are treated
> slightly different by the underlying parser.
>
> While commit 2e0d737fc76f ("kco
On Fri, Jul 10, 2015 at 10:25:31AM +0200, Andreas Ruprecht wrote:
> This patchset changes the lexer file to emit a warning if any unhandled
> characters are found in the input. So far, Kconfig options like
>
> +config FOO
> bool
> [...]
>
> (note the wrong '+'!) were parsed without a war
One more nitpick:
On Tue, Jul 07, 2015 at 12:31:16PM +0200, Andreas Ruprecht wrote:
> In Kconfig, definitions of options take the following form:
> " ...". COMMANDs and PARAMs are treated
> slightly different by the underlying parser.
>
> While commit 2e0d737fc76f ("kconfig: don't silently igno
On Wed, Jul 8, 2015 at 12:17 PM, Andreas Ruprecht
wrote:
> Hi,
>
> On 07/07/2015 16:45, Ulf Magnusson wrote:
>>
>> Did you use the (undocumented, obviously :) REGENERATE_PARSERS option,
>> like 'make menuconfig REGENERATE_PARSERS=1'? It's from
>>
On Tue, Jul 7, 2015 at 12:31 PM, Andreas Ruprecht
wrote:
> In Kconfig, definitions of options take the following form:
> " ...". COMMANDs and PARAMs are treated
> slightly different by the underlying parser.
>
> While commit 2e0d737fc76f ("kconfig: don't silently ignore unhandled
> characters")
A more exact commit title would be something like "warn for unhandled
characters before the initial token on a line".
On Fri, Jul 3, 2015 at 2:46 PM, Andreas Ruprecht
wrote:
> While commit 2e0d737fc76f ("kconfig: don't silently ignore unhandled
> characters") introduced a warning for unsupported
On Sat, Jul 4, 2015 at 11:33 AM, Paul Bolle wrote:
> On vr, 2015-07-03 at 14:46 +0200, Andreas Ruprecht wrote:
>> While commit 2e0d737fc76f ("kconfig: don't silently ignore unhandled
>> characters") introduced a warning for unsupported characters inside
>> parameters,
>
> What are "parameters"? Th
On Fri, Jul 3, 2015 at 2:39 PM, Ulf Magnusson wrote:
> On Fri, Jul 3, 2015 at 1:40 PM, Ulf Magnusson
> wrote:
>> On Fri, Jul 3, 2015 at 1:33 PM, Andreas Ruprecht
>> wrote:
>>> On 07/03/2015 12:46, Ulf Magnusson wrote:
>>>>
>>>> Except for scat
201 - 300 of 314 matches
Mail list logo
