[PATCH] serial: sh-sci: remove obsolete latency workaround

2021-04-15 Thread Ulrich Hecht
Since the transition to hrtimers there is no more need to set a minimum RX timeout to work around latency issues. Signed-off-by: Ulrich Hecht --- drivers/tty/serial/sh-sci.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers

Antw: [EXT] [systemd-devel] [SPECIFICATION RFC] The firmware and bootloader log specification

2020-11-15 Thread Ulrich Windl
o or what defines t == 0? ... Regards, Ulrich Windl

FYI: PoC: Running 100000 processes in 5.3.18 (SLES15 SP2)

2020-10-02 Thread Ulrich Windl
08 64228/102328 134935 Regards, Ulrich

Re: [PATCH v3] pinctrl: renesas: r8a7790: Add VIN1-B and VIN2-G pins, groups and functions

2020-09-19 Thread Ulrich Hecht
Hi! Thanks for the patch. Verified it against data sheet, the magic numbers check out. Reviewed-by: Ulrich Hecht CU Uli > On 09/17/2020 9:59 PM Lad Prabhakar > wrote: > > > Add pins, groups and functions for the VIN1-B [data/sync/field/clkenb/clk] > and VIN2-G8. >

heads up: clock_gettime(CLOCK_MONOTONIC, ...) is not monotonic with Xen PVM

2020-08-11 Thread Ulrich Windl
res; get_res(&res); printf("resolution is 0.%09ld\n", res.tv_nsec); return(result); } - it is intentional that the program aborts on error Output from a newer machine: get_res: resolution is 0.1 get_res: smallest delta is 0.00030 get_res: largest delta is 0.00050 resolution is 0.00030 Regards, Ulrich Windl (Keep me on CC if I should read your replies)

Q: Getting consistent CPU status rates from /proc/stat

2020-07-02 Thread Ulrich Windl
), '#7=.sirq' (software IRQs), '#8=.st' (stolen) Is "idle" the only field that is in USER_HZ? If so it makes it hard to be used by a univarsal utility like my monitoring plugin that can read _any_ value from procfs. For reference, here's the consistency check

Re: [BOOTLOADER SPECIFICATION RFC] The bootloader log format for TrenchBoot and others

2020-06-01 Thread Hans Ulrich Niedermann
On Fri, 29 May 2020 13:27:35 +0200 Daniel Kiper wrote: > Below you can find my rough idea of the bootloader log format which is > generic thing but initially will be used for TrenchBoot work. I > discussed this proposal with Ross and Daniel S. So, the idea went > through initial sanitization. Now

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-05 Thread Ulrich Weigand
expected by our freeze code, in particular in gup the existing reference is simply the one from the pte. So in this case our freeze *would* succeeed. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain ulrich.weig...@de.ibm.com

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-05 Thread Ulrich Weigand
On Tue, May 05, 2020 at 05:34:45AM -0700, Dave Hansen wrote: > On 5/4/20 6:41 AM, Ulrich Weigand wrote: > > You're right that there is no mechanism to prevent new references, > > but that's really never been the goal either. We're simply trying > > to ensur

Re: [PATCH v2 1/1] fs/splice: add missing callback for inaccessible pages

2020-05-04 Thread Ulrich Weigand
27;t think Linux mm code would be able to handle the case where a file-backed page is in the page table but not page cache). I'm not sure what exactly the requirements for your use case are; if those are significantly differently, maybe we can work together to find an approach that works for both? Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain ulrich.weig...@de.ibm.com

Issue with reading sysfs files

2019-10-17 Thread Ulrich Windl
rtual/net/lo/name_assign_type: Invalid argument /sys/devices/virtual/net/lo/speed Found in 4.12.14-95.6-default of SLES SP4 (x86_64) Regards, Ulrich

Re: [PATCH v2] i2c: i2c-mt65xx: fix NULL ptr dereference

2019-10-02 Thread Ulrich Hecht
;i2c: mediatek: disable zero-length transfers for > mt8183") > Signed-off-by: Fabien Parent Thank you! Tested successfully on Acer R13 Chromebook (mt8173). Tested-by: Ulrich Hecht CU Uli

Re: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or_reset() helper

2019-07-31 Thread Ulrich Hecht
ret = of_thermal_get_ntrips(tsc->zone); > if (ret < 0) > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH] serial: sh-sci: Use DEVICE_ATTR_RW() for rx_fifo_trigger

2019-07-31 Thread Ulrich Hecht
TTR(rx_fifo_trigger, 0644, rx_trigger_show, rx_trigger_store); > +static DEVICE_ATTR_RW(rx_fifo_trigger); > > static ssize_t rx_fifo_timeout_show(struct device *dev, > struct device_attribute *attr, > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH v2 17/19] drm: rcar-du: crtc: Enable and disable CMMs

2019-07-16 Thread Ulrich Hecht
-git a/drivers/gpu/drm/rcar-du/rcar_du_regs.h > b/drivers/gpu/drm/rcar-du/rcar_du_regs.h > index bc87f080b170..fb9964949368 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_regs.h > +++ b/drivers/gpu/drm/rcar-du/rcar_du_regs.h > @@ -197,6 +197,11 @@ > #define DEFR6_MLOS1 (1 << 2) > #define DEFR6_DEFAULT(DEFR6_CODE | DEFR6_TCNE1) > > +#define DEFR70x000ec > +#define DEFR7_CODE (0x7779 << 16) > +#define DEFR7_CMME1 BIT(6) > +#define DEFR7_CMME0 BIT(4) > + Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH] serial: sh-sci: Fix HSCIF RX sampling point calculation

2019-04-01 Thread Ulrich Hecht
signed variables to int, adding one to srr, and > using a single DIV_ROUND_CLOSEST(). > > Fixes: 63ba1e00f178a448 ("serial: sh-sci: Support for HSCIF RX sampling point > adjustment") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Ulrich Hecht CU Uli

leap seconds and 61st second in minute

2019-02-13 Thread Ulrich Windl
offer a TAI-based time, or, maybe even better: The kernel could run on TAI internally, and convert to UNIX time scale as needed. I'll leave exact specification and implementation to the really clever guys. Regards, Ulrich P.S. Not subscribed to the kernel-list so if you want to talk to me keep me on CC: preferably

Re: Licensing of include/linux/hash.h

2019-02-11 Thread Ulrich Mueller
>>>>> On Mon, 11 Feb 2019, Ulrich Mueller wrote: >>>>> On Mon, 11 Feb 2019, Domenico Andreoli wrote: >> On Mon, Feb 11, 2019 at 12:08:32AM +0100, Kristian Fiskerstrand wrote: >>> It was [pointed out] by one of our license group that [hash.h] is the &g

Re: Licensing of include/linux/hash.h

2019-02-11 Thread Ulrich Mueller
/history.git/commit/?id=882ad449046cec136c484dd2b3659fb4c683e0a3 filemap.c has a copyright line by Linus, but git blame shows that the relevant code was added in 2002 with a commit by Rik van Riel: https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=e5191c50d12621e04f8bc247dcb6a0f4ad76ae26 The relevant thread in LKML is here: https://lkml.org/lkml/2002/2/18/1970 Ulrich

Re: [PATCH] serial: sh-sci: Fix use-after-free on subsequent port startup

2018-07-17 Thread Ulrich Hecht
s/tty/serial/sh-sci.c > @@ -1872,6 +1872,7 @@ static int sci_request_irq(struct sci_port *port) > } > > desc = sci_irq_desc + i; > + port->irqstr[j] = NULL; > if (SCIx_TEIDRI_IRQ_EXISTS(port)) { > /* > * ERI and BRI are muxed, just register ERI and > -- > 2.17.1 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH/RFT 6/6] i2c: recovery: remove bogus check if SDA GPIO is set to output

2018-07-16 Thread Ulrich Hecht
bri->set_sda = set_sda_gpio_value; > + bri->set_sda = set_sda_gpio_value; > } > return; > } > -- > 2.11.0 > Reviewed-by: Ulrich Hecht CU Uli

Re: [PATCH] mux: include compiler.h from mux/consumer.h

2017-08-02 Thread Ulrich Hecht
On Mon, Jul 31, 2017 at 6:28 PM, Peter Rosin wrote: > On 2017-07-31 18:00, Greg Kroah-Hartman wrote: >> On Mon, Jul 31, 2017 at 12:04:35PM +0200, Peter Rosin wrote: >>> From: Ulrich Hecht >>> >>> Required for __must_check. >>> >>> Signe

Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Ulrich Windl
7;s random). It's unlikely, but it can happen. The question is whether the probability of non-unique values from /dev/urandom is any higher than that for values read from /dev/random. One _might_ be able to predict the values from /dev/urandom. Regards, Ulrich > > Jeff > &

Antw: Re: [kernel-hardening] Re: [PATCH v4 06/13] iscsi: ensure RNG is seeded before use

2017-07-05 Thread Ulrich Windl
initialized and working. Such > devices > commonly start working after the the root partition is mounted as it > contains > all drivers, all configuration information etc. > > Note, during the development of my /dev/random implementation, I added the > getrandom-like b

Antw: Q: si_code for SIGBUS caused by mmap() write error

2017-05-08 Thread Ulrich Windl
I'm sorry for using that address as sender in my previous message; it was an oversight! The CC: address was correct, however. You can drop above address from your replies.

Kernel lockup with Intel Iris graphics

2017-04-20 Thread Ulrich Windl
Hi folks, maybe someone has a idea on this: https://bugzilla.opensuse.org/show_bug.cgi?id=1032832 Regards, Ulrich

Re: linux-next: build warning after merge of the tty tree

2017-02-06 Thread Ulrich Hecht
i: implement FIFO threshold register setting") >> >> Forgot to add a call to this new function? > > I think this is fixed by a patch I just took into my tree, which isn't > in linux-next yet. Right Ulrich? That is correct, it's called in "[PATCH v4 2/4] serial: sh-sci: SCIFA/B RX FIFO software timeout". CU Uli

Antw: 3.0.101: "blk_rq_check_limits: over max size limit."

2016-12-07 Thread Ulrich Windl
83809.595235] [<7fb04560dba0>] 0x7fb04560db9f >>> Ulrich Windl schrieb am 07.12.2016 um 13:23 in Nachricht <5847FF5E.7E4 : >>> 161 : 60728>: > Hi again! > > An addition: Processes doing such I/O seem to be unkillable, and I also > cannot change the queue paramete

Antw: 3.0.101: "blk_rq_check_limits: over max size limit."

2016-12-07 Thread Ulrich Windl
nonvoluntary_ctxt_switches: 1 Best regards, Ulrich >>> Ulrich Windl schrieb am 07.12.2016 um 13:19 in Nachricht <5847FE66.7E4 : >>> 161 : 60728>: > Hi again! > > Maybe someone can confirm this: > If you have a device (e.g. multipath map) that limits max_sectors_kb to &

Antw: 3.0.101: "blk_rq_check_limits: over max size limit."

2016-12-07 Thread Ulrich Windl
nyway). Last seen with this kernel (SLES11 SP4 on x86_64): Linux version 3.0.101-88-default (geeko@buildhost) (gcc version 4.3.4 [gcc-4_3-branch revision 152973] (SUSE Linux) ) #1 SMP Fri Nov 4 22:07:35 UTC 2016 (b45f205) Regards, Ulrich >>> Ulrich Windl schrieb am 23.08.2016 um 17:0

Antw: Re: MBR partitions slow?

2016-08-31 Thread Ulrich Windl
>>> Mark D Rustad schrieb am 31.08.2016 um 17:32 in >>> Nachricht : > Ulrich Windl wrote: > >> So without partition the throughput is about twice as high! Why? > > My first thought is that by starting at block 0 the accesses were aligned > with

Antw: MBR partitions slow?

2016-08-30 Thread Ulrich Windl
at 0x7fe18823e000: 0.038380s time to close /dev/disk/by-id/dm-name-FirstTest-32_part2: 0.265687s So the correctly aligned partition is two to three times faster than the badly aligned partition (write-only case), and it's about the performance of an unpartitioned disk. Regards, Ulrich >&

MBR partitions slow?

2016-08-30 Thread Ulrich Windl
: 0.069956s time to close /dev/disk/by-id/dm-name-FirstTest-32: 0.327232s So without partition the throughput is about twice as high! Why? Regards Ulrich

3.0.101: "blk_rq_check_limits: over max size limit."

2016-08-23 Thread Ulrich Windl
(253:8) FirstTest-32(253:7) # cat /sys/block/dm-8/queue/max_sectors_kb 1024 After "# echo 128 >/sys/block/dm-8/queue/max_sectors_kb" things still did not get better. Can't blk_rq_check_limits() do anything more clever than returning -EIO? Regards, Ulrich P.S: Keep me in CC:, please!

cpuset cleanup race

2016-04-26 Thread Ulrich Drepper
I came across a problem with code which uses a cpuset CG and tries to be responsible and clean up after itself. The code attached at the bottom illustrates the problem. It's only long because it has no dependencies aside from the basic runtime and should work on all machines. You need to run it

Re: [PATCH] watchdog: don't run proc_watchdog_update if new value is same as old

2016-03-19 Thread Ulrich Obergfell
false positives' as the repeated cancel/restart of watchdog_timer_fn() prevents the 'watchdog/N' thread from running (i.e. I think the thread is not prevented from running by something actually hogging CPU N). Regards, Uli - Original Message - From: "Josh Hunt&quo

Re: [PATCH] watchdog: don't run proc_watchdog_update if new value is same as old

2016-03-16 Thread Ulrich Obergfell
#x27;s patch and it did not help. After that I did a git bisect to figure out when the soft lockup was fixed and it appears to be resolved after one of the commits in this series: commit 81a4beef91ba4a9e8ad6054ca9933dff7e25ff28 Author: Ulrich Obergfell Date: Fri Sep 4 15:45:15 2015 -0700 watchdog: introduce watchd

and NTP incompatibility (MOD_NANO)

2016-01-31 Thread Ulrich Windl
t; is needed to get the fix permanently into Linux. My proposal many years ago was to use ADJ_* style flags only for the Linux specialities (the adjtime() part of adjtimex()), and use the MOD_* style flags for the NTP part of adjtimex(). Regards, Ulrich --- Appendix: Linux has only these: /*

Suggestion for improving documentation (/usr/src/linux/Documentation/sysctl/vm.txt)

2016-01-28 Thread Ulrich Windl
== My proposal to improve sysctl documentation is obvious, and no, I don't mean "Use the source, Luke!" ;-) (I'm not subscribed to LKML) Regards, Ulrich

Re: [PATCH 2/2] workqueue: implement lockup detector

2015-12-04 Thread Ulrich Obergfell
Tejun, > Sure, separating the knobs out isn't difficult. I still don't like > the idea of having multiple set of similar knobs controlling about the > same thing tho. > > For example, let's say there's a user who boots with "nosoftlockup" > explicitly. I'm pretty sure the user wouldn't be inten

Re: [PATCH 2/2] workqueue: implement lockup detector

2015-12-03 Thread Ulrich Obergfell
mind is: Would the workqueue watchdog participate in the lockup detector suspend/resume mechanism, and if yes, how would it be integrated into this ? Regards, Uli - Original Message - From: "Tejun Heo" To: "Don Zickus" Cc: "Ulrich Obergfell" , "Ing

[PATCH 1/4] watchdog: avoid race between lockup detector suspend/resume and CPU hotplug

2015-11-03 Thread Ulrich Obergfell
suspended, and the thread could thus interfere unexpectedly with the code that requested to suspend the lockup detector. Avoid the race by calling get_online_cpus() in lockup_detector_suspend() put_online_cpus() in lockup_detector_resume() Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c

[PATCH 0/4] watchdog: address various races (CPU hotplug, timer expiry)

2015-11-03 Thread Ulrich Obergfell
This patch set addresses various races in relation to CPU hotplug and a race in relation to watchdog timer expiry. I discovered the corner cases during code inspection. I haven't seen any of these issues occur in practice. Ulrich Obergfell (4): watchdog: avoid race between lockup det

[PATCH 4/4] watchdog: fix race between proc_watchdog_thresh() and watchdog_timer_fn()

2015-11-03 Thread Ulrich Obergfell
ix this by checking the current value of 'watchdog_thresh'. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 84c4744..18f34cf 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdo

[PATCH 2/4] watchdog: avoid races between /proc handlers and CPU hotplug

2015-11-03 Thread Ulrich Obergfell
get|put}_online_cpus() in proc_watchdog_common() {get|put}_online_cpus() in proc_watchdog_thresh() {get|put}_online_cpus() in proc_watchdog_cpumask() Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kernel/watchdog.c b/ker

[PATCH 3/4] watchdog: remove {get|put}_online_cpus() from watchdog_{park|unpark}_threads()

2015-11-03 Thread Ulrich Obergfell
watchdog_{park|unpark}_threads() are now called in code paths that protect themselves against CPU hotplug, so {get|put}_online_cpus() calls are redundant and can be removed. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[tip:irq/core] irqchip/renesas-intc-irqpin: r8a7778 IRLM setup support

2015-09-30 Thread tip-bot for Ulrich Hecht
Commit-ID: 26c21dd9885a2d8a4f4d539917c4877ffd399286 Gitweb: http://git.kernel.org/tip/26c21dd9885a2d8a4f4d539917c4877ffd399286 Author: Ulrich Hecht AuthorDate: Wed, 30 Sep 2015 12:03:07 +0200 Committer: Thomas Gleixner CommitDate: Wed, 30 Sep 2015 21:02:22 +0200 irqchip/renesas-intc

Re: [PATCH 0/5] improve handling of errors returned by kthread_park()

2015-09-30 Thread Ulrich Obergfell
ke error returns from kthread_park() in order to test the patches. Regards, Uli - Original Message - From: "Andrew Morton" To: "Ulrich Obergfell" Cc: linux-kernel@vger.kernel.org, dzic...@redhat.com, atom...@redhat.com Sent: Wednesday, September 30, 2015 1:30:36 AM Sub

[PATCH 2/5] watchdog: move watchdog_disable_all_cpus() outside of ifdef

2015-09-28 Thread Ulrich Obergfell
It makes sense to place watchdog_{dis|enable}_all_cpus() outside of the ifdef so that _both_ are available even if CONFIG_SYSCTL is not defined. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/watchdog.c b

[PATCH 3/5] watchdog: implement error handling in update_watchdog_all_cpus() and callers

2015-09-28 Thread Ulrich Obergfell
update_watchdog_all_cpus() now passes errors from watchdog_park_threads() up to functions in the call chain. This allows watchdog_enable_all_cpus() and proc_watchdog_update() to handle such errors too. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 30 +++--- 1

[PATCH 1/5] watchdog: fix error handling in proc_watchdog_thresh()

2015-09-28 Thread Ulrich Obergfell
Restore the previous value of watchdog_thresh _and_ sample_period if proc_watchdog_update() returns an error. The variables must be consistent to avoid false positives of the lockup detectors. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH 5/5] watchdog: do not unpark threads in watchdog_park_threads() on error

2015-09-28 Thread Ulrich Obergfell
the lockup detectors will soon be disabled by the callers anyway. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 3bc22a9..af70bf2 100644 --- a/kernel/watchdog.c ++

[PATCH 4/5] watchdog: implement error handling in lockup_detector_suspend()

2015-09-28 Thread Ulrich Obergfell
lockup_detector_suspend() now handles errors from watchdog_park_threads(). Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 457113c..3bc22a9 100644 --- a/kernel/watchdog.c +++ b/kernel

[PATCH 0/5] improve handling of errors returned by kthread_park()

2015-09-28 Thread Ulrich Obergfell
s. Failure becomes visible to the user as follows: - error messages from lockup_detector_suspend() or watchdog_enable_all_cpus() - the state that can be read from /proc/sys/kernel/watchdog_enabled - the 'write' system call in the latter call chain returns an error

[PATCH 2/2] watchdog: use pr_debug() in fixup_ht_bug() failure path

2015-08-07 Thread Ulrich Obergfell
Signed-off-by: Ulrich Obergfell --- arch/x86/kernel/cpu/perf_event_intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c index 0357bf7..abb25c3 100644 --- a/arch/x86/kernel/cpu

[PATCH 0/2] watchdog: avoid races in watchdog_nmi_{en|disable} functions - follow up patches

2015-08-07 Thread Ulrich Obergfell
l=linux-kernel&m=143869949229461&w=2 Ulrich Obergfell (2): watchdog: rename watchdog_suspend() and watchdog_resume() watchdog: use pr_debug() in fixup_ht_bug() failure path arch/x86/kernel/cpu/perf_event_intel.c | 6 +++--- include/linux/nmi.h| 8 +++

[PATCH 1/2] watchdog: rename watchdog_suspend() and watchdog_resume()

2015-08-07 Thread Ulrich Obergfell
watchdog_suspended variables and their relationship. Signed-off-by: Ulrich Obergfell --- arch/x86/kernel/cpu/perf_event_intel.c | 4 ++-- include/linux/nmi.h| 8 kernel/watchdog.c | 26 ++ 3 files changed, 28 insertions(+), 10

Re: [PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume()

2015-08-05 Thread Ulrich Obergfell
> - Original Message - > From: "Andrew Morton" > ... > On Sat, 1 Aug 2015 14:49:23 +0200 Ulrich Obergfell > wrote: > >> This interface can be utilized to deactivate the hard and soft lockup >> detector temporarily. Callers are expected to

Re: [PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads()

2015-08-04 Thread Ulrich Obergfell
> - Original Message - > From: "Michal Hocko" ... > On Sat 01-08-15 14:49:22, Ulrich Obergfell wrote: >> These functions are intended to be used only from inside kernel/watchdog.c >> to park/unpark all watchdog threads that are specified in watchdog_cpuma

Re: [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug()

2015-08-04 Thread Ulrich Obergfell
> - Original Message - > From: "Don Zickus" ... > On Tue, Aug 04, 2015 at 03:31:30PM +0200, Michal Hocko wrote: >> On Sat 01-08-15 14:49:25, Ulrich Obergfell wrote: >> [...] >> > @@ -3368,7 +3368,10 @@ static __init int fix

Re: [PATCH] watchdog: Fix race on single cpu boot

2015-08-02 Thread Ulrich Obergfell
Peter, >> I posted the patch set here: >> >> https://lkml.org/lkml/2015/8/1/64 >> https://lkml.org/lkml/2015/8/1/65 >> https://lkml.org/lkml/2015/8/1/66 >> https://lkml.org/lkml/2015/8/1/67 >> https://lkml.org/lkml/2015/8/1/68 > > If only you didn't use lkml.org links, that site is fla

Re: [PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume()

2015-08-01 Thread Ulrich Obergfell
> - Original Message - > From: "Guenter Roeck" > ... > Subject: Re: [PATCH 2/4] watchdog: introduce watchdog_suspend() and > watchdog_resume() > > On Sat, Aug 01, 2015 at 02:49:23PM +0200, Ulrich Obergfell wrote: >> This interface can be utilized t

Re: [PATCH] watchdog: Fix race on single cpu boot

2015-08-01 Thread Ulrich Obergfell
Don, > Uli privately has been working on a patchset that cleans up a bunch of these > race conditions. We believe it should cover this case. It uses the > proc_mutex to synchronize everything. > > I think he is reaching out to you. If you could try his patchset to see if > it fixes things, it

[PATCH 2/4] watchdog: introduce watchdog_suspend() and watchdog_resume()

2015-08-01 Thread Ulrich Obergfell
This interface can be utilized to deactivate the hard and soft lockup detector temporarily. Callers are expected to minimize the duration of deactivation. Multiple deactivations are allowed to occur in parallel but should be rare in practice. Signed-off-by: Ulrich Obergfell --- include/linux

[PATCH 3/4] watchdog: use park/unpark functions in update_watchdog_all_cpus()

2015-08-01 Thread Ulrich Obergfell
Remove update_watchdog() and restart_watchdog_hrtimer() since these functions are no longer needed. Changes of parameters such as the sample period are honored at the time when the watchdog threads are being unparked. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 40

[PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug()

2015-08-01 Thread Ulrich Obergfell
Remove watchdog_nmi_disable_all() and watchdog_nmi_enable_all() since these functions are no longer needed. If a subsystem has a need to deactivate the watchdog temporarily, it should utilize the watchdog_suspend() and watchdog_resume() functions. Signed-off-by: Ulrich Obergfell --- arch/x86

[PATCH 1/4] watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads()

2015-08-01 Thread Ulrich Obergfell
These functions are intended to be used only from inside kernel/watchdog.c to park/unpark all watchdog threads that are specified in watchdog_cpumask. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 36 1 file changed, 36 insertions(+) diff --git a

[PATCH 0/4] watchdog: avoid races in watchdog_nmi_{en|disable} functions

2015-08-01 Thread Ulrich Obergfell
pected that the duration of deactivation will be short. Ulrich Obergfell (4): watchdog: introduce watchdog_park_threads() and watchdog_unpark_threads() watchdog: introduce watchdog_suspend() and watchdog_resume() watchdog: use park/unpark functions in update_watchdog_all_cpus() w

ioprio_set() & IOPRIO_WHO_PROCESS: Rename?

2015-07-13 Thread Ulrich Windl
READ? (i.e. #define IOPRIO_WHO_PROCESS IOPRIO_WHO_THREAD /* and #define IOPRIO_WHO_THREAD */) Regards, Ulrich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 3/4] smpboot: Allow to pass the cpumask on per-cpu thread registration

2015-07-11 Thread Ulrich Obergfell
Frederic, since you changed the function name, you may want to adjust the comment header too . v /** * smpboot_register_percpu_thread - Register a per_cpu thread related to hotplug * @plug_thread:Hotplug thread descriptor + * @cpumask:

Antw: Re: Lower bound 0.05 on 15-Minute load?

2015-07-02 Thread Ulrich Windl
>>> Martin Steigerwald schrieb am 02.07.2015 um 11:26 in Nachricht <1479160.a5Vb4cJSSF@merkaba>: > On Thursday 02 July 2015 10:50:13 Ulrich Windl wrote: >> Hi! > > Hi Ulrich, > >> I'm not subscribed, so plese CC: me for your replies. >> &g

Lower bound 0.05 on 15-Minute load?

2015-07-02 Thread Ulrich Windl
ll of "uptime" seems to confirm my suspect: windl> uptime 10:41am up 23 days 18:49, 1 user, load average: 0.08, 0.05, 0.05 windl> uptime 10:48am up 23 days 18:56, 1 user, load average: 0.00, 0.04, 0.05 windl> cat /proc/loadavg 0.00 0.04 0.05 1/108 9704 I'll attach a sample graph. Regards, Ulrich

Formatting of /proc/meminfo

2015-06-23 Thread Ulrich Windl
t (%-16s%8lu kB\n) in a constant also, allowing a change at one point to affect every item... Probably gcc will optimize the code anyway, so there won't be much difference regarding performance. Regards, Ulrich Windl -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH V8 00/28] Add new powerpc specific ELF core notes

2015-06-08 Thread Ulrich Weigand
(on and off TM) > - Implemented support for EBB register set > - Implemented review comments on previous versions > - Some code re-arrangements, re-writes and documentation > - Added comprehensive list of test cases into selftests This addresses all the issues I raised in my comments on V7. The regi

Re: suspend regression in 4.1-rc1

2015-05-18 Thread Ulrich Obergfell
Peter, please see my comments in-line. Regards, Uli - Original Message - From: "Peter Zijlstra" To: "Michal Hocko" [...] > On Mon, May 18, 2015 at 11:03:37AM +0200, Michal Hocko wrote: >> This doesn't hang anymore. I've just had to move the mutex definition >> up to make it compile.

Re: suspend regression in 4.1-rc1

2015-05-18 Thread Ulrich Obergfell
reproduce. >> > > >> > > So've tried to bisect ^80dcc31fbe55 e4b0db72be24 and merged 80dcc31fbe55 >> > > in each step. >> > >> > Good extra work! Thanks. >> > >> > > This lead to: >> > > >> > >

Re: [PATCH v9 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-29 Thread Ulrich Obergfell
- Original Message - From: "Chris Metcalf" [...] On 04/21/2015 08:32 AM, Ulrich Obergfell wrote: >> Chris, >> >> in v9, smpboot_update_cpumask_percpu_thread() allocates 'tmp' mask >> dynamically. >> This allocation can fail and thus

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-29 Thread Ulrich Obergfell
- Original Message - From: "Chris Metcalf" [...] > On 04/22/2015 04:20 AM, Ulrich Obergfell wrote: >> Chris, >> >> in principle the change looks o.k. to me, even though I'm not really familiar >> with the watchdog_nmi_disable_all() and watchd

Re: [PATCH v9 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-25 Thread Ulrich Obergfell
- Original Message - From: "Don Zickus" [...] > On Tue, Apr 21, 2015 at 10:07:00AM -0400, Ulrich Obergfell wrote: >> >> Chris, >> [...] >> I think the user should only be allowed to specify a mask that is a subset of >> tick_nohz_full_mask as o

Re: [PATCH] watchdog: Fix watchdog_nmi_enable_all()

2015-04-23 Thread Ulrich Obergfell
> - Original Message - > From: "Andrew Morton" > To: "Don Zickus" > Cc: "LKML" , "Ulrich Obergfell" > > Sent: Wednesday, April 22, 2015 10:12:01 PM > Subject: Re: [PATCH] watchdog: Fix watchdog_nmi_enable_all() > > On W

Re: [PATCH v9 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-22 Thread Ulrich Obergfell
Chris, in https://lkml.org/lkml/2015/4/17/616 you stated: ">> + alloc_cpumask_var(&watchdog_cpumask_for_smpboot, GFP_KERNEL); > > alloc_cpumask_var could fail? Good catch; if I get a failure I'll just return early without trying to start the watchdog, since clearly things are too memo

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-22 Thread Ulrich Obergfell
or_init() is executed before fixup_ht_bug(). Regards, Uli On 04/16/2015 06:46 AM, Ulrich Obergfell wrote: > if a user changes watchdog parameters in /proc/sys/kernel, the watchdog > threads > are not stopped and restarted in all cases. Parameters can also be changed 'on > the fl

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-04-21 Thread Ulrich Weigand
sible inside EBB) So I'm not really familiar with the EBB stuff. But just as a general note, if those are in fact related (i.e. on every machine that has EBB, all those registers will be available), it might indeed make more sense to collect them into a single note section (NT_PPC_EBB?) after

Re: [PATCH v9 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-21 Thread Ulrich Obergfell
Chris, I think it would also be nice to check the plausibility of the user input. +int proc_watchdog_cpumask(struct ctl_table *table, int write, + void __user *buffer, size_t *lenp, loff_t *ppos) +{ +int err; + +mutex_lock(&watchdog_proc_mutex); +

Re: [PATCH v9 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-21 Thread Ulrich Obergfell
ker" , "Don Zickus" , "Ingo Molnar" , "Andrew Morton" , "Andrew Jones" , "chai wen" , "Ulrich Obergfell" , "Fabian Frederick" , "Aaron Tomlin" , "Ben Zhang" , "Christoph Lameter" , "Gilad Ben-Yos

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-04-20 Thread Ulrich Weigand
Anshuman Khandual wrote on 13.04.2015 10:48:57: > On 04/10/2015 04:03 PM, Ulrich Weigand wrote: > > - You provide checkpointed FPR and VMX registers, but there doesn't seem > > to be any way to get at the checkpointed *VSX* registers (i.e. the part > > that is nei

[RFC PATCH 0/1] watchdog: fix watchdog_nmi_enable_all()

2015-04-17 Thread Ulrich Obergfell
to determine whether the NMI watchdog is running, not the content of watchdog_user_enabled. The attached [RFC PATCH 1/1] has undergone minimal testing only. Ulrich Obergfell (1): watchdog: fix watchdog_nmi_enable_all() kernel/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[RFC PATCH 1/1] watchdog: fix watchdog_nmi_enable_all()

2015-04-17 Thread Ulrich Obergfell
ABLED bit in 'watchdog_enabled'. Signed-off-by: Ulrich Obergfell --- kernel/watchdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 2316f50..cba2110 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -608,7 +60

Re: [PATCH v8 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz

2015-04-16 Thread Ulrich Obergfell
Chris, if a user changes watchdog parameters in /proc/sys/kernel, the watchdog threads are not stopped and restarted in all cases. Parameters can also be changed 'on the fly', for example like 'watchdog_thresh' in the following flow of execution: proc_watchdog_thresh proc_watchdog_update

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-04-08 Thread Ulrich Weigand
also provide the opportunity to operate on the full 64-bit register set. Both apply independently of whether the target process is 32-bit or 64-bit. Is this not correct? Bye, Ulrich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: linux-next: manual merge of the akpm-current tree with the tile tree

2015-04-07 Thread Ulrich Obergfell
hwell" To: "Andrew Morton" , "Chris Metcalf" Cc: linux-n...@vger.kernel.org, linux-kernel@vger.kernel.org, "Ulrich Obergfell" , "Don Zickus" Sent: Tuesday, April 7, 2015 1:21:53 PM Subject: linux-next: manual merge of the akpm-current tree with the

Re: [PATCH v4 2/2] watchdog: add watchdog_exclude sysctl to assist nohz

2015-04-05 Thread Ulrich Obergfell
Chris, I'd like to comment on the following proposed change: +int proc_dowatchdog_exclude(struct ctl_table *table, int write, +void __user *buffer, size_t *lenp, loff_t *ppos) +{ +int err; + +mutex_lock(&watchdog_proc_mutex); +err = proc_do_lar

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-03-18 Thread Ulrich Weigand
ince > > we're now in nontransactional state, and there is probably no way > > to force us back into transactional/suspended state ...). > > Yep. So right now I'd tend to prefer (A)+(A'), but the important thing is that the kernel seems to provide all features required for GDB to implement any of the above, so we can still make that decision later. > Getting back to the kernel interface, are you happy with what Anshuman > has proposed in the current series? Given the discussion above, this seems fine to me now. Bye, Ulrich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Xen. How an error message should not look like

2015-02-22 Thread Ulrich Windl
{ vbd_free(&be->blkif->vbd); xenbus_dev_fatal(dev, err, "creating sysfs entries"); } break; } Itself vbd_create() does not log a message, and neither does blkdev_get_by_dev() where the err

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-02-06 Thread Ulrich Weigand
ers, issues the trechkpt instruction to move them to the checkpointed register, and then loads the normal register set, before returning to user space? Then it does indeed appear that both sets *are* modifyable, and thus the kernel interface should export them as such. Bye, Ulrich -- To unsubsc

Re: [V6,1/9] elf: Add new powerpc specifc core note sections

2015-01-22 Thread Ulrich Weigand
splay current position (already reflecting the fact that the transaction will abort), and use it when changing register values e.g. to effect an inferior function call - a new ptrace register set should allow access (read-only) to the *running* register values -- GDB can use this to display

Re: [PATCH v2 0/8] Add Simple Power-Managed Bus Support

2015-01-09 Thread Ulrich Hecht
m9g-multiplatform. Without this, Ethernet >> doesn't work, as the ZB clock is disabled by clk_disable_unused(). >> Testing on r8a73a4/ape6evm-multiplatform would be appreciated. > > Has anyone tried this on r8a73a4/ape6evm-multiplatform? Works like a charm. Tested-by: Ulrich H

Re: [RFC] ptrace: add generic SET_SYSCALL request

2014-11-13 Thread Ulrich Weigand
r a section ".reg-s390-system-call", but that would be somewhat confusing. Using a new, platform-specific note type for ARM64 would appear to fit better with existing precedent. Bye, Ulrich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

RFE: kernel message "rport-2:0-10: blocked FC remote port time out: removing rport"

2014-10-24 Thread Ulrich Windl
the erro message if possible. Regards, Ulrich Windl -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

FYI: unclean Intel RAID reported as "clean"

2014-10-20 Thread Ulrich Windl
can find the details there. I thought the problem is important enough to let you know... Regards, Ulrich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

  1   2   3   4   5   6   7   >