Re: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote: + i2c->reg_base = devm_ioremap_resource(>dev, res); + if (IS_ERR(i2c->reg_base)) { + dev_err(>dev, "failed to map resource: %ld\n", + PTR_ERR(i2c->reg_base)); + return

Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-14 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 05:04 PM, Wolfram Sang wrote: On Tue, Jul 14, 2015 at 01:06:39PM +0530, Vaibhav Hiremath wrote: This patch series fixes bugs/warnings, cleans up the code and adds support for PXA910 family of devices to PXA I2C bus driver. There has been one attempt made sometime back

[PATCH-v2 1/2] mfd: 88pm80x: Add 88pm860 chip type support

2015-07-14 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/mfd/88pm80x.c b

[PATCH-v2 2/2] mfd: 88pm800: Add init time initial configuration support

2015-07-14 Thread Vaibhav Hiremath
not validate the configuration on 88PM800, restricting myself only to 88PM860. If anyone can validate on 88PM800, we can move common code accordingly. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski --- drivers/mfd/88pm800.c | 71

[PATCH-v2 0/2] mfd: 88pm800: Add 88pm860 device support

2015-07-14 Thread Vaibhav Hiremath
Link to RFC - https://patches.linaro.org/50604/ Vaibhav Hiremath (2): mfd: 88pm80x: Add 88pm860 chip type support mfd: 88pm800: Add init time initial configuration support drivers/mfd/88pm800.c | 71 + drivers/mfd/88pm80x.c | 2 ++ include

[PATCH-v4 03/11] i2c: pxa: Return I2C_RETRY when timeout in pio mode

2015-07-14 Thread Vaibhav Hiremath
From: Shouming Wang In case of timeout in pio mode of operation return I2C_RETRY. This behavior will be same as interrupt mode of operation. Signed-off-by: Shouming Wang [vaibhav.hirem...@linaro.org: Updated changelog] Signed-off-by: Vaibhav Hiremath Acked-by: Robert Jarzmik --- drivers/i2c

[PATCH-v4 05/11] i2c: pxa: Update debug function to dump more info on error

2015-07-14 Thread Vaibhav Hiremath
Update i2c_pxa_scream_blue_murder() fn to print more information in case of error. Also, use dev_err variants instead of printk. Signed-off-by: Jett.Zhou Signed-off-by: Vaibhav Hiremath Cc: Wolfram Sang --- drivers/i2c/busses/i2c-pxa.c | 22 +++--- 1 file changed, 15

[PATCH-v4 08/11] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-07-14 Thread Vaibhav Hiremath
Driver now supports enable/disable across msg xfer, which user can control it by new DT property - i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer and enable it back before xfer. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/i2c/i2c

[PATCH-v4 10/11] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-07-14 Thread Vaibhav Hiremath
-by: Vaibhav Hiremath Signed-off-by: Jett.Zhou Signed-off-by: Yi Zhang --- drivers/i2c/busses/i2c-pxa.c | 66 1 file changed, 60 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index 8d76197..ee79599

[PATCH-v4 09/11] i2c: pxa: Add support for pxa910/988 & new configuration features

2015-07-14 Thread Vaibhav Hiremath
ndard DT properties for ilcr and iwcr configuration fields. In case of Master ilcr is used for low/high time and in case of slave mode of operation iwcr is used for setup/hold time. Signed-off-by: Jett.Zhou Signed-off-by: Yi Zhang Signed-off-by: Vaibhav Hiremath --- drive

[PATCH-v4 11/11] Documentation: binding: add sclk adjustment properties to i2c-pxa

2015-07-14 Thread Vaibhav Hiremath
hold/setup wait counter for standard and fast mode. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b/Documentation/devicetree/bindings

[PATCH-v4 07/11] i2c: pxa: enable/disable i2c module across msg xfer

2015-07-14 Thread Vaibhav Hiremath
of the I2C module after xfer in master mode of operation. i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer Signed-off-by: Yi Zhang Signed-off-by: Vaibhav Hiremath --- Note that, in order _NOT_ to break existing slave support, we can not enable this property by default

[PATCH-v4 01/11] i2c: pxa: keep i2c irq ON in suspend

2015-07-14 Thread Vaibhav Hiremath
[vaibhav.hirem...@linaro.org: updated Changelog] Signed-off-by: Vaibhav Hiremath Cc: Wolfram Sang --- drivers/i2c/busses/i2c-pxa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c index d9c0d6a..f4ac8c5 100644

[PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Vaibhav Hiremath
instead of printk for KERN_INFO Signed-off-by: Vaibhav Hiremath Acked-by: Robert Jarzmik --- drivers/i2c/busses/i2c-pxa.c | 81 1 file changed, 30 insertions(+), 51 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c

[PATCH-v4 04/11] i2c: pxa: Fix compile warning in 64bit mode

2015-07-14 Thread Vaibhav Hiremath
From: Yipeng Yao Fix below warning message, coming from 64 bit toolchain. drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] Signed-off-by: Yipeng Yao [vaibhav.hirem...@linaro.org: Updated Changelog] Signed-off-by: Vaibhav

[PATCH-v4 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-14 Thread Vaibhav Hiremath
interface, and if we set 0x30 as a slave address in pxa1928 TWSI0 module, all the transactions towards PMIC would go for toss. Signed-off-by: Jett.Zhou Signed-off-by: Vaibhav Hiremath Acked-by: Robert Jarzmik --- drivers/i2c/busses/i2c-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-14 Thread Vaibhav Hiremath
08/12: NAKed and dropped - Separated DT binding patch from driver changes, for easy merge Leilei Shang (1): i2c: pxa: keep i2c irq ON in suspend Shouming Wang (1): i2c: pxa: Return I2C_RETRY when timeout in pio mode Vaibhav Hiremath (7): i2c: pxa: No need to set slave addr for i2c mas

[PATCH-v4 05/11] i2c: pxa: Update debug function to dump more info on error

2015-07-14 Thread Vaibhav Hiremath
Update i2c_pxa_scream_blue_murder() fn to print more information in case of error. Also, use dev_err variants instead of printk. Signed-off-by: Jett.Zhou jtz...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Cc: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c

[PATCH-v4 03/11] i2c: pxa: Return I2C_RETRY when timeout in pio mode

2015-07-14 Thread Vaibhav Hiremath
From: Shouming Wang wang...@marvell.com In case of timeout in pio mode of operation return I2C_RETRY. This behavior will be same as interrupt mode of operation. Signed-off-by: Shouming Wang wang...@marvell.com [vaibhav.hirem...@linaro.org: Updated changelog] Signed-off-by: Vaibhav Hiremath

[PATCH-v4 07/11] i2c: pxa: enable/disable i2c module across msg xfer

2015-07-14 Thread Vaibhav Hiremath
to control disable of the I2C module after xfer in master mode of operation. i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer Signed-off-by: Yi Zhang yizh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Note that, in order _NOT_ to break

[PATCH-v4 08/11] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-07-14 Thread Vaibhav Hiremath
Driver now supports enable/disable across msg xfer, which user can control it by new DT property - i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer and enable it back before xfer. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation

[PATCH-v4 11/11] Documentation: binding: add sclk adjustment properties to i2c-pxa

2015-07-14 Thread Vaibhav Hiremath
hold/setup wait counter for standard and fast mode. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt b

[PATCH-v4 10/11] i2c: pxa: Add ILCR (tLow tHigh) configuration support

2015-07-14 Thread Vaibhav Hiremath
-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Signed-off-by: Jett.Zhou jtz...@marvell.com Signed-off-by: Yi Zhang yizh...@marvell.com --- drivers/i2c/busses/i2c-pxa.c | 66 1 file changed, 60 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH-v4 09/11] i2c: pxa: Add support for pxa910/988 new configuration features

2015-07-14 Thread Vaibhav Hiremath
configuration fields. In case of Master ilcr is used for low/high time and in case of slave mode of operation iwcr is used for setup/hold time. Signed-off-by: Jett.Zhou jtz...@marvell.com Signed-off-by: Yi Zhang yizh...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org

[PATCH-v4 01/11] i2c: pxa: keep i2c irq ON in suspend

2015-07-14 Thread Vaibhav Hiremath
...@marvell.com Signed-off-by: Xiaofan Tian tia...@marvell.com [vaibhav.hirem...@linaro.org: updated Changelog] Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Cc: Wolfram Sang w...@the-dreams.de --- drivers/i2c/busses/i2c-pxa.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-14 Thread Vaibhav Hiremath
, for easy merge Leilei Shang (1): i2c: pxa: keep i2c irq ON in suspend Shouming Wang (1): i2c: pxa: Return I2C_RETRY when timeout in pio mode Vaibhav Hiremath (7): i2c: pxa: No need to set slave addr for i2c master mode reset i2c: pxa: Update debug function to dump more info on error

[PATCH-v4 04/11] i2c: pxa: Fix compile warning in 64bit mode

2015-07-14 Thread Vaibhav Hiremath
Changelog] Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Cc: Wolfram Sang w...@the-dreams.de Acked-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/i2c/busses/i2c-pxa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c

[PATCH-v4 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-14 Thread Vaibhav Hiremath
interface, and if we set 0x30 as a slave address in pxa1928 TWSI0 module, all the transactions towards PMIC would go for toss. Signed-off-by: Jett.Zhou jtz...@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Acked-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/i2c/busses/i2c

[PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Vaibhav Hiremath
instead of printk for KERN_INFO Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Acked-by: Robert Jarzmik robert.jarz...@free.fr --- drivers/i2c/busses/i2c-pxa.c | 81 1 file changed, 30 insertions(+), 51 deletions(-) diff --git a/drivers/i2c

[PATCH-v2 1/2] mfd: 88pm80x: Add 88pm860 chip type support

2015-07-14 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2 files changed, 3

[PATCH-v2 2/2] mfd: 88pm800: Add init time initial configuration support

2015-07-14 Thread Vaibhav Hiremath
not validate the configuration on 88PM800, restricting myself only to 88PM860. If anyone can validate on 88PM800, we can move common code accordingly. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/mfd/88pm800.c

[PATCH-v2 0/2] mfd: 88pm800: Add 88pm860 device support

2015-07-14 Thread Vaibhav Hiremath
://patches.linaro.org/50604/ Vaibhav Hiremath (2): mfd: 88pm80x: Add 88pm860 chip type support mfd: 88pm800: Add init time initial configuration support drivers/mfd/88pm800.c | 71 + drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 14

Re: [PATCH-v4 00/11] i2c: pxa: Fixes, cleanup and support for pxa910 family

2015-07-14 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 05:04 PM, Wolfram Sang wrote: On Tue, Jul 14, 2015 at 01:06:39PM +0530, Vaibhav Hiremath wrote: This patch series fixes bugs/warnings, cleans up the code and adds support for PXA910 family of devices to PXA I2C bus driver. There has been one attempt made sometime back

Re: [PATCH-v4 06/11] i2c:pxa: Use devm_ variants in probe function

2015-07-14 Thread Vaibhav Hiremath
On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote: + i2c-reg_base = devm_ioremap_resource(dev-dev, res); + if (IS_ERR(i2c-reg_base)) { + dev_err(dev-dev, failed to map resource: %ld\n, + PTR_ERR(i2c-reg_base)); + return

Re: [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support

2015-07-13 Thread Vaibhav Hiremath
On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also sets default configuration of irq clear method if board file doesn't exist. Testing:: - Boot tested on PXA1928 based platform. - probe of mfd, rtc

Re: [PATCH-v3 07/11] i2c: pxa: enable/disable i2c module across msg xfer

2015-07-13 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:54 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:51AM +0530, Vaibhav Hiremath wrote: From: Yi Zhang Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be distrubed if the slave device, typically

Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-07-13 Thread Vaibhav Hiremath
On Monday 13 July 2015 01:40 PM, Krzysztof Kozlowski wrote: On 13.07.2015 16:50, Vaibhav Hiremath wrote: On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM860 family of device supports dual phase mode on BUCK1 supply

Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-07-13 Thread Vaibhav Hiremath
On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch adds

Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable

2015-07-13 Thread Vaibhav Hiremath
On Monday 13 July 2015 01:01 PM, Krzysztof Kozlowski wrote: On 13.07.2015 16:24, Vaibhav Hiremath wrote: On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM800 family of device supports output of 32KHz clock (low jitter

Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable

2015-07-13 Thread Vaibhav Hiremath
On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM800 family of device supports output of 32KHz clock (low jitter) on CLK32K2/3 pin which can be supplied to other peripherals on the board. This patch adds the devicetree

Re: [PATCH 2/6] mfd: 88pm800: Add init time initial configuration support

2015-07-13 Thread Vaibhav Hiremath
On Saturday 11 July 2015 12:23 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: This patch adds init time configuration of 88PM800/805 and 88PM860. It includes, - Enable BUCK clock gating in low power mode - Full mode support for BUCK2 and 4 - Enable

Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-13 Thread Vaibhav Hiremath
On Friday 10 July 2015 08:26 PM, Wolfram Sang wrote: On Fri, Jul 10, 2015 at 07:55:31PM +0530, Vaibhav Hiremath wrote: On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote: On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote: On Friday 10 July 2015 01:41 PM, Wolfram Sang

Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-07-13 Thread Vaibhav Hiremath
On Monday 13 July 2015 01:40 PM, Krzysztof Kozlowski wrote: On 13.07.2015 16:50, Vaibhav Hiremath wrote: On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM860 family of device supports dual phase mode on BUCK1 supply

Re: [PATCH-v6 0/6] mfd: 88pm800: Add Device tree support

2015-07-13 Thread Vaibhav Hiremath
On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote: This patch-series adds support for Device tree to 88PM800 mfd driver. It also sets default configuration of irq clear method if board file doesn't exist. Testing:: - Boot tested on PXA1928 based platform. - probe of mfd, rtc

Re: [PATCH-v3 07/11] i2c: pxa: enable/disable i2c module across msg xfer

2015-07-13 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:54 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:51AM +0530, Vaibhav Hiremath wrote: From: Yi Zhang yizh...@marvell.com Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be distrubed if the slave

Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-13 Thread Vaibhav Hiremath
On Friday 10 July 2015 08:26 PM, Wolfram Sang wrote: On Fri, Jul 10, 2015 at 07:55:31PM +0530, Vaibhav Hiremath wrote: On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote: On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote: On Friday 10 July 2015 01:41 PM, Wolfram Sang

Re: [PATCH 2/6] mfd: 88pm800: Add init time initial configuration support

2015-07-13 Thread Vaibhav Hiremath
On Saturday 11 July 2015 12:23 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: This patch adds init time configuration of 88PM800/805 and 88PM860. It includes, - Enable BUCK clock gating in low power mode - Full mode support for BUCK2 and 4 - Enable

Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable

2015-07-13 Thread Vaibhav Hiremath
On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM800 family of device supports output of 32KHz clock (low jitter) on CLK32K2/3 pin which can be supplied to other peripherals on the board. This patch adds the devicetree

Re: [PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable

2015-07-13 Thread Vaibhav Hiremath
On Monday 13 July 2015 01:01 PM, Krzysztof Kozlowski wrote: On 13.07.2015 16:24, Vaibhav Hiremath wrote: On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM800 family of device supports output of 32KHz clock (low jitter

Re: [PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-07-13 Thread Vaibhav Hiremath
On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote: W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze: 88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch adds

Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote: On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote: On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote: Normally i2c controller works as master, so slave

Re: [PATCH-v3 04/11] i2c: pxa: Remove compile warnning in 64bit mode

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:43 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:48AM +0530, Vaibhav Hiremath wrote: From: Yipeng Yao Fix below warning message, coming from 64 bit toolchain. drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer of different size

Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote: Normally i2c controller works as master, so slave addr is not needed, or it will impact some slave device (eg. ST NFC chip) i2c accesses, because it has the same i2c address

Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:06 AM, valdis.kletni...@vt.edu wrote: On Thu, 09 Jul 2015 18:11:32 +0530, Vaibhav Hiremath said: This patch adds dev_info line at the end of probe function, to clearly put status of regulator probe on console. Useful during development, specially to check bootlog

Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 12:35 AM, Mark Brown wrote: On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote: This patch adds dev_info line at the end of probe function, to clearly put status of regulator probe on console. Useful during development, specially to check bootlog

Re: [PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 12:34 AM, Mark Brown wrote: On Thu, Jul 09, 2015 at 06:11:31PM +0530, Vaibhav Hiremath wrote: From: Yi Zhang As per datasheet, Except LDO2, all other LDO's use bit [3:0] for VOUT select. Bug fixes like this should come at the start of the series before new

Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-10 Thread Vaibhav Hiremath
On Thursday 09 July 2015 06:58 PM, Krzysztof Kozlowski wrote: 2015-07-09 21:53 GMT+09:00 Vaibhav Hiremath : On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote: On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote: 2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath : 88PM860

Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-10 Thread Vaibhav Hiremath
On Thursday 09 July 2015 06:58 PM, Krzysztof Kozlowski wrote: 2015-07-09 21:53 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote: On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote: 2015-07-09 20:47 GMT+09:00

Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote: Normally i2c controller works as master, so slave addr is not needed, or it will impact some slave device (eg. ST NFC chip) i2c accesses, because it has the same i2c address

Re: [PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 12:34 AM, Mark Brown wrote: On Thu, Jul 09, 2015 at 06:11:31PM +0530, Vaibhav Hiremath wrote: From: Yi Zhang yizh...@marvell.com As per datasheet, Except LDO2, all other LDO's use bit [3:0] for VOUT select. Bug fixes like this should come at the start of the series

Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 12:35 AM, Mark Brown wrote: On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote: This patch adds dev_info line at the end of probe function, to clearly put status of regulator probe on console. Useful during development, specially to check bootlog

Re: [PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:06 AM, valdis.kletni...@vt.edu wrote: On Thu, 09 Jul 2015 18:11:32 +0530, Vaibhav Hiremath said: This patch adds dev_info line at the end of probe function, to clearly put status of regulator probe on console. Useful during development, specially to check bootlog

Re: [PATCH-v3 04/11] i2c: pxa: Remove compile warnning in 64bit mode

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 01:43 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:48AM +0530, Vaibhav Hiremath wrote: From: Yipeng Yao yp...@marvell.com Fix below warning message, coming from 64 bit toolchain. drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer

Re: [PATCH-v3 02/11] i2c: pxa: No need to set slave addr for i2c master mode reset

2015-07-10 Thread Vaibhav Hiremath
On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote: On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote: On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote: On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote: Normally i2c controller works as master, so slave

Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-09 Thread Vaibhav Hiremath
On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote: On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote: 2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath : 88PM860 falls under 88pm800 family of devices, with some feature additions, for example, support for dual phase on BUCK1

[PATCH 1/3] regulator: 88pm800: Add 88pm860 regulator support

2015-07-09 Thread Vaibhav Hiremath
also renames to more generic name. TODO: - Validation on 88PM800 device, looking for some help here, as I do not have any platform with 88PM800 device. Signed-off-by: Vaibhav Hiremath Signed-off-by: Hongyan Song --- drivers/regulator/88pm800.c | 194

[PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value

2015-07-09 Thread Vaibhav Hiremath
-by: Vaibhav Hiremath --- drivers/regulator/88pm800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c index d22a098..fdebd23 100644 --- a/drivers/regulator/88pm800.c +++ b/drivers/regulator/88pm800.c @@ -137,7 +137,7 @@ struct

[PATCH 0/3] regulator: 88pm800: Add 88pm860 regulator support

2015-07-09 Thread Vaibhav Hiremath
, as I do not have any platform with 88PM800 device. Vaibhav Hiremath (2): regulator: 88pm800: Add 88pm860 regulator support regulator: 88pm800: Add dev_info to show probe success status Yi Zhang (1): regulator: 88pm800: fix LDO vsel_mask value drivers/regulator/88pm800.c | 197

[PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

2015-07-09 Thread Vaibhav Hiremath
This patch adds dev_info line at the end of probe function, to clearly put status of regulator probe on console. Useful during development, specially to check bootlog. Signed-off-by: Vaibhav Hiremath --- drivers/regulator/88pm800.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers

Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-09 Thread Vaibhav Hiremath
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote: 2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath : 88PM860 falls under 88pm800 family of devices, with some feature additions, for example, support for dual phase on BUCK1. Hi, There are already drivers for 88PM860: mfd, charger

Re: [RESEND PATCH-v2] rtc: 88pm80x: add device tree support

2015-07-09 Thread Vaibhav Hiremath
On Thursday 09 July 2015 05:25 PM, Alexandre Belloni wrote: Hi, On 09/07/2015 at 12:25:51 +0530, Vaibhav Hiremath wrote : Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath

[PATCH 4/6] mfd: 88pm800: Enable 32KHZ XO low jitter clock out

2015-07-09 Thread Vaibhav Hiremath
ot; Since this configuration is controlled through DT property, it is safe to put it as common code. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 13 + include/linux/mfd/88pm80x.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/mfd/88pm800.c b/d

[PATCH 6/6] mfd: 88pm800: Add support for configuration of dual phase on BUCK1

2015-07-09 Thread Vaibhav Hiremath
buck1-dualphase-en" Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 11 +++ include/linux/mfd/88pm80x.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 8930fd8..a2ef0c7 100644 --- a/drivers/mfd/88pm800.c +++ b/d

[PATCH 1/6] mfd: 88pm80x: Add 88pm860 chip type support

2015-07-09 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/mfd/88pm80x.c b/drivers/mfd/88pm80x.c index

[PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable

2015-07-09 Thread Vaibhav Hiremath
88PM800 family of device supports output of 32KHz clock (low jitter) on CLK32K2/3 pin which can be supplied to other peripherals on the board. This patch adds the devicetree binding to enable this feature. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings/mfd/88pm800.txt

[PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-07-09 Thread Vaibhav Hiremath
88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch adds the devicetree binding to enable this feature. Signed-off-by: Vaibhav Hiremath --- Documentation/devicetree/bindings

[PATCH 2/6] mfd: 88pm800: Add init time initial configuration support

2015-07-09 Thread Vaibhav Hiremath
not validate the configuration on 88PM800, restricting myself only to 88PM860. If anyone can validate on 88PM800, we can move common code accordingly. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 64 + include/linux/mfd/88pm80x.h | 13

[PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-09 Thread Vaibhav Hiremath
configuration also includes pinmux setting for the device. I am working on using pinctrl-single driver to have standard and generic interface, hopefully it will get handled through pinctrl subsystem. Link to RFC - https://patches.linaro.org/50604/ Vaibhav Hiremath (6): mfd: 88pm80x: Add

[RESEND PATCH-v2] rtc: 88pm80x: add device tree support

2015-07-09 Thread Vaibhav Hiremath
Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath --- drivers/rtc/rtc-88pm80x.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git

[RESEND PATCH-v2] rtc: 88pm80x: add device tree support

2015-07-09 Thread Vaibhav Hiremath
Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie chao@marvell.com Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/rtc/rtc-88pm80x.c | 28 +--- 1 file changed, 17

[PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-09 Thread Vaibhav Hiremath
configuration also includes pinmux setting for the device. I am working on using pinctrl-single driver to have standard and generic interface, hopefully it will get handled through pinctrl subsystem. Link to RFC - https://patches.linaro.org/50604/ Vaibhav Hiremath (6): mfd: 88pm80x: Add

Re: [RESEND PATCH-v2] rtc: 88pm80x: add device tree support

2015-07-09 Thread Vaibhav Hiremath
On Thursday 09 July 2015 05:25 PM, Alexandre Belloni wrote: Hi, On 09/07/2015 at 12:25:51 +0530, Vaibhav Hiremath wrote : Along with DT support, this patch also cleans up the unnecessary code around 'rtc_wakeup' initialization. Signed-off-by: Chao Xie chao@marvell.com Signed-off

[PATCH 5/6] mfd: devicetree: bindings: 88pm800: Add DT property for dual phase enable

2015-07-09 Thread Vaibhav Hiremath
88PM860 family of device supports dual phase mode on BUCK1 supply providing total 6A capacity. Note that by default they operate independently with 3A capacity. This patch adds the devicetree binding to enable this feature. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org

[PATCH 2/6] mfd: 88pm800: Add init time initial configuration support

2015-07-09 Thread Vaibhav Hiremath
not validate the configuration on 88PM800, restricting myself only to 88PM860. If anyone can validate on 88PM800, we can move common code accordingly. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 64

[PATCH 1/6] mfd: 88pm80x: Add 88pm860 chip type support

2015-07-09 Thread Vaibhav Hiremath
Add chip identification support for 88PM860 device to the pm80x_chip_mapping table. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm80x.c | 2 ++ include/linux/mfd/88pm80x.h | 1 + 2 files changed, 3 insertions(+) diff --git a/drivers/mfd/88pm80x.c b

[PATCH 3/6] mfd: devicetree: bindings: 88pm800: Add DT property for 32KHz output enable

2015-07-09 Thread Vaibhav Hiremath
88PM800 family of device supports output of 32KHz clock (low jitter) on CLK32K2/3 pin which can be supplied to other peripherals on the board. This patch adds the devicetree binding to enable this feature. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- Documentation/devicetree

[PATCH 6/6] mfd: 88pm800: Add support for configuration of dual phase on BUCK1

2015-07-09 Thread Vaibhav Hiremath
-en Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 11 +++ include/linux/mfd/88pm80x.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c index 8930fd8..a2ef0c7 100644 --- a/drivers/mfd

[PATCH 4/6] mfd: 88pm800: Enable 32KHZ XO low jitter clock out

2015-07-09 Thread Vaibhav Hiremath
this configuration is controlled through DT property, it is safe to put it as common code. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/mfd/88pm800.c | 13 + include/linux/mfd/88pm80x.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/mfd

[PATCH 1/3] regulator: 88pm800: Add 88pm860 regulator support

2015-07-09 Thread Vaibhav Hiremath
also renames to more generic name. TODO: - Validation on 88PM800 device, looking for some help here, as I do not have any platform with 88PM800 device. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org Signed-off-by: Hongyan Song hys...@marvell.com --- drivers/regulator/88pm800.c

[PATCH 3/3] regulator: 88pm800: Add dev_info to show probe success status

2015-07-09 Thread Vaibhav Hiremath
This patch adds dev_info line at the end of probe function, to clearly put status of regulator probe on console. Useful during development, specially to check bootlog. Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/regulator/88pm800.c | 1 + 1 file changed, 1 insertion

[PATCH 2/3] regulator: 88pm800: fix LDO vsel_mask value

2015-07-09 Thread Vaibhav Hiremath
detailed description] Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org --- drivers/regulator/88pm800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c index d22a098..fdebd23 100644 --- a/drivers/regulator

[PATCH 0/3] regulator: 88pm800: Add 88pm860 regulator support

2015-07-09 Thread Vaibhav Hiremath
, as I do not have any platform with 88PM800 device. Vaibhav Hiremath (2): regulator: 88pm800: Add 88pm860 regulator support regulator: 88pm800: Add dev_info to show probe success status Yi Zhang (1): regulator: 88pm800: fix LDO vsel_mask value drivers/regulator/88pm800.c | 197

Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-09 Thread Vaibhav Hiremath
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote: 2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: 88PM860 falls under 88pm800 family of devices, with some feature additions, for example, support for dual phase on BUCK1. Hi, There are already drivers

Re: [PATCH 0/6] mfd: 88pm800: Add 88pm860 device support

2015-07-09 Thread Vaibhav Hiremath
On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote: On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote: 2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org: 88PM860 falls under 88pm800 family of devices, with some feature additions, for example, support

[PATCH-v6 6/6] mfd: devicetree: bindings: Add new 88pm800 mfd binding

2015-07-08 Thread Vaibhav Hiremath
With addition of DT support to 88pm800 mfd driver, this patch adds new DT binding documentation along with respective properties. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Rob Herring Acked-by: Lee Jones --- Documentation/devicetree/bindings/mfd/88pm800.txt

[PATCH-v6 5/6] mfd: 88pm800: Set default interrupt clear method

2015-07-08 Thread Vaibhav Hiremath
uot; Also, as suggested by "Lee Jones" renaming variable field to appropriate name and removed unnecessary field pm80x_chip.irq_mode, using platform_data.irq_clr_method. Signed-off-by: Zhao Ye Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski --- drivers/mfd/

[PATCH-v6 2/6] mfd: 88pm800: Add device tree support

2015-07-08 Thread Vaibhav Hiremath
Add DT support to the 88pm800 driver, along with compatible field for it's sub-devices (rtc, onkey and regulator) Signed-off-by: Chao Xie Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Lee Jones --- drivers/mfd/88pm800.c | 26 ++ 1 file

[PATCH-v6 4/6] mfd: 88pm800: Remove unnecessary protection around pdata

2015-07-08 Thread Vaibhav Hiremath
With addition of proper checks in place in pm800_probe function, which makes sure that pdata would never become NULL. So remove all unnecessary protection around pdata in whole driver code. Signed-off-by: Vaibhav Hiremath Reviewed-by: Krzysztof Kozlowski Acked-by: Lee Jones --- drivers/mfd

[PATCH-v6 1/6] mfd: 88pm800: remove duplicate dev_err calls during probe

2015-07-08 Thread Vaibhav Hiremath
During probe, inside fn device_800_init(), submodule init is happening and the same error message is getting printed in both the places, _init() and inside device_800_init(). So this patch gets rid of dev_err from _init() fns. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 32

[PATCH-v6 3/6] mfd: 88pm800: Get pdata from 'device' rather than passing as a parameter

2015-07-08 Thread Vaibhav Hiremath
Currently the device_xxx_init() fns take pdata as an input parameter to the fn, but the cleaner approach would be to use dev_get_platdata() to get the pdata. So this patch changes the code accordingly. Signed-off-by: Vaibhav Hiremath --- drivers/mfd/88pm800.c | 29

<    1   2   3   4   5   6   7   >