On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote:
+ i2c->reg_base = devm_ioremap_resource(>dev, res);
+ if (IS_ERR(i2c->reg_base)) {
+ dev_err(>dev, "failed to map resource: %ld\n",
+ PTR_ERR(i2c->reg_base));
+ return
On Tuesday 14 July 2015 05:04 PM, Wolfram Sang wrote:
On Tue, Jul 14, 2015 at 01:06:39PM +0530, Vaibhav Hiremath wrote:
This patch series fixes bugs/warnings, cleans up the code and adds
support for PXA910 family of devices to PXA I2C bus driver.
There has been one attempt made sometime back
Add chip identification support for 88PM860 device
to the pm80x_chip_mapping table.
Signed-off-by: Vaibhav Hiremath
Reviewed-by: Krzysztof Kozlowski
---
drivers/mfd/88pm80x.c | 2 ++
include/linux/mfd/88pm80x.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/mfd/88pm80x.c b
not validate the configuration on 88PM800,
restricting myself only to 88PM860.
If anyone can validate on 88PM800, we can move common code accordingly.
Signed-off-by: Vaibhav Hiremath
Reviewed-by: Krzysztof Kozlowski
---
drivers/mfd/88pm800.c | 71
Link to RFC - https://patches.linaro.org/50604/
Vaibhav Hiremath (2):
mfd: 88pm80x: Add 88pm860 chip type support
mfd: 88pm800: Add init time initial configuration support
drivers/mfd/88pm800.c | 71 +
drivers/mfd/88pm80x.c | 2 ++
include
From: Shouming Wang
In case of timeout in pio mode of operation return I2C_RETRY.
This behavior will be same as interrupt mode of operation.
Signed-off-by: Shouming Wang
[vaibhav.hirem...@linaro.org: Updated changelog]
Signed-off-by: Vaibhav Hiremath
Acked-by: Robert Jarzmik
---
drivers/i2c
Update i2c_pxa_scream_blue_murder() fn to print more information
in case of error.
Also, use dev_err variants instead of printk.
Signed-off-by: Jett.Zhou
Signed-off-by: Vaibhav Hiremath
Cc: Wolfram Sang
---
drivers/i2c/busses/i2c-pxa.c | 22 +++---
1 file changed, 15
Driver now supports enable/disable across msg xfer, which user
can control it by new DT property -
i2c-disable-after-xfer : If set, driver will disable I2C module after msg
xfer and enable it back before xfer.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/i2c/i2c
-by: Vaibhav Hiremath
Signed-off-by: Jett.Zhou
Signed-off-by: Yi Zhang
---
drivers/i2c/busses/i2c-pxa.c | 66
1 file changed, 60 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 8d76197..ee79599
ndard
DT properties for ilcr and iwcr configuration fields.
In case of Master ilcr is used for low/high time and in case of slave mode
of operation iwcr is used for setup/hold time.
Signed-off-by: Jett.Zhou
Signed-off-by: Yi Zhang
Signed-off-by: Vaibhav Hiremath
---
drive
hold/setup wait counter for
standard and fast mode.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 +
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt
b/Documentation/devicetree/bindings
of the I2C module after xfer in master
mode of operation.
i2c-disable-after-xfer : If set, driver will disable I2C module after
msg xfer
Signed-off-by: Yi Zhang
Signed-off-by: Vaibhav Hiremath
---
Note that, in order _NOT_ to break existing slave support, we can not
enable this property by default
[vaibhav.hirem...@linaro.org: updated Changelog]
Signed-off-by: Vaibhav Hiremath
Cc: Wolfram Sang
---
drivers/i2c/busses/i2c-pxa.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index d9c0d6a..f4ac8c5 100644
instead of printk for KERN_INFO
Signed-off-by: Vaibhav Hiremath
Acked-by: Robert Jarzmik
---
drivers/i2c/busses/i2c-pxa.c | 81
1 file changed, 30 insertions(+), 51 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
From: Yipeng Yao
Fix below warning message, coming from 64 bit toolchain.
drivers/i2c/busses/i2c-pxa.c:1237:15:
warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Signed-off-by: Yipeng Yao
[vaibhav.hirem...@linaro.org: Updated Changelog]
Signed-off-by: Vaibhav
interface, and if we set 0x30 as a slave address in
pxa1928 TWSI0 module, all the transactions towards PMIC would go for toss.
Signed-off-by: Jett.Zhou
Signed-off-by: Vaibhav Hiremath
Acked-by: Robert Jarzmik
---
drivers/i2c/busses/i2c-pxa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
08/12: NAKed and dropped
- Separated DT binding patch from driver changes, for easy merge
Leilei Shang (1):
i2c: pxa: keep i2c irq ON in suspend
Shouming Wang (1):
i2c: pxa: Return I2C_RETRY when timeout in pio mode
Vaibhav Hiremath (7):
i2c: pxa: No need to set slave addr for i2c mas
Update i2c_pxa_scream_blue_murder() fn to print more information
in case of error.
Also, use dev_err variants instead of printk.
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c
From: Shouming Wang wang...@marvell.com
In case of timeout in pio mode of operation return I2C_RETRY.
This behavior will be same as interrupt mode of operation.
Signed-off-by: Shouming Wang wang...@marvell.com
[vaibhav.hirem...@linaro.org: Updated changelog]
Signed-off-by: Vaibhav Hiremath
to control disable of the I2C module after xfer in master
mode of operation.
i2c-disable-after-xfer : If set, driver will disable I2C module after
msg xfer
Signed-off-by: Yi Zhang yizh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Note that, in order _NOT_ to break
Driver now supports enable/disable across msg xfer, which user
can control it by new DT property -
i2c-disable-after-xfer : If set, driver will disable I2C module after msg
xfer and enable it back before xfer.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation
hold/setup wait counter for
standard and fast mode.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 +
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt
b
-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Yi Zhang yizh...@marvell.com
---
drivers/i2c/busses/i2c-pxa.c | 66
1 file changed, 60 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c
configuration fields.
In case of Master ilcr is used for low/high time and in case of slave mode
of operation iwcr is used for setup/hold time.
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Yi Zhang yizh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
...@marvell.com
Signed-off-by: Xiaofan Tian tia...@marvell.com
[vaibhav.hirem...@linaro.org: updated Changelog]
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-pxa.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
, for easy merge
Leilei Shang (1):
i2c: pxa: keep i2c irq ON in suspend
Shouming Wang (1):
i2c: pxa: Return I2C_RETRY when timeout in pio mode
Vaibhav Hiremath (7):
i2c: pxa: No need to set slave addr for i2c master mode reset
i2c: pxa: Update debug function to dump more info on error
Changelog]
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
Acked-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/i2c/busses/i2c-pxa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c
interface, and if we set 0x30 as a slave address in
pxa1928 TWSI0 module, all the transactions towards PMIC would go for toss.
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Acked-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/i2c/busses/i2c
instead of printk for KERN_INFO
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Acked-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/i2c/busses/i2c-pxa.c | 81
1 file changed, 30 insertions(+), 51 deletions(-)
diff --git a/drivers/i2c
Add chip identification support for 88PM860 device
to the pm80x_chip_mapping table.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/mfd/88pm80x.c | 2 ++
include/linux/mfd/88pm80x.h | 1 +
2 files changed, 3
not validate the configuration on 88PM800,
restricting myself only to 88PM860.
If anyone can validate on 88PM800, we can move common code accordingly.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
drivers/mfd/88pm800.c
://patches.linaro.org/50604/
Vaibhav Hiremath (2):
mfd: 88pm80x: Add 88pm860 chip type support
mfd: 88pm800: Add init time initial configuration support
drivers/mfd/88pm800.c | 71 +
drivers/mfd/88pm80x.c | 2 ++
include/linux/mfd/88pm80x.h | 14
On Tuesday 14 July 2015 05:04 PM, Wolfram Sang wrote:
On Tue, Jul 14, 2015 at 01:06:39PM +0530, Vaibhav Hiremath wrote:
This patch series fixes bugs/warnings, cleans up the code and adds
support for PXA910 family of devices to PXA I2C bus driver.
There has been one attempt made sometime back
On Tuesday 14 July 2015 05:05 PM, Wolfram Sang wrote:
+ i2c-reg_base = devm_ioremap_resource(dev-dev, res);
+ if (IS_ERR(i2c-reg_base)) {
+ dev_err(dev-dev, failed to map resource: %ld\n,
+ PTR_ERR(i2c-reg_base));
+ return
On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote:
This patch-series adds support for Device tree to 88PM800 mfd driver.
It also sets default configuration of irq clear method if board file
doesn't exist.
Testing::
- Boot tested on PXA1928 based platform.
- probe of mfd, rtc
On Friday 10 July 2015 01:54 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:51AM +0530, Vaibhav Hiremath wrote:
From: Yi Zhang
Enable i2c module/unit before transmission and disable when it finishes.
why?
It's because the i2c bus may be distrubed if the slave device,
typically
On Monday 13 July 2015 01:40 PM, Krzysztof Kozlowski wrote:
On 13.07.2015 16:50, Vaibhav Hiremath wrote:
On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM860 family of device supports dual phase mode on BUCK1 supply
On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM860 family of device supports dual phase mode on BUCK1 supply
providing total 6A capacity.
Note that by default they operate independently with 3A capacity.
This patch adds
On Monday 13 July 2015 01:01 PM, Krzysztof Kozlowski wrote:
On 13.07.2015 16:24, Vaibhav Hiremath wrote:
On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM800 family of device supports output of 32KHz clock (low jitter
On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM800 family of device supports output of 32KHz clock (low jitter)
on CLK32K2/3 pin which can be supplied to other peripherals on the board.
This patch adds the devicetree
On Saturday 11 July 2015 12:23 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
This patch adds init time configuration of 88PM800/805 and
88PM860. It includes,
- Enable BUCK clock gating in low power mode
- Full mode support for BUCK2 and 4
- Enable
On Friday 10 July 2015 08:26 PM, Wolfram Sang wrote:
On Fri, Jul 10, 2015 at 07:55:31PM +0530, Vaibhav Hiremath wrote:
On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote:
On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote:
On Friday 10 July 2015 01:41 PM, Wolfram Sang
On Monday 13 July 2015 01:40 PM, Krzysztof Kozlowski wrote:
On 13.07.2015 16:50, Vaibhav Hiremath wrote:
On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM860 family of device supports dual phase mode on BUCK1 supply
On Wednesday 08 July 2015 05:56 PM, Vaibhav Hiremath wrote:
This patch-series adds support for Device tree to 88PM800 mfd driver.
It also sets default configuration of irq clear method if board file
doesn't exist.
Testing::
- Boot tested on PXA1928 based platform.
- probe of mfd, rtc
On Friday 10 July 2015 01:54 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:51AM +0530, Vaibhav Hiremath wrote:
From: Yi Zhang yizh...@marvell.com
Enable i2c module/unit before transmission and disable when it finishes.
why?
It's because the i2c bus may be distrubed if the slave
On Friday 10 July 2015 08:26 PM, Wolfram Sang wrote:
On Fri, Jul 10, 2015 at 07:55:31PM +0530, Vaibhav Hiremath wrote:
On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote:
On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote:
On Friday 10 July 2015 01:41 PM, Wolfram Sang
On Saturday 11 July 2015 12:23 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
This patch adds init time configuration of 88PM800/805 and
88PM860. It includes,
- Enable BUCK clock gating in low power mode
- Full mode support for BUCK2 and 4
- Enable
On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM800 family of device supports output of 32KHz clock (low jitter)
on CLK32K2/3 pin which can be supplied to other peripherals on the board.
This patch adds the devicetree
On Monday 13 July 2015 01:01 PM, Krzysztof Kozlowski wrote:
On 13.07.2015 16:24, Vaibhav Hiremath wrote:
On Saturday 11 July 2015 12:41 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM800 family of device supports output of 32KHz clock (low jitter
On Saturday 11 July 2015 12:46 PM, Krzysztof Kozlowski wrote:
W dniu 09.07.2015 o 20:47, Vaibhav Hiremath pisze:
88PM860 family of device supports dual phase mode on BUCK1 supply
providing total 6A capacity.
Note that by default they operate independently with 3A capacity.
This patch adds
On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote:
On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote:
On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote:
Normally i2c controller works as master, so slave
On Friday 10 July 2015 01:43 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:48AM +0530, Vaibhav Hiremath wrote:
From: Yipeng Yao
Fix below warning message, coming from 64 bit toolchain.
drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer of
different size
On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote:
Normally i2c controller works as master, so slave addr is not needed, or it
will impact some slave device (eg. ST NFC chip) i2c accesses, because it has
the same i2c address
On Friday 10 July 2015 01:06 AM, valdis.kletni...@vt.edu wrote:
On Thu, 09 Jul 2015 18:11:32 +0530, Vaibhav Hiremath said:
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog
On Friday 10 July 2015 12:35 AM, Mark Brown wrote:
On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote:
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog
On Friday 10 July 2015 12:34 AM, Mark Brown wrote:
On Thu, Jul 09, 2015 at 06:11:31PM +0530, Vaibhav Hiremath wrote:
From: Yi Zhang
As per datasheet,
Except LDO2, all other LDO's use bit [3:0] for VOUT select.
Bug fixes like this should come at the start of the series before new
On Thursday 09 July 2015 06:58 PM, Krzysztof Kozlowski wrote:
2015-07-09 21:53 GMT+09:00 Vaibhav Hiremath :
On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote:
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote:
2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath
:
88PM860
On Thursday 09 July 2015 06:58 PM, Krzysztof Kozlowski wrote:
2015-07-09 21:53 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org:
On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote:
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote:
2015-07-09 20:47 GMT+09:00
On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote:
Normally i2c controller works as master, so slave addr is not needed, or it
will impact some slave device (eg. ST NFC chip) i2c accesses, because it has
the same i2c address
On Friday 10 July 2015 12:34 AM, Mark Brown wrote:
On Thu, Jul 09, 2015 at 06:11:31PM +0530, Vaibhav Hiremath wrote:
From: Yi Zhang yizh...@marvell.com
As per datasheet,
Except LDO2, all other LDO's use bit [3:0] for VOUT select.
Bug fixes like this should come at the start of the series
On Friday 10 July 2015 12:35 AM, Mark Brown wrote:
On Thu, Jul 09, 2015 at 06:11:32PM +0530, Vaibhav Hiremath wrote:
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog
On Friday 10 July 2015 01:06 AM, valdis.kletni...@vt.edu wrote:
On Thu, 09 Jul 2015 18:11:32 +0530, Vaibhav Hiremath said:
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog
On Friday 10 July 2015 01:43 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:48AM +0530, Vaibhav Hiremath wrote:
From: Yipeng Yao yp...@marvell.com
Fix below warning message, coming from 64 bit toolchain.
drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer
On Friday 10 July 2015 07:44 PM, Wolfram Sang wrote:
On Fri, Jul 10, 2015 at 06:08:43PM +0530, Vaibhav Hiremath wrote:
On Friday 10 July 2015 01:41 PM, Wolfram Sang wrote:
On Tue, Jul 07, 2015 at 12:54:46AM +0530, Vaibhav Hiremath wrote:
Normally i2c controller works as master, so slave
On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote:
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote:
2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath
:
88PM860 falls under 88pm800 family of devices, with some feature
additions, for example, support for dual phase on BUCK1
also renames to more generic name.
TODO:
- Validation on 88PM800 device, looking for some help here, as I do
not have any platform with 88PM800 device.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Hongyan Song
---
drivers/regulator/88pm800.c | 194
-by: Vaibhav Hiremath
---
drivers/regulator/88pm800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c
index d22a098..fdebd23 100644
--- a/drivers/regulator/88pm800.c
+++ b/drivers/regulator/88pm800.c
@@ -137,7 +137,7 @@ struct
, as I do
not have any platform with 88PM800 device.
Vaibhav Hiremath (2):
regulator: 88pm800: Add 88pm860 regulator support
regulator: 88pm800: Add dev_info to show probe success status
Yi Zhang (1):
regulator: 88pm800: fix LDO vsel_mask value
drivers/regulator/88pm800.c | 197
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog.
Signed-off-by: Vaibhav Hiremath
---
drivers/regulator/88pm800.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote:
2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath :
88PM860 falls under 88pm800 family of devices, with some feature
additions, for example, support for dual phase on BUCK1.
Hi,
There are already drivers for 88PM860: mfd, charger
On Thursday 09 July 2015 05:25 PM, Alexandre Belloni wrote:
Hi,
On 09/07/2015 at 12:25:51 +0530, Vaibhav Hiremath wrote :
Along with DT support, this patch also cleans up the unnecessary
code around 'rtc_wakeup' initialization.
Signed-off-by: Chao Xie
Signed-off-by: Vaibhav Hiremath
ot;
Since this configuration is controlled through DT property, it is
safe to put it as common code.
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 13 +
include/linux/mfd/88pm80x.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/drivers/mfd/88pm800.c b/d
buck1-dualphase-en"
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 11 +++
include/linux/mfd/88pm80x.h | 3 +++
2 files changed, 14 insertions(+)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index 8930fd8..a2ef0c7 100644
--- a/drivers/mfd/88pm800.c
+++ b/d
Add chip identification support for 88PM860 device
to the pm80x_chip_mapping table.
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm80x.c | 2 ++
include/linux/mfd/88pm80x.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/mfd/88pm80x.c b/drivers/mfd/88pm80x.c
index
88PM800 family of device supports output of 32KHz clock (low jitter)
on CLK32K2/3 pin which can be supplied to other peripherals on the board.
This patch adds the devicetree binding to enable this feature.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/mfd/88pm800.txt
88PM860 family of device supports dual phase mode on BUCK1 supply
providing total 6A capacity.
Note that by default they operate independently with 3A capacity.
This patch adds the devicetree binding to enable this
feature.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings
not validate the configuration on 88PM800,
restricting myself only to 88PM860.
If anyone can validate on 88PM800, we can move common code accordingly.
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 64 +
include/linux/mfd/88pm80x.h | 13
configuration also includes pinmux setting for the device.
I am working on using pinctrl-single driver to have standard and generic
interface, hopefully it will get handled through pinctrl subsystem.
Link to RFC - https://patches.linaro.org/50604/
Vaibhav Hiremath (6):
mfd: 88pm80x: Add
Along with DT support, this patch also cleans up the unnecessary
code around 'rtc_wakeup' initialization.
Signed-off-by: Chao Xie
Signed-off-by: Vaibhav Hiremath
---
drivers/rtc/rtc-88pm80x.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git
Along with DT support, this patch also cleans up the unnecessary
code around 'rtc_wakeup' initialization.
Signed-off-by: Chao Xie chao@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/rtc/rtc-88pm80x.c | 28 +---
1 file changed, 17
configuration also includes pinmux setting for the device.
I am working on using pinctrl-single driver to have standard and generic
interface, hopefully it will get handled through pinctrl subsystem.
Link to RFC - https://patches.linaro.org/50604/
Vaibhav Hiremath (6):
mfd: 88pm80x: Add
On Thursday 09 July 2015 05:25 PM, Alexandre Belloni wrote:
Hi,
On 09/07/2015 at 12:25:51 +0530, Vaibhav Hiremath wrote :
Along with DT support, this patch also cleans up the unnecessary
code around 'rtc_wakeup' initialization.
Signed-off-by: Chao Xie chao@marvell.com
Signed-off
88PM860 family of device supports dual phase mode on BUCK1 supply
providing total 6A capacity.
Note that by default they operate independently with 3A capacity.
This patch adds the devicetree binding to enable this
feature.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
not validate the configuration on 88PM800,
restricting myself only to 88PM860.
If anyone can validate on 88PM800, we can move common code accordingly.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 64
Add chip identification support for 88PM860 device
to the pm80x_chip_mapping table.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm80x.c | 2 ++
include/linux/mfd/88pm80x.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/mfd/88pm80x.c b
88PM800 family of device supports output of 32KHz clock (low jitter)
on CLK32K2/3 pin which can be supplied to other peripherals on the board.
This patch adds the devicetree binding to enable this feature.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation/devicetree
-en
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 11 +++
include/linux/mfd/88pm80x.h | 3 +++
2 files changed, 14 insertions(+)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index 8930fd8..a2ef0c7 100644
--- a/drivers/mfd
this configuration is controlled through DT property, it is
safe to put it as common code.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 13 +
include/linux/mfd/88pm80x.h | 1 +
2 files changed, 14 insertions(+)
diff --git a/drivers/mfd
also renames to more generic name.
TODO:
- Validation on 88PM800 device, looking for some help here, as I do
not have any platform with 88PM800 device.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Signed-off-by: Hongyan Song hys...@marvell.com
---
drivers/regulator/88pm800.c
This patch adds dev_info line at the end of probe function, to
clearly put status of regulator probe on console. Useful during
development, specially to check bootlog.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/regulator/88pm800.c | 1 +
1 file changed, 1 insertion
detailed description]
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/regulator/88pm800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c
index d22a098..fdebd23 100644
--- a/drivers/regulator
, as I do
not have any platform with 88PM800 device.
Vaibhav Hiremath (2):
regulator: 88pm800: Add 88pm860 regulator support
regulator: 88pm800: Add dev_info to show probe success status
Yi Zhang (1):
regulator: 88pm800: fix LDO vsel_mask value
drivers/regulator/88pm800.c | 197
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote:
2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org:
88PM860 falls under 88pm800 family of devices, with some feature
additions, for example, support for dual phase on BUCK1.
Hi,
There are already drivers
On Thursday 09 July 2015 06:14 PM, Vaibhav Hiremath wrote:
On Thursday 09 July 2015 05:34 PM, Krzysztof Kozlowski wrote:
2015-07-09 20:47 GMT+09:00 Vaibhav Hiremath
vaibhav.hirem...@linaro.org:
88PM860 falls under 88pm800 family of devices, with some feature
additions, for example, support
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
Reviewed-by: Krzysztof Kozlowski
Acked-by: Rob Herring
Acked-by: Lee Jones
---
Documentation/devicetree/bindings/mfd/88pm800.txt
uot;
Also, as suggested by "Lee Jones" renaming variable field
to appropriate name and removed unnecessary field
pm80x_chip.irq_mode, using platform_data.irq_clr_method.
Signed-off-by: Zhao Ye
Signed-off-by: Vaibhav Hiremath
Reviewed-by: Krzysztof Kozlowski
---
drivers/mfd/
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie
Signed-off-by: Vaibhav Hiremath
Reviewed-by: Krzysztof Kozlowski
Acked-by: Lee Jones
---
drivers/mfd/88pm800.c | 26 ++
1 file
With addition of proper checks in place in pm800_probe function,
which makes sure that pdata would never become NULL.
So remove all unnecessary protection around pdata in whole
driver code.
Signed-off-by: Vaibhav Hiremath
Reviewed-by: Krzysztof Kozlowski
Acked-by: Lee Jones
---
drivers/mfd
During probe, inside fn device_800_init(), submodule init is
happening and the same error message is getting printed in both
the places, _init() and inside device_800_init().
So this patch gets rid of dev_err from _init() fns.
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 32
Currently the device_xxx_init() fns take pdata as an input parameter to
the fn, but the cleaner approach would be to use dev_get_platdata() to
get the pdata.
So this patch changes the code accordingly.
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 29
301 - 400 of 612 matches
Mail list logo