On Tuesday 07 July 2015 08:27 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 06:24 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:42 PM
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Rob Herring r...@kernel.org
Acked
, as suggested by Lee Jones renaming variable field
to appropriate name and removed unnecessary field
pm80x_chip.irq_mode, using platform_data.irq_clr_method.
Signed-off-by: Zhao Ye zh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Reviewed-by: Krzysztof Kozlowski k.kozlow
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie chao@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Acked-by: Lee Jones
With addition of proper checks in place in pm800_probe function,
which makes sure that pdata would never become NULL.
So remove all unnecessary protection around pdata in whole
driver code.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Reviewed-by: Krzysztof Kozlowski k.kozlow
During probe, inside fn device_800_init(), submodule init is
happening and the same error message is getting printed in both
the places, subdev_init() and inside device_800_init().
So this patch gets rid of dev_err from subdev_init() fns.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem
Currently the device_xxx_init() fns take pdata as an input parameter to
the fn, but the cleaner approach would be to use dev_get_platdata() to
get the pdata.
So this patch changes the code accordingly.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 29
On Tuesday 07 July 2015 08:27 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 06:24 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:42 PM
On Tuesday 07 July 2015 06:24 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:10 PM
On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 12:59 PM, Lee
On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote
On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing
On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing interrupt
status of 88pm800 family of devices;
0: clear on read
1: clear on write
If pdata
On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote:
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
Hi,
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
-pdata
On Thursday 25 June 2015 01:16 PM, Vaibhav Hiremath wrote:
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
Hi,
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
-pdata
On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing
On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing interrupt
status of 88pm800 family of devices;
0: clear on read
1: clear on write
If pdata
On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 12:59 PM, Lee Jones wrote:
On Mon, 29 Jun 2015, Vaibhav Hiremath wrote
On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:10 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 12:59 PM, Lee
On Tuesday 07 July 2015 06:24 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:48 PM, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:42 PM, Lee Jones wrote:
On Tue, 07 Jul 2015, Vaibhav Hiremath wrote:
On Tuesday 07 July 2015 04:10 PM
From: Yipeng Yao
Fix below warning message, coming from 64 bit toolchain.
drivers/i2c/busses/i2c-pxa.c:1237:15: warning: cast from pointer to integer of
different size [-Wpointer-to-int-cast]
Signed-off-by: Yipeng Yao
[vaibhav.hirem...@linaro.org: Updated Changelog]
Signed-off-by: Vaibhav
of the I2C module after xfer in master mode
of operation.
i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer
Signed-off-by: Yi Zhang
Signed-off-by: Vaibhav Hiremath
---
drivers/i2c/busses/i2c-pxa.c | 43 +--
1 file changed, 41
hold/setup wait counter for
standard and fast mode.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 +
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt
b/Documentation/devicetree/bindings
Normally i2c controller works as master, so slave addr is not needed, or it
will impact some slave device (eg. ST NFC chip) i2c accesses, because it has
the same i2c address with controller.
Signed-off-by: Jett.Zhou
Signed-off-by: Vaibhav Hiremath
Acked-by: Robert Jarzmik
---
drivers/i2c
Driver now supports enable/disable across msg xfer, which user
can control it by new DT property -
i2c-disable-after-xfer : If set, driver will disable I2C module after msg
xfer and enable it back before xfer.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/i2c/i2c
ndard
DT properties for ilcr and iwcr configuration fields.
In case of Master ilcr is used for low/high time and in case of slave mode
of operation iwcr is used for setup/hold time.
Signed-off-by: Jett.Zhou
Signed-off-by: Yi Zhang
Signed-off-by: Vaibhav Hiremath
---
drive
-by: Vaibhav Hiremath
Signed-off-by: Jett.Zhou
Signed-off-by: Yi Zhang
---
drivers/i2c/busses/i2c-pxa.c | 68 +++-
1 file changed, 61 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index d5cf6f5..537555a
From: Shouming Wang
In case of timeout in pio mode of operation return I2C_RETRY.
This behavior will be same as interrupt mode of operation.
Signed-off-by: Shouming Wang
[vaibhav.hirem...@linaro.org: Updated changelog]
Signed-off-by: Vaibhav Hiremath
Acked-by: Robert Jarzmik
---
drivers/i2c
Update i2c_pxa_scream_blue_murder() fn to print more information
in case of error.
Also, use dev_err variants instead of printk.
Signed-off-by: Jett.Zhou
Signed-off-by: Vaibhav Hiremath
Cc: Wolfram Sang
---
drivers/i2c/busses/i2c-pxa.c | 22 +++---
1 file changed, 15
instead of printk for KERN_INFO
Signed-off-by: Vaibhav Hiremath
Acked-by: Robert Jarzmik
---
drivers/i2c/busses/i2c-pxa.c | 82 ++--
1 file changed, 34 insertions(+), 48 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
[vaibhav.hirem...@linaro.org: updated Changelog]
Signed-off-by: Vaibhav Hiremath
Cc: Wolfram Sang
---
drivers/i2c/busses/i2c-pxa.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index d9c0d6a..f4ac8c5 100644
l submit shortly.
08/12: NAKed and dropped
- Separated DT binding patch from driver changes, for easy merge
Leilei Shang (1):
i2c: pxa: keep i2c irq ON in suspend
Shouming Wang (1):
i2c: pxa: Return I2C_RETRY when timeout in pio mode
Vaibhav Hiremath (7):
i2c: pxa: No need to set slave
On Monday 06 July 2015 12:05 PM, Tony Lindgren wrote:
* Vaibhav Hiremath [150702 09:58]:
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
-static unsigned __maybe_unused pcs_readb(void __iomem *reg)
+static unsigned pcs_read(struct regmap *map, unsigned int reg
On Monday 06 July 2015 12:05 PM, Tony Lindgren wrote:
* Vaibhav Hiremath vaibhav.hirem...@linaro.org [150702 09:58]:
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
-static unsigned __maybe_unused pcs_readb(void __iomem *reg)
+static unsigned pcs_read(struct
to control disable of the I2C module after xfer in master mode
of operation.
i2c-disable-after-xfer : If set, driver will disable I2C module after msg xfer
Signed-off-by: Yi Zhang yizh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/i2c/busses/i2c-pxa.c | 43
hold/setup wait counter for
standard and fast mode.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation/devicetree/bindings/i2c/i2c-pxa.txt | 13 +
1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-pxa.txt
b
configuration fields.
In case of Master ilcr is used for low/high time and in case of slave mode
of operation iwcr is used for setup/hold time.
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Yi Zhang yizh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Driver now supports enable/disable across msg xfer, which user
can control it by new DT property -
i2c-disable-after-xfer : If set, driver will disable I2C module after msg
xfer and enable it back before xfer.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation
Normally i2c controller works as master, so slave addr is not needed, or it
will impact some slave device (eg. ST NFC chip) i2c accesses, because it has
the same i2c address with controller.
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
From: Shouming Wang wang...@marvell.com
In case of timeout in pio mode of operation return I2C_RETRY.
This behavior will be same as interrupt mode of operation.
Signed-off-by: Shouming Wang wang...@marvell.com
[vaibhav.hirem...@linaro.org: Updated changelog]
Signed-off-by: Vaibhav Hiremath
Update i2c_pxa_scream_blue_murder() fn to print more information
in case of error.
Also, use dev_err variants instead of printk.
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c
-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Signed-off-by: Jett.Zhou jtz...@marvell.com
Signed-off-by: Yi Zhang yizh...@marvell.com
---
drivers/i2c/busses/i2c-pxa.c | 68 +++-
1 file changed, 61 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c
instead of printk for KERN_INFO
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Acked-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/i2c/busses/i2c-pxa.c | 82 ++--
1 file changed, 34 insertions(+), 48 deletions(-)
diff --git a/drivers/i2c
binding patch from driver changes, for easy merge
Leilei Shang (1):
i2c: pxa: keep i2c irq ON in suspend
Shouming Wang (1):
i2c: pxa: Return I2C_RETRY when timeout in pio mode
Vaibhav Hiremath (7):
i2c: pxa: No need to set slave addr for i2c master mode reset
i2c: pxa: Update debug
...@marvell.com
Signed-off-by: Xiaofan Tian tia...@marvell.com
[vaibhav.hirem...@linaro.org: updated Changelog]
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
---
drivers/i2c/busses/i2c-pxa.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Changelog]
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
Acked-by: Robert Jarzmik robert.jarz...@free.fr
---
drivers/i2c/busses/i2c-pxa.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c
, accepted, nacked, acked, suggestions...
Signed-off-by: Vaibhav Hiremath
---
arch/arm64/boot/dts/marvell/pxa1928-helium.dts | 15 +++
drivers/mfd/88pm800.c | 41 +++
drivers/pinctrl/pinctrl-single.c | 159 +
3 files changed, 140
, accepted, nacked, acked, suggestions...
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
arch/arm64/boot/dts/marvell/pxa1928-helium.dts | 15 +++
drivers/mfd/88pm800.c | 41 +++
drivers/pinctrl/pinctrl-single.c | 159
On Wednesday 01 July 2015 10:47 PM, Rob Herring wrote:
On Wed, Jul 1, 2015 at 11:21 AM, Vaibhav Hiremath
wrote:
On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote:
On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath
wrote:
With addition of DT support to 88pm800 mfd driver
On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote:
On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath
wrote:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
Didn't I ack
On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote:
On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath
vaibhav.hirem...@linaro.org wrote:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off
On Wednesday 01 July 2015 10:47 PM, Rob Herring wrote:
On Wed, Jul 1, 2015 at 11:21 AM, Vaibhav Hiremath
vaibhav.hirem...@linaro.org wrote:
On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote:
On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath
vaibhav.hirem...@linaro.org wrote
On Tuesday 30 June 2015 01:16 PM, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote:
* Vaibhav Hiremath [150624 10:12]:
I do not like this, as this is not HW feature, so DT may not be right
On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote:
* Vaibhav Hiremath [150624 10:12]:
I do not like this, as this is not HW feature, so DT may not be right
approach.
So I will dig more from either runtime or Compile time
On Tuesday 30 June 2015 01:16 PM, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote:
* Vaibhav Hiremath vaibhav.hirem...@linaro.org [150624 10:12]:
I do not like this, as this is not HW feature, so
On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote:
* Vaibhav Hiremath vaibhav.hirem...@linaro.org [150624 10:12]:
I do not like this, as this is not HW feature, so DT may not be right
approach.
So I will dig more from either
On Tuesday 30 June 2015 06:01 AM, Krzysztof Kozlowski wrote:
2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath :
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
(once again, too
uot;
Also, as suggested by "Lee Jones" renaming variable field
to appropriate name.
Signed-off-by: Zhao Ye
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 15 ++-
include/linux/mfd/88pm80x.h | 10 --
2 files changed, 18 insertions(+), 7 deletions(-)
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/mfd/88pm800.c
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++
1 file changed, 53 insertions(+)
create mode
- Rgulator driver changes to add support for 88PM860 device
Vaibhav Hiremath (4):
mfd: 88pm800: Add device tree support
mfd: 88pm800: Remove unnecessary protection around pdata
mfd: 88pm800: Set default interrupt clear method
mfd: devicetree: bindings: Add new 88pm800 mfd binding
Documentatio
With addition of proper checks in place in pm800_probe function,
which makes sure that pdata would never become NULL.
So remove all unnecessary protection around pdata in whole
driver code.
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 14 ++
1 file changed, 6
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++
1 file changed, 53
, as suggested by Lee Jones renaming variable field
to appropriate name.
Signed-off-by: Zhao Ye zh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 15 ++-
include/linux/mfd/88pm80x.h | 10 --
2 files changed, 18 insertions
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie chao@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 23 +++
1 file changed, 23
With addition of proper checks in place in pm800_probe function,
which makes sure that pdata would never become NULL.
So remove all unnecessary protection around pdata in whole
driver code.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 14
Vaibhav Hiremath (4):
mfd: 88pm800: Add device tree support
mfd: 88pm800: Remove unnecessary protection around pdata
mfd: 88pm800: Set default interrupt clear method
mfd: devicetree: bindings: Add new 88pm800 mfd binding
Documentation/devicetree/bindings/mfd/88pm800.txt | 53
On Tuesday 30 June 2015 06:01 AM, Krzysztof Kozlowski wrote:
2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav
On Saturday 27 June 2015 11:06 AM, Krzysztof Kozlowski wrote:
2015-06-26 22:08 GMT+09:00 Vaibhav Hiremath :
Instead of hard coding the shift for bit definition, use
BIT() macro.
I am not convinced that such change improves anything in existing
code. IMHO (1 << n) is quite re
On Saturday 27 June 2015 11:06 AM, Krzysztof Kozlowski wrote:
2015-06-26 22:08 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org:
Instead of hard coding the shift for bit definition, use
BIT() macro.
I am not convinced that such change improves anything in existing
code. IMHO (1 n
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing interrupt
status of 88pm800 family of devices;
0: clear on read
1: clear on write
If pdata
Instead of hard coding the shift for bit definition, use
BIT() macro.
Signed-off-by: Vaibhav Hiremath
---
Boot tested on PXA1928 based platform.
Note that all upcoming patches will be on top of this patch now.
include/linux/mfd/88pm80x.h | 162 ++--
1
On Friday 26 June 2015 11:35 AM, Yi Zhang wrote:
On Thu, Jun 25, 2015 at 03:26:29PM +0800, Vaibhav Hiremath wrote:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
On Friday 26 June 2015 11:23 AM, Yi Zhang wrote:
On Thu, Jun 25, 2015 at 08:57:49PM +0530, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 08:18 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 03:49 PM, Lee Jones wrote:
On Thu, 25 Jun 2015
On Friday 26 June 2015 11:35 AM, Yi Zhang wrote:
On Thu, Jun 25, 2015 at 03:26:29PM +0800, Vaibhav Hiremath wrote:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem
On Friday 26 June 2015 11:23 AM, Yi Zhang wrote:
On Thu, Jun 25, 2015 at 08:57:49PM +0530, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 08:18 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 03:49 PM, Lee Jones wrote:
On Thu, 25 Jun 2015
Instead of hard coding the shift for bit definition, use
BIT() macro.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Boot tested on PXA1928 based platform.
Note that all upcoming patches will be on top of this patch now.
include/linux/mfd/88pm80x.h | 162
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing interrupt
status of 88pm800 family of devices;
0: clear on read
1: clear on write
If pdata
On Thursday 25 June 2015 08:16 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing
On Thursday 25 June 2015 08:18 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 03:49 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc
On Thursday 25 June 2015 05:15 PM, Krzysztof Kozlowski wrote:
2015-06-25 20:19 GMT+09:00 Vaibhav Hiremath :
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
(...)
diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
index 97cb283..94b3dcd 100644
--- a/include/linux
On Thursday 25 June 2015 03:58 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing interrupt
status of 88pm800 family of devices;
0: clear on read
1: clear on write
If pdata
On Thursday 25 June 2015 03:49 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
Hi,
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
- pdata = dev_get_platdata(>dev);
- if (pdata == N
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++
1 file changed, 54 insertions(+)
create mode
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/drivers/mfd/88pm800.c
uot;
Also, as suggested by "Lee Jones" renaming variable field
to appropriate name.
Signed-off-by: Zhao Ye
Signed-off-by: Vaibhav Hiremath
---
drivers/mfd/88pm800.c | 15 ++-
include/linux/mfd/88pm80x.h | 6 --
2 files changed, 14 insertions(+), 7 deletions(-)
diff
f the patches to the list sometime
back in 2013.
Link to previous patch submission:
https://lkml.org/lkml/2013/8/14/86
TODO:
=
- init config for 88PM860 device
- Rgulator driver changes to add support for 88PM860 device
Vaibhav Hiremath (3):
mfd: 88pm800: Add device tree suppor
, as suggested by Lee Jones renaming variable field
to appropriate name.
Signed-off-by: Zhao Ye zh...@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 15 ++-
include/linux/mfd/88pm80x.h | 6 --
2 files changed, 14 insertions(+), 7
to previous patch submission:
https://lkml.org/lkml/2013/8/14/86
TODO:
=
- init config for 88PM860 device
- Rgulator driver changes to add support for 88PM860 device
Vaibhav Hiremath (3):
mfd: 88pm800: Add device tree support
mfd: 88pm800: Set default interrupt clear method
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie chao@marvell.com
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
drivers/mfd/88pm800.c | 23 +++
1 file changed, 23
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
---
Documentation/devicetree/bindings/mfd/88pm800.txt | 54 +++
1 file changed, 54
On Saturday 20 June 2015 06:13 AM, Alexandre Belloni wrote:
Hi,
Sorry I missed this email.
Just wanted to send reminder email and saw this :)
On 18/06/2015 at 00:28:06 +0530, Vaibhav Hiremath wrote :
- pdata = dev_get_platdata(pdev-dev);
- if (pdata == NULL
On Thursday 25 June 2015 03:49 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc, onkey and regulator)
Signed-off-by: Chao Xie chao@marvell.com
Signed-off-by: Vaibhav Hiremath
On Thursday 25 June 2015 03:58 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
With addition of DT support to 88pm800 mfd driver, this patch
adds new DT binding documentation along with respective properties.
Signed-off-by: Vaibhav Hiremath vaibhav.hirem...@linaro.org
On Thursday 25 June 2015 05:15 PM, Krzysztof Kozlowski wrote:
2015-06-25 20:19 GMT+09:00 Vaibhav Hiremath vaibhav.hirem...@linaro.org:
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
(...)
diff --git a/include/linux/mfd/88pm80x.h b/include/linux/mfd/88pm80x.h
index 97cb283..94b3dcd
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing interrupt
status of 88pm800 family of devices;
0: clear on read
1: clear on write
If pdata
On Thursday 25 June 2015 08:16 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 03:56 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe
(page 0) controls the method of clearing
On Thursday 25 June 2015 08:18 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
On Thursday 25 June 2015 03:49 PM, Lee Jones wrote:
On Thu, 25 Jun 2015, Vaibhav Hiremath wrote:
Add DT support to the 88pm800 driver, along with compatible
field for it's sub-devices (rtc
401 - 500 of 612 matches
Mail list logo
