RE: [PATCH 2/3] arm: introduce IRQ stacks

2020-10-21 Thread Vaneet Narang
velopers for further development,instead of increasing stack size to 16KB or spending time on debugging stack overflow issues. PS: We have debugged and resolved stack overflow issue but we still implemented this sol. to avoid debugging such issues in future also it gives us flexibility for kernel enhancement on ARM. Thanks & Regards, Vaneet Narang

RE: [PATCH 1/1] arm64: add support for PAGE_SIZE aligned kernel stack

2020-08-03 Thread Vaneet Narang
oints we realised 12KB stack might be sufficient for our system. Analyzing stack using stack tracer confirmed max stack requirement. This is still configurable, if some system has higher stack requirement then user can go with 16KB but there should be option to change it. Regards, Vaneet Narang

RE:(2) [PATCH 3/4] scripts/checkstack.pl: add arm push handling for stack usage

2020-05-07 Thread Vaneet Narang
0d4c: e24cb004sub fp, ip, #4 c01f0d50: e24dd094sub sp, sp, #448; 0x1C0 Thanks & Regards, Vaneet Narang     

RE:(2) [PATCH 1/1] mm/vmscan.c: change prototype for shrink_page_list

2020-04-29 Thread Vaneet Narang
but we did this as we normally follow this coding convention when defining structures or stack variables. Thanks & Regards, Vaneet Narang      

RE: [PATCH 1/2] zstd: pass pointer rathen than structure to functions

2019-05-30 Thread Vaneet Narang
ntinue_internal)-> 136  -> 88 > (ZSTD_compressCCtx) -> 192  -> 64 > (zstd_compress) -> 144      -> 96 Regards, Vaneet Narang

Re: [PATCH 2/2] printk: make sure to print log on console.

2018-06-01 Thread Vaneet Narang
sole log level handling. Which can be done using dmesg as well. For example: dmesg -n 7 "Run some scenario to capture all the kernel logs" dmesg -n 1 I may end up not getting all the logs if my console flush is slow & dmesg -n 1 got excuted before flush . Thanks & Regards, Vaneet Narang

RE: Re: [PATCH 1/1] lz4: Implement lz4 with dynamic offset length.

2018-04-03 Thread Vaneet Narang
#define M2_MAX_LEN 8 #define M3_MIN_LEN 3 #define M3_MAX_LEN 33 #define M4_MIN_LEN 3 #define M4_MAX_LEN 9 #define M1_MARKER 0 #define M2_MARKER 64 #define M3_MARKER 32 #define M4_MARKER 16 Similarly for LZ4 Dyn, we have used 1 bit as a marker to determine offset length. Thanks & Regards, Vaneet Narang rcptInfo.txt Description: Binary data

RE: [PATCH v2] arm/stacktrace: stop unwinding after an invalid address.

2018-04-03 Thread Vaneet Narang
if (!__kernel_text_address(regs->ARM_pc)) >+ return 1; >+ > trace->entries[trace->nr_entries++] = regs->ARM_pc;   Any Inputs or Comments on this patch to avoid storing user space entries during unwind.   Regards, Vaneet Narang rcptInfo.txt Description: Binary data

RE: Re: [PATCH v2] mm/page_owner: ignore everything below the IRQ entry point

2018-03-26 Thread Vaneet Narang
u think empty definition of in_irqentry_text() is not requited then we will modify & resend the patch. Thanks & Regards, Vaneet Narang

Re: [PATCH 0/1] cover-letter/lz4: Implement lz4 with dynamic offset length.

2018-03-23 Thread Vaneet Narang
a32k lzbench 1.7.3 (32-bit Linux) Assembled by P.Skibinski Compressor name Compress. Decompress. Compr. size Ratio Filename memcpy 5273 MB/s 5320 MB/s 32768 100.00 data/data32k lzo1x 2.09 -1 283 MB/s 465 MB/s 14292 43.62 data/data32k Regards, Va

Re: [PATCH 1/1] lz4: Implement lz4 with dynamic offset length.

2018-03-23 Thread Vaneet Narang
n to both >LZ4 and LZ4_DYN decompression speed. Since there is no backward compatibility of our solution with original LZ4 so we are bit confused if we should make it as separate API to avoid overhead of dynOffset checks every where in the code and also to avoid changing prototype of exported functions LZ4_decompress/LZ4_compress OR we should keep these checks to avoid redundant code. Kindly suggest Thanks & Regards, Vaneet Narang

RE: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Vaneet Narang
nk its useful, we can share scalable patch to configure below two values based on number of stack entries dynamically. #define STACK_ALLOC_ORDER 2 #define STACK_HASH_SIZE (1L << STACK_HASH_ORDER) Regards, Vaneet Narang

RE: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Vaneet Narang
0 __do_softirq+0xce/0x298 irq_exit+0xa3/0xb0 We have been getting similar kind of such entries and eventually stackdepot reaches Max Cap. So we found this interface useful in debugging stackdepot issue so shared in community. Regards, Vaneet Narang

RE: Re: [PATCH 1/1] mpi: check for shift exponent greater than 31.

2017-11-09 Thread Vaneet Narang
thout breaking mpi_powm(). >Further, have you checked the caller to see if they do ever violate the >constraints? From caller side, only issue which i can think is passing 0 in as last valid limb of mod. Is this any constraint ? Regards, Vaneet Narang

RE: [PATCH v2] stackdepot: ignore junk last entry in case of switch from user mode.

2017-10-12 Thread Vaneet Narang
depot_index gets a stable value after some time. (Tested on ARM) >+ trace->nr_entries--; >+ > hash = hash_stack(trace->entries, trace->nr_entries); > bucket = &stack_table[hash & STACK_HASH_MASK]; > >-- >1.9.1 Regards, Vaneet Narang

Re: [PATCH v2] module: check if memory leak by module.

2017-03-29 Thread Vaneet Narang
l for kernel modules but our intent is to detect memory allocated directly by kernel modules and not getting freed. Regards, Vaneet Narang

RE: Re: [PATCH 1/1] arm/module: maximum utilization of module area.

2016-12-12 Thread Vaneet Narang
l 22MB modules are not penalised but without these changes once size of modules gets over 14MB PLT becomes must.  Regards, Vaneet Narang

Re: Re: [PATCH 1/1] kasan: Support for r/w instrumentation control

2016-12-12 Thread Vaneet Narang
by doing some direct memory access then both read >> / write sanity of uImage >> can be avoided. > >But then you don't need KASAN at all. KASAN support is required in this case to detect module issues. KASAN provides asan_load / asan_store definition as these functions ar

RE: Re: [PATCH 1/1] kasan: Support for r/w instrumentation control

2016-12-12 Thread Vaneet Narang
times useful when uImage is already sanitized and some corruption is done by kernel modules by doing some direct memory access then both read / write sanity of uImage can be avoided. > disabling reads, right? > Disabling both certainly does not make sense. Regards, Vaneet Narang

Re: [PATCH 1/1] arm/module: maximum utilization of module area.

2016-12-12 Thread Vaneet Narang
dules for making short calls. So CONFIG_ARM_MODULE_PLTS is not required when modules can be accomdated within 20MB. >way, there is no need to update these defaults for everyone. > >> +#else >> +#define MODULES_START MODULES_VADDR Thanks & Regards, Vaneet Narang

Re: [PATCH] af_packet: Raw socket destruction warning fix

2016-02-10 Thread Vaneet Narang
as size of last packet received on socket. Kindly comment on the fix shared at following link. http://www.spinics.net/lists/kernel/msg2184815.html Thanks & Regards, Vaneet Narang

Re: [PATCH] af_packet: Raw socket destruction warning fix

2016-02-04 Thread Vaneet Narang
re this is avoided or is there any way this gets added to error queue. As per my understanding rmem_alloc gets increased only if packets gets added to receive queue or error queue. Is it any other queue which also changes rmem_alloc? Thanks, Vaneet Narang .

Re: [EDT] [PATCH 1/1] Fix: hw watchpoint continually triggers callback

2015-05-18 Thread Vaneet Narang
EP-2DAD0AFA905A4ACB804C4F82A001242F > >Ok, I have to ask: what on Earth is this number and what does [EDT] mean? This is auto generated from our editor. Kindly ignore its not relevant. Please find reply inline. >> >On Tue, May 12, 2015 at 02:12:54PM +0100, Vaneet Narang wrot

Re: [EDT][PATCH 1/1] hw_breakpoint.c :cpu hotplug handling

2015-05-17 Thread Vaneet Narang
ar these slots or we should reinstall but if you think reinstall has to be taken care by scheduler or debugger then at least we should clear these slots. Regards, Vaneet Narang

Re: [EDT] [PATCH 1/1] Fix: hw watchpoint continually triggers callback

2015-05-12 Thread Vaneet Narang
EP-2DAD0AFA905A4ACB804C4F82A001242F >On Tue, May 12, 2015 at 02:12:54PM +0100, Vaneet Narang wrote: >> On Tue, May 12, 2015 at 12:48:13PM +0100, Maninder Singh wrote: >> >> On ARM, when a watchpoint is registered using >> >> register_wide_hw_breakpoint, >>

Fwd: Re: Re: [EDT] [PATCH 1/1] Fix: hw watchpoint continually triggers callback

2015-05-12 Thread Vaneet Narang
s issue by using KPROBES (getting the instruction >> executed and incrementing PC >> to next instruction). >> >> Signed-off-by: Vaneet Narang >> Signed-off-by: Maninder Singh >> Reviewed-by: Amit Arora >> Reviewed-by: Ajeet Yadav >> --- >> arc