Re: [PATCH] drivers: infiniband: core: Remove extra parentheses

Hi Jason, On Wed, Jul 25, 2018 at 10:37 PM, Jason Gunthorpe wrote: > On Wed, Jul 25, 2018 at 08:43:56PM +0200, Varsha Rao wrote: > > Remove unnecessary parentheses to fix the clang warning of extraneous > > parentheses. > > > > Signed-off-by: Varsha Rao > >

Re: [PATCH] drivers: infiniband: core: Remove extra parentheses

Hi Jason, On Wed, Jul 25, 2018 at 10:37 PM, Jason Gunthorpe wrote: > On Wed, Jul 25, 2018 at 08:43:56PM +0200, Varsha Rao wrote: > > Remove unnecessary parentheses to fix the clang warning of extraneous > > parentheses. > > > > Signed-off-by: Varsha Rao > >

[PATCH] net: wireless: cw1200: Remove extra parentheses

Remove unnecessary parentheses to fix the extraneous parentheses clang warning. Signed-off-by: Varsha Rao --- drivers/net/wireless/st/cw1200/txrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/txrx.c b/drivers/net/wireless/st/cw1200

[PATCH] net: wireless: cw1200: Remove extra parentheses

Remove unnecessary parentheses to fix the extraneous parentheses clang warning. Signed-off-by: Varsha Rao --- drivers/net/wireless/st/cw1200/txrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/st/cw1200/txrx.c b/drivers/net/wireless/st/cw1200

[PATCH] net: wireless: brcmsmac: Remove extra parentheses

Remove the unnecessary parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211

[PATCH] net: wireless: brcmsmac: Remove extra parentheses

Remove the unnecessary parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211

[PATCH] net: wireless: ath9k: Remove unnecessary parentheses

Remove extra parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/net/wireless/ath/ath9k/debug_sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/debug_sta.c b/drivers/net/wireless/ath/ath9k

[PATCH] net: wireless: ath9k: Remove unnecessary parentheses

Remove extra parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/net/wireless/ath/ath9k/debug_sta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/debug_sta.c b/drivers/net/wireless/ath/ath9k

[PATCH] net: wireless: ath6kl: Remove unnecessary parentheses

Remove extra parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/net/wireless/ath/ath6kl/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c

[PATCH] net: wireless: ath6kl: Remove unnecessary parentheses

Remove extra parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/net/wireless/ath/ath6kl/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath6kl/main.c b/drivers/net/wireless/ath/ath6kl/main.c

[PATCH] drivers: infiniband: core: Remove extra parentheses

Remove unnecessary parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/infiniband/core/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index bff10ab141b0

[PATCH] drivers: infiniband: core: Remove extra parentheses

Remove unnecessary parentheses to fix the clang warning of extraneous parentheses. Signed-off-by: Varsha Rao --- drivers/infiniband/core/cma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index bff10ab141b0

[tip:x86/urgent] x86/platform/uv: Remove extra parentheses

Commit-ID: cce2946b9b30a9b31a18de737d5010c08076e77f Gitweb: https://git.kernel.org/tip/cce2946b9b30a9b31a18de737d5010c08076e77f Author: Varsha Rao AuthorDate: Sun, 20 May 2018 13:30:12 +0530 Committer: Thomas Gleixner CommitDate: Wed, 6 Jun 2018 13:38:01 +0200 x86/platform/uv: Remove

[tip:x86/urgent] x86/platform/uv: Remove extra parentheses

Commit-ID: cce2946b9b30a9b31a18de737d5010c08076e77f Gitweb: https://git.kernel.org/tip/cce2946b9b30a9b31a18de737d5010c08076e77f Author: Varsha Rao AuthorDate: Sun, 20 May 2018 13:30:12 +0530 Committer: Thomas Gleixner CommitDate: Wed, 6 Jun 2018 13:38:01 +0200 x86/platform/uv: Remove

[PATCH] x86: platform: uv: Remove extra parentheses

Remove extra parentheses to fix the extraneous parentheses clang warning. Suggested-by: Lukas Bulwahn <lukas.bulw...@gmail.com> Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- arch/x86/platform/uv/tlb_uv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/

[PATCH] x86: platform: uv: Remove extra parentheses

Remove extra parentheses to fix the extraneous parentheses clang warning. Suggested-by: Lukas Bulwahn Signed-off-by: Varsha Rao --- arch/x86/platform/uv/tlb_uv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c

[PATCH] ocfs2: dlm: Remove extra parentheses

Remove unnecessary parentheses to fix the clang warning of extraneous parentheses. Suggested-by: Lukas Bulwahn <lukas.bulw...@gmail.com> Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- fs/ocfs2/dlm/dlmthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH] ocfs2: dlm: Remove extra parentheses

Remove unnecessary parentheses to fix the clang warning of extraneous parentheses. Suggested-by: Lukas Bulwahn Signed-off-by: Varsha Rao --- fs/ocfs2/dlm/dlmthread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c index

[RESEND PATCH v2] crypto: cavium: zip: Remove unnecessary parentheses

This patch fixes the clang warning of extraneous parentheses, with the following coccinelle script. @@ identifier i; constant c; expression e; @@ ( !((e)) | -(( \(i == c\|i != c\|i <= c\|i < c\|i >= c\|i > c\) -)) ) Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- Changes

[RESEND PATCH v2] crypto: cavium: zip: Remove unnecessary parentheses

This patch fixes the clang warning of extraneous parentheses, with the following coccinelle script. @@ identifier i; constant c; expression e; @@ ( !((e)) | -(( \(i == c\|i != c\|i <= c\|i < c\|i >= c\|i > c\) -)) ) Signed-off-by: Varsha Rao --- Changes in v2: - Modified cocci

[PATCH v2] crypto: cavium: zip: Remove unnecessary parentheses

This patch fixes the clang warning of extraneous parentheses, with the following coccinelle script. @@ identifier i; constant c; expression e; @@ ( !((e)) | -(( \(i == c\|i != c\|i <= c\|i < c\|i >= c\|i > c\) -)) ) Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- Changes

[PATCH v2] crypto: cavium: zip: Remove unnecessary parentheses

This patch fixes the clang warning of extraneous parentheses, with the following coccinelle script. @@ identifier i; constant c; expression e; @@ ( !((e)) | -(( \(i == c\|i != c\|i <= c\|i < c\|i >= c\|i > c\) -)) ) Signed-off-by: Varsha Rao --- Changes in v2: - Modified cocci

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Sat, Mar 31, 2018 at 11:48 AM, Julia Lawall wrote: > On Thu, 29 Mar 2018, Varsha Rao wrote: > >> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: >> > >> > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: >> > > This patch fixes t

Re: [Cocci] [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Sat, Mar 31, 2018 at 11:48 AM, Julia Lawall wrote: > On Thu, 29 Mar 2018, Varsha Rao wrote: > >> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: >> > >> > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: >> > > This patch fixes t

Re: [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > This patch fixes the clang warning of extraneous parentheses, with the > > following coccinelle script. > > > > @@ > > identifier i; > > constant c

Re: [PATCH] crypto: cavium: zip: Remove unnecessary parentheses

On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote: > > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote: > > This patch fixes the clang warning of extraneous parentheses, with the > > following coccinelle script. > > > > @@ > > identifier i; > > constant c

[PATCH] crypto: cavium: zip: Remove unnecessary parentheses

This patch fixes the clang warning of extraneous parentheses, with the following coccinelle script. @@ identifier i; constant c; @@ ( -((i == c)) +i == c | -((i <= c)) +i <= c ) Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/crypto/cavium/zip/zip

[PATCH] crypto: cavium: zip: Remove unnecessary parentheses

This patch fixes the clang warning of extraneous parentheses, with the following coccinelle script. @@ identifier i; constant c; @@ ( -((i == c)) +i == c | -((i <= c)) +i <= c ) Signed-off-by: Varsha Rao --- drivers/crypto/cavium/zip/zip_regs.h | 42 ++--

[PATCH 2/2] drivers: char: Replace fail_printk with fail_print.

As printk is no longer used here, rename the label fail_printk as fail_print. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 5786281..0fed477

[PATCH 2/2] drivers: char: Replace fail_printk with fail_print.

As printk is no longer used here, rename the label fail_printk as fail_print. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 5786281..0fed477 100644 --- a/drivers/char

[PATCH 1/2] drivers: char: Replace bit operation functions with IDA allocator.

Replace bit operation functions with IDA allocator functions. As IDA allocation is simpler, faster, more space efficient and it generates small integer IDs which can be used as minor device numbers. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 16 ++---

[PATCH 1/2] drivers: char: Replace bit operation functions with IDA allocator.

Replace bit operation functions with IDA allocator functions. As IDA allocation is simpler, faster, more space efficient and it generates small integer IDs which can be used as minor device numbers. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 16 ++-- 1 file changed, 10

[PATCH 0/2] drivers: char: Replace bit operation functions with IDA allocator and fail_printk label.

In this patchset label fail_printk is renamed and use IDA allocation instead of bitmap. Varsha Rao (2): drivers: char: Replace bit operation functions with IDA allocator. drivers: char: Replace fail_printk with fail_print. drivers/char/misc.c | 20 1 file changed, 12

[PATCH 0/2] drivers: char: Replace bit operation functions with IDA allocator and fail_printk label.

In this patchset label fail_printk is renamed and use IDA allocation instead of bitmap. Varsha Rao (2): drivers: char: Replace bit operation functions with IDA allocator. drivers: char: Replace fail_printk with fail_print. drivers/char/misc.c | 20 1 file changed, 12

Re: [PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.

ISC_MAJOR, misc->minor)); >> if (i < DYNAMIC_MINORS && i >= 0) >> - clear_bit(i, misc_minors); >> + ida_simple_remove(_minors_ida, i); > > As much as I like the ida interface, I don't see why it is required to > use it here, you

Re: [PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.

ISC_MAJOR, misc->minor)); >> if (i < DYNAMIC_MINORS && i >= 0) >> - clear_bit(i, misc_minors); >> + ida_simple_remove(_minors_ida, i); > > As much as I like the ida interface, I don't see why it is required to > use it here, you

[PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.

Replace bit operation functions with IDA allocator functions. As IDA allocation is simpler. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/

[PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.

Replace bit operation functions with IDA allocator functions. As IDA allocation is simpler. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index c9cd1ea..5786281

[PATCH 4/5] drivers: char: Replace printk with pr_err.

Replace printk with pr_err to fix the checkpatch issue. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 1312e29..c9cd1ea 100644 --- a/drivers/char/

[PATCH 4/5] drivers: char: Replace printk with pr_err.

Replace printk with pr_err to fix the checkpatch issue. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 1312e29..c9cd1ea 100644 --- a/drivers/char/misc.c +++ b/drivers/char

[PATCH 3/5] drivers: char: Add blank line after declaration.

Add a blank line after declaration, to fix the checkpatch issue. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 3a19fa3..1312e29 100644 --- a/drivers/char/misc.c

[PATCH 3/5] drivers: char: Add blank line after declaration.

Add a blank line after declaration, to fix the checkpatch issue. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 3a19fa3..1312e29 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c

[PATCH 2/5] drivers: char: Add space after ','.

Add space which is required after ',' to follow linux coding style. This patch fixes the checkpatch issue. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/

[PATCH 2/5] drivers: char: Add space after ','.

Add space which is required after ',' to follow linux coding style. This patch fixes the checkpatch issue. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index ed8f79c..3a19fa3

[PATCH 1/5] drivers: char: Replace "foo * bar" with "foo *bar".

Remove space after * in pointer type, to follow linux coding style. This patch fixes the following checkpatch issue: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertion

[PATCH 1/5] drivers: char: Replace "foo * bar" with "foo *bar".

Remove space after * in pointer type, to follow linux coding style. This patch fixes the following checkpatch issue: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Varsha Rao --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 0/5] drivers: char: Fix checkpatch issues.

This patchset fixes checkpatch issues and use IDA allocation instead of bitmap. Varsha Rao (5): drivers: char: Replace "foo * bar" with "foo *bar". drivers: char: Add space after ','. drivers: char: Add blank line after declarations. drivers: char: Replace printk wi

[PATCH 0/5] drivers: char: Fix checkpatch issues.

This patchset fixes checkpatch issues and use IDA allocation instead of bitmap. Varsha Rao (5): drivers: char: Replace "foo * bar" with "foo *bar". drivers: char: Add space after ','. drivers: char: Add blank line after declarations. drivers: char: Replace printk wi

[PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.

Replace bit operation functions with IDA allocator functions. As IDA allocation is simpler. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/

[PATCH 5/5] drivers: char: Replace bit operation functions with IDA allocator.

Replace bit operation functions with IDA allocator functions. As IDA allocation is simpler. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index c9cd1ea..5786281

[PATCH 4/5] drivers: char: Replace printk with pr_err.

Replace printk with pr_err to fix the checkpatch issue. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 1312e29..c9cd1ea 100644 --- a/drivers/char/

[PATCH 4/5] drivers: char: Replace printk with pr_err.

Replace printk with pr_err to fix the checkpatch issue. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 1312e29..c9cd1ea 100644 --- a/drivers/char/misc.c +++ b/drivers/char

[PATCH 3/5] drivers: char: Add blank line after declarations.

Add a blank line after declarations, to fix the checkpatch issue. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 3a19fa3..1312e29 100644 --- a/drivers/char/misc.c

[PATCH 3/5] drivers: char: Add blank line after declarations.

Add a blank line after declarations, to fix the checkpatch issue. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 3a19fa3..1312e29 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c

[PATCH 2/5] drivers: char: Add space after ','.

Add space which is required after ',' to follow Linux coding style. This patch fixes the checkpatch issue. Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/

[PATCH 2/5] drivers: char: Add space after ','.

Add space which is required after ',' to follow Linux coding style. This patch fixes the checkpatch issue. Signed-off-by: Varsha Rao --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index ed8f79c..3a19fa3

[PATCH 0/5] drivers: char: Fix checkpatch issues.

This patchset fixes checkpatch issues and use IDA allocation instead of bitmap. Varsha Rao (5): drivers: char: Replace "foo * bar" with "foo *bar". drivers: char: Add space after ','. drivers: char: Add blank line after declarations. drivers: char: Replace printk wi

[PATCH 0/5] drivers: char: Fix checkpatch issues.

This patchset fixes checkpatch issues and use IDA allocation instead of bitmap. Varsha Rao (5): drivers: char: Replace "foo * bar" with "foo *bar". drivers: char: Add space after ','. drivers: char: Add blank line after declarations. drivers: char: Replace printk wi

[PATCH 1/5] drivers: char: Replace "foo * bar" with "foo *bar".

Remove space after * in pointer type, to follow Linux coding style. This patch fixes the following checkpatch issue: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Varsha Rao <rvarsha...@gmail.com> --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertion

[PATCH 1/5] drivers: char: Replace "foo * bar" with "foo *bar".

Remove space after * in pointer type, to follow Linux coding style. This patch fixes the following checkpatch issue: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Varsha Rao --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff