Performance problem with bond interface

2014-04-21 Thread Venkat Venkatsubra
We see a performance problem when the slaves of the bond don't support checksum offload features. What we see is tcp_sendmsg's skb_add_data_nocache ending up not using the csum_and_copy_from_user which would have computed the checksum while copying from user buffer to kernel buffer. Instead it

Performance problem with bond interface

2014-04-21 Thread Venkat Venkatsubra
We see a performance problem when the slaves of the bond don't support checksum offload features. What we see is tcp_sendmsg's skb_add_data_nocache ending up not using the csum_and_copy_from_user which would have computed the checksum while copying from user buffer to kernel buffer. Instead it

RE: [PATCH] rds: prevent dereference of a NULL device

2013-12-19 Thread Venkat Venkatsubra
> > Signed-off-by: Sasha Levin > --- Acked-by: Venkat Venkatsubra Venkat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] rds: prevent dereference of a NULL device

2013-12-19 Thread Venkat Venkatsubra
Signed-off-by: Sasha Levin sasha.le...@oracle.com --- Acked-by: Venkat Venkatsubra venkat.x.venkatsu...@oracle.com Venkat -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-20 Thread Venkat Venkatsubra
> Why are you posting this message a second time? Reposting just the contents of the second message in case it got missed the previous time. Looks like the fix pointed to by the previous link is for a panic on a PPC system with a PAGE_SIZE of 64Kbytes. I think the sequence it was going through

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-20 Thread Venkat Venkatsubra
-Original Message- From: Venkat Venkatsubra Sent: Tuesday, November 19, 2013 5:33 PM To: Honggang LI; Josh Hunt Cc: David Miller; jjo...@suse.com; LKML; net...@vger.kernel.org Subject: RE: [PATCH] rds: Error on offset mismatch if not loopback We now have lot more information than we

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-20 Thread Venkat Venkatsubra
-Original Message- From: Venkat Venkatsubra Sent: Tuesday, November 19, 2013 5:33 PM To: Honggang LI; Josh Hunt Cc: David Miller; jjo...@suse.com; LKML; net...@vger.kernel.org Subject: RE: [PATCH] rds: Error on offset mismatch if not loopback We now have lot more information than we

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-20 Thread Venkat Venkatsubra
Why are you posting this message a second time? Reposting just the contents of the second message in case it got missed the previous time. Looks like the fix pointed to by the previous link is for a panic on a PPC system with a PAGE_SIZE of 64Kbytes. I think the sequence it was going through

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-14 Thread Venkat Venkatsubra
-Original Message- From: Honggang LI [mailto:ho...@redhat.com] Sent: Wednesday, November 13, 2013 6:56 PM To: Josh Hunt; Venkat Venkatsubra Cc: David Miller; jjo...@suse.com; LKML; net...@vger.kernel.org Subject: Re: [PATCH] rds: Error on offset mismatch if not loopback On 11/14/2013

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-14 Thread Venkat Venkatsubra
-Original Message- From: Honggang LI [mailto:ho...@redhat.com] Sent: Wednesday, November 13, 2013 6:56 PM To: Josh Hunt; Venkat Venkatsubra Cc: David Miller; jjo...@suse.com; LKML; net...@vger.kernel.org Subject: Re: [PATCH] rds: Error on offset mismatch if not loopback On 11/14/2013

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-13 Thread Venkat Venkatsubra
-Original Message- From: Josh Hunt [mailto:joshhun...@gmail.com] Sent: Tuesday, November 12, 2013 10:25 PM To: David Miller Cc: jjo...@suse.com; LKML; Venkat Venkatsubra; net...@vger.kernel.org Subject: Re: [PATCH] rds: Error on offset mismatch if not loopback On Tue, Nov 12, 2013

RE: [PATCH] rds: Error on offset mismatch if not loopback

2013-11-13 Thread Venkat Venkatsubra
-Original Message- From: Josh Hunt [mailto:joshhun...@gmail.com] Sent: Tuesday, November 12, 2013 10:25 PM To: David Miller Cc: jjo...@suse.com; LKML; Venkat Venkatsubra; net...@vger.kernel.org Subject: Re: [PATCH] rds: Error on offset mismatch if not loopback On Tue, Nov 12, 2013

RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

2013-10-28 Thread Venkat Venkatsubra
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, October 27, 2013 11:27 PM To: b...@decadent.org.uk Cc: Venkat Venkatsubra; linux-kernel@vger.kernel.org; rds-de...@oss.oracle.com; net...@vger.kernel.org Subject: Re: [PATCH 7/8] rds: Pass pointers

RE: [PATCH 7/8] rds: Pass pointers to virt_to_page(), not integers

2013-10-28 Thread Venkat Venkatsubra
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: Sunday, October 27, 2013 11:27 PM To: b...@decadent.org.uk Cc: Venkat Venkatsubra; linux-kernel@vger.kernel.org; rds-de...@oss.oracle.com; net...@vger.kernel.org Subject: Re: [PATCH 7/8] rds: Pass pointers

Re: [PATCH 179/193] net/rds: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Venkat Venkatsubra
On 10/23/2012 3:04 PM, Kees Cook wrote: This config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it. CC: Venkat Venkatsubra CC: "David S. Miller" Signed-off-by: Kees Cook Acked-

Re: [PATCH 179/193] net/rds: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Venkat Venkatsubra
-off-by: Kees Cookkeesc...@chromium.org Acked-by: Venkat Venkatsubra venkat.x.venkatsu...@oracle.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rds: Error on offset mismatch if not loopback

2012-09-21 Thread Venkat Venkatsubra
On 9/21/2012 4:32 PM, John Jolly wrote: Attempting an rds connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine. A local unprivileged user could use

Re: [PATCH] rds: Error on offset mismatch if not loopback

2012-09-21 Thread Venkat Venkatsubra
On 9/21/2012 4:32 PM, John Jolly wrote: Attempting an rds connection from the IP address of an IPoIB interface to itself causes a kernel panic due to a BUG_ON() being triggered. Making the test less strict allows rds-ping to work without crashing the machine. A local unprivileged user could use