On 1/23/15, 4:50 PM, "Rasmus Villemoes" wrote:
>On Sat, Jan 24 2015, "Vick, Matthew" wrote:
>
>> Good catch! I noticed this too and was getting a patch together to
>>address
>> this.
>>
>> The difference is that I was planning on not sile
On 1/22/15, 2:53 PM, "Rasmus Villemoes" wrote:
>The comment explains the intention, but vid has type u16. Before the
>inner shift, it is promoted to int, which has plenty of space for all
>vid's bits, so nothing is dropped. Use a simple mask instead.
>
>Signed-off-by: Rasmus Villemoes
>---
> dri
On 1/16/15, 10:59 AM, "Xander Huff" wrote:
>From: Jeff Westfahl
>
>The TXPBSIZE register of the i210 resets to its default value only
>at power-on. It doesn't reset if you reboot the system, only if you
>pull power. If something (another driver, another OS, etc.) modifies
>this register from its
On 11/13/14, 3:36 PM, "Joe Stringer" wrote:
>fm10k supports up to 184 bytes of inner+outer headers. Add an initial
>check to fail encap offload if these are too large.
>
>Signed-off-by: Joe Stringer
>---
>Matthew, I didn't see the equivalent patch on netdev so I went ahead and
>created it. If I'
On 11/7/14, 2:35 PM, "Joe Stringer" wrote:
>Sure, I think fm10k_tx_encap_offload() is a good place for the header
>length
>check. Separately, my question above was regarding the idea of a helper
>for
>SKB_GSO_{GRE,UDP_TUNNEL}. The only reason it might be useful for the
>fm10k
>driver is becaus
On 11/6/14, 9:05 PM, "Joe Stringer" wrote:
>Let's merge both discussions into one thread (pick here or there). We
>have
>this suggestion or the one which simply checks for tunnels and
>inner+outer
>header lengths. Do you have a preference between them?
Agreed with merging the thread--consider
On 11/6/14, 1:15 PM, "Joe Stringer" wrote:
>Oh, I suppose we need to check the gso_type too. More like this?
>
>+static bool fm10k_gso_check(struct sk_buff *skb, struct net_device *dev)
>+{
>+ if ((skb_shinfo(skb)->gso_type & (SKB_GSO_UDP_TUNNEL |
>SKB_GSO_GRE)) &&
>+ !fm10k_tx_en
On 5/13/13 3:07 AM, "Dong Zhu" wrote:
>> You could use the flags field, as it has no definition yet.
>>
>> But you still need to explain why this new functionality is needed in
>> the first place:
>>
>> - You can query an interface's time stamping capabilities with the
>> GET_TS_INFO ethtool
8 matches
Mail list logo
