t;tpm: Remove useless priv field in struct
tpm_vendor_specific")
Cc: <sta...@vger.kernel.org>
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/ch
t;tpm: Remove useless priv field in struct
tpm_vendor_specific")
Cc:
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
ind
On Wed, 2017-03-08 at 13:52 -0700, Jason Gunthorpe wrote:
> On Wed, Mar 08, 2017 at 03:28:11PM -0500, Hon Ching(Vicky) Lo wrote:
> > On Wed, 2017-03-08 at 10:17 -0700, Jason Gunthorpe wrote:
> > > On Tue, Mar 07, 2017 at 11:12:43PM -0500, Hon Ching(Vicky) Lo wrote:
> > >
On Wed, 2017-03-08 at 13:52 -0700, Jason Gunthorpe wrote:
> On Wed, Mar 08, 2017 at 03:28:11PM -0500, Hon Ching(Vicky) Lo wrote:
> > On Wed, 2017-03-08 at 10:17 -0700, Jason Gunthorpe wrote:
> > > On Tue, Mar 07, 2017 at 11:12:43PM -0500, Hon Ching(Vicky) Lo wrote:
> > >
On Wed, 2017-03-08 at 10:17 -0700, Jason Gunthorpe wrote:
> On Tue, Mar 07, 2017 at 11:12:43PM -0500, Hon Ching(Vicky) Lo wrote:
> > On Mon, 2017-03-06 at 16:19 -0700, Jason Gunthorpe wrote:
>
> > > Also, how does locking work here? Does the vio core prevent
> > &g
On Wed, 2017-03-08 at 10:17 -0700, Jason Gunthorpe wrote:
> On Tue, Mar 07, 2017 at 11:12:43PM -0500, Hon Ching(Vicky) Lo wrote:
> > On Mon, 2017-03-06 at 16:19 -0700, Jason Gunthorpe wrote:
>
> > > Also, how does locking work here? Does the vio core prevent
> > &g
On Mon, 2017-03-06 at 16:19 -0700, Jason Gunthorpe wrote:
> On Mon, Mar 06, 2017 at 05:32:15PM -0500, Hon Ching(Vicky) Lo wrote:
> > The current code passes the address of tpm_chip as the argument to
> > dev_get_drvdata() without prior NULL check in
> > tpm_ibmvtpm_get_desire
On Mon, 2017-03-06 at 16:19 -0700, Jason Gunthorpe wrote:
> On Mon, Mar 06, 2017 at 05:32:15PM -0500, Hon Ching(Vicky) Lo wrote:
> > The current code passes the address of tpm_chip as the argument to
> > dev_get_drvdata() without prior NULL check in
> > tpm_ibmvtpm_get_desire
t;tpm: Remove useless priv field in struct
tpm_vendor_specific")
Cc: <sta...@vger.kernel.org>
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/ch
t;tpm: Remove useless priv field in struct
tpm_vendor_specific")
Cc:
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index 1b9d61
> On Jan 26, 2017, at 5:58 PM, Ashley Lai <ashleyd...@gmail.com> wrote:
>
> Adding Vicky from IBM.
>
>
> On 01/26/2017 04:05 PM, Jason Gunthorpe wrote:
>> On Thu, Jan 26, 2017 at 09:22:48PM +0100, Michal Such??nek wrote:
>>
>>> This is repeate
> On Jan 26, 2017, at 5:58 PM, Ashley Lai wrote:
>
> Adding Vicky from IBM.
>
>
> On 01/26/2017 04:05 PM, Jason Gunthorpe wrote:
>> On Thu, Jan 26, 2017 at 09:22:48PM +0100, Michal Such??nek wrote:
>>
>>> This is repeated a few times in the driver so I
H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c | 43 ---
drivers/char/tpm/tpm_ibmvtpm.h |7 ++
2 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvt
H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c | 43 ---
drivers/char/tpm/tpm_ibmvtpm.h |7 ++
2 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
granular level than what the existing code does. This patch adds
the missing CRQ transport event code checks to ensure appropriate
action taken, in the case that ibmvtpm_send_crq returns H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
granular level than what the existing code does. This patch adds
the missing CRQ transport event code checks to ensure appropriate
action taken, in the case that ibmvtpm_send_crq returns H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
of this horrible looking tail recursion thing.
> >
> > What the heck is suspend_again_count and why it can be module scope
> > variable? You could use a local variable instead if you would iterate
> > with a loop.
> >
> > /Jarkko
> >
>
> The reason for the 'goto' statement and the suspend_again_count was to
> prevent the suspend function recurse again. In the case if vtpm is in
> the process of being reloaded by firmware, we want to wait for the CRQ
> INITIALIZATION and resubmit suspend message i.e. recurse only once.
>
Never mind.. I don't really save any repetitive code by using recursion
now. I'll rework and resubmit the patch.
Thanks,
Vicky
of this horrible looking tail recursion thing.
> >
> > What the heck is suspend_again_count and why it can be module scope
> > variable? You could use a local variable instead if you would iterate
> > with a loop.
> >
> > /Jarkko
> >
>
> The reason for the 'goto' statement and the suspend_again_count was to
> prevent the suspend function recurse again. In the case if vtpm is in
> the process of being reloaded by firmware, we want to wait for the CRQ
> INITIALIZATION and resubmit suspend message i.e. recurse only once.
>
Never mind.. I don't really save any repetitive code by using recursion
now. I'll rework and resubmit the patch.
Thanks,
Vicky
On Fri, 2016-03-04 at 18:55 +0200, Jarkko Sakkinen wrote:
> On Wed, Mar 02, 2016 at 01:23:47AM -0500, Hon Ching(Vicky) Lo wrote:
> > ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
> > granular level than what the existing code does. This patch adds
> > the
On Fri, 2016-03-04 at 18:55 +0200, Jarkko Sakkinen wrote:
> On Wed, Mar 02, 2016 at 01:23:47AM -0500, Hon Ching(Vicky) Lo wrote:
> > ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
> > granular level than what the existing code does. This patch adds
> > the
ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
granular level than what the existing code does. This patch adds
the missing CRQ transport event code checks to ensure appropriate
action taken, in the case that ibmvtpm_send_crq returns H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
ibmvtpm_send_crq in tpm_ibmvtpm_suspend returns errors in a more
granular level than what the existing code does. This patch adds
the missing CRQ transport event code checks to ensure appropriate
action taken, in the case that ibmvtpm_send_crq returns H_CLOSED.
Signed-off-by: Hon Ching(Vicky) Lo
On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote:
>
> On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote:
> > The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
> > This patch reformats the log to be byte-aligned for the Linux client.
> >
> >
On Tue, 2015-10-13 at 13:43 -0500, Ashley Lai wrote:
>
> On 10/07/2015 07:11 PM, Hon Ching(Vicky) Lo wrote:
> > The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
> > This patch reformats the log to be byte-aligned for the Linux client.
> >
> >
The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
This patch reformats the log to be byte-aligned for the Linux client.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch/powerpc/kernel/prom_init.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
Replace all occurrences of '/ibm,vtpm' with '/vdevice/vtpm',
as only the latter is ganranteed to be available for the client OS.
The '/ibm,vtpm' node should only be used by Open Firmware, which
is susceptible to changes.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch/powerpc/kernel/prom_init.c
The OS should ask Power Firmware (PFW) for the size of the buffer
allocated for the event log, instead of the size of the actual
event log. It then passes the buffer adddress and size to PFW in
the handover process, into which PFW copies the log.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch
. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
Replace all occurrences of '/ibm,vtpm' with '/vdevice/vtpm',
as only the latter is ganranteed to be available for the client OS.
The '/ibm,vtpm' node should only be used by Open Firmware, which
is susceptible to changes.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch/powerpc/kernel/prom_init.c
The OS should ask Power Firmware (PFW) for the size of the buffer
allocated for the event log, instead of the size of the actual
event log. It then passes the buffer adddress and size to PFW in
the handover process, into which PFW copies the log.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch
. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo
---
drivers/char/tpm/tpm_ibmvtpm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
This patch reformats the log to be byte-aligned for the Linux client.
Signed-off-by: Hon Ching(Vicky) Lo
---
arch/powerpc/kernel/prom_init.c | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
diff --git
The OS should ask Power Firmware (PFW) for the size of the buffer
allocated for the event log, instead of the size of the actual
event log. It then passes the buffer adddress and size to PFW in
the handover process, into which PFW copies the log.
Signed-off-by: Hon Ching(Vicky) Lo <
Replace all occurrences of '/ibm,vtpm' with '/vdevice/vtpm',
as only the latter is ganranteed to be available for the client OS.
The '/ibm,vtpm' node should only be used by Open Firmware, which
is susceptible to changes.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvt
The OS should ask Power Firmware (PFW) for the size of the buffer
allocated for the event log, instead of the size of the actual
event log. It then passes the buffer adddress and size to PFW in
the handover process, into which PFW copies the log.
Signed-off-by: Hon Ching(Vicky) Lo <
The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
This patch reformats the log to be byte-aligned for the Linux client.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
arch/powerpc/kernel/prom_init.c | 13 -
1 files changed, 12 inse
Replace all occurrences of '/ibm,vtpm' with '/vdevice/vtpm',
as only the latter is ganranteed to be available for the client OS.
The '/ibm,vtpm' node should only be used by Open Firmware, which
is susceptible to changes.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
. This patch uses 'GFP_ATOMIC' instead so that the
allocation is high-priority and does not sleep.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
drivers/char/tpm/tpm_ibmvtpm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/char/tpm/tpm_ibmvt
The event log generated by OpenFirmware in PowerPC is 4-byte aligned.
This patch reformats the log to be byte-aligned for the Linux client.
Signed-off-by: Hon Ching(Vicky) Lo <hon...@linux.vnet.ibm.com>
---
arch/powerpc/kernel/prom_init.c | 13 -
1 files changed, 12 inse
Hi Peter,
Did you the explanations in the following reply make sense to you?
If you needed more clarifications, please advice. Thanks!
Forwarded Message
From: Hon Ching(Vicky) Lo
To: Peter Hüwe
Cc: tpmdd-de...@lists.sourceforge.net, Ashley Lai
, Vicky Lo ,
linux-kernel
Hi Peter,
Did you the explanations in the following reply make sense to you?
If you needed more clarifications, please advice. Thanks!
Forwarded Message
From: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
To: Peter Hüwe peterhu...@gmx.de
Cc: tpmdd-de
On Thu, 2015-07-16 at 20:43 +0200, Peter Hüwe wrote:
> Hi Vicky,
> Am Donnerstag, 16. Juli 2015, 19:54:15 schrieb Hon Ching(Vicky) Lo:
> > Hi Peter,
> >
> > On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote:
> > > Hi Vicky,
> > >
> > > sorry
On Thu, 2015-07-16 at 20:43 +0200, Peter Hüwe wrote:
Hi Vicky,
Am Donnerstag, 16. Juli 2015, 19:54:15 schrieb Hon Ching(Vicky) Lo:
Hi Peter,
On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote:
Hi Vicky,
sorry for the late reply
This patch makes the code endianness
Hi Peter,
On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote:
> Hi Vicky,
>
> sorry for the late reply
>
>
> > This patch makes the code endianness independent. We defined a
> > macro do_endian_conversion to apply endianness to raw integers
Hi Peter,
On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote:
Hi Vicky,
sorry for the late reply
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed
Hi Peter,
Please also commit this patch, if you accept it as well.
Thanks,
Vicky
Forwarded Message
From: Ashley Lai
To: Hon Ching(Vicky) Lo
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe ,
Ashley Lai , Vicky Lo ,
linux-kernel@vger.kernel.org, Joy Latten
>Subject:
Hi Peter,
Can you please commit the patch in the next open window,
if you accept it as well? Thanks!
Regards,
Vicky
Forwarded Message
From: Ashley Lai
To: Hon Ching(Vicky) Lo
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe ,
Ashley Lai , Vicky Lo ,
linux-kernel
Hi Peter,
Can you please commit the patch in the next open window, if you
accept it as well?
Thanks,
Vicky
On Thu, 2015-06-18 at 08:23 -0500, Ashley Lai wrote:
Looks better. Thanks.
>
> Reviewed-by: Ashley Lai
>
> Cheers,
> Ashley Lai
>
>
On Wed, 2015-06-17 at 1
Hi Peter,
Can you please commit the patch in the next open window, if you
accept it as well?
Thanks,
Vicky
On Thu, 2015-06-18 at 08:23 -0500, Ashley Lai wrote:
Looks better. Thanks.
Reviewed-by: Ashley Lai ash...@ahsleylai.com
Cheers,
Ashley Lai
On Wed, 2015-06-17 at 18:17 -0400
Hi Peter,
Can you please commit the patch in the next open window,
if you accept it as well? Thanks!
Regards,
Vicky
Forwarded Message
From: Ashley Lai ash...@ashleylai.com
To: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe
Hi Peter,
Please also commit this patch, if you accept it as well.
Thanks,
Vicky
Forwarded Message
From: Ashley Lai ash...@ashleylai.com
To: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe peterhu...@gmx.de,
Ashley Lai ash
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Signed-off-by: Hon Ching(Vicky) Lo
Signed
that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index c002d1b..62a22ce 100644
--- a/drivers/char/tpm
Hi Ashley,
Ah, good catch. I think I can only join the first two lines (where the
assignments are) and will have to leave the rest splitted. I'll resubmit
this one soon.
Thanks for the review!
Vicky
On Tue, 2015-06-16 at 20:17 -0500, Ashley Lai wrote:
> Just a small comment otherw
that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Signed-off-by: Joy Latten jmlat...@linux.vnet.ibm.com
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Signed-off-by: Hon Ching(Vicky) Lo hon
Hi Ashley,
Ah, good catch. I think I can only join the first two lines (where the
assignments are) and will have to leave the rest splitted. I'll resubmit
this one soon.
Thanks for the review!
Vicky
On Tue, 2015-06-16 at 20:17 -0500, Ashley Lai wrote:
Just a small comment otherwise
Hi Peter,
Yes, it's a fix to a kernel dump caused by enabling both vtpm and kdump.
On Tue, 2015-06-16 at 22:37 +0200, Peter Hüwe wrote:
> Hey,
>
> Am Freitag, 22. Mai 2015, 19:23:02 schrieb Hon Ching(Vicky) Lo:
> > tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without hav
Hi Peter,
Yes, it's a fix to a kernel dump caused by enabling both vtpm and kdump.
On Tue, 2015-06-16 at 22:37 +0200, Peter Hüwe wrote:
Hey,
Am Freitag, 22. Mai 2015, 19:23:02 schrieb Hon Ching(Vicky) Lo:
tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet
set
that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
index c002d1b..62a22ce 100644
--- a/drivers/char/tpm
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Signed-off-by: Hon Ching(Vicky) Lo
Signed
This patch makes the code endianness independent. We defined a
macro do_endian_conversion to apply endianness to raw integers
in the event entries so that they will be displayed properly.
tpm_binary_bios_measurements_show() is modified for the display.
Signed-off-by: Hon Ching(Vicky) Lo hon
that it is correctly
implemented.
Signed-off-by: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Signed-off-by: Joy Latten jmlat...@linux.vnet.ibm.com
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_of.c b/drivers/char/tpm/tpm_of.c
Hi Peter,
Would it be possible for you to review and commit the following patch
at your earliest convenience? Thanks in advance!
Forwarded Message
From: Ashley Lai
To: Hon Ching(Vicky) Lo
Cc: tpmdd-de...@lists.sourceforge.net, Peter Huewe ,
Ashley Lai , Vicky Lo ,
linux
Hi Peter,
Would it be possible for you to review and commit the following patch
at your earliest convenience? Thanks in advance!
Forwarded Message
From: Ashley Lai ash...@ashleylai.com
To: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Cc: tpmdd-de...@lists.sourceforge.net
tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet
set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq,
the phype call contains empty unit addresses, ibmvtpm->vdev->unit_address.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
d
tpm_ibmvtpm_probe() calls ibmvtpm_reset_crq(ibmvtpm) without having yet
set the virtual device in the ibmvtpm structure. So in ibmvtpm_reset_crq,
the phype call contains empty unit addresses, ibmvtpm-vdev-unit_address.
Signed-off-by: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Signed-off
On Tue, 2015-05-19 at 16:08 -0500, Ashley Lai wrote:
> Thank you Vicky and Joy for the clarification. This patch mainly
> converts the fields in the tcpa_event structure. I see the code converts
> everytime it accesses the event fields. Would it be more efficient if you
> do th
On Tue, 2015-05-19 at 16:08 -0500, Ashley Lai wrote:
Thank you Vicky and Joy for the clarification. This patch mainly
converts the fields in the tcpa_event structure. I see the code converts
everytime it accesses the event fields. Would it be more efficient if you
do the conversion once
ng tools
> that parse or understand the machine readable format. Any comments on
> this anyone?
I got comments on the format, so I tried to make that conditional
statement all in one line, but the 'Lindent' tool puts the lines back to
the above format..
Regards,
Vicky
--
tried to make that conditional
statement all in one line, but the 'Lindent' tool puts the lines back to
the above format..
Regards,
Vicky
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
prom_instantiate_sml() already converted the base pointer to little
endian. This patch removes this unnecessary additional conversion.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_of.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff
Do not skip the last entry of the event log.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
Changelog:
- remove redundant code
---
drivers/char/tpm/tpm_eventlog.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/char/tpm/tpm_eventlog.c b
Hi,
The patch set converts big endian event log entries to guest format
in PowerPC, which supports both little endian and big endian guests.
It also contains a fix to make sure the last event entry wasn't skipped.
Hon Ching(Vicky) Lo (3):
vTPM: fixed the limit checking
TPM: remove
the event
and print each field individually.
Signed-off-by: Hon Ching(Vicky) Lo
Signed-off-by: Joy Latten
---
drivers/char/tpm/tpm_eventlog.c | 92 +++
1 files changed, 73 insertions(+), 19 deletions(-)
diff --git a/drivers/char/tpm/tpm_eventlog.c b/drivers
Do not skip the last entry of the event log.
Signed-off-by: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Signed-off-by: Joy Latten jmlat...@linux.vnet.ibm.com
Changelog:
- remove redundant code
---
drivers/char/tpm/tpm_eventlog.c |5 +
1 files changed, 1 insertions(+), 4 deletions
Hi,
The patch set converts big endian event log entries to guest format
in PowerPC, which supports both little endian and big endian guests.
It also contains a fix to make sure the last event entry wasn't skipped.
Hon Ching(Vicky) Lo (3):
vTPM: fixed the limit checking
TPM: remove
prom_instantiate_sml() already converted the base pointer to little
endian. This patch removes this unnecessary additional conversion.
Signed-off-by: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Signed-off-by: Joy Latten jmlat...@linux.vnet.ibm.com
---
drivers/char/tpm/tpm_of.c |4 ++--
1
the event
and print each field individually.
Signed-off-by: Hon Ching(Vicky) Lo hon...@linux.vnet.ibm.com
Signed-off-by: Joy Latten jmlat...@linux.vnet.ibm.com
---
drivers/char/tpm/tpm_eventlog.c | 92 +++
1 files changed, 73 insertions(+), 19 deletions(-)
diff
is a special
case where the device is not initialized.
Regards,
Vicky
On Wed, 2014-12-03 at 08:20 +1100, Anton Blanchard wrote:
> Hi,
>
> > is this patchset still needed after Vicky's patch
> > "[tpmdd-devel] Fix NULL return in tpm_ibmvtpm_get_desired_dma"
> >
is a special
case where the device is not initialized.
Regards,
Vicky
On Wed, 2014-12-03 at 08:20 +1100, Anton Blanchard wrote:
Hi,
is this patchset still needed after Vicky's patch
[tpmdd-devel] Fix NULL return in tpm_ibmvtpm_get_desired_dma
https://patchwork.ozlabs.org/patch/402315
: 8b 7d 08 ff 4b 14 0f 94 c0 84 c0 0f 84
a5 00 00 00 53 e8 7a
Oct 1 12:58:02 proxy3 kernel: <7>sending pkt_too_big to self
--
Best regards,
Vicky Shrestha
System Administrator
WorldLink Communications Pvt.Ltd
Jawalakhel, Kathmandu, Nepal.
_ The ISP-LINUX Discussio
12:58:02 proxy3 kernel: Code: 8b 7d 08 ff 4b 14 0f 94 c0 84 c0 0f 84
a5 00 00 00 53 e8 7a
Oct 1 12:58:02 proxy3 kernel: 7sending pkt_too_big to self
--
Best regards,
Vicky Shrestha
System Administrator
WorldLink Communications Pvt.Ltd
Jawalakhel, Kathmandu, Nepal.
_ The ISP
84 matches
Mail list logo
