Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-09-01 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 2:55 PM, wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP which enables access to > Altera EPCS and EPCQ flash chips. This patch adds driver > for these devices. > > Signed-off-by: VIET NGA DAO > > --- > v5: >

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Fri, Aug 21, 2015 at 4:37 AM, Brian Norris wrote: > On Thu, Aug 20, 2015 at 05:18:14PM +0800, Viet Nga Dao wrote: >> You might misunderstand the hardware problem i mention here. This soft >> IP controller is able to provide the ID for our Altera EPCS/EPCQ flash >> chips

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 4:52 PM, Marek Vasut wrote: > On Thursday, August 20, 2015 at 10:13:30 AM, Nga Chi wrote: >> On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut wrote: >> > On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: >> >> From: VIET NGA DA

Re: [PATCH] [PATCH v5] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
Sorry for missing to reply the last question On Thu, Aug 20, 2015 at 4:13 PM, Nga Chi wrote: > On Thu, Aug 20, 2015 at 4:03 PM, Marek Vasut wrote: >> On Thursday, August 20, 2015 at 08:55:05 AM, vn...@altera.com wrote: >>> From: VIET NGA DAO >>> >>> Alt

Re: [PATCH] [PATCH v4] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Thu, Aug 20, 2015 at 3:55 PM, Marek Vasut wrote: > On Thursday, August 20, 2015 at 09:37:33 AM, Viet Nga Dao wrote: >> Hi, > > Hi, > >> >> On Tuesday, August 18, 2015 at 03:24:44 AM, Brian Norris wrote: >> >>> I'm not very helpful her

Re: [PATCH] [PATCH v4] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
Hi, >> On Tuesday, August 18, 2015 at 03:24:44 AM, Brian Norris wrote: >>> I'm not very helpful here, so hopefully Viet can be of more use: >> >> Yup :) >> >>> On Mon, Aug 17, 2015 at 07:53:23PM +0200, Marek Vasut wrote: >>> > On Monday, August 17, 2015 at 06:03:38 PM, Brian Norris wrote: >>> > Als

Re: [PATCH] [PATCH v4] mtd:spi-nor: Add Altera Quad SPI Driver

2015-08-20 Thread Viet Nga Dao
On Tue, Aug 18, 2015 at 2:55 PM, Viet Nga Dao wrote: > > > -Original Message- > From: ma...@denx.de > Sent: Tuesday, August 18, 2015 9:33 AM > To: Brian Norris > Cc: linux-...@lists.infradead.org; Viet Nga Dao; devicet...@vger.kernel.org; > Rafa?? Mi??ecki; linu

Re: [PATCH] [PATCH v4] mtd:spi-nor: Add Altera Quad SPI Driver

2015-07-27 Thread Viet Nga Dao
Thanks Brian for your reply! On Sat, Jul 25, 2015 at 2:37 AM, Brian Norris wrote: > On Wed, Jun 03, 2015 at 12:30:44AM -0700, vn...@altera.com wrote: >> From: VIET NGA DAO >> >> Altera Quad SPI Controller is a soft IP which enables access to >> Altera EPCS, EPCQ a

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-05-04 Thread Viet Nga Dao
get this patch upstream > by end of this month. > Thanks, > Viet Nga > > On Mon, Mar 16, 2015 at 4:16 PM, wrote: >> From: VIET NGA DAO >> >> Altera Quad SPI Controller is a soft IP which enables access to Altera EPCQ >> and >> EPCS flash chips. This pa

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-04-14 Thread Viet Nga Dao
Hi, Could you please help me to review this patch? Thanks On Mon, Mar 16, 2015 at 4:40 PM, Viet Nga Dao wrote: > On Mon, Mar 16, 2015 at 4:35 PM, Rafał Miłecki wrote: >> On 16 March 2015 at 09:16, wrote: >>> +static struct flash_device flash_devices[] = { >>> +

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-04-07 Thread Viet Nga Dao
Hi Brian, Can you help me to review this patch of mine? Thanks, Nga On Mon, Mar 16, 2015 at 4:16 PM, wrote: > From: VIET NGA DAO > > Altera Quad SPI Controller is a soft IP which enables access to Altera EPCQ > and > EPCS flash chips. This patch adds driver for these devices.

Re: [PATCH] mtd:spi-nor: Add lock and unlock callback functions to struct spi_nor

2015-03-19 Thread Viet Nga Dao
Hi Brian, On Fri, Mar 20, 2015 at 1:49 AM, Brian Norris wrote: > Hi Viet, > > On Mon, Mar 16, 2015 at 01:15:14AM -0700, vn...@altera.com wrote: >> From: VIET NGA DAO >> >> This patch introduces a properly-replaceable spi_nor callback that does >> flash speci

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-16 Thread Viet Nga Dao
On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris wrote: > Hi Viet, > > On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote: >> From: Viet Nga Dao >> >> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and >> EPCS flash chips. This pa

Re: [PATCH] [PATCH v3] mtd:spi-nor: Add Altera Quad SPI Driver

2015-03-16 Thread Viet Nga Dao
On Mon, Mar 16, 2015 at 4:35 PM, Rafał Miłecki wrote: > On 16 March 2015 at 09:16, wrote: >> +static struct flash_device flash_devices[] = { >> + FLASH_ID("epcq16-nonjedec", 2, 0x15), >> + FLASH_ID("epcq32-nonjedec", 2, 0x16), >> + FLASH_ID("epcq64-nonjedec", 2, 0x17), >> +

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-13 Thread Viet Nga Dao
Hi Brian, Thanks for your detail comment. I will make modification and submit the separated patches On Fri, Mar 13, 2015 at 3:38 PM, Brian Norris wrote: > Hi Viet, > > On Wed, Feb 11, 2015 at 12:53:00PM +0800, Viet Nga Dao wrote: >> From: Viet Nga Dao >> >> Altera E

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Viet Nga Dao
On Fri, Mar 13, 2015 at 1:45 PM, Rafał Miłecki wrote: > On 11 March 2015 at 09:41, Viet Nga Dao wrote: >> On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >>> Ok. I will modify the code the way you suggest. >> >> I just realize that the opcode for RDID is han

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-12 Thread Viet Nga Dao
Hi, Could anyone please help me review the lock, unlock modification part i did in spi-nor? Thanks, Viet Nga On Mon, Feb 23, 2015 at 9:30 AM, Viet Nga Dao wrote: > Hi, > It has been nearly 2 weeks since i submitted this patch. Could you > please help to review? > Thanks, > &

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-11 Thread Viet Nga Dao
Hi Rafal, On Tue, Mar 10, 2015 at 4:09 PM, Viet Nga Dao wrote: >>>>> + >>>>> +/* Altera EPCQ/EPCS Flashes */ >>>>> +{ "epcq16" , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) }, >>>>> +{ "epcq32" , EPCQ_I

Re: FW: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-10 Thread Viet Nga Dao
+ +/* Altera EPCQ/EPCS Flashes */ +{ "epcq16" , EPCQ_INFO(2, 0x15, 0x1, 32, 0x100) }, +{ "epcq32" , EPCQ_INFO(2, 0x16, 0x1, 64, 0x100) }, +{ "epcq64" , EPCQ_INFO(2, 0x17, 0x1, 128, 0x100) }, +{ "epcq128" , EPCQ_INFO(2, 0x18, 0x10

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-09 Thread Viet Nga Dao
Hi Rafal, Thanks for your review. On Mon, Mar 9, 2015 at 2:31 PM, Rafał Miłecki wrote: > Hi Viet, > > I'm not too active in mtd subsystem, so I didn't notice your patch > earlier. However I would like to share few comments. > > On 11 February 2015 at 05:53, Viet Nga D

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-03-08 Thread Viet Nga Dao
Hi Brian, I understand that you are busy but is it possible if you could spend some time to help me review my patch? My work progress really depends on your review. Thanks, Viet Nga On Tue, Feb 24, 2015 at 11:59 AM, Brian Norris wrote: > On Mon, Feb 23, 2015 at 09:30:09AM +0800, Viet Nga

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-22 Thread Viet Nga Dao
Hi, It has been nearly 2 weeks since i submitted this patch. Could you please help to review? Thanks, On Tue, Feb 17, 2015 at 9:33 AM, Viet Nga Dao wrote: > Hi Brian, > Could you please help me to review through this 2nd version? > > On Wed, Feb 11, 2015 at 12:53 PM, Viet Ng

Re: [PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-16 Thread Viet Nga Dao
Hi Brian, Could you please help me to review through this 2nd version? On Wed, Feb 11, 2015 at 12:53 PM, Viet Nga Dao wrote: > From: Viet Nga Dao > > Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and > EPCS flash chips. This patch adds driver for t

[PATCH v2] mtd:spi-nor: Add Altera EPCQ Driver

2015-02-10 Thread Viet Nga Dao
From: Viet Nga Dao Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and EPCS flash chips. This patch adds driver for these devices. Signed-off-by: VIET NGA DAO --- v2: - Change to spi_nor structure - Add lock and unlock functions for spi_nor - Simplify the

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-02-09 Thread Viet Nga Dao
Sorry for multiple emails. On Mon, Feb 9, 2015 at 2:42 PM, Viet Nga Dao wrote: > Please ignore previous 2 emails of mine ^^ > > On Thu, Feb 5, 2015 at 4:37 AM, Brian Norris > wrote: >> On Tue, Jan 27, 2015 at 02:53:59PM +0800, Viet Nga Dao wrote: >>> On Tue, Jan 20,

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-02-08 Thread Viet Nga Dao
Please ignore previous 2 emails of mine ^^ On Thu, Feb 5, 2015 at 4:37 AM, Brian Norris wrote: > On Tue, Jan 27, 2015 at 02:53:59PM +0800, Viet Nga Dao wrote: >> On Tue, Jan 20, 2015 at 10:05 AM, Viet Nga Dao wrote: >> > On Thu, Jan 15, 2015 at 5:27 PM, Viet Nga Dao wrote: &g

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-02-04 Thread Viet Nga Dao
On Thu, Feb 5, 2015 at 4:37 AM, Brian Norris wrote: > On Tue, Jan 27, 2015 at 02:53:59PM +0800, Viet Nga Dao wrote: >> On Tue, Jan 20, 2015 at 10:05 AM, Viet Nga Dao wrote: >> > On Thu, Jan 15, 2015 at 5:27 PM, Viet Nga Dao wrote: >> >> On Tue, Jan 13,

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-26 Thread Viet Nga Dao
On Tue, Jan 20, 2015 at 10:05 AM, Viet Nga Dao wrote: > On Thu, Jan 15, 2015 at 5:27 PM, Viet Nga Dao wrote: >> On Tue, Jan 13, 2015 at 11:33 AM, Brian Norris >> wrote: >>> On Thu, Dec 18, 2014 at 12:23:16AM -0800, vn...@altera.com wrote: >>>> From:

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-21 Thread Viet Nga Dao
On Tue, Jan 20, 2015 at 10:05 AM, Viet Nga Dao wrote: > On Thu, Jan 15, 2015 at 5:27 PM, Viet Nga Dao wrote: >> On Tue, Jan 13, 2015 at 11:33 AM, Brian Norris >> wrote: >>> On Thu, Dec 18, 2014 at 12:23:16AM -0800, vn...@altera.com wrote: >>>> From:

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-19 Thread Viet Nga Dao
On Thu, Jan 15, 2015 at 5:27 PM, Viet Nga Dao wrote: > On Tue, Jan 13, 2015 at 11:33 AM, Brian Norris > wrote: >> On Thu, Dec 18, 2014 at 12:23:16AM -0800, vn...@altera.com wrote: >>> From: Viet Nga Dao >>> >>> Altera EPCQ Controller is a soft IP which ena

Re: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-15 Thread Viet Nga Dao
On Tue, Jan 13, 2015 at 11:33 AM, Brian Norris wrote: > On Thu, Dec 18, 2014 at 12:23:16AM -0800, vn...@altera.com wrote: >> From: Viet Nga Dao >> >> Altera EPCQ Controller is a soft IP which enables access to Altera EPCQ and >> EPCS flash chips. This patch ad

RE: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-14 Thread Viet Nga Dao
decoding works for the only few used opcodes. Thanks, Viet Nga -Original Message- From: Brian Norris [mailto:computersforpe...@gmail.com] Sent: Tuesday, January 13, 2015 11:33 AM To: Viet Nga Dao Cc: dw...@infradead.org; linux-...@lists.infradead.org; linux-kernel@vger.kernel.org; devicet

RE: [PATCH mtd] mtd:devices: Add Altera EPCQ Driver

2015-01-12 Thread Viet Nga Dao
Hi Linux Community, It is been a while since I submitted this patch. Could you please help me to review this driver? Thanks and Regards, Viet Nga Dao -Original Message- From: Viet Nga Dao Sent: Thursday, December 18, 2014 4:23 PM To: dw...@infradead.org; computersforpe...@gmail.com Cc