Re: [PATCH V1 1/3] mmc: sdhci: Allow platform controlled voltage switching

2018-07-25 Thread Vijay Viswanath
Hi Adrian, On 7/25/2018 5:23 PM, Adrian Hunter wrote: On 20/07/18 13:46, Vijay Viswanath wrote: Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching. For such controllers, changing voltage before the HW is ready can result in various issues

Re: [PATCH V1 1/3] mmc: sdhci: Allow platform controlled voltage switching

2018-07-25 Thread Vijay Viswanath
Hi Adrian, On 7/25/2018 5:23 PM, Adrian Hunter wrote: On 20/07/18 13:46, Vijay Viswanath wrote: Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching. For such controllers, changing voltage before the HW is ready can result in various issues

Re: [PATCH RFC 2/7] mmc: core: devfreq: Add devfreq based clock scaling support

2018-07-23 Thread Vijay Viswanath
Hi Sayali, On 7/13/2018 3:22 PM, Sayali Lokhande wrote: This change adds the use of devfreq to MMC. Both eMMC and SD card will use it. For some workloads, such as video playback, it isn't necessary for these cards to run at high speed. Running at lower frequency, for example 52MHz, in such

Re: [PATCH RFC 2/7] mmc: core: devfreq: Add devfreq based clock scaling support

2018-07-23 Thread Vijay Viswanath
Hi Sayali, On 7/13/2018 3:22 PM, Sayali Lokhande wrote: This change adds the use of devfreq to MMC. Both eMMC and SD card will use it. For some workloads, such as video playback, it isn't necessary for these cards to run at high speed. Running at lower frequency, for example 52MHz, in such

[PATCH V1 3/3] mmc: sdhci-msm: Use internal voltage control

2018-07-20 Thread Vijay Viswanath
. Signed-off-by: Asutosh Das Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Veerabhadrarao Badiganti Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 220 --- 1 file changed, 209 insertions(+), 11 deletions(-) diff --git a/drivers/mmc

[PATCH V1 3/3] mmc: sdhci-msm: Use internal voltage control

2018-07-20 Thread Vijay Viswanath
. Signed-off-by: Asutosh Das Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Veerabhadrarao Badiganti Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 220 --- 1 file changed, 209 insertions(+), 11 deletions(-) diff --git a/drivers/mmc

[PATCH V1 2/3] Documentation: sdhci-msm: Add entries for passing load values

2018-07-20 Thread Vijay Viswanath
The load a particular sdhc controller should request from a regulator is device specific and hence each device should individually vote for the required load. Signed-off-by: Vijay Viswanath --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH V1 2/3] Documentation: sdhci-msm: Add entries for passing load values

2018-07-20 Thread Vijay Viswanath
The load a particular sdhc controller should request from a regulator is device specific and hence each device should individually vote for the required load. Signed-off-by: Vijay Viswanath --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH V1 1/3] mmc: sdhci: Allow platform controlled voltage switching

2018-07-20 Thread Vijay Viswanath
driver. Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1c828e0..494a1e2 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c

[PATCH V1 1/3] mmc: sdhci: Allow platform controlled voltage switching

2018-07-20 Thread Vijay Viswanath
driver. Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 1c828e0..494a1e2 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c

[PATCH V1 0/3] Internal voltage control for platform drivers

2018-07-20 Thread Vijay Viswanath
tors if sdhci_msm layer is present. Tested on: sdm845 Requies patch series:"[PATCH V3 0/4] Changes for SDCC5 version" Vijay Viswanath (3): mmc: sdhci: Allow platform controlled voltage switching Documentation: sdhci-msm: Add entries for passing load values mmc: sdhci-msm: Use internal v

[PATCH V1 0/3] Internal voltage control for platform drivers

2018-07-20 Thread Vijay Viswanath
tors if sdhci_msm layer is present. Tested on: sdm845 Requies patch series:"[PATCH V3 0/4] Changes for SDCC5 version" Vijay Viswanath (3): mmc: sdhci: Allow platform controlled voltage switching Documentation: sdhci-msm: Add entries for passing load values mmc: sdhci-msm: Use internal v

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-17 Thread Vijay Viswanath
On 7/17/2018 3:24 PM, Adrian Hunter wrote: On 17/07/18 12:45, Vijay Viswanath wrote: On 7/17/2018 2:12 PM, Adrian Hunter wrote: On 17/07/18 11:40, Vijay Viswanath wrote: On 7/17/2018 1:00 PM, Adrian Hunter wrote: On 17/07/18 08:14, Vijay Viswanath wrote: On 7/10/2018 4:37 PM

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-17 Thread Vijay Viswanath
On 7/17/2018 3:24 PM, Adrian Hunter wrote: On 17/07/18 12:45, Vijay Viswanath wrote: On 7/17/2018 2:12 PM, Adrian Hunter wrote: On 17/07/18 11:40, Vijay Viswanath wrote: On 7/17/2018 1:00 PM, Adrian Hunter wrote: On 17/07/18 08:14, Vijay Viswanath wrote: On 7/10/2018 4:37 PM

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-17 Thread Vijay Viswanath
On 7/17/2018 2:12 PM, Adrian Hunter wrote: On 17/07/18 11:40, Vijay Viswanath wrote: On 7/17/2018 1:00 PM, Adrian Hunter wrote: On 17/07/18 08:14, Vijay Viswanath wrote: On 7/10/2018 4:37 PM, Adrian Hunter wrote: On 21/06/18 15:23, Vijay Viswanath wrote: Some controllers can have

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-17 Thread Vijay Viswanath
On 7/17/2018 2:12 PM, Adrian Hunter wrote: On 17/07/18 11:40, Vijay Viswanath wrote: On 7/17/2018 1:00 PM, Adrian Hunter wrote: On 17/07/18 08:14, Vijay Viswanath wrote: On 7/10/2018 4:37 PM, Adrian Hunter wrote: On 21/06/18 15:23, Vijay Viswanath wrote: Some controllers can have

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-17 Thread Vijay Viswanath
On 7/17/2018 1:00 PM, Adrian Hunter wrote: On 17/07/18 08:14, Vijay Viswanath wrote: On 7/10/2018 4:37 PM, Adrian Hunter wrote: On 21/06/18 15:23, Vijay Viswanath wrote: Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-17 Thread Vijay Viswanath
On 7/17/2018 1:00 PM, Adrian Hunter wrote: On 17/07/18 08:14, Vijay Viswanath wrote: On 7/10/2018 4:37 PM, Adrian Hunter wrote: On 21/06/18 15:23, Vijay Viswanath wrote: Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-16 Thread Vijay Viswanath
On 7/10/2018 4:37 PM, Adrian Hunter wrote: On 21/06/18 15:23, Vijay Viswanath wrote: Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching. For such controllers, changing voltage before the HW is ready can result in various issues. Add a quirk

Re: [PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-07-16 Thread Vijay Viswanath
On 7/10/2018 4:37 PM, Adrian Hunter wrote: On 21/06/18 15:23, Vijay Viswanath wrote: Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching. For such controllers, changing voltage before the HW is ready can result in various issues. Add a quirk

[PATCH RFC 2/2] mmc: sdhci-msm: Use internal voltage control

2018-06-21 Thread Vijay Viswanath
. Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 99 ++-- 1 file changed, 87 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index a0dc3e1..ebdde29 100644 --- a/drivers/mmc/host/sdhci

[PATCH RFC 2/2] mmc: sdhci-msm: Use internal voltage control

2018-06-21 Thread Vijay Viswanath
. Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 99 ++-- 1 file changed, 87 insertions(+), 12 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index a0dc3e1..ebdde29 100644 --- a/drivers/mmc/host/sdhci

[PATCH RFC 0/2] Internal voltage control for platform drivers

2018-06-21 Thread Vijay Viswanath
the msm driver and use them. Voltage switching from core layer is causing CRC/cmd timeout errors in some chipsets. Tested on: sdm845, db410c Requies patch series:"[PATCH V3 0/4] Changes for SDCC5 version" Vijay Viswanath (2): mmc: sdhci: Allow platform controlled voltage switching

[PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-06-21 Thread Vijay Viswanath
Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching. For such controllers, changing voltage before the HW is ready can result in various issues. Add a quirk, which can be used by drivers of such controllers. Signed-off-by: Vijay Viswanath

[PATCH RFC 0/2] Internal voltage control for platform drivers

2018-06-21 Thread Vijay Viswanath
the msm driver and use them. Voltage switching from core layer is causing CRC/cmd timeout errors in some chipsets. Tested on: sdm845, db410c Requies patch series:"[PATCH V3 0/4] Changes for SDCC5 version" Vijay Viswanath (2): mmc: sdhci: Allow platform controlled voltage switching

[PATCH RFC 1/2] mmc: sdhci: Allow platform controlled voltage switching

2018-06-21 Thread Vijay Viswanath
Some controllers can have internal mechanism to inform the SW that it is ready for voltage switching. For such controllers, changing voltage before the HW is ready can result in various issues. Add a quirk, which can be used by drivers of such controllers. Signed-off-by: Vijay Viswanath

[PATCH V3 4/4] mmc: host: Register changes for sdcc V5

2018-06-18 Thread Vijay Viswanath
From: Sayali Lokhande Add support to use the new compatible string "qcom,sdhci-msm-v5". Based on the msm variant, pick the relevant variant data and use it for register read/write to msm specific registers. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath Reviewed-by:

[PATCH V3 4/4] mmc: host: Register changes for sdcc V5

2018-06-18 Thread Vijay Viswanath
From: Sayali Lokhande Add support to use the new compatible string "qcom,sdhci-msm-v5". Based on the msm variant, pick the relevant variant data and use it for register read/write to msm specific registers. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath Reviewed-by:

[PATCH V3 3/4] Documentation: sdhci-msm: Add new compatible string for SDCC v5

2018-06-18 Thread Vijay Viswanath
From: Sayali Lokhande For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci-msm-v5" is added. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath Acked-by: Rob Herring --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 7 ++- 1 file changed, 6

[PATCH V3 3/4] Documentation: sdhci-msm: Add new compatible string for SDCC v5

2018-06-18 Thread Vijay Viswanath
From: Sayali Lokhande For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci-msm-v5" is added. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath Acked-by: Rob Herring --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 7 ++- 1 file changed, 6

[PATCH V3 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-18 Thread Vijay Viswanath
. Also defind new data structure to hold version specific Ops and register addresses. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath Reviewed-by: Evan Green --- drivers/mmc/host/sdhci-msm.c | 75 1 file changed, 75 insertions(+) diff

[PATCH V3 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-18 Thread Vijay Viswanath
. Also defind new data structure to hold version specific Ops and register addresses. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath Reviewed-by: Evan Green --- drivers/mmc/host/sdhci-msm.c | 75 1 file changed, 75 insertions(+) diff

[PATCH V3 1/4] mmc: sdhci-msm: Define new Register address map

2018-06-18 Thread Vijay Viswanath
-by: Vijay Viswanath Reviewed-by: Evan Green Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-msm.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index bb11916..4050c99 100644

[PATCH V3 0/4] Changes for SDCC5 version

2018-06-18 Thread Vijay Viswanath
ss map Documentation: sdhci-msm: Add new compatible string for SDCC v5 mmc: host: Register changes for sdcc V5 Vijay Viswanath (1): mmc: sdhci-msm: Add msm version specific ops and data structures .../devicetree/bindings/mmc/sdhci-msm.txt | 7 +- drivers/mmc/host/s

[PATCH V3 1/4] mmc: sdhci-msm: Define new Register address map

2018-06-18 Thread Vijay Viswanath
-by: Vijay Viswanath Reviewed-by: Evan Green Acked-by: Adrian Hunter --- drivers/mmc/host/sdhci-msm.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index bb11916..4050c99 100644

[PATCH V3 0/4] Changes for SDCC5 version

2018-06-18 Thread Vijay Viswanath
ss map Documentation: sdhci-msm: Add new compatible string for SDCC v5 mmc: host: Register changes for sdcc V5 Vijay Viswanath (1): mmc: sdhci-msm: Add msm version specific ops and data structures .../devicetree/bindings/mmc/sdhci-msm.txt | 7 +- drivers/mmc/host/s

Re: [PATCH V2 4/4] mmc: host: Register changes for sdcc V5

2018-06-14 Thread Vijay Viswanath
On 6/13/2018 4:55 AM, Stephen Boyd wrote: Quoting Vijay Viswanath (2018-05-29 02:52:41) @@ -137,6 +125,12 @@ /* Timeout value to avoid infinite waiting for pwr_irq */ #define MSM_PWR_IRQ_TIMEOUT_MS 5000 +#define MSM_HOST_READL(msm_host, host, offset) \ + msm_host->var_

Re: [PATCH V2 4/4] mmc: host: Register changes for sdcc V5

2018-06-14 Thread Vijay Viswanath
On 6/13/2018 4:55 AM, Stephen Boyd wrote: Quoting Vijay Viswanath (2018-05-29 02:52:41) @@ -137,6 +125,12 @@ /* Timeout value to avoid infinite waiting for pwr_irq */ #define MSM_PWR_IRQ_TIMEOUT_MS 5000 +#define MSM_HOST_READL(msm_host, host, offset) \ + msm_host->var_

Re: [PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-14 Thread Vijay Viswanath
Hi Stephen, On 6/13/2018 5:06 AM, Stephen Boyd wrote: Quoting Vijay Viswanath (2018-05-29 02:52:39) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 4050c99..2a66aa0 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -226,6 +226,24

Re: [PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-06-14 Thread Vijay Viswanath
Hi Stephen, On 6/13/2018 5:06 AM, Stephen Boyd wrote: Quoting Vijay Viswanath (2018-05-29 02:52:39) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 4050c99..2a66aa0 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc/host/sdhci-msm.c @@ -226,6 +226,24

Re: [PATCH v2 4/4] mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq

2018-05-30 Thread Vijay Viswanath
t get any "Reset 0x1 never completed" error during card insert/remove or shutdown. Thanks, Vijay On 5/29/2018 5:49 PM, Georgi Djakov wrote: Hello Vijay, On 09/27/2017 08:34 AM, Vijay Viswanath wrote: Register writes which change voltage of IO lines or turn the IO bus on/off require

Re: [PATCH v2 4/4] mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq

2018-05-30 Thread Vijay Viswanath
t get any "Reset 0x1 never completed" error during card insert/remove or shutdown. Thanks, Vijay On 5/29/2018 5:49 PM, Georgi Djakov wrote: Hello Vijay, On 09/27/2017 08:34 AM, Vijay Viswanath wrote: Register writes which change voltage of IO lines or turn the IO bus on/off require

[PATCH V2 4/4] mmc: host: Register changes for sdcc V5

2018-05-29 Thread Vijay Viswanath
Add support to use the new compatible string "qcom,sdhci-msm-v5". Based on the msm variant, pick the relevant variant data and use it for register read/write to msm specific registers. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-m

[PATCH V2 4/4] mmc: host: Register changes for sdcc V5

2018-05-29 Thread Vijay Viswanath
Add support to use the new compatible string "qcom,sdhci-msm-v5". Based on the msm variant, pick the relevant variant data and use it for register read/write to msm specific registers. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-m

[PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-29 Thread Vijay Viswanath
. Also defind new data structure to hold version specific Ops and register addresses. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 77 1 file changed, 77 insertions(+) diff --git a/drivers/mmc/host

[PATCH V2 3/4] Documentation: sdhci-msm: Add new compatible string for SDCC v5

2018-05-29 Thread Vijay Viswanath
From: Sayali Lokhande For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci-msm-v5" is added. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletio

[PATCH V2 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-29 Thread Vijay Viswanath
. Also defind new data structure to hold version specific Ops and register addresses. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 77 1 file changed, 77 insertions(+) diff --git a/drivers/mmc/host

[PATCH V2 3/4] Documentation: sdhci-msm: Add new compatible string for SDCC v5

2018-05-29 Thread Vijay Viswanath
From: Sayali Lokhande For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci-msm-v5" is added. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletio

[PATCH V2 1/4] mmc: sdhci-msm: Define new Register address map

2018-05-29 Thread Vijay Viswanath
-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index bb11916..4050c99 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc

[PATCH V2 1/4] mmc: sdhci-msm: Define new Register address map

2018-05-29 Thread Vijay Viswanath
-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index bb11916..4050c99 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc

[PATCH V2 0/4] Changes for SDCC5 version

2018-05-29 Thread Vijay Viswanath
c: sdhci-msm: Define new Register address map Documentation: sdhci-msm: Add new compatible string for SDCC v5 Vijay Viswanath (2): mmc: sdhci-msm: Add msm version specific ops and data structures mmc: host: Register changes for sdcc V5 .../devicetree/bindings/mmc/sdhci-msm.txt |

[PATCH V2 0/4] Changes for SDCC5 version

2018-05-29 Thread Vijay Viswanath
c: sdhci-msm: Define new Register address map Documentation: sdhci-msm: Add new compatible string for SDCC v5 Vijay Viswanath (2): mmc: sdhci-msm: Add msm version specific ops and data structures mmc: host: Register changes for sdcc V5 .../devicetree/bindings/mmc/sdhci-msm.txt |

Re: [PATCH V1 3/3] mmc: host: Register changes for sdcc V5

2018-05-24 Thread Vijay Viswanath
On 5/22/2018 11:42 PM, Evan Green wrote: Hi Vijay. Thanks for this patch. On Thu, May 17, 2018 at 3:30 AM Vijay Viswanath <vvisw...@codeaurora.org> wrote: From: Sayali Lokhande <saya...@codeaurora.org> For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci

Re: [PATCH V1 3/3] mmc: host: Register changes for sdcc V5

2018-05-24 Thread Vijay Viswanath
On 5/22/2018 11:42 PM, Evan Green wrote: Hi Vijay. Thanks for this patch. On Thu, May 17, 2018 at 3:30 AM Vijay Viswanath wrote: From: Sayali Lokhande For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci-msm-v5" is added. Based on the msm variant, pick th

Re: [PATCH V1 2/3] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-24 Thread Vijay Viswanath
On 5/22/2018 11:40 PM, Evan Green wrote: On Thu, May 17, 2018 at 3:30 AM Vijay Viswanath <vvisw...@codeaurora.org> wrote: In addition to offsets of certain registers changing, the registers in core_mem have been shifted to HC mem as well. To access these registers, define msm v

Re: [PATCH V1 2/3] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-24 Thread Vijay Viswanath
On 5/22/2018 11:40 PM, Evan Green wrote: On Thu, May 17, 2018 at 3:30 AM Vijay Viswanath wrote: In addition to offsets of certain registers changing, the registers in core_mem have been shifted to HC mem as well. To access these registers, define msm version specific functions

Re: [PATCH V1 1/3] mmc: sdhci-msm: Define new Register address map

2018-05-24 Thread Vijay Viswanath
On 5/22/2018 11:39 PM, Evan Green wrote: Hi Vijay, On Thu, May 17, 2018 at 3:30 AM Vijay Viswanath <vvisw...@codeaurora.org> wrote: From: Sayali Lokhande <saya...@codeaurora.org> For SDCC version 5.0.0, MCI registers are removed from SDCC interface and some registers are

Re: [PATCH V1 1/3] mmc: sdhci-msm: Define new Register address map

2018-05-24 Thread Vijay Viswanath
On 5/22/2018 11:39 PM, Evan Green wrote: Hi Vijay, On Thu, May 17, 2018 at 3:30 AM Vijay Viswanath wrote: From: Sayali Lokhande For SDCC version 5.0.0, MCI registers are removed from SDCC interface and some registers are moved to HC. Define a new data structure where we can statically

[PATCH V1 2/3] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-17 Thread Vijay Viswanath
. Also defind new data structure to hold version specific Ops and register addresses. Signed-off-by: Sayali Lokhande <saya...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 112 +++ 1

[PATCH V1 2/3] mmc: sdhci-msm: Add msm version specific ops and data structures

2018-05-17 Thread Vijay Viswanath
. Also defind new data structure to hold version specific Ops and register addresses. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 112 +++ 1 file changed, 112 insertions(+) diff --git a/drivers/mmc/host

[PATCH V1 0/3] Changes for SDCC5 version

2018-05-17 Thread Vijay Viswanath
mmc: host: Register changes for sdcc V5 Vijay Viswanath (1): mmc: sdhci-msm: Add msm version specific ops and data structures .../devicetree/bindings/mmc/sdhci-msm.txt | 5 +- drivers/mmc/host/sdhci-msm.c | 545 - 2 files changed, 423 insertio

[PATCH V1 0/3] Changes for SDCC5 version

2018-05-17 Thread Vijay Viswanath
mmc: host: Register changes for sdcc V5 Vijay Viswanath (1): mmc: sdhci-msm: Add msm version specific ops and data structures .../devicetree/bindings/mmc/sdhci-msm.txt | 5 +- drivers/mmc/host/sdhci-msm.c | 545 - 2 files changed, 423 insertio

[PATCH V1 1/3] mmc: sdhci-msm: Define new Register address map

2018-05-17 Thread Vijay Viswanath
ed-off-by: Sayali Lokhande <saya...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-m

[PATCH V1 3/3] mmc: host: Register changes for sdcc V5

2018-05-17 Thread Vijay Viswanath
i Lokhande <saya...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- .../devicetree/bindings/mmc/sdhci-msm.txt | 5 +- drivers/mmc/host/sdhci-msm.c | 344 + 2 files changed, 222 insertions(+), 127 deletions(-)

[PATCH V1 1/3] mmc: sdhci-msm: Define new Register address map

2018-05-17 Thread Vijay Viswanath
-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 89 1 file changed, 89 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index bb11916..2524455 100644 --- a/drivers/mmc/host/sdhci-msm.c +++ b/drivers/mmc

[PATCH V1 3/3] mmc: host: Register changes for sdcc V5

2018-05-17 Thread Vijay Viswanath
From: Sayali Lokhande For SDCC version 5.0.0 and higher, new compatible string "qcom,sdhci-msm-v5" is added. Based on the msm variant, pick the relevant variant data and use it for register read/write to msm specific registers. Signed-off-by: Sayali Lokhande Signed-off-by: Vijay

Re: [PATCH RFC 2/4] mmc: sdhci-msm: Add and use voltage regulator related APIs

2018-05-03 Thread Vijay Viswanath
On 5/2/2018 2:19 PM, Ulf Hansson wrote: On 1 May 2018 at 12:39, Vijay Viswanath <vvisw...@codeaurora.org> wrote: From: Asutosh Das <asuto...@codeaurora.org> Some platforms require that the voltage switching happen only after the register write occurs and controller is ready fo

Re: [PATCH RFC 2/4] mmc: sdhci-msm: Add and use voltage regulator related APIs

2018-05-03 Thread Vijay Viswanath
On 5/2/2018 2:19 PM, Ulf Hansson wrote: On 1 May 2018 at 12:39, Vijay Viswanath wrote: From: Asutosh Das Some platforms require that the voltage switching happen only after the register write occurs and controller is ready for the switch. When the controller is ready, it will inform

Re: [PATCH RFC 1/4] mmc: host: Register changes for sdcc V5

2018-05-03 Thread Vijay Viswanath
On 5/2/2018 1:58 PM, Ulf Hansson wrote: On 1 May 2018 at 12:39, Vijay Viswanath <vvisw...@codeaurora.org> wrote: From: Sayali Lokhande <saya...@codeaurora.org> For SDCC version 5.0.0, MCI registers are removed from SDCC interface and some registers are moved to HC. This change i

Re: [PATCH RFC 1/4] mmc: host: Register changes for sdcc V5

2018-05-03 Thread Vijay Viswanath
On 5/2/2018 1:58 PM, Ulf Hansson wrote: On 1 May 2018 at 12:39, Vijay Viswanath wrote: From: Sayali Lokhande For SDCC version 5.0.0, MCI registers are removed from SDCC interface and some registers are moved to HC. This change is to support MCI register removal for msmfalcon. New

[PATCH RFC 2/4] mmc: sdhci-msm: Add and use voltage regulator related APIs

2018-05-01 Thread Vijay Viswanath
bha...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- .../devicetree/bindings/mmc/sdhci-msm.txt | 27 +- drivers/mmc/host/sdhci-msm.c | 537 +++-- 2 files changed, 529 insertions(+), 35 deletions(-) diff --

[PATCH RFC 4/4] host: sdhci-msm: implement get_current_limit() host op

2018-05-01 Thread Vijay Viswanath
khande <saya...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 0e0f12d..083b4a5 100644 ---

[PATCH RFC 3/4] host: sdhci: fix current caps when there is no host->vmmc

2018-05-01 Thread Vijay Viswanath
@codeaurora.org> Signed-off-by: Sayali Lokhande <saya...@codeaurora.org> [vvisw...@codeaurora.org: fixed trivial merge conflicts] Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> Change-Id: I3370a2411beec1f03cc5f102bf95cd816c60351e --- drivers/mmc/host/sdhci.c | 11 +++

[PATCH RFC 3/4] host: sdhci: fix current caps when there is no host->vmmc

2018-05-01 Thread Vijay Viswanath
[vvisw...@codeaurora.org: fixed trivial merge conflicts] Signed-off-by: Vijay Viswanath Change-Id: I3370a2411beec1f03cc5f102bf95cd816c60351e --- drivers/mmc/host/sdhci.c | 11 --- drivers/mmc/host/sdhci.h | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/sdh

[PATCH RFC 4/4] host: sdhci-msm: implement get_current_limit() host op

2018-05-01 Thread Vijay Viswanath
From: Sahitya Tummala This is needed to get the current capabilities of vdd regulator that is not managed by SDHCI driver. Change-Id: I927c14b9890f1d672fe8a3e89d0b334f43463b36 Signed-off-by: Sahitya Tummala Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- drivers/mmc/host

[PATCH RFC 2/4] mmc: sdhci-msm: Add and use voltage regulator related APIs

2018-05-01 Thread Vijay Viswanath
instead of relying on core layer voltage switching. Change-Id: Iaa98686e71a5bfe0092c68e9ffa563b060c5ac60 Signed-off-by: Asutosh Das Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani Signed-off-by: Vijay Viswanath --- .../devicetree/bindings/mmc/sdhci-msm.txt | 27

[PATCH RFC 1/4] mmc: host: Register changes for sdcc V5

2018-05-01 Thread Vijay Viswanath
alcon to support this change. Change-Id: I0febfd9bb436a8eff20c20107dd4180c9781 Signed-off-by: Sayali Lokhande <saya...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- .../devicetree/bindings/mmc/sdhci-msm.txt | 5 +- drivers/mmc/host/sdhci-msm.c

[PATCH RFC 1/4] mmc: host: Register changes for sdcc V5

2018-05-01 Thread Vijay Viswanath
Change-Id: I0febfd9bb436a8eff20c20107dd4180c9781 Signed-off-by: Sayali Lokhande Signed-off-by: Vijay Viswanath --- .../devicetree/bindings/mmc/sdhci-msm.txt | 5 +- drivers/mmc/host/sdhci-msm.c | 485 +++-- 2 files changed, 365 insertions(+), 125

[PATCH RFC 0/4] Changes for SDCC5 version

2018-05-01 Thread Vijay Viswanath
With SDCC5, the MCI register space got removed and the offset/order of several registers have changed. Based on SDCC version used and the register, we need to pick the base address and offset. Also power irq is a signal from controller to SW that it is ready for voltage switch. So added support to

[PATCH RFC 0/4] Changes for SDCC5 version

2018-05-01 Thread Vijay Viswanath
With SDCC5, the MCI register space got removed and the offset/order of several registers have changed. Based on SDCC version used and the register, we need to pick the base address and offset. Also power irq is a signal from controller to SW that it is ready for voltage switch. So added support to

[PATCH V5 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-04-20 Thread Vijay Viswanath
During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> Reviewed-by: Douglas Anderson <diand...@chromium.org> --- drivers/mm

[PATCH V5 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-04-20 Thread Vijay Viswanath
During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay Viswanath Reviewed-by: Douglas Anderson --- drivers/mmc/host/sdhci-msm.c | 29 - 1

[PATCH V5 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-20 Thread Vijay Viswanath
power irq is triggered for io high or io low, the driver should check the voltages supported and set the pad accordingly. Signed-off-by: Krishna Konda <kko...@codeaurora.org> Signed-off-by: Venkat Gopalakrishnan <venk...@codeaurora.org> Signed-off-by: Vijay Viswanath <vvisw...

[PATCH V5 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-20 Thread Vijay Viswanath
power irq is triggered for io high or io low, the driver should check the voltages supported and set the pad accordingly. Signed-off-by: Krishna Konda Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Vijay Viswanath Reviewed-by: Douglas Anderson --- drivers/mmc/host/sdhci-msm.c | 57

[PATCH V5 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm

2018-04-20 Thread Vijay Viswanath
v4: Removed unnecessary mb() within sdhci_msm_handle_pwr_irq() since wakeup calls have implicit write barriers. Krishna Konda (1): mmc: sdhci-msm: support voltage pad switching Vijay Viswanath (1): mmc: sdhci-msm: Add support to store supported vdd-io voltages drivers/mmc/host/sdhci-ms

[PATCH V5 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm

2018-04-20 Thread Vijay Viswanath
v4: Removed unnecessary mb() within sdhci_msm_handle_pwr_irq() since wakeup calls have implicit write barriers. Krishna Konda (1): mmc: sdhci-msm: support voltage pad switching Vijay Viswanath (1): mmc: sdhci-msm: Add support to store supported vdd-io voltages drivers/mmc/host/sdhci-ms

Re: [PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-18 Thread Vijay Viswanath
On 4/13/2018 10:38 PM, Doug Anderson wrote: Hi, On Fri, Apr 6, 2018 at 2:48 AM, Vijay Viswanath <vvisw...@codeaurora.org> wrote: On 3/29/2018 4:23 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath <vvisw...@codeaurora.org> wrote: From: Krishn

Re: [PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-18 Thread Vijay Viswanath
On 4/13/2018 10:38 PM, Doug Anderson wrote: Hi, On Fri, Apr 6, 2018 at 2:48 AM, Vijay Viswanath wrote: On 3/29/2018 4:23 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath wrote: From: Krishna Konda The PADs for SD card are dual-voltage that support 3v

Re: [PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-06 Thread Vijay Viswanath
On 3/29/2018 4:23 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath <vvisw...@codeaurora.org> wrote: From: Krishna Konda <kko...@codeaurora.org> The PADs for SD card are dual-voltage that support 3v/1.8v. Those PADs have a control signal (io_pa

Re: [PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-04-06 Thread Vijay Viswanath
On 3/29/2018 4:23 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath wrote: From: Krishna Konda The PADs for SD card are dual-voltage that support 3v/1.8v. Those PADs have a control signal (io_pad_pwr_switch/mode18 ) that indicates whether the PAD works in 3v

Re: [PATCH V4 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-04-01 Thread Vijay Viswanath
On 3/29/2018 4:22 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath <vvisw...@codeaurora.org> wrote: During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform

Re: [PATCH V4 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-04-01 Thread Vijay Viswanath
On 3/29/2018 4:22 AM, Doug Anderson wrote: Hi, On Wed, Mar 28, 2018 at 6:08 AM, Vijay Viswanath wrote: During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay

[PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-03-28 Thread Vijay Viswanath
org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 64 ++-- 1 file changed, 62 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index 2fcd9010..bbf9626 10064

[PATCH V4 2/2] mmc: sdhci-msm: support voltage pad switching

2018-03-28 Thread Vijay Viswanath
for IO lines. So when power irq is triggered for io high or io low, the driver should check the voltages supported and set the pad accordingly. Signed-off-by: Krishna Konda Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 64

[PATCH V4 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-03-28 Thread Vijay Viswanath
During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 35

[PATCH V4 1/2] mmc: sdhci-msm: Add support to store supported vdd-io voltages

2018-03-28 Thread Vijay Viswanath
During probe check whether the vdd-io regulator of sdhc platform device can support 1.8V and 3V and store this information as a capability of platform device. Signed-off-by: Vijay Viswanath --- drivers/mmc/host/sdhci-msm.c | 35 ++- 1 file changed, 34 insertions

[PATCH V4 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm

2018-03-28 Thread Vijay Viswanath
mmc: sdhci-msm: support voltage pad switching Vijay Viswanath (1): mmc: sdhci-msm: Add support to store supported vdd-io voltages drivers/mmc/host/sdhci-msm.c | 99 +++- 1 file changed, 97 insertions(+), 2 deletions(-) -- Qualcomm India Private Limi

[PATCH V4 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm

2018-03-28 Thread Vijay Viswanath
mmc: sdhci-msm: support voltage pad switching Vijay Viswanath (1): mmc: sdhci-msm: Add support to store supported vdd-io voltages drivers/mmc/host/sdhci-msm.c | 99 +++- 1 file changed, 97 insertions(+), 2 deletions(-) -- Qualcomm India Private Limi

[PATCH V3 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm

2018-03-28 Thread Vijay Viswanath
v2: IO_PAD_PWR_SWITCH_EN will be set only if we have info regarding what voltage is suported by the regulators. Replaced regulator_list_voltage() API with regulator_is_supported_voltage(). Krishna Konda (1): mmc: sdhci-msm: support voltage pad switching Vijay Viswanath (1):

[PATCH V3 2/2] mmc: sdhci-msm: support voltage pad switching

2018-03-28 Thread Vijay Viswanath
org> Signed-off-by: Vijay Viswanath <vvisw...@codeaurora.org> --- drivers/mmc/host/sdhci-msm.c | 65 ++-- 1 file changed, 63 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c index a822f10..2ffb7bb 10064

  1   2   >