[RFC v4 3/3] vfio: platform: reset: add msi support

2021-01-29 Thread Vikas Gupta
Add msi support for Broadcom FlexRm device. Signed-off-by: Vikas Gupta --- .../platform/reset/vfio_platform_bcmflexrm.c | 72 ++- 1 file changed, 70 insertions(+), 2 deletions(-) diff --git a/drivers/vfio/platform/reset/vfio_platform_bcmflexrm.c b/drivers/vfio/platform/reset

[RFC v4 0/3] msi support for platform devices

2021-01-29 Thread Vikas Gupta
ed as below Example: if there are 'n' IRQs and 'k' MSIs --- |IRQ-0|IRQ-1||IRQ-n|MSI-0|MSI-1|MSI-2|..|MSI-k| --- MSI-0 will have coun

[RFC v4 2/3] vfio/platform: change cleanup order

2021-01-29 Thread Vikas Gupta
In the case of msi, vendor specific msi module may require region access to handle msi cleanup so we need to cleanup region after irq cleanup only. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[RFC v4 1/3] vfio/platform: add support for msi

2021-01-29 Thread Vikas Gupta
MSI support for platform devices. MSI is added as a single 'index' with 'count' as the number of MSI(s) supported by the devices. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/Kconfig | 1 + drivers/vfio/platform/vfio_platform_common.c | 95 +

Re: [RFC v3 2/2] vfio/platform: msi: add Broadcom platform devices

2021-01-14 Thread Vikas Gupta
Hi Eric, On Tue, Jan 12, 2021 at 2:52 PM Auger Eric wrote: > > Hi Vikas, > > On 12/14/20 6:45 PM, Vikas Gupta wrote: > > Add msi support for Broadcom platform devices > > > > Signed-off-by: Vikas Gupta > > --- > > drivers/vfio/platform/Kconfig

Re: [RFC v3 1/2] vfio/platform: add support for msi

2021-01-14 Thread Vikas Gupta
Hi Eric, On Tue, Jan 12, 2021 at 2:30 PM Auger Eric wrote: > > Hi Vikas, > > On 1/5/21 6:53 AM, Vikas Gupta wrote: > > On Tue, Dec 22, 2020 at 10:57 PM Auger Eric wrote: > >> > >> Hi Vikas, > >> > >> On 12/14/20 6:45 PM, Vikas Gupta wrote

Re: [RFC v3 1/2] vfio/platform: add support for msi

2021-01-04 Thread Vikas Gupta
On Tue, Dec 22, 2020 at 10:57 PM Auger Eric wrote: > > Hi Vikas, > > On 12/14/20 6:45 PM, Vikas Gupta wrote: > > MSI support for platform devices.The MSI block > > is added as an extended IRQ which exports caps > > VFIO_IRQ_INFO_CAP_TYPE and VFIO_IRQ_INFO_CAP_MS

[RFC v3 1/2] vfio/platform: add support for msi

2020-12-14 Thread Vikas Gupta
MSI support for platform devices.The MSI block is added as an extended IRQ which exports caps VFIO_IRQ_INFO_CAP_TYPE and VFIO_IRQ_INFO_CAP_MSI_DESCS. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 179 +++- drivers/vfio/platform/vfio_platform_irq.c

[RFC v3 2/2] vfio/platform: msi: add Broadcom platform devices

2020-12-14 Thread Vikas Gupta
Add msi support for Broadcom platform devices Signed-off-by: Vikas Gupta --- drivers/vfio/platform/Kconfig | 1 + drivers/vfio/platform/Makefile| 1 + drivers/vfio/platform/msi/Kconfig | 9 drivers/vfio/platform/msi/Makefile| 2

[RFC, v3 0/2] msi support for platform devices

2020-12-14 Thread Vikas Gupta
7; IRQs and 'k' MSIs --- |IRQ-0|IRQ-1||IRQ-n|MSI-0|MSI-1|MSI-2|..|MSI-k| --- MSI-0 will have count=k set and flags set accordingly. Vikas Gupta (2): vfio/platform: add s

Re: [RFC v2 1/1] vfio/platform: add support for msi

2020-12-09 Thread Vikas Gupta
HI Eric, On Tue, Dec 8, 2020 at 2:13 AM Auger Eric wrote: > > Hi Vikas, > > On 12/3/20 3:50 PM, Vikas Gupta wrote: > > Hi Eric, > > > > On Wed, Dec 2, 2020 at 8:14 PM Auger Eric wrote: > >> > >> Hi Vikas, > >> > >> On 11/24/20

Re: [RFC v2 1/1] vfio/platform: add support for msi

2020-12-03 Thread Vikas Gupta
Hi Eric, On Wed, Dec 2, 2020 at 8:14 PM Auger Eric wrote: > > Hi Vikas, > > On 11/24/20 5:16 PM, Vikas Gupta wrote: > > MSI support for platform devices. > > > > Signed-off-by: Vikas Gupta > > --- > > drivers/vfio/platform/vfio_platform_common.c

Re: [RFC, v2 0/1] msi support for platform devices

2020-12-03 Thread Vikas Gupta
HI Eric, On Wed, Dec 2, 2020 at 8:13 PM Auger Eric wrote: > > Hi Vikas, > On 11/24/20 5:16 PM, Vikas Gupta wrote: > > This RFC adds support for MSI for platform devices. > > MSI block is added as an ext irq along with the existing > > wired interrupt implement

[RFC v2 1/1] vfio/platform: add support for msi

2020-11-24 Thread Vikas Gupta
MSI support for platform devices. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 99 ++- drivers/vfio/platform/vfio_platform_irq.c | 260 +- drivers/vfio/platform/vfio_platform_private.h | 16 ++ include/uapi/linux/vfio.h

[RFC, v2 0/1] msi support for platform devices

2020-11-24 Thread Vikas Gupta
e 'n' IRQs and 'k' MSIs --- |IRQ-0|IRQ-1||IRQ-n|MSI-0|MSI-1|MSI-2|..|MSI-k| --- MSI-0 will have count=k set and flags set accordingly. Vi

Re: [RFC, v1 0/3] msi support for platform devices

2020-11-17 Thread Vikas Gupta
Hi Eric, On Tue, Nov 17, 2020 at 1:55 PM Auger Eric wrote: > > Hi Vikas, > > On 11/17/20 9:05 AM, Auger Eric wrote: > > Hi Vikas, > > > > On 11/17/20 7:25 AM, Vikas Gupta wrote: > >> Hi Eric, > >> > >> On Mon, Nov 16, 2020 at 6:44 PM Auge

Re: [RFC, v1 0/3] msi support for platform devices

2020-11-16 Thread Vikas Gupta
Hi Eric, On Mon, Nov 16, 2020 at 6:44 PM Auger Eric wrote: > > Hi Vikas, > > On 11/13/20 6:24 PM, Vikas Gupta wrote: > > Hi Eric, > > > > On Fri, Nov 13, 2020 at 12:10 AM Auger Eric wrote: > >> > >> Hi Vikas, > >> > >> On 11/12/

Re: [RFC, v1 0/3] msi support for platform devices

2020-11-13 Thread Vikas Gupta
Hi Eric, On Fri, Nov 13, 2020 at 12:10 AM Auger Eric wrote: > > Hi Vikas, > > On 11/12/20 6:58 PM, Vikas Gupta wrote: > > This RFC adds support for MSI for platform devices. > > a) MSI(s) is/are added in addition to the normal interrupts. > > b) The vendor specific

[RFC v1 2/3] vfio/platform: change cleanup order

2020-11-12 Thread Vikas Gupta
In the case of msi, vendor specific msi module may require region access to handle msi cleanup so we need to cleanup region after irq cleanup only. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[RFC v1 1/3] vfio/platform: add support for msi

2020-11-12 Thread Vikas Gupta
MSI support for platform devices. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 84 ++- drivers/vfio/platform/vfio_platform_irq.c | 238 +- drivers/vfio/platform/vfio_platform_private.h | 23 ++ 3 files changed, 331 insertions(+), 14

[RFC v1 3/3] vfio/platform: add Broadcom msi module

2020-11-12 Thread Vikas Gupta
Add Broadcom msi module for platform devices. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/Kconfig | 1 + drivers/vfio/platform/Makefile| 1 + drivers/vfio/platform/msi/Kconfig | 9 +++ drivers/vfio/platform/msi/Makefile| 2

[RFC, v1 0/3] msi support for platform devices

2020-11-12 Thread Vikas Gupta
lags set accordingly. Vikas Gupta (3): vfio/platform: add support for msi vfio/platform: change cleanup order vfio/platform: add Broadcom msi module drivers/vfio/platform/Kconfig | 1 + drivers/vfio/platform/Makefile| 1 + drivers/vfio/platform/msi/Kconf

Re: [RFC, v0 1/3] vfio/platform: add support for msi

2020-11-10 Thread Vikas Gupta
Hi Alex, On Mon, Nov 9, 2020 at 8:58 PM Alex Williamson wrote: > > On Mon, 9 Nov 2020 12:11:15 +0530 > Vikas Gupta wrote: > > > Hi Alex, > > > > On Fri, Nov 6, 2020 at 8:42 AM Alex Williamson > > wrote: > > > > > > On Fri, 6 Nov 2020 08:

Re: [RFC, v0 1/3] vfio/platform: add support for msi

2020-11-10 Thread Vikas Gupta
Hi Eric, On Mon, Nov 9, 2020 at 8:35 PM Auger Eric wrote: > > Hi Vikas, > > On 11/6/20 3:54 AM, Vikas Gupta wrote: > > Hi Alex, > > > > On Thu, Nov 5, 2020 at 12:38 PM Alex Williamson > > wrote: > >> > >> On Thu, 5 Nov 2020 11:32:55

Re: [RFC, v0 1/3] vfio/platform: add support for msi

2020-11-08 Thread Vikas Gupta
Hi Alex, On Fri, Nov 6, 2020 at 8:42 AM Alex Williamson wrote: > > On Fri, 6 Nov 2020 08:24:26 +0530 > Vikas Gupta wrote: > > > Hi Alex, > > > > On Thu, Nov 5, 2020 at 12:38 PM Alex Williamson > > wrote: > > > > > > On Th

Re: [RFC, v0 1/3] vfio/platform: add support for msi

2020-11-05 Thread Vikas Gupta
Hi Alex, On Thu, Nov 5, 2020 at 12:38 PM Alex Williamson wrote: > > On Thu, 5 Nov 2020 11:32:55 +0530 > Vikas Gupta wrote: > > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > > index 2f313a238a8f..aab051e8338d 100644 > > --- a/include/uapi/

[RFC, v0 3/3] vfio/platform: add Broadcom msi module

2020-11-04 Thread Vikas Gupta
Add Broadcom msi module for platform devices. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/Kconfig | 1 + drivers/vfio/platform/Makefile| 1 + drivers/vfio/platform/msi/Kconfig | 9 +++ drivers/vfio/platform/msi/Makefile| 2

[RFC, v0 1/3] vfio/platform: add support for msi

2020-11-04 Thread Vikas Gupta
MSI support for platform devices. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 84 ++- drivers/vfio/platform/vfio_platform_irq.c | 235 +- drivers/vfio/platform/vfio_platform_private.h | 23 ++ include/uapi/linux/vfio.h

[RFC, v0 0/3] msi support for platform devices

2020-11-04 Thread Vikas Gupta
This RFC adds support for MSI for platform devices. a) MSI(s) is/are added in addition to the normal interrupts. b) The vendor specific MSI configuration can be done using callbacks which is implemented as msi module. c) Adds a msi handling module for the Broadcom platform devices. Vikas Gupta

[RFC, v0 2/3] vfio/platform: change cleanup order

2020-11-04 Thread Vikas Gupta
In the case of msi, vendor specific msi module may require region access to handle msi cleanup so we need to cleanup region after irq cleanup only. Signed-off-by: Vikas Gupta --- drivers/vfio/platform/vfio_platform_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: MSI/MSIX for VFIO platform

2020-09-14 Thread Vikas Gupta
Hi Eric/Alex, Thanks for your valuable suggestions and get back to you if anything is required. Thanks, Vikas On Fri, Sep 11, 2020 at 7:23 PM Auger Eric wrote: > > Hi Vikas, > > On 9/10/20 6:57 PM, Alex Williamson wrote: > > On Thu, 10 Sep 2020 16:15:27 +0530 > > Vikas G