Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-25 Thread Vinay Simha B N
laurent, Please review or give some feedback. On Thu, Aug 13, 2020 at 9:09 PM Vinay Simha B N wrote: > > laurent, > > The code sequence was a problem. *num_inputs_fmts = > ARRAY_SIZE(tc_lvds_in_bus_fmts); should come first and then allocate > the kcalloc. > &

Re: [PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-23 Thread Vinay Simha B N
Thanks Sam. On Sun, Aug 23, 2020 at 8:35 PM Sam Ravnborg wrote: > > On Sun, Aug 16, 2020 at 11:20:41AM +0530, Vinay Simha BN wrote: > > passing zero to 'PTR_ERR' > > > > Reported-by: kernel test robot > > Signed-off-by: Vinay Simha BN > > Applied to drm-misc-next - thanks. > > Sam > > >

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-13 Thread Vinay Simha B N
IZE(tc_lvds_in_bus_fmts); ++i) input_fmts[i] = tc_lvds_in_bus_fmts[i]; *num_inputs_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); So, internally in the drm pipeline get set the input format based on the output formats? On Wed, Aug 12, 2020 at 10:45 PM Vinay Simha B N wr

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha B N
IZE(tc_lvds_in_bus_fmts); ++i) input_fmts[i] = tc_lvds_in_bus_fmts[i]; *num_input_fmts = ARRAY_SIZE(tc_lvds_in_bus_fmts); On Wed, Aug 12, 2020 at 8:25 PM Vinay Simha B N wrote: > > laurent, > > Video data input format : RGB666 loosely packed 24 bits per pix

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha B N
t chosen? Since dsi->format = MIPI_DSI_FMT_RGB888 is used does it chooses MEDIA_BUS_FMT_RBG888_1X24 by the drm pipeline On Wed, Aug 12, 2020 at 6:48 PM Laurent Pinchart wrote: > > Hi Vinay, > > On Wed, Aug 12, 2020 at 06:07:52PM +0530, Vinay Simha B N wrote: > > On Wed, Aug

Re: [PATCH] drm/bridge/tc358775: Fixes bus formats read

2020-08-12 Thread Vinay Simha B N
laurent, please see the reply inline below. On Wed, Aug 12, 2020 at 3:24 PM Laurent Pinchart wrote: > > Hi Vinay, > > Thank you for the patch. > > On Wed, Aug 12, 2020 at 12:55:50PM +0530, Vinay Simha BN wrote: > > - bus formats read from drm_bridge_state.output_bus_cfg.format > > and .atomic_

Re: [PATCH v8 2/2] display/drm/bridge: TC358775 DSI/LVDS driver

2020-08-12 Thread Vinay Simha B N
sam/laurent, [PATCH] drm/bridge/tc358775: Fixes bus formats read is on top of drm-misc-next. On Wed, Aug 12, 2020 at 7:50 AM Vinay Simha B N wrote: > > Sam, > > I will look into this and send the patch ASAP. > > On Wed, Aug 12, 2020 at 12:47 AM Sam Ravnborg wro

Re: [PATCH v6 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-03 Thread Vinay Simha B N
sam, I will change to "GPL-2.0-only OR BSD-2-Clause", i thought running dt_binding_check is enough for .yaml. On Fri, Jul 3, 2020 at 8:36 PM Sam Ravnborg wrote: > > Hi Vinay. > > On Thu, Jul 02, 2020 at 06:06:33PM +0530, Vinay Simha BN wrote: > > Signed-off-by: Vinay Simha BN > > > > --- > > v1

Re: [PATCH v5 1/2] dt-binding: Add DSI/LVDS TC358775 bridge bindings

2020-07-01 Thread Vinay Simha B N
sam, I rechecked, but did not find any indents are too spaced. This is taken from a working dts tree. I had given two examples for a purpose. One for single lvds configuration single link mode, another is for dual lvds configurations dual-link mode and port mappings. On Wed, Jul 1, 2020 at 2:49

Re: [PATCH v4] display/drm/bridge: TC358775 DSI/LVDS driver

2020-06-29 Thread Vinay Simha B N
Neil, yaml is the v3 version, there was no change , so i had not created v4 for yaml [PATCH v3 2/2] display/drm/bridge: TC358775 DSI/LVDS driver On Mon, Jun 29, 2020 at 2:08 PM Neil Armstrong wrote: > > Hi, > > On 21/06/2020 17:38, Vinay Simha BN wrote: > > Signed-off-by: Vinay Simha BN > > >

Re: [PATCH 1/2] dt-binding: Add DSI/LVDS tc358775 bridge bindings

2020-06-08 Thread Vinay Simha B N
;, 'panel-lvds'] is too long Please suggest how to add the references of panel/lvds.yaml or panel/panel-common.yaml and panel/advantech,idk-2121wr.yaml in my yaml file. On Tue, Mar 17, 2020 at 7:57 PM Sam Ravnborg wrote: > > Hi Vinay. > > On Tue, Mar 17, 2020 at 12:25:42PM

Re: [PATCH] power: smb347-charger: Summit SMB358 charger IC

2017-08-06 Thread Vinay Simha B N
In the config attached. CONFIG_GPIOLIB is not set. please set and recompile fyi, devm_gpiod_get() declared in drivers/gpio/devres.c -> CONFIG_GPIOLIB On Thu, Aug 3, 2017 at 3:28 AM, kbuild test robot wrote: > > Hi Vinay, > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.

Re: [PATCH] drm/msm/hdmi: redefinitions of macros not required

2017-03-21 Thread Vinay Simha B N
hi, Could you please give some feedback or review comments for this patch On 3/14/17, Vinay Simha BN wrote: > 4 macros already defined in hdmi.h, > which is not required to redefine in hdmi_audio.c > > Signed-off-by: Vinay Simha BN > --- > drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 7 --- > 1