xperience is that BQL is not adapted for protocol with small
PDU and also not adapted for interfaces with a high
latency (e.g. USB) by default. But, modifying the dql.min_limit
solves it.
So, I let over people continue the discussion on points 1) and 2)
Yours sincerely,
Vincent
On Wed, 10 Mar 2021 at 06:53, Srikar Dronamraju
wrote:
>
> * Vincent Guittot [2021-03-08 14:52:39]:
>
> > On Fri, 26 Feb 2021 at 17:41, Srikar Dronamraju
> > wrote:
> > >
>
> Thanks Vincent for your review comments.
>
> > > +static int prefe
On Wed. 10 Mar 2021 at 03:11, Vincent MAILHOL
wrote:
>
> On Wed. 10 Mar 2021 at 02:27, Jimmy Assarsson
> wrote:
> >
> > Hi Vincent,
> >
> > On 2021-03-09 13:09, Vincent Mailhol wrote:
> > > This driver supports the ES581.4, ES582.1 and ES58
On Wed. 10 Mar 2021 at 02:27, Jimmy Assarsson wrote:
>
> Hi Vincent,
>
> On 2021-03-09 13:09, Vincent Mailhol wrote:
> > This driver supports the ES581.4, ES582.1 and ES584.1 interfaces from
> > ETAS GmbH (https://www.etas.com/en/products/es58x.php).
> ...
> >
On Wed. 10 Mar 2021 at 00:23, Vincent Mailhol
wrote:
>
> Add a function to set the dynamic queue limit minimum value.
>
> This function is to be used by network drivers which are able to
> prove, at least through empirical tests, that they reach better
> performances with a s
> + return cppc_freq_invariance_exit();
> > +
> > + ret = cppc_get_perf_ctrs(i, _ctrs);
> > + if (ret) {
> > + pr_warn("%s: failed to read perf counters: %d\n",
> > + __func__, ret);
> > + return cppc_freq_invariance_exit();
> > + }
> > +
> > + cppc_fi->prev_perf_fb_ctrs = fb_ctrs;
> > + }
> > +
> > + /* Register for freq-invariance */
> > + topology_set_scale_freq_source(_sftd, cpu_present_mask);
> > +}
>
> After another very quick round of testing:
>
> Reviewed-by: Ionela Voinescu
> Tested-by: Ionela Voinescu
>
> I did not get the chance to test on ThunderX2 yet, but if you are happy
> with your testing on it, I won't delay this any further.
I have just run some functional tests on thx2 with rt-app: I have run
a periodic task (6ms running / 30ms periods) at different frequencies
(2.5Ghz, 2Ghz, 1.5Ghz, 1.333Ghz, 1Ghz) and the PELT signals stays the
same for all frequencies.
Tested-by: Vincent Guittot
>
> Thanks,
> Ionela.
list:
https://lore.kernel.org/linux-can/20210309125708.ei75tr5vp2san...@pengutronix.de/
Thank you for your comments.
Yours sincerely,
Vincent
Vincent Mailhol (1):
dql: add dql_set_min_limit()
include/linux/dynamic_queue_limits.h | 3 +++
lib/dynamic_queue_limits.c | 8
2 files
Add a function to set the dynamic queue limit minimum value.
This function is to be used by network drivers which are able to
prove, at least through empirical tests, that they reach better
performances with a specific predefined dql.min_limit value.
Signed-off-by: Vincent Mailhol
---
include
On Tue, Mar 09, 2021 at 01:05:11AM +0100, ronnie sahlberg wrote:
> On Sun, Mar 7, 2021 at 8:52 PM Shyam Prasad N via samba-technical
> wrote:
> > The reason for rejecting the request maybe a number of things like:
> > corrupted request, stale request (for some old session), or for a
> > wrong
in that branch to compile.
Crossing fingers, hoping that we are now close to a release.
Thank you in advance for your review and for your time!
Yours sincerely,
Vincent
Vincent Mailhol (1):
can: usb: etas_es58X: add support for ETAS ES58X CAN USB interfaces
drivers/net/can/usb/Kconfig
USERS throughput 4420.64553.3 (3.00%)4405.8
> (-0.33%)
> sys/user:time 79.13/20.32 78.76/21.01 79/20
>
> Cc: LKML
> Cc: Michael Ellerman
> Cc: Michael Neuling
> Cc: Gautham R Shenoy
> Cc: Parth Shah
> Cc: Ingo M
Hi Aubrey,
On Thu, 4 Mar 2021 at 14:51, Li, Aubrey wrote:
>
> Hi Peter,
>
> On 2020/12/11 23:07, Vincent Guittot wrote:
> > On Thu, 10 Dec 2020 at 02:44, Aubrey Li wrote:
> >>
> >> Add idle cpumask to track idle cpus in sched domain. Every time
> >&
On Tue, 2 Mar 2021 at 00:08, Barry Song wrote:
>
> ARM64 chip Kunpeng 920 has 6 or 8 clusters in each NUMA node, and each
> cluster has 4 cpus. All clusters share L3 cache data, but each cluster
> has local L3 tag. On the other hand, each clusters will share some
> internal system bus. This means
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 0826530de3cbdc89e60a89e86def94a5f0fc81ca
Gitweb:
https://git.kernel.org/tip/0826530de3cbdc89e60a89e86def94a5f0fc81ca
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:01 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 64f84f273592d17dcdca20244168ad9f525a39c3
Gitweb:
https://git.kernel.org/tip/64f84f273592d17dcdca20244168ad9f525a39c3
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:03 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: ab2dde5e98db23387147fb4e7a52b6cf8141cdb3
Gitweb:
https://git.kernel.org/tip/ab2dde5e98db23387147fb4e7a52b6cf8141cdb3
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:02 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 6553fc18179113a11835d5fde1735259f8943a55
Gitweb:
https://git.kernel.org/tip/6553fc18179113a11835d5fde1735259f8943a55
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:05 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c6f886546cb8a38617cdbe755fe50d3acd2463e4
Gitweb:
https://git.kernel.org/tip/c6f886546cb8a38617cdbe755fe50d3acd2463e4
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:06 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 7a82e5f52a3506bc35a4dc04d53ad2c9daf82e7f
Gitweb:
https://git.kernel.org/tip/7a82e5f52a3506bc35a4dc04d53ad2c9daf82e7f
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:04 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 3ae70c251f344976428d1f6ee61ea7b4e170fec3
Gitweb:
https://git.kernel.org/tip/3ae70c251f344976428d1f6ee61ea7b4e170fec3
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:04
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 453e41085183980087f8a80dada523caf1131c3c
Gitweb:
https://git.kernel.org/tip/453e41085183980087f8a80dada523caf1131c3c
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:06
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 62f250694092dd5fef9900dc3126f07110bf9d48
Gitweb:
https://git.kernel.org/tip/62f250694092dd5fef9900dc3126f07110bf9d48
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:05
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: b89997aa88f0b07d8a6414c908af75062103b8c9
Gitweb:
https://git.kernel.org/tip/b89997aa88f0b07d8a6414c908af75062103b8c9
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 16:58:20
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 736cc6b31102236a55470c72523ed0a65eb3f804
Gitweb:
https://git.kernel.org/tip/736cc6b31102236a55470c72523ed0a65eb3f804
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 08:36:12
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 39b6a429c30482c349f1bb3746470fe473cbdb0f
Gitweb:
https://git.kernel.org/tip/39b6a429c30482c349f1bb3746470fe473cbdb0f
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:07 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 0372e1cf70c28de6babcba38ef97b6ae3400b101
Gitweb:
https://git.kernel.org/tip/0372e1cf70c28de6babcba38ef97b6ae3400b101
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 08:36:11
Committer
__must_be_array, offsetof, sizeof_field and __stringify are all
preprocessor macros and do not evaluate their arguments. As such, it
is safe not to warn when arguments are being reused in those four
sub-expressions.
Exclude those so that they can pass checkpatch.
Signed-off-by: Vincent Mailhol
This adds dts bindings for the mstar msg2638 touchscreen.
Reviewed-by: Linus Walleij
Signed-off-by: Vincent Knecht
---
Changed in v6:
- change touchscreen-size-x/y values in example section to reflect
scaling removal in driver (Dmitry)
- add Linus W. Reviewed-by
Changed in v5: nothing
Changed
Add support for the msg2638 touchscreen IC from MStar.
Firmware handling, wakeup gestures and other specialties are not supported.
This driver reuses zinitix.c structure, while the checksum and irq handler
functions are based on out-of-tree driver for Alcatel Idol 3 (4.7").
Signed-off-by: Vi
ignore as per the spec.
Signed-off-by: Vincent Whitchurch
---
fs/cifs/smb2misc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c
index 60d4bd1eae2b..3ea3bda64083 100644
--- a/fs/cifs/smb2misc.c
+++ b/fs/cifs/smb2
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 63dbe695827f0f612a0cdbc82a43a974bcd536cd
Gitweb:
https://git.kernel.org/tip/63dbe695827f0f612a0cdbc82a43a974bcd536cd
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:06 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 21c5d27a4c5d9fddb2c35ccdd5cddc11b75f753d
Gitweb:
https://git.kernel.org/tip/21c5d27a4c5d9fddb2c35ccdd5cddc11b75f753d
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:03 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 780eec5b50930b34e2f096b4dce5368d90497b55
Gitweb:
https://git.kernel.org/tip/780eec5b50930b34e2f096b4dce5368d90497b55
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:07 +01:00
On Mon, Mar 01, 2021 at 06:21:23PM +0100, Peter Zijlstra wrote:
> On Mon, Mar 01, 2021 at 05:34:09PM +0100, Dietmar Eggemann wrote:
> > On 26/02/2021 09:41, Peter Zijlstra wrote:
> > > On Thu, Feb 25, 2021 at 04:58:20PM +, Vincent Donnefort wrote:
> > >
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 1690607f4232c120a2d6ff1f9d0766551d9609f1
Gitweb:
https://git.kernel.org/tip/1690607f4232c120a2d6ff1f9d0766551d9609f1
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:01 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8b89220650146d59e9a8af2e5f12fc582539609e
Gitweb:
https://git.kernel.org/tip/8b89220650146d59e9a8af2e5f12fc582539609e
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:06
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: b641a8b52c6162172ca31590510569eaadcd5e49
Gitweb:
https://git.kernel.org/tip/b641a8b52c6162172ca31590510569eaadcd5e49
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 08:36:12
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 2aa7f2f6d1e4308b81bef079091561445b9cb949
Gitweb:
https://git.kernel.org/tip/2aa7f2f6d1e4308b81bef079091561445b9cb949
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:04 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 6d06c515e9151dc858e391bd6bebce0b684eec4f
Gitweb:
https://git.kernel.org/tip/6d06c515e9151dc858e391bd6bebce0b684eec4f
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:04
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 9357e217ba642b39ce89f9cd5b5f3e5a21712283
Gitweb:
https://git.kernel.org/tip/9357e217ba642b39ce89f9cd5b5f3e5a21712283
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 16:58:20
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 5e7f238920174248049ff840eff43c94f3a2e67e
Gitweb:
https://git.kernel.org/tip/5e7f238920174248049ff840eff43c94f3a2e67e
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:05
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 053192dea58da994fb3dd7ad235440accf292a08
Gitweb:
https://git.kernel.org/tip/053192dea58da994fb3dd7ad235440accf292a08
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:05 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: f2c0af1dabdae4674fb7ddba0ac88ca78d0fe675
Gitweb:
https://git.kernel.org/tip/f2c0af1dabdae4674fb7ddba0ac88ca78d0fe675
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:02 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 2d120f71df4baeb7694f513c86fe6f85940f6f76
Gitweb:
https://git.kernel.org/tip/2d120f71df4baeb7694f513c86fe6f85940f6f76
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 08:36:11
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8af3f0fbfbaa3b78bb1fc577ee42c3228f3cc822
Gitweb:
https://git.kernel.org/tip/8af3f0fbfbaa3b78bb1fc577ee42c3228f3cc822
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:03 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 81df323258719a0194fadbf4aa93e213a552e460
Gitweb:
https://git.kernel.org/tip/81df323258719a0194fadbf4aa93e213a552e460
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:02 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8af20c5fe756a9ff556c9b520201b2d158874481
Gitweb:
https://git.kernel.org/tip/8af20c5fe756a9ff556c9b520201b2d158874481
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 08:36:11
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 839ffb99d94f930fecbdee2fdfb883b10c30326b
Gitweb:
https://git.kernel.org/tip/839ffb99d94f930fecbdee2fdfb883b10c30326b
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:07 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c91b0dcb6482096e7af4adbf39cfe3296af74a78
Gitweb:
https://git.kernel.org/tip/c91b0dcb6482096e7af4adbf39cfe3296af74a78
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:06
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: c0d2f3b54ed88ce1079f8ffb094205d3f578a9bb
Gitweb:
https://git.kernel.org/tip/c0d2f3b54ed88ce1079f8ffb094205d3f578a9bb
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:04 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 78ca1ab2718a5518171f2e7d0afad0b9752c4453
Gitweb:
https://git.kernel.org/tip/78ca1ab2718a5518171f2e7d0afad0b9752c4453
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 16:58:20
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 4537b36ee8a290376174b297d6812cba1375ea79
Gitweb:
https://git.kernel.org/tip/4537b36ee8a290376174b297d6812cba1375ea79
Author:Vincent Donnefort
AuthorDate:Thu, 25 Feb 2021 08:36:12
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 06a35afe89800789fc47ca5c41fbe435cc77d8e0
Gitweb:
https://git.kernel.org/tip/06a35afe89800789fc47ca5c41fbe435cc77d8e0
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:01 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: e58422d9789d5c61bb039e40e4e10781d8d43ac3
Gitweb:
https://git.kernel.org/tip/e58422d9789d5c61bb039e40e4e10781d8d43ac3
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:04
Committer
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 1705e3b449f62d957e897239ef6c67ca574acfc6
Gitweb:
https://git.kernel.org/tip/1705e3b449f62d957e897239ef6c67ca574acfc6
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:06 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 0c067f38e1b9640e9121fb7e0bb38fa8f867a248
Gitweb:
https://git.kernel.org/tip/0c067f38e1b9640e9121fb7e0bb38fa8f867a248
Author:Vincent Guittot
AuthorDate:Wed, 24 Feb 2021 14:30:05 +01:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 92e1512c5329c7675b66163d357d00d95107fa03
Gitweb:
https://git.kernel.org/tip/92e1512c5329c7675b66163d357d00d95107fa03
Author:Vincent Donnefort
AuthorDate:Tue, 16 Feb 2021 10:35:05
Committer
On Thu, 25 Feb 2021 at 17:58, Vincent Donnefort
wrote:
>
> Being called for each dequeue, util_est reduces the number of its updates
> by filtering out when the EWMA signal is different from the task util_avg
> by less than 1%. It is a problem for a sudden util_avg ramp-up. Due to
/hikey960.
Signed-off-by: Vincent Donnefort
Reviewed-by: Dietmar Eggemann
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9e4104ae39ae..214e02862994 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -3966,24 +3966,27 @@ static inline void util_est_dequeue(struct cfs_rq
*cfs_rq
On Thu, Feb 25, 2021 at 12:45:06PM +0100, Dietmar Eggemann wrote:
> On 25/02/2021 09:36, vincent.donnef...@arm.com wrote:
> > From: Vincent Donnefort
>
> [...]
>
> > cpu_util_next() estimates the CPU utilization that would happen if the
> > task was placed on dst_
On Thu, Feb 25, 2021 at 04:26:50PM +0100, Vincent Guittot wrote:
> On Mon, 22 Feb 2021 at 10:24, Vincent Donnefort
> wrote:
> >
> > On Fri, Feb 19, 2021 at 11:48:28AM +0100, Vincent Guittot wrote:
> > > On Tue, 16 Feb 2021 at 17:39, wrote:
> > &g
oing a load balance before a offline tasks to run.
>
> Signed-off-by: Chen Xiaoguang
> Signed-off-by: Chen He
Reviewed-by: Vincent Guittot
Thanks
> ---
> v1 -> v2:
> - Add checking in balance_fair
> - Remove task state checking in pick_next_task_fair
&
On Mon, 22 Feb 2021 at 10:24, Vincent Donnefort
wrote:
>
> On Fri, Feb 19, 2021 at 11:48:28AM +0100, Vincent Guittot wrote:
> > On Tue, 16 Feb 2021 at 17:39, wrote:
> > >
> > > From: Vincent Donnefort
> > >
> > > Being called for each deq
From: Vincent Donnefort
The sub_positive local version is saving an explicit load-store and is
enough for the cpu_util_next() usage.
Signed-off-by: Vincent Donnefort
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 146ac9fec4b6..1364f8b95214 100644
--- a/kernel/sched/fair.c
+++ b
From: Vincent Donnefort
find_energy_efficient_cpu() (feec()) computes for each perf_domain (pd) an
energy delta as follows:
feec(task)
for_each_pd
base_energy = compute_energy(task, -1, pd)
-> for_each_cpu(pd)
-> cpu_util_next(cpu, task, -1)
energy
From: Vincent Donnefort
Changelog since v1:
- Fix the issue in compute_energy(), as a change in cpu_util_next() would
break the OPP selection estimation.
- Separate patch for lsub_positive usage in cpu_util_next()
Vincent Donnefort (2):
sched/fair: Fix task utilization accountability
Hi Valentin,
On Wed, 24 Feb 2021 at 19:46, Valentin Schneider
wrote:
>
> On 24/02/21 14:30, Vincent Guittot wrote:
> > Joel reported long preempt and irq off sequence in newidle_balance because
> > of a large number of CPU cgroups in use and having to be updated. This
On Wed, 24 Feb 2021 at 18:41, Peter Zijlstra wrote:
>
> On Wed, Feb 24, 2021 at 04:57:15PM +0100, Vincent Guittot wrote:
> > On Wed, 24 Feb 2021 at 16:54, Peter Zijlstra wrote:
> > >
> > > On Wed, Feb 24, 2021 at 02:30:00PM +0100, Vincent Guittot wrote:
> > &g
On Wed, 24 Feb 2021 at 16:54, Peter Zijlstra wrote:
>
> On Wed, Feb 24, 2021 at 02:30:00PM +0100, Vincent Guittot wrote:
> > Joel reported long preempt and irq off sequence in newidle_balance because
> > of a large number of CPU cgroups in use and having to be updated. This
Instead of waking up a random and already idle CPU, we can take advantage
of this_cpu being about to enter idle to run the ILB and update the
blocked load.
Signed-off-by: Vincent Guittot
---
kernel/sched/core.c | 2 +-
kernel/sched/fair.c | 24 +---
kernel/sched/idle.c
Start to update last_blocked_load_update_tick to reduce the possibility
of another cpu starting the update one more time
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched
Reorder the tests and skip useless ones when no load balance has been
performed and rq lock has not been released.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
update. We don't need a special case for handling the update of
nohz.next_balance for this_cpu anymore because it is now handled by the
loop like others.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 32 +++-
1 file changed, 7 insertions(+), 25 deletions
idle load balance is the only user of update_nohz_stats and doesn't use
force parameter. Remove it
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e23709f6854b
the update from newidle_balance and trigger a normal ILB that
will take care of the update instead.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 33 +
1 file changed, 5 insertions(+), 28 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
The return of _nohz_idle_balance() is not used anymore so we can remove
it
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0d45b7716384..e23709f6854b 100644
ave been removed yet from previous
idle phase.
Vincent Guittot (7):
sched/fair: remove update of blocked load from newidle_balance
sched/fair: remove unused return of _nohz_idle_balance
sched/fair: remove unused parameter of update_nohz_stats
sched/fair: merge for each idle cpu loop of ILB
On Tue, 23 Feb 2021 at 06:41, Li, Aubrey wrote:
>
> Hi Vincent,
>
> Sorry for the delay, I just returned from Chinese New Year holiday.
>
> On 2021/1/25 22:51, Vincent Guittot wrote:
> > On Mon, 25 Jan 2021 at 15:00, Li, Aubrey wrote:
> >>
> >>
On Tue, 23 Feb 2021 at 13:03, Valentin Schneider
wrote:
>
>
> +Vincent
>
> On 22/02/21 09:12, syzbot wrote:
> > syzbot has found a reproducer for the following issue on:
> >
> > HEAD commit:31caf8b2 Merge branch 'linus' of git://git.kernel.org/pub/..
> &g
Le samedi 20 février 2021 à 15:23 -0800, Dmitry Torokhov a écrit :
> Hi Vincent,
Hi Dmitry, thank you for the review !
> On Wed, Feb 10, 2021 at 06:33:52PM +0100, Vincent Knecht wrote:
> > +
> > + for (i = 0; i < MAX_SUPPORTED_FINGER_NUM; i++) {
> > +
e
> > frequency estimation right.
>
> Totally untested, but I think in principle you would like something like
> the snippet below. Would that work?
You preempted my previous email :)
Yeah, that looks like what we want, I'll give a try.
Thanks,
--
Vincent.
>
> diff --git
On Mon, Feb 22, 2021 at 03:58:56PM +, Quentin Perret wrote:
> On Monday 22 Feb 2021 at 15:01:51 (+), Vincent Donnefort wrote:
> > You mean that it could lead to a wrong frequency estimation when doing
> > freq = map_util_freq() in em_cpu_energy()?
>
> I'm
On Mon, Feb 22, 2021 at 12:23:04PM +, Quentin Perret wrote:
> On Monday 22 Feb 2021 at 11:36:03 (+), Vincent Donnefort wrote:
> > Here's with real life numbers.
> >
> > The task: util_avg=3 (1) util_est=11 (2)
> >
> > pd0 (CPU-0, CPU-1, CPU-2)
> &
Hi Quentin,
On Mon, Feb 22, 2021 at 10:11:03AM +, Quentin Perret wrote:
> Hey Vincent,
>
> On Monday 22 Feb 2021 at 09:54:01 (+), vincent.donnef...@arm.com wrote:
> > From: Vincent Donnefort
> >
> > Currently, cpu_util_next() estimates the CPU utilization
From: Vincent Donnefort
Currently, cpu_util_next() estimates the CPU utilization as follows:
max(cpu_util + task_util,
cpu_util_est + task_util_est)
This is an issue when making a comparison between CPUs, as the task
contribution can be either:
(1) task_util_est, on a mostly idle
On Fri, Feb 19, 2021 at 11:19:05AM +0100, Dietmar Eggemann wrote:
> On 16/02/2021 17:39, vincent.donnef...@arm.com wrote:
> > From: Vincent Donnefort
> >
> > Being called for each dequeue, util_est reduces the number of its updates
> > by filtering out when the EW
On Fri, Feb 19, 2021 at 11:48:28AM +0100, Vincent Guittot wrote:
> On Tue, 16 Feb 2021 at 17:39, wrote:
> >
> > From: Vincent Donnefort
> >
> > Being called for each dequeue, util_est reduces the number of its updates
> > by filtering out when the EWMA signal is
On Tue, 16 Feb 2021 at 17:39, wrote:
>
> From: Vincent Donnefort
>
> Being called for each dequeue, util_est reduces the number of its updates
> by filtering out when the EWMA signal is different from the task util_avg
> by less than 1%. It is a problem for a sudden uti
On Wed, 17 Feb 2021 at 12:51, Valentin Schneider
wrote:
>
> On 15/02/21 16:02, Vincent Guittot wrote:
> > On Fri, 12 Feb 2021 at 20:19, Valentin Schneider
> > wrote:
> >> I don't think there is anything inherently wrong with it - the
> >> nohz_idle_balanc
rn(>client->dev, "debug: does not have \\n at end");
dev_warn(>client->dev, "debug: has \\n\\n at end\n\n");
dev_warn(>client->dev, "debug: hello");
dev_warn(>client->dev, "debug: world");
[ 99.069100] idtcm 15-005b: debug: has \n at end
[ 99.073623] idtcm 15-005b: debug: does not have \n at end
[ 99.079017] idtcm 15-005b: debug: has \n\n at end
[ 99.079017]
[ 99.085194] idtcm 15-005b: debug: hello
[ 99.089025] idtcm 15-005b: debug: world
>> +
>> +if (wait_for_sys_apll_dpll_lock(idtcm))
>> +dev_warn(>client->dev,
>> + "Continuing while SYS APLL/DPLL is not locked");
>
>And here.
\n not needed.
Thank-you for the comments, helps make cleaner code.
Vincent
From: Vincent Donnefort
Being called for each dequeue, util_est reduces the number of its updates
by filtering out when the EWMA signal is different from the task util_avg
by less than 1%. It is a problem for a sudden util_avg ramp-up. Due to the
decay from a previous high util_avg, EWMA might
This adds dts bindings for the mstar msg2638 touchscreen.
Signed-off-by: Vincent Knecht
---
Changed in v5: nothing
Changed in v4:
- don't use wildcards in compatible strings (Rob H)
- rename from msg26xx to msg2638
- rename example pinctrl-0 to _int_reset_default for consistency
Changed in v3
Add support for the msg2638 touchscreen IC from MStar.
This driver reuses zinitix.c structure, while the checksum and irq handler
functions are based on out-of-tree driver for Alcatel Idol 3 (4.7").
Signed-off-by: Vincent Knecht
---
Changed in v5:
- use gpiod_set_value_cansleep() (Step
From: Vincent Donnefort
Factorizing and unifying cpuhp callback range invocations, especially for
the hotunplug path, where two different ways of decrementing were used. The
first one, decrements before the callback is called:
cpuhp_thread_fun()
state = st->state;
st->
From: Vincent Donnefort
The atomic states (between CPUHP_AP_IDLE_DEAD and CPUHP_AP_ONLINE) are
triggered by the CPUHP_BRINGUP_CPU step. If the latter fails, no atomic
state can be rolled back.
DEAD callbacks too can't fail and disallow recovery. As a consequence,
during hotunplug, the fail
From: Vincent Donnefort
This patch-set intends to unify steps call throughout hotplug and
hotunplug.
It also improves the "fail" interface, which can now be reset and will
reject states for which a failure can't be recovered.
v2:
- Reject all DEAD steps in the fail interface.
-
From: Vincent Donnefort
Currently, the only way of resetting the fail injection is to trigger a
hotplug, hotunplug or both. This is rather annoying for testing
and, as the default value for this file is -1, it seems pretty natural to
let a user write it.
Signed-off-by: Vincent Donnefort
diff
On Fri, 12 Feb 2021 at 20:19, Valentin Schneider
wrote:
>
> On 12/02/21 15:17, Vincent Guittot wrote:
> > Instead of waking up a random and already idle CPU, we can take advantage
> > of this_cpu being about to enter idle to run the ILB and update the
> > blocked
e this removal is unrelated to the patch subject, and so it
>deserves its own small patch.
Ok, will separate into separate patch for V2.
Vincent
Start to update last_blocked_load_update_tick to reduce the possibility
of another cpu starting the update one more time
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched
201 - 300 of 6120 matches
Mail list logo
